Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-25 Thread Gonglei (Arei)
Ping, please. Any comments? Thanks. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, August 21, 2014 10:11 AM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); pbonz...@redhat.com; > afaer...@suse.de; imamm...@redhat.com; peter.cros

Re: [Qemu-devel] [PATCH v2 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs

2014-08-25 Thread Peter Crosthwaite
Ping! Andreas, are you able to take this? Regards, Peter On Thu, Aug 21, 2014 at 7:23 PM, Alexander Graf wrote: > > > On 15.08.14 07:29, Peter Crosthwaite wrote: >> Hi All, >> >> So phase one was the QOMification of qemu_irq. This is the next step. >> We start to setup GPIOs as proper QOM objec

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its corresponding ioapic->irr bit always set

2014-08-25 Thread Zhang Haoyu
>> Hi, all >> >> I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC >> interrupt storm, >> because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always true >> in __kvm_ioapic_update_eoi(). >> >> Any ideas? > >We meet this several times: search the autoneg patches

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its corresponding ioapic->irr bit always set

2014-08-25 Thread Jason Wang
On 08/25/2014 03:17 PM, Zhang Haoyu wrote: >>> Hi, all >>> >>> I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC >>> interrupt storm, >>> because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always true >>> in __kvm_ioapic_update_eoi(). >>> >>> Any ideas? >> We

Re: [Qemu-devel] [bisected] VNC server can't get all sent chars correctly

2014-08-25 Thread Markus Armbruster
Michael Tokarev writes: > There's a bug filed against debian qemu package, there: > > http://bugs.debian.org/758881 > > which says about problems sending keypress events over VNC to > a qemu guest, -- some keypresses gets lost, at least. > > The bisection between qemu 2.0 and 2.1 leads to this c

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its corresponding ioapic->irr bit always set

2014-08-25 Thread Jason Wang
On 08/25/2014 03:17 PM, Zhang Haoyu wrote: >>> Hi, all >>> >> >>> >> I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC >>> >> interrupt storm, >>> >> because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always >>> >> true in __kvm_ioapic_update_eoi(). >>> >> >>>

Re: [Qemu-devel] [bisected] VNC server can't get all sent chars correctly

2014-08-25 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Monday, August 25, 2014 3:30 PM > To: Michael Tokarev > Cc: qemu-devel; Gonglei (Arei); Gabriele Giacone; Gerd Hoffmann; > 758...@bugs.debian.org > Subject: Re: [Qemu-devel] [bisected] VNC server can't get all sent chars > correctly > >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations)

2014-08-25 Thread Markus Armbruster
Stefan Weil writes: > Am 24.08.2014 11:21, schrieb Michael Tokarev: >> Applied to -trivial, thank you! >> >> But I've a small concern - should we really do this on "external" sources, >> and divirge from upstream needlessly? >> >> Thanks, >> >> /mjt > > In general, I agree. In this case, the code

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-25 Thread Markus Armbruster
Dmitry Fleytman writes: > On Aug 24, 2014, at 16:10 PM, Michael Tokarev wrote: > >> 24.08.2014 16:28, Dmitry Fleytman wrote: >> >>> Hi Michael, >>> >>> I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me. >> >> Maybe you can add yourself to MAINTAINERS file as well? :)

Re: [Qemu-devel] [PATCH v2 3/4] ioh3420: Remove obsoleted, unused ioh3420_init function

2014-08-25 Thread Gonglei (Arei)
> -Original Message- > From: Knut Omang [mailto:knut.om...@oracle.com] > Sent: Sunday, August 24, 2014 9:32 PM > To: qemu-devel@nongnu.org > Cc: Michael S. Tsirkin; Alexey Kardashevskiy; Juan Quintela; Marcel Apfelbaum; > Markus Armbruster; Paolo Bonzini; Gonglei (Arei); Igor Mammedov; Knut

[Qemu-devel] reporting 9pfs init errors

2014-08-25 Thread Michael Tokarev
Hello. I've a bugreport against debian qemu package which basically states that 9pfs does not work. After some digging it turned out to be error reporting problem, plain and simple. The error message is: qemu-system-x86_64: -device virtio-9p-pci,id=fs0,fsdev=fsdev-fs0,mount_tag=pwk,bus=pci.0,a

[Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- hw/pci-bridge/ioh3420.h | 4 1 file changed, 4 deletions(-) diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h index 7776e5b..ea423cb 100644 --- a/hw/pci-bridge/ioh3420.h +++ b/hw/pci-bridge/ioh3420.h @@ -3,8 +3,4 @@ #include "hw/pci

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-25 Thread Markus Armbruster
Lluís Vilanova writes: > Eric Blake writes: > >> On 08/21/2014 11:52 AM, Lluís Vilanova wrote: >>> Also removes old "trace-event", "trace-file" and "info trace-events" HMP >>> commands. >>> >>> Signed-off-by: Lluís Vilanova >>> --- >>> monitor.c | 24 +++- >>> qapi-schema

Re: [Qemu-devel] [PATCH 1/4] hd-geometry.c: Integrate HDIO_GETGEO in guessing for target-s390x

2014-08-25 Thread Christian Borntraeger
On 20/08/14 15:10, Paolo Bonzini wrote: > Il 20/08/2014 11:35, Christian Borntraeger ha scritto: >> On 20/08/14 10:19, Paolo Bonzini wrote: >>> Il 29/07/2014 14:27, Ekaterina Tumanova ha scritto: The new HDIO_GETGEO logic is required for two use cases: a) Support for geometries of Direct

Re: [Qemu-devel] [PATCH] acpi-build: Set FORCE_APIC_CLUSTER_MODEL bit of FADT flags

2014-08-25 Thread zhanghailiang
Hi, Ping... Are there any news about this patch? Thanks, zhanghailiang If we start Windows 2008 R2 DataCenter with number of cpu less than 8, The system will use APIC Flat Logical destination mode as default configuration, Which has an upper limit of 8 CPUs. The fault is that VM can not show

Re: [Qemu-devel] [question] e1000 interrupt storm happened becauseof its correspondingioapic->irr bit always set

2014-08-25 Thread Zhang Haoyu
Hi, all I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC interrupt storm, because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always true in __kvm_ioapic_update_eoi(). Any ideas? >>> We meet this several times: search th

[Qemu-devel] [PATCH v6 0/7] Virtio PCI libqos driver

2014-08-25 Thread Marc Marí
v3: Solved problems, added indirect descriptor support and test for configuration changes v4: Solved bugs, changed some interfaces, added MSI-X and event_idx support. v5: Simplified virtio-blk-test, solved bugs, avoid patches already merged. v6: Solve bugs (qpci_iomap changed prototype) Marc M

[Qemu-devel] [PATCH v6 2/7] tests: Add virtio device initialization

2014-08-25 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 67 + tests/libqos/virtio-pci.h | 18 test

[Qemu-devel] [PATCH v6 1/7] tests: Functions bus_foreach and device_find from libqos virtio API

2014-08-25 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Reviewed-by: Stefan Hajnoczi Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos/v

[Qemu-devel] [PATCH v6 3/7] libqos: Added basic virtqueue support to virtio implementation

2014-08-25 Thread Marc Marí
Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 82 + tests/libqos/virtio-pci.h |2 + tests/libqos/virtio.c | 100

[Qemu-devel] [PATCH v6 4/7] libqos: Added indirect descriptor support to virtio implementation

2014-08-25 Thread Marc Marí
Add functions necessary for working with indirect descriptors. Add test using new functions. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c | 10 + tests/libqos/virtio.c | 64 + tests/libqos/virtio.h | 22 +- tests/virtio-blk-test.c

[Qemu-devel] [PATCH v6 5/7] libqos: Added test case for configuration changes in virtio-blk test

2014-08-25 Thread Marc Marí
Signed-off-by: Marc Marí --- tests/virtio-blk-test.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c index 95e6861..07ae754 100644 --- a/tests/virtio-blk-test.c +++ b/tests/virtio-blk-test.c @@ -359,6 +359

[Qemu-devel] [PATCH v6 7/7] libqos: Added EVENT_IDX support

2014-08-25 Thread Marc Marí
Added avail_event and NO_NOTIFY check before notifying. Added used_event setting. Signed-off-by: Marc Marí --- tests/libqos/virtio-pci.c |1 + tests/libqos/virtio.c | 27 +- tests/libqos/virtio.h |5 ++ tests/virtio-blk-test.c | 124 ++

[Qemu-devel] [PATCH v6 6/7] libqos: Added MSI-X support

2014-08-25 Thread Marc Marí
Added MSI-X support for qtest PCI. Added MSI-X support for virtio-pci. Added MSI-X test case in virtio-blk-test. Signed-off-by: Marc Marí --- tests/libqos/pci.c| 111 +++- tests/libqos/pci.h| 10 +++ tests/libqos/virtio-pci.c | 142

[Qemu-devel] [PATCH] device_tree.c: redirect load_device_tree err message to stderr

2014-08-25 Thread john.liuli
From: Li Liu Signed-off-by: Li Liu --- device_tree.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/device_tree.c b/device_tree.c index ca83504..ccdb039 100644 --- a/device_tree.c +++ b/device_tree.c @@ -79,7 +79,7 @@ void *load_device_tree(const char *filename_p

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-25 Thread Knut Omang
On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > If ARI Forwarding is disabled, according to PCIe spec > section 7.3.1, only slot 0 with the device attached to > logic bus representing the link from downstream > ports and root ports. > > So, adding check for

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-08-25 Thread Benoît Canet
On Mon, Aug 25, 2014 at 02:04:24PM +0800, Fam Zheng wrote: > On Fri, 08/22 18:11, Benoît Canet wrote: > > Since the block layer code is starting to modify the BDS graph right in the > > middle of BDS chains (block-mirror's replace parameter for example) QEMU > > needs > > to properly block and unb

Re: [Qemu-devel] [PATCH] qemu-iotests: stop using /tmp directly

2014-08-25 Thread Benoît Canet
The Sunday 24 Aug 2014 à 21:54:51 (+0200), Peter Wu wrote : > On Friday 22 August 2014 20:58:34 Benoît Canet wrote: > > The Friday 22 Aug 2014 à 13:25:43 (+0200), Peter Wu wrote : > > > Before this patch you could not run multiple tests concurrently as they > > > might clobber each other test files

[Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Riku Voipio
Hi, After weekend, I think the solution to using the P flag is to go back to Joakim's original patch: http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg02269.html With this, we get: If you continue to use qemu-x-static in your binfmt_misc registration, nothing changes - both old and new q

Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding

2014-08-25 Thread Knut Omang
On Mon, 2014-08-25 at 06:09 +, Gonglei (Arei) wrote: > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Subject: Re: [PATCH v2 4/4] ioh3420: Enable ARI forwarding > > > > On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote: > > > Signed-off-by: Knut Omang > > > > BTW pcie_cap_i

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Alexander Graf
On 25.08.14 11:09, Riku Voipio wrote: > Hi, > > After weekend, I think the solution to using the P flag is to > go back to Joakim's original patch: > > http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg02269.html > > With this, we get: > > If you continue to use qemu-x-static in your bi

Re: [Qemu-devel] [PATCH v2 3/4] ioh3420: Remove obsoleted, unused ioh3420_init function

2014-08-25 Thread Knut Omang
On Mon, 2014-08-25 at 07:47 +, Gonglei (Arei) wrote: > > -Original Message- > > From: Knut Omang [mailto:knut.om...@oracle.com] > > Sent: Sunday, August 24, 2014 9:32 PM > > To: qemu-devel@nongnu.org > > Cc: Michael S. Tsirkin; Alexey Kardashevskiy; Juan Quintela; Marcel > > Apfelbaum;

Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread Knut Omang
On Mon, 2014-08-25 at 15:54 +0800, arei.gong...@huawei.com wrote: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/pci-bridge/ioh3420.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > index 7776e5b..ea423cb 100644 > --- a/hw/

Re: [Qemu-devel] [PATCH 01/15] hw/intc/arm_gic: Request FIQ sources

2014-08-25 Thread Sergey Fedorov
On 22.08.2014 14:29, Fabian Aggeler wrote: > Preparing for FIQ lines from GIC to CPUs, which is needed for GIC > Security Extensions. > > Signed-off-by: Fabian Aggeler > --- > hw/intc/arm_gic.c| 3 +++ > include/hw/intc/arm_gic_common.h | 1 + > 2 files changed, 4 insertions(+) >

Re: [Qemu-devel] [PATCH 03/15] hw/intc/arm_gic: Add Security Extensions property

2014-08-25 Thread Sergey Fedorov
On 22.08.2014 14:29, Fabian Aggeler wrote: > The existing implementation does not support Security Extensions mentioned > in the GICv1 and GICv2 architecture specification. Security Extensions are > not available on all GICs. This property makes it possible to enable Security > Extensions. > > It

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-25 Thread Gonglei (Arei)
> -Original Message- > From: Knut Omang [mailto:knut.om...@oracle.com] > Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports > and > downstream ports > > On Thu, 2014-08-21 at 17:47 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > If ARI Forwarding

Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations]

2014-08-25 Thread Paolo Bonzini
Il 24/08/2014 21:31, Peter Lieven ha scritto: > Am 24.08.2014 um 18:30 schrieb Paolo Bonzini: >> Il 22/08/2014 10:42, Kevin Wolf ha scritto: Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or 4K depending on the blocksize. >>> I don't remember the details, but

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-08-25 Thread Fam Zheng
On Mon, 08/25 09:06, Benoît Canet wrote: > On Mon, Aug 25, 2014 at 02:04:24PM +0800, Fam Zheng wrote: > > On Fri, 08/22 18:11, Benoît Canet wrote: > > > Since the block layer code is starting to modify the BDS graph right in > > > the > > > middle of BDS chains (block-mirror's replace parameter fo

Re: [Qemu-devel] [bisected] VNC server can't get all sent chars correctly

2014-08-25 Thread Gerd Hoffmann
On Sa, 2014-08-23 at 12:56 +0400, Michael Tokarev wrote: > There's a bug filed against debian qemu package, there: > > http://bugs.debian.org/758881 > > which says about problems sending keypress events over VNC to > a qemu guest, -- some keypresses gets lost, at least. > So it looks like somet

Re: [Qemu-devel] [PATCH 03/15] hw/intc/arm_gic: Add Security Extensions property

2014-08-25 Thread Aggeler Fabian
On 25 Aug 2014, at 11:20, Sergey Fedorov wrote: > On 22.08.2014 14:29, Fabian Aggeler wrote: >> The existing implementation does not support Security Extensions mentioned >> in the GICv1 and GICv2 architecture specification. Security Extensions are >> not available on all GICs. This property mak

Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: honor target mask in gic_update()

2014-08-25 Thread Sergey Fedorov
Ping. On 13.08.2014 20:31, Sergey Fedorov wrote: > Take IRQ target mask into account when determining the highest priority > pending interrupt. > > Signed-off-by: Sergey Fedorov > --- > hw/intc/arm_gic.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/arm_gic.c

Re: [Qemu-devel] [PATCH] qemu-iotests: stop using /tmp directly

2014-08-25 Thread Fam Zheng
On Fri, 08/22 13:25, Peter Wu wrote: > Before this patch you could not run multiple tests concurrently as they > might clobber each other test files. This patch solves that by using > random temporary directory instead of `/tmp` (for writing output in the > individual tests and valgrind logs). > >

Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread Markus Armbruster
writes: > From: Gonglei > > Signed-off-by: Gonglei > --- > hw/pci-bridge/ioh3420.h | 4 > 1 file changed, 4 deletions(-) > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > index 7776e5b..ea423cb 100644 > --- a/hw/pci-bridge/ioh3420.h > +++ b/hw/pci-bridge/ioh3420.h > @@

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-25 Thread Knut Omang
On Mon, 2014-08-25 at 09:23 +, Gonglei (Arei) wrote: > > -Original Message- > > From: Knut Omang [mailto:knut.om...@oracle.com] > > Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports > > and > > downstream ports > > > > On Thu, 2014-08-21 at 17:47 +0800, arei.

Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations]

2014-08-25 Thread Peter Lieven
On 25.08.2014 10:56, Paolo Bonzini wrote: Il 24/08/2014 21:31, Peter Lieven ha scritto: Am 24.08.2014 um 18:30 schrieb Paolo Bonzini: Il 22/08/2014 10:42, Kevin Wolf ha scritto: Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or 4K depending on the blocksize. I don't re

Re: [Qemu-devel] [PATCH 03/15] hw/intc/arm_gic: Add Security Extensions property

2014-08-25 Thread Sergey Fedorov
On 25.08.2014 13:39, Aggeler Fabian wrote: > On 25 Aug 2014, at 11:20, Sergey Fedorov wrote: > >> On 22.08.2014 14:29, Fabian Aggeler wrote: >>> The existing implementation does not support Security Extensions mentioned >>> in the GICv1 and GICv2 architecture specification. Security Extensions are

[Qemu-devel] [RFC PATCH] vmstate: Enable custom migration block name check

2014-08-25 Thread Alexey Kardashevskiy
This adds a callback to support custom names for migration blocks. Signed-off-by: Alexey Kardashevskiy --- RFC! not a real patch! There was a problem a while ago how to migrate sPAPR TCE tables - they needed unique id + instance_id and there 2 approaches for that: 1. Put them on a virtual made

Re: [Qemu-devel] [RFC PATCH] vmstate: Enable custom migration block name check

2014-08-25 Thread Alexander Graf
On 25.08.14 12:22, Alexey Kardashevskiy wrote: > This adds a callback to support custom names for migration blocks. > > Signed-off-by: Alexey Kardashevskiy > --- > > RFC! not a real patch! > > There was a problem a while ago how to migrate sPAPR TCE tables - they > needed unique id + instance

Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread Knut Omang
On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: > writes: > > > From: Gonglei > > > > Signed-off-by: Gonglei > > --- > > hw/pci-bridge/ioh3420.h | 4 > > 1 file changed, 4 deletions(-) > > > > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h > > index 7776e5b..ea

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-25 Thread Richard W.M. Jones
On Mon, Aug 25, 2014 at 01:18:30PM +0800, Hu Tao wrote: > On Fri, Aug 22, 2014 at 05:00:08PM +0100, Richard W.M. Jones wrote: > > What is proposed to be called 'preallocation=falloc' should fall back > > to other methods (eg. writing random, writing zeroes). It should > > also be called something

Re: [Qemu-devel] [PATCH 0/2] pflash (UEFI varstore) migration shortcut for libvirt

2014-08-25 Thread Paolo Bonzini
Il 23/08/2014 12:19, Laszlo Ersek ha scritto: > Libvirt is growing support for x86_64 OVMF guests: > > http://www.redhat.com/archives/libvir-list/2014-August/msg01045.html > > An important feature of such guests is the persistent store for > non-volatile UEFI variables. This is implemented with i

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Paolo Bonzini
Il 22/08/2014 11:26, Peter Lieven ha scritto: > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 22 +++--- > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/block/iscsi.c b/block/iscsi.c > index ed883c3..131357c 100644 > --- a/block/iscsi.c > +++ b/block/i

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-25 Thread Paolo Bonzini
Il 24/08/2014 22:14, Andrey Korolyov ha scritto: > Forgot to mention, _actual_ patch from above. Adding > cpu_synchronize_all_states() bringing old bug with lost interrupts > back. Are you adding it before or after cpu_clean_all_dirty? Paolo

[Qemu-devel] [PATCH V3] net: Fix dealing with packets when runstate changes

2014-08-25 Thread zhanghailiang
For all NICs(except virtio-net) emulated by qemu, Such as e1000, rtl8139, pcnet and ne2k_pci, Qemu can still receive packets when VM is not running. If this happened in *migration's* last PAUSE VM stage, The new dirty RAM related to the packets will be missed, And this will lead serious network fau

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-25 Thread Gonglei (Arei)
> From: Knut Omang [mailto:knut.om...@oracle.com] > Sent: Monday, August 25, 2014 5:51 PM > Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports > and > downstream ports > > On Mon, 2014-08-25 at 09:23 +, Gonglei (Arei) wrote: > > > -Original Message- > > > From

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-25 Thread Andrey Korolyov
On Mon, Aug 25, 2014 at 2:45 PM, Paolo Bonzini wrote: > Il 24/08/2014 22:14, Andrey Korolyov ha scritto: >> Forgot to mention, _actual_ patch from above. Adding >> cpu_synchronize_all_states() bringing old bug with lost interrupts >> back. > > Are you adding it before or after cpu_clean_all_dirty?

Re: [Qemu-devel] [libvirt] Mentors wanted for Outreach Program for Women October 2014

2014-08-25 Thread Martin Kletzander
On Thu, Aug 21, 2014 at 09:06:39PM +0100, Stefan Hajnoczi wrote: Dear mentors and core contributors, Outreach Program for Women is starting the next round in October 2014. OPW funds women to work on open source software for 12 weeks with the help of mentors: https://wiki.gnome.org/OutreachProgram

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-25 Thread Knut Omang
On Mon, 2014-08-25 at 10:51 +, Gonglei (Arei) wrote: > > From: Knut Omang [mailto:knut.om...@oracle.com] > > Sent: Monday, August 25, 2014 5:51 PM > > Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports > > and > > downstream ports > > > > On Mon, 2014-08-25 at 09:23 +

Re: [Qemu-devel] [PATCH] exec: save exception_index field

2014-08-25 Thread Pavel Dovgaluk
> From: Andreas Färber [mailto:afaer...@suse.de] > Am 31.07.2014 07:41, schrieb Pavel Dovgaluk: > > This patch adds subsection with exception_index field to the VMState for > > correct saving the CPU state. > > Without this patch simulator could miss the pending exception in the saved > > virtual m

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Joakim Tjernlund
Alexander Graf wrote on 2014/08/25 11:14:58: > > On 25.08.14 11:09, Riku Voipio wrote: > > Hi, > > > > After weekend, I think the solution to using the P flag is to > > go back to Joakim's original patch: > > > > http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg02269.html > > > > With t

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Peter Lieven
On 25.08.2014 12:37, Paolo Bonzini wrote: Il 22/08/2014 11:26, Peter Lieven ha scritto: Signed-off-by: Peter Lieven --- block/iscsi.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index ed883c3..131357c 100644 ---

Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state

2014-08-25 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Eric Blake writes: >> >>> On 08/21/2014 11:52 AM, Lluís Vilanova wrote: [...] +# +# Since 2.2 +## +{ 'command': 'trace-event-set-state', + 'data': {'name': 'str', 'state': 'bool', '*keepgoing': 'bool'} } >> >>> This

Re: [Qemu-devel] 9p mapped-* security model infos are architecture-specific

2014-08-25 Thread Michael Tokarev
I haven't noticed this email - which is almost a month old now - until today. So replying now... 30.07.2014 21:43, Aneesh Kumar K.V wrote: > "Aneesh Kumar K.V" writes: > >> Michael Tokarev writes: >> >>> Apparently the the mapped-* security models results in a raw bytes >>> being dumped to host

Re: [Qemu-devel] [RFC PATCH] vmstate: Enable custom migration block name check

2014-08-25 Thread Alexey Kardashevskiy
On 08/25/2014 08:23 PM, Alexander Graf wrote: > > > On 25.08.14 12:22, Alexey Kardashevskiy wrote: >> This adds a callback to support custom names for migration blocks. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> RFC! not a real patch! >> >> There was a problem a while ago how to migr

[Qemu-devel] [PATCH v41/2] trace: [qmp] Add commands to query and control event tracing state

2014-08-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- qapi-schema.json|3 ++ qapi/trace.json | 65 qmp-commands.hx | 35 trace/Makefile.objs |1 + trace/qmp.c | 75 +

[Qemu-devel] [PATCH v4 0/2] trace: Trace control commands

2014-08-25 Thread Lluís Vilanova
Adds QAPI/QMP commands to control tracing events, and reimplements some of the related HMP commands on top. NOTE: The "trace-event-set-state" command uses a bool 'enable' argument instead of an enum 'state'. I'm still not sure if an enum is better than the two separate booleans. Signe

[Qemu-devel] [PATCH v4 1/2] trace: [qmp] Add commands to query and control event tracing state

2014-08-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- qapi-schema.json|3 ++ qapi/trace.json | 65 qmp-commands.hx | 35 trace/Makefile.objs |1 + trace/qmp.c | 75 +

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:10, Peter Lieven ha scritto: > On 25.08.2014 12:37, Paolo Bonzini wrote: >> Il 22/08/2014 11:26, Peter Lieven ha scritto: >>> Signed-off-by: Peter Lieven >>> --- >>> block/iscsi.c | 22 +++--- >>> 1 file changed, 15 insertions(+), 7 deletions(-) >>> >>> diff -

[Qemu-devel] [PATCH v4 2/2] trace: [hmp] Reimplement "trace-event" and "info trace-events" using QMP

2014-08-25 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 27 ++- trace/control.c | 13 - trace/control.h |7 --- 3 files changed, 14 insertions(+), 33 deletions(-) diff --git a/monitor.c b/monitor.c index cdbaa60..551dd0b 100644 --- a/monitor.c +++ b/mo

Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports and downstream ports

2014-08-25 Thread Gonglei (Arei)
> -Original Message- > From: Knut Omang [mailto:knut.om...@oracle.com] > Sent: Monday, August 25, 2014 7:02 PM > Subject: Re: [Qemu-devel] [PATCH v2 2/2] pci: add check for pcie root ports > and > downstream ports > > On Mon, 2014-08-25 at 10:51 +, Gonglei (Arei) wrote: > > > From: Kn

Re: [Qemu-devel] [PATCH v8 0/5] cpus: Add generic "nmi" monitor command support

2014-08-25 Thread Paolo Bonzini
Il 20/08/2014 14:16, Alexey Kardashevskiy ha scritto: > This adds an "nmi" monitor command handler per CPUs. > x86, s390 and ppc CPUS are supported. > > Please comment. Thanks. > > Changes: > v8: > * adjusted commit log for s390 patch > * fixed missing "static" in 1/4 > > v7: > * fixed typenames

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Peter Lieven
On 25.08.2014 13:20, Paolo Bonzini wrote: Il 25/08/2014 13:10, Peter Lieven ha scritto: On 25.08.2014 12:37, Paolo Bonzini wrote: Il 22/08/2014 11:26, Peter Lieven ha scritto: Signed-off-by: Peter Lieven --- block/iscsi.c | 22 +++--- 1 file changed, 15 insertions(+), 7

Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-08-25 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 31/07/2014 17:21, Pavel Dovgalyuk ha scritto: > > Pre load is necessary, because we switched off resetting VM while > > loading in the replay mode. > > Then you should not add it now, but rather when you add replay. Treat > this part of the

Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:26, Peter Lieven ha scritto: >>> >> Hmm, good question. If so, the patch is correct with error_report. I >> thought a failure in iscsi_open would be less surprising. The question >> then is, do we need an option to disable allocationmap queries? > > We have cache=none... Doh,

Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:40, Pavel Dovgaluk ha scritto: > Do you mean, that I should separate the migration patches from > the replay ones and submit them in another series? Yes, that will help getting the less controversial pieces in first. Paolo

Re: [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters

2014-08-25 Thread Paolo Bonzini
Il 24/08/2014 13:16, Michael S. Tsirkin ha scritto: > > Are these appropriate for 2.1.1? > Add Cc stable? I think so. Paolo

Re: [Qemu-devel] [PATCH] translate-all.c: fix debug memory maps printing

2014-08-25 Thread Paolo Bonzini
Il 11/08/2014 12:28, Mikhail Ilyin ha scritto: > Fix memory maps textualizing function. The output was not correct because of > wrong base address calculation. The initial address has to be shifted also > for TARGET_PAGE_BITS. > > Signed-off-by: Mikhail Ilyin > --- > translate-all.c | 3 +-- > 1

Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread Markus Armbruster
Knut Omang writes: > On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: >> writes: >> >> > From: Gonglei >> > >> > Signed-off-by: Gonglei >> > --- >> > hw/pci-bridge/ioh3420.h | 4 >> > 1 file changed, 4 deletions(-) >> > >> > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridg

Re: [Qemu-devel] [PATCH] translate-all.c: fix debug memory maps printing

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:45, Paolo Bonzini ha scritto: > Il 11/08/2014 12:28, Mikhail Ilyin ha scritto: >> Fix memory maps textualizing function. The output was not correct because of >> wrong base address calculation. The initial address has to be shifted also >> for TARGET_PAGE_BITS. >> >> Signed-off-by:

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-08-25 Thread Benoît Canet
On Mon, Aug 25, 2014 at 05:37:37PM +0800, Fam Zheng wrote: > On Mon, 08/25 09:06, Benoît Canet wrote: > > On Mon, Aug 25, 2014 at 02:04:24PM +0800, Fam Zheng wrote: > > > On Fri, 08/22 18:11, Benoît Canet wrote: > > > > Since the block layer code is starting to modify the BDS graph right in > > >

Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Monday, August 25, 2014 7:51 PM > Subject: Re: [Qemu-devel] [PATCH] ioh3420: Remove unused ioh3420_init() > declaration > > Knut Omang writes: > > > On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: > >> writes: > >> > >> >

[Qemu-devel] [PATCH] vl: process -object after other backend options

2014-08-25 Thread Paolo Bonzini
QOM backends can refer to chardevs, but not vice versa. So process -chardev and -fsdev options before -object This fixes the rng-egd backend to virtio-rng. Reported-by: Amos Kong Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- vl.c | 10 +- 1 file changed, 5 insertions(+),

[Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration

2014-08-25 Thread arei.gonglei
From: Gonglei This patch based on Knut's patch: ioh3420: Remove unused ioh3420_init() declaration which has been pulled on the fly. Signed-off-by: Gonglei Reviewed-by: Knut Omang --- v2: - add commit message to state the patch's prerequisites. - add 'Reviewed-by' tag --- hw/pci-bridge/ioh

Re: [Qemu-devel] [PATCH 0/6] add dumpdts ability to convert dtb to dts

2014-08-25 Thread Peter Maydell
On 25 August 2014 05:00, john.liuli wrote: > From: Li Liu > > This patchset let qemu can convert dtb file to dts for two demands: > > Some archtectures may generate the dtb file dynamically through > qemu device tree functions. So this let it's possiable to dump final > dtb to dts and save it as

Re: [Qemu-devel] [PATCH 01/15] hw/intc/arm_gic: Request FIQ sources

2014-08-25 Thread Peter Maydell
On 25 August 2014 10:16, Sergey Fedorov wrote: > On 22.08.2014 14:29, Fabian Aggeler wrote: >> Preparing for FIQ lines from GIC to CPUs, which is needed for GIC >> Security Extensions. >> >> Signed-off-by: Fabian Aggeler >> --- >> hw/intc/arm_gic.c| 3 +++ >> include/hw/intc/arm_

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Riku Voipio
On Mon, Aug 25, 2014 at 11:14:58AM +0200, Alexander Graf wrote: > > > On 25.08.14 11:09, Riku Voipio wrote: > > Hi, > > > > After weekend, I think the solution to using the P flag is to > > go back to Joakim's original patch: > > > > http://lists.gnu.org/archive/html/qemu-devel/2014-07/msg02269

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Alexander Graf
On 25.08.14 14:42, Riku Voipio wrote: > On Mon, Aug 25, 2014 at 11:14:58AM +0200, Alexander Graf wrote: >> >> >> On 25.08.14 11:09, Riku Voipio wrote: >>> Hi, >>> >>> After weekend, I think the solution to using the P flag is to >>> go back to Joakim's original patch: >>> >>> http://lists.gnu.org

Re: [Qemu-devel] [PATCH 1/2] usb: Fix bootindex for portnr > 9

2014-08-25 Thread Gerd Hoffmann
On Fr, 2014-08-15 at 13:32 +0200, Markus Armbruster wrote: > We identify devices by their Open Firmware device paths. The encoding > of the host controller and hub port numbers is incorrect: > usb_get_fw_dev_path() formats them in decimal, while SeaBIOS uses > hexadecimal. When some port number >

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Riku Voipio
On Mon, Aug 25, 2014 at 02:46:21PM +0200, Alexander Graf wrote: > > > On 25.08.14 14:42, Riku Voipio wrote: > > On Mon, Aug 25, 2014 at 11:14:58AM +0200, Alexander Graf wrote: > >> > >> > >> On 25.08.14 11:09, Riku Voipio wrote: > >>> Hi, > >>> > >>> After weekend, I think the solution to using t

Re: [Qemu-devel] Bug#758881: [bisected] VNC server can't get all sent chars correctly

2014-08-25 Thread Gabriele Giacone
[ CC'ing Marc Sibson, vncdotool developer ] Hi Marc, thread starts at http://thread.gmane.org/gmane.comp.emulators.qemu/292614 On Mon, Aug 25, 2014 at 11:37 AM, Gerd Hoffmann wrote: > On Sa, 2014-08-23 at 12:56 +0400, Michael Tokarev wrote: >> There's a bug filed against debian qemu package, the

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Laurent Vivier
> Le 25 août 2014 à 14:46, Alexander Graf a écrit : > > > > > On 25.08.14 14:42, Riku Voipio wrote: > > On Mon, Aug 25, 2014 at 11:14:58AM +0200, Alexander Graf wrote: > >> > >> > >> On 25.08.14 11:09, Riku Voipio wrote: > >>> Hi, > >>> > >>> After weekend, I think the solution to using the P fla

Re: [Qemu-devel] [PATCH v2 5/7] util: Move throttle.c out to top level

2014-08-25 Thread Paolo Bonzini
Il 22/08/2014 12:54, Fam Zheng ha scritto: > It is only used by block code and has dependency on timers, so move it > out to allow util to be linked unconditionally. > > Signed-off-by: Fam Zheng > --- > Makefile.objs | 2 +- > util/throttle.c => throttle.c | 0 > util/Makefile.ob

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-08-25 Thread Anshul Makkar
Hi, I am testing memory hotadd/remove functionality for Windows guest (currently 2012 server). Memory hot remove is not working. As mentioned in the mail chain, hot remove on Windows is not supported.So just wanted to check if its still not supported or has been supported or its a work in progres

Re: [Qemu-devel] [PATCH 00/35] pc: ACPI memory hotplug

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 15:28, Anshul Makkar ha scritto: > > I am testing memory hotadd/remove functionality for Windows guest > (currently 2012 server). Memory hot remove is not working. > > As mentioned in the mail chain, hot remove on Windows is not > supported.So just wanted to check if its still not s

Re: [Qemu-devel] linux-user: enabling binfmt P flag

2014-08-25 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/08/25 14:42:57: > > On Mon, Aug 25, 2014 at 11:14:58AM +0200, Alexander Graf wrote: > > > > > > On 25.08.14 11:09, Riku Voipio wrote: > > > Hi, > > > > > > After weekend, I think the solution to using the P flag is to > > > go back to Joakim's original patch: > > > >

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-25 Thread Richard W.M. Jones
On Mon, Aug 25, 2014 at 01:18:30PM +0800, Hu Tao wrote: > What if user cares about time(writing zeroes or non-zeroes is > time-consuming) and wants falloc only sometimes? I think this is the > main difference between preallocation=falloc and preallocation=full. Also posix_fallocate in glibc falls

[Qemu-devel] [PATCH 0/5] target-ppc: Add FWNMI support in QEMU for powerKVM guests

2014-08-25 Thread Aravinda Prasad
This series of patches add support for fwnmi in powerKVM guests. Currently upon machine check exception, if the address in error belongs to guest then KVM invokes guest's NMI interrupt vector 0x200. This patch series adds functionality where the guest's 0x200 interrupt vector is patched such that

[Qemu-devel] [PATCH 1/5] target-ppc: Extend rtas-blob

2014-08-25 Thread Aravinda Prasad
Extend rtas-blob to accommodate error log. Error log structure is saved in rtas space upon a machine check exception. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 13 ++--- hw/ppc/spapr_rtas.c |4 ++-- include/hw/ppc/spapr.h |2 +- p

[Qemu-devel] [PATCH 5/5] target-ppc: Handle cases when multi-processors get machine-check

2014-08-25 Thread Aravinda Prasad
It is possible for multi-processors to experience machine check at or about the same time. As per PAPR, subsequent processors serialize waiting for the first processor to issue the ibm,nmi-interlock call. The second processor retries if the first processor which received a machine check is still r

[Qemu-devel] [PATCH 4/5] target-ppc: Handle ibm, nmi-register RTAS call

2014-08-25 Thread Aravinda Prasad
This patch adds FWNMI support in qemu for powerKVM guests by handling the ibm,nmi-register rtas call. Whenever OS issues ibm,nmi-register RTAS call, the machine check notification address is saved and the machine check interrupt vector 0x200 is patched to issue a private hcall. Signed-off-by: Arav

  1   2   3   >