[Qemu-devel] [Bug 1278977] Re: qemu-system-sparc64 crash when initializing disk

2014-08-24 Thread Mark Cave-Ayland
HI Waldemar, Glad that you now have something that works for you. I've tried to reproduce your virtio hang this morning with multiple 100% CPU and "find / -name 'foo'" processes running but I can't seem to get virtio to hang on my system here. Since this is the second report I've had of this pro

Re: [Qemu-devel] [PATCH v2 for-2.1] po: Fix Makefile rules for in-tree builds without configuration

2014-08-24 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: fix file descriptor leaks

2014-08-24 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-24 Thread Michael Tokarev
This might be due to old(ish) seabios you're using. It should be 1.7.5 version, not 1.7.4. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359243 Title: [BSOD 0xc00d] Can't boot windows with qe

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations)

2014-08-24 Thread Michael Tokarev
Applied to -trivial, thank you! But I've a small concern - should we really do this on "external" sources, and divirge from upstream needlessly? Thanks, /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] IDE: MMIO IDE device control should be little endian

2014-08-24 Thread Michael Tokarev
22.08.2014 12:52, Valentin Manea wrote: > Set the IDE MMIO memory type to little endian. The ATA specs identify > words part of the control commands encoded as little endian. > While this has no impact on little endian systems, it's required for big > endian systems(eg OpenRisc). While the patch i

Re: [Qemu-devel] [Qemu-trivial] [PATCH] libdecnumber: Fix warnings from smatch (missing static, boolean operations)

2014-08-24 Thread Stefan Weil
Am 24.08.2014 11:21, schrieb Michael Tokarev: Applied to -trivial, thank you! But I've a small concern - should we really do this on "external" sources, and divirge from upstream needlessly? Thanks, /mjt In general, I agree. In this case, the code was part of gcc, and newer versions of gcc

Re: [Qemu-devel] [PATCH v4 0/8] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset

2014-08-24 Thread Michael S. Tsirkin
On Sat, Aug 16, 2014 at 01:55:36PM +0800, Le Tan wrote: > Hi, > > These patches are intended to introduce Intel IOMMU (VT-d) emulation to q35 > chipset. The major job in these patches is to add support for emulating Intel > IOMMU according to the VT-d specification, including basic responses to CS

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-24 Thread Michael S. Tsirkin
On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: > On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: > >On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: > >>Currenjly this ISA bridge should be fixed at 1f.0, and pass the > > > >Currently > > Fixed. > > > > >>real vendor/dev

Re: [Qemu-devel] [PATCH RESEND 0/2] Fix leaks on object_property_add_str() setters

2014-08-24 Thread Michael S. Tsirkin
Are these appropriate for 2.1.1? Add Cc stable? On Fri, Aug 22, 2014 at 04:35:24PM -0300, Eduardo Habkost wrote: > Ping? Who can apply these? > > On Wed, Aug 06, 2014 at 03:18:19PM -0300, Eduardo Habkost wrote: > > Resending two patches from the previous series which were not applied yet. > > >

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Michael Tokarev
20.08.2014 16:27, Ben Draper wrote: > When running VMware ESXi under qemu-kvm the guest discards frames > that are too short. Short ARP Requests will be dropped, this prevents > guests on the same bridge as VMware ESXi from communicating. This patch > simply adds the padding on the network device i

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Dmitry Fleytman
On Aug 24, 2014, at 15:06 PM, Michael Tokarev wrote: > 20.08.2014 16:27, Ben Draper wrote: >> When running VMware ESXi under qemu-kvm the guest discards frames >> that are too short. Short ARP Requests will be dropped, this prevents >> guests on the same bridge as VMware ESXi from communicating.

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Michael Tokarev
24.08.2014 16:28, Dmitry Fleytman wrote: > Hi Michael, > > I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me. Maybe you can add yourself to MAINTAINERS file as well? :) I dunno if that's actually needed, but at least this should stop "strain" patches like this to be sent

Re: [Qemu-devel] [question] which version of seabios is best for qemu-2.0.0?

2014-08-24 Thread Michael Tokarev
12.08.2014 15:14, Zhang Haoyu wrote: > Hi all, > > We choose qemu-2.0.0 as distribution, and which version of seabios is best > for qemu-2.0.0 ? qemu comes with bundled seabios, which works best with this version of qemu. For qemu 2.0, you may use seabios 1.7.4 or 1.7.5 (while 2.1 requires at l

Re: [Qemu-devel] [PATCH v1 5/5] Netduino: Add the Netduino Plus 2 Machine Model

2014-08-24 Thread Peter Crosthwaite
On Sun, Aug 24, 2014 at 10:14 AM, Alistair Francis wrote: > This patch adds the Netduion Plus 2 machine to QEMU. > > Signed-off-by: Alistair Francis > --- > hw/arm/Makefile.objs | 2 +- > hw/arm/netduinoplus2.c | 202 > + > 2 files changed, 20

Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Dmitry Fleytman
On Aug 24, 2014, at 16:10 PM, Michael Tokarev wrote: > 24.08.2014 16:28, Dmitry Fleytman wrote: > >> Hi Michael, >> >> I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me. > > Maybe you can add yourself to MAINTAINERS file as well? :) Yes, this should be done. How we d

[Qemu-devel] [PULL 09/11] linux-user: fix file descriptor leaks

2014-08-24 Thread Michael Tokarev
From: zhanghailiang Handle variable "fd_orig" going out of scope leaks the handle. Signed-off-by: zhanghailiang Reviewed-by: Gonglei Signed-off-by: Michael Tokarev --- linux-user/syscall.c |1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c inde

[Qemu-devel] [PULL 03/11] tests/bios-tables-test: check the value returned by fopen()

2014-08-24 Thread Michael Tokarev
From: zhanghailiang The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiang Signed-off-by: Li Liu Reviewed-by: Alex Bennée Signed-off-by: Michael Tokarev --- tests/bios-tables-test.c |5 + 1 file changed, 5 insertions(+) diff --git a/tests/bios-tables

[Qemu-devel] [PULL 06/11] configure: no need to mkdir QMP

2014-08-24 Thread Michael Tokarev
From: Liming Wang commit 7537fe04 QMP: QMP/ -> docs/qmp/ Above commit has moved last QMP files to docs/qmp and it's not necessary to create QMP directory. So remove it from configure. Signed-off-by: Liming Wang Signed-off-by: Michael Tokarev --- configure |4 1 file changed, 4 delet

[Qemu-devel] [PULL 10/11] libdecnumber: Fix warnings from smatch (missing static, boolean operations)

2014-08-24 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- libdecnumber/decNumber.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/libdecnumber/decNumber.c b/libdecnumber/decNumber.c index a30632f..58211e7 100644 --- a/libdecn

[Qemu-devel] [PULL 02/11] tcg: dump op count into qemu log

2014-08-24 Thread Michael Tokarev
From: zhanghailiang fopen() may fail and it does not check its return vaule here, it is better to dump op count to the normal log file. Signed-off-by: Li Liu Signed-off-by: zhanghailiang Signed-off-by: Michael Tokarev --- tcg/tcg.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(

[Qemu-devel] [PULL 00/11] Trivial patches for 2014-08-24

2014-08-24 Thread Michael Tokarev
This time, we've a bunch of trivial stuff all over, including a series from zhanghailiang, some minor fixes from Stefan Weil and Peter Crosthwaite, and also a bugfix for a rare device - vmxnet3 - reviewed by the author. Please consider pulling/applying. Thanks, /mjt The following changes since

[Qemu-devel] [PATCH v2 0/4] q35: Minor fixes/enhancements to improve usability of root ports

2014-08-24 Thread Knut Omang
These are some minor fixes necessary to be able to operate ARI capable devices in PCIe root ports on a q35 machine, using command line options like this: -device ioh3420,slot=0,id=pcie_port.0 -device ioh3420,slot=1,id=pcie_port.1 -device ,bus=pcie_port.0 -device ,bus=pcie_port.1 Changes since

[Qemu-devel] [PATCH v2 2/4] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*

2014-08-24 Thread Knut Omang
Rename helper functions to make a clearer distinction between the PCIe capability/control register feature ARI forwarding and a device that supports the ARI feature via an ARI extended PCIe capability. Signed-off-by: Knut Omang --- hw/pci-bridge/ioh3420.c| 1 + hw/pci-bridge/xio3130

[Qemu-devel] [PATCH v2 3/4] ioh3420: Remove obsoleted, unused ioh3420_init function

2014-08-24 Thread Knut Omang
Signed-off-by: Knut Omang --- hw/pci-bridge/ioh3420.c | 24 1 file changed, 24 deletions(-) diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c index aed2bf1..e6674a1 100644 --- a/hw/pci-bridge/ioh3420.c +++ b/hw/pci-bridge/ioh3420.c @@ -157,30 +157,6 @@ stati

[Qemu-devel] [PATCH v2 1/4] pcie: Fix incorrect write to the ari capability next function field

2014-08-24 Thread Knut Omang
PCI_ARI_CAP_NFN, a macro for reading next function was used instead of the intended write. Signed-off-by: Knut Omang --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index a123c01..de0e967 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/

[Qemu-devel] [PULL 11/11] vmxnet3: Pad short frames to minimum size (60 bytes)

2014-08-24 Thread Michael Tokarev
From: Ben Draper When running VMware ESXi under qemu-kvm the guest discards frames that are too short. Short ARP Requests will be dropped, this prevents guests on the same bridge as VMware ESXi from communicating. This patch simply adds the padding on the network device itself. Signed-off-by: Be

[Qemu-devel] [PULL 07/11] slirp/misc: Use the GLib memory allocation APIs

2014-08-24 Thread Michael Tokarev
From: zhanghailiang Here we don't check the return value of malloc() which may fail. Use the g_new() instead, which will abort the program when there is not enough memory. Also, use g_strdup instead of strdup and remove the unnecessary strdup function. Signed-off-by: zhanghailiang Reviewed-by:

[Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding

2014-08-24 Thread Knut Omang
Signed-off-by: Knut Omang --- hw/pci-bridge/ioh3420.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c index e6674a1..cce2fdd 100644 --- a/hw/pci-bridge/ioh3420.c +++ b/hw/pci-bridge/ioh3420.c @@ -85,6 +85,7 @@ static void ioh3420_reset(Devic

[Qemu-devel] [PULL 08/11] po: Fix Makefile rules for in-tree builds without configuration

2014-08-24 Thread Michael Tokarev
From: Stefan Weil Adding 'update' to the phony targets fixes this error: $ LANG=C make -C po update make: Entering directory `/qemu/po' LINK update /qemu/po/de_DE.po: file not recognized: File format not recognized collect2: error: ld returned 1 exit status make: *** [update] Error 1 make: Le

[Qemu-devel] [PULL 01/11] util/path: Use the GLib memory allocation routines

2014-08-24 Thread Michael Tokarev
From: zhanghailiang In this file, we don't check the return value of malloc/strdup/realloc which may fail. Instead of using these routines, we use the GLib memory APIs g_malloc/g_strdup/g_realloc. They will exit on allocation failure, so there is no need to test for failure, which would be fine

[Qemu-devel] [PULL 05/11] dma: axidma: Variablise repeated s->streams[i] sub-expr

2014-08-24 Thread Michael Tokarev
From: Peter Crosthwaite This have 6 inline usages. Make it a bit more readable by using a local variable. Signed-off-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/dma/xilinx_axidma.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/dma/xilinx_a

[Qemu-devel] [PULL 04/11] microblaze: ml605: Get rid of ddr_base variable

2014-08-24 Thread Michael Tokarev
From: Peter Crosthwaite It's a constant based on a macro. Just use the macro in place. Signed-off-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/microblaze/petalogix_ml605_mmu.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/microblaze/petalogix_ml

[Qemu-devel] [Bug 1354167] Re: On VM restart: Could not open 'poppy.qcow2': Could not read snapshots: File too large

2014-08-24 Thread Gary Roberts
I too am getting his bug. Same error message Todd gets word for word. Even going to the command prompt yields the same issue. I have QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.2) Thank you -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH] target-i386: Don't forbid NX bit on PAE PDEs and PTEs

2014-08-24 Thread William Grant
Commit e8f6d00c30ed88910d0d985f4b2bf41654172ceb ("target-i386: raise page fault for reserved physical address bits") added a check that the NX bit is not set on PAE PDPEs, but it also added it to rsvd_mask for the rest of the function. This caused any PDEs or PTEs with NX set to be erroneously reje

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-24 Thread Gannet
And where can I find it, 1.7.4 version ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359243 Title: [BSOD 0xc00d] Can't boot windows with qemu Status in QEMU: New Bug description: Upgra

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-24 Thread Gannet
I meаnt 1.7.5. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1359243 Title: [BSOD 0xc00d] Can't boot windows with qemu Status in QEMU: New Bug description: Upgrading to latest qemu I foun

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-24 Thread Andrey Korolyov
Sorry, I was a bit inaccurate in my thoughts at Fri about necessary amount of work, patch lays perfectly on 3.10 with bit of monkey rewrites. The attached one fixed problem for me - it represents 0b10a1c87a2b0fb459baaefba9cb163dbb8d3344, 0bc830b05c667218d703f2026ec866c49df974fc, 44847dea79751e95665

Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations]

2014-08-24 Thread Paolo Bonzini
Il 22/08/2014 10:42, Kevin Wolf ha scritto: > > Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or 4K > > depending > > on the blocksize. > > I don't remember the details, but I think when I went through all > drivers, I couldn't convince myself that a reasonable block size

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-24 Thread Paolo Bonzini
Il 24/08/2014 18:19, Andrey Korolyov ha scritto: > Sorry, I was a bit inaccurate in my thoughts at Fri about necessary > amount of work, patch lays perfectly on 3.10 with bit of monkey > rewrites. The attached one fixed problem for me - it represents > 0b10a1c87a2b0fb459baaefba9cb163dbb8d3344, > 0b

Re: [Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support

2014-08-24 Thread Jun Li
Hi Kevin and Stefan, As the realize of bdrv_discard, and this patch has been received, but I have some question. This adds a bdrv_discard function to qcow2 that frees the discarded clusters. It does not yet pass the discard on to the underlying file system driver, but the space can be reused

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-24 Thread Andrey Korolyov
On Sun, Aug 24, 2014 at 8:35 PM, Paolo Bonzini wrote: > Il 24/08/2014 18:19, Andrey Korolyov ha scritto: >> Sorry, I was a bit inaccurate in my thoughts at Fri about necessary >> amount of work, patch lays perfectly on 3.10 with bit of monkey >> rewrites. The attached one fixed problem for me - it

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-24 Thread Gannet
Well, I took it here: https://launchpad.net/ubuntu/+source/seabios. Although it's for Utopic and, as noted, also unstable, but you're right. It works ! Thanks. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-24 Thread Andrey Korolyov
On Sun, Aug 24, 2014 at 8:57 PM, Andrey Korolyov wrote: > On Sun, Aug 24, 2014 at 8:35 PM, Paolo Bonzini wrote: >> Il 24/08/2014 18:19, Andrey Korolyov ha scritto: >>> Sorry, I was a bit inaccurate in my thoughts at Fri about necessary >>> amount of work, patch lays perfectly on 3.10 with bit of

[Qemu-devel] [Bug 1359243] Re: [BSOD 0xc000000d] Can't boot windows with qemu

2014-08-24 Thread Michael Tokarev
So, the problem is with the ppa, not qemu. The ppa package does not express dependencies correctly. Closing as invalid. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations]

2014-08-24 Thread Peter Lieven
Am 24.08.2014 um 18:30 schrieb Paolo Bonzini: > Il 22/08/2014 10:42, Kevin Wolf ha scritto: >>> Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or 4K >>> depending >>> on the blocksize. >> I don't remember the details, but I think when I went through all >> drivers, I couldn'

Re: [Qemu-devel] [PATCH] qemu-iotests: stop using /tmp directly

2014-08-24 Thread Peter Wu
On Friday 22 August 2014 20:58:34 Benoît Canet wrote: > The Friday 22 Aug 2014 à 13:25:43 (+0200), Peter Wu wrote : > > Before this patch you could not run multiple tests concurrently as they > > might clobber each other test files. This patch solves that by using > > random temporary directory ins

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-24 Thread Andrey Korolyov
Forgot to mention, _actual_ patch from above. Adding cpu_synchronize_all_states() bringing old bug with lost interrupts back.

Re: [Qemu-devel] [PATCH v2 0/4] q35: Minor fixes/enhancements to improve usability of root ports

2014-08-24 Thread Michael S. Tsirkin
On Sun, Aug 24, 2014 at 03:32:16PM +0200, Knut Omang wrote: > These are some minor fixes necessary to be able to operate ARI capable devices > in PCIe root ports on a q35 machine, using command line options like this: > > -device ioh3420,slot=0,id=pcie_port.0 > -device ioh3420,slot=1,id=pcie_por

[Qemu-devel] [PATCH] pcie: fix trailing whitespace

2014-08-24 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 6cb6e0c..1babddf 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -498,7 +498,7 @@ void pcie_cap_flr_write_config(PCIDevice *dev, } /* A

[Qemu-devel] [PULL 00/11] pci, pc fixes, features

2014-08-24 Thread Michael S. Tsirkin
The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 09:55:42 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags

[Qemu-devel] [PULL 05/11] Add ACPI tables for TPM

2014-08-24 Thread Michael S. Tsirkin
From: Stefan Berger Add an SSDT ACPI table for the TPM device. Add a TCPA table for BIOS logging area when a TPM is being used. The latter follows this spec here: http://www.trustedcomputinggroup.org/files/static_page_files/DCD4188E-1A4B-B294-D050A155FB6F7385/TCG_ACPIGeneralSpecification_Public

[Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE

2014-08-24 Thread Michael S. Tsirkin
When memory is allocated on a wrong node, MPOL_MF_STRICT doesn't move it - it just fails the allocation. A simple way to reproduce the failure is with mlock=on realtime feature. The code comment actually says: "ensure policy won't be ignored" so setting MPOL_MF_MOVE seems like a better way to do t

[Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function

2014-08-24 Thread Michael S. Tsirkin
From: Knut Omang Signed-off-by: Knut Omang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/ioh3420.c | 24 1 file changed, 24 deletions(-) diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c index aed2bf1..e6674a1 100644

[Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows

2014-08-24 Thread Michael S. Tsirkin
From: Paolo Bonzini The regions are destroyed and recreated on configuration space accesses. We need to destroy them before the containing PCIBridgeWindows object is freed. Reported-by: Gonglei Reported-by: Knut Omang Signed-off-by: Paolo Bonzini Reviewed-by: Michael S. Tsirkin Signed-off-by

[Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds

2014-08-24 Thread Michael S. Tsirkin
From: Gonglei Prevent out-of-bounds array access on acpi_pcihp_pci_status. Signed-off-by: Gonglei Reviewed-by: Peter Crosthwaite Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Cc: qemu-sta...@nongnu.org Reviewed-by: Marcel Apfelbaum --- hw/acpi/pcihp.c | 2 +- 1 file cha

[Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git

2014-08-24 Thread Michael S. Tsirkin
Needed for systems without IASL. Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-tpm.hex.generated | 95 ++ 1 file changed, 95 insertions(+) create mode 100644 hw/i386/ssdt-tpm.hex.generated diff --git a/hw/i386/ssdt-tpm.hex.generated b/hw/i386/ssdt-t

[Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding

2014-08-24 Thread Michael S. Tsirkin
From: Knut Omang Signed-off-by: Knut Omang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/ioh3420.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/pci-bridge/ioh3420.c b/hw/pci-bridge/ioh3420.c index e6674a1..cce2fdd 100644 --- a/hw/pci-bridge/io

[Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*

2014-08-24 Thread Michael S. Tsirkin
From: Knut Omang Rename helper functions to make a clearer distinction between the PCIe capability/control register feature ARI forwarding and a device that supports the ARI feature via an ARI extended PCIe capability. Signed-off-by: Knut Omang Reviewed-by: Michael S. Tsirkin Signed-off-by: Mi

[Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types

2014-08-24 Thread Michael S. Tsirkin
commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9 acpi-build: tweak acpi migration limits broke kernel loading with -kernel/-initrd: it doubled the size of ACPI tables but did not reserve enough memory. As a result, issues on boot and halt are observed. Fix this up by doubling reserved memory f

[Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field

2014-08-24 Thread Michael S. Tsirkin
From: Knut Omang PCI_ARI_CAP_NFN, a macro for reading next function was used instead of the intended write. Signed-off-by: Knut Omang Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci

[Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace

2014-08-24 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 6cb6e0c..1babddf 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -498,7 +498,7 @@ void pcie_cap_flr_write_config(PCIDevice *dev, } /* A

Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding

2014-08-24 Thread Michael S. Tsirkin
On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote: > Signed-off-by: Knut Omang BTW pcie_cap_is_arifwd_enabled is still unused. We really should use it to make ARI work properly, right? > --- > hw/pci-bridge/ioh3420.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/pci-br

Re: [Qemu-devel] [PATCH v12 5/6] raw-posix: Add falloc and full preallocation option

2014-08-24 Thread Hu Tao
On Fri, Aug 22, 2014 at 12:58:23PM +0200, Kevin Wolf wrote: > Am 11.07.2014 um 08:10 hat Hu Tao geschrieben: > > This patch adds a new option preallocation for raw format, and implements > > falloc and full preallocation. > > > > Reviewed-by: Max Reitz > > Signed-off-by: Hu Tao > > raw-posix ne

Re: [Qemu-devel] [PATCH v12 1/6] block: round up file size to nearest sector

2014-08-24 Thread Hu Tao
On Fri, Aug 22, 2014 at 12:55:51PM +0200, Kevin Wolf wrote: > Am 11.07.2014 um 08:09 hat Hu Tao geschrieben: > > Reviewed-by: Max Reitz > > Reviewed-by: Eric Blake > > Signed-off-by: Hu Tao > > If we make this change, shouldn't we do it consistently across all image > formats? With this patch w

Re: [Qemu-devel] [PATCH v12 4/6] qapi: introduce PreallocMode and a new PreallocMode full.

2014-08-24 Thread Hu Tao
On Fri, Aug 22, 2014 at 12:57:15PM +0200, Kevin Wolf wrote: > Am 11.07.2014 um 08:10 hat Hu Tao geschrieben: > > This patch prepares for the subsequent patches. > > > > Reviewed-by: Fam Zheng > > Reviewed-by: Eric Blake > > Reviewed-by: Max Reitz > > Signed-off-by: Hu Tao > > Strictly speakin

Re: [Qemu-devel] [PATCH v2 3/4] target-openrisc: Add OpenCores keyboard device support

2014-08-24 Thread Jia Liu
Hi Valentin, On Sat, Aug 23, 2014 at 1:05 AM, Valentin Manea wrote: > Add support for the OpenCores keyboard device to the default OpenRisc > machine. > > The OpenCores keyboard device is a simple open source keyboard device > created by the OpenCores project(http://opencores.org/). By default it

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-24 Thread Hu Tao
On Fri, Aug 22, 2014 at 12:54:29PM +0200, Kevin Wolf wrote: > Am 28.07.2014 um 10:48 hat Hu Tao geschrieben: > > ping... > > > > All the 6 patches have reviewed-by now. > > Looks mostly good to me, I have only a few minor comments that wouldn't > block inclusion but could be addressed in follow-u

Re: [Qemu-devel] [PATCH v2 4/4] target-openrisc: Add LPC32XX touchscreen device

2014-08-24 Thread Jia Liu
Hi Valentin, On Sat, Aug 23, 2014 at 1:06 AM, Valentin Manea wrote: > The LPC32XX is a simple MMIO touch screen device with a Linux device > driver. The device is suitable for small machines which require mouse > input but have no suitable bus(SPI, I2C). > > Add the LPC32XX device to the default

Re: [Qemu-devel] [PATCH v12 6/6] qcow2: Add falloc and full preallocation option

2014-08-24 Thread Hu Tao
On Fri, Aug 22, 2014 at 01:00:53PM +0200, Kevin Wolf wrote: > Am 11.07.2014 um 08:10 hat Hu Tao geschrieben: > > This adds preallocation=falloc and preallocation=full mode to qcow2 > > image creation. > > > > preallocation=full allocates disk space by writing zeros to disk to > > ensure disk space

[Qemu-devel] [PATCH trivial v2] Fix debug print warning

2014-08-24 Thread arei.gonglei
From: Gonglei Steps: 1.enable qemu debug print, using simply scprit as below: grep "//#define DEBUG" * -rl | xargs sed -i "s/\/\/#define DEBUG/#define DEBUG/g" 2. make -j 3. get some warning: hw/i2c/pm_smbus.c: In function 'smb_ioport_writeb': hw/i2c/pm_smbus.c:142: warning: format '%04x' expe

Re: [Qemu-devel] [PATCH v6 0/2] add read-pattern for block qourum

2014-08-24 Thread Liu Yuan
On Mon, Aug 18, 2014 at 05:41:03PM +0800, Liu Yuan wrote: > v6: > - fix a unused warning introduced by last version > Hi Stefan and Kevin, Benoît Canet has added Reviewed-by tag to both patches, could one of you pick this patch set? Thanks Yuan

Re: [Qemu-devel] [question] e1000 interrupt storm happened because of its corresponding ioapic->irr bit always set

2014-08-24 Thread Jason Wang
On 08/23/2014 06:36 PM, Zhang Haoyu wrote: > Hi, all > > I use a qemu-1.4.1/qemu-2.0.0 to run win7 guest, and encounter e1000 NIC > interrupt storm, > because "if (!ent->fields.mask && (ioapic->irr & (1 << i)))" is always true > in __kvm_ioapic_update_eoi(). > > Any ideas? We meet this several

Re: [Qemu-devel] [bisected] VNC server can't get all sent chars correctly

2014-08-24 Thread Gonglei (Arei)
Hi, > From: Michael Tokarev [mailto:m...@tls.msk.ru] > Sent: Saturday, August 23, 2014 4:56 PM > To: qemu-devel > Cc: Gerd Hoffmann; Gonglei (Arei); 758...@bugs.debian.org; Gabriele > Giacone > Subject: [bisected] VNC server can't get all sent chars correctly > > There's a bug filed against debia

Re: [Qemu-devel] [PATCH v2] monitor: fix debug print compiling error

2014-08-24 Thread Gonglei (Arei)
Hi, Cc'ing qemu-trivial. Please consider receiving, thanks. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, August 21, 2014 9:03 PM > To: qemu-devel@nongnu.org > Cc: lcapitul...@redhat.com; Huangweidong (C); peter.crosthwa...@xilinx.com; > Gonglei (

Re: [Qemu-devel] [RESEND v2 0/3] Fix some memory leaks about query memdev

2014-08-24 Thread chen.fan.f...@cn.fujitsu.com
ping... This patches have been reviewed-by, only need someone ack it. Thanks, Chen On Mon, 2014-08-18 at 14:46 +0800, Chen Fan wrote: > when using valgrind to test the command "query memdev", I had > found some memory leaks. the test result: > > ==13802== 4 bytes in 1 blocks are definitely los

[Qemu-devel] [PATCH 3/6] device_tree.c: Format a blob in memory as dts stream and dump to a file.

2014-08-24 Thread john.liuli
From: Li Liu The outputed stream format is compatile with 'dtc -I dtb -O dts xxx.dtb'. Signed-off-by: Li Liu --- device_tree.c | 80 + 1 file changed, 80 insertions(+) diff --git a/device_tree.c b/device_tree.c index 14d4015..1e407d2 1

[Qemu-devel] [PATCH 1/6] device_tree.c: Introduce a function to check multiple strings for dts

2014-08-24 Thread john.liuli
From: Li Liu dts property's value can be multiple strings. So introduce a function to check a data with a given length to see if it is all printable and has a valid terminator. It can contain either a single string, or multiple strings each of non-zero length. Signed-off-by: Li Liu --- device_

[Qemu-devel] [PATCH 0/6] add dumpdts ability to convert dtb to dts

2014-08-24 Thread john.liuli
From: Li Liu This patchset let qemu can convert dtb file to dts for two demands: Some archtectures may generate the dtb file dynamically through qemu device tree functions. So this let it's possiable to dump final dtb to dts and save it as a reference. For novices to debugging the issues caused

[Qemu-devel] [PATCH 2/6] device_tree.c: dump three kind data types of dts to a file desciptor

2014-08-24 Thread john.liuli
From: Li Liu dump three kind data types 'strings', 'cell' and 'bytes' of dts to a file desciptor. Signed-off-by: Li Liu --- device_tree.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/device_tree.c b/device_tree.c index 29d9acc..14d4015 100644 -

[Qemu-devel] [PATCH 4/6] device_tree.c: add the main function to analyse the parameter 'dumpdts'

2014-08-24 Thread john.liuli
From: Li Liu add the main function to analyse the parameter 'dumpdts' as a filename the dts will be dumped to. Signed-off-by: Li Liu --- device_tree.c| 21 + include/sysemu/device_tree.h |1 + 2 files changed, 22 insertions(+) diff --git a/device_tree

[Qemu-devel] [PATCH 5/6] machine: add 'dumpdts' parameter to 'machine' optslist.

2014-08-24 Thread john.liuli
From: Li Liu Signed-off-by: Li Liu --- vl.c |4 1 file changed, 4 insertions(+) diff --git a/vl.c b/vl.c index b796c67..853f748 100644 --- a/vl.c +++ b/vl.c @@ -357,6 +357,10 @@ static QemuOptsList qemu_machine_opts = { .type = QEMU_OPT_STRING, .help = "Dump

[Qemu-devel] [PATCH 6/6] arm: Allow dumping generated dtb to dts file

2014-08-24 Thread john.liuli
From: Li Liu By calling qemu_fdt_dumdts before qemu_fdt_dumpdtb. Signed-off-by: Li Liu --- hw/arm/boot.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index e32f2f4..18cc8ac 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -394,6 +394,7 @@ static int loa

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xen:i386:pc_piix: create isa bridge specific to IGD passthrough

2014-08-24 Thread Chen, Tiejun
On 2014/8/24 19:12, Michael S. Tsirkin wrote: On Fri, Aug 22, 2014 at 09:06:20AM +0800, Chen, Tiejun wrote: On 2014/8/22 0:16, Konrad Rzeszutek Wilk wrote: On Thu, Aug 21, 2014 at 09:28:28AM +0800, Tiejun Chen wrote: Currenjly this ISA bridge should be fixed at 1f.0, and pass the Currently

Re: [Qemu-devel] [PATCH v12 0/6] qcow2, raw: add preallocation=full and preallocation=falloc

2014-08-24 Thread Hu Tao
On Fri, Aug 22, 2014 at 05:00:08PM +0100, Richard W.M. Jones wrote: > On Fri, Aug 22, 2014 at 05:53:22PM +0200, Kevin Wolf wrote: > > Am 22.08.2014 um 17:34 hat Richard W.M. Jones geschrieben: > > > On Fri, Aug 22, 2014 at 05:22:33PM +0200, Kevin Wolf wrote: > > > > It's still useful because it hap

Re: [Qemu-devel] [PATCH] block: Make op blockers recursive

2014-08-24 Thread Fam Zheng
On Fri, 08/22 18:11, Benoît Canet wrote: > Since the block layer code is starting to modify the BDS graph right in the > middle of BDS chains (block-mirror's replace parameter for example) QEMU needs > to properly block and unblock whole BDS subtrees; recursion is a neat way to > achieve this task.

Re: [Qemu-devel] [PATCH v2 4/4] ioh3420: Enable ARI forwarding

2014-08-24 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH v2 4/4] ioh3420: Enable ARI forwarding > > On Sun, Aug 24, 2014 at 03:32:20PM +0200, Knut Omang wrote: > > Signed-off-by: Knut Omang > > BTW pcie_cap_is_arifwd_enabled is still unused. Not yet, but I have posted a patch s