From: Gonglei
This error can not happen normally. If it happens indicates
something very wrong, we should abort QEMU. moreover, The
user can only refer to /machine/peripheral, not
/machine/unattached.
Signed-off-by: Gonglei
---
hw/core/qdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
From: Gonglei
It's enough to report an error. Assert() is not acceptable
because the error is not a fatal error.
Signed-off-by: Gonglei
---
hw/pci/pcie.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index a123c01..7b46140 100644
--- a/h
From: Gonglei
At present, this function doesn't have partial cleanup implemented,
which will cause resource leak in some scenarios.
Example:
1. Assuming that "dc->realize(dev, &local_err)" execute successful
and local_err == NULL;
2. Executing device hotplug in hotplug_handler_plug(), but fa
From: Gonglei
after committing
[PATCH v6 0/9] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API
If devcie hotplugging failed, will casuse resource leak.
This patch series include address resouce leak and two other issuses.
v2 -> v1:
- rewrite patch 1/3, using error_abort instea
On 08/21/2014 05:44 AM, Alex Williamson wrote:
> On Wed, 2014-08-20 at 17:49 +1000, Alexey Kardashevskiy wrote:
>> On 08/19/2014 03:42 AM, Alex Williamson wrote:
>>> On Fri, 2014-08-15 at 20:12 +1000, Alexey Kardashevskiy wrote:
Since the changes are not in upstream yet, no tag or branch is sp
On Wed, 08/20 15:29, Paolo Bonzini wrote:
> Il 20/08/2014 12:01, Fam Zheng ha scritto:
> > +
> > +qemuutil.o: CC_REL_FLAGS := -Wl,-r
>
> Why the target-specific rule?
>
> > +qemuutil.o: $(util-obj-y)
> > + $(call quiet-command,$(CC) -nostdlib $(CC_REL_FLAGS) -o $@ $^," LD -r
> > $(TARGET_DIR
On Thu, Aug 21, 2014 at 1:58 AM, Paolo Bonzini wrote:
> Il 20/08/2014 11:07, Peter Maydell ha scritto:
>> The other thing you need to say is that the returned string is
>> only valid for as long as the object remains a child property
>> of its parent. (Is that right? I'm not clear. It also sounds
On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis wrote:
> Add Konstanty
>
>
> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis
> wrote:
>> This allows the board to set the reset address, which is required
>> for some boards (the Netduino Plus 2 for example)
>>
The change is armv7m specific
On Thu, Aug 21, 2014 at 12:11 PM, wrote:
> From: Gonglei
>
> This error can not happen normally. If it happens indicates
> something very wrong, we should abort QEMU. moreover, The
> user can only refer to /machine/peripheral, not
> /machine/unattached.
>
> Signed-off-by: Gonglei
Reviewed-by:
> Subject: Re: [Qemu-devel] [PATCH v2 1/3] qdev: using error_abort instead of
> using local_err
>
> On Thu, Aug 21, 2014 at 12:11 PM, wrote:
> > From: Gonglei
> >
> > This error can not happen normally. If it happens indicates
> > something very wrong, we should abort QEMU. moreover, The
> > us
On Wed, 08/20 15:32, Paolo Bonzini wrote:
>
> In any case, if we need it I think there's no need to keep the argument
> to iqn_generate.
How about multiple initiators? Should they use the same iqn?
Fam
On Thu, Aug 21, 2014 at 1:37 PM, Peter Crosthwaite
wrote:
> On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis
> wrote:
>> Add Konstanty
>>
>>
>> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis
>> wrote:
>>> This allows the board to set the reset address, which is required
>>> for some boar
On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote:
> On 2014/8/19 12:56, Jason Wang wrote:
>> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
> call it before setting
>> Zhang Jie, please test this patch to see if it fixes the issue.
>> +static void vhost_net_set_vq_index(struct vhost_
On Wed, 20 Aug 2014 22:55:38 +0200
"Michael S. Tsirkin" wrote:
> commit 868270f23d8db2cce83e4f082fe75e8625a5fbf9
> acpi-build: tweak acpi migration limits
> broke kernel loading with -kernel/-initrd: it doubled
> the size of ACPI tables but did not reserve
> enough memory.
>
> As a result, i
On Wed, 20 Aug 2014 23:00:57 +0200
"Michael S. Tsirkin" wrote:
> On Wed, Aug 20, 2014 at 04:41:25PM -0400, Luiz Capitulino wrote:
> >
> > Starting a QEMU instance manually configured to boot a Fedora installation
> > kernel with the -kernel/-initrd command-line options cause ACPI to brake
> > in
On 2014/8/21 12:29, Jason Wang wrote:
> On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote:
>> On 2014/8/19 12:56, Jason Wang wrote:
>>> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
>> call it before setting
>>> Zhang Jie, please test this patch to see if it fixes the issue.
>>> +st
Fam Zheng writes:
> On Wed, 08/20 19:07, Markus Armbruster wrote:
>> Instead of bdrv_getlength().
>>
>> Commit 57322b7 did this all over block, but one more bdrv_getlength()
>> has crept in since.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> block/vmdk.c | 11 +--
>> 1 file change
On 08/21/2014 02:28 PM, Zhangjie (HZ) wrote:
> On 2014/8/21 12:29, Jason Wang wrote:
>> On 08/20/2014 05:23 PM, Zhangjie (HZ) wrote:
>>> On 2014/8/19 12:56, Jason Wang wrote:
commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
>>> call it before setting
Zhang Jie, please te
201 - 218 of 218 matches
Mail list logo
