Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-08 Thread Marcelo Tosatti
On Mon, Aug 04, 2014 at 08:30:48PM +0200, Paolo Bonzini wrote: > Il 04/08/2014 18:30, Marcin Gibuła ha scritto: > > > > > > is this analysis deep enough for you? I don't know if that can be fixed > > with existing api as cpu_synchronize_all_states() is all or nothing kind > > of stuff. > > > > K

Re: [Qemu-devel] [PULL 17/19] target-i386: Support "invariant tsc" flag

2014-08-08 Thread Marcelo Tosatti
Chen Liang, On Fri, Aug 08, 2014 at 07:07:59AM +, chenliang (T) wrote: > Hi, > We found that value of host cpus tsc are same to echo other when host has > invariant tsc flag. What you mean exactly? Do you have a test program? > But it is not in vm. The problem is that offset of vcpus tsc

[Qemu-devel] [Bug 1354529] Re: qemu-io: Assert failure on the fuzzed qcow2 image

2014-08-08 Thread Max Reitz
Hi, The problem here is that an L2 table contains an offset which is not aligned on cluster boundaries. To turn the failed assertion into an EIO (and probably we also want to mark the image corrupt), we'd have to verify every single L2 entry when it is read. We can (and should) most certainly do

Re: [Qemu-devel] [PATCH 3/3] block: Catch !bs->drv in bdrv_check()

2014-08-08 Thread Max Reitz
On 08.08.2014 23:11, Max Reitz wrote: On 08.08.2014 11:15, Kevin Wolf wrote: Am 07.08.2014 um 22:47 hat Max Reitz geschrieben: qemu-img check calls bdrv_check() twice if the first run repaired some inconsistencies. If the first run however again triggered corruption prevention (on qcow2) due to

[Qemu-devel] [PATCH] qemu-nbd: NULL nbd export pointer dereference after kill (TERMINATE)

2014-08-08 Thread Zhang Haoyu
After receive TERMINATE signal, qemu nbd state is set to TERMINATE, then in the main loop, nbd_export_close -> nbd_export_put is performed, but sometimes exp->refcount still greater than zero after nbd_export_put, so the qemu nbd state has not been set to TERMINATED, then in next cycle, NULL e

Re: [Qemu-devel] [PATCH v1 4/4] virtio_rng: replace custom backend API with UserCreatable.complete() callback

2014-08-08 Thread Amos Kong
On Thu, Jan 16, 2014 at 05:34:39PM +0100, Igor Mammedov wrote: > in addition fix default backend leak by releasing it if its > initialization failed. > > Signed-off-by: Igor Mammedov Hi Igor, This patch introduced a regression. x86_64-softmmu/qemu-system-x86_64 -monitor stdio -vnc :0 \ -cha

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2014-08-08 Thread Serge Hallyn
Have you had any more time to look into this? Should the QEMU (project) task also be re-marked open? ** Changed in: qemu (Ubuntu) Importance: Undecided => Wishlist -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.laun

[Qemu-devel] [Bug 1289527] Re: qemu-aarch64-static: java dies with SIGILL

2014-08-08 Thread Serge Hallyn
Hi Dann, would you be able to provide the information requested in comment #1? ** Changed in: qemu (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/128952

[Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-08-08 Thread Serge Hallyn
I see this patch now applied in the git tree around June time frame, so marking Fix Released ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu) Status: New => Triaged ** Changed in: qemu (Ubuntu) Status: Triaged => Fix Released ** Changed

[Qemu-devel] [Bug 1350435] Re: tcg.c:1693: tcg fatal error

2014-08-08 Thread Serge Hallyn
https://launchpad.net/~serge-hallyn/+archive/ubuntu/qemu-user-thread contains a package with this patch applied (built for trusty). Please let us know how much it helps. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

[Qemu-devel] [patch] qcow2: double free snapshots

2014-08-08 Thread Zhang Haoyu
In qcow2_open(), if qcow2_read_snapshots() failed, qcow2_open() -> qcow2_free_snapshots() will be called, NULL snapshots dereference happened. because qcow2_free_snapshots has been performed before in the fail case of qcow2_read_snapshots(). shown as below callstack, qcow2_open |- qcow2_read_snap

[Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-08-08 Thread Michael Tokarev
Hmm. Speaking of "wrong" executables. We have another bugreport in debian, -- https://bugs.debian.org/754336 -- which might be related. But I tried qemu-2.1-rc and it didn't run these binaries. Is it not the same thing? (The debian bugreport has sample files attached). ** Bug watch added: Debi

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2014-08-08 Thread Erik de Castro Lopo
I've been looking at it over the last week or so and I have submitted a patch toe the qemu-devel mailing list to fix another timer_create() problem sometime in the last week. Unfortunately the test case @pittit submitted is far harder to support than the original test case. In this case the timer_

[Qemu-devel] [RFC PATCH v3 1/6] QEMUSizedBuffer/QEMUFile

2014-08-08 Thread Sanidhya Kashyap
From: "Dr. David Alan Gilbert" Stefan Berger's to create a QEMUFile that goes to a memory buffer; from: http://lists.gnu.org/archive/html/qemu-devel/2013-03/msg05036.html Using the QEMUFile interface, this patch adds support functions for operating on in-memory sized buffers that can be written

[Qemu-devel] [RFC PATCH v3 2/6] VMState test: get information about the registered devices

2014-08-08 Thread Sanidhya Kashyap
Added both qmp and hmp interface to get the information about the devices that have been qdevified and are registered with the SaveVMHandlers. I have not used any format to print the device information for the hmp interface. It would be great if anyone can give me some pointers about this about th

[Qemu-devel] [RFC PATCH v3 5/6] VMState test: update period of vmstate testing process

2014-08-08 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++ hmp.c| 14 ++ hmp.h| 1 + qapi-schema.json | 12 qmp-commands.hx | 21 + savevm.c | 13 + 6 files changed, 76 insertions(+) diff -

[Qemu-devel] [RFC PATCH v3 0/6] VMState testing

2014-08-08 Thread Sanidhya Kashyap
Hi, The following patch introduce a mechanism to test the correctness of the vmstate's information. This is achieved by saving the device states' information to a memory buffer and then clearing the states, followed by loading the data from the saved memory buffer. v2 --> v3 * Made the devices l

[Qemu-devel] [RFC PATCH v3 4/6] VMState test: querying the vmstate testing process

2014-08-08 Thread Sanidhya Kashyap
This patch has been updated to provide the following information: * Added a new return value in the form of devices' info that provides the device name as well as the version number. * provides the hmp interface - info test_vmstates and qmp interface - query-test-vmstates to obtain the information

[Qemu-devel] [RFC PATCH v3 3/6] VMstate test: basic VMState testing mechanism

2014-08-08 Thread Sanidhya Kashyap
This patch implements the basic way of testing the VMStates' information whether it is correct or not while saving and loading the states. The qmp interface - test-vmstates can take three parameters as an input to test the device states. Now, one can check for any of the devices that have been regi

[Qemu-devel] [RFC PATCH v3 6/6] VMState test: cancel mechanism for an already running vmstate testing process

2014-08-08 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 14 ++ hmp.c| 6 ++ hmp.h| 1 + qapi-schema.json | 9 + qmp-commands.hx | 20 savevm.c | 16 ++-- 6 files changed, 64 insertions(+), 2 deletions(-)

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-08-08 Thread Paolo Bonzini
> > Yeah, I need to sit down and look at the code more closely... Perhaps a > > cpu_mark_all_dirty() is enough. > > Hi Paolo, > > cpu_clean_all_dirty, you mean? Has the same effect. > > Marcin's patch to add cpu_synchronize_state_always() has the same > effect. > > What do you prefer ? I'd p

Re: [Qemu-devel] [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support

2014-08-08 Thread M.Kustova
On Fri, Aug 8, 2014 at 10:54 AM, Stefan Hajnoczi wrote: > On Wed, Aug 06, 2014 at 05:12:45PM +0400, Maria Kustova wrote: >> >> This patch series introduces the image fuzzer, a tool for stability and >> reliability testing. >> Its approach is to run large amount of tests in background. During every

Re: [Qemu-devel] [PATCH v6 6/7] exec: report error when memory < hpagesize

2014-08-08 Thread Hu Tao
On Thu, Aug 07, 2014 at 09:45:04PM +1000, Peter Crosthwaite wrote: > On Thu, Aug 7, 2014 at 7:10 PM, Hu Tao wrote: > > Report error when memory < hpagesize in file_ram_alloc() so callers can > > "an error" > > > handle the error. > > > > This patch fix a problem that if user adds a memory-backen

Re: [Qemu-devel] [PULL 17/19] target-i386: Support "invariant tsc" flag

2014-08-08 Thread chenliang (T)
Hi, We found that value of host cpus tsc are same to echo other when host has invariant tsc flag. But it is not in vm. The problem is that offset of vcpus tsc are not equal. The offset is set when vcpu is created. Is it ok to set same offset? And is it reasonable? Best regards Chen Liang From:

Re: [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-08 Thread Alex Bligh
On 7 Aug 2014, at 20:26, Serge E. Hallyn wrote: > A-ha, acpi wasn't a problem. I actually had a general migration > problem even when coming from other utopic hosts. With that fixed, > I've got successful migration from qemu-kvm 1.0 in precise to > a utopic host. That's good news. You might t

Re: [Qemu-devel] [PATCH 1/2] sheepdog: adopting protocol update for VDI locking

2014-08-08 Thread Liu Yuan
On Fri, Aug 08, 2014 at 03:12:17PM +0900, Hitoshi Mitake wrote: > At Fri, 8 Aug 2014 13:20:39 +0800, > Liu Yuan wrote: > > > > On Thu, Aug 07, 2014 at 04:28:39PM +0900, Hitoshi Mitake wrote: > > > The update is required for supporting iSCSI multipath. It doesn't > > > affect behavior of QEMU drive

Re: [Qemu-devel] [PATCH] block: add watermark event

2014-08-08 Thread Francesco Romani
- Original Message - > From: "Stefan Hajnoczi" > To: "Kevin Wolf" > Cc: mdr...@linux.vnet.ibm.com, "Francesco Romani" , > qemu-devel@nongnu.org, lcapitul...@redhat.com > Sent: Tuesday, August 5, 2014 3:08:46 PM > Subject: Re: [Qemu-devel] [PATCH] block: add watermark event > > On Tue, A

Re: [Qemu-devel] [PATCH v4 00/21] block: Handle failure for potentially large allocations

2014-08-08 Thread Kevin Wolf
Am 07.08.2014 um 20:34 hat Max Reitz geschrieben: > On 24.06.2014 17:36, Kevin Wolf wrote: > >A not too small part of the recent CVEs were DoS scenarios by letting > >qemu abort with too large memory allocations. We generally "fixed" these > >cases by setting some limits on values read from image f

Re: [Qemu-devel] [PATCH v2 1/2] contrib: add ivshmem client and server

2014-08-08 Thread David Marchand
Hello Markus, On 07/21/2014 07:35 PM, Markus Armbruster wrote: Do you have a compelling reason why you can't license under GPLv2+? If yes, please explain it to us. If no, please use * This work is licensed under the terms of the GNU GPL, version 2 or * later. See the COPYING file in the

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread Fam Zheng
On Wed, 08/06 17:12, Maria Kustova wrote: > The purpose of the test runner is to prepare the test environment (e.g. create > a work directory, a test image, etc), execute a program under test with > parameters, indicate a test failure if the program was killed during the test > execution and collec

[Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread David Marchand
Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some parts of the documentation and re-organise it. Signed-off-by: David Marchand --- docs/specs/ivshmem_device_

[Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread David Marchand
Here is a patchset containing an update on ivshmem specs documentation and importing ivshmem server and client tools. These tools have been written from scratch and are not related to what is available in nahanni repository. I put them in contrib/ directory as the qemu-doc.texi was already telling

[Qemu-devel] [PATCH v3 1/2] contrib: add ivshmem client and server

2014-08-08 Thread David Marchand
When using ivshmem devices, notifications between guests can be sent as interrupts using a ivshmem-server (typical use described in documentation). The client is provided as a debug tool. Signed-off-by: Olivier Matz Signed-off-by: David Marchand --- contrib/ivshmem-client/Makefile | 2

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread M.Kustova
On Fri, Aug 8, 2014 at 12:50 PM, Fam Zheng wrote: > On Wed, 08/06 17:12, Maria Kustova wrote: >> The purpose of the test runner is to prepare the test environment (e.g. >> create >> a work directory, a test image, etc), execute a program under test with >> parameters, indicate a test failure if t

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread Claudio Fontana
Hello David, On 08.08.2014 10:55, David Marchand wrote: > Add some notes on the parts needed to use ivshmem devices: more specifically, > explain the purpose of an ivshmem server and the basic concept to use the > ivshmem devices in guests. > Move some parts of the documentation and re-organise it

[Qemu-devel] [PATCH V3 0/3] image-fuzzer: Support L1/L2 tables in the qcow2 image generator

2014-08-08 Thread Maria Kustova
This patch series adds support of L1/L2 tables to the qcow2 image generator. This patch series was created for the 'block-next' branch and based on the next series: [PATCH V5 0/5] tests: Add the image fuzzer with qcow2 support. v2 -> v3: * Fixed wrong entry indices in the last L2 tabl

[Qemu-devel] [PATCH V3 2/3] fuzz: Add fuzzing functions for L1/L2 table entries

2014-08-08 Thread Maria Kustova
Signed-off-by: Maria Kustova --- tests/image-fuzzer/qcow2/fuzz.py | 28 1 file changed, 28 insertions(+) diff --git a/tests/image-fuzzer/qcow2/fuzz.py b/tests/image-fuzzer/qcow2/fuzz.py index a53c84f..57527f9 100644 --- a/tests/image-fuzzer/qcow2/fuzz.py +++ b/tests/

[Qemu-devel] [PATCH V3 1/3] docs: Expand the list of supported image elements with L1/L2 tables

2014-08-08 Thread Maria Kustova
Signed-off-by: Maria Kustova --- tests/image-fuzzer/docs/image-fuzzer.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/image-fuzzer/docs/image-fuzzer.txt b/tests/image-fuzzer/docs/image-fuzzer.txt index efe0ed4..2e8e3b9 100644 --- a/tests/image-fuzzer/docs/image-fu

[Qemu-devel] [PATCH V3 3/3] layout: Add generators of L1/L2 tables

2014-08-08 Thread Maria Kustova
Entries in L1/L2 entries are based on a portion of random guest clusters. L2 entries contain offsets to host image clusters filled with random data. Clusters for L1/L2 tables and guest data are selected randomly. Signed-off-by: Maria Kustova --- tests/image-fuzzer/qcow2/layout.py | 255 +

Re: [Qemu-devel] [PATCH 0/3] qcow2: Prevent corruption-related crashes

2014-08-08 Thread Kevin Wolf
Am 07.08.2014 um 22:47 hat Max Reitz geschrieben: > The first two patches in this series address > https://bugs.launchpad.net/qemu/+bug/1349972. > > For the third patch I found it hard to write an appropriate test case > (it would have to make qemu-img check repair some leaks but induce the > corr

Re: [Qemu-devel] [PATCH 3/3] block: Catch !bs->drv in bdrv_check()

2014-08-08 Thread Kevin Wolf
Am 07.08.2014 um 22:47 hat Max Reitz geschrieben: > qemu-img check calls bdrv_check() twice if the first run repaired some > inconsistencies. If the first run however again triggered corruption > prevention (on qcow2) due to very bad inconsistencies, bs->drv may be > NULL afterwards. Thus, bdrv_che

[Qemu-devel] [PATCH v4 07/10] linux-user: check return value of malloc()

2014-08-08 Thread zhanghailiang
Signed-off-by: zhanghailiang --- linux-user/syscall.c | 4 1 file changed, 4 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index a50229d..8e5ccf1 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2870,6 +2870,10 @@ static inline abi_long do_msgsnd(int

[Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread zhanghailiang
Signed-off-by: zhanghailiang --- slirp/misc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..9b457ad 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -55,6 +55,10 @@ int add_exec(struct ex_list **ex_ptr, int do_pty, char *exe

[Qemu-devel] [PATCH v4 09/10] tcg: check return value of fopen()

2014-08-08 Thread zhanghailiang
From: Li Liu Give a warning message if fopen() failed to open the log file. Signed-off-by: zhanghailiang Signed-off-by: Li Liu --- tcg/tcg.c | 4 1 file changed, 4 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index c068990..8f50d2a 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2406,6 +

[Qemu-devel] [PATCH v4 04/10] ivshmem: check the value returned by fstat()

2014-08-08 Thread zhanghailiang
The function fstat() may fail, so check its return value. Acked-by: Levente Kurusa Signed-off-by: zhanghailiang --- hw/misc/ivshmem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c index 768e528..2be4b86 100644 --- a/hw/misc/ivshme

[Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc()

2014-08-08 Thread zhanghailiang
Reviewed-by: Gonglei Signed-off-by: zhanghailiang --- util/path.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/path.c b/util/path.c index 5c59d9f..df1653f 100644 --- a/util/path.c +++ b/util/path.c @@ -46,9 +46,12 @@ static struct pathelem *new_entry(const ch

[Qemu-devel] [PATCH v4 00/10] fix three bugs about use-after-free and several api abuse

2014-08-08 Thread zhanghailiang
This patch set fix three bugs about accessing freed memory and several api abuse. In qemu, there are serveral places that do not check the return value of fstat()/fopen()/malloc(). Though it is a small probability for the these functions to fail, but it is better to fix them, Or there may be a

[Qemu-devel] [PATCH v4 03/10] virtio-blk: fix reference a pointer which might be freed

2014-08-08 Thread zhanghailiang
In function virtio_blk_handle_request, it may freed memory pointed by req, So do not access member of req after calling this function. Reviewed-by: Stefan Hajnoczi Signed-off-by: zhanghailiang --- hw/block/virtio-blk.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH v4 02/10] monitor: fix access freed memory

2014-08-08 Thread zhanghailiang
The function monitor_fdset_dup_fd_find_remove() references member of 'mon_fdset' which may be freed in function monitor_fdset_cleanup() Reviewed-by: Gonglei Signed-off-by: zhanghailiang --- monitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c in

[Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen()

2014-08-08 Thread zhanghailiang
The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiang Signed-off-by: Li Liu --- tests/bios-tables-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c index 045eb27..6a357c0 100644 --- a/tests/bios-tabl

[Qemu-devel] [PATCH v4 10/10] block/vvfat: fix setbuf stream parameter may be NULL

2014-08-08 Thread zhanghailiang
From: Li Liu fopen() may return NULL which will cause setbuf() segmentfault Signed-off-by: zhanghailiang Signed-off-by: Li Liu --- block/vvfat.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index 70176b1..6889ea9 100644 --- a/block/vvfa

[Qemu-devel] [PATCH v4 01/10] l2cap: fix access freed memory

2014-08-08 Thread zhanghailiang
Pointer 'ch' will be used in function 'l2cap_channel_open_req_msg' after it was previously freed in 'l2cap_channel_open'. Assigned it to NULL after it is freed. Reviewed-by: Alex Bennée Signed-off-by: zhanghailiang --- hw/bt/l2cap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add > client/server tools > > Here is a patchset containing an update on ivshmem specs documentation and > importing ivshmem server and client tools. > These tools have been written from scratch and are not related to what

[Qemu-devel] [PATCH V2] layout: Reduce number of generator functions in __init__

2014-08-08 Thread Maria Kustova
Some issues can be found only when a fuzzed image has a partial structure, e.g. has L1/L2 tables but no refcount ones. Generation of an entirely defined image limits these cases. Now the Image constructor creates only a header and a backing file name (if any), other image elements are generated in

Re: [Qemu-devel] [PATCH v3 2/2] docs: update ivshmem device spec

2014-08-08 Thread David Marchand
Hello Claudio, On 08/08/2014 11:04 AM, Claudio Fontana wrote: On 08.08.2014 10:55, David Marchand wrote: Add some notes on the parts needed to use ivshmem devices: more specifically, explain the purpose of an ivshmem server and the basic concept to use the ivshmem devices in guests. Move some p

Re: [Qemu-devel] [PATCH v4 01/15] target-tricore: Add target stubs and qom-cpu

2014-08-08 Thread Bastian Koppelmann
On 08/08/2014 03:28 AM, Richard Henderson wrote: On 08/07/2014 04:34 AM, Bastian Koppelmann wrote: +/* PSW flag cache for faster execution + if flag != 0 then flag is set. Else flag is not set. +*/ +target_ulong PSW_USB_C; +target_ulong PSW_USB_V; +target_ulong PSW_USB

Re: [Qemu-devel] [PULL v2 00/11] KVM, icount changes for 2014-08-06

2014-08-08 Thread Peter Maydell
On 7 August 2014 14:34, Paolo Bonzini wrote: > The following changes since commit 41a1a9c42c4e0fb5f1b94aa8b72e42f66ebde3d9: > > po: Update German translation (2014-07-28 23:37:17 +0200) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git tags/for-upstream > > for

Re: [Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: > Reviewed-by: Gonglei > Signed-off-by: zhanghailiang > --- > util/path.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/util/path.c b/util/path.c > index 5c59d9f..df1653f 100644 > --- a/util/path.c > +++ b/util/path.c > @@ -46,9 +46,12

Re: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: > Signed-off-by: zhanghailiang > --- > slirp/misc.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/slirp/misc.c b/slirp/misc.c > index b8eb74c..9b457ad 100644 > --- a/slirp/misc.c > +++ b/slirp/misc.c > @@ -55,6 +55,10 @@ int add_exec(str

Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread David Marchand
Hello Gonglei, On 08/08/2014 11:30 AM, Gonglei (Arei) wrote: If you can describe the steps of using example about your ivshmem-client and ivshmem-server will be great IMHO. I already have included a note in the qemu-doc.texi file on how to start the ivshmem-server. The (debug) client is star

Re: [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: > The function fopen() may fail, so check its return value. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Liu > --- > tests/bios-tables-test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c > index 045

[Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Gaurav Sharma
Hi, I am trying to test the floating point instruction for arm in qemu. For floating point reciprocal estimate instruction, for a64 i see a check for underflow condition in float64 HELPER(recpe_f64) method : " else if (f64_exp >= 1023 && fpst->flush_to_zero) " 1. how do we calculate the value to

Re: [Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Peter Maydell
On 8 August 2014 11:02, Gaurav Sharma wrote: > I am trying to test the floating point instruction for arm in qemu. > For floating point reciprocal estimate instruction, for a64 i see a check > for underflow condition in float64 HELPER(recpe_f64) method : > > " else if (f64_exp >= 1023 && fpst->flu

Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add client/server tools

2014-08-08 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, > add client/server tools > > Hello Gonglei, > > On 08/08/2014 11:30 AM, Gonglei (Arei) wrote: > > If you can describe the steps of using example about > > your ivshmem-client and ivshmem-server will be great IMHO. >

Re: [Qemu-devel] [PATCH v4 01/15] target-tricore: Add target stubs and qom-cpu

2014-08-08 Thread Bastian Koppelmann
On 08/08/2014 11:40 AM, Bastian Koppelmann wrote: On 08/08/2014 03:28 AM, Richard Henderson wrote: On 08/07/2014 04:34 AM, Bastian Koppelmann wrote: +/* PSW flag cache for faster execution + if flag != 0 then flag is set. Else flag is not set. +*/ +target_ulong PSW_USB_C; +

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-08 Thread Ming Lei
On Thu, Aug 7, 2014 at 9:51 PM, Kevin Wolf wrote: > Am 07.08.2014 um 12:27 hat Ming Lei geschrieben: >> On Wed, Aug 6, 2014 at 11:40 PM, Kevin Wolf wrote: >> > Am 06.08.2014 um 13:28 hat Ming Lei geschrieben: >> >> On Wed, Aug 6, 2014 at 6:09 PM, Kevin Wolf wrote: >> >> > Am 06.08.2014 um 11:37

Re: [Qemu-devel] [PATCH v4 05/10] util/path: check return value of malloc()

2014-08-08 Thread zhanghailiang
On 2014/8/8 17:36, Alex Bennée wrote: zhanghailiang writes: Reviewed-by: Gonglei Signed-off-by: zhanghailiang --- util/path.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/util/path.c b/util/path.c index 5c59d9f..df1653f 100644 --- a/util/path.c +++ b/util/pat

Re: [Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Peter Maydell
On 8 August 2014 11:25, Peter Maydell wrote: > Since we've already dealt with the NaN and infinity and > denormal cases by this point in the code, we know that >value == (-1)^S * 2^(exp-1023) * 1.frac > If you plug in the value == 2.0^1022 and work it out > you'll find that this corresponds to

Re: [Qemu-devel] Checking underflow condition for FRCPE instr [AARCH64]

2014-08-08 Thread Gaurav Sharma
My bad, I was not specific. Actually, i am trying to run some test on qemu to verify some instructions. For which i build a binary and load it on qemu in my environment and test the output. In this case even i am not sure, if the output i get from qemu is correct or not. [Use case] [sample - Instr

Re: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread zhanghailiang
On 2014/8/8 17:43, Alex Bennée wrote: zhanghailiang writes: Signed-off-by: zhanghailiang --- slirp/misc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index b8eb74c..9b457ad 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -55,6 +55

Re: [Qemu-devel] [PATCH v4 08/10] tests/bios-tables-test: check the value returned by fopen()

2014-08-08 Thread zhanghailiang
On 2014/8/8 17:51, Alex Bennée wrote: zhanghailiang writes: The function fopen() may fail, so check its return value. Signed-off-by: zhanghailiang Signed-off-by: Li Liu --- tests/bios-tables-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/bios-tables-test.c b/tests/bios-

Re: [Qemu-devel] [PATCH V5 2/5] runner: Tool for fuzz tests execution

2014-08-08 Thread Fam Zheng
On Fri, 08/08 12:58, M.Kustova wrote: > On Fri, Aug 8, 2014 at 12:50 PM, Fam Zheng wrote: > > On Wed, 08/06 17:12, Maria Kustova wrote: > >> The purpose of the test runner is to prepare the test environment (e.g. > >> create > >> a work directory, a test image, etc), execute a program under test

Re: [Qemu-devel] [PULL 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Peter Maydell
On 7 August 2014 23:18, Eric Blake wrote: > On 08/07/2014 04:10 PM, Michael Roth wrote: >> Please pull the following changes, which add a new guest-fsfreeze-freeze-list >> command to qemu-ga that supports specifying specific mounts to freeze, and >> improves the introspection information from gues

Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support

2014-08-08 Thread Ming Lei
On Fri, Aug 8, 2014 at 6:32 PM, Ming Lei wrote: > On Thu, Aug 7, 2014 at 9:51 PM, Kevin Wolf wrote: >> Am 07.08.2014 um 12:27 hat Ming Lei geschrieben: >>> On Wed, Aug 6, 2014 at 11:40 PM, Kevin Wolf wrote: >>> > Am 06.08.2014 um 13:28 hat Ming Lei geschrieben: >>> >> On Wed, Aug 6, 2014 at 6:09

[Qemu-devel] [PATCH 05/11] target-arm: Don't allow AArch32 to access RES0 CPSR bits

2014-08-08 Thread Peter Maydell
The CPSR has a new-in-v8 execution state bit (IL), and also some state which has effects in AArch32 but appears only in the SPSR format (SS) but is RES0 in the CPSR. Add the IL bit to CPSR_EXEC, and enforce that guest direct reads and writes to CPSR can't read or write the RES0 bits, so the guest

[Qemu-devel] [PATCH 00/11] target-arm: Implement ARMv8 debug single-stepping

2014-08-08 Thread Peter Maydell
This patchset implements the ARMv8 architecturally defined software singlestepping. This is necessary to support running gdb or gdbserver inside a Linux guest, because Linux assumes the presence of this (mandatory) architectural feature and uses it to implement PTRACE_SINGLESTEP for 64-bit debuggee

[Qemu-devel] [PATCH 04/11] target-arm: Adjust debug ID registers per-CPU

2014-08-08 Thread Peter Maydell
Allow each CPU type to specify the value for the debug ID registers, by putting them in the ARMCPU struct, and use the resulting information to only expose the correct number of watchpoint and breakpoint registers for the CPU. Signed-off-by: Peter Maydell --- target-arm/cpu-qom.h | 1 + target-

[Qemu-devel] [PATCH 08/11] target-arm: A64: Avoid duplicate exit_tb(0) in non-linked goto_tb

2014-08-08 Thread Peter Maydell
If gen_goto_tb() decides not to link the two TBs, then the fallback path generates unnecessary code: * if singlestep is enabled then we generate unreachable code after the gen_exception_internal(EXCP_DEBUG) * if singlestep is disabled then we will generate exit_tb(0) twice, once in gen_goto

[Qemu-devel] [PATCH 02/11] target-arm: Allow STATE_BOTH reginfo descriptions for more than cp14

2014-08-08 Thread Peter Maydell
Currently the STATE_BOTH shorthand for allowing a single reginfo struct to define handling for both AArch32 and AArch64 views of a register only permits this where the AArch32 view is in cp15. It turns out that the debug registers in cp14 also have neatly lined up encodings; allow these also to sha

[Qemu-devel] [PATCH 07/11] target-arm: Set PSTATE.SS correctly on exception return from AArch64

2014-08-08 Thread Peter Maydell
Set the PSTATE.SS bit correctly on exception returns from AArch64, as required by the debug single-step functionality. Signed-off-by: Peter Maydell --- target-arm/cpu.h | 61 ++ target-arm/op_helper.c | 20 + 2 files changed,

[Qemu-devel] [PATCH 01/11] target-arm: Collect up the debug cp register definitions

2014-08-08 Thread Peter Maydell
At the moment we have a mixed set of mostly dummy register definitions for various debug related registers which have been added piecemeal in order to get Linux kernels to boot. In preparation for actually implementing debug support, bring them all together into one place. This commit doesn't chan

[Qemu-devel] [PATCH 09/11] target-arm: Implement ARMv8 single-step handling for A64 code

2014-08-08 Thread Peter Maydell
Implement ARMv8 software single-step handling for A64 code: correctly update the single-step state machine and generate debug exceptions when stepping A64 code. This patch has no behavioural change since MDSCR_EL1.SS can't be set by the guest yet. Signed-off-by: Peter Maydell --- target-arm/cpu

[Qemu-devel] [PATCH 11/11] target-arm: Implement MDSCR_EL1 as having state

2014-08-08 Thread Peter Maydell
Now that all the new code to support single-stepping is in place, wire up the guest-visible MDSCR_EL1, so the guest can enable single-stepping. Signed-off-by: Peter Maydell --- target-arm/helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target

[Qemu-devel] [PATCH 06/11] target-arm: Correctly handle PSTATE.SS when taking exception to AArch32

2014-08-08 Thread Peter Maydell
When an exception is taken to AArch32, we must clear the PSTATE.SS bit for the exception handler, and must also ensure that the SS bit is not set in the value saved to SPSR_. Achieve both of these aims by clearing the bit in uncached_cpsr before saving it to the SPSR. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 03/11] target-arm: Provide both 32 and 64 bit versions of debug registers

2014-08-08 Thread Peter Maydell
Bring the 32 bit and 64 bit views of the debug registers into line by providing the same set of registers in both cases. (This still isn't a complete set, but it is consistent.) Signed-off-by: Peter Maydell --- target-arm/helper.c | 34 -- 1 file changed, 20 inser

[Qemu-devel] [PATCH 10/11] target-arm: Implement ARMv8 single-stepping for AArch32 code

2014-08-08 Thread Peter Maydell
ARMv8 single-stepping requires the exception level that controls the single-stepping to be in AArch64 execution state, but the code being stepped may be in AArch64 or AArch32. Implement the necessary support code for single-stepping AArch32 code. Signed-off-by: Peter Maydell --- target-arm/cpu.h

Re: [Qemu-devel] [PATCH] linux-user: fix readlink handling with magic exe symlink

2014-08-08 Thread Eric Blake
On 08/07/2014 06:40 PM, Mike Frysinger wrote: > From: Mike Frysinger > > The current code always returns the length of the path when it should > be returning the number of bytes it wrote to the output string. That is indeed a bug. > > Further, readlink is not supposed to append a NUL byte, but

Re: [Qemu-devel] [PATCH] block: add watermark event

2014-08-08 Thread Eric Blake
On 08/08/2014 02:01 AM, Francesco Romani wrote: So let the block-set-watermark caller pass an absolute sector number instead. It keeps things simple for both QEMU and thin provisioning manager. >>> >>> No sector numbers in external interfaces, please. These units of 512 >>> bytes a

Re: [Qemu-devel] [PULL 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Michael Roth
Quoting Peter Maydell (2014-08-08 06:12:34) > On 7 August 2014 23:18, Eric Blake wrote: > > On 08/07/2014 04:10 PM, Michael Roth wrote: > >> Please pull the following changes, which add a new > >> guest-fsfreeze-freeze-list > >> command to qemu-ga that supports specifying specific mounts to freez

[Qemu-devel] [PULL v2 0/3] qga: support fsfreeze'ing specific mounts

2014-08-08 Thread Michael Roth
Hello, Please pull the following changes, which add a new guest-fsfreeze-freeze-list command to qemu-ga that supports specifying specific mounts to freeze, and improves the introspection information from guest-info by explicitly blacklisting/reporting commands that aren't supported on a particular

[Qemu-devel] [PATCH 3/3] qga: Disable unsupported commands by default

2014-08-08 Thread Michael Roth
From: Tomoki Sekiyama Currently management softwares cannot know whether a qemu-ga command is supported or not on the running platform until they actually execute it. This patch disables unsupported commands at launch time of qemu-ga, so that management softwares can check whether they are suppor

[Qemu-devel] [PATCH 1/3] qga: Add guest-fsfreeze-freeze-list command

2014-08-08 Thread Michael Roth
From: Tomoki Sekiyama If an array of mount point paths is specified as 'mountpoints' argument of guest-fsfreeze-freeze-list, qemu-ga will only freeze the file systems mounted on specified paths in Linux guests. Otherwise, it works as the same way as guest-fsfreeze-freeze. This would be useful whe

[Qemu-devel] [PATCH 2/3] qga: Add guest-get-fsinfo command

2014-08-08 Thread Michael Roth
From: Tomoki Sekiyama Add command to get mounted filesystems information in the guest. The returned value contains a list of mountpoint paths and corresponding disks info such as disk bus type, drive address, and the disk controllers' PCI addresses, so that management layer such as libvirt can re

Re: [Qemu-devel] [PATCH V5 3/5] fuzz: Fuzzing functions for qcow2 images

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:48PM +0400, Maria Kustova wrote: > The fuzz submodule of the qcow2 image generator contains fuzzing functions for > image fields. > Each fuzzing function contains a list of constraints and a call of a helper > function that randomly selects a fuzzed value satisfied to

Re: [Qemu-devel] [PATCH V5 5/5] package: Public API for image-fuzzer/runner/runner.py

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:50PM +0400, Maria Kustova wrote: > __init__.py provides the public API required by the test runner > > Signed-off-by: Maria Kustova > --- > tests/image-fuzzer/qcow2/__init__.py | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tests/image-fuzzer/qcow2/__

Re: [Qemu-devel] [PATCH V5 4/5] layout: Generator of fuzzed qcow2 images

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 05:12:49PM +0400, Maria Kustova wrote: > The layout submodule of the qcow2 package creates a random valid image, > randomly selects some amount of its fields, fuzzes them and write the fuzzed > image to the file. Fuzzing process can be controlled by an external > configurati

Re: [Qemu-devel] [Bug 1353545] Re: QED does not deliver flush on synchronized write

2014-08-08 Thread Stefan Hajnoczi
On Wed, Aug 06, 2014 at 03:32:29PM -, Nybble wrote: > ** Changed in: qemu >Status: New => Invalid I guess you saw that bdrv_co_flush() calls bdrv_co_flush(bs->file). This means that even block drivers that do not provide ->bdrv_co_flush_to_disk() will have fdatasync() called on their i

Re: [Qemu-devel] [PATCH v4 06/10] slirp/misc: check return value of malloc()

2014-08-08 Thread Alex Bennée
zhanghailiang writes: > On 2014/8/8 17:43, Alex Bennée wrote: >> >> zhanghailiang writes: >> >>> Signed-off-by: zhanghailiang >>> --- >>> slirp/misc.c | 9 +++-- >>> 1 file changed, 7 insertions(+), 2 deletions(-) >>> >> >> Your indenting has gone a bit weird there. > > Hmm, this file has

[Qemu-devel] [PATCH 1/2] target-arm: Rename QEMU PSCI v0.1 definitions

2014-08-08 Thread Christoffer Dall
The function IDs for PSCI v0.1 are exported by KVM and defined as KVM_PSCI_FN_. To build using these defines in non-KVM code, QEMU defines these IDs locally and check their correctness against the KVM headers when those are available. However, the naming scheme used for QEMU (almost) clashes with

[Qemu-devel] [PATCH v2 2/2] arm/virt: Use PSCI v0.2 function IDs in the DT when KVM uses PSCI v0.2

2014-08-08 Thread Christoffer Dall
The current code supplies the PSCI v0.1 function IDs in the DT even when KVM uses PSCI v0.2. This will break guest kernels that only support PSCI v0.1 as they will use the IDs provided in the DT. Guest kernels with PSCI v0.2 support are not affected by this patch, because they ignore the function

  1   2   3   >