Re: [Qemu-devel] [PATCH] cadence_uart: check for serial backend before using it.

2014-07-16 Thread Frederic Konrad
On 16/07/2014 05:48, Peter Crosthwaite wrote: On Wed, Jul 16, 2014 at 1:18 AM, wrote: From: KONRAD Frederic This checks that s->chr is not NULL before using it. Signed-off-by: KONRAD Frederic --- hw/char/cadence_uart.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(

Re: [Qemu-devel] [PATCH] linux-user: Add binfmt wrapper

2014-07-16 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/07/16 08:54:45: > > On Tue, Jul 15, 2014 at 05:11:48PM +0200, Joakim Tjernlund wrote: > > Riku Voipio wrote on 2014/07/15 16:12:26: > > > On Mon, Jul 14, 2014 at 05:38:49PM +0200, Joakim Tjernlund wrote: > > > > Alexander Graf wrote on 2014/07/14 17:21:33: > > > > > On

[Qemu-devel] Bogus struct stat64 for qemu-microblaze (user emulation)?

2014-07-16 Thread Rich Felker
The qemu-microblaze definition of struct stat64 seems to mismatch the kernel definition, which is using asm-generic/stat.h. See: http://git.qemu.org/?p=qemu.git;a=blob;f=linux-user/syscall_defs.h;h=c9e6323905486452f518102bf40ba73143c9d601;hb=HEAD#l1469 http://git.qemu.org/?p=qemu.git;a=blob;f=linu

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-16 Thread Marcin Gibuła
Andrey, Can you please provide instructions on how to create reproducible environment? The following patch is equivalent to the original patch, for the purposes of fixing the kvmclock problem. Perhaps it becomes easier to spot the reason for the hang you are experiencing. Marcelo, the origin

[Qemu-devel] Help on vm (winxp sp3) having no sound

2014-07-16 Thread 楼正伟
Hi all, I have one vm (winxp sp3), but it has no sound. I was using intel hda, but the guest could not find the driver for "Audio Device on High Definition Audio Bus". The vm is created by qemu-kvm on host which is centos6.4. The command is: qemu-system-x86_64 -enable-kvm -device intel-hda,id=sou

[Qemu-devel] [PATCH for-2.1] cadence_uart: check serial backend before using it.

2014-07-16 Thread fred . konrad
From: KONRAD Frederic Segfault occurs when there are less than two serial backends with zynq platform. This checks that s->chr is not NULL before using it. Signed-off-by: KONRAD Frederic Reviewed-by: Peter Crosthwaite --- hw/char/cadence_uart.c | 14 ++ 1 file changed, 10 inserti

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-16 Thread Riku Voipio
On Sat, Jul 12, 2014 at 04:06:09PM +0200, Joakim Tjernlund wrote: > Alexander Graf wrote on 2014/07/12 12:41:05: > > > > On 12.07.14 12:40, Peter Maydell wrote: > > > On 12 July 2014 10:39, Alexander Graf wrote: > > >> On 12.07.14 10:58, Peter Maydell wrote: > > >>> On 12 July 2014 01:39, Alexan

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-16 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/07/16 09:55:50: > From: Riku Voipio > To: Joakim Tjernlund , > Cc: Alexander Graf , Peter Maydell , "qemu-...@nongnu.org" , QEMU Developers > Date: 2014/07/16 09:55 > Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging > > On Sat, Jul 12

Re: [Qemu-devel] Bogus struct stat64 for qemu-microblaze (user emulation)?

2014-07-16 Thread Peter Maydell
On 16 July 2014 05:02, Rich Felker wrote: > The qemu-microblaze definition of struct stat64 seems to mismatch the > kernel definition, which is using asm-generic/stat.h. See: > > http://git.qemu.org/?p=qemu.git;a=blob;f=linux-user/syscall_defs.h;h=c9e6323905486452f518102bf40ba73143c9d601;hb=HEAD#l

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-16 Thread Andrey Korolyov
On Wed, Jul 16, 2014 at 5:16 AM, Marcelo Tosatti wrote: > On Wed, Jul 16, 2014 at 03:40:47AM +0400, Andrey Korolyov wrote: >> On Wed, Jul 16, 2014 at 2:01 AM, Paolo Bonzini wrote: >> > Il 15/07/2014 23:25, Andrey Korolyov ha scritto: >> > >> >> On Wed, Jul 16, 2014 at 1:09 AM, Marcelo Tosatti >>

Re: [Qemu-devel] hw/arm: add Lego NXT board

2014-07-16 Thread Alexander Graf
On 07/15/2014 10:09 PM, Paolo Bonzini wrote: BTW, sorry for the confusion. There is another frequent contributor to QEMU with the same name as yours. I only noticed now that the email address is different. Oh right I noticed that; should have said something. 4. Now, thanks to the help on th

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-16 Thread Alexander Graf
> Am 16.07.2014 um 10:32 schrieb Joakim Tjernlund > : > > Riku Voipio wrote on 2014/07/16 09:55:50: > >> From: Riku Voipio >> To: Joakim Tjernlund , >> Cc: Alexander Graf , Peter Maydell > , "qemu-...@nongnu.org" , > QEMU Developers >> Date: 2014/07/16 09:55 >> Subject: Re: [Qemu-devel] [Q

Re: [Qemu-devel] hw/arm: add Lego NXT board

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 10:40, Alexander Graf ha scritto: I think that there are two other ways to do it. And what about the chardev way? Your silence in this regard is misterious ;-) The main problem with chardevs is that they are completely asynchronous. So they may not be a good match for your

[Qemu-devel] [PULL for-2.1] virtio-serial: bugfix for virtconsole port unplug

2014-07-16 Thread Amit Shah
Hi, This is a small bugfix to prevent port unplug causing port 0 getting unreserved for virtconsole use. Patch has been on-list for a few days and has been reviewed. Please pull. The following changes since commit 5a7348045091a2bc15d85bb177e5956aa6114e5a: Update version for v2.1.0-rc2 relea

[Qemu-devel] [PULL for-2.1] migration: detect section renames in vmstate static checker script

2014-07-16 Thread Amit Shah
Hi, A minor enhancement to the static checker script that detects section renames. One such rename was added recently (ICH9-LPC -> ICH9 LPC). This doesn't affect the qemu code, and enhances a test program, so I recommend we pull it for 2.1. Patch has been on list for a few days. The following

[Qemu-devel] [PULL for-2.1] virtio-rng: Fix abort on invalid input

2014-07-16 Thread Amit Shah
Hi, This patch returns an error instead of aborting, which is desirable not just for cmdline invocation, but prevents an abort in case of device hotplug. Patch is small, and reviewed on-list. Please pull, The following changes since commit 5a7348045091a2bc15d85bb177e5956aa6114e5a: Update ver

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-16 Thread Alex Bennée
Joakim Tjernlund writes: > Alexander Graf wrote on 2014/07/12 02:39:21: >> >> >> On 11.07.14 20:22, Peter Maydell wrote: >> > On 11 July 2014 19:15, Joakim Tjernlund > wrote: >> >> Peter Maydell wrote on 2014/07/11 > 19:14:25: >> >>> On 11 July 2014 16:18, Joakim Tjernlund > >> >> wrote:

Re: [Qemu-devel] [PATCH 15/46] Rework loadvm path for subloops

2014-07-16 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 07/07/2014 16:35, Dr. David Alan Gilbert ha scritto: > >* Paolo Bonzini (pbonz...@redhat.com) wrote: > >>Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: > >>>From: "Dr. David Alan Gilbert" > >>> > >>>Postcopy needs to have two migrati

Re: [Qemu-devel] [PATCH 07/46] Return path: Open a return path on QEMUFile for sockets

2014-07-16 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 04/07/2014 19:41, Dr. David Alan Gilbert (git) ha scritto: > >From: "Dr. David Alan Gilbert" > > > >Postcopy needs a method to send messages from the destination back to > >the source, this is the 'return path'. > > > >+/* Give a QEMUFile* off t

Re: [Qemu-devel] [PATCH 07/46] Return path: Open a return path on QEMUFile for sockets

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 11:37, Dr. David Alan Gilbert ha scritto: + +/* If it's already open, return it */ +if (qfs->file->return_path) { +return qfs->file->return_path; Wouldn't this leave a dangling file descriptor if you call socket_dup_return_path twice, and then close the original Q

Re: [Qemu-devel] [PATCH] Tap: fix vcpu long time io blocking on tap

2014-07-16 Thread Wangkai (Kevin,C)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Tuesday, July 15, 2014 11:00 PM > To: Wangkai (Kevin,C) > Cc: Stefan Hajnoczi; Lee yang; qemu-devel@nongnu.org; > aligu...@amazon.com > Subject: Re: [Qemu-devel] [PATCH] Tap: fix vcpu long time io blocking >

[Qemu-devel] [Bug 1185228] Re: with 'monitor pty', it needs to flush pts device after sending command to it

2014-07-16 Thread Paolo Bonzini
This is not a bug. What happens is that QEMU echoes the command you type onto the PTY. If you do not do a "cat /dev/pts/8", the PTY's buffer gets full and QEMU stops reading from the PTY until it is emptied. It doesn't happen if you use QMP. ** Changed in: qemu Status: New => Invalid --

[Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name

2014-07-16 Thread Amit Shah
Hi, The 2nd patch prevents adding ports to the system with conflicts in the 'name' parameter. This is done by going through all the ports in the system, including ports on other virtio-serial devices. The first patch prepares for this by creating a linked list of all available virtio-serial devi

[Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices

2014-07-16 Thread Amit Shah
To ensure two virtserialports don't get added to the system with the same 'name' parameter, we need to access all the ports on all the devices added, and compare the names. We currently don't have a list of all VirtIOSerial devices added to the system. This commit adds a simple linked list in whi

[Qemu-devel] [PATCH 2/2] virtio-serial: search for duplicate port names before adding new ports

2014-07-16 Thread Amit Shah
Before adding new ports to VirtIOSerial devices, check if there's a conflict in the 'name' parameter. This ensures two virtserialports with identical names are not initialized. Reported-by: Signed-off-by: Amit Shah --- hw/char/virtio-serial-bus.c | 22 ++ 1 file changed, 22

Re: [Qemu-devel] [PATCH] linux-user: Add binfmt wrapper

2014-07-16 Thread Joakim Tjernlund
Riku Voipio wrote on 2014/07/16 08:54:45: > > On Tue, Jul 15, 2014 at 05:11:48PM +0200, Joakim Tjernlund wrote: > > Riku Voipio wrote on 2014/07/15 16:12:26: > > > On Mon, Jul 14, 2014 at 05:38:49PM +0200, Joakim Tjernlund wrote: > > > > Alexander Graf wrote on 2014/07/14 17:21:33: > > > > > On

Re: [Qemu-devel] [PATCH 07/46] Return path: Open a return path on QEMUFile for sockets

2014-07-16 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 16/07/2014 11:37, Dr. David Alan Gilbert ha scritto: > >>> > >>>+ > >>>+/* If it's already open, return it */ > >>>+if (qfs->file->return_path) { > >>>+return qfs->file->return_path; > >> > >>Wouldn't this leave a dangling file descr

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-16 Thread Marcelo Tosatti
On Wed, Jul 16, 2014 at 12:38:51PM +0400, Andrey Korolyov wrote: > On Wed, Jul 16, 2014 at 5:16 AM, Marcelo Tosatti wrote: > > On Wed, Jul 16, 2014 at 03:40:47AM +0400, Andrey Korolyov wrote: > >> On Wed, Jul 16, 2014 at 2:01 AM, Paolo Bonzini wrote: > >> > Il 15/07/2014 23:25, Andrey Korolyov ha

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-16 Thread Marcelo Tosatti
On Wed, Jul 16, 2014 at 09:35:16AM +0200, Marcin Gibuła wrote: > >Andrey, > > > >Can you please provide instructions on how to create reproducible > >environment? > > > >The following patch is equivalent to the original patch, for > >the purposes of fixing the kvmclock problem. > > > >Perhaps it be

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] ppc: remove excessive logging

2014-07-16 Thread Peter Maydell
On 16 July 2014 10:17, Alex Bennée wrote: > On aarch64 we do: > > #define unsupported_encoding(s, insn)\ > do { \ > qemu_log_mask(LOG_UNIMP, \ >

[Qemu-devel] [RFC PATCH V4 3/6] icount: Make icount_time_shift available everywhere

2014-07-16 Thread Sebastian Tanase
icount_time_shift is used for calculting the delay qemu has to sleep in order to synchronise the host and guest clocks. Therefore, we need it in cpu-exec.c. Signed-off-by: Sebastian Tanase Tested-by: Camille Bégué Signed-off-by: Paolo Bonzini --- cpus.c| 8 ++-- include/qem

[Qemu-devel] [RFC PATCH V4 1/6] icount: Add QemuOpts for icount

2014-07-16 Thread Sebastian Tanase
Make icount parameter use QemuOpts style options in order to easily add other suboptions. Signed-off-by: Sebastian Tanase Tested-by: Camille Bégué Signed-off-by: Paolo Bonzini --- cpus.c| 10 +- include/qemu-common.h | 3 ++- qemu-options.hx | 4 ++-- qtest.c

[Qemu-devel] [RFC PATCH V4 4/6] cpu_exec: Add sleeping algorithm

2014-07-16 Thread Sebastian Tanase
The goal is to sleep qemu whenever the guest clock is in advance compared to the host clock (we use the monotonic clocks). The amount of time to sleep is calculated in the execution loop in cpu_exec. At first, we tried to approximate at each for loop the real time elapsed while searching for a TB

[Qemu-devel] [RFC PATCH V4 5/6] cpu_exec: Print to console if the guest is late

2014-07-16 Thread Sebastian Tanase
If the align option is enabled, we print to the user whenever the guest clock is behind the host clock in order for he/she to have a hint about the actual performance. The maximum print interval is 2s and we limit the number of messages to 100. If desired, this can be changed in cpu-exec.c Signed-

[Qemu-devel] [RFC PATCH V4 2/6] icount: Add align option to icount

2014-07-16 Thread Sebastian Tanase
The align option is used for activating the align algorithm in order to synchronise the host clock and the guest clock. Signed-off-by: Sebastian Tanase Tested-by: Camille Bégué --- cpus.c| 19 --- include/qemu-common.h | 1 + qemu-options.hx | 15 +

[Qemu-devel] [RFC PATCH V4 6/6] monitor: Add drift info to 'info jit'

2014-07-16 Thread Sebastian Tanase
Show in 'info jit' the current delay between the host clock and the guest clock. In addition, print the maximum advance and delay of the guest compared to the host. Signed-off-by: Sebastian Tanase Tested-by: Camille Bégué --- cpu-exec.c| 19 ++- cpus.c

[Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-16 Thread Sebastian Tanase
The icount option already implemented in QEMU allows the guest to run at a theoretical frequency of 1/(2^N) GHz (N is the icount parameter). The goal of this patch is to have a real guest frequency close to the one imposed by using the icount option. The main idea behind the algorithm is that we

Re: [Qemu-devel] [PATCH 07/46] Return path: Open a return path on QEMUFile for sockets

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 13:52, Dr. David Alan Gilbert ha scritto: * Paolo Bonzini (pbonz...@redhat.com) wrote: Il 16/07/2014 11:37, Dr. David Alan Gilbert ha scritto: + +/* If it's already open, return it */ +if (qfs->file->return_path) { +return qfs->file->return_path; Wouldn't this l

[Qemu-devel] [PATCH for-2.2 0/5] scsi: enable passthrough of vendor-specific commands

2014-07-16 Thread Paolo Bonzini
Right now scsi-generic is parsing the CDB, in order to compute the expected number of bytes to be transferred. This is necessary if DMA is done by the HBA via scsi_req_data, but it prevents executing vendor-specific commands via scsi-generic because we don't know how to parse them. If DMA is dele

[Qemu-devel] [PATCH 3/5] scsi-block: extract scsi_block_is_passthrough

2014-07-16 Thread Paolo Bonzini
This will be used for both scsi_block_new_request and the scsi-block implementation of parse_cdb. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-d

[Qemu-devel] [Bug 1342704] [NEW] error: Crash of qemu-img/qemu-io on the qcow2 image with large values in 'incompatible features' field

2014-07-16 Thread Maria Kustova
Public bug reported: qemu-io and qemu-img fails with an assertion (see below) at attempt to interact with the qcow2 image having large values in the 'incompatible features' header field. util/error.c:34: error_set: Assertion `*errp == ((void *)0)' failed. The backtrace file and the test imag

[Qemu-devel] [PATCH 2/5] scsi-bus: introduce parse_cdb in SCSIDeviceClass and SCSIBusInfo

2014-07-16 Thread Paolo Bonzini
These callbacks will let devices do their own request parsing, or defer it to the bus. If the bus does not provide an implementation, in turn, fall back to the default parsing routine. Swap the first two arguments to scsi_req_parse, and rename it to scsi_req_parse_cdb, for consistency. Signed-of

[Qemu-devel] [PATCH 1/5] scsi-bus: prepare scsi_req_new for introduction of parse_cdb

2014-07-16 Thread Paolo Bonzini
The per-SCSIDevice parse_cdb callback must not be called if the request will go through special SCSIReqOps, so detect the special cases early enough. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 44 +--- 1 file changed, 25 insertions(+), 19 deleti

[Qemu-devel] [PATCH 4/5] scsi-block, scsi-generic: implement parse_cdb

2014-07-16 Thread Paolo Bonzini
The callback lets the bus provide the direction and transfer count for passthrough commands, enabling passthrough of vendor-specific commands. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 3 +-- hw/scsi/scsi-disk.c| 14 ++ hw/scsi/scsi-generic.c | 7 +++ includ

[Qemu-devel] [PATCH 5/5] virtio-scsi: implement parse_cdb

2014-07-16 Thread Paolo Bonzini
Enable passthrough of vendor-specific commands. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 24 1 file changed, 24 insertions(+) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 0eb069a..e8f4c0c 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/sc

Re: [Qemu-devel] [RFC PATCH V4 6/6] monitor: Add drift info to 'info jit'

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 14:18, Sebastian Tanase ha scritto: -static int64_t clocks_offset; -if (!icount_align_option) { -return; +static int64_t realtime_clock_value; Does this really need to be static? +if (icount_align_option || !realtime_clock_value) { +realtime_clock

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 14:18, Sebastian Tanase ha scritto: v3 -> v4 * Add better error handling for 'strtol' in patch 2 * Add 'Sleep' instead of 'nanosleep' for Windows hosts in patch 4 * Remove function pointers from patches 4 and 5 Hi Sebastian, I think we're getting really close. I asked a question

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-16 Thread Andrey Korolyov
On Wed, Jul 16, 2014 at 3:52 PM, Marcelo Tosatti wrote: > On Wed, Jul 16, 2014 at 12:38:51PM +0400, Andrey Korolyov wrote: >> On Wed, Jul 16, 2014 at 5:16 AM, Marcelo Tosatti wrote: >> > On Wed, Jul 16, 2014 at 03:40:47AM +0400, Andrey Korolyov wrote: >> >> On Wed, Jul 16, 2014 at 2:01 AM, Paolo

Re: [Qemu-devel] [RFC PATCH V4 0/6] icount: Implement delay algorithm between guest and host clocks

2014-07-16 Thread Luiz Capitulino
On Wed, 16 Jul 2014 14:18:00 +0200 Sebastian Tanase wrote: > The icount option already implemented in QEMU allows the guest to run at a > theoretical > frequency of 1/(2^N) GHz (N is the icount parameter). The goal of this patch > is to have a > real guest frequency close to the one imposed by

[Qemu-devel] [Bug 1342686] [NEW] Windows 95 setup hangs

2014-07-16 Thread Piotr Gliźniewicz
Public bug reported: Windows 95 (first version, not 95A or OSR2) setup hangs on QEMU version 2.0.0. It was compiled from the sources on Fedora 20. Setup starts without problems, it goes through the first phase and then hangs on the "Getting ready to run Windows 95 for the first time..." screen

Re: [Qemu-devel] [Intel-gfx] ResettRe: [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-07-16 Thread Konrad Rzeszutek Wilk
On Thu, Jul 03, 2014 at 11:27:40PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 03, 2014 at 12:09:28PM -0700, Jesse Barnes wrote: > > On Thu, 3 Jul 2014 14:26:12 -0400 > > Konrad Rzeszutek Wilk wrote: > > > > > On Thu, Jul 03, 2014 at 10:32:12AM +0300, Michael S. Tsirkin wrote: > > > > On Wed,

[Qemu-devel] [PATCH 0/2] Add SP810 to Versatile Express boards

2014-07-16 Thread Fabian Aggeler
Hi, The Versatile Express emulation in QEMU currently does not have a model of the SP810 used in real hardware. The registers provided by this System Controller can be used to set the frequency of the SP804 timers. On newer releases of the board the SP804 is set to 32kHz by default and has to be i

[Qemu-devel] [PATCH 1/2] hw/misc/arm_sp810: Create SP810 device

2014-07-16 Thread Fabian Aggeler
This adds a device model for the PrimeXsys System Controller (SP810) which is present in the Versatile Express motherboards. It is so far read-only but allows to set the SCCTRL register. Signed-off-by: Fabian Aggeler --- default-configs/arm-softmmu.mak | 1 + hw/misc/Makefile.objs |

[Qemu-devel] [PATCH 2/2] hw/arm/vexpress: add SP810 to the vexpress

2014-07-16 Thread Fabian Aggeler
The SP810, which is present in the Versatile Express motherboards, allows to set the timing reference to either REFCLK or TIMCLK. QEMU currently sets the SP804 timer to 1MHz by default. To reflect this, we set the TimerEn0Sel, TimerEn1Sel, TimerEn2Sel, and TimerEn3Sel of the system control register

Re: [Qemu-devel] [PATCH 2/2] hw/arm/vexpress: add SP810 to the vexpress

2014-07-16 Thread Alex Bennée
Fabian Aggeler writes: > The SP810, which is present in the Versatile Express motherboards, > allows to set the timing reference to either REFCLK or TIMCLK. > QEMU currently sets the SP804 timer to 1MHz by default. To reflect > this, we set the TimerEn0Sel, TimerEn1Sel, TimerEn2Sel, and > TimerEn

[Qemu-devel] [PATCH for-2.1 0/2] raw-posix: Fail gracefully if no working alignment is found

2014-07-16 Thread Kevin Wolf
Kevin Wolf (2): block: Add Error argument to bdrv_refresh_limits() raw-posix: Fail gracefully if no working alignment is found block.c | 33 +++-- block/iscsi.c | 3 +-- block/qcow2.c | 4 +--- block/qed.c |

[Qemu-devel] [PATCH 1/2] block: Add Error argument to bdrv_refresh_limits()

2014-07-16 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 33 +++-- block/iscsi.c | 3 +-- block/qcow2.c | 4 +--- block/qed.c | 4 +--- block/raw-posix.c | 4 +--- block/raw_bsd.c | 3 +-- block/stream.c

[Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working alignment is found

2014-07-16 Thread Kevin Wolf
If qemu couldn't find out what O_DIRECT alignment to use with a given file, it would run into assert(bdrv_opt_mem_align(bs) != 0); in block.c and confuse users. This adds a more descriptive error message for such cases. Signed-off-by: Kevin Wolf --- block/raw-posix.c | 35 +++

[Qemu-devel] [PATCH qemu] i386, linux-headers: Add support for kvm_get_rng_seed

2014-07-16 Thread Andy Lutomirski
This updates x86's kvm_para.h for the feature bit definition and target-i386/cpu.c for the feature name and default. Signed-off-by: Andy Lutomirski --- linux-headers/asm-x86/kvm_para.h | 2 ++ target-i386/cpu.c| 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --gi

Re: [Qemu-devel] [musl] Re: Bogus struct stat64 for qemu-microblaze (user emulation)?

2014-07-16 Thread Rich Felker
On Wed, Jul 16, 2014 at 09:36:23AM +0100, Peter Maydell wrote: > On 16 July 2014 05:02, Rich Felker wrote: > > The qemu-microblaze definition of struct stat64 seems to mismatch the > > kernel definition, which is using asm-generic/stat.h. See: > > > > http://git.qemu.org/?p=qemu.git;a=blob;f=linux

Re: [Qemu-devel] [PATCH qemu] i386, linux-headers: Add support for kvm_get_rng_seed

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 17:52, Andy Lutomirski ha scritto: This updates x86's kvm_para.h for the feature bit definition and target-i386/cpu.c for the feature name and default. Signed-off-by: Andy Lutomirski Thanks, looks good---assuming the kernel side will make it into 3.17, I'll sync the headers onc

[Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases (was: [ANNOUNCE] QEMU 2.1.0-rc2 is now available)

2014-07-16 Thread Stefan Weil
Am 16.07.2014 02:26, schrieb Michael Roth: > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > third release candidate for the QEMU 2.1 release. This release is meant > for testing purposes and should not be used in a production environment. > > http://wiki.qe

[Qemu-devel] [PATCH RFC 00/14] dataplane: performance optimization and multi virtqueue

2014-07-16 Thread Ming Lei
Hi, These patches bring up below 4 changes: - introduce selective coroutine bypass mechanism for improving performance of virtio-blk dataplane with raw format image - introduce object allocation pool and apply it to virtio-blk dataplane for improving its p

[Qemu-devel] [PATCH RFC 03/14] block: support to bypass qemu coroutinue

2014-07-16 Thread Ming Lei
This patch adds bypass mode support for the coroutinue in bdrv_co_aio_rw_vector(), which is in the fast path of lots of block device, especially for virtio-blk dataplane. Signed-off-by: Ming Lei --- block.c | 129 +++ 1 file changed, 1

[Qemu-devel] [PATCH RFC 01/14] qemu coroutine: support bypass mode

2014-07-16 Thread Ming Lei
This patch introduces several APIs for supporting bypass qemu coroutine in case of being not necessary and for performance's sake. Signed-off-by: Ming Lei --- include/block/coroutine.h |7 +++ include/block/coroutine_int.h |5 + qemu-coroutine-lock.c |4 ++-- qemu

[Qemu-devel] [PATCH RFC 10/14] linux-aio: remove 'node' from 'struct qemu_laiocb'

2014-07-16 Thread Ming Lei
No one uses the 'node' field any more, so remove it from 'struct qemu_laiocb', and this can save 16byte for the struct on 64bit arch. Signed-off-by: Ming Lei --- block/linux-aio.c |1 - 1 file changed, 1 deletion(-) diff --git a/block/linux-aio.c b/block/linux-aio.c index c06a57d..337f879 1

[Qemu-devel] [PATCH RFC 02/14] qemu aio: prepare for supporting selective bypass coroutine

2014-07-16 Thread Ming Lei
If device thinks that it isn't necessary to apply coroutine in its performance sensitive path, it can call qemu_aio_set_bypass_co(false) to bypass the coroutine which has supported bypass mode and just call the function directly. One example is virtio-blk dataplane. Signed-off-by: Ming Lei ---

[Qemu-devel] [PATCH RFC 14/14] dataplane: virtio-blk: support mutlti virtqueue

2014-07-16 Thread Ming Lei
This patch supports to handle host notify from multi virt queues, but still process/submit io in the one iothread. Currently this patch brings up below improvement with two virtqueues(against single virtqueue): --- |

[Qemu-devel] [PATCH RFC 08/14] linux-aio: fix submit aio as a batch

2014-07-16 Thread Ming Lei
In the enqueue path, we can't complete request, otherwise "Co-routine re-entered recursively" may be caused, so this patch fixes the issue with below ideas: - for -EAGAIN or partial completion, retry the submission by an introduced event handler - for part of completion, al

[Qemu-devel] [PATCH RFC 12/14] hw/virtio/virtio-blk.h: introduce VIRTIO_BLK_F_MQ

2014-07-16 Thread Ming Lei
Prepare for supporting mutli vqs per virtio-blk device. Signed-off-by: Ming Lei --- include/hw/virtio/virtio-blk.h |8 1 file changed, 8 insertions(+) diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h index 45f8894..ad70c9a 100644 --- a/include/hw/virtio/

[Qemu-devel] [PATCH RFC 04/14] Revert "raw-posix: drop raw_get_aio_fd() since it is no longer used"

2014-07-16 Thread Ming Lei
This reverts commit 76ef2cf5493a215efc351f48ae7094d6c183fcac. Reintroduce the helper of raw_get_aio_fd() for enabling coroutinue bypass mode in case of raw image. Signed-off-by: Ming Lei --- block/raw-posix.c | 34 ++ include/block/block.h |9 +

[Qemu-devel] [PATCH RFC 05/14] dataplane: enable selective bypassing coroutine

2014-07-16 Thread Ming Lei
This patch enables selective bypassing for the coroutine in bdrv_co_aio_rw_vector() if the image format is raw. With this patch, ~16% thoughput improvement can be observed in my laptop based VM test, and ~7% improvement is observed in the VM based on server. Signed-off-by: Ming Lei --- hw/block

[Qemu-devel] [PATCH RFC 13/14] hw/block/virtio-blk: create num_queues vqs if dataplane is enabled

2014-07-16 Thread Ming Lei
Now we only support multi vqs for dataplane case. Signed-off-by: Ming Lei --- hw/block/virtio-blk.c | 16 +++- include/hw/virtio/virtio-blk.h |3 +++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index ab99

[Qemu-devel] [PATCH RFC 06/14] qemu/obj_pool.h: introduce object allocation pool

2014-07-16 Thread Ming Lei
This patch introduces object allocation pool for speeding up object allocation in fast path. Signed-off-by: Ming Lei --- include/qemu/obj_pool.h | 64 +++ 1 file changed, 64 insertions(+) create mode 100644 include/qemu/obj_pool.h diff --git a/incl

[Qemu-devel] [PATCH RFC 07/14] dataplane: use object pool to speed up allocation for virtio blk request

2014-07-16 Thread Ming Lei
g_slice_new(VirtIOBlockReq), its free pair and access the instance is a bit slow since sizeof(VirtIOBlockReq) takes more than 40KB, so use object pool to speed up its allocation and release. With this patch, ~20% thoughput improvement can be observed in my laptop based VM test, and ~5% improvement

[Qemu-devel] [PATCH RFC 09/14] linux-aio: increase max event to 256

2014-07-16 Thread Ming Lei
This patch increases max event to 256 for the comming virtio-blk multi virtqueue support. Signed-off-by: Ming Lei --- block/linux-aio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/linux-aio.c b/block/linux-aio.c index 5eb9c92..c06a57d 100644 --- a/block/linux-aio

[Qemu-devel] [PATCH RFC 11/14] hw/virtio-pci: introduce num_queues property

2014-07-16 Thread Ming Lei
This patch introduces the parameter of 'num_queues', and prepare for supporting mutli vqs of virtio-blk. Signed-off-by: Ming Lei --- hw/block/virtio-blk.c |1 + include/hw/virtio/virtio-blk.h |1 + 2 files changed, 2 insertions(+) diff --git a/hw/block/virtio-blk.c b/hw/block/v

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases (was: [ANNOUNCE] QEMU 2.1.0-rc2 is now available)

2014-07-16 Thread Peter Maydell
On 16 July 2014 17:28, Stefan Weil wrote: > a recent commit (e49ab19fcaa617ad6cdfe1ac401327326b6a2552) increased the > requirements for libiscsi from 1.4.0 to 1.9.0. From a user's point of > view, this change results in a regression for Debian and similar Linux > distributions: QEMU no longer incl

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread Paolo Bonzini
Il 16/07/2014 18:28, Stefan Weil ha scritto: Debian testing includes a brand new libiscsi, but it does not include libiscsi.pc, so pkg-config won't know that it is available and configure will disable libiscsi. That's a packaging bug. I have a patch which fixes this, so QEMU for Debian testin

Re: [Qemu-devel] [PATCH 07/46] Return path: Open a return path on QEMUFile for sockets

2014-07-16 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 16/07/2014 13:52, Dr. David Alan Gilbert ha scritto: > >* Paolo Bonzini (pbonz...@redhat.com) wrote: > >>Il 16/07/2014 11:37, Dr. David Alan Gilbert ha scritto: > > > >+ > >+/* If it's already open, return it */ > >+if (qfs->

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread Stefan Weil
Am 16.07.2014 18:49, schrieb Paolo Bonzini: > Il 16/07/2014 18:28, Stefan Weil ha scritto: >> Debian testing includes a brand new libiscsi, but it >> does not include libiscsi.pc, so pkg-config won't know that it is >> available and configure will disable libiscsi. > > That's a packaging bug. CC'

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread ronnie sahlberg
On Wed, Jul 16, 2014 at 10:11 AM, Stefan Weil wrote: > Am 16.07.2014 18:49, schrieb Paolo Bonzini: >> Il 16/07/2014 18:28, Stefan Weil ha scritto: >>> Debian testing includes a brand new libiscsi, but it >>> does not include libiscsi.pc, so pkg-config won't know that it is >>> available and config

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread Michael Tokarev
16.07.2014 21:11, Stefan Weil wrote: > Am 16.07.2014 18:49, schrieb Paolo Bonzini: >> Il 16/07/2014 18:28, Stefan Weil ha scritto: >>> Debian testing includes a brand new libiscsi, but it >>> does not include libiscsi.pc, so pkg-config won't know that it is >>> available and configure will disable

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread Michael Tokarev
16.07.2014 21:23, ronnie sahlberg wrote: > If you ask debian to upgrade. Could you ask them to wait and upgrade after I > have release the next version, hopefully if all goes well, at the end > of this week? There's no problem in updating now to fix missing .pc file and to update next week to inc

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread Peter Lieven
Am 16.07.2014 19:23, schrieb ronnie sahlberg: > On Wed, Jul 16, 2014 at 10:11 AM, Stefan Weil wrote: >> Am 16.07.2014 18:49, schrieb Paolo Bonzini: >>> Il 16/07/2014 18:28, Stefan Weil ha scritto: Debian testing includes a brand new libiscsi, but it does not include libiscsi.pc, so pkg-c

Re: [Qemu-devel] [RFC] How to handle feature regressions in new QEMU releases

2014-07-16 Thread Peter Lieven
Am 16.07.2014 18:46, schrieb Peter Maydell: > On 16 July 2014 17:28, Stefan Weil wrote: >> a recent commit (e49ab19fcaa617ad6cdfe1ac401327326b6a2552) increased the >> requirements for libiscsi from 1.4.0 to 1.9.0. From a user's point of >> view, this change results in a regression for Debian and s

Re: [Qemu-devel] [PATCH 1/2] block: Add Error argument to bdrv_refresh_limits()

2014-07-16 Thread Eric Blake
On 07/16/2014 09:48 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block.c | 33 +++-- > block/iscsi.c | 3 +-- > block/qcow2.c | 4 +--- > block/qed.c | 4 +--- > block/raw-posix.c | 4 +---

Re: [Qemu-devel] [PATCH 2/2] raw-posix: Fail gracefully if no working alignment is found

2014-07-16 Thread Eric Blake
On 07/16/2014 09:48 AM, Kevin Wolf wrote: > If qemu couldn't find out what O_DIRECT alignment to use with a given > file, it would run into assert(bdrv_opt_mem_align(bs) != 0); in block.c > and confuse users. This adds a more descriptive error message for such > cases. > > Signed-off-by: Kevin Wol

Re: [Qemu-devel] latest rc: virtio-blk hangs forever after migration

2014-07-16 Thread Andrey Korolyov
On Wed, Jul 16, 2014 at 5:24 PM, Andrey Korolyov wrote: > On Wed, Jul 16, 2014 at 3:52 PM, Marcelo Tosatti wrote: >> On Wed, Jul 16, 2014 at 12:38:51PM +0400, Andrey Korolyov wrote: >>> On Wed, Jul 16, 2014 at 5:16 AM, Marcelo Tosatti >>> wrote: >>> > On Wed, Jul 16, 2014 at 03:40:47AM +0400, A

Re: [Qemu-devel] [PATCH 1/2] block: Add Error argument to bdrv_refresh_limits()

2014-07-16 Thread Kevin Wolf
Am 16.07.2014 um 20:07 hat Eric Blake geschrieben: > On 07/16/2014 09:48 AM, Kevin Wolf wrote: > > @@ -1154,7 +1167,7 @@ void bdrv_set_backing_hd(BlockDriverState *bs, > > BlockDriverState *backing_hd) > > bdrv_op_unblock(bs->backing_hd, BLOCK_OP_TYPE_COMMIT, > > bs->back

[Qemu-devel] [Bug 1338563] Re: README refers to a non-extant file

2014-07-16 Thread Daniel U. Thibault
** Changed in: qemu Status: Invalid => Opinion -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1338563 Title: README refers to a non-extant file Status in QEMU: Opinion Bug description:

[Qemu-devel] [PATCH V3 2/5] runner: Tool for fuzz tests execution

2014-07-16 Thread Maria Kustova
The purpose of the test runner is to prepare test environment (e.g. create a work directory, a test image, etc), execute the program under test with parameters, indicate a test failure if the program was killed during test execution and collect core dumps, logs and other test artifacts. The test r

[Qemu-devel] [PATCH V3 0/5] tests: Add the image fuzzer with qcow2 support

2014-07-16 Thread Maria Kustova
This patch series introduces the image fuzzer, a tool for stability and reliability testing. Its approach is to run large amount of tests in background. During every test a program (e.g. qemu-img) is called to read or modify an invalid test image. A test image has valid inner structure defined by i

[Qemu-devel] [PATCH V3 1/5] docs: Specification for the image fuzzer

2014-07-16 Thread Maria Kustova
'Overall fuzzer requirements' chapter contains the current product vision and features done and to be done. This chapter is still in progress. Signed-off-by: Maria Kustova --- tests/image-fuzzer/docs/image-fuzzer.txt | 239 +++ 1 file changed, 239 insertions(+) creat

[Qemu-devel] [PATCH V3 5/5] package: Public API for image-fuzzer/runner/runner.py

2014-07-16 Thread Maria Kustova
__init__.py provides the public API required by the test runner Signed-off-by: Maria Kustova --- tests/image-fuzzer/qcow2/__init__.py | 1 + 1 file changed, 1 insertion(+) create mode 100644 tests/image-fuzzer/qcow2/__init__.py diff --git a/tests/image-fuzzer/qcow2/__init__.py b/tests/image-f

[Qemu-devel] [PATCH V3 4/5] layout: Generator of fuzzed qcow2 images

2014-07-16 Thread Maria Kustova
The layout submodule of the qcow2 package creates a random valid image, randomly selects some amount of its fields, fuzzes them and write the fuzzed image to the file. Fuzzing process can be controlled by external configuration. Now only a header, header extensions and a backing file name are gene

[Qemu-devel] [PATCH V3 3/5] fuzz: Fuzzing functions for qcow2 images

2014-07-16 Thread Maria Kustova
The fuzz submodule of the qcow2 image generator contains fuzzing functions for image fields. Each fuzzing function contains list of constraints and a call of a helper function that randomly selects a fuzzed value satisfied to one of constraints. For now constraints include only known as invalid or

Re: [Qemu-devel] [PATCH v6 0/3] s390: Support for Hotplug of Standby Memory

2014-07-16 Thread Matthew Rosato
On 06/30/2014 10:00 AM, Matthew Rosato wrote: > This patchset adds support in s390 for a pool of standby memory, > which can be set online/offline by the guest (ie, via chmem). > The standby pool of memory is allocated as the difference between > the initial memory setting and the maxmem setting.

[Qemu-devel] [Bug 1318830] Re: High CPU usage on windows virtual machine

2014-07-16 Thread Serge Hallyn
Hi, could you please try adding hyperv to the vm options, as shown here: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1308341/comments/10 Please let us know if that helps. ** Changed in: qemu (Ubuntu) Status: New => Incomplete -- You received this bug notification because you ar

[Qemu-devel] pause and restore function before and after QEMU Live Snapshot

2014-07-16 Thread Yuanzhen Gu
Hi folks, I am going to make a patch, and need to find the pause and thaw(restore) function before and after taking Live QEMU Snapshot respectively. Basically, I'm using # (qemu) snapshot_blkdev taking snapshot, http://wiki.qemu.org/Features/Snapshotsmy profile tool didn't work when givi

  1   2   >