[Qemu-devel] [RFC 01/25] vl.c: Small coding style fix

2014-07-10 Thread Eduardo Habkost
Just to make checkpatch.pl happy when moving the code. Signed-off-by: Eduardo Habkost --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 6e084c2..8da895f 100644 --- a/vl.c +++ b/vl.c @@ -2692,7 +2692,7 @@ static int configure_accelerator(MachineClass *

Re: [Qemu-devel] dataplane degradation in 2.1

2014-07-10 Thread Fam Zheng
On Wed, 07/09 20:50, Andrey Korolyov wrote: > Hello, > > I`ve observed an immediate crash running tagged -rc1 with > virtio-blk(675879f6f3c9463e103735a4e41e9deb0bee9b39). Please take a > look on attached backtrace, hope that the fix still can made its way > to 2.1. 1.6 works well with same config,

[Qemu-devel] [PATCH 065/156] pci-assign: limit # of msix vectors

2014-07-10 Thread Michael Roth
From: "Michael S. Tsirkin" KVM only supports MSIX table size up to 256 vectors, but some assigned devices support more vectors, at the moment attempts to assign them fail with EINVAL. Tweak the MSIX capability exposed to guest to limit table size to a supported value. Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH V2 4/6] layout: Generator of fuzzed qcow2 images

2014-07-10 Thread Fam Zheng
On Fri, 07/04 15:39, Maria Kustova wrote: > Layout submodule of qcow2 package creates a random valid image, randomly > selects some amount of its fields, fuzzes them and write the fuzzed image to > the file. > Now only header and header extensions are generated, a remaining file is > filled > by z

[Qemu-devel] [PATCH v3 2.1 1/4] virtio-blk: Factor common checks out of virtio_blk_handle_read/write()

2014-07-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Fam Zheng --- hw/block/virtio-blk.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index aec3146..d946fa9 100644 --- a/hw/block/virtio-blk.c +++ b/hw/block/

[Qemu-devel] [PATCH 103/156] dmg: prevent out-of-bounds array access on terminator

2014-07-10 Thread Michael Roth
From: Stefan Hajnoczi When a terminator is reached the base for offsets and sectors is stored. The following records that are processed will use this base value. If the first record we encounter is a terminator, then calculating the base values would result in out-of-bounds array accesses. Don'

Re: [Qemu-devel] [Bug 1324112] Re: qemu parallel building error on libcacard.la

2014-07-10 Thread Stefan Hajnoczi
On Thu, Jul 10, 2014 at 7:28 AM, Fam Zheng wrote: > > Could be because of this rule: > > > # libtool will build the .o files, too > > $(libcacard-obj-y): | $(libcacard-lobj-y) > > Does removing the "|" (order deps) solve the issue? I don't think so: libcacard.la: $(libcacard-lobj-y) $(cal

[Qemu-devel] [PATCH 020/156] megasas: Implement LD_LIST_QUERY

2014-07-10 Thread Michael Roth
From: Hannes Reinecke Newer firmware implement a LD_LIST_QUERY command, and due to a driver issue no drives might be detected if this command isn't supported. So add emulation for this command, too. Cc: qemu-sta...@nongnu.org Signed-off-by: Hannes Reinecke Signed-off-by: Paolo Bonzini (cherry

Re: [Qemu-devel] [Bug 1324112] Re: qemu parallel building error on libcacard.la

2014-07-10 Thread Stefan Hajnoczi
On Thu, Jul 10, 2014 at 9:32 AM, Stefan Hajnoczi wrote: > Try this on qemu.git/master: > > $ make distclean > $ ./configure > $ make libcacard/vscclient > libcacard/vscclient.o: In function `do_command': > /home/stefanha/qemu/libcacard/vscclient.c:500: undefined reference to > `vreader_get_reader_

Re: [Qemu-devel] [Bug 1324112] Re: qemu parallel building error on libcacard.la

2014-07-10 Thread Stefan Hajnoczi
Since the following commit, libcacard and vscclient no longer link against QEMU common code: commit fd25c0e6dd1ed2aa932fa7ef814b32457bf270fd Author: Michael Tokarev Date: Thu May 8 12:30:48 2014 +0400 libcacard: replace qemu thread primitives with glib ones Therefore this bug no longer ex

Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer

2014-07-10 Thread Fam Zheng
On Fri, 06/27 11:44, Kevin Wolf wrote: > In general, it feels like it would be the right thing to do, especially > considering the goal of operation categories in the final state, but on > the other hand it means that RESIZE would have to be excluded from > bs->backing_blocker, too, allowing standa

Re: [Qemu-devel] [PULL 2/3] hw/arm/vexpress: Alias NOR flash at 0 for vexpress-a9

2014-07-10 Thread Peter Maydell
On 8 July 2014 13:13, Peter Maydell wrote: > Make the vexpress-a9 board alias the first NOR flash region at > address zero, like vexpress-a15. This makes "-bios" actually usable > on this board. Oof. Judging by the headers lists.gnu sat on this email for over 36 hours... -- PMM

[Qemu-devel] [PATCH 073/156] block/cloop: refuse images with huge offsets arrays (CVE-2014-0144)

2014-07-10 Thread Michael Roth
From: Stefan Hajnoczi Limit offsets_size to 512 MB so that: 1. g_malloc() does not abort due to an unreasonable size argument. 2. offsets_size does not overflow the bdrv_pread() int size argument. This limit imposes a maximum image size of 16 TB at 256 KB block size. Signed-off-by: Stefan Haj

Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer

2014-07-10 Thread Fam Zheng
On Thu, 07/10 11:25, Kevin Wolf wrote: > Am 10.07.2014 um 10:42 hat Fam Zheng geschrieben: > > On Fri, 06/27 11:44, Kevin Wolf wrote: > > > In general, it feels like it would be the right thing to do, especially > > > considering the goal of operation categories in the final state, but on > > > the

Re: [Qemu-devel] [Bug 1324112] [NEW] qemu parallel building error on libcacard.la

2014-07-10 Thread Paolo Bonzini
Il 10/06/2014 17:08, tal zilcer ha scritto: Trace/generated*.o files depends on trace/generated*.la files($(libcacard-obj-y): | $(libcacard-lobj-y)) Also util depends on generated-*.o files (util-obj-y += generated-events.o) This means when libcacard.la is being build generated-*.o files can be

[Qemu-devel] [PULL 11/18] target-alpha: Disallow literal operand to 1C.30 to 1C.37

2014-07-10 Thread Richard Henderson
Before 64f45e49 we used to have literal checks for 4 of these 8 opcodes. Confirmed that real hardware doesn't allow them. Reported-by: Al Viro Signed-off-by: Richard Henderson --- target-alpha/translate.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/t

[Qemu-devel] [RFC 19/25] accel: Use target-specific accel class if available

2014-07-10 Thread Eduardo Habkost
Target-specific accelerator subclasses are optional. If a given accelerator type needs to make it mandatory, the base class can be made abstract. Signed-off-by: Eduardo Habkost --- hw/core/accel.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/core/a

Re: [Qemu-devel] [PATCH for 2.1 0/2] Fix commit of oversized layer

2014-07-10 Thread Kevin Wolf
Am 10.07.2014 um 10:42 hat Fam Zheng geschrieben: > On Fri, 06/27 11:44, Kevin Wolf wrote: > > In general, it feels like it would be the right thing to do, especially > > considering the goal of operation categories in the final state, but on > > the other hand it means that RESIZE would have to be

Re: [Qemu-devel] [PATCH v4 2.1 0/4] Suppress error action on r/w beyond end

2014-07-10 Thread Kevin Wolf
Am 09.07.2014 um 19:07 hat Markus Armbruster geschrieben: > When a device model's I/O operation fails, we execute the error > action. This lets layers above QEMU implement thin provisioning, or > attempt to correct errors before they reach the guest. But when the > I/O operation fails because its

Re: [Qemu-devel] [PATCH v5] spapr: add uuid/host details to device tree

2014-07-10 Thread Alexander Graf
On 09.07.14 12:38, Nikunj A Dadhania wrote: Useful for identifying the guest/host uniquely within the guest. Adding following properties to the guest root node. vm,uuid - uuid of the guest host-model - Host model number host-serial - Host machine serial number hypervisor type - Tells its "kvm"

[Qemu-devel] [PATCH 0/6 v6] ppc: Add debug stub support

2014-07-10 Thread Bharat Bhushan
This patchset add support for - software breakpoint - h/w breakpoint - h/w watchpoint Please find description in individual patch. v5->v6 - Added a new patch to synchronize excp_vectors. - Inject program exception rather than debug exception if guest is not able to handle debug exception.

[Qemu-devel] [PATCH 2/6 v6] ppc: Add interface to inject interrupt to guest

2014-07-10 Thread Bharat Bhushan
This patch adds interface to inject interrupt to guest. Currently a void program check exception function added. Follow up patch will use this interface to inject program check exception to guest Signed-off-by: Bharat Bhushan --- v5->v6 - replace debug with program interrupt target-ppc/cpu.h |

[Qemu-devel] [PATCH 4/6 v6] ppc: Add program exception injection handler

2014-07-10 Thread Bharat Bhushan
With this patch a program check exception can be injected to guest. Follow up patch will use this interface to inject program exception to guest. Signed-off-by: Bharat Bhushan --- v5->v6 - new patch (infact replace debug interrupt injection) target-ppc/kvm.c | 5 + 1 file changed, 5 insert

[Qemu-devel] [PATCH 3/6 v6] ppc: synchronize excp_vectors for injecting exception

2014-07-10 Thread Bharat Bhushan
This patch synchronizes env->excp_vectors[] with env->iovr[]. This is required for using the existing interrupt injection mechanism for kvm. Signed-off-by: Bharat Bhushan --- v5->v6 - new patch target-ppc/kvm.c | 44 1 file changed, 44 insertions(+)

Re: [Qemu-devel] [PATCH 2/6 v6] ppc: Add interface to inject interrupt to guest

2014-07-10 Thread Alexander Graf
On 10.07.14 12:57, Bharat Bhushan wrote: This patch adds interface to inject interrupt to guest. Currently a void program check exception function added. Follow up patch will use this interface to inject program check exception to guest Signed-off-by: Bharat Bhushan --- v5->v6 - replace debu

Re: [Qemu-devel] [PATCH 3/6 v6] ppc: synchronize excp_vectors for injecting exception

2014-07-10 Thread Alexander Graf
On 10.07.14 12:57, Bharat Bhushan wrote: This patch synchronizes env->excp_vectors[] with env->iovr[]. This is required for using the existing interrupt injection mechanism for kvm. Signed-off-by: Bharat Bhushan --- v5->v6 - new patch target-ppc/kvm.c | 44

Re: [Qemu-devel] [PATCH 5/6 v6] ppc: Add software breakpoint support

2014-07-10 Thread Alexander Graf
On 10.07.14 12:58, Bharat Bhushan wrote: This patch allow insert/remove software breakpoint Signed-off-by: Bharat Bhushan --- v5->v6 - No change target-ppc/kvm.c | 73 +--- 1 file changed, 59 insertions(+), 14 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH] pass $($*.o-cflags) first to gcc/g++

2014-07-10 Thread Stefano Stabellini
On Thu, 10 Jul 2014, Paolo Bonzini wrote: > Il 09/07/2014 23:59, Stefano Stabellini ha scritto: > > On Wed, 9 Jul 2014, Paolo Bonzini wrote: > > > What package is it that has the conflicting utils.h file? Any chance to > > > get > > > it fixed in your distro? Here I get: > > > > > > $ find /usr/

Re: [Qemu-devel] [PATCH 6/6 v6] ppc: Add hw breakpoint watchpoint support

2014-07-10 Thread Alexander Graf
On 10.07.14 12:58, Bharat Bhushan wrote: This patch adds hardware breakpoint and hardware watchpoint support for ppc. On BOOKE architecture we cannot share debug resources between QEMU and guest because: When QEMU is using debug resources then debug exception must be always enabled. T

[Qemu-devel] [PULL 09/18] target-alpha: Fix integer overflow checking insns

2014-07-10 Thread Richard Henderson
We need to write the result to the destination register before raising any exception. Thus inline the code for each insn, and check for any exception after we're done. Reported-by: Al Viro Signed-off-by: Richard Henderson --- target-alpha/helper.h | 7 +- target-alpha/int_helper.c | 5

Re: [Qemu-devel] [RFC PATCH v2] spapr: Enable use of huge pages

2014-07-10 Thread Alexey Kardashevskiy
On 07/10/2014 08:29 PM, Alexander Graf wrote: > > On 09.07.14 15:59, Alexey Kardashevskiy wrote: >> On 07/09/2014 05:46 PM, Paolo Bonzini wrote:> Il 09/07/2014 07:57, Alexey >> Kardashevskiy ha scritto: 0b183fc87 "memory: move mem_path handling to memory_region_allocate_system_memory" di

[Qemu-devel] [PATCH v2] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2014-07-10 Thread Shreyas B. Prabhu
Commit 0b183fc871:"memory: move mem_path handling to memory_region_allocate_system_memory" split memory_region_init_ram and memory_region_init_ram_from_file. Also it moved mem-path handling a step up from memory_region_init_ram to memory_region_allocate_system_memory. Therefore for any board that

Re: [Qemu-devel] [PATCH v2] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2014-07-10 Thread Alexander Graf
On 10.07.14 14:01, Shreyas B. Prabhu wrote: Commit 0b183fc871:"memory: move mem_path handling to memory_region_allocate_system_memory" split memory_region_init_ram and memory_region_init_ram_from_file. Also it moved mem-path handling a step up from memory_region_init_ram to memory_region_allocat

[Qemu-devel] [PATCH 011/156] configure: Don't use __int128_t for clang versions before 3.2

2014-07-10 Thread Michael Roth
From: Stefan Weil Those versions don't fully support __int128_t. Cc: qemu-sta...@nongnu.org Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev (cherry picked from commit a00f66ab9b3021e781695a73c579b6292501ab37) Signed-off-by: Michael Roth --- configure | 5 + 1 file changed, 5 in

Re: [Qemu-devel] [PATCH v2] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2014-07-10 Thread Shreyas B Prabhu
On Thursday 10 July 2014 05:34 PM, Alexander Graf wrote: > > On 10.07.14 14:01, Shreyas B. Prabhu wrote: >> Commit 0b183fc871:"memory: move mem_path handling to >> memory_region_allocate_system_memory" split memory_region_init_ram and >> memory_region_init_ram_from_file. Also it moved mem-path h

[Qemu-devel] [PATCH 151/156] nbd: Shutdown socket before closing.

2014-07-10 Thread Michael Roth
From: Hani Benhabiles This forces finishing data sending to client before closing the socket like in exports listing or replying with NBD_REP_ERR_UNSUP cases. Signed-off-by: Hani Benhabiles Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini (cherry picked from commit 27e5eae4577316f7e86a5

Re: [Qemu-devel] [PATCH v5 00/12] KVM Support for MIPS32 Processors

2014-07-10 Thread Peter Maydell
On 17 June 2014 23:10, James Hogan wrote: > The patchset depends on v4 of "target-mips: implement UserLocal > Register". I'm aiming for QEMU 2.1, hopefully it isn't too late to get > some final review. > > Thanks to everybody who has already taken part in review. > > This patchset implements KVM s

[Qemu-devel] [PATCH 049/156] ssi-sd: fix buffer overrun on invalid state load

2014-07-10 Thread Michael Roth
From: "Michael S. Tsirkin" CVE-2013-4537 s->arglen is taken from wire and used as idx in ssi_sd_transfer(). Validate it before access. Signed-off-by: Michael S. Tsirkin Signed-off-by: Juan Quintela (cherry picked from commit a9c380db3b8c6af19546a68145c8d1438a09c92b) Signed-off-by: Michael Ro

Re: [Qemu-devel] [PATCH] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2014-07-10 Thread Alexander Graf
On 10.07.14 09:01, Shreyas B. Prabhu wrote: Commit 0b183fc871:"memory: move mem_path handling to memory_region_allocate_system_memory" split memory_region_init_ram and memory_region_init_ram_from_file. Also it moved mem-path handling a step up from memory_region_init_ram to memory_region_allocat

[Qemu-devel] [PULL for-2.1 04/22] block: drop aio functions that operate on the main AioContext

2014-07-10 Thread Kevin Wolf
From: Paolo Bonzini The main AioContext should be accessed explicitly via qemu_get_aio_context(). Most of the time, using it is not the right thing to do. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- aio-posix.c | 4 ++-- aio-win32.c | 6 +++--- inc

[Qemu-devel] [PULL for-2.1 03/22] block: prefer aio_poll to qemu_aio_wait

2014-07-10 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c| 2 +- blockjob.c | 2 +- qemu-io-cmds.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index c9629a4..510430d 100644 --- a/block.c +++ b/block.c @@ -4

[Qemu-devel] [PULL for-2.1 01/22] block/backup: Fix hang for unaligned image size

2014-07-10 Thread Kevin Wolf
When doing a block backup of an image with an unaligned size (with respect to the BACKUP_CLUSTER_SIZE), qemu would check the allocation status of sectors after the end of the image. bdrv_is_allocated() returns a result that is valid for 0 sectors in this case, so the backup job ran into an endless

Re: [Qemu-devel] [PATCH] target-ppc: Fix number of threads per core limit

2014-07-10 Thread Alexander Graf
On 09.07.14 16:40, Alexey Kardashevskiy wrote: The number of threads per core is different for POWER6/7/8 CPUs. Guest systems do not expect to see more threads per core than a specific CPU supports so we need to limit this number. This limit is implemented by ppc_get_compat_smt_threads(). Howev

[Qemu-devel] [PATCH 128/156] block/vvfat: Plug memory leak in read_directory()

2014-07-10 Thread Michael Roth
From: Markus Armbruster Has always been leaky. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit b122c3b6d020e529b203836efb8f611ece787293) Signed-off-by: Michael Roth --- block/vvfat.c | 4 +++- 1 file chang

[Qemu-devel] [PULL for-2.1 11/22] virtio-blk: avoid dataplane VirtIOBlockReq early free

2014-07-10 Thread Kevin Wolf
From: Stefan Hajnoczi VirtIOBlockReq is freed later by virtio_blk_free_request() in hw/block/virtio-blk.c. Remove this extraneous g_slice_free(). This patch fixes the following segfault: 0x556373af in virtio_blk_rw_complete (opaque=0x565ff5e0, ret=0) at hw/block/virtio-blk.c:99

[Qemu-devel] [PULL for-2.1 08/22] qcow2: Make qiov match request size until backing file EOF

2014-07-10 Thread Kevin Wolf
If a qcow2 image has a shorter backing file and a read request to unallocated clusters goes across EOF of the backing file, the backing file sees a shortened request and the rest is filled with zeros. However, the original too long qiov was used with the shortened request. This patch makes the qio

[Qemu-devel] [PULL for-2.1 15/22] AioContext: do not rely on aio_poll(ctx, true) result to end a loop

2014-07-10 Thread Kevin Wolf
From: Paolo Bonzini Currently, whenever aio_poll(ctx, true) has completed all pending work it returns true *and* the next call to aio_poll(ctx, true) will not block. This invariant has its roots in qemu_aio_flush()'s implementation as "while (qemu_aio_wait()) {}". However, qemu_aio_flush() does

[Qemu-devel] [PULL for-2.1 16/22] tests: Fix unterminated string output visitor enum human string

2014-07-10 Thread Kevin Wolf
From: Andreas Färber The buffer was being allocated of size string length plus two. Around the string two quotes were being added, but no terminating NUL. It was then compared using g_assert_cmpstr(), resulting in fairly random assertion failures: ERROR:tests/test-string-output-visitor.c:213:te

Re: [Qemu-devel] [PATCH v5 00/12] KVM Support for MIPS32 Processors

2014-07-10 Thread Paolo Bonzini
Il 10/07/2014 14:17, Peter Maydell ha scritto: More generally, there doesn't really seem to be provision in the KVM KVM_EXIT_MMIO API for returning "this access failed". I guess in theory userspace could do all the "figure out how to adjust CPU state to do exception entry and then run VCPU", but

Re: [Qemu-devel] [PATCH 00/46] Postcopy implementation

2014-07-10 Thread Eric Blake
On 07/10/2014 05:29 AM, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> Il 07/07/2014 16:02, Dr. David Alan Gilbert ha scritto: > Could you have instead a "migrate_start_postcopy" command, and leave the > policy to management instead? >>> Hmm; yes that is pro

[Qemu-devel] [PATCH 041/156] hw/pci/pcie_aer.c: fix buffer overruns on invalid state load

2014-07-10 Thread Michael Roth
From: "Michael S. Tsirkin" 4) CVE-2013-4529 hw/pci/pcie_aer.cpcie aer log can overrun the buffer if log_num is too large There are two issues in this file: 1. log_max from remote can be larger than on local then buffer will overrun with data coming from state file. 2. lo

Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm

2014-07-10 Thread David Hildenbrand
> This is the qemu part of kernel series "Let user space control the > cpu states" > > Christian Borntraeger (1): > update linux headers with with cpustate changes > > David Hildenbrand (4): > s390x/kvm: introduce proper states for s390 cpus > s390x/kvm: proper use of the cpu states OPERATI

Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm

2014-07-10 Thread David Hildenbrand
> This is the qemu part of kernel series "Let user space control the > cpu states" > > Christian Borntraeger (1): > update linux headers with with cpustate changes > > David Hildenbrand (4): > s390x/kvm: introduce proper states for s390 cpus > s390x/kvm: proper use of the cpu states OPERATI

Re: [Qemu-devel] [PATCH/RFC 0/5] s390x/kvm: track the logical cpu state in QEMU and propagate it to kvm

2014-07-10 Thread David Hildenbrand
> > This is the qemu part of kernel series "Let user space control the > > cpu states" > > > > Christian Borntraeger (1): > > update linux headers with with cpustate changes > > > > David Hildenbrand (4): > > s390x/kvm: introduce proper states for s390 cpus > > s390x/kvm: proper use of the

Re: [Qemu-devel] [PATCH 00/46] Postcopy implementation

2014-07-10 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 07/10/2014 05:29 AM, Dr. David Alan Gilbert wrote: > > * Paolo Bonzini (pbonz...@redhat.com) wrote: > >> Il 07/07/2014 16:02, Dr. David Alan Gilbert ha scritto: > > Could you have instead a "migrate_start_postcopy" command, and leave the > > poli

[Qemu-devel] [PATCH 1/6 v6] ppc: debug stub: Get trap instruction opcode from KVM

2014-07-10 Thread Bharat Bhushan
Get trap instruction opcode from KVM and this opcode will be used for setting software breakpoint in following patch Signed-off-by: Bharat Bhushan --- v5->v6 - no change target-ppc/kvm.c | 4 1 file changed, 4 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 2d87108..

[Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-10 Thread Luiz Capitulino
The event code generator barfs when it sees a dot in an event argument, this makes it impossible to support vendor extensions in event arguments as they always contain dots. Fix this by replacing dots by hyphens in the generated code. PS: Event names and QMP command arguments may suffer from the s

Re: [Qemu-devel] [PATCH v6 1/5] block: Support Archipelago as a QEMU block backend

2014-07-10 Thread Chrysostomos Nanakos
On 07/10/2014 01:04 PM, Chrysostomos Nanakos wrote: On 07/10/2014 03:23 AM, Jeff Cody wrote: On Fri, Jun 27, 2014 at 11:24:08AM +0300, Chrysostomos Nanakos wrote: VM Image on Archipelago volume is specified like this: file.driver=archipelago,file.volume=[,file.mport=[, file.vport=][,file.se

[Qemu-devel] [PATCH v3 4/4] virtio-blk: embed VirtQueueElement in VirtIOBlockReq

2014-07-10 Thread Stefan Hajnoczi
The memory allocation between hw/block/virtio-blk.c, hw/block/dataplane/virtio-blk.c, and hw/virtio/dataplane/vring.c is messy. Structs are allocated in different files than they are freed in. This is risky and makes memory leaks easier. Embed VirtQueueElement in VirtIOBlockReq to reduce the amou

Re: [Qemu-devel] [PATCH 1/6 v6] ppc: debug stub: Get trap instruction opcode from KVM

2014-07-10 Thread Peter Maydell
On 10 July 2014 11:57, Bharat Bhushan wrote: > Get trap instruction opcode from KVM and this opcode will > be used for setting software breakpoint in following patch > > Signed-off-by: Bharat Bhushan > --- > v5->v6 > - no change > > target-ppc/kvm.c | 4 > 1 file changed, 4 insertions(+) >

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-10 Thread Markus Armbruster
Luiz Capitulino writes: > The event code generator barfs when it sees a dot in an event > argument, this makes it impossible to support vendor extensions > in event arguments as they always contain dots. Fix this by > replacing dots by hyphens in the generated code. Code replaces by underbar, no

Re: [Qemu-devel] dataplane degradation in 2.1

2014-07-10 Thread Stefan Hajnoczi
On Wed, Jul 09, 2014 at 08:50:43PM +0400, Andrey Korolyov wrote: > I`ve observed an immediate crash running tagged -rc1 with > virtio-blk(675879f6f3c9463e103735a4e41e9deb0bee9b39). Please take a > look on attached backtrace, hope that the fix still can made its way > to 2.1. 1.6 works well with sam

Re: [Qemu-devel] [RFC PATCH V5 1/3] xen: pass kernel initrd to qemu

2014-07-10 Thread Ian Campbell
On Mon, 2014-07-07 at 14:34 +0800, Chunyan Liu wrote: > xen side patch to support xen HVM direct kernel boot: > support 'kernel', 'ramdisk', 'cmdline' (and 'root', 'extra' as well > which would be deprecated later) in HVM config file, parse config file, > pass -kernel, -initrd, -append parameters t

Re: [Qemu-devel] [PULL for-2.1 v2 00/10] KVM changes (+ misc small fixes) for 2.1

2014-07-10 Thread Peter Maydell
On 9 July 2014 17:18, Paolo Bonzini wrote: > The following changes since commit 9d9de254c2b81b68cd48f2324cc753a570a4cdd8: > > MAINTAINERS: seccomp: change email contact for Eduardo Otubo (2014-07-03 > 12:36:15 +0100) > > are available in the git repository at: > > git://git.kernel.org/pub/scm

Re: [Qemu-devel] [RFC PATCH V5 2/3] xl.cfg: add 'cmdline' in config file

2014-07-10 Thread Ian Campbell
On Mon, 2014-07-07 at 14:34 +0800, Chunyan Liu wrote: > Currently in xl.cfg, use 'root' and 'extra' to generate the command > line. 'cmdline' could be a more generic equivalent. So, add 'cmdline' > in xl.cfg and let it be preferred. 'root' and 'extra' still works. > But when 'cmdline' is specified,

[Qemu-devel] [PATCH v3 0/2] spapr: Enable huge pages again

2014-07-10 Thread Alexey Kardashevskiy
This does small RMA allocation rework and enables huge pages. Please comment, especially commit logs. Thanks! Changes: v3: * split to 2 patches, one mechanical * tested on PPC970 v2: * moved RMA memory region out of KVM code Alexey Kardashevskiy (2): spapr: Move RMA memory region registratio

[Qemu-devel] [PATCH] ppc: memory: Replace memory_region_init_ram with memory_region_allocate_system_memory

2014-07-10 Thread Shreyas B. Prabhu
Commit 0b183fc871:"memory: move mem_path handling to memory_region_allocate_system_memory" split memory_region_init_ram and memory_region_init_ram_from_file. Also it moved mem-path handling a step up from memory_region_init_ram to memory_region_allocate_system_memory. Therefore for any board that

Re: [Qemu-devel] [PATCH 00/46] Postcopy implementation

2014-07-10 Thread Andrea Arcangeli
On Thu, Jul 10, 2014 at 02:37:43PM +0100, Dr. David Alan Gilbert wrote: > * Eric Blake (ebl...@redhat.com) wrote: > > Is there any need for an > > event telling libvirt that enough pre-copy has occurred to make a > > postcopy worthwhile? > > I'm not sure that qemu knows much more than management d

[Qemu-devel] [PATCH v2 06/10] linux-user/main.c: __kernel_cmpxchg set env->CF directly

2014-07-10 Thread Alex Bennée
As we only need to manipulate the single flag do it directly though env. Signed-off-by: Alex Bennée --- v2: - remove unused cpsr - the direct flag setting seems a little hacky? diff --git a/linux-user/main.c b/linux-user/main.c index 8848e15..9101541 100644 --- a/linux-user/main.c +++ b/li

[Qemu-devel] [PATCH v2 02/10] target-arm/cpu.h: common pstate save/restore

2014-07-10 Thread Alex Bennée
This adds a universal program state save and restore function. This is intended to simplify the migration serialisation functionality and avoid special casing depending on the mode of the CPU at serialisation time. Signed-off-by: Alex Bennée --- v2: - reword commentary for restore_state_from_s

[Qemu-devel] [PATCH v2 07/10] target-arm: remove last users of cpsr_write

2014-07-10 Thread Alex Bennée
And use the new machinery to to save and restore program state. The old cpsr_write function did some special handling for mode switches which has been moved into the helper function. Signed-off-by: Alex Bennée --- v2: - rebase - add mask helper function - checkpatch fixes diff --git a/lin

Re: [Qemu-devel] Help on possible hang in drive-mirror / query-block-jobs

2014-07-10 Thread Paolo Bonzini
Il 10/07/2014 17:53, Daniel P. Berrange ha scritto: > Can you install a custom QEMU? How many megabytes of stdout can your test > rig tolerate? Any chance you can collect other files (traces)? I can possibly come up with some gross hack to wget a qemu binary from an external host at the start

[Qemu-devel] [PULL 10/10] qtest: fix vhost-user-test compilation with old GLib

2014-07-10 Thread Paolo Bonzini
From: Nikolay Nikolaev Mising G_TIME_SPAN_SECOND definition breaks the RHEL6 compilation as GLib version before 2.26 does not have it. In such case just define it. Reported-by: Kevin Wolf Signed-off-by: Nikolay Nikolaev Signed-off-by: Paolo Bonzini --- tests/vhost-user-test.c | 4 1 fil

Re: [Qemu-devel] [PATCH 16/46] Add migration-capability boolean for postcopy-ram.

2014-07-10 Thread Paolo Bonzini
Il 07/07/2014 22:23, Dr. David Alan Gilbert ha scritto: I think what I need to do for that is: 1) As for precopy add the option not to start the destination CPU on entry to postcopy; I think that's OK, because we can carry on in postcopy mode even if the destination CPU isn't run

[Qemu-devel] [PULL 05/10] watchdog: fix deadlock with -watchdog-action pause

2014-07-10 Thread Paolo Bonzini
qemu_clock_enable says: /* Disabling the clock will wait for related timerlists to stop * executing qemu_run_timers. Thus, this functions should not * be used from the callback of a timer that is based on @clock. * Doing so would cause a deadlock. */ and it indeed does: vm_stop uses qemu_clo

[Qemu-devel] [PULL for-2.1 13/22] virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and VirtQueueElement

2014-07-10 Thread Kevin Wolf
From: Stefan Hajnoczi In commit de6c8042ec55da18702fa51f09072fcaa315edc3 ("virtio-blk: Avoid zeroing every request structure") we avoided the 40 KB memset when allocating VirtIOBlockReq. The memset was reintroduced in commit 671ec3f056559f22a2531a91dce3a258b9b5eb8a ("virtio-blk: Convert VirtIOBl

[Qemu-devel] [PULL for-2.1 05/22] test-aio: fix GSource-based timer test

2014-07-10 Thread Kevin Wolf
From: Paolo Bonzini The current test depends too much on the implementation of the AioContext GSource. Just iterate on the main loop until the callback has been invoked the right number of times. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- tests/test-aio.c | 13 ++---

Re: [Qemu-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-10 Thread Stefano Stabellini
ping? On Thu, 12 Jun 2014, Stefano Stabellini wrote: > Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for > sure what is the machine that we are emulating. > > Use pc-i440fx-1.6 regardless of the xen_platform_pci option. Add the > xen-platform device if requested. Move the ma

[Qemu-devel] [PATCH 131/156] linux-user: Don't overrun guest buffer in sched_getaffinity

2014-07-10 Thread Michael Roth
From: Peter Maydell If the guest's "long" type is smaller than the host's, then our sched_getaffinity wrapper needs to round the buffer size up to a multiple of the host sizeof(long). This means that when we copy the data back from the host buffer to the guest's buffer there might be more than we

Re: [Qemu-devel] [PATCH] scripts: qapi-event.py: support vendor extension

2014-07-10 Thread Eric Blake
On 07/10/2014 08:31 AM, Markus Armbruster wrote: > Luiz Capitulino writes: > >> The event code generator barfs when it sees a dot in an event >> argument, this makes it impossible to support vendor extensions >> in event arguments as they always contain dots. Fix this by >> replacing dots by hyph

Re: [Qemu-devel] [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6

2014-07-10 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH v2] libxl: change default QEMU machine to pc-i440fx-1.6"): > ping? > > On Thu, 12 Jun 2014, Stefano Stabellini wrote: ... > > This patch does not change the emulated environment in the guest, unless > > soundhw='hda' is specified, in that case the xen-platfo

Re: [Qemu-devel] dataplane degradation in 2.1

2014-07-10 Thread Paolo Bonzini
Il 10/07/2014 17:10, Andrey Korolyov ha scritto: Cool, thanks Stefan. Nearly missed this set in patchwork because it came a bit earlier than the latest fix addressed to the segfault I mentioned. By the way, do you plan to add I/O throttlers to the iothread model in next release cycles? Throttli

Re: [Qemu-devel] [PATCH v2 2.1 4/4] ide: Treat read/write beyond end as invalid

2014-07-10 Thread Markus Armbruster
Kevin Wolf writes: > Am 04.07.2014 um 15:32 hat Markus Armbruster geschrieben: >> The block layer fails such reads and writes just fine. However, they >> then get treated like valid operations that fail: the error action >> gets executed. Unwanted; reporting the error to the guest is the only >

Re: [Qemu-devel] [RFC] alpha qemu arithmetic exceptions

2014-07-10 Thread Al Viro
On Tue, Jul 08, 2014 at 05:33:16PM +0100, Peter Maydell wrote: > > Incidentally, combination of --enable-gprof and (default) --enable-pie > > won't build - it dies with ld(1) complaining about relocs in gcrt1.o. > > This sounds like a toolchain bug to me :-) Debian stable/amd64, gcc 4.7.2, binut

[Qemu-devel] [PATCH 109/156] block: Limit request size (CVE-2014-0143)

2014-07-10 Thread Michael Roth
From: Kevin Wolf Limiting the size of a single request to INT_MAX not only fixes a direct integer overflow in bdrv_check_request() (which would only trigger bad behaviour with ridiculously huge images, as in close to 2^64 bytes), but can also prevent overflows in all block drivers. Signed-off-by

[Qemu-devel] [RFC 12/25] accel: Move accel init/allowed code to separate function

2014-07-10 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/core/accel.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/hw/core/accel.c b/hw/core/accel.c index 9aa853f..85e60eb 100644 --- a/hw/core/accel.c +++ b/hw/core/accel.c @@ -57,6 +57,17 @@ static AccelClass *accel_find(cons

[Qemu-devel] [PATCH 129/156] block/sheepdog: Plug memory leak in sd_snapshot_create()

2014-07-10 Thread Michael Roth
From: Markus Armbruster Has always been leaky. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Benoit Canet Signed-off-by: Kevin Wolf (cherry picked from commit 2df5fee2dbd56a9c34afd6d7df6744da2d951ccb) Signed-off-by: Michael Roth --- block/sheepdog.c | 4 ++-- 1 file ch

[Qemu-devel] [PATCH 095/156] qcow2: Zero-initialise first cluster for new images

2014-07-10 Thread Michael Roth
From: Kevin Wolf Strictly speaking, this is only required for has_zero_init() == false, but it's easy enough to just do a cluster-aligned write that is padded with zeros after the header. This fixes that after 'qemu-img create' header extensions are attempted to be parsed that are really just ra

Re: [Qemu-devel] [RFC PATCH V5 0/3] Support xen HVM direct kernel boot

2014-07-10 Thread Ian Campbell
On Mon, 2014-07-07 at 14:34 +0800, Chunyan Liu wrote: > Updated current patch series for working with qemu-xen and default > BIOS (seabios), to make it in good shape. Stubdom support will be > continued. This series is all acked and hasn't really felt RFC for a few iterations now. I suppose the x

[Qemu-devel] [RFC 06/25] accel: Use QOM classes for accel types

2014-07-10 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/core/accel.c| 117 ++--- include/hw/accel.h | 27 + 2 files changed, 120 insertions(+), 24 deletions(-) diff --git a/hw/core/accel.c b/hw/core/accel.c index 7f9b715..b42335c 100644 --- a/hw/cor

[Qemu-devel] [PATCH 087/156] qcow2: Check header_length (CVE-2014-0144)

2014-07-10 Thread Michael Roth
From: Kevin Wolf This fixes an unbounded allocation for s->unknown_header_fields. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Signed-off-by: Stefan Hajnoczi (cherry picked from commit 24342f2cae47d03911e346fe1e520b00dc2818e0) Conflicts: tests/qemu-iotests/group *fixed context m

[Qemu-devel] [PULL for-2.1 02/22] block: Fix bdrv_is_allocated() return value

2014-07-10 Thread Kevin Wolf
bdrv_is_allocated() should return either 0 or 1 in successful cases. We're lucky that currently, the callers that rely on this (e.g. because they check for ret == 1) don't seem to break badly. They just might skip some optimisation or in the case of qemu-io 'map' print separate lines where a single

[Qemu-devel] [PATCH v2 05/10] arm/nwfps: replace cpsr_write with set_condition_codes

2014-07-10 Thread Alex Bennée
This is a pre-cursor to removing the cpsr_write function completely from the code base. set_condition_codes() only affects the integer condition flags. Signed-off-by: Alex Bennée --- v2 - fix nwfpe set_condition_codes diff --git a/linux-user/arm/nwfpe/fpa11.h b/linux-user/arm/nwfpe/fpa11.h in

Re: [Qemu-devel] [PATCH 16/46] Add migration-capability boolean for postcopy-ram.

2014-07-10 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 07/07/2014 22:23, Dr. David Alan Gilbert ha scritto: > >I think what I need to do for that is: > > 1) As for precopy add the option not to start the destination CPU on > > entry to postcopy; > > I think that's OK, because we can carry on in

[Qemu-devel] [PATCH 3/4 v7] ppc: Add software breakpoint support

2014-07-10 Thread Bharat Bhushan
This patch allow insert/remove software breakpoint. When QEMU is not able to handle debug exception then we inject program exception to guest because for software breakpoint QEMU uses a ehpriv-1 instruction; So there cannot be any reason that we are in qemu with exit reason KVM_EXIT_DEBUG for gue

[Qemu-devel] [PATCH 096/156] qcow2: Don't rely on free_cluster_index in alloc_refcount_block() (CVE-2014-0147)

2014-07-10 Thread Michael Roth
From: Kevin Wolf free_cluster_index is only correct if update_refcount() was called from an allocation function, and even there it's brittle because it's used to protect unfinished allocations which still have a refcount of 0 - if it moves in the wrong place, the unfinished allocation can be corr

Re: [Qemu-devel] dataplane degradation in 2.1

2014-07-10 Thread Andrey Korolyov
Cool, thanks Stefan. Nearly missed this set in patchwork because it came a bit earlier than the latest fix addressed to the segfault I mentioned. By the way, do you plan to add I/O throttlers to the iothread model in next release cycles? On Thu, Jul 10, 2014 at 6:39 PM, Stefan Hajnoczi wrote: > O

Re: [Qemu-devel] [PATCH buildfix for-2.1] tests: Fix unterminated string output visitor enum human string

2014-07-10 Thread Peter Maydell
On 9 July 2014 21:28, Andreas Färber wrote: > The buffer was being allocated of size string length plus two. > Around the string two quotes were being added, but no terminating NUL. > It was then compared using g_assert_cmpstr(), resulting in fairly random > assertion failures: > > ERROR:tests/te

[Qemu-devel] [PATCH/RFC 5/5] s390x/kvm: propagate s390 cpu state to kvm

2014-07-10 Thread Christian Borntraeger
From: David Hildenbrand Let QEMU propagate the cpu state to kvm. If kvm doesn't yet support it, it is silently ignored as kvm will still handle the cpu state itself in that case. The state is not synced back, thus kvm won't have a chance to actively modify the cpu state. To do so, control has to

[Qemu-devel] [PULL for-2.1 07/22] block: Make qiov match the request size until EOF

2014-07-10 Thread Kevin Wolf
If a read request goes across EOF, the block driver sees a shortened request that stops at EOF (the rest is memsetted in block.c), however the original qiov was used for this request. This patch makes the qiov size match the request size, avoiding a potential buffer overflow in raw-posix. Signed-

  1   2   3   >