Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Chen, Tiejun
On 2014/6/30 14:48, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 10:51:49AM +0800, Chen, Tiejun wrote: On 2014/6/26 18:03, Paolo Bonzini wrote: Il 26/06/2014 11:18, Chen, Tiejun ha scritto: - offsets 0x..0x0fff map to configuration space of the host MCH Are you saying the config

[Qemu-devel] [PATCH] ui/vnc: fix potential memory corruption issues

2014-06-30 Thread Peter Lieven
this patch addresses 2 memory corruption issues. The first was actually discovered during playing around with a Windows 7 vServer. During resolution change in Windows 7 it happens sometimes that Windows changes to an intermediate resolution where server_stride % cmp_bytes != 0 (in vnc_refresh_serv

Re: [Qemu-devel] [PATCH 0/4] ui/cocoa: Fix absolute positioning and other bugs

2014-06-30 Thread Gerd Hoffmann
On Mo, 2014-06-23 at 10:35 +0100, Peter Maydell wrote: > This set of cocoa UI patches: > * fixes the completely broken handling of absolute positioning >(tablet-style) input devices > * fixes a bug where if the first surface created was the same 640x480 >as the initial window we'd never a

Re: [Qemu-devel] possible denial of service via VNC

2014-06-30 Thread Gerd Hoffmann
On So, 2014-06-29 at 14:16 +0200, Peter Lieven wrote: > Hi, > > while debugging a VNC issue I found this: > > case VNC_MSG_CLIENT_CUT_TEXT: > if (len == 1) > return 8; > > if (len == 8) { > uint32_t dlen = read_u32(data, 4); > if (dlen > 0)

Re: [Qemu-devel] possible denial of service via VNC

2014-06-30 Thread Peter Lieven
On 30.06.2014 09:33, Gerd Hoffmann wrote: On So, 2014-06-29 at 14:16 +0200, Peter Lieven wrote: Hi, while debugging a VNC issue I found this: case VNC_MSG_CLIENT_CUT_TEXT: if (len == 1) return 8; if (len == 8) { uint32_t dlen = read_u32(data, 4

Re: [Qemu-devel] possible denial of service via VNC

2014-06-30 Thread Gerd Hoffmann
Hi, > I would vote for disconnect as soon as the limit specified is too big. > Otherwise > we had to rewrite the whole receive logic which could introduce additional > bugs. Sounds sensible. cheers, Gerd

Re: [Qemu-devel] [PATCH] numa: check for busy memory backend

2014-06-30 Thread Hu Tao
On Mon, Jun 30, 2014 at 09:53:20AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 30, 2014 at 01:33:42PM +0800, Hu Tao wrote: > > On Sun, Jun 29, 2014 at 06:20:22PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 05:04:14PM +0800, Hu Tao wrote: > > > > ..to prevent one memory backend

Re: [Qemu-devel] [PATCH] Functions bus_foreach and device_find from libqos virtio API

2014-06-30 Thread Stefan Hajnoczi
On Thu, Jun 26, 2014 at 04:34:40PM +0200, Marc Marí wrote: > +static QVirtioPCIDevice *qpcidevice_to_qvirtiodevice(QPCIDevice *pdev) > +{ > +QVirtioPCIDevice *vpcidev; > +vpcidev = g_malloc0(sizeof(*vpcidev)); > + > +if (pdev) { > +vpcidev->pdev = pdev; > +vpcidev->vdev.

Re: [Qemu-devel] possible denial of service via VNC

2014-06-30 Thread Peter Lieven
On 30.06.2014 09:46, Gerd Hoffmann wrote: Hi, I would vote for disconnect as soon as the limit specified is too big. Otherwise we had to rewrite the whole receive logic which could introduce additional bugs. Sounds sensible. Especially since client_cut_text is currently a NOP. Peter

Re: [Qemu-devel] [PATCH] ui/vnc: fix potential memory corruption issues

2014-06-30 Thread Gerd Hoffmann
On Mo, 2014-06-30 at 09:24 +0200, Peter Lieven wrote: > this patch addresses 2 memory corruption issues. > > The first was actually discovered during playing > around with a Windows 7 vServer. During resolution > change in Windows 7 it happens sometimes that Windows > changes to an intermediate re

Re: [Qemu-devel] [PATCH] ui/vnc: fix potential memory corruption issues

2014-06-30 Thread Peter Lieven
On 30.06.2014 09:52, Gerd Hoffmann wrote: On Mo, 2014-06-30 at 09:24 +0200, Peter Lieven wrote: this patch addresses 2 memory corruption issues. The first was actually discovered during playing around with a Windows 7 vServer. During resolution change in Windows 7 it happens sometimes that Wind

[Qemu-devel] [PATCH] ui/vnc: limit client_cut_text msg payload size

2014-06-30 Thread Peter Lieven
currently a malicious client could define a payload size of 2^32 - 1 bytes and send up to that size of data to the vnc server. The server would allocated that amount of memory which could easily create an out of memory condition. This patch limits the payload size to 1MB max. Please note that cli

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-30 Thread Stefan Hajnoczi
On Sat, Jun 28, 2014 at 05:58:58PM +0800, Ming Lei wrote: > On Sat, Jun 28, 2014 at 5:51 AM, Paolo Bonzini wrote: > > Il 27/06/2014 20:01, Ming Lei ha scritto: > > > >> I just implemented plug&unplug based batching, and it is working now. > >> But throughout still has no obvious improvement. > >>

Re: [Qemu-devel] [PATCH] numa: check for busy memory backend

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 03:46:56PM +0800, Hu Tao wrote: > On Mon, Jun 30, 2014 at 09:53:20AM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 30, 2014 at 01:33:42PM +0800, Hu Tao wrote: > > > On Sun, Jun 29, 2014 at 06:20:22PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jun 25, 2014 at 05:04:1

Re: [Qemu-devel] [regression] dataplane: throughout -40% by commit 580b6b2aa2

2014-06-30 Thread Ming Lei
On Mon, Jun 30, 2014 at 4:08 PM, Stefan Hajnoczi wrote: > On Sat, Jun 28, 2014 at 05:58:58PM +0800, Ming Lei wrote: >> On Sat, Jun 28, 2014 at 5:51 AM, Paolo Bonzini wrote: >> > Il 27/06/2014 20:01, Ming Lei ha scritto: >> > >> >> I just implemented plug&unplug based batching, and it is working n

[Qemu-devel] [PATCH v5] ppc: spapr-rtas - implement os-term rtas call

2014-06-30 Thread Nikunj A Dadhania
PAPR compliant guest calls this in absence of kdump. This finally reaches the guest and can be handled according to the policies set by higher level tools(like taking dump) for further analysis by tools like crash. Linux kernel calls ibm,os-term when extended property of os-term is set. This makes

Re: [Qemu-devel] [PATCH] ui/vnc: fix potential memory corruption issues

2014-06-30 Thread Gerd Hoffmann
On Mo, 2014-06-30 at 10:01 +0200, Peter Lieven wrote: > On 30.06.2014 09:52, Gerd Hoffmann wrote: > > So this basically makes vnc work correctly in case guest surface and > > server surface have different sizes, then fixes the two bugs on top of > > that. And it obsoletes the other corruption patc

Re: [Qemu-devel] [PATCH v4 0/9] virtio-blk: use alias properties in transport devices

2014-06-30 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 05:58:27PM +0800, Stefan Hajnoczi wrote: > v4: > * Coding style: typedef struct { on a single line [Andreas] > * Add "dataplane: bail out on unsupported transport" for s390-virtio > [Cornelia] > > v3: > * Split qdev_alias_all_properties() into its own patch [Peter Crost

Re: [Qemu-devel] [PATCH] numa: check for busy memory backend

2014-06-30 Thread Igor Mammedov
On Mon, 30 Jun 2014 11:28:07 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 30, 2014 at 03:46:56PM +0800, Hu Tao wrote: > > On Mon, Jun 30, 2014 at 09:53:20AM +0300, Michael S. Tsirkin wrote: > > > On Mon, Jun 30, 2014 at 01:33:42PM +0800, Hu Tao wrote: > > > > On Sun, Jun 29, 2014 at 06:20:22PM

[Qemu-devel] [PATCHv2] ui/vnc: fix potential memory corruption issues

2014-06-30 Thread Peter Lieven
this patch makes the VNC server work correctly if the server surface and the guest surface have different sizes. Basically the server surface is adjusted to not exceed VNC_MAX_WIDTH x VNC_MAX_HEIGHT and additionally the width is rounded up to multiple of VNC_DIRTY_PIXELS_PER_BIT. If we have a re

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 03:24:58PM +0800, Chen, Tiejun wrote: > On 2014/6/30 14:48, Michael S. Tsirkin wrote: > >On Mon, Jun 30, 2014 at 10:51:49AM +0800, Chen, Tiejun wrote: > >>On 2014/6/26 18:03, Paolo Bonzini wrote: > >>>Il 26/06/2014 11:18, Chen, Tiejun ha scritto: > > > > >- offs

Re: [Qemu-devel] [PATCH v5] ppc: spapr-rtas - implement os-term rtas call

2014-06-30 Thread Alexander Graf
> Am 30.06.2014 um 10:35 schrieb Nikunj A Dadhania : > > PAPR compliant guest calls this in absence of kdump. This finally > reaches the guest and can be handled according to the policies set by > higher level tools(like taking dump) for further analysis by tools like > crash. > > Linux kernel

Re: [Qemu-devel] [PATCH] numa: check for busy memory backend

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 10:48:22AM +0200, Igor Mammedov wrote: > On Mon, 30 Jun 2014 11:28:07 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jun 30, 2014 at 03:46:56PM +0800, Hu Tao wrote: > > > On Mon, Jun 30, 2014 at 09:53:20AM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Jun 30, 2014 at

Re: [Qemu-devel] [PATCH v5] ppc: spapr-rtas - implement os-term rtas call

2014-06-30 Thread Nikunj A Dadhania
Alexander Graf writes: >> Am 30.06.2014 um 10:35 schrieb Nikunj A Dadhania : >> >> +static void rtas_ibm_os_term(PowerPCCPU *cpu, >> +sPAPREnvironment *spapr, >> +uint32_t token, uint32_t nargs, >> +target_ulong

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-06-30 Thread Gerd Hoffmann
Hi, > >>> /* Make cirrues VGA S3 suspend/resume work in Windows > >>> XP/2003 */ > >>> Device (VGA) > >>> { > >>> - Name (_ADR, 0x0002) > >>> + // Address of the VGA (device F function 0) > >>> + Name (_ADR,

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Chen, Tiejun
On 2014/6/30 17:05, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 03:24:58PM +0800, Chen, Tiejun wrote: On 2014/6/30 14:48, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 10:51:49AM +0800, Chen, Tiejun wrote: On 2014/6/26 18:03, Paolo Bonzini wrote: Il 26/06/2014 11:18, Chen, Tiejun ha

Re: [Qemu-devel] [PULL 01/15] block/iscsi: handle BUSY condition

2014-06-30 Thread Alexey Kardashevskiy
On 06/19/2014 02:03 AM, Paolo Bonzini wrote: > From: Peter Lieven > > this patch adds handling of BUSY status reponse from an iSCSI target. > Currently, we fail with -EIO in case of SCSI_STATUS_BUSY while the > obvious reaction would be to retry the operation after some time. > The retry time is

Re: [Qemu-devel] [PATCH v2] qtest: enable vhost-user-test

2014-06-30 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 09:24:09PM +0300, Michael S. Tsirkin wrote: > On Thu, Jun 19, 2014 at 08:35:42PM +0300, Nikolay Nikolaev wrote: > > Use qtest-obj-y to get the right library order. CONFIG_POSIX ensures > > mingw compilation won't break. > > > > Signed-off-by: Nikolay Nikolaev > > okay but

Re: [Qemu-devel] [PATCH v3 1/2] block: Do not prematurely remove "filename"

2014-06-30 Thread Kevin Wolf
Am 26.06.2014 um 23:38 hat Max Reitz geschrieben: > If "filename" is removed from the options QDict before entering > bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait > until it has been copied there and remove it from the options only > afterwards. > > This fixes "filename" in

[Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch

2014-06-30 Thread Ming Lei
Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O at batch is removed. This patchset trys to introduce this mechanism on block, at least, linux-aio can benefit from that.

[Qemu-devel] [PATCH 1/3] block: introduce IO queue APIs

2014-06-30 Thread Ming Lei
This patch introduces IO queue related APIs so that following patches can support queuing I/O requests and submitting them at batch for improving I/O performance. Signed-off-by: Ming Lei --- aio-posix.c | 13 block.c | 78 +

[Qemu-devel] [PATCH 2/3] block: linux-aio: support submit io_queue

2014-06-30 Thread Ming Lei
This patch implements .bdrv_submit_io_queue callback for linux-aio Block Drivers, so that submitting I/O at batch can be supported on linux-aio. Signed-off-by: Ming Lei --- block/linux-aio.c | 32 ++-- block/raw-aio.h |1 + block/raw-posix.c | 16 +++

[Qemu-devel] [PATCH 3/3] dataplane: submit I/O at batch

2014-06-30 Thread Ming Lei
Before commit 580b6b2aa2(dataplane: use the Qemu block layer for I/O), dataplane for virtio-blk submits block I/O at batch. This commit 580b6b2aa2 replaces the custom linux AIO implementation(including I/O batch) with Qemu block layer, but this commit causes ~40% throughput regression on virtio-bl

Re: [Qemu-devel] [PATCH v8 00/14] qemu-img: Implement commit like QMP

2014-06-30 Thread Kevin Wolf
Am 28.06.2014 um 00:07 hat Max Reitz geschrieben: > On 07.06.2014 20:51, Max Reitz wrote: > >qemu-img should use QMP commands whenever possible in order to ensure > >feature completeness of both online and offline image operations. For > >the "commit" command, this is relatively easy, so implement

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 05:38:21PM +0800, Chen, Tiejun wrote: > On 2014/6/30 17:05, Michael S. Tsirkin wrote: > >On Mon, Jun 30, 2014 at 03:24:58PM +0800, Chen, Tiejun wrote: > >>On 2014/6/30 14:48, Michael S. Tsirkin wrote: > >>>On Mon, Jun 30, 2014 at 10:51:49AM +0800, Chen, Tiejun wrote: > O

Re: [Qemu-devel] [SeaBIOS] [PATCH v3] hw/pci: reserve IO and mem for pci express downstream ports with no devices attached

2014-06-30 Thread Gerd Hoffmann
On Mo, 2014-06-23 at 18:55 +0300, Michael S. Tsirkin wrote: > On Mon, Jun 23, 2014 at 06:29:51PM +0300, Marcel Apfelbaum wrote: > > Commit c6e298e1f12e0f4ca02b6da5e42919ae055f6830 > > hw/pci: reserve IO and mem for pci-2-pci bridges with no devices > > attached > > > > introduced support for

[Qemu-devel] [PATCH v3] tests: Functions bus_foreach and device_find from libqos virtio API

2014-06-30 Thread Marc Marí
Virtio header has been changed to compile and work with a real device. Functions bus_foreach and device_find have been implemented for PCI. Virtio-blk test case now opens a fake device. Signed-off-by: Marc Marí --- tests/Makefile|3 +- tests/libqos/virtio-pci.c | 72 +++

Re: [Qemu-devel] [PATCH] hw/virtio: enable common virtio feature for mmio device

2014-06-30 Thread Ming Lei
Hi Guys, On Wed, Jun 4, 2014 at 10:05 AM, Ming Lei wrote: > Both 'indirect_desc' and 'event_idx' are bus independent features, > and they should be enabled for mmio devices too. > > On arm64 quad core VM(qemu-kvm), the patch can increase block I/O > performance a lot with latest linux tree: >

Re: [Qemu-devel] [PATCH v8 01/14] qcow2: Allow "full" discard

2014-06-30 Thread Kevin Wolf
Am 07.06.2014 um 20:51 hat Max Reitz geschrieben: > Normally, discarded sectors should read back as zero. However, there are > cases in which a sector (or rather cluster) should be discarded as if > they were never written in the first place, that is, reading them should > fall through to the backi

Re: [Qemu-devel] [PATCH v8 02/14] qcow2: Implement bdrv_make_empty()

2014-06-30 Thread Kevin Wolf
Am 07.06.2014 um 20:51 hat Max Reitz geschrieben: > Implement this function by making all clusters in the image file fall > through to the backing file (by using the recently extended discard). > > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [questions] about KVM as a Microsoft-compatible hypervisor

2014-06-30 Thread Vadim Rozenfeld
On Mon, 2014-06-30 at 09:39 +0800, Zhang Haoyu wrote: > Hi, Vadim > I read the kvm-2012-forum paper < KVM as a Microsoft-compatible hypervisor>, > Any update and other references, please? > > Thanks, > Zhang Haoyu > > Unfortunately, not too much. >From the the most recent, we have lazy eoi imp

Re: [Qemu-devel] [PATCH] hw/virtio: enable common virtio feature for mmio device

2014-06-30 Thread Michael S. Tsirkin
On Wed, Jun 04, 2014 at 10:05:55AM +0800, Ming Lei wrote: > Both 'indirect_desc' and 'event_idx' are bus independent features, > and they should be enabled for mmio devices too. > > On arm64 quad core VM(qemu-kvm), the patch can increase block I/O > performance a lot with latest linux tree: >

Re: [Qemu-devel] [PATCH] hw/virtio: enable common virtio feature for mmio device

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 16, 2014 at 05:26:33PM +0800, Ming Lei wrote: > On Mon, Jun 16, 2014 at 3:54 PM, Paolo Bonzini wrote: > > Il 09/06/2014 10:00, Ming Lei ha scritto: > > > >> On Wed, Jun 4, 2014 at 10:05 AM, Ming Lei wrote: > >>> > >>> Both 'indirect_desc' and 'event_idx' are bus independent features,

Re: [Qemu-devel] [PATCH] hw/virtio: enable common virtio feature for mmio device

2014-06-30 Thread Ming Lei
On Mon, Jun 30, 2014 at 6:09 PM, Michael S. Tsirkin wrote: > On Mon, Jun 16, 2014 at 05:26:33PM +0800, Ming Lei wrote: >> On Mon, Jun 16, 2014 at 3:54 PM, Paolo Bonzini wrote: >> > Il 09/06/2014 10:00, Ming Lei ha scritto: >> > >> >> On Wed, Jun 4, 2014 at 10:05 AM, Ming Lei wrote: >> >>> >> >>>

Re: [Qemu-devel] [PATCH] virtio: move common virtio properties to bus class device

2014-06-30 Thread Ming Lei
Hi Michael, On Wed, Jun 18, 2014 at 3:13 PM, Ming Lei wrote: > The two common virtio features can be defined per bus, so move all > into bus class device to make code more clean. > > As discussed with cornelia, s390-virtio-blk doesn't support > the two features at all, so keep s390-virtio as it.

Re: [Qemu-devel] [PATCH] numa: check for busy memory backend

2014-06-30 Thread Hu Tao
On Mon, Jun 30, 2014 at 12:12:20PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 30, 2014 at 10:48:22AM +0200, Igor Mammedov wrote: > > On Mon, 30 Jun 2014 11:28:07 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jun 30, 2014 at 03:46:56PM +0800, Hu Tao wrote: > > > > On Mon, Jun 30, 201

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Chen, Tiejun
On 2014/6/30 17:55, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 05:38:21PM +0800, Chen, Tiejun wrote: On 2014/6/30 17:05, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 03:24:58PM +0800, Chen, Tiejun wrote: On 2014/6/30 14:48, Michael S. Tsirkin wrote: On Mon, Jun 30, 2014 at 10:51:4

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-06-30 Thread Chen, Tiejun
On 2014/6/30 17:29, Gerd Hoffmann wrote: Hi, /* Make cirrues VGA S3 suspend/resume work in Windows XP/2003 */ Device (VGA) { - Name (_ADR, 0x0002) + // Address of the VGA (device F function 0) + Name (

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-30 Thread Gerd Hoffmann
Hi, > > * The old qemu_chr_open_socket() has an > >"if (!is_waitconnect) > >qemu_set_nonblock(fd); > >which the QMP char-open codepath has never had. Does this matter? > >Which of the two code paths was correct? > > Gerd? IIRC the socket is put into non-blocking mode anywa

[Qemu-devel] [PATCH v2] numa: check for busy memory backend

2014-06-30 Thread Hu Tao
Specifying the same memory backend twice leads to an assert: ./x86_64-softmmu/qemu-system-x86_64 -m 512M -enable-kvm -object memory-backend-ram,size=256M,id=ram0 -numa node,nodeid=0,memdev=ram0 -numa node,nodeid=1,memdev=ram0 qemu-system-x86_64: /scm/qemu/memory.c:1506: memory_region_add_subregion

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-30 Thread Peter Maydell
On 30 June 2014 11:23, Gerd Hoffmann wrote: > Hi, > >> > * The old qemu_chr_open_socket() has an >> >"if (!is_waitconnect) >> >qemu_set_nonblock(fd); >> >which the QMP char-open codepath has never had. Does this matter? >> >Which of the two code paths was correct? >> >> Gerd

[Qemu-devel] [PATCH for-2.1 v2] pc-dimm: error out if memory hotplug is not enabled

2014-06-30 Thread Igor Mammedov
fixes QEMU abort in case it's started without memory hotplug enabled. as result of fix it will print following messages: " -device pc-dimm,id=d1,memdev=m1: memory hotplug is not enabled, enable it on startup -device pc-dimm,id=d1,memdev=m1: Device 'pc-dimm' could not be initialized " Also fixup

Re: [Qemu-devel] [PATCH for-2.1 v2] pc-dimm: error out if memory hotplug is not enabled

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 12:43:29PM +0200, Igor Mammedov wrote: > fixes QEMU abort in case it's started without memory > hotplug enabled. > > as result of fix it will print following messages: > " > -device pc-dimm,id=d1,memdev=m1: memory hotplug is not enabled, enable it on > startup > -device pc

Re: [Qemu-devel] [PATCH v2] numa: check for busy memory backend

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 06:28:15PM +0800, Hu Tao wrote: > Specifying the same memory backend twice leads to an assert: > > ./x86_64-softmmu/qemu-system-x86_64 -m 512M -enable-kvm -object > memory-backend-ram,size=256M,id=ram0 -numa node,nodeid=0,memdev=ram0 > -numa node,nodeid=1,memdev=ram0 > qemu

Re: [Qemu-devel] The first function called after migration for a block device

2014-06-30 Thread Paolo Bonzini
Il 28/06/2014 00:54, Xiongzi Ge ha scritto: Hi Paolo, Thanks. I found a function called bdrv_invalidate_cache() in qcow2.c. After migration, it will be called to invalidate the cache of the block device? Let me quote again: This function has *nothing* to do with the guest OS's cache.

Re: [Qemu-devel] [PATCH FOR 2.1 1/5] tests/test-qmp-event: fix for GLib < 2.31

2014-06-30 Thread Paolo Bonzini
Il 29/06/2014 22:31, Peter Maydell ha scritto: On 27 June 2014 19:28, Luiz Capitulino wrote: On Wed, 25 Jun 2014 15:15:35 +0200 Paolo Bonzini wrote: Il 25/06/2014 15:13, Luiz Capitulino ha scritto: On Tue, 24 Jun 2014 16:33:56 -0700 Wenchao Xia wrote: From: Paolo Bonzini On old GLib, t

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 05:13, Chen, Tiejun ha scritto: After I discuss internal, we think even we just set the real vendor/device ids to this ISA bridge at 00:1f.0, guest firmware should still work well with these pair of real vendor/device ids. So if you think something would conflict or be broken, coul

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-30 Thread Gerd Hoffmann
On Mo, 2014-06-30 at 11:33 +0100, Peter Maydell wrote: > On 30 June 2014 11:23, Gerd Hoffmann wrote: > > Hi, > > > >> > * The old qemu_chr_open_socket() has an > >> >"if (!is_waitconnect) > >> >qemu_set_nonblock(fd); > >> >which the QMP char-open codepath has never had. Does thi

Re: [Qemu-devel] [PATCH v2 3/3] serial: poll the serial console with G_IO_HUP

2014-06-30 Thread Roger Pau Monné
Do I need to resend this? it's been more than a month without review. Roger. On 13/06/14 17:35, Roger Pau Monné wrote: > Ping? > > On 23/05/14 17:57, Roger Pau Monne wrote: >> On FreeBSD polling a master pty while the other end is not connected >> with G_IO_OUT only results in an endless wait. T

Re: [Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 11:49, Ming Lei ha scritto: Hi, The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) introduces ~40% throughput regression on virtio-blk dataplane, and one of causes is that submitting I/O at batch is removed. This patchset trys to introduce this mechanism on block,

Re: [Qemu-devel] [questions] about KVM as a Microsoft-compatible hypervisor

2014-06-30 Thread Jidong Xiao
On Mon, Jun 30, 2014 at 6:02 AM, Vadim Rozenfeld wrote: > On Mon, 2014-06-30 at 09:39 +0800, Zhang Haoyu wrote: >> Hi, Vadim >> I read the kvm-2012-forum paper < KVM as a Microsoft-compatible hypervisor>, >> Any update and other references, please? >> >> Thanks, >> Zhang Haoyu >> >> > > Unfortunat

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-30 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Jun 17, 2014 at 11:44:11AM +0200, Paolo Bonzini wrote: >> Il 17/06/2014 11:03, David Marchand ha scritto: >> >>Unless someone steps up and maintains ivshmem, I think it should be >> >>deprecated and dropped from QEMU. >> > >> >Then I can maintain ivshmem for QEMU

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-30 Thread Gerd Hoffmann
Hi, > From what I can tell, we only ever call the cursor drawing callback on > non-shared surfaces. Should I deduce that the HW cursor emulation simply > doesn't work when using shared surfaces ? Or is there another path I > have missed to handle it ? Hmm. Looks like hw-cursor-on-shared-surfac

Re: [Qemu-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type

2014-06-30 Thread Michael S. Tsirkin
On Thu, Jun 19, 2014 at 05:53:51PM +0800, Tiejun Chen wrote: > Originally the reason to probe ISA bridge instead of Dev31:Fun0 > is to make graphics device passthrough work easy for VMM, that > only need to expose ISA bridge to let driver know the real > hardware underneath. This is a requirement f

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 12:20, Chen, Tiejun ha scritto: I already post this to mainline to change as follows: -while ((pch = pci_get_class(PCI_CLASS_BRIDGE_ISA << 8, pch))) { +pch = pci_get_bus_and_slot(0, PCI_DEVFN(0x1f, 0)); +if (pch) { Please refer to this, [RFC][PATCH] gpu:drm:i915:inte

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 06:20:22PM +0800, Chen, Tiejun wrote: > On 2014/6/30 17:55, Michael S. Tsirkin wrote: > >On Mon, Jun 30, 2014 at 05:38:21PM +0800, Chen, Tiejun wrote: > >>On 2014/6/30 17:05, Michael S. Tsirkin wrote: > >>>On Mon, Jun 30, 2014 at 03:24:58PM +0800, Chen, Tiejun wrote: > O

Re: [Qemu-devel] [Xen-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 01:18:51PM +0200, Paolo Bonzini wrote: > Il 30/06/2014 12:20, Chen, Tiejun ha scritto: > > > >I already post this to mainline to change as follows: > > > >-while ((pch = pci_get_class(PCI_CLASS_BRIDGE_ISA << 8, pch))) { > >+pch = pci_get_bus_and_slot(0, PCI_DEVFN(0x1

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-30 Thread Peter Maydell
On 30 June 2014 11:57, Gerd Hoffmann wrote: > IIRC "wait for client to connect" is a blocking accept() call. Which > you certainly don't want do in a qmp command handler. So if we switch > over chardevs created via -chardev to use the qmp init code path too we > need some hackery to make '-chard

Re: [Qemu-devel] [RFC 10/14] vga: Remove some "should be done in BIOS" comments

2014-06-30 Thread Gerd Hoffmann
On Di, 2014-06-24 at 09:11 +1000, Benjamin Herrenschmidt wrote: > Not all platforms have a VGA BIOS, powerpc typically relies on > using the DISPI interface to initialize the card. s/bios/guest/ and it would hold ;) But the dispi interface is defined the way it is. We are not going to change it,

Re: [Qemu-devel] [PATCH v8 03/14] qcow2: Optimize bdrv_make_empty()

2014-06-30 Thread Kevin Wolf
Am 07.06.2014 um 20:51 hat Max Reitz geschrieben: > bdrv_make_empty() is currently only called if the current image > represents an external snapshot that has been committed to its base > image; it is therefore unlikely to have internal snapshots. In this > case, bdrv_make_empty() can be greatly sp

Re: [Qemu-devel] [questions] about KVM as a Microsoft-compatible hypervisor

2014-06-30 Thread Vadim Rozenfeld
On Mon, 2014-06-30 at 06:19 -0400, Jidong Xiao wrote: > On Mon, Jun 30, 2014 at 6:02 AM, Vadim Rozenfeld wrote: > > On Mon, 2014-06-30 at 09:39 +0800, Zhang Haoyu wrote: > >> Hi, Vadim > >> I read the kvm-2012-forum paper < KVM as a Microsoft-compatible > >> hypervisor>, > >> Any update and other

Re: [Qemu-devel] [RFC 13/14] vga: Add endian control register

2014-06-30 Thread Gerd Hoffmann
Hi, > diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h > index ae64321..894c6ab 100644 > --- a/hw/display/vga_int.h > +++ b/hw/display/vga_int.h > @@ -47,6 +47,8 @@ > #define VBE_DISPI_INDEX_Y_OFFSET0x9 > #define VBE_DISPI_INDEX_NB 0xa /* size of vbe_regs[] */ > #

Re: [Qemu-devel] [questions] about KVM as a Microsoft-compatiblehypervisor

2014-06-30 Thread Zhang Haoyu
>> Hi, Vadim >> I read the kvm-2012-forum paper < KVM as a Microsoft-compatible hypervisor>, >> Any update and other references, please? >> >> Thanks, >> Zhang Haoyu >> >> > >Unfortunately, not too much. >From the the most recent, we have lazy eoi implemented by >MST and reference time counter

[Qemu-devel] [PATCH 0/5] tests: Add the image fuzzer with qcow2 support

2014-06-30 Thread Maria Kustova
This patch series introduces the image fuzzer, a tool for stability and reliability testing. Its approach is to run large amount of tests in background. During every test a program (e.g. qemu-img) is called to read or modify an invalid test image. A test image has valid inner structure defined by i

[Qemu-devel] [PATCH 1/5] docs: Specification for the image fuzzer

2014-06-30 Thread Maria Kustova
'Overall fuzzer requirements' chapter contains the current product vision and features done and to be done. This chapter is still in progress. Signed-off-by: Maria Kustova --- tests/image-fuzzer/docs/image-fuzzer.txt | 176 +++ 1 file changed, 176 insertions(+) creat

[Qemu-devel] [PATCH 4/5] layout: Generator of fuzzed qcow2 images

2014-06-30 Thread Maria Kustova
Layout submodule of qcow2 package creates a random valid image, randomly selects some amount of its fields, fuzzes them and write the fuzzed image to the file. Now only header and header extensions are generated, remaining file is filled by zeroes. Signed-off-by: Maria Kustova --- tests/image-fu

[Qemu-devel] [PATCH 2/5] runner: Tool for fuzz tests execution

2014-06-30 Thread Maria Kustova
The purpose of the test runner is to prepare test environment (e.g. create a work directory, a test image, etc), execute the program under test with parameters, indicate a test failure if the program was killed during test execution and collect core dumps, logs and other test artifacts. The test r

Re: [Qemu-devel] [RFC 14/14] ppc/spapr/vga: Switch VGA endian on H_SET_MODE

2014-06-30 Thread Gerd Hoffmann
On Di, 2014-06-24 at 09:11 +1000, Benjamin Herrenschmidt wrote: > When the guest switches the interrupt endian mode, which essentially > means a global machine endian switch, we want to change the VGA > framebuffer endian mode as well in order to be backward compatible > with existing guests who do

[Qemu-devel] [PATCH 3/5] fuzz: Fuzzing functions for qcow2 images

2014-06-30 Thread Maria Kustova
Fuzz submodule of qcow2 image generator contains fuzzing functions for image fields. Each fuzzing function contains list of constraints and call of a helper function that randomly selects a fuzzed value satisfied to one of constraints. For now constraints are only known as invalid or potentially da

Re: [Qemu-devel] [PATCH] virtio: move common virtio properties to bus class device

2014-06-30 Thread Michael S. Tsirkin
On Mon, Jun 30, 2014 at 06:15:35PM +0800, Ming Lei wrote: > Hi Michael, > > > On Wed, Jun 18, 2014 at 3:13 PM, Ming Lei wrote: > > The two common virtio features can be defined per bus, so move all > > into bus class device to make code more clean. > > > > As discussed with cornelia, s390-virtio

[Qemu-devel] [PATCH 5/5] package: Public API for image-fuzzer/runner/runner.py

2014-06-30 Thread Maria Kustova
__init__.py provides the public API required by the test runner Signed-off-by: Maria Kustova --- tests/image-fuzzer/qcow2/__init__.py | 1 + 1 file changed, 1 insertion(+) create mode 100644 tests/image-fuzzer/qcow2/__init__.py diff --git a/tests/image-fuzzer/qcow2/__init__.py b/tests/image-f

Re: [Qemu-devel] [RFC 00/14] VGA cleanups and endian control

2014-06-30 Thread Gerd Hoffmann
On Di, 2014-06-24 at 09:10 +1000, Benjamin Herrenschmidt wrote: > This series cleans up VGA and a bit of cirrus to remove all > the now unused conversions to non-32bpp surfaces. Then the last > two patches add a proposed variant of the endian control register > and the (still somewhat controversial

Re: [Qemu-devel] [PATCH v5] ppc: spapr-rtas - implement os-term rtas call

2014-06-30 Thread Alexander Graf
On 30.06.14 11:25, Nikunj A Dadhania wrote: Alexander Graf writes: Am 30.06.2014 um 10:35 schrieb Nikunj A Dadhania : +static void rtas_ibm_os_term(PowerPCCPU *cpu, +sPAPREnvironment *spapr, +uint32_t token, uint32_t nargs, +

Re: [Qemu-devel] [PATCH 1/2] target-ppc: Change default cpu for ppc64le-linux-user

2014-06-30 Thread Tom Musta
On 6/28/2014 1:42 PM, Richard Henderson wrote: > On 06/28/2014 09:50 AM, Alexander Graf wrote: >> How about we switch to p7 for BE top? > > Not ideal until we implement all of p7's insns in TCG: > > Warning: Disabling some instructions which are not emulated by TCG (0x0, 0x4) > > > r~ > That

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Paolo Bonzini
Il 28/06/2014 18:59, Peter Maydell ha scritto: Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing sometimes, because it means that when Make does its "is any makefile or include out of date and needing a rebuild?" check, as well as possibly ru

Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-30 Thread Alexander Graf
On 29.06.14 20:21, reza.jel...@gmail.com wrote: This requires a custom ovmf image with sata controller for testing [0] [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2 I guess this is supposed to be a cover letter? A few rules for cover letters: 1) Cover letters only make sense for patch s

Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-30 Thread Alexander Graf
On 29.06.14 20:21, reza.jel...@gmail.com wrote: From: Reza Jelveh This is a hint that your git configuration isn't fully correct. If the email address git thinks you want to use is the same as the From: email address, it will not print this line. I suppose the problem is with the differenc

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Peter Maydell
On 30 June 2014 13:09, Paolo Bonzini wrote: > Il 28/06/2014 18:59, Peter Maydell ha scritto: > >> Having a direct dependency >>Makefile: $(GENERATED_HEADERS) >> can result in not-from-clean builds failing sometimes, because it means >> that when Make does its "is any makefile or include out of

Re: [Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch

2014-06-30 Thread Ming Lei
Hi Paolo, On Mon, Jun 30, 2014 at 7:10 PM, Paolo Bonzini wrote: > Il 30/06/2014 11:49, Ming Lei ha scritto: > >> Hi, >> >> The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O) >> introduces ~40% throughput regression on virtio-blk dataplane, and >> one of causes is that submitting I

Re: [Qemu-devel] [PATCH 1/2] target-ppc: Change default cpu for ppc64le-linux-user

2014-06-30 Thread Alexander Graf
On 30.06.14 14:08, Tom Musta wrote: On 6/28/2014 1:42 PM, Richard Henderson wrote: On 06/28/2014 09:50 AM, Alexander Graf wrote: How about we switch to p7 for BE top? Not ideal until we implement all of p7's insns in TCG: Warning: Disabling some instructions which are not emulated by TCG (0x

Re: [Qemu-devel] [questions] about KVM as a Microsoft-compatiblehypervisor

2014-06-30 Thread Vadim Rozenfeld
On Mon, 2014-06-30 at 19:45 +0800, Zhang Haoyu wrote: > >> Hi, Vadim > >> I read the kvm-2012-forum paper < KVM as a Microsoft-compatible > >> hypervisor>, > >> Any update and other references, please? > >> > >> Thanks, > >> Zhang Haoyu > >> > >> > > > >Unfortunately, not too much. > >From the

Re: [Qemu-devel] [PATCH 0/3] iotests: Fix qemu-iotests-quick.sh

2014-06-30 Thread Kevin Wolf
Am 27.06.2014 um 22:47 hat Max Reitz geschrieben: > My previous series "iotests: Allow out-of-tree run" broke > qemu-iotests-quick.sh. Fixing it means simplifying it and allowing more > tests to be added to the quick group, which is what this series does. It > also adds some unaffected tests to the

Re: [Qemu-devel] [PATCH 2/2] target-ppc: Fix gdbstub for ppc64le-linux-user

2014-06-30 Thread Alexander Graf
On 28.06.14 18:45, Richard Henderson wrote: The bswap that's needed for system mode isn't required for user mode, and in fact breaks debugging. Cc: Aldy Hernandez Signed-off-by: Richard Henderson This breaks the Apple gdbstub backend we recently got in target-ppc. I'll fix it up while appl

Re: [Qemu-devel] [PATCH 0/2] ppc64le-linux-user fixes

2014-06-30 Thread Alexander Graf
On 28.06.14 18:45, Richard Henderson wrote: Two fixes needed to run and debug hello world. Thanks, fixed up both patches and applied the to ppc-next (2.1 branch). Alex

Re: [Qemu-devel] [PATCH v2 3/3] serial: poll the serial console with G_IO_HUP

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 13:00, Roger Pau Monné ha scritto: Do I need to resend this? it's been more than a month without review. I'll send a pull request for it. Sorry for the delay. Paolo On 13/06/14 17:35, Roger Pau Monné wrote: Ping? On 23/05/14 17:57, Roger Pau Monne wrote: On FreeBSD polling

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 12:57, Gerd Hoffmann ha scritto: On Mo, 2014-06-30 at 11:33 +0100, Peter Maydell wrote: On 30 June 2014 11:23, Gerd Hoffmann wrote: Hi, * The old qemu_chr_open_socket() has an "if (!is_waitconnect) qemu_set_nonblock(fd); which the QMP char-open codepath has neve

Re: [Qemu-devel] [PATCH 0/3] block: introduce submit I/O at batch

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 14:16, Ming Lei ha scritto: I added the io queue into AioContext because the io queue can only be used in the attached context(or thread), that said the io queue has to be put into per context instance. It doesn't *have* to be per-thread. It is certainly simplest if you make it p

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-30 Thread Benjamin Herrenschmidt
On Mon, 2014-06-30 at 13:14 +0200, Gerd Hoffmann wrote: > Hi, > > > From what I can tell, we only ever call the cursor drawing callback on > > non-shared surfaces. Should I deduce that the HW cursor emulation simply > > doesn't work when using shared surfaces ? Or is there another path I > > hav

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-30 Thread Peter Maydell
On 30 June 2014 13:29, Paolo Bonzini wrote: > Il 30/06/2014 12:57, Gerd Hoffmann ha scritto: >> On Mo, 2014-06-30 at 11:33 +0100, Peter Maydell wrote: >>> In that case is qemu_chr_open_socket_fd() incorrect >>> in marking the socket as nonblocking in the >>> is_listen && is_waitconnect case? > > >

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 14:13, Peter Maydell ha scritto: > config-devices.mak is not reflected in any C header file. Apart from this, > > Reviewed-by: Paolo Bonzini Do you mean "...and therefore should not be listed on the RHS of this dependency" ? It need not be listed; it doesn't hurt to leave it in

  1   2   3   4   >