Re: [Qemu-devel] [Bug 1334397] [NEW] cmos RTC alarms no longer wake system from suspend

Il 25/06/2014 22:11, Paolo Bonzini ha scritto: > The only way to have the CMOS updated is from the guest, so the guest is > resumed. The "RTC wakeup!" also is just before setting the > RT_CLOCK_STATUS field in the ACPI PM1A event status register. > > However, I can reproduce that the system looks

Re: [Qemu-devel] [PATCH] pci: add checking whether the device is realized before unlinking the capability

On Thu, Jun 26, 2014 at 12:48:14PM +0900, SeokYeon Hwang wrote: > > On Wed, 2014-06-25 at 15:03 +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 06:59:08PM +0900, SeokYeon Hwang wrote: > > > > In case of the unrealized "pdev", memory can be illegally accessed and > > corrupted. > > >

Re: [Qemu-devel] vhost-user: broken mem regions

On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: > > >> nregions: 4 > >> region: > >>gpa = 0x1 > >>size = 3221225472 > >>ua = 0x2aab6ac0 > > > > High memory, above 3 gigabytes. > > > >> region:

Re: [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts

On 26.06.2014 07:01, Chun Yan Liu wrote: On 6/23/2014 at 10:06 PM, in message <53a8347c.6010...@dlhnet.de>, Peter Lieven wrote: On 05.06.2014 11:20, Chunyan Liu wrote: This patch series is to replace QEMUOptionParameter with QemuOpts, so that only one Qemu Option structure is kept in QEMU

[Qemu-devel] [PATCH 3/5 v5] ppc: Add debug interrupt injection handler

With this patch a debug interrupt can be injected to guest. Follow up patch will use this interface to inject debug interrupt to guest if qemu will not be able to handle. Signed-off-by: Bharat Bhushan --- v4->v5 - No change target-ppc/kvm.c | 53

[Qemu-devel] [PATCH 4/5 v5] ppc: Add software breakpoint support

This patch allow insert/remove software breakpoint Signed-off-by: Bharat Bhushan --- v4->v5 - No change target-ppc/kvm.c | 73 +--- 1 file changed, 59 insertions(+), 14 deletions(-) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 5238

[Qemu-devel] [PATCH 5/5 v5] ppc: Add hw breakpoint watchpoint support

This patch adds hardware breakpoint and hardware watchpoint support for ppc. If the debug interrupt is not handled then this is injected to guest. Signed-off-by: Bharat Bhushan --- v4->v5 - cleanup in kvmppc_hw_debug_points_init() - replaced assert in kvm_arch_insert_hw_breakpoint() with return

[Qemu-devel] [PATCH 0/5 v5] ppc: Add debug stub support

This patchset add support for - software breakpoint - h/w breakpoint - h/w watchpoint Please find description in individual patch. v4->v5 - cleanup in kvmppc_hw_debug_points_init() - replaced assert in kvm_arch_insert_hw_breakpoint() with return. This allows gdb to through warning "You ma

[Qemu-devel] [PATCH 2/5 v5] ppc: Add interface to inject interrupt to guest

This patch adds interface to inject interrupt to guest. Currently a void debug exception function added. Follow up patch will use this interface to inject debug interrupt to guest Signed-off-by: Bharat Bhushan --- v4->v5 - No change target-ppc/kvm.c | 22 ++ 1 file changed,

[Qemu-devel] [PATCH 1/5 v5] ppc: debug stub: Get trap instruction opcode from KVM

Get trap instruction opcode from KVM and this opcode will be used for setting software breakpoint in following patch Signed-off-by: Bharat Bhushan --- v4->v5 - No change target-ppc/kvm.c | 4 1 file changed, 4 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index dfa5a26..

Re: [Qemu-devel] 答复: [RFC PATCH v5 09/13] introduce reverse execution mechanism.

On 26/06/2014 04:31, lig.f...@cn.fujitsu.com wrote: > Hi, Hi, >> -邮件原件- >> 发件人: qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org >> [mailto:qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org] 代表 >> fred.kon...@greensocs.com >> 发送时间: 2014年6月25日 23:20 >> 收件人: qemu-devel@nongnu.org >

Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them

Paolo Bonzini writes: > Otherwise, hot-unplug of pci-serial-2x trips the assertion > in memory_region_destroy: > > (qemu) device_del gg > (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021: > memory_region_destroy: Assertion `((&mr->subregions)->tqh_first == ((void > *)0))'

Re: [Qemu-devel] 答复: [RFC PATCH v5 10/13] gdbstub: allow reverse execution in gdb stub.

On 26/06/2014 04:50, lig.f...@cn.fujitsu.com wrote: > Hi, > > Why not a gdb record support? > > Thanks! > Li Guang Hi, Good idea. We didn't think about that yet. It might be done in a futur patch-set. Thanks, Fred >> -邮件原件- >> 发件人: qemu-devel-bounces+lig.fnst=cn.fujitsu@nongnu.org >

Re: [Qemu-devel] [RFC v3 06/10] virt: Assign a VFIO platform device with -device option

On 06/26/2014 12:28 AM, Alexander Graf wrote: > > On 26.06.14 00:28, Peter Maydell wrote: >> On 2 June 2014 08:49, Eric Auger wrote: >>> This patch aims at allowing the end-user to specify the device he >>> wants to directly assign to his mach-virt guest in the QEMU command >>> line. >>> hw/arm

Re: [Qemu-devel] vhost-user: broken mem regions

On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: >> nregions: 4 region: gpa = 0x1 size = 3221225472 ua = 0x2aab6ac0

Re: [Qemu-devel] [RFC v3 03/10] vfio: add vfio-platform support

On 06/25/2014 11:21 PM, Alexander Graf wrote: > > On 02.06.14 09:49, Eric Auger wrote: >> From: Kim Phillips >> >> Functions for which PCI and platform device support share are moved >> into common.c. The common vfio_{get,put}_group() get an additional >> argument, a pointer to a vfio_reset_hand

[Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

Old code was affected by memory gaps which resulted in buffer pointers pointing to address outside of the mapped regions. Signed-off-by: Damjan Marion --- docs/specs/vhost-user.txt | 7 --- exec.c| 7 +++ hw/virtio/vhost-user.c| 22 +- includ

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

Alexander Graf writes: > On 25.06.14 13:27, Nikunj A Dadhania wrote: >> Alexander Graf writes: >> >> Let me put down my understanding: >> >> There are two possible way to handle kernel panic: >> 1) Kdump service running in guest - already working >> 2) Pass the kernel panic information to hyperv

Re: [Qemu-devel] vhost-user: broken mem regions

On Thu, Jun 26, 2014 at 07:44:24AM +, Damjan Marion (damarion) wrote: > > On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: > > > On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: > >> > >> On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: > >> > nregions: 4 >

Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

On Thu, Jun 26, 2014 at 09:55:03AM +0200, Damjan Marion wrote: > Old code was affected by memory gaps which > resulted in buffer pointers pointing to > address outside of the mapped regions. > > Signed-off-by: Damjan Marion > --- > docs/specs/vhost-user.txt | 7 --- > exec.c

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

> Am 26.06.2014 um 09:55 schrieb Nikunj A Dadhania : > > Alexander Graf writes: > >>> On 25.06.14 13:27, Nikunj A Dadhania wrote: >>> Alexander Graf writes: >>> >>> Let me put down my understanding: >>> >>> There are two possible way to handle kernel panic: >>> 1) Kdump service running in g

Re: [Qemu-devel] [RFC PATCH v5 00/13] Reverse execution.

On 25/06/2014 17:43, Paolo Bonzini wrote: Il 25/06/2014 17:19, fred.kon...@greensocs.com ha scritto: From: KONRAD Frederic Hi everybody, This is the fifth version of this RFC (see the changes below). Those are the two first patch-set we have been worked on for reverse execution. The first

Re: [Qemu-devel] memory: memory_region_transaction_commit() slow

On 06/25/2014 08:53 PM, Etienne Martineau wrote: Hi, It seems to me that there is a scale issue O(n) in memory_region_transaction_commit(). It's actually O(n^3). Flatview is kept sorted but is just a vector, so if you insert n regions, you have n^2 operations. In addition every PCI device

Re: [Qemu-devel] 答复: 答复: [RFC PATCH v5 09/13] introduce reverse execution mechanism.

On 26/06/2014 10:17, lig.f...@cn.fujitsu.com wrote: >> -邮件原件- >> 发件人: Frederic Konrad [mailto:fred.kon...@greensocs.com] >> 发送时间: 2014年6月26日 15:28 >> 收件人: Li, Guang/李 广; qemu-devel@nongnu.org >> 抄送: peter.mayd...@linaro.org; quint...@redhat.com; >> mark.bur...@greensocs.com; dgilb...@redhat

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

On 2014/6/26 10:00, Chen, Tiejun wrote: On 2014/6/26 7:04, Slutz, Donald Christopher wrote: On 06/24/14 22:49, Chen, Tiejun wrote: On 2014/5/19 19:22, Gerd Hoffmann wrote: Hi, I think '-vga none' just guarantees the qemu vga cards doesn't occupy 00:02.0, but this doesn't mean others use t

Re: [Qemu-devel] vhost-user: broken mem regions

On 26 Jun 2014, at 09:56, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 07:44:24AM +, Damjan Marion (damarion) wrote: >> >> On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: On 25 Jun 2014,

Re: [Qemu-devel] [v5][PATCH 3/5] xen, gfx passthrough: support Intel IGD passthrough with VT-D

On 2014/6/26 14:04, Michael S. Tsirkin wrote: On Thu, Jun 26, 2014 at 01:34:14PM +0800, Chen, Tiejun wrote: On 2014/6/25 22:05, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 10:17:19AM +0800, Tiejun Chen wrote: Some registers of Intel IGD are mapped in host bridge, so it needs to passthrou

Re: [Qemu-devel] [RFC v3 05/10] vfio: Add initial IRQ support in platform device

On 06/25/2014 11:40 PM, Alex Williamson wrote: > On Wed, 2014-06-25 at 23:28 +0200, Alexander Graf wrote: >> On 02.06.14 09:49, Eric Auger wrote: >>> This patch brings a first support for device IRQ assignment to a >>> KVM guest. Code is inspired of PCI INTx code. >>> >>> General principle of IRQ h

Re: [Qemu-devel] [RFC v3 06/10] virt: Assign a VFIO platform device with -device option

On 06/25/2014 11:30 PM, Alexander Graf wrote: > > On 02.06.14 09:49, Eric Auger wrote: >> This patch aims at allowing the end-user to specify the device he >> wants to directly assign to his mach-virt guest in the QEMU command >> line. >> >> The QEMU platform device becomes generic. >> >> Current

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

Alexander Graf writes: >> Am 26.06.2014 um 09:55 schrieb Nikunj A Dadhania : >> >> Alexander Graf writes: >> On 25.06.14 13:27, Nikunj A Dadhania wrote: Alexander Graf writes: Let me put down my understanding: There are two possible way to handle kernel panic:

Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

On 26 Jun 2014, at 10:01, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 09:55:03AM +0200, Damjan Marion wrote: >> Old code was affected by memory gaps which >> resulted in buffer pointers pointing to >> address outside of the mapped regions. >> >> Signed-off-by: Damjan Marion >> --- >> d

Re: [Qemu-devel] [RFC PATCH v3] numa: enable sparse node numbering

On Wed, Jun 25, 2014 at 09:23:17PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 01:52:56PM -0300, Eduardo Habkost wrote: > > On Wed, Jun 25, 2014 at 09:13:59AM -0700, Nishanth Aravamudan wrote: > > > On 25.06.2014 [13:21:34 +0200], Igor Mammedov wrote: > > > > On Tue, 24 Jun 2014 10:4

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

On 2014/6/25 17:54, Paolo Bonzini wrote: Il 25/06/2014 11:50, Chen, Tiejun ha scritto: For past devices, we know which BARs they use. For future devices, it would be nice if the PCH/MCH backdoor was specified so that we know they will leave a free BAR for virtualization. Now I'm a bit confu

Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

Il 26/06/2014 11:10, Damjan Marion (damarion) ha scritto: Does it really make a sense to keep old broken code, which doesn’t work if VM have more than 3 GB of RAM? As Nikolay said yesterday: > On the other hand there's no wide adoption of > the protocol so it's still not critical to change it.

Re: [Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

On 26.06.14 11:05, Nikunj A Dadhania wrote: Alexander Graf writes: Am 26.06.2014 um 09:55 schrieb Nikunj A Dadhania : Alexander Graf writes: On 25.06.14 13:27, Nikunj A Dadhania wrote: Alexander Graf writes: Let me put down my understanding: There are two possible way to handle kernel

Re: [Qemu-devel] [RFC v3 06/10] virt: Assign a VFIO platform device with -device option

On 26.06.14 10:53, Eric Auger wrote: On 06/25/2014 11:30 PM, Alexander Graf wrote: On 02.06.14 09:49, Eric Auger wrote: This patch aims at allowing the end-user to specify the device he wants to directly assign to his mach-virt guest in the QEMU command line. The QEMU platform device becomes

Re: [Qemu-devel] [RFC v3 06/10] virt: Assign a VFIO platform device with -device option

On 06/26/2014 11:25 AM, Alexander Graf wrote: > > On 26.06.14 10:53, Eric Auger wrote: >> On 06/25/2014 11:30 PM, Alexander Graf wrote: >>> On 02.06.14 09:49, Eric Auger wrote: This patch aims at allowing the end-user to specify the device he wants to directly assign to his mach-virt gue

[Qemu-devel] [PATCH 3/4] mips_malta: Remove incorrect KVM T&E references

Fix the error message and code comments relating to KVM not supporting booting from the flash mapping when no kernel is provided. The issue is a general MIPS KVM issue and isn't specific to the Trap & Emulate version of MIPS KVM. Reported-by: Andreas Färber Signed-off-by: James Hogan Cc: Aurelie

[Qemu-devel] [PATCH 0/4] QEMU MIPS KVM improvements for v2.1

This patchset has a few improvements & minor fixes for MIPS KVM support. Patches 1-2 are fixes for forward compatibility of savevm with MIPS KVM. Patch 3 just corrects comments and an error message. Patch 4 adds errors when the wrong type of kernel is provided. James Hogan (4): mips/kvm: Init E

Re: [Qemu-devel] [RFC v3 03/10] vfio: add vfio-platform support

On 26.06.14 09:47, Eric Auger wrote: On 06/25/2014 11:21 PM, Alexander Graf wrote: On 02.06.14 09:49, Eric Auger wrote: From: Kim Phillips Functions for which PCI and platform device support share are moved into common.c. The common vfio_{get,put}_group() get an additional argument, a point

Re: [Qemu-devel] [PATCH v9 02/22] virtio-serial: don't migrate the config space

OBOn (Tue) 24 Jun 2014 [19:13:50], Greg Kurz wrote: > From: Alexander Graf > > The device configuration is set at realize time and never changes. It > should not be migrated as it is done today. For the sake of compatibility, > let's just skip them at load time. > > Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH] configure: explicitly state version requirements to devel packages

Signed-off-by: Hu Tao --- configure | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 7102964..adff12e 100755 --- a/configure +++ b/configure @@ -3066,7 +3066,8 @@ if test "$glusterfs" != "no" ; then fi else if test "$gluster

[Qemu-devel] [PATCH 4/4] mips_malta: Catch kernels linked at wrong address

Add error reporting if the wrong type of kernel is provided for the current mode of acceleration. Currently a KVM kernel linked at 0x4000 can't be used with TCG, and a normal kernel linked at 0x8000 can't be used with KVM. Signed-off-by: James Hogan Cc: Aurelien Jarno Cc: Paolo Bonzini

Re: [Qemu-devel] [Bug 1334397] [NEW] cmos RTC alarms no longer wake system from suspend

Il 25/06/2014 20:39, John Stultz ha scritto: Public bug reported: Running QEMU emulator version 2.0.0 (Debian 2.0.0+dfsg-2ubuntu1.1), booting Linux kernels with qemu-system-x86_64 and qemu-system-i386, I no longer see the system resume from suspend when an RTC alarm is set. My simple test appli

Re: [Qemu-devel] vhost-user: broken mem regions

On Thu, Jun 26, 2014 at 12:37 AM, Damjan Marion (damarion) wrote: > > On 25 Jun 2014, at 20:18, Michael S. Tsirkin wrote: > >> On Wed, Jun 25, 2014 at 09:13:36PM +0300, Nikolay Nikolaev wrote: >>> On Wed, Jun 25, 2014 at 9:07 PM, Michael S. Tsirkin wrote: On Wed, Jun 25, 2014 at 07:56:46PM

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

Il 26/06/2014 11:18, Chen, Tiejun ha scritto: - offsets 0x..0x0fff map to configuration space of the host MCH Are you saying the config space in the video device? No, I am saying in a new BAR, or at some magic offset of an existing MMIO BAR. Paolo

[Qemu-devel] [PATCH 2/4] mips_malta: Change default KVM cpu to 24Kc (no FP)

Change the default Malta CPU model for when KVM is enabled to 24Kc which doesn't have floating point support compared to the 24Kf. The resulting incorrect Config CP0 register value doesn't get passed to KVM yet as KVM doesn't expose it, however we should ensure it is set correctly now to reduce th

Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them

Il 26/06/2014 09:32, Markus Armbruster ha scritto: > Reported-by: Markus Armbruster > Signed-off-by: Paolo Bonzini Reviewed-by: Markus Armbruster Would it make sense to add a "must not contain subregions" to memory_region_destroy()'s function comment? I don't know, in the end the assertion

[Qemu-devel] [PATCH 1/4] mips/kvm: Init EBase to correct KSEG0

The EBase CP0 register is initialised to 0x8000, however with KVM the guest's KSEG0 is at 0x4000. The incorrect value doesn't get passed to KVM yet as KVM doesn't implement the EBase register, however we should set it correctly now so as not to break migration/loadvm to a future version of

[Qemu-devel] [Bug 1334397] Re: cmos RTC alarms no longer wake system from suspend

** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1334397 Title: cmos RTC alarms no longer wake system from suspend Status in QEMU: Fix Commit

Re: [Qemu-devel] [PATCH 0/4] QEMU MIPS KVM improvements for v2.1

Il 26/06/2014 11:44, James Hogan ha scritto: This patchset has a few improvements & minor fixes for MIPS KVM support. Patches 1-2 are fixes for forward compatibility of savevm with MIPS KVM. Patch 3 just corrects comments and an error message. Patch 4 adds errors when the wrong type of kernel is

Re: [Qemu-devel] [RFC PATCH v5 00/13] Reverse execution.

Il 26/06/2014 10:17, Frederic Konrad ha scritto: Hi, You mean adding cexe as a suboption of icount? Is both option related? I mean reverse execution needs icount but I think it doesn't make sense to make it as icount suboption? I think it does. The implementation relies heavily on icount.

Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1

Am 25.06.2014 um 16:35 hat Kevin Wolf geschrieben: > This is the first part of an attempt for disentangling bdrv_open(). At the end > of this series, bdrv_open() code is somewhat easier to read, but the real > changes (including some bug fixes and changes of behaviour) haven't happened > yet. > >

Re: [Qemu-devel] [PATCH 5/5 v5] ppc: Add hw breakpoint watchpoint support

On 26.06.14 09:23, Bharat Bhushan wrote: This patch adds hardware breakpoint and hardware watchpoint support for ppc. If the debug interrupt is not handled then this is injected to guest. Signed-off-by: Bharat Bhushan --- v4->v5 - cleanup in kvmppc_hw_debug_points_init() - replaced assert

[Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

Old code was affected by memory gaps which resulted in buffer pointers pointing to address outside of the mapped regions. Signed-off-by: Damjan Marion --- docs/specs/vhost-user.txt | 7 --- exec.c| 7 +++ hw/virtio/vhost-user.c| 23 ++- inclu

Re: [Qemu-devel] [PATCH v11 1/3] sPAPR: Implement EEH RTAS calls

On 26.06.14 03:35, Gavin Shan wrote: The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls and adds callback sPAPRPHBClass::eeh_handler, which is going to be used this way: 1. RTAS calls are re

Re: [Qemu-devel] [PATCH v11 1/3] sPAPR: Implement EEH RTAS calls

On Thu, Jun 26, 2014 at 12:30:16PM +0200, Alexander Graf wrote: > >On 26.06.14 03:35, Gavin Shan wrote: >>The emulation for EEH RTAS requests from guest isn't covered >>by QEMU yet and the patch implements them. >> >>The patch defines constants used by EEH RTAS calls and adds >>callback sPAPRPHBCla

Re: [Qemu-devel] [PATCH v11 1/3] sPAPR: Implement EEH RTAS calls

On 26.06.14 12:43, Gavin Shan wrote: On Thu, Jun 26, 2014 at 12:30:16PM +0200, Alexander Graf wrote: On 26.06.14 03:35, Gavin Shan wrote: The emulation for EEH RTAS requests from guest isn't covered by QEMU yet and the patch implements them. The patch defines constants used by EEH RTAS calls

Re: [Qemu-devel] HQEMU :Violations of the GPLLicenses?

Hi, Am 25.06.2014 16:05, schrieb Lb peace: > Efficient and retargetable dynamic binary translation on multicores > Author:Ding-Yong Hong; Jan-Jan Wu; Pen-Chung Yew; Wei-Chung Hsu; > Chun-Chen Hsu; Pangfeng Liu; Chien-Min Wang; Yeh-Ching Chung > IEEE Transactions on Parallel and Distributed Systems

[Qemu-devel] [PATCH for-2.1 v2 0/2] help libvirt know what's up with qga

Version 2 of the series originally posted at , rebased to Wenchao Xia's qapi-event feature, and addressing Eric's review notes for v1. Changes are broken out per patch. The series builds at each patch. I repeated the tests described in the

[Qemu-devel] [PATCH for-2.1 v2 1/2] virtio-serial: report frontend connection state via monitor

Libvirt wants to know about the guest-side connection state of some virtio-serial ports (in particular the one(s) assigned to guest agent(s)). Report such states with a new monitor event. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376 Signed-off-by: Laszlo Ersek --- Notes: v2:

[Qemu-devel] [PATCH for-2.1 v2 2/2] char: report frontend open/closed state in 'query-chardev'

In addition to the on-line reporting added in the previous patch, allow libvirt to query frontend state independently of events. Libvirt's path to identify the guest agent channel it cares about differs between the event added in the previous patch and the QMP response field added here. The event

[Qemu-devel] [PATCH v5 04/10] block: Use bdrv_nb_sectors() in bdrv_aligned_preadv()

Instead of bdrv_getlength(). Eliminate variable len. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- block.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 51dc65e..a6b620d 100644 --- a/block.c +++ b/

[Qemu-devel] [PATCH v5 00/10] Clean up around bdrv_getlength()

Issues addressed in this series: * BlockDriver method bdrv_getlength() generally returns -errno, but some implementations return -1 instead. Fix them [PATCH 1]. * Frequent conversions between sectors and bytes complicate the code needlessly. Clean up some [PATCH 2-7]. * bdrv_getlength() al

[Qemu-devel] [PATCH v5 02/10] block: New bdrv_nb_sectors()

A call to retrieve the image size converts between bytes and sectors several times: * BlockDriver method bdrv_getlength() returns bytes. * refresh_total_sectors() converts to sectors, rounding up, and stores in total_sectors. * bdrv_getlength() converts total_sectors back to bytes (now rounded

[Qemu-devel] [PATCH v5 03/10] block: Use bdrv_nb_sectors() in bdrv_make_zero()

Instead of bdrv_getlength(). Variable target_size is initially in bytes, then changes meaning to sectors. Ugh. Replace by target_sectors. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- block.c | 12 +--- 1 file changed, 5 insertions(+), 7 dele

[Qemu-devel] [PATCH v5 05/10] block: Use bdrv_nb_sectors() in bdrv_co_get_block_status()

Instead of bdrv_getlength(). Replace variables length, length2 by total_sectors, nb_sectors2. Bonus: use total_sectors instead of the slightly unclean bs->total_sectors. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- block.c | 16 1 fil

[Qemu-devel] [PATCH v5 07/10] block: Use bdrv_nb_sectors() where sectors, not bytes are wanted

Instead of bdrv_getlength(). Aside: a few of these callers don't handle errors. I didn't investigate whether they should. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- block-migration.c | 9 - block.c | 3 +-- block/qcow2.c | 2 +

[Qemu-devel] [PATCH v5 08/10] block: Drop superfluous aligning of bdrv_getlength()'s value

It returns a multiple of the sector size. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz Reviewed-by: Benoit Canet --- block.c | 1 - block/qcow2.c | 1 - 2 files changed, 2 deletions(-) diff --git a/block.c b/block.c index a527740..36f3315 100644 --- a/block.c +++ b/block.c @@

Re: [Qemu-devel] [PATCH 0/3] virtio-blk: Suppress error action on r/w beyond end

Ping? Markus Armbruster writes: > When a device model's I/O operation fails, we execute the error > action. This lets layers above QEMU implement thin provisioning, or > attempt to correct errors before they reach the guest. But when the > I/O operation fails because its invalid, reporting the

[Qemu-devel] [PATCH v5 01/10] raw-posix: Fix raw_getlength() to always return -errno on error

We got a merry mix of -1 and -errno here. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- block/raw-posix.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index dacf4

[Qemu-devel] [PATCH v5 10/10] block: Avoid bdrv_get_geometry() where errors should be detected

bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Max Reitz Reviewed-by: Benoit Canet --- block.c | 11 --- block/qapi.c | 14 +--

Re: [Qemu-devel] [PATCH v2 3/7] target-arm: Add arm_ccnt_enabled function

On Thu, Jun 26, 2014 at 3:02 PM, Alistair Francis wrote: > Include a helper function to determine if the CCNT counter > is enabled as well as the constants used to mask the pmccfiltr_el0 > and c9_pmxevtyper registers. > > Signed-off-by: Alistair Francis > --- > > target-arm/helper.c | 40 +

[Qemu-devel] [PATCH v5 06/10] block: Use bdrv_nb_sectors() in img_convert()

Instead of bdrv_getlength(). Replace variable output_length by output_sectors. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Benoit Canet --- qemu-img.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index c98896b..c

Re: [Qemu-devel] [PATCH 0/4] QEMU MIPS KVM improvements for v2.1

On 26/06/14 11:12, Paolo Bonzini wrote: > Il 26/06/2014 11:44, James Hogan ha scritto: >> This patchset has a few improvements & minor fixes for MIPS KVM support. >> >> Patches 1-2 are fixes for forward compatibility of savevm with MIPS KVM. >> Patch 3 just corrects comments and an error message. >

[Qemu-devel] [PATCH v5 09/10] qemu-img: Make img_convert() get image size just once per image

Chiefly so I don't have to do the error checking in quadruplicate in the next commit. Moreover, replacing the frequently updated bs_sectors by an array assigned just once makes the code easier to understand. Signed-off-by: Markus Armbruster Reviewed-by: Max Reitz Reviewed-by: Benoit Canet ---

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: > Old code was affected by memory gaps which > resulted in buffer pointers pointing to > address outside of the mapped regions. > > Signed-off-by: Damjan Marion > --- changelog? does not look like all comments have been addressed.

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

Il 26/06/2014 13:26, Michael S. Tsirkin ha scritto: On Thu, Jun 26, 2014 at 12:03:58PM +0200, Paolo Bonzini wrote: Il 26/06/2014 11:18, Chen, Tiejun ha scritto: - offsets 0x..0x0fff map to configuration space of the host MCH Are you saying the config space in the video device? No, I

Re: [Qemu-devel] [PATCH for-2.1 v2 0/2] help libvirt know what's up with qga

On (Thu) 26 Jun 2014 [13:11:13], Laszlo Ersek wrote: > Version 2 of the series originally posted at > , rebased to > Wenchao Xia's qapi-event feature, and addressing Eric's review notes for > v1. Changes are broken out per patch. > > The se

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

On Thu, Jun 26, 2014 at 12:03:58PM +0200, Paolo Bonzini wrote: > Il 26/06/2014 11:18, Chen, Tiejun ha scritto: > > > >> > >>- offsets 0x..0x0fff map to configuration space of the host MCH > >> > > > >Are you saying the config space in the video device? > > No, I am saying in a new BAR, or at s

Re: [Qemu-devel] [v5][PATCH 0/5] xen: add Intel IGD passthrough support

On Thu, Jun 26, 2014 at 01:30:42PM +0200, Paolo Bonzini wrote: > Il 26/06/2014 13:26, Michael S. Tsirkin ha scritto: > >On Thu, Jun 26, 2014 at 12:03:58PM +0200, Paolo Bonzini wrote: > >>Il 26/06/2014 11:18, Chen, Tiejun ha scritto: > >>> > > - offsets 0x..0x0fff map to configuration s

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: >> Old code was affected by memory gaps which >> resulted in buffer pointers pointing to >> address outside of the mapped regions. >> >> Signed-off-by: Damjan Marion >> --- > >

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

On Thu, Jun 26, 2014 at 11:35:13AM +, Damjan Marion (damarion) wrote: > > On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: > > > On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: > >> Old code was affected by memory gaps which > >> resulted in buffer pointers pointing to > >>

Re: [Qemu-devel] [PATCH v2 5/7] target-arm: Remove old code and replace with new functions

On Thu, Jun 26, 2014 at 3:02 PM, Alistair Francis wrote: > Remove the old PMCCNTR code and replace it with calls to the new > pmccntr_sync() function and the CCNT_ENABLED macro arm_ccnt_enabled() function. > > Signed-off-by: Alistair Francis > --- > > target-arm/helper.c | 27 ---

Re: [Qemu-devel] [PATCH v1 7/7] target-arm: Call the pmccntr_sync function when swapping ELs

On Tue, Jun 24, 2014 at 11:12 AM, Alistair Francis wrote: > Call the new pmccntr_sync() function when there is a possibility > of swapping ELs (I.E. when there is an exception) > > Signed-off-by: Alistair Francis > --- > > target-arm/helper-a64.c |5 + > target-arm/helper.c |7 ++

[Qemu-devel] [PATCH v2 0/4] Fix pxa2xx/strongarm missing vmstate

This patchseries fixes some cases for pxa2xx and strongarm where we'd defined a vmstate struct but forgotten to actually register it (caught by new warnings in clang 3.4). As a prerequisite (suggested by Peter Crosthwaite) we clean up the handling of GPSR/GPCR reads (which are unpredictable) so we

[Qemu-devel] [PATCH v2 2/4] hw/arm/strongarm: Wire up missing GPIO and PPC vmstate

The VMStateDescription structs for the GPIO and PPC devices were accidentally never wired up. Add missing state fields and register them via dc->vmsd. Signed-off-by: Peter Maydell --- hw/arm/strongarm.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/strongarm.c b/hw/arm/strongarm

[Qemu-devel] [PATCH v2 3/4] hw/arm/pxa2xx_gpio: Fix handling of GPSR/GPCR reads

The PXA2xx GPIO GPSR and GPCR registers are write-only, with reads being undefined behaviour. Instead of having GPCR return 31337 and GPSR return the value last written, make both log the guest error and return 0. Signed-off-by: Peter Maydell --- hw/arm/pxa2xx_gpio.c | 14 ++ 1 file

Re: [Qemu-devel] [PATCH v1 7/7] target-arm: Call the pmccntr_sync function when swapping ELs

On Thu, Jun 26, 2014 at 9:40 PM, Peter Crosthwaite wrote: > On Tue, Jun 24, 2014 at 11:12 AM, Alistair Francis > wrote: >> Call the new pmccntr_sync() function when there is a possibility >> of swapping ELs (I.E. when there is an exception) >> >> Signed-off-by: Alistair Francis >> --- >> >> tar

[Qemu-devel] [PATCH] qemu-char: initialize chr_write_lock

chr_write_lock was introduced in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1 but was used uninitialized. It caused segmentation fault on windows hosts. Add missing lock initialization to qemu_chr_alloc. Cc: Paolo Bonzini Cc: Luiz Capitulino Cc: Fam Zheng Signed-off-by: Kirill Batuzov Sign

Re: [Qemu-devel] HQEMU :Violations of the GPLLicenses?

In fact I do ask them for anything(binaries /source codes/diff to QEMU) to verify their result,but I have got no any reply from their funny group.Maybe I should write comments to the journal (and) to request sth. for verifing.Or someone in their group can see this letter in maillist. Many papers s

Re: [Qemu-devel] [PATCH] qemu-char: initialize chr_write_lock

Il 26/06/2014 13:45, Kirill Batuzov ha scritto: chr_write_lock was introduced in commit 9005b2a7589540a3733b3abdcfbccfe7746cd1a1 but was used uninitialized. It caused segmentation fault on windows hosts. A similar patch is already on the list. Thanks anyway for your contribution! Paolo

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

On 26 Jun 2014, at 13:37, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 11:35:13AM +, Damjan Marion (damarion) wrote: >> >> On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: >> >>> On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: Old code was affected by memory

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

On 06/26/2014 12:13 AM, Hu Tao wrote: > We already have ROUND_UP but there are similar macros and ROUND_UP-like > lines all around, replace them with ROUND_UP and clean up similar macros. Not a review (yet), but a question - how did you find lines to convert? Is there a particular grep pattern you

Re: [Qemu-devel] [PATCH 0/5] Platform device support

On 20.06.14 08:43, Peter Crosthwaite wrote: On Wed, Jun 4, 2014 at 10:28 PM, Alexander Graf wrote: Platforms without ISA and/or PCI have had a seriously hard time in the dynamic device creation world of QEMU. Devices on these were modeled as SysBus devices which can only be instantiated in mac

Re: [Qemu-devel] [PATCH] qemu-char: fix warning 'res' may be used uninitialized

On 25 June 2014 20:10, Stefan Weil wrote: > Am 25.06.2014 13:51, schrieb Igor Mammedov: >> On Wed, 25 Jun 2014 11:08:29 +0200 >> Markus Armbruster wrote: >> >>> Igor Mammedov writes: >>> Signed-off-by: Igor Mammedov >>> >>> Broken in commit 9005b2a (author cc'ed). Bites only when passed z

Re: [Qemu-devel] [PATCH for-2.1 v2 2/2] char: report frontend open/closed state in 'query-chardev'

On 06/26/2014 05:11 AM, Laszlo Ersek wrote: > In addition to the on-line reporting added in the previous patch, allow > libvirt to query frontend state independently of events. > > Libvirt's path to identify the guest agent channel it cares about differs > between the event added in the previous p

[Qemu-devel] [PATCH v2 1/4] hw/arm/strongarm: Fix handling of GPSR/GPCR reads

The StrongARM GPIO GPSR and GPCR registers are write-only, with reads being undefined behaviour. Instead of having GPCR return 31337 and GPSR return the value last written, make both log the guest error and return 0. Signed-off-by: Peter Maydell --- hw/arm/strongarm.c | 14 ++ 1 file

[Qemu-devel] [PATCH v2 4/4] hw/arm/pxa2xx_gpio: Correct and register vmstate

The pxa2xx-gpio device has a VMStateDescription, but it was accidentally never actually registered, and it wasn't quite correct. Remove the 'lines' field (this is a device property, not mutable state), add the missing 'prev_level' field, and set dc->vmsd so it actually gets used. Signed-off-by: Pe

Re: [Qemu-devel] [PATCH for-2.1 v2 1/2] virtio-serial: report frontend connection state via monitor

On 06/26/2014 05:11 AM, Laszlo Ersek wrote: > Libvirt wants to know about the guest-side connection state of some > virtio-serial ports (in particular the one(s) assigned to guest agent(s)). > Report such states with a new monitor event. > > RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=108037

  1   2   3   >