Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-23 Thread Fam Zheng
On Mon, 06/23 07:17, Benoît Canet wrote: > The Monday 23 Jun 2014 à 12:32:30 (+0800), Fam Zheng wrote : > > On Sat, 06/21 17:40, Benoît Canet wrote: > > > The Saturday 21 Jun 2014 à 17:39:11 (+0200), Benoît Canet wrote : > > > > We still have the issue of unlocking the bottom BDS when a subtree is

Re: [Qemu-devel] [PULL v2 059/106] libqemustub: add stubs to be able to use qemu-char.c

2014-06-23 Thread Michael S. Tsirkin
On Mon, Jun 23, 2014 at 09:15:34AM +0300, Riku Voipio wrote: > Hi, > > On Wed, Jun 18, 2014 at 07:19:17PM +0300, Michael S. Tsirkin wrote: > > From: Nikolay Nikolaev > > > > chardev depends on lots of external symbols that are not necessarily > > needed to be able to use, for example, 'socket ch

[Qemu-devel] [PATCH] console: move chardev declarations to sysemu/char.h

2014-06-23 Thread Michael S. Tsirkin
move generic chardev APIs to sysemu/char.h, to make them available to callers which can not depend on the whole of ui/console.h. This fixes a build error on systems without pixman-devel: ./configure --disable-tools --disable-docs --target-list=arm-linux-user ... pixmannone ... make ...

Re: [Qemu-devel] extremely low IOPS performance of QCOW2 image format on an SSD RAID1

2014-06-23 Thread Stefan Hajnoczi
On Mon, Jun 23, 2014 at 11:14:25AM +0800, lihuiba wrote: > >Did you prefill the image? Amplification could come from cluster allocation. > Yes! > I forgot to mention that I created the qcow2 image with > 'preallocation=metadata', and I have allocated > the data blocks with dd in VM. > > > Creat

Re: [Qemu-devel] [PATCH trivial] block.c: Correct the return value and the failure object when failure occurs

2014-06-23 Thread Stefan Hajnoczi
On Sat, Jun 21, 2014 at 10:59:29PM +0800, Chen Gang wrote: > When failure occurs, 'ret' need be set, or may return 0 to indicate success. > And error_propagate() also need be called only one time within a function. > > Signed-off-by: Chen Gang > --- > block.c | 2 +- > 1 file changed, 1 insertio

Re: [Qemu-devel] [Bug 1332297] Re: qemu-img: crash on check of an image with large value in the 'size' header field

2014-06-23 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 07:19:55PM -, Maria Kustova wrote: > The bug description missed qemu-img error: > > (process:12283): GLib-ERROR **: gmem.c:110: failed to allocate > 18446744059294601304 bytes Thanks, there has been recent work by Kevin Wolf to handle memory allocation failures gracefu

Re: [Qemu-devel] [PATCH 0/2] ivshmem: update documentation, add client/server tools

2014-06-23 Thread Claudio Fontana
Hello David, On 20.06.2014 14:15, David Marchand wrote: > Hello, > > (as suggested by Paolo, ccing Claudio and kvm mailing list) > > Here is a patchset containing an update on ivshmem specs documentation and > importing ivshmem server and client tools. > These tools have been written from scrat

Re: [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries

2014-06-23 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 06:40:11PM +0200, Peter Lieven wrote: > during rebasing the changed init value for the > retry counter was missed. This resulted in no retries > being performed at all. > > Signed-off-by: Peter Lieven > --- > block/iscsi.c |1 - > 1 file changed, 1 deletion(-) Thanks

Re: [Qemu-devel] [PATCH] block/iscsi: drop obsolete pointers from iscsi_co_writev

2014-06-23 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 06:40:22PM +0200, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/iscsi.c |9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan pgptADHEDIDsU.pgp Descr

Re: [Qemu-devel] [PATCH] block/iscsi: fix init value for iTask->retries

2014-06-23 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 06:40:11PM +0200, Peter Lieven wrote: > during rebasing the changed init value for the > retry counter was missed. This resulted in no retries > being performed at all. > > Signed-off-by: Peter Lieven > --- > block/iscsi.c |1 - > 1 file changed, 1 deletion(-) Neverm

Re: [Qemu-devel] [PATCH] block/iscsi: drop obsolete pointers from iscsi_co_writev

2014-06-23 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 06:40:22PM +0200, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/iscsi.c |9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) Nevermind, Paolo already applied this via the SCSI tree. pgplnuEkJCpo2.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-23 Thread Chrysostomos Nanakos
On 06/20/2014 05:33 PM, Stefan Hajnoczi wrote: On Thu, Jun 19, 2014 at 05:48:46PM +0300, Chrysostomos Nanakos wrote: +typedef struct BDRVArchipelagoState { +int fds[2]; +int qemu_aio_count; This field is never used. It's increment and decremented but nothing ever checks the value. It

Re: [Qemu-devel] extremely low IOPS performance of QCOW2 image format on an SSD RAID1

2014-06-23 Thread Stefan Hajnoczi
On Mon, Jun 23, 2014 at 02:20:25PM +0800, lihuiba wrote: > I think I have found the reason: > There's a cache in qemu that accelerates the transform of virtual LBA to > cluster offset of qcow2 image. > The cache has a fixed size of 16x8192=128k in my configuration, which > corresponds to a 8GB (1

Re: [Qemu-devel] [PATCH v4 1/3] block: Support Archipelago as a QEMU block backend

2014-06-23 Thread Stefan Hajnoczi
On Mon, Jun 23, 2014 at 11:17:16AM +0300, Chrysostomos Nanakos wrote: > On 06/20/2014 05:33 PM, Stefan Hajnoczi wrote: > >On Thu, Jun 19, 2014 at 05:48:46PM +0300, Chrysostomos Nanakos wrote: > > > >>+if (!segreq->failed) { > >>+reqdata->aio_cb->r

Re: [Qemu-devel] [PATCH 0/2] block: Fix unset "filename" for certain drivers

2014-06-23 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 12:14:08AM +0200, Max Reitz wrote: > For some protocol block drivers, the "filename" attribute in their BDSs > is unset due to bdrv_file_open() removing it from the options QDict > before bdrv_open_common() is able to copy it into the BDS. Fix this by > not removing it until

Re: [Qemu-devel] [PATCH 3/3] virtio-blk: Treat read/write beyond end as invalid

2014-06-23 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jun 05, 2014 at 02:15:36PM +0200, Markus Armbruster wrote: >> +if (sector > total_sectors || nb_sectors > total_sectors - sector) { >> +return false; >> +} > > if (sector >= total_sectors || ...) { I suspect reading bdrv_check_byte_request() put

[Qemu-devel] [PATCH] virtio-pci: Report an error when msix vectors init fails

2014-06-23 Thread Fam Zheng
Currently vectors silently cleared to 0 if the initialization is failed, but user should at least have one way to notice this. Signed-off-by: Fam Zheng --- hw/virtio/virtio-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index ce97514..

Re: [Qemu-devel] [PATCH] console: move chardev declarations to sysemu/char.h

2014-06-23 Thread Riku Voipio
On Mon, Jun 23, 2014 at 10:29:07AM +0300, Michael S. Tsirkin wrote: > move generic chardev APIs to sysemu/char.h, to make them available to > callers which can not depend on the whole of ui/console.h. > This fixes a build error on systems without pixman-devel: > > ./configure --disable-tools --dis

[Qemu-devel] [PATCH] spapr: Fix RTAS token numbers

2014-06-23 Thread Alexey Kardashevskiy
At the moment spapr_rtas_register() allocates a new token number for every new RTAS callback so numbers are not fixed and depend on the number of supported RTAS handlers and the exact order of spapr_rtas_register() calls. These tokens are copied into the device tree and remain the same during the g

[Qemu-devel] [PULL 0/6] Block patches

2014-06-23 Thread Stefan Hajnoczi
The following changes since commit 427e1750a0b98a72cad424327604f51e993dcc5f: gt64xxx_pci: Add VMStateDescription (2014-06-20 23:40:16 +0200) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 2bd3bce8efebe86b031b

[Qemu-devel] [PULL 1/6] block: m25p80: sync_page(): Deindent function body.

2014-06-23 Thread Stefan Hajnoczi
From: Peter Crosthwaite sync_page() was conditionalizing it's whole fn body on the bdrv being non-null. Just return for the function immediately on NULL brdv and get rid of the big if. Makes implementation consistent with flash_zynq_area(). Signed-off-by: Peter Crosthwaite Signed-off-by: Stefa

[Qemu-devel] [PULL 3/6] QemuOpts: check NULL opts in qemu_opt_get functions

2014-06-23 Thread Stefan Hajnoczi
From: Chunyan Liu Some places will call bdrv_create_file(filename, NULL, &local_err), where opts is NULL. Check NULL in qemu_opt_get and qemu_opt_get_*_del functions, to avoid extra effort of checking opts before calling them every time. Signed-off-by: Chunyan Liu Reviewed-by: Eric Blake Signe

[Qemu-devel] [PULL 2/6] block: m25p80: Support read only bdrvs.

2014-06-23 Thread Stefan Hajnoczi
From: Peter Crosthwaite By just never doing write-backs. This is completely invisible to the guest, as the entire storage area is implemented as device state (at realize time the entire drive is read in). Signed-off-by: Peter Crosthwaite Signed-off-by: Stefan Hajnoczi --- hw/block/m25p80.c |

[Qemu-devel] [PATCH 1/4] ui/cocoa: Cope with first surface being same as initial window size

2014-06-23 Thread Peter Maydell
Do the recalculation of the content dimensions in switchSurface if the current cdx is zero as well as if the new surface is a different size to the current window. This catches the case where the first surface registered happens to be 640x480 (our current window size), and fixes a bug where we woul

[Qemu-devel] [PATCH 3/4] ui/cocoa: Fix handling of absolute positioning devices

2014-06-23 Thread Peter Maydell
Fix handling of absolute positioning devices, which were basically unusable for two separate reasons: (1) as soon as you pressed the left mouse button we would call CGAssociateMouseAndMouseCursorPosition(FALSE), which means that the absolute coordinates of the mouse events are never upda

[Qemu-devel] [PATCH 0/4] ui/cocoa: Fix absolute positioning and other bugs

2014-06-23 Thread Peter Maydell
This set of cocoa UI patches: * fixes the completely broken handling of absolute positioning (tablet-style) input devices * fixes a bug where if the first surface created was the same 640x480 as the initial window we'd never actually draw it * implements support for the -show-cursor comman

[Qemu-devel] [PATCH 2/4] ui/cocoa: Add utility method to check if point is within window

2014-06-23 Thread Peter Maydell
Add a utility method to check whether a point is within the current window bounds, and use it in the various places in the mouse handling code that were opencoding the check. Signed-off-by: Peter Maydell --- ui/cocoa.m | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/

[Qemu-devel] [PATCH 4/4] ui/cocoa: Honour -show-cursor command line option

2014-06-23 Thread Peter Maydell
Honour the -show-cursor command line option (which forces the mouse pointer to always be displayed even when input is grabbed) in the Cocoa UI backend. Signed-off-by: Peter Maydell --- ui/cocoa.m | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m

[Qemu-devel] [PULL 5/6] vl: allow other threads to do qemu_system_vmstop_request

2014-06-23 Thread Stefan Hajnoczi
From: Paolo Bonzini There patch protects vmstop_requested with a lock and introduces qemu_system_vmstop_request_prepare. Together with the new call to qemu_vmstop_requested in vm_start, qemu_system_vmstop_request_prepare avoids a race where the VM could remain stopped even though the iostatus of

Re: [Qemu-devel] [PATCH v3] qmp: add ACPI_DEVICE_OST event handling

2014-06-23 Thread Markus Armbruster
Wenchao Xia writes: > 于 2014/6/20 23:46, Eric Blake 写道: >> On 06/20/2014 02:33 AM, Igor Mammedov wrote: >>> emits event when ACPI OSPM evaluates _OST method >>> of ACPI device. >>> >>> Signed-off-by: Igor Mammedov >>> --- >>> v2: >>> - use new QAPI event infrastructure >>>from rebased

[Qemu-devel] [PULL 4/6] sheepdog: fix NULL dereference in sd_create

2014-06-23 Thread Stefan Hajnoczi
From: Liu Yuan Following command qemu-img create -f qcow2 sheepdog:test 20g will cause core dump because aio_context is NULL in sd_create. We should initialize it by qemu_get_aio_context() to avoid NULL dereference. Cc: qemu-devel@nongnu.org Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by:

[Qemu-devel] [PULL 6/6] block: asynchronously stop the VM on I/O errors

2014-06-23 Thread Stefan Hajnoczi
From: Paolo Bonzini With virtio-blk dataplane, I/O errors might occur while QEMU is not in the main I/O thread. However, it's invalid to call vm_stop when we're neither in a VCPU thread nor in the main I/O thread, even if we were to take the iothread mutex around it. To avoid this problem, we c

Re: [Qemu-devel] [PATCH for-2.2 v3 0/3] nbd: Adapt for dataplane

2014-06-23 Thread Stefan Hajnoczi
On Fri, Jun 20, 2014 at 09:57:31PM +0200, Max Reitz wrote: > For the NBD server to work with dataplane, it needs to correctly access > the exported BDS. It makes the most sense to run both in the same > AioContext, therefore this series implements methods for tracking a > BDS's AioContext and makes

Re: [Qemu-devel] [Xen-devel] [RFC PATCH V3 2/2] qemu: support xen hvm direct kernel boot

2014-06-23 Thread Stefano Stabellini
On Sun, 22 Jun 2014, Chun Yan Liu wrote: > >>> On 6/20/2014 at 08:08 PM, in message > , Stefano > Stabellini wrote: > > On Fri, 20 Jun 2014, Chunyan Liu wrote: > > > qemu side patch to support xen HVM direct kernel boot: > > > if -kernel exists, calls xen_load_linux(), which will read kernel/in

Re: [Qemu-devel] [PATCH v6 for 2.1 02/10] block: add helper function to determine if a BDS is in a chain

2014-06-23 Thread Benoît Canet
The Tuesday 17 Jun 2014 à 17:53:50 (-0400), Jeff Cody wrote : > This is a small helper function, to determine if 'base' is in the > chain of BlockDriverState 'top'. It returns true if it is in the chain, > and false otherwise. > > If either argument is NULL, it will also return false. > > Review

[Qemu-devel] [PATCH] ccid-card-emulated: use EventNotifier

2014-06-23 Thread Paolo Bonzini
Shut up Coverity's complaint about unchecked fcntl return values, and especially make the code simpler and more efficient. Signed-off-by: Paolo Bonzini --- hw/usb/ccid-card-emulated.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/hw/usb/ccid-

Re: [Qemu-devel] [PATCH] console: move chardev declarations to sysemu/char.h

2014-06-23 Thread Peter Maydell
On 23 June 2014 10:07, Riku Voipio wrote: > On Mon, Jun 23, 2014 at 10:29:07AM +0300, Michael S. Tsirkin wrote: >> move generic chardev APIs to sysemu/char.h, to make them available to >> callers which can not depend on the whole of ui/console.h. >> This fixes a build error on systems without pixm

Re: [Qemu-devel] [PATCH] ccid-card-emulated: use EventNotifier

2014-06-23 Thread Alon Levy
> Shut up Coverity's complaint about unchecked fcntl return values, > and especially make the code simpler and more efficient. > > Signed-off-by: Paolo Bonzini Reviewed-by: Alon Levy one question below. > --- > hw/usb/ccid-card-emulated.c | 29 ++--- > 1 file changed,

Re: [Qemu-devel] [PATCH 3/4] pc-bios/s390-ccw: fix for fragmented SCSI bootmap

2014-06-23 Thread Cornelia Huck
On Wed, 18 Jun 2014 16:53:15 +0400 "Eugene \"jno\" Dvurechenski" wrote: > > > On 06/18/2014 04:16 PM, Jens Freimann wrote: > > +static inline bool unused_space(const void *p, unsigned int size) > > +{ > > +int i; > > s390-ccw.h has a def for size_t (well, it's just "long"). > So, we can us

Re: [Qemu-devel] [PATCH 0/4] s390-ccw.img: s390-ccw.img fixes

2014-06-23 Thread Cornelia Huck
On Wed, 18 Jun 2014 14:16:43 +0200 Jens Freimann wrote: > Conny, Christian, Alex, > > here's three bios bugfixes and an update for the binary. > Patch 1 lets us boot with big inital ramdisks, Patch 2 introduces > a subsystem reset to make sure start with a clean state. Patch 3 > fixes parsing of

[Qemu-devel] [PATCH V3] qemu-img create: add 'nocow' option

2014-06-23 Thread Chunyan Liu
Add 'nocow' option so that users could have a chance to set NOCOW flag to newly created files. It's useful on btrfs file system to enhance performance. Btrfs has low performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate th

Re: [Qemu-devel] [PATCH] ccid-card-emulated: use EventNotifier

2014-06-23 Thread Paolo Bonzini
Il 23/06/2014 12:38, Alon Levy ha scritto: > { > -EmulatedState *card = opaque; > +EmulatedState *card = container_of(notifier, EmulatedState, notifier); > EmulEvent *event, *next; > -char dummy; > -int len; > > -do { > -len = read(card->pipe[0], &dummy, sizeof(d

[Qemu-devel] [PATCH v2 3/3] hw/pcie: better hotplug/hotunplug support

2014-06-23 Thread Marcel Apfelbaum
The current code is broken: it does surprise removal which crashes guests. Reimplemented the steps: - Hotplug triggers both 'present detect change' and 'attention button pressed'. - Hotunplug starts by triggering 'attention button pressed', then waits for the OS to power off the device an

[Qemu-devel] [PATCH v2 0/3] hw/pcie: better hotplug/hotunplug support

2014-06-23 Thread Marcel Apfelbaum
v1 -> v2: - Addressed Michael S. Tsirkin's comments: - patch 2/3: - Added "power controller present" to compat_props. - patch 3/3: - Unplug all bus functions on hot-unplug, not only function 0. - Minor code refactoring The current code is broken: it does surprise removal which

[Qemu-devel] [PATCH v2 1/3] hw/pcie: corrected a debug message

2014-06-23 Thread Marcel Apfelbaum
Trivial issue, discovered while debugging. Signed-off-by: Marcel Apfelbaum --- hw/pci/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c index 02cde6f..ae92f00 100644 --- a/hw/pci/pcie.c +++ b/hw/pci/pcie.c @@ -224,7 +224,7 @@ static void pci

[Qemu-devel] [PATCH v2 2/3] hw/pcie: implement power controller functionality

2014-06-23 Thread Marcel Apfelbaum
It is needed by hot-unplug in order to get an indication from the OS when the device can be physically detached. Signed-off-by: Marcel Apfelbaum --- hw/pci-bridge/ioh3420.c| 7 +++ hw/pci-bridge/xio3130_downstream.c | 7 +++ hw/pci/pcie.c | 33 +

Re: [Qemu-devel] [PULL for-2.1] Update OpenBIOS images to r1306

2014-06-23 Thread Peter Maydell
On 21 June 2014 08:00, Mark Cave-Ayland wrote: > Hi Peter, > > The following commit updates the OpenBIOS images to SVN r1306. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 427e1750a0b98a72cad424327604f51e993dcc5f: > > gt64xxx_pci: Add VMStateDescription (2014-06-20 2

Re: [Qemu-devel] [PATCH v2 1/3] hw/pcie: corrected a debug message

2014-06-23 Thread Michael S. Tsirkin
On Mon, Jun 23, 2014 at 02:15:24PM +0300, Marcel Apfelbaum wrote: > Trivial issue, discovered while debugging. > > Signed-off-by: Marcel Apfelbaum Can you rebase on pci branch pls? > --- > hw/pci/pcie.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/pci/pcie.c b/h

[Qemu-devel] [Bug 1333216] [NEW] Xen 4.4 with qemu 1.6.2 VGA passthru NVIDIA

2014-06-23 Thread Maxim Gordeev
Public bug reported: Hi! Please, give me an advice. I try use VGA passthough NVidia k40 on SuperMicro Server, but server is having error. My Xen is using qemu (a9e8aeb3755bccb7b51174adcf4a3fc427e0d147)2.0.0 My VirtualMachine is have config: device_model_version = "qemu-xen" device_model_overri

Re: [Qemu-devel] [PATCH v2 1/3] hw/pcie: corrected a debug message

2014-06-23 Thread Marcel Apfelbaum
On Mon, 2014-06-23 at 14:41 +0300, Michael S. Tsirkin wrote: > On Mon, Jun 23, 2014 at 02:15:24PM +0300, Marcel Apfelbaum wrote: > > Trivial issue, discovered while debugging. > > > > Signed-off-by: Marcel Apfelbaum > > Can you rebase on pci branch pls? Sure, Marcel > > > --- > > hw/pci/pcie.

Re: [Qemu-devel] [PATCH v9] net: L2TPv3 transport

2014-06-23 Thread Stefan Hajnoczi
On Fri, Jun 20, 2014 at 10:34:41AM +0100, anton.iva...@kot-begemot.co.uk wrote: > From: Anton Ivanov > > This transport allows to connect a QEMU nic to a static Ethernet > over L2TPv3 tunnel. The transport supports all options present > in the Linux kernel implementation. It allows QEMU to connec

Re: [Qemu-devel] [Qemu-trivial] [PATCH] x86: correctly implement soft reset

2014-06-23 Thread Paolo Bonzini
Il 21/06/2014 17:12, Michael Tokarev ha scritto: >> Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. >> These only reset the CPU. > > I'm not sure how this is -trivial material? :) Ping? This patch hasn't been applied so far, do you want to actually push it? No, I

[Qemu-devel] [PATCH v4 1/4] tests: add OHCI qtest

2014-06-23 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- MAINTAINERS | 2 +- tests/Makefile| 3 +++ tests/usb-hcd-ohci-test.c | 35 +++ 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 tests/usb-hcd-ohci-test.c diff --git a/MAINTA

[Qemu-devel] [PATCH v4 3/4] tests: add xHCI qtest

2014-06-23 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- tests/Makefile| 3 +++ tests/usb-hcd-xhci-test.c | 35 +++ 2 files changed, 38 insertions(+) create mode 100644 tests/usb-hcd-xhci-test.c diff --git a/tests/Makefile b/tests/Makefile index ac16ae5..6a78ade 1

[Qemu-devel] [PATCH v4 0/4] tests: add usb host adapter qtest cases

2014-06-23 Thread arei.gonglei
From: Gonglei This patch series base on my request usb host adapter hotplug/unplug series: [PATCH v3 00/10] usb: usb host adapter hotplug http://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00746.html Changes since v3: - rebase on latest qemu master Changes since v2: - add 'const' quali

[Qemu-devel] [PATCH v4 2/4] tests: add UHCI qtest

2014-06-23 Thread arei.gonglei
From: Gonglei Signed-off-by: Gonglei --- tests/Makefile| 4 +++- tests/usb-hcd-uhci-test.c | 35 +++ 2 files changed, 38 insertions(+), 1 deletion(-) create mode 100644 tests/usb-hcd-uhci-test.c diff --git a/tests/Makefile b/tests/Makefile index 76

[Qemu-devel] [PATCH v4 4/4] tests: add usb hcds hotplugging qtest

2014-06-23 Thread arei.gonglei
From: Gonglei Because of we now support usb hcds hotplugging, and collect all hcds hotplugging tests into one file for code sharing. Signed-off-by: Gonglei --- tests/Makefile | 2 + tests/usb-hcd-hotplug-test.c | 88 2 files changed,

Re: [Qemu-devel] [PULL for-2.1] qemu-sparc update

2014-06-23 Thread Peter Maydell
On 21 June 2014 08:02, Mark Cave-Ayland wrote: > Hi Peter, > > This update contains Stefan's fix for an out-of-bounds array access on apb. > Please pull. > > > ATB, > > Mark. > > > The following changes since commit 427e1750a0b98a72cad424327604f51e993dcc5f: > > gt64xxx_pci: Add VMStateDescriptio

Re: [Qemu-devel] [PATCH v9] net: L2TPv3 transport

2014-06-23 Thread Anton Ivanov (antivano)
On 23/06/14 12:50, Stefan Hajnoczi wrote: > On Fri, Jun 20, 2014 at 10:34:41AM +0100, anton.iva...@kot-begemot.co.uk > wrote: >> From: Anton Ivanov >> >> This transport allows to connect a QEMU nic to a static Ethernet >> over L2TPv3 tunnel. The transport supports all options present >> in the Li

Re: [Qemu-devel] [PATCH] q35: Use PC_Q35_COMPAT_1_4 on pc-q35-1.4 compat_props

2014-06-23 Thread Markus Armbruster
Eduardo Habkost writes: > pc-q35-1.4 was incorrectly using PC_COMPAT_1_4 instead of > PC_Q35_COMPAT_1_4. > > The only side-effect was that the hpet compat property (inherited from > PC_Q35_COMPAT_1_7) was missing. > > Without this patch, pc-q35-1.4 inicorrectly initializes hpet-intcap to incorre

[Qemu-devel] [PATCH v1] trace: add qemu_system_powerdown_request and qemu_system_shutdown_request trace events

2014-06-23 Thread Yang Zhiyong
We have the experience that the guest doesn't stop successfully though it was instructed to shut down. The root cause may be not in QEMU mostly. However, QEMU is often suspected at the beginning just because the issue occurred in virtualization environment. Therefore, we need to affirm that QEM

Re: [Qemu-devel] [PULL 0/6] Block patches

2014-06-23 Thread Peter Maydell
On 23 June 2014 10:31, Stefan Hajnoczi wrote: > The following changes since commit 427e1750a0b98a72cad424327604f51e993dcc5f: > > gt64xxx_pci: Add VMStateDescription (2014-06-20 23:40:16 +0200) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/block-pull-re

Re: [Qemu-devel] [RFC 2/3] image-fuzzer: Initial generator of qcow2 fuzzed images

2014-06-23 Thread Markus Armbruster
Eric Blake writes: > On 06/18/2014 09:29 AM, Maria Kustova wrote: >> Qcow2 image generator is a python package providing create_image(img_path) >> method required by the test runner. >> It generates files containing fuzzed qcow2 image headers. Files are randomly >> variable not only in fuzzed fie

[Qemu-devel] [PULL 1/4] pc-bios/s390-ccw: virtio_load_direct() can't load max number of sectors

2014-06-23 Thread Cornelia Huck
From: David Hildenbrand The number of sectors to read is given by the last 16 bit of rec_list2. 1 is added in order to get to the real number of sectors to read (0x -> read 1 block). For now, the maximum number (0x) led to 0 sectors being read. This fixes a bug where a large initrd (62MB

[Qemu-devel] [PULL 0/4] s390-ccw bios fixes

2014-06-23 Thread Cornelia Huck
:39 +0100) are available in the git repository at: git://github.com/cohuck/qemu.git tags/s390x-20140623-2 for you to fetch changes up to 4ff51e66374706d22c7e37b094a3b7a464b8ac91: pc-bios/s390-ccw: update s390-ccw.img binary (2014-06-23

[Qemu-devel] [PULL 4/4] pc-bios/s390-ccw: update s390-ccw.img binary

2014-06-23 Thread Cornelia Huck
From: Jens Freimann Update s390-ccw.img to match with latest fixes Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- pc-bios/s390-ccw.img | Bin 9336 -> 9432 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index f62

[Qemu-devel] [PULL 3/4] pc-bios/s390-ccw: fix for fragmented SCSI bootmap

2014-06-23 Thread Cornelia Huck
From: "Eugene (jno) Dvurechenski" We need to interpret the last entry of the bootmap with zero block count as "continuation pointer". The "last entry" is being detected by pre-filling of the scratch space with known values and respective look-ahead. Signed-off-by: Eugene (jno) Dvurechenski Sign

[Qemu-devel] [PULL 2/4] pc-bios/s390-ccw: do a subsystem reset before running the guest

2014-06-23 Thread Cornelia Huck
From: Christian Borntraeger The loader BIOS has already activated several devices. Let's do a subsystem reset before jumping into the guest. As there is no direct way of doing so, we use diagnose 308 to bring the system in a defined state. This is similar to what kdump on s390 uses. We have to de

[Qemu-devel] [PATCH v5 2/4] block/archipelago: Add support for creating images

2014-06-23 Thread Chrysostomos Nanakos
qemu-img archipelago:[/mport=[:vport=] [:segment=]] [size] Signed-off-by: Chrysostomos Nanakos --- block/archipelago.c | 146 +++ 1 file changed, 146 insertions(+) diff --git a/block/archipelago.c b/block/archipelago.c index c0810ef..d382667 1006

[Qemu-devel] [PATCH v5 1/4] block: Support Archipelago as a QEMU block backend

2014-06-23 Thread Chrysostomos Nanakos
VM Image on Archipelago volume is specified like this: file=archipelago:[/mport=[:vport=][: segment=]] or file.driver=archipelago,file.volume=[,file.mport=[, file.vport=][,file.segment=]] 'archipelago' is the protocol. 'mport' is the port number on which mapperd is listening. This is optional

[Qemu-devel] [PATCH v5 0/4] Support Archipelago as a QEMU block backend

2014-06-23 Thread Chrysostomos Nanakos
v5: - Remove useless qemu_aio_count variable from BDRVArchipelagoState struct. - Cleanup xseg signal descriptor, call xseg_quit_local_signal() when closing block device. - Fix ds and volname leaks. - Make xseg request handler thread joinable and wait until exits before destroying conditio

[Qemu-devel] [PATCH v5 4/4] qemu-iotests: add support for Archipelago protocol

2014-06-23 Thread Chrysostomos Nanakos
Signed-off-by: Chrysostomos Nanakos --- tests/qemu-iotests/common|6 ++ tests/qemu-iotests/common.rc |8 +++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 0aaf84d..a0e35c4 100644 --- a/tests/qemu-iot

[Qemu-devel] [PATCH v5 3/4] QMP: Add support for Archipelago

2014-06-23 Thread Chrysostomos Nanakos
Introduce new enum BlockdevOptionsArchipelago. @volume: #Name of the Archipelago volume image @mport: #'mport' is the port number on which mapperd is listening. This is optional and if not specified, QEMU will make Archipelago

Re: [Qemu-devel] [PATCH v6 for 2.1 01/10] block: Auto-generate node_names for each BDS entry

2014-06-23 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 08:30:19AM -0400, Jeff Cody wrote: > On Thu, Jun 19, 2014 at 04:55:02PM +0800, Stefan Hajnoczi wrote: > > On Tue, Jun 17, 2014 at 05:53:49PM -0400, Jeff Cody wrote: > > It seems like neither type of user will get much mileage out of this > > feature. Is it really necessary

[Qemu-devel] [PATCH v6 4/4] qemu-iotests: add support for Archipelago protocol

2014-06-23 Thread Chrysostomos Nanakos
Signed-off-by: Chrysostomos Nanakos --- tests/qemu-iotests/common|6 ++ tests/qemu-iotests/common.rc |9 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 0aaf84d..a0e35c4 100644 --- a/tests/qemu-io

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-23 Thread Markus Armbruster
Peter Maydell writes: > Convert the socket char backend to the new style QAPI framework; > this allows it to return an Error ** to callers who might not > want it to print directly about socket failures. > > Signed-off-by: Peter Maydell > --- > I'm not 100% sure I have this correct -- review fro

Re: [Qemu-devel] [PATCH] spapr: Fix RTAS token numbers

2014-06-23 Thread Alexander Graf
On 23.06.14 11:27, Alexey Kardashevskiy wrote: At the moment spapr_rtas_register() allocates a new token number for every new RTAS callback so numbers are not fixed and depend on the number of supported RTAS handlers and the exact order of spapr_rtas_register() calls. These tokens are copied int

Re: [Qemu-devel] [PATCH 3/3] virtio-blk: Treat read/write beyond end as invalid

2014-06-23 Thread Markus Armbruster
Markus Armbruster writes: > Stefan Hajnoczi writes: > >> On Thu, Jun 05, 2014 at 02:15:36PM +0200, Markus Armbruster wrote: >>> +if (sector > total_sectors || nb_sectors > total_sectors - sector) { >>> +return false; >>> +} >> >> if (sector >= total_sectors || ...) { > > I suspec

Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

2014-06-23 Thread Peter Maydell
On 23 June 2014 13:49, Markus Armbruster wrote: > Peter Maydell writes: > >> Convert the socket char backend to the new style QAPI framework; >> this allows it to return an Error ** to callers who might not >> want it to print directly about socket failures. >> >> Signed-off-by: Peter Maydell >>

Re: [Qemu-devel] [PATCH v6 for 2.1 00/10] Modify block jobs to use node-names

2014-06-23 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote: > On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote: > > On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote: > > Let's discuss this topic in a sub-thread and figure out what to do for > > QEMU 2.1. This is an important

[Qemu-devel] [PULL 02/19] Add support for the arm breakpoint syscall

2014-06-23 Thread riku . voipio
From: Hunter Laux OABI arm used a software interrupt(0xef9f0001) for breakpoints. Since 2005 gdb has used the break instruction(0xe7f001f0) for EABI. Apparently Steel Bank Common Lisp still uses the swi instruction. This is the kernel implementation: http://lxr.free-electrons.com/source/arch/arm

[Qemu-devel] [PULL 09/19] linux-user: support strace of epoll_create1

2014-06-23 Thread riku . voipio
From: Paul Burton Add the epoll_create1 syscall to strace.list in order to display that syscall when it occurs, rather than a message about the syscall being unknown despite QEMU already implementing support for it. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/strace.l

[Qemu-devel] [PULL 12/19] linux-user: allow NULL tv argument for settimeofday

2014-06-23 Thread riku . voipio
From: Paul Burton The tv argument to the settimeofday syscall is allowed to be NULL, if the program only wishes to provide the timezone. QEMU previously returned -EFAULT when tv was NULL. Instead, execute the syscall & provide NULL to the kernel as the target program expected. Signed-off-by: Pau

[Qemu-devel] [PULL 00/19] linux-user changes for 2.1

2014-06-23 Thread riku . voipio
From: Riku Voipio The following changes since commit d9c1647d896d3192cba9dbf98fb7efab876edde5: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2014-06-23 12:55:22 +0100) are available in the git repository at: git://git.linaro.org/people/riku.voipio/q

[Qemu-devel] [PULL 17/19] linux-user: support the unshare syscall

2014-06-23 Thread riku . voipio
From: Paul Burton Add support for the unshare syscall, trivially passed through to the host. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/syscall.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ecd5be9..769c

[Qemu-devel] [PULL 10/19] linux-user: fix struct target_epoll_event layout for MIPS

2014-06-23 Thread riku . voipio
From: Paul Burton MIPS requires the pad field to 64b-align the data field just as ARM does. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/syscall_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_de

[Qemu-devel] [PULL 13/19] linux-user: support timerfd_{create, gettime, settime} syscalls

2014-06-23 Thread riku . voipio
From: Paul Burton Adds support for the timerfd_create, timerfd_gettime & timerfd_settime syscalls, allowing use of timerfds by target programs. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/strace.list | 9 + linux-user/syscall.c | 45

[Qemu-devel] [PULL 06/19] linux-user: support SO_{SND, RCV}BUFFORCE setsockopt options

2014-06-23 Thread riku . voipio
From: Paul Burton Translate the SO_SNDBUFFORCE & SO_RCVBUFFORCE options to setsockopt to the host values & perform the syscall as expected, allowing use of those options by target programs. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/syscall.c | 6 ++ 1 file chang

[Qemu-devel] [PATCH v2] spapr: Fix RTAS token numbers

2014-06-23 Thread Alexey Kardashevskiy
At the moment spapr_rtas_register() allocates a new token number for every new RTAS callback so numbers are not fixed and depend on the number of supported RTAS handlers and the exact order of spapr_rtas_register() calls. These tokens are copied into the device tree and remain the same during the g

Re: [Qemu-devel] [PATCH v2] spapr: Fix RTAS token numbers

2014-06-23 Thread Alexander Graf
On 23.06.14 15:26, Alexey Kardashevskiy wrote: At the moment spapr_rtas_register() allocates a new token number for every new RTAS callback so numbers are not fixed and depend on the number of supported RTAS handlers and the exact order of spapr_rtas_register() calls. These tokens are copied int

[Qemu-devel] [PULL 18/19] linux-user: support the KDSIGACCEPT ioctl

2014-06-23 Thread riku . voipio
From: Paul Burton Add a definition of the KDSIGACCEPT ioctl & allow its use by target programs. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/ioctls.h | 1 + linux-user/syscall.c | 7 +++ linux-user/syscall_defs.h | 1 + 3 files changed, 9 insertions(+)

Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable

2014-06-23 Thread Kevin Wolf
Am 21.06.2014 um 15:00 hat Chen Gang geschrieben: > 'buf' is not used actually, so remove it and related snprintf() statement. > > > Signed-off-by: Chen Gang Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v2] spapr: Fix RTAS token numbers

2014-06-23 Thread Alexander Graf
On 23.06.14 15:26, Alexey Kardashevskiy wrote: At the moment spapr_rtas_register() allocates a new token number for every new RTAS callback so numbers are not fixed and depend on the number of supported RTAS handlers and the exact order of spapr_rtas_register() calls. These tokens are copied int

[Qemu-devel] [PULL 05/19] linux-user: support SO_ACCEPTCONN getsockopt option

2014-06-23 Thread riku . voipio
From: Paul Burton Translate the SO_ACCEPTCONN option to the host value & execute the syscall as expected. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8d1

[Qemu-devel] [PULL 08/19] linux-user: allow NULL arguments to mount

2014-06-23 Thread riku . voipio
From: Paul Burton Calls to the mount syscall can legitimately provide NULL as the value for the source of filesystemtype arguments, which QEMU would previously reject & return -EFAULT to the target program. An example of this is remounting an already mounted filesystem with different properties.

[Qemu-devel] [PULL 15/19] linux-user: support {name_to, open_by}_handle_at syscalls

2014-06-23 Thread riku . voipio
From: Paul Burton Implement support for the name_to_handle_at and open_by_handle_at syscalls, allowing their use by the target program. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/strace.c| 30 ++ linux-user/strace.list | 6 ++ linux-u

Re: [Qemu-devel] [PATCH v3 07/16] target-arm: Add HCR_EL2

2014-06-23 Thread Greg Bellows
Reviewed-by: Greg Bellows On 17 June 2014 03:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 36 > target-arm/helper.c | 26 ++ > 2 files changed, 62 inse

Re: [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts

2014-06-23 Thread Peter Lieven
On 05.06.2014 11:20, Chunyan Liu wrote: This patch series is to replace QEMUOptionParameter with QemuOpts, so that only one Qemu Option structure is kept in QEMU code. --- Changes to v27: * rebase to git master (code has been updated in this part since v27 sent so rebase to make the patc

[Qemu-devel] [PULL 07/19] linux-user: support SO_PASSSEC setsockopt option

2014-06-23 Thread riku . voipio
From: Paul Burton Translate the SO_PASSSEC option to setsockopt to the host value & perform the syscall as expected, allowing use of the option by target programs. Signed-off-by: Paul Burton Signed-off-by: Riku Voipio --- linux-user/socket.h | 5 + linux-user/syscall.c | 3 +++ 2 files c

[Qemu-devel] [PULL 03/19] linux-user: added fake open() for /proc/self/cmdline

2014-06-23 Thread riku . voipio
From: Wim Vander Schelden Signed-off-by: Wim Vander Schelden Signed-off-by: Riku Voipio --- linux-user/syscall.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 007d59d..5c175ba 100644 --- a/l

  1   2   3   4   >