[Qemu-devel] [PULL for-2.1] Update OpenBIOS images to r1306

2014-06-21 Thread Mark Cave-Ayland
Hi Peter, The following commit updates the OpenBIOS images to SVN r1306. Please pull. ATB, Mark. The following changes since commit 427e1750a0b98a72cad424327604f51e993dcc5f: gt64xxx_pci: Add VMStateDescription (2014-06-20 23:40:16 +0200) are available in the git repository at: https://

[Qemu-devel] [PULL for-2.1] qemu-sparc update

2014-06-21 Thread Mark Cave-Ayland
Hi Peter, This update contains Stefan's fix for an out-of-bounds array access on apb. Please pull. ATB, Mark. The following changes since commit 427e1750a0b98a72cad424327604f51e993dcc5f: gt64xxx_pci: Add VMStateDescription (2014-06-20 23:40:16 +0200) are available in the git repository at

Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-21 Thread Fam Zheng
On Fri, 06/20 09:30, Eric Blake wrote: > On 06/19/2014 11:01 PM, Fam Zheng wrote: > > On Thu, 06/19 22:20, Benoît Canet wrote: > >> The Thursday 19 Jun 2014 à 14:13:20 (-0600), Eric Blake wrote : > >>> On 06/19/2014 02:01 PM, Benoît Canet wrote: > As the code will start to operate on arbitratr

Re: [Qemu-devel] [PATCH block v1 2/2] block: m25p80: Support read only bdrvs.

2014-06-21 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 11:08:42AM +0200, Paolo Bonzini wrote: > >static void bdrv_sync_complete(void *opaque, int ret) > >{ > >/* do nothing. Masters do not directly interact with the backing store, > > * only the working copy so no mutexing required. > > */ > >} > > > >static void fla

Re: [Qemu-devel] Why I advise against using ivshmem

2014-06-21 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 10:57 PM, David Marchand wrote: > On 06/18/2014 12:48 PM, Stefan Hajnoczi wrote: >> >> One more thing to add to the list: >> >> static void ivshmem_read(void *opaque, const uint8_t * buf, int flags) >> >> The "flags" argument should be "size". Size should be checked before

Re: [Qemu-devel] [PATCH 01/16] linux-user: translate the result of getsockopt SO_TYPE

2014-06-21 Thread Riku Voipio
On Sun, Jun 15, 2014 at 05:18:18PM +0100, Paul Burton wrote: > QEMU previously passed the result of the host syscall directly to the > target program. This is a problem if the host & target have different > representations of socket types, as is the case when running a MIPS > target program on an x

Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-21 Thread Benoît Canet
The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote : > On Fri, 06/20 09:30, Eric Blake wrote: > > On 06/19/2014 11:01 PM, Fam Zheng wrote: > > > On Thu, 06/19 22:20, Benoît Canet wrote: > > >> The Thursday 19 Jun 2014 à 14:13:20 (-0600), Eric Blake wrote : > > >>> On 06/19/2014 02:01 PM,

Re: [Qemu-devel] [PATCH 04/16] linux-user: support SO_PASSSEC setsockopt option

2014-06-21 Thread Riku Voipio
On Sun, Jun 15, 2014 at 05:18:21PM +0100, Paul Burton wrote: > Translate the SO_PASSSEC option to setsockopt to the host value & > perform the syscall as expected, allowing use of the option by target > programs. Another file that is a total mess in linux-user tree.. This should be split out to ar

Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event layout for MIPS

2014-06-21 Thread Riku Voipio
On Sun, Jun 15, 2014 at 05:18:24PM +0100, Paul Burton wrote: > MIPS requires the pad field to 64b-align the data field just as ARM > does. Is this true for the 64bit mips also? > Signed-off-by: Paul Burton > --- > linux-user/syscall_defs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 00/16] linux-user fixes & improvements

2014-06-21 Thread Riku Voipio
On Sun, Jun 15, 2014 at 05:18:17PM +0100, Paul Burton wrote: > This series fixes a number of bugs in QEMUs linux-user support, some > specific to targetting the MIPS architecture but mostly generic. It also > adds support for some previously unsupported syscalls & {g,s}etsockopt > options. Apart f

Re: [Qemu-devel] [Qemu-trivial] [PATCH] virtio-serial: remove useless set_config function

2014-06-21 Thread Michael Tokarev
12.06.2014 13:20, Paolo Bonzini wrote: > Its only contents are a dead memcpy. Since it is optional, > drop the function altogether. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix new typos (found by codespell)

2014-06-21 Thread Michael Tokarev
13.06.2014 22:42, Stefan Weil wrote: > * accomodate -> accommodate > * aquiring -> acquiring > * beacuse -> because > * loosing -> losing > * prefering -> preferring > * threshhold -> threshold Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH v4] configure: Enable TPM by default, add --disable-tpm

2014-06-21 Thread Michael Tokarev
16.06.2014 23:32, Cole Robinson wrote: > I don't see why tpm is disabled by default: it doesn't have any > external dependencies, or change default behavior. Leaving it disabled > is just going to cause it to bit rot. > > Enable it by default, and add a --disable-tpm option. Applied to -trivial,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-ppc: Fix compiler warning

2014-06-21 Thread Michael Tokarev
17.06.2014 21:18, Stefan Weil wrote: > gcc reports a warning which is usually wrong: [] > Using g_assert_not_reached better documents the intention and does not > have these problems. Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Add support for the arm breakpoint syscall.

2014-06-21 Thread Michael Tokarev
20.06.2014 13:51, Peter Maydell пишет: > [cc'ing Riku as the linux-user maintainer.] > > On 20 June 2014 10:14, Hunter Laux wrote: > > Thanks for writing this patch. It mostly looks good > but there are some minor admin/format tweaks we need. > > You need to provide a Signed-off-by: line here,

Re: [Qemu-devel] [PATCH] vscclient: Add required headers to fix build on FreeBSD

2014-06-21 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

[Qemu-devel] [PATCH v3 00/11] implement dynamic endianness switching

2014-06-21 Thread Paolo Bonzini
This fixes the Raspberry Pi optimized memcmp library (with both user-mode and system-mode emulation). Compared to the previous submission, the main changes are: - I track access endianness by taking into account both SCTLR.B and CPSR.E, to make the code easier to understand (though a little bit

[Qemu-devel] [PATCH v3 01/11] linux-user: arm: fix coding style for some linux-user signal functions

2014-06-21 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- linux-user/signal.c | 112 ++-- 1 file changed, 57 insertions(+), 55 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index f3b4378..624c34d 100644 --- a/linux-user/signal.c +++ b/linux-user/signa

[Qemu-devel] [PATCH v3 04/11] linux-user: arm: set CPSR.E correctly for BE8 mode

2014-06-21 Thread Paolo Bonzini
Set it on startup, in signal handler frames and in new threads. Signed-off-by: Paolo Bonzini --- linux-user/arm/target_cpu.h | 2 ++ linux-user/main.c | 3 ++- linux-user/signal.c | 2 ++ target-arm/cpu.h| 3 +++ 4 files changed, 9 insertions(+), 1 deletions(-) dif

[Qemu-devel] [PATCH v3 03/11] target-arm: implement SCTLR.B, drop bswap_code

2014-06-21 Thread Paolo Bonzini
bswap_code is a CPU property of sorts ("is the iside endianness the opposite way round to TARGET_WORDS_BIGENDIAN?") but it is not the actual CPU state involved here which is SCTLR.B (set for BE32 binaries, clear for BE8). Replace bswap_code with SCTLR.B, and pass that to arm_ld*_code. The next pat

[Qemu-devel] [PATCH v3 02/11] linux-user: arm: pass env to get_user_code_*

2014-06-21 Thread Paolo Bonzini
This matches the idiom used by get_user_data_* later in the series, and will help when bswap_code will be replaced by SCTLR.B. Signed-off-by: Paolo Bonzini --- linux-user/main.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/linux-user/main.c b/linux-us

[Qemu-devel] [PATCH v3 05/11] linux-user: arm: handle CPSR.E correctly in strex emulation

2014-06-21 Thread Paolo Bonzini
Now that CPSR.E is set correctly, prepare for when setend will be able to change it; bswap data in and out of strex manually by comparing SCTLR.B, CPSR.E and TARGET_WORDS_BIGENDIAN (we do not have the luxury of using TCGMemOps). Signed-off-by: Paolo Bonzini --- linux-user/main.c | 50 +++

[Qemu-devel] [PATCH v3 06/11] target-arm: implement SCTLR.EE

2014-06-21 Thread Paolo Bonzini
Set CPSR.E to SCTLR.EE on exception, and use SCTLR.EE also to determine endianness for loads during TLB misses. Signed-off-by: Paolo Bonzini --- target-arm/helper.c | 38 -- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/target-arm/helper.c b/t

[Qemu-devel] [PATCH v3 08/11] target-arm: introduce tbflag for CPSR.E

2014-06-21 Thread Paolo Bonzini
Together with the existing tb flag for SCTLR.B, this governs the endianness of data accesses. Note that TARGET_WORDS_BIGENDIAN is not used, the two flags are enough because linux-user/main.c initializes SCTRL.B and CPSR.E correctly. Similar to bswap_code, the new predicate arm_tbflag_is_data_be o

[Qemu-devel] [PATCH v3 10/11] target-arm: reorganize gen_aa32_ld/st to prepare for BE32 system emulation

2014-06-21 Thread Paolo Bonzini
Extract everything to an inline function and simplify DO_GEN_LD/DO_GEN_ST. Signed-off-by: Paolo Bonzini --- target-arm/translate.c | 66 +- 1 file changed, 39 insertions(+), 27 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translat

[Qemu-devel] [PATCH v3 07/11] target-arm: pass DisasContext to gen_aa32_ld*/st*

2014-06-21 Thread Paolo Bonzini
We'll need the DisasContext in the next patch to retrieve the desired endianness, so pass it as a whole to gen_aa32_ld*/st*. Unfortunately we cannot let those functions call get_mem_index, because of user-mode load/store instructions. Signed-off-by: Paolo Bonzini --- target-arm/translate.c | 25

[Qemu-devel] [PATCH v3 09/11] target-arm: implement setend

2014-06-21 Thread Paolo Bonzini
Since this is not a high-performance path, just use a helper to flip the E bit and force a lookup in the hash table since the flags have changed. Signed-off-by: Paolo Bonzini --- target-arm/helper.h| 1 + target-arm/op_helper.c | 5 + target-arm/translate.c | 12 ++-- 3 files c

[Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation

2014-06-21 Thread Paolo Bonzini
System emulation only has a little-endian target; BE32 mode is implemented by adjusting the low bits of the address for every byte and halfword load and store. 64-bit accesses flip the low and high words. Signed-off-by: Paolo Bonzini --- target-arm/cpu.h | 5 +-- target-arm/translate.c

[Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable

2014-06-21 Thread Chen Gang
'buf' is not used actually, so remove it and related snprintf() statement. Signed-off-by: Chen Gang --- block.c | 2 -- dtc | 1 - 2 files changed, 3 deletions(-) delete mode 16 dtc diff --git a/block.c b/block.c index 43abe96..74af8d7 100644 --- a/block.c +++ b/block.c @@ -5595,7 +55

[Qemu-devel] [PATCH-trivial] Grub fails to boot from internal TFTP server when loading more than 3 initrd files.

2014-06-21 Thread Bernhard Übelacker
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - From a5c3977f133faa8d7e403005325014f114234307 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bernhard=20=C3=9Cbelacker?= Date: Sat, 21 Jun 2014 15:26:05 +0200 Subject: Increase maximum number of session of the internal TFTP server. MIME-Version: 1.0 Conte

Re: [Qemu-devel] problem using AHCI on xen fvm

2014-06-21 Thread Stefano Stabellini
I am glad it worked. Cheers, Stefano On Fri, 20 Jun 2014, Zhang, Eniac wrote: > Hi Stefano, > > You are a genius. Qemu2.0.0 works fine with my AHCI hack. > > Then I took a look at the patch. That fix is exactly what's missing in qemu > 1.6.1. I ported back that one fix and all is workin

[Qemu-devel] [PATCH trivial] block.c: Correct the return value and the failure object when failure occurs

2014-06-21 Thread Chen Gang
When failure occurs, 'ret' need be set, or may return 0 to indicate success. And error_propagate() also need be called only one time within a function. Signed-off-by: Chen Gang --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 74af8d7..12ce4e

Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable

2014-06-21 Thread Michael Tokarev
21.06.2014 17:00, Chen Gang wrote: > 'buf' is not used actually, so remove it and related snprintf() statement. Applied to -trivial, after removing wrong reference to dtc submodule removal. Please don't include these in diffs. Thanks, /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/3] rng-random: NULL check not needed before g_free()

2014-06-21 Thread Michael Tokarev
10.06.2014 00:04, Luiz Capitulino wrote: > On Fri, 30 May 2014 17:02:18 -0300 > Eduardo Habkost wrote: > >> g_free() is NULL-safe. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] tcg: mark tcg_out* and tcg_patch* with attribute 'unused'

2014-06-21 Thread Michael Tokarev
07.06.2014 21:08, Peter Maydell wrote: > The tcg_out* and tcg_patch* functions are utility routines that may or > may not be used by a particular backend; mark them with the 'unused' > attribute to suppress spurious warnings if they aren't used. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] x86: correctly implement soft reset

2014-06-21 Thread Michael Tokarev
08.06.2014 17:15, Michael Tokarev wrote: > 06.06.2014 18:06, Paolo Bonzini wrote: >> Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. >> These only reset the CPU. > > I'm not sure how this is -trivial material? :) Ping? This patch hasn't been applied so far, do you wa

Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-21 Thread Fam Zheng
On Sat, 06/21 12:45, Benoît Canet wrote: > The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote : > > On Fri, 06/20 09:30, Eric Blake wrote: > > > On 06/19/2014 11:01 PM, Fam Zheng wrote: > > > > On Thu, 06/19 22:20, Benoît Canet wrote: > > > >> The Thursday 19 Jun 2014 à 14:13:20 (-0600),

Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-21 Thread Benoît Canet
The Saturday 21 Jun 2014 à 23:15:19 (+0800), Fam Zheng wrote : > On Sat, 06/21 12:45, Benoît Canet wrote: > > The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote : > > > On Fri, 06/20 09:30, Eric Blake wrote: > > > > On 06/19/2014 11:01 PM, Fam Zheng wrote: > > > > > On Thu, 06/19 22:20, B

Re: [Qemu-devel] [PATCH] block: Make op blocker recursive

2014-06-21 Thread Benoît Canet
The Saturday 21 Jun 2014 à 17:39:11 (+0200), Benoît Canet wrote : > The Saturday 21 Jun 2014 à 23:15:19 (+0800), Fam Zheng wrote : > > On Sat, 06/21 12:45, Benoît Canet wrote: > > > The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote : > > > > On Fri, 06/20 09:30, Eric Blake wrote: > > > >

Re: [Qemu-devel] [PATCH 0/4] bsd-user: Update Queue

2014-06-21 Thread Sean Bruno
On Thu, 2014-06-19 at 17:19 -0700, Sean Bruno wrote: > This patchset brings us a couple of steps closer to the FreeBSD Development > tree, Stacey Son's bsd-user branch and qemu-devel port maintained out of tree. > > These patches are designed to begin to break apart the architectures > in bsd-user

Re: [Qemu-devel] [PATCH 01/16] linux-user: translate the result of getsockopt SO_TYPE

2014-06-21 Thread Paul Burton
On Sat, Jun 21, 2014 at 12:39:12PM +0300, Riku Voipio wrote: > > @@ -1526,6 +1555,7 @@ static abi_long do_getsockopt(int sockfd, int level, > > int optname, > > abi_long ret; > > int len, val; > > socklen_t lv; > > +int (*translate_result)(int val) = NULL; > > > > switch(

Re: [Qemu-devel] [PATCH] target-i386: simplify AES emulation

2014-06-21 Thread Richard Henderson
On 06/20/2014 03:48 PM, Aurelien Jarno wrote: > This patch simplifies the AES code, by directly accessing the newly added > S-Box, InvS-Box and InvMixColumns tables instead of recreating them by > using the AES_Te and AES_Td tables. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderso

[Qemu-devel] [Bug 1319493] Re: strip: '/usr/local/bin/fsdev/virtfs-proxy-helper': No such file make: *** [install] Error 1

2014-06-21 Thread Nigel Horne
I'm having the same problem. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1319493 Title: strip: '/usr/local/bin/fsdev/virtfs-proxy-helper': No such file make: *** [install] Error 1 Status in QE

[Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

2014-06-21 Thread Aurelien Jarno
The roundAndPackFloat16 function should return a float16 value, not a float32 one. Fix that. Cc: Peter Maydell Signed-off-by: Aurelien Jarno --- fpu/softfloat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index e00a6fb..3b19736 100644

Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

2014-06-21 Thread Peter Maydell
On 21 June 2014 20:35, Aurelien Jarno wrote: > The roundAndPackFloat16 function should return a float16 value, not a > float32 one. Fix that. > > Cc: Peter Maydell > Signed-off-by: Aurelien Jarno Agreed, though I don't think it has any effect on the results. Can we have the usual "ok under soft

Re: [Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation

2014-06-21 Thread Richard Henderson
On 06/21/2014 05:58 AM, Paolo Bonzini wrote: > @@ -855,32 +878,68 @@ static inline void gen_aa32_ld64(DisasContext *s, > TCGv_i64 val, TCGv_i32 addr, i > { > TCGMemOp opc = MO_Q | s->mo_endianness; > tcg_gen_qemu_ld_i64(val, addr, index, opc); > +#ifndef CONFIG_USER_ONLY > +/* Not n

Re: [Qemu-devel] [PATCH] softfloat: fix return type of roundAndPackFloat16

2014-06-21 Thread Aurelien Jarno
On Sat, Jun 21, 2014 at 09:06:21PM +0100, Peter Maydell wrote: > On 21 June 2014 20:35, Aurelien Jarno wrote: > > The roundAndPackFloat16 function should return a float16 value, not a > > float32 one. Fix that. > > > > Cc: Peter Maydell > > Signed-off-by: Aurelien Jarno > > Agreed, though I don

[Qemu-devel] [PATCH v2 00/16] linux-user fixes & improvements

2014-06-21 Thread Paul Burton
From: Paul Burton This series fixes a number of bugs in QEMUs linux-user support, some specific to targetting the MIPS architecture but mostly generic. It also adds support for some previously unsupported syscalls & {g,s}etsockopt options. Paul Burton (16): linux-user: translate the result of

[Qemu-devel] [PATCH v2 03/16] linux-user: support SO_{SND, RCV}BUFFORCE setsockopt options

2014-06-21 Thread Paul Burton
Translate the SO_SNDBUFFORCE & SO_RCVBUFFORCE options to setsockopt to the host values & perform the syscall as expected, allowing use of those options by target programs. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/syscall.c | 6 ++ 1 file changed, 6 insertions(+)

[Qemu-devel] [PATCH v2 02/16] linux-user: support SO_ACCEPTCONN getsockopt option

2014-06-21 Thread Paul Burton
Translate the SO_ACCEPTCONN option to the host value & execute the syscall as expected. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 30610e7..dba5b4d 10064

[Qemu-devel] [PATCH v2 06/16] linux-user: support strace of epoll_create1

2014-06-21 Thread Paul Burton
Add the epoll_create1 syscall to strace.list in order to display that syscall when it occurs, rather than a message about the syscall being unknown despite QEMU already implementing support for it. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/strace.list | 3 +++ 1 file

[Qemu-devel] [PATCH v2 14/16] linux-user: support the unshare syscall

2014-06-21 Thread Paul Burton
Add support for the unshare syscall, trivially passed through to the host. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/syscall.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 0bbdf61..936064c 100644 --- a/li

[Qemu-devel] [PATCH v2 01/16] linux-user: translate the result of getsockopt SO_TYPE

2014-06-21 Thread Paul Burton
QEMU previously passed the result of the host syscall directly to the target program. This is a problem if the host & target have different representations of socket types, as is the case when running a MIPS target program on an x86 host. Introduce a host_to_target_sock_type helper function mirrori

[Qemu-devel] [PATCH v2 07/16] linux-user: fix struct target_epoll_event layout for MIPS

2014-06-21 Thread Paul Burton
MIPS requires the pad field to 64b-align the data field just as ARM does. Signed-off-by: Paul Burton --- Changes in v2: - Apply the same padding for the mips64 target. --- linux-user/syscall_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall_defs.h b/

[Qemu-devel] [PATCH v2 11/16] linux-user: support ioprio_{get, set} syscalls

2014-06-21 Thread Paul Burton
Add support for the ioprio_get & ioprio_set syscalls, allowing their use by target programs. Signed-off-by: Paul Burton --- Changes in v2: - Declare the host syscalls conditionally upon whether both host & target define their numbers, to avoid compile time warnings/errors about the host

[Qemu-devel] [PATCH v2 12/16] linux-user: support {name_to, open_by}_handle_at syscalls

2014-06-21 Thread Paul Burton
Implement support for the name_to_handle_at and open_by_handle_at syscalls, allowing their use by the target program. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/strace.c| 30 ++ linux-user/strace.list | 6 ++ linux-user/syscall.c

[Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday

2014-06-21 Thread Paul Burton
The settimeofday syscall accepts a tz argument indicating the desired timezone to the kernel. QEMU previously ignored any argument provided by the target program & always passed NULL to the kernel. Instead, translate the argument & pass along the data userland provided. Although this argument is d

[Qemu-devel] [PATCH v2 04/16] linux-user: support SO_PASSSEC setsockopt option

2014-06-21 Thread Paul Burton
Translate the SO_PASSSEC option to setsockopt to the host value & perform the syscall as expected, allowing use of the option by target programs. Signed-off-by: Paul Burton --- Changes in v2: - Fix the value of TARGET_SO_PASSSEC for the sparc target. --- linux-user/socket.h | 5 + linux-u

[Qemu-devel] [PATCH v2 05/16] linux-user: allow NULL arguments to mount

2014-06-21 Thread Paul Burton
Calls to the mount syscall can legitimately provide NULL as the value for the source of filesystemtype arguments, which QEMU would previously reject & return -EFAULT to the target program. An example of this is remounting an already mounted filesystem with different properties. Instead of rejectin

[Qemu-devel] [PATCH v2 15/16] linux-user: support the KDSIGACCEPT ioctl

2014-06-21 Thread Paul Burton
Add a definition of the KDSIGACCEPT ioctl & allow its use by target programs. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/ioctls.h | 1 + linux-user/syscall_defs.h | 1 + 2 files changed, 2 insertions(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h ind

[Qemu-devel] [PATCH v2 09/16] linux-user: allow NULL tv argument for settimeofday

2014-06-21 Thread Paul Burton
The tv argument to the settimeofday syscall is allowed to be NULL, if the program only wishes to provide the timezone. QEMU previously returned -EFAULT when tv was NULL. Instead, execute the syscall & provide NULL to the kernel as the target program expected. Signed-off-by: Paul Burton --- Change

[Qemu-devel] [PATCH v2 16/16] linux-user: support the SIOCGIFINDEX ioctl

2014-06-21 Thread Paul Burton
Add a definition of the SIOCGIFINDEX ioctl, allowing its use by target programs. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/ioctls.h | 1 + linux-user/syscall_defs.h | 1 + 2 files changed, 2 insertions(+) diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h

[Qemu-devel] [PATCH v2 10/16] linux-user: support timerfd_{create, gettime, settime} syscalls

2014-06-21 Thread Paul Burton
Adds support for the timerfd_create, timerfd_gettime & timerfd_settime syscalls, allowing use of timerfds by target programs. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/strace.list | 9 + linux-user/syscall.c | 44 +++

[Qemu-devel] [PATCH v2 13/16] linux-user: support the setns syscall

2014-06-21 Thread Paul Burton
Add support for the setns syscall, trivially passed through to the host. Signed-off-by: Paul Burton --- Changes in v2: - None. --- linux-user/strace.list | 3 +++ linux-user/syscall.c | 6 ++ 2 files changed, 9 insertions(+) diff --git a/linux-user/strace.list b/linux-user/strace.list i

Re: [Qemu-devel] [PATCH v2 15/16] linux-user: support the KDSIGACCEPT ioctl

2014-06-21 Thread Peter Maydell
On 21 June 2014 23:53, Paul Burton wrote: > Add a definition of the KDSIGACCEPT ioctl & allow its use by target > programs. > > Signed-off-by: Paul Burton > --- > Changes in v2: > - None. > --- > linux-user/ioctls.h | 1 + > linux-user/syscall_defs.h | 1 + > 2 files changed, 2 insertion

Re: [Qemu-devel] [PATCH v2 08/16] linux-user: respect timezone for settimeofday

2014-06-21 Thread Peter Maydell
On 21 June 2014 23:53, Paul Burton wrote: > The settimeofday syscall accepts a tz argument indicating the desired > timezone to the kernel. QEMU previously ignored any argument provided > by the target program & always passed NULL to the kernel. Instead, > translate the argument & pass along the d

Re: [Qemu-devel] [PATCH 04/16] linux-user: support SO_PASSSEC setsockopt option

2014-06-21 Thread Paul Burton
On Sat, Jun 21, 2014 at 01:59:33PM +0300, Riku Voipio wrote: > On Sun, Jun 15, 2014 at 05:18:21PM +0100, Paul Burton wrote: > > Translate the SO_PASSSEC option to setsockopt to the host value & > > perform the syscall as expected, allowing use of the option by target > > programs. > > Another file

Re: [Qemu-devel] [PATCH 07/16] linux-user: fix struct target_epoll_event layout for MIPS

2014-06-21 Thread Paul Burton
On Sat, Jun 21, 2014 at 02:02:55PM +0300, Riku Voipio wrote: > On Sun, Jun 15, 2014 at 05:18:24PM +0100, Paul Burton wrote: > > MIPS requires the pad field to 64b-align the data field just as ARM > > does. > > Is this true for the 64bit mips also? It appears so, good catch :) Paul > > Signed-of

Re: [Qemu-devel] [PATCH trivial] block.c: Remove useless 'buf' variable

2014-06-21 Thread Chen Gang
On 06/21/2014 11:03 PM, Michael Tokarev wrote: > 21.06.2014 17:00, Chen Gang wrote: >> 'buf' is not used actually, so remove it and related snprintf() statement. > > Applied to -trivial, after removing wrong reference to dtc submodule removal. > Please don't include these in diffs. > OK, thanks

Re: [Qemu-devel] [RFC] qemu VGA endian swap low level drawing changes

2014-06-21 Thread Benjamin Herrenschmidt
On Sat, 2014-06-21 at 15:37 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2014-06-19 at 11:36 +0200, Gerd Hoffmann wrote: > > If not -- then I prefer to play save and not use a vbe register to avoid > > ending up with two incompatible bochs interface revisions. If you don't > > like the pci confi

[Qemu-devel] [PATCH for-2.1 0/2] qemu-char: fixes to the new get_msgfds API

2014-06-21 Thread Stefan Hajnoczi
The recent changes to extend qemu-char get_msgfds to support multiple file descriptors caused a qemu-iotests regression and also introduced a file descriptor leak. This patch series fixes the bugs. Stefan Hajnoczi (2): qemu-char: fix qemu_chr_fe_get_msgfd() qemu-char: avoid leaking unused fds

[Qemu-devel] [PATCH for-2.1 1/2] qemu-char: fix qemu_chr_fe_get_msgfd()

2014-06-21 Thread Stefan Hajnoczi
Commit c76bf6bb8fbbb233a7d3641e09229d23747d5ee3 ("Add chardev API qemu_chr_fe_get_msgfds") broke qemu_chr_fe_get_msgfd() because it changed the return value. Callers expect -1 if no fd is available. The commit changed the return value to 0 (which is a valid file descriptor number) so callers alwa

[Qemu-devel] [PATCH for-2.1 2/2] qemu-char: avoid leaking unused fds in tcp_get_msgfds()

2014-06-21 Thread Stefan Hajnoczi
Commit c76bf6bb8fbbb233a7d3641e09229d23747d5ee3 ("Add chardev API qemu_chr_fe_get_msgfds") extended the get_msgfds API from one to multiple file descriptors. It forgot to close unused file descriptors before freeing the file descriptor array. This patch prevents a file descriptor leak if the tcp_

Re: [Qemu-devel] [PATCH v3] qmp: add ACPI_DEVICE_OST event handling

2014-06-21 Thread Michael S. Tsirkin
On Fri, Jun 20, 2014 at 10:33:26AM +0200, Igor Mammedov wrote: > emits event when ACPI OSPM evaluates _OST method > of ACPI device. > > Signed-off-by: Igor Mammedov The subject and commit log are confusing here. We already have Author: Igor Mammedov qmp: add ACPI_DEVICE_OST

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries

2014-06-21 Thread Michael Tokarev
04.06.2014 05:37, Sam Bobroff пишет: > Allow "make install" to handle tool binaries that reside in > sub-directories. > > Without this patch "make install" will fail if it needs to strip > a tool binary (e.g. debugging is not enabled) that is installed > from a subdirectory. An example is fsdev/vi

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/1] Makefile: Correct path in stripping tool binaries

2014-06-21 Thread Michael Tokarev
22.06.2014 10:30, Michael Tokarev wrote: > 04.06.2014 05:37, Sam Bobroff wrote: >> Allow "make install" to handle tool binaries that reside in >> sub-directories. >> >> Without this patch "make install" will fail if it needs to strip >> a tool binary (e.g. debugging is not enabled) that is installe