From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
block.c | 21 +++--
docs/qmp/qmp-events.txt | 18 --
qapi/block.json | 14 ++
3 files changed, 21 insertions(+), 32 deletions(-)
diff --git a/block
From: Wenchao Xia
SPICE_INITIALIZED, SPICE_CONNECTED, SPICE_DISCONNECTED and
SPICE_MIGRATE_COMPLETED are converted in one patch, since they
use some common functions. inet_strfamily() is removed since no
callers exist anymore.
Note that there is no existing doc for SPICE_MIGRATE_COMPLETED
in doc
From: Wenchao Xia
'monitor.h' is still included in target-s390x/kvm.c, since I have
no good way to verify whether other code need it on my x86 host.
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
docs/qmp/qmp-events.txt | 14 --
hw/misc/pvpanic.c | 13 ++
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
include/monitor/monitor.h | 40 -
monitor.c | 220 +
stubs/Makefile.objs| 1 -
stubs/mon-protocol-event.c | 6 --
4 files changed, 4
Reviewed-by: Fam Zheng
Signed-off-by: Paolo Bonzini
---
qemu-char.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 26994aa..9470ea2 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1055,6 +1055,22 @@ static voi
Event emission must be protected by a mutex because of access to
the shared rate-limiting state, and to guard against concurrent
monitor "hot-plug" by means of human-monitor-command.
Reviewed-by: Luiz Capitulino
Signed-off-by: Paolo Bonzini
---
monitor.c | 16
1 file changed, 1
Il 18/06/2014 08:29, Amos Kong ha scritto:
> Instead of adding g_strescape everywhere, we should use json-parser's own
> interpolation support. See this patch:
> http://article.gmane.org/gmane.comp.emulators.qemu/279836 which also fixes a
> leak as a bonus.
>
> Also, you can use ' instead of " i
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
docs/qmp/qmp-events.txt | 18 --
hw/core/qdev.c | 12 ++--
qapi-event.json | 16
3 files changed, 18 insertions(+), 28 deletions(-)
diff --git a/docs/qmp/qmp
Il 17/06/2014 19:38, Andreas Färber ha scritto:
Am 17.06.2014 19:30, schrieb Paolo Bonzini:
Il 17/06/2014 19:09, Andreas Färber ha scritto:
Or at least give the
"rtc" node a more generic property type for ABI stability? I.e. you only
want "date" here, not any other properties of the mc146818rtc
The two common virtio features can be defined per bus, so move all
into bus class device to make code more clean.
As discussed with cornelia, s390-virtio-blk doesn't support
the two features at all, so keep s390-virtio as it.
Acked-by: Cornelia Huck #for s390 ccw
Suggested-by: Paolo Bonzini
Sig
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
docs/qmp/qmp-events.txt | 12
qapi-event.json | 10 ++
vl.c| 2 +-
3 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/docs/qmp/qmp-events.txt b/docs/qmp
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
block.c | 36
blockjob.c| 6 +-
docs/qmp/qmp-events.txt | 47 ---
include/block/block_int.h |
From: Wenchao Xia
In order to let event defines use existing types later, instead of
redefine new ones, some old type defines for spice and vnc are changed,
and BlockErrorAction is moved from block.h to qapi schema. Note that
BlockErrorAction is not merged with BlockdevOnError.
At this point, Vn
From: Wenchao Xia
These cases will verify whether the expected qdict is built.
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
tests/Makefile | 16 +-
tests/qapi-schema/qapi-schema-test.json | 12 ++
tests/qapi-schema/qapi-schema-test.out | 10 +-
test
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
block/qcow2-refcount.c | 14 --
docs/qmp/qmp-events.txt | 22 --
qapi/block-core.json| 24
3 files changed, 32 insertions(+), 28 deletions(-)
diff --git
- Fixed Andreas's mail address
On Fri, Jun 13, 2014 at 10:15:00AM +0200, Paolo Bonzini wrote:
> libqtest is using g_strdup_printf to format QMP commands, but
> this does not work if the argument strings need to be escaped.
> Instead, use the fancy %-formatting functionality of QObject.
> The only
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
balloon.c | 13 -
docs/qmp/qmp-events.txt| 17 -
hw/virtio/virtio-balloon.c | 6 --
include/sysemu/balloon.h | 2 --
monitor.c | 3 +--
qapi-
From: Wenchao Xia
Signed-off-by: Wenchao Xia
Signed-off-by: Paolo Bonzini
---
cpus.c | 5 +++--
docs/qmp/qmp-events.txt | 12
qapi-event.json | 9 +
3 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/cpus.c b/cpus.c
index dd7ac13..8
On Tue, Jun 17, 2014 at 09:51:21PM -0600, Eric Blake wrote:
> On 06/10/2014 05:25 AM, Amos Kong wrote:
> > It's ugly to add const prefix for parameter type by an if statement
> > outside c_type(). This patch adds a parameter to do it.
> >
> > Signed-off-by: Amos Kong
> > Suggested-by: Markus Armb
Hi Andreas and all,
I have done some cleanup of your WIP IRQ QOMification and have it in a
hopefully ready state. Its now link safe and the allocation/freeing
process is not as complex as before.
For fuller context of the motivation behind this series, please see:
http://lists.gnu.org/archive/htm
From: Andreas Färber
Replace qemu_allocate_irqs(foo, bar, 1)[0]
with qemu_allocate_irq(foo, bar, 0).
This avoids leaking the dereferenced qemu_irq *.
Cc: Kirill Batuzov
Cc: Markus Armbruster
Cc: Peter Maydell
Reviewed-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
Signed-off-by: Andreas
From: Andreas Färber
It does a g_free() on the pointer.
Reviewed-by: Peter Crosthwaite
Reviewed-by: Peter Maydell
Signed-off-by: Andreas Färber
Signed-off-by: Peter Crosthwaite
---
hw/sd/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd/sdhci.c b/hw/sd/s
Allocate each IRQ individually on array allocations. This prepares for
QOMification of IRQs, where pointers to individual IRQs may be taken
and handed around for usage as QOM Links. The g_renew scheme used here
is too fragile and would break all existing links should an IRQ list
be extended.
We no
From: Andreas Färber
As a prequel to any big Pin refactoring plans, do an in-place conversion
of qemu_irq to an Object, so that we can reference it in link<> properties.
Reviewed-by: Peter Maydell
Signed-off-by: Andreas Färber
[ PC Changes:
* Removed array-alloctor ref counting logic (limit c
Hello,
v4:
- Return value capped to 255 to prevent wrap-around (Eric Blake)
v3:
- Python script returns an error code: 0 if no errors, positive for
the number of errors identified.
v2:
- Tabs->spaces (Dave Gilbert)
- Several changes to the python script to make it more python-like
(Vit
This script compares the vmstate dumps in JSON format as output by QEMU
with the -dump-vmstate option.
It flags various errors, like version mismatch, sections going away,
size mismatches, etc.
This script is tolerant of a few changes that do not change the on-wire
format, like embedding a few fi
This commit adds a new command, '-dump-vmstate', that takes a filename
as a parameter. When executed, QEMU will dump the vmstate information
for the machine type it's invoked with to the file, and quit.
The JSON-format output can then be used to compare the vmstate info for
different QEMU version
This commit modifies the dump2 data to flag incompatibilities in the
machine types being compared.
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/v
This shows how the script deals with substructures added to vmstate
descriptions that don't change the on-wire format.
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 115 +++
1 file changed, 64 insertions(+), 51 deletions(-)
diff --git a/test
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f405534..36a9b4b 100644
--- a/tests/vmstate-static-check
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f6b52d0..34bfbf6 100644
--- a/tests/vmstate-static-checker-data/dum
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 45cccaf..75719f5 100644
--- a/tests/vmstate-static-check
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 0a8b81d..f405534 100644
--- a/tests/vmstate-static-check
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 27 +--
1 file changed, 1 insertion(+), 26 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 66ac3bd..05b8fce 100644
---
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 36a9b4b..4ccfd67 100644
--- a/tests/vmstate-static-check
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 114 +--
1 file changed, 1 insertion(+), 113 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index f69966d..cc0aae3 100644
--
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 15 ---
1 file changed, 15 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 6f8a617..b5cb1aa 100644
--- a/tests/vmstate-static-check
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 6 --
1 file changed, 6 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 4ccfd67..f6b52d0 100644
--- a/tests/vmstate-static-checker-data/dum
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 13 -
1 file changed, 13 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 05b8fce..6f8a617 100644
--- a/tests/vmstate-static-checker
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 33 +---
1 file changed, 1 insertion(+), 32 deletions(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index cc0aae3..66ac3bd 100644
---
On 18 June 2014 05:45, Stefan Weil wrote:
> A 32 bit build on Ubuntu gcc-4.6.3-1ubuntu5 just finished and shows the
> same error messages, so really all of my builds show them (32 and 64
> bit, Linux native and cross for Windows).
>
> Peter, I know that libvixl is external code, but posted this pa
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump2.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump2.json
b/tests/vmstate-static-checker-data/dump2.json
index 34bfbf6..f69966d 100644
--- a/tests/vmstate-static-check
On Tue, Jun 17, 2014 at 11:02:48AM +0200, Marc Marí wrote:
> This is the draft for the libqos virtio API to create test cases for virtio
> devices. I'm looking forward to your comments.
>
> Signed-off-by: Marc Marí
> ---
> tests/libqos/virtio.h | 148
> +
From: Wim Vander Schelden
Signed-off-by: Wim Vander Schelden
---
linux-user/syscall.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index c134c32..1be0f09 100644
--- a/linux-user/syscall.c
+++ b/li
Hi Eric,
Thanks for your feedback.
I've addressed the issues you mentioned and verified the patch with
checkpatch.pl.
The updated patch follows.
Kind regards,
Wim
Signed-off-by: Amit Shah
---
tests/vmstate-static-checker-data/dump1.json | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vmstate-static-checker-data/dump1.json
b/tests/vmstate-static-checker-data/dump1.json
index 44200fb..786ca0b 100644
--- a/tests/vmstate-static-check
On Tue, 2014-06-17 at 23:19 +0300, Michael S. Tsirkin wrote:
> On Tue, Jun 17, 2014 at 10:14:01PM +0200, Igor Mammedov wrote:
> > linker and RSDP tables are build only once, so if later
> > during rebuild sizes of ACPI tables change pointers will
> > be patched incorrectly due to wrong offsets.
> >
On Wed, Jun 18, 2014 at 12:04:31PM +0300, Marcel Apfelbaum wrote:
> On Tue, 2014-06-17 at 23:19 +0300, Michael S. Tsirkin wrote:
> > On Tue, Jun 17, 2014 at 10:14:01PM +0200, Igor Mammedov wrote:
> > > linker and RSDP tables are build only once, so if later
> > > during rebuild sizes of ACPI tables
This test needs a bit more work: issues have been
found on legacy systems, disable it for now to
avoid false positives for people.
Will re-enable after issues are addressed.
Reported-by: Igor Mammedov
Signed-off-by: Michael S. Tsirkin
---
tests/Makefile | 2 +-
1 file changed, 1 insertion(+), 1
Il 17/06/2014 21:11, Ed Maste ha scritto:
On 17 June 2014 13:15, Paolo Bonzini wrote:
Il 17/06/2014 19:10, Ed Maste ha scritto:
This change breaks the build on FreeBSD:
libcacard/vscclient.c: In function 'send_msg':
libcacard/vscclient.c:111: warning: implicit declaration of function
'htonl'
Il 18/06/2014 01:23, Hani Benhabiles ha scritto:
Due to an incomplete initialization, adding a usb-bt-dongle device through HMP
or QMP will cause a segmentation fault.
Signed-off-by: Hani Benhabiles
Suggested-by: Paolo Bonzini
---
Compared to v1:
* Remove duplicate code from usb_bt_init() and
Just a query whether migration works for you
guys with vhost-user and snabbswitch.
vhost user code seems to have enough hooks in
place to make it work, but was it tested
in practice?
--
MST
Hi,
> > IMO xen should use a versioned machine type to make live migration more
> > reliable. IIRC this was discussed anyway for other reasons (see
> > xen-platform-pci discussions, picking pc-i440fx-1.6 IIRC).
>
> That is happening as far as I know and does not directly impact this
> patch se
On Wed, 18 Jun 2014 12:23:36 +0300
"Michael S. Tsirkin" wrote:
> This test needs a bit more work: issues have been
> found on legacy systems, disable it for now to
> avoid false positives for people.
> Will re-enable after issues are addressed.
>
> Reported-by: Igor Mammedov
> Signed-off-by: Mi
Il 18/06/2014 09:41, Amos Kong ha scritto:
- Fixed Andreas's mail address
On Fri, Jun 13, 2014 at 10:15:00AM +0200, Paolo Bonzini wrote:
libqtest is using g_strdup_printf to format QMP commands, but
this does not work if the argument strings need to be escaped.
Instead, use the fancy %-formatti
v4:
* Coding style: typedef struct { on a single line [Andreas]
* Add "dataplane: bail out on unsupported transport" for s390-virtio [Cornelia]
v3:
* Split qdev_alias_all_properties() into its own patch [Peter Crosthwaite]
* Do not dereference DEVICE_CLASS(class) inline [Peter Crosthwaite]
v2
Sometimes an object needs to present a property which is actually on
another object, or it needs to provide an alias name for an existing
property.
Examples:
a.foo -> b.foo
a.old_name -> a.new_name
The new object_property_add_alias() API allows objects to alias a
property on the same object o
It becomes unwiedly to duplicate all virtio-blk qdev property
definitions due to an #ifdef. The C preprocessor syntax makes it a
little hard to resolve this cleanly but we can extract the #ifdef and
call a macro it defines later.
Avoiding duplication is important since it will only get worse when
On Wed, 18 Jun 2014 12:19:10 +0300
"Michael S. Tsirkin" wrote:
> On Wed, Jun 18, 2014 at 12:04:31PM +0300, Marcel Apfelbaum wrote:
> > On Tue, 2014-06-17 at 23:19 +0300, Michael S. Tsirkin wrote:
> > > On Tue, Jun 17, 2014 at 10:14:01PM +0200, Igor Mammedov wrote:
> > > > linker and RSDP tables a
From: Cornelia Huck
If the virtio transport does not support notifiers (like s390-virtio),
we can't use dataplane. Bail out early and let the user know what is
wrong.
Signed-off-by: Cornelia Huck
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi
---
hw/block/dataplane/virtio-blk.c
The qdev_alias_all_properties() function creates QOM alias properties
for each qdev property on a DeviceState. This is useful for parent
objects that wish to forward property accesses to their children.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Peter Crosthwaite
---
v3:
* Split qdev_alias_al
Move the x-data-plane property. Originally it was outside since not
every transport may wish to support dataplane. But that makes little
sense when we have a dedicated CONFIG_VIRTIO_BLK_DATA_PLANE ifdef
already.
This move makes it easier to switch to property aliases in the next
patch.
Signed-o
This function is no longer used since parent objects now use child
aliases to set the VirtIOBlkConf directly.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Peter Crosthwaite
---
hw/block/virtio-blk.c | 6 --
include/hw/virtio/virtio-blk.h | 2 --
2 files changed, 8 deletions(-)
diff
virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the
qdev properties of their VirtIOBlock child. This approach does not work
well with string or pointer properties since we must be careful about
leaking or double-freeing them.
Use the QOM alias property to forward property access
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-blk child is not finalized!
Drop our reference
There is no need to make DEFINE_VIRTIO_BLK_PROPERTIES() public. Inline
it into virtio-blk.c so it cannot be used by mistake from other source
files.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Peter Crosthwaite
---
hw/block/virtio-blk.c | 12 +++-
include/hw/virtio/virtio-blk.
On Tue, Jun 17, 2014 at 11:08:48AM -0400, Milos Vyletel wrote:
> I hope this is the right place to report this. I've noticed that I
> can't run qemu-img convert on latest git version because it segfaults.
> I've bisected the code and identified that this was caused by
Thanks for the bug report!
>
On Tue, Jun 17, 2014 at 04:48:43PM +0200, Anshul Makkar wrote:
> Just want to check this small piece of implementation detail in qemu.
>
> Is it possible to change the mac address of VM at runtime and does
> the same information is conveyed to host if we are using Virtio based
> transfers (approa
On Mon, Jun 16, 2014 at 01:29:08PM -0400, Gabriel L. Somlo wrote:
> This series contains a few fixes and improvements in the emulation
> of link auto-negotiation:
>
> - use auto-negotiation when the link is bounced externally (e.g. via
> set_link down/up on the qemu monitor command line).
>
Amit Shah wrote:
> This commit adds a new command, '-dump-vmstate', that takes a filename
> as a parameter. When executed, QEMU will dump the vmstate information
> for the machine type it's invoked with to the file, and quit.
>
> The JSON-format output can then be used to compare the vmstate info
Am 18.06.2014 08:40, schrieb Amos Kong:
> On Tue, Jun 17, 2014 at 03:25:34PM +0200, Andreas Färber wrote:
>> Am 06.06.2014 16:33, schrieb Amos Kong:
>>> This patch adds a new subtest, it hotplugs 29 * 8 = 232 virtio-blk
>>> devices to guest, and try to hot-unplug them.
>>>
>>> Note: the hot-unplug
Amit Shah wrote:
> This commit modifies the dump2 data to flag incompatibilities in the
> machine types being compared.
>
> Signed-off-by: Amit Shah
Acked-by: Juan Quintela
Amit Shah wrote:
> These are stripped-down JSON data as obtained from the -dump-vmstate
> option. The two files are identical in this commit, and will be
> modified in the later commits to show what the script does with the
> data.
>
> Signed-off-by: Amit Shah
Acked-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Acked-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Acked-by: Juan Quintela
Amit Shah wrote:
Reviewed-by: Juan Quintela
On (Wed) 18 Jun 2014 [12:24:25], Juan Quintela wrote:
> Amit Shah wrote:
> > This commit adds a new command, '-dump-vmstate', that takes a filename
> > as a parameter. When executed, QEMU will dump the vmstate information
> > for the machine type it's invoked with to the file, and quit.
> >
> > T
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote:
>
> On 17.06.14 09:36, Stefan Hajnoczi wrote:
> >On Fri, Jun 13, 2014 at 01:18:00PM +0200, Greg Kurz wrote:
> >>This version merges the changes requested during the v7 review, remarks from
> >>ppc64 dump support review (yes, we talked
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
Il 17/06/2014 22:34, Andreas Färber ha scritto:
Apart from that, looks sane, so if someone can confirm the
Broadwell-specific values I'll be happy to fix the style and queue it
for 2.1.
The only Broadwell machine I can see the data for (but I cannot access
it) is a laptop version (ULT) and it
Amit Shah wrote:
> This script compares the vmstate dumps in JSON format as output by QEMU
> with the -dump-vmstate option.
>
> It flags various errors, like version mismatch, sections going away,
> size mismatches, etc.
>
> This script is tolerant of a few changes that do not change the on-wire
>
Amit Shah wrote:
> This shows how the script deals with substructures added to vmstate
> descriptions that don't change the on-wire format.
>
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
On Tue, Jun 17, 2014 at 11:44:11AM +0200, Paolo Bonzini wrote:
> Il 17/06/2014 11:03, David Marchand ha scritto:
> >>Unless someone steps up and maintains ivshmem, I think it should be
> >>deprecated and dropped from QEMU.
> >
> >Then I can maintain ivshmem for QEMU.
> >If this is ok, I will send a
Amit Shah wrote:
> Hello,
>
> v4:
> - Return value capped to 255 to prevent wrap-around (Eric Blake)
>
> v3:
> - Python script returns an error code: 0 if no errors, positive for
>the number of errors identified.
>
> v2:
> - Tabs->spaces (Dave Gilbert)
> - Several changes to the python scr
On Tue, Jun 17, 2014 at 11:03:32AM +0200, David Marchand wrote:
> On 06/17/2014 04:54 AM, Stefan Hajnoczi wrote:
> >ivshmem has a performance disadvantage for guest-to-host
> >communication. Since the shared memory is exposed as PCI BARs, the
> >guest has to memcpy into the shared memory.
> >
> >v
On Mon, Jun 16, 2014 at 11:52:22AM +0100, Peter Maydell wrote:
> On 10 June 2014 15:03, Peter Maydell wrote:
> > If the flash device is configured with a device-width which is
> > not equal to the bank-width, indicating that it is actually several
> > narrow flash devices in parallel, the CFI tabl
Hi Anton,
Still alive? L2TPv3 for QEMU has not been merged. Do you have an
up-to-date series based on qemu.git/master you could send?
I remember it was very close to finished.
Stefan
pgpkUKbx4IXVe.pgp
Description: PGP signature
Amit Shah wrote:
>>
>> You can print always \n now, right?
>
> There's also a , there...
>
> This sequence was added recently (v2 onwards) for the ignoring of the
> VMS_MUST_EXIST stuff.
I knew it needed to be some reason for the ugliness :-()
>> Same for the other places? Or I am missing some
On (Wed) 18 Jun 2014 [12:44:12], Juan Quintela wrote:
> Amit Shah wrote:
> > This script compares the vmstate dumps in JSON format as output by QEMU
> > with the -dump-vmstate option.
> >
> > It flags various errors, like version mismatch, sections going away,
> > size mismatches, etc.
> >
> > Thi
On (Wed) 18 Jun 2014 [12:49:21], Juan Quintela wrote:
> Amit Shah wrote:
> > Hello,
> >
> > v4:
> > - Return value capped to 255 to prevent wrap-around (Eric Blake)
> >
> > v3:
> > - Python script returns an error code: 0 if no errors, positive for
> >the number of errors identified.
> >
> >
On Tue, Jun 10, 2014 at 5:00 PM, Paolo Bonzini wrote:
> Il 10/06/2014 09:29, Stefan Hajnoczi ha scritto:
>
>> This series adds blockstats support to virtio-blk data-plane and protects
>> query-blockstats from races with the dataplane IOThread.
>>
>> Stefan Hajnoczi (3):
>> dataplane: add bdrv_ac
On Wed, Jun 11, 2014 at 2:35 AM, Paolo Bonzini wrote:
> Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto:
>
>> @@ -193,6 +193,8 @@ static void s390_virtio_blk_instance_init(Object *obj)
>> object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev),
>> NULL);
>> object_unref(OBJEC
Amit Shah wrote:
> Signed-off-by: Amit Shah
Reviewed-by: Juan Quintela
1 - 100 of 453 matches
Mail list logo
