Re: [Qemu-devel] [PATCH RESEND v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed

2014-06-10 Thread Amit Shah
On (Wed) 14 May 2014 [16:30:09], Eduardo Habkost wrote: > From: Marcelo Tosatti > > Invariant TSC documentation mentions that "invariant TSC will run at a > constant rate in all ACPI P-, C-. and T-states". > > This is not the case if migration to a host with different TSC frequency > is allowed,

[Qemu-devel] [Bug 1323001] Re: Netlink socket support for MIPS*

2014-06-10 Thread Luca Falavigna
This patches solves the issue for me: http://patchwork.ozlabs.org/patch/346018/ ** Tags added: patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323001 Title: Netlink socket support for MIPS*

Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

2014-06-10 Thread Amit Shah
On (Tue) 13 May 2014 [20:25:38], arei.gong...@huawei.com wrote: > From: Gonglei > > If the networking break or there's something wrong with rdma > device(ib0 with no IP) during rdma migration, the main_loop of > qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event > to fix this bug. >

[Qemu-devel] [PATCH v8 0/4] Quorum maintainance operations

2014-06-10 Thread Benoît Canet
in v8: check size is the same [Eric] drop sync=full requirement [Eric] split patch in two [Eric] shorter names [Eric] Benoît Canet (4): quorum: Add the rewrite-corrupted parameter to quorum. block: Add node-name argument to drive-mirror. block: Add replaces ar

[Qemu-devel] [PATCH v8 2/4] block: Add node-name argument to drive-mirror.

2014-06-10 Thread Benoît Canet
This new argument can be used to specify the node-name of the new mirrored BDS. Signed-off-by: Benoit Canet --- blockdev.c | 11 +-- hmp.c| 1 + qapi/block-core.json | 4 qmp-commands.hx | 3 +++ 4 files changed, 17 insertions(+), 2 deletions(-) di

[Qemu-devel] [PATCH v8 4/4] qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror node-name mode.

2014-06-10 Thread Benoît Canet
The to-replace-node-name is designed to allow repairing of broken Quorum file. This patch introduce a new class TestRepairQuorum testing that the feature works. Some further work will be done on QEMU to improve the robutness of the tests. Signed-off-by: Benoit Canet --- tests/qemu-iotests/041

[Qemu-devel] [PATCH v8 3/4] block: Add replaces argument to drive-mirror

2014-06-10 Thread Benoît Canet
drive-mirror will bdrv_swap the new BDS named node-name with the one pointed by replaces when the mirroring is finished. Signed-off-by: Benoit Canet --- block.c | 26 block/mirror.c| 62 +-- blockdev.c

[Qemu-devel] [PATCH v8 1/4] quorum: Add the rewrite-corrupted parameter to quorum.

2014-06-10 Thread Benoît Canet
On read operations when this parameter is set and some replicas are corrupted while quorum can be reached quorum will proceed to rewrite the correct version of the data to fix the corrupted replicas. This will shine with SSD where the FTL will remap the same block at another place on rewrite. Sig

Re: [Qemu-devel] [PATCH v8 1/4] quorum: Add the rewrite-corrupted parameter to quorum.

2014-06-10 Thread Benoît Canet
The Tuesday 10 Jun 2014 à 09:21:43 (+0200), Benoît Canet wrote : Oh i again submitted a commit subject ending with a dot I will remove theses. > On read operations when this parameter is set and some replicas are corrupted > while quorum can be reached quorum will proceed to rewrite the correct v

Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load

2014-06-10 Thread Amit Shah
On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote: > * Peter Lieven (p...@kamp.de) wrote: > > if a saved vm has unknown flags in the memory data qemu > > currently simply ignores this flag and continues which > > yields in an unpredictable result. > > > > this patch catches all unknown

Re: [Qemu-devel] [PATCH v5 2/3] pc & q35: Add new machine opt max-ram-below-4g

2014-06-10 Thread Gerd Hoffmann
Hi, > > So instead of default 0, it would be preferable to set the default to the > > actual value, and let user override it. > > > > Or if that's too hard, set max_ram_below_4g instead of setting > > gigabyte_align. gigabyte_align switches everywhere is messy > > enough, adding max_ram_below_4g

[Qemu-devel] [PATCH] block/nfs: fix potential segfault on early callback

2014-06-10 Thread Peter Lieven
it will happen in the future that the callback of a libnfs call directly invokes the callback. In this case we end up in a segfault because the NFSRPC is gone when we the BH is scheduled. Signed-off-by: Peter Lieven --- block/nfs.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif

Re: [Qemu-devel] [PATCH 2/3] console: rework text terminal cursor logic

2014-06-10 Thread Gerd Hoffmann
On So, 2014-06-08 at 11:30 +0100, Ian Campbell wrote: > On Thu, 2014-05-22 at 13:00 +0200, Gerd Hoffmann wrote: > > Have a global timer. Update all visible terminal windows syncronously. > > Right now this can be the active_console only, but that will change > > soon. The global timer will disabl

[Qemu-devel] [PATCH] block/iscsi: fix potential segfault on early callback

2014-06-10 Thread Peter Lieven
it might happen in the future that a function directly invokes its callback. In this case we end up in a segfault because the iTask is gone when the BH is scheduled. Signed-off-by: Peter Lieven --- block/iscsi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/block/isc

[Qemu-devel] [PATCH 2/3] spapr: Add "qemu, boot-menu" property to /chosen

2014-06-10 Thread Nikunj A Dadhania
From: Avik Sil This is required to enable boot menu display during booting Signed-off-by: Avik Sil Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index ff37319..c6760a1 100644 --- a/hw/ppc/spapr.c +++

[Qemu-devel] [PATCH 3/3] ppc: spapr-rtas - implement os-term rtas call

2014-06-10 Thread Nikunj A Dadhania
PAPR compliant guest calls this in absence of kdump. After receiving this call qemu could trigger a guest dump. This guest dump can be used to analyse using crash tool. Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_rtas.c | 34 ++ 1 file changed, 34 insertions

[Qemu-devel] [PATCH 1/3] spapr: add uuid/host details to device tree

2014-06-10 Thread Nikunj A Dadhania
Useful for identifying the guest/host uniquely within the guest. Adding following properties to the guest root node. vm,uuid - uuid of the guest host-model - Host model number host-serial - Host machine serial number hypervisor type - Tells its "kvm" Signed-off-by: Nikunj A Dadhania --- hw/ppc/

Re: [Qemu-devel] [PATCH] audio: Drop superfluous conditionals around g_free()

2014-06-10 Thread Gerd Hoffmann
Hi, > Gerd, should patches for audio/ conform to the usual style now, or are > they still special? I don't consider them special. If you use usual qemu style in patches that is fine with me. But I don't feel like doing a conversion pass, that simply isn't worth the trouble IMO. cheers, Ger

Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free()

2014-06-10 Thread Gerd Hoffmann
> >> +*cred = NULL; > >> > >> *cred = g_malloc(strlen(certdir) + strlen(filename) + 2); > > > > Still a dead store > > No deader than before my patch :) > > Still, it's as good an opportunity to drop it as any. Gerd, would you > like a v3? It's an improvement in any case, so I'm not

Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load

2014-06-10 Thread Peter Lieven
On 10.06.2014 09:31, Amit Shah wrote: On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote: * Peter Lieven (p...@kamp.de) wrote: if a saved vm has unknown flags in the memory data qemu currently simply ignores this flag and continues which yields in an unpredictable result. this patch

[Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load

2014-06-10 Thread Peter Lieven
if a saved vm has unknown flags in the memory data qemu currently simply ignores this flag and continues which yields in an unpredictable result. this patch catches all unknown flags and aborts the loading of the vm. CC: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- v2->v3: - reworked l

Re: [Qemu-devel] [PATCH] target-arm: A64: Correct handling of UXN bit.

2014-06-10 Thread Claudio Fontana
This patch fixes my issue with page tables switching on OSv guest. Thank you all! Tested-by: Claudio Fontana On 08.06.2014 15:53, Ian Campbell wrote: > In v8 page tables bit 54 in the PTE is UXN in the EL0/EL1 translation regimes > and XN elsewhere. In v7 the bit is always XN. Since we only emu

[Qemu-devel] [PULL 01/10] s390x/css: handle emw correctly for tsch

2014-06-10 Thread Cornelia Huck
We should not try to store the emw portion of the irb if extended measurements are not applicable. In particular, we should not surprise the guest by storing a larger irb if it did not enable extended measurements. Cc: qemu-sta...@nongnu.org Reviewed-by: David Hildenbrand Tested-by: Christian Bor

[Qemu-devel] [PULL 00/10] s390 patches

2014-06-10 Thread Cornelia Huck
tags/s390x-20140610 for you to fetch changes up to bbd8bb8e3245cf6fc6d12b10b3320ab183adb866: s390x/kvm: inject via flic (2014-06-10 09:50:27 +0200) Several patches for s390: - bugfixes: A fix for a long-standing bug in the css code as w

[Qemu-devel] [PULL 02/10] s390x/kvm: make flic play well with old kernels

2014-06-10 Thread Cornelia Huck
If we run with an old kernel that does not support KVM_CAP_IRQ_ROUTING, we don't have to do anything in the ->register_io_adapter and ->io_adapter_map callbacks and therefore should return 0 instead of -ENOSYS (just as the non-kvm flic does). This fixes using adapter interrupts when running under

[Qemu-devel] [PULL 05/10] s390x/kvm: Log unmanageable program interruptions

2014-06-10 Thread Cornelia Huck
From: Thomas Huth The kernel only drops to userspace if an endless program interrupt loop has been detected. Let's print an error message in this case to inform the user about the crash and stop the affected CPU with a panic event, just like it is already done for the external interruption loop d

[Qemu-devel] [PULL 07/10] s390x: consolidate floating interrupts

2014-06-10 Thread Cornelia Huck
Move the injection code for all floating interrupts to interrupt.c and add a comment. Also get rid of the #ifdef CONFIG_KVM for the service interrupt. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-bus.c | 11 --- target-s390x/cpu.h | 32

[Qemu-devel] [PULL 04/10] s390x/kvm: Log unmanageable external interruptions

2014-06-10 Thread Cornelia Huck
From: Thomas Huth Interception code 0x14 only drops to userspace when an unmanageable external interruption interception occured (e.g. if the External New PSW does not disable external interruptions). Instead of bailing out via the default handler, it is better to inform the user with a proper er

[Qemu-devel] [PULL 03/10] s390x/kvm: enable/reset cmma via vm attributes

2014-06-10 Thread Cornelia Huck
From: Dominik Dingel Exploit the new api for userspace-controlled cmma. If supported, enable cmma during kvm initialization and register a reset handler for cmma, which is also called directly from the load IPL code. The reset functionality is needed to reset the cmma state of the guest pages, e

[Qemu-devel] [PULL 06/10] s390/virtio-ccw: migration support

2014-06-10 Thread Cornelia Huck
From: Jens Freimann This patch adds live migration support for virtio-ccw devices. It's not done with vmstate because virtio itself is not yet ported to vmstate either. Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- hw/s390x/css.c| 111 +

[Qemu-devel] [PULL 10/10] s390x/kvm: inject via flic

2014-06-10 Thread Cornelia Huck
Try to inject floating interrupts via the flic if it is available. This allows us to inject the full range of floating interrupts. Reviewed-by: Jens Freimann Signed-off-by: Cornelia Huck --- hw/intc/s390_flic_kvm.c | 10 ++ target-s390x/cpu.h |1 + target-s390x/kvm.c |

[Qemu-devel] [PULL 08/10] s390x/kvm: add alternative injection interface

2014-06-10 Thread Cornelia Huck
Add kvm_s390_{vcpu,floating}_interrupt, which offer the possibility to inject interrupts with larger payloads (when a kvm backend becomes available). Moreover, kvm_s390_floating_interrupt() does no longer have the bogus requirement for a vcpu. Signed-off-by: Cornelia Huck --- target-s390x/cpu.h

Re: [Qemu-devel] [PATCH] block/iscsi: fix potential segfault on early callback

2014-06-10 Thread Peter Lieven
On 10.06.2014 10:08, Paolo Bonzini wrote: Il 10/06/2014 09:52, Peter Lieven ha scritto: it might happen in the future that a function directly invokes its callback. In this case we end up in a segfault because the iTask is gone when the BH is scheduled. Signed-off-by: Peter Lieven --- block/i

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-06-10 Thread Michael Tokarev
10.06.2014 10:34, Paolo Bonzini wrote: > Il 10/06/2014 08:30, Michael Tokarev ha scritto: >> Hello. >> >> The question is: are the drive shortcuts - -cdrom, -hda, -hdb etc - >> supposed to work in -machine q35 too? Or are they merely ignored? >> >> qemu-system-x86_64 -machine q35 -cdrom foo.img

[Qemu-devel] [PULL 09/10] s390x: cleanup interrupt injection

2014-06-10 Thread Cornelia Huck
Remove the need for a cpu to inject a floating interrupt on kvm. Acked-by: Thomas Huth Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 15 ++- hw/s390x/s390-virtio-bus.c |6 +-- target-s390x/cpu.h | 41 + target-s390x/interrupt.c | 38 ++

Re: [Qemu-devel] [PATCH] block/iscsi: fix potential segfault on early callback

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 09:52, Peter Lieven ha scritto: it might happen in the future that a function directly invokes its callback. In this case we end up in a segfault because the iTask is gone when the BH is scheduled. Signed-off-by: Peter Lieven --- block/iscsi.c |5 - 1 file changed, 4 inse

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 10:10, Michael Tokarev ha scritto: > It should work. I remember some complications due to AHCI not having slaves, but it is a bug. It looks like the "short" -drive if=ide option does not connect the created drive to any bus at all. With the above command, or with -drive if=ide,i

Re: [Qemu-devel] [PATCH] scsi: Report error when lun number is in use

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 08:55, Fam Zheng ha scritto: In the case that the lun number is taken by another scsi device, don't release the existing device siliently, but report an error to user. Signed-off-by: Fam Zheng --- hw/scsi/scsi-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

Re: [Qemu-devel] [PATCH] add command to position mouse pointer in absolute mode

2014-06-10 Thread Gerd Hoffmann
Hi, > +.name = "mouse_move_abs", > +.args_type = "dx_str:s,dy_str:s,dz_str:s?", > +.params = "dx dy [dz]", > +.help = "send mouse move events (absolute coordinates)", > +.mhandler.cmd = do_mouse_move_abs, > +}, > + > +STEXI > +@item mo

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-10 Thread Hu Tao
On Tue, Jun 10, 2014 at 01:09:32AM -0400, Paolo Bonzini wrote: > > > > > +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" > > > how about naming it after what it really is? "memory-backend-hugepage" > > > Later we could split it into generic superclass mmap-ed > > > "memory-backend-file" an

Re: [Qemu-devel] [50809c8] Attempt to boot a guest results in - qemu: could not load PC BIOS 'bios-256k.bin'

2014-06-10 Thread Kashyap Chamarthy
On Sun, Jun 08, 2014 at 05:48:58PM +0530, Kashyap Chamarthy wrote: > Heya, > > I built QEMU from this commit: > > $ git log | head -2 > commit 50809c8b9288a9bfe1fdec926b7ef985608a7ea6 > Merge: 4e627ae ae74bbe > > > And, attempted to boot a Fedora guest via this QEMU CLI results as >

Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load

2014-06-10 Thread Amit Shah
On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote: > if a saved vm has unknown flags in the memory data qemu > currently simply ignores this flag and continues which > yields in an unpredictable result. > > this patch catches all unknown flags and > aborts the loading of the vm. > > CC: qemu-st

[Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property

2014-06-10 Thread Stefan Hajnoczi
Up until now the virtio-blk x-data-plane and x-iothread features have been experimental. It's time to commit to a final command-line interface: qemu -object iothread,id=iothread0 \ -drive if=none,id=drive0,file=test.qcow2,format=qcow2 \ -device virtio-blk-pci,iothread=iothread0,dr

[Qemu-devel] [PATCH 2/3] qdev: drop iothread property type

2014-06-10 Thread Stefan Hajnoczi
The iothread property type is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi --- hw/core/qdev-properties-system.c | 50 include/hw/qdev-properties.h | 3 --- 2 files changed, 53 deletions(-) diff --git a/hw/core/qdev-properties-sy

[Qemu-devel] [PATCH 3/3] virtio-blk: remove need for explicit x-data-plane=on option

2014-06-10 Thread Stefan Hajnoczi
The x-data-plane=on|off option is no longer useful because the iothread= option conveys the same information plus which IOThread to use. Do not delete x-data-plane=on|off yet as a convenience to people using this legacy experimental option. We will drop it in QEMU 2.2. Instead, turn on data-plan

[Qemu-devel] [PATCH 1/3] virtio-blk: replace x-iothread with iothread link property

2014-06-10 Thread Stefan Hajnoczi
Up until now -device virtio-blk-pci,x-iothread= was used to assign an IOThread. This was a temporary solution while we cleaned up QOM link properties. This patch switches over to a QOM link property since it is now possible to restrict the setter to unrealized instances and automatically unref th

Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load

2014-06-10 Thread Peter Lieven
On 10.06.2014 10:45, Amit Shah wrote: On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote: if a saved vm has unknown flags in the memory data qemu currently simply ignores this flag and continues which yields in an unpredictable result. this patch catches all unknown flags and aborts the loadin

[Qemu-devel] [PATCH 0/3] dataplane: add query-blockstats support

2014-06-10 Thread Stefan Hajnoczi
This series adds blockstats support to virtio-blk data-plane and protects query-blockstats from races with the dataplane IOThread. Stefan Hajnoczi (3): dataplane: add bdrv_acct_*() accounting block: make bdrv_query_stats() static block: acquire AioContext is qmp_query_blockstats() block/qa

[Qemu-devel] [PATCH 3/3] block: acquire AioContext is qmp_query_blockstats()

2014-06-10 Thread Stefan Hajnoczi
Make query-blockstats safe for dataplane by acquiring the BlockDriverState's AioContext. This ensures that the dataplane IOThread and the main loop's monitor code do not race. Note the assumption that acquiring the drive's BDS AioContext also protects ->file and ->backing_hd. This assumption is

[Qemu-devel] [PATCH 1/3] dataplane: add bdrv_acct_*() accounting

2014-06-10 Thread Stefan Hajnoczi
bdrv_acct_start() and bdrv_acct_done() must be called in order to update block device accounting information. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/vi

[Qemu-devel] [PATCH 2/3] block: make bdrv_query_stats() static

2014-06-10 Thread Stefan Hajnoczi
This function is only called from block/qapi.c. There is no need to keep it public. Signed-off-by: Stefan Hajnoczi --- block/qapi.c | 2 +- include/block/qapi.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/block/qapi.c b/block/qapi.c index 97e1641..aeabaaf 100644

[Qemu-devel] [PATCH] checkpatch.pl: adjust typedef definition to QEMU coding style

2014-06-10 Thread Paolo Bonzini
Most QEMU typedefs are camelcase, starting with one uppercase letter and containing at least one lowercase letter. There are a few all-uppercase types, add the most common too. This fixes recognition of types in lines such as static __attribute__((unused)) inline void tcg_out8(TCGContext *s,

Re: [Qemu-devel] [50809c8] Attempt to boot a guest results in - qemu: could not load PC BIOS 'bios-256k.bin'

2014-06-10 Thread Paolo Bonzini
Il 08/06/2014 14:18, Kashyap Chamarthy ha scritto: Heya, I built QEMU from this commit: $ git log | head -2 commit 50809c8b9288a9bfe1fdec926b7ef985608a7ea6 Merge: 4e627ae ae74bbe And, attempted to boot a Fedora guest via this QEMU CLI results as below: $ /usr/local/sbin/qemu-

Re: [Qemu-devel] [PATCH v2 2/6] vga: Fix divide-by-zero in vga_update_text

2014-06-10 Thread Gonglei (Arei)
Hi, Gerd What's your opinion about this patch? Thanks, Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Wednesday, May 28, 2014 9:22 PM > To: qemu-devel@nongnu.org > Cc: av1...@comtv.ru; kra...@redhat.com; lcapitul...@redhat.com; > ler...@redhat.com; qiaonuo

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 10:30, Hu Tao ha scritto: On Tue, Jun 10, 2014 at 01:09:32AM -0400, Paolo Bonzini wrote: +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" how about naming it after what it really is? "memory-backend-hugepage" Later we could split it into generic superclass mmap-ed "memory

Re: [Qemu-devel] [PATCH 0/3] dataplane: add query-blockstats support

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 09:29, Stefan Hajnoczi ha scritto: This series adds blockstats support to virtio-blk data-plane and protects query-blockstats from races with the dataplane IOThread. Stefan Hajnoczi (3): dataplane: add bdrv_acct_*() accounting block: make bdrv_query_stats() static block: acqu

Re: [Qemu-devel] [PATCH 0/3] dataplane: introduce virtio-blk.iothread property

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 09:03, Stefan Hajnoczi ha scritto: Up until now the virtio-blk x-data-plane and x-iothread features have been experimental. It's time to commit to a final command-line interface: qemu -object iothread,id=iothread0 \ -drive if=none,id=drive0,file=test.qcow2,format=qcow2 \

Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load

2014-06-10 Thread Amit Shah
On (Tue) 10 Jun 2014 [10:47:56], Peter Lieven wrote: > On 10.06.2014 10:45, Amit Shah wrote: > >On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote: > >>if a saved vm has unknown flags in the memory data qemu > >>currently simply ignores this flag and continues which > >>yields in an unpredictable

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-10 Thread Igor Mammedov
On Tue, 10 Jun 2014 16:30:06 +0800 Hu Tao wrote: > On Tue, Jun 10, 2014 at 01:09:32AM -0400, Paolo Bonzini wrote: > > > > > > > +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" > > > > how about naming it after what it really is? "memory-backend-hugepage" > > > > Later we could split it i

Re: [Qemu-devel] [PATCH] qtest: fix qtest_clock_warp() for no deadline case

2014-06-10 Thread Sergey Fedorov
On 09.06.2014 21:36, Alex Bligh wrote: > On 9 Jun 2014, at 17:42, Sergey Fedorov wrote: > >> If there is no deadline across all timerlists attached to the clock >> then qemu_clock_deadline_ns_all() returns -1. Cast it to unsinged so >> MIN() do not treat it as minimum. >> >> Signed-off-by: Sergey F

[Qemu-devel] [PATCH] qtest: fix qtest_clock_warp() for no deadline case

2014-06-10 Thread Sergey Fedorov
Use dedicated qemu_soonest_timeout() instead of MIN(). Signed-off-by: Sergey Fedorov --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index dd7ac13..af06dc0 100644 --- a/cpus.c +++ b/cpus.c @@ -347,7 +347,7 @@ void qtest_clock_warp(int64_t dest)

Re: [Qemu-devel] [50809c8] Attempt to boot a guest results in - qemu: could not load PC BIOS 'bios-256k.bin'

2014-06-10 Thread Kashyap Chamarthy
On Tue, Jun 10, 2014 at 10:55:13AM +0200, Paolo Bonzini wrote: > Il 08/06/2014 14:18, Kashyap Chamarthy ha scritto: [. . .] > > QEMU's "make install" should have installed the firmware blobs in > /usr/share/local/qemu, including bios-256k.bin. Did it? Yes it did. I just tested it by providing

[Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fini_out()

2014-06-10 Thread arei.gonglei
From: Gonglei Spotted by Coverity: (8) Event freed_arg: "fclose(FILE *)" frees "wav->f". (9) Event cond_true: Condition "fclose(wav->f)", taking true branch Also see events: [pass_freed_arg] 212 if (fclose (wav->f)) { (10) Event pass_freed_arg: Passing freed pointer "wav->f" as an

[Qemu-devel] [PATCH v3 1/4] json-parser: drop superfluous assignment for token variable

2014-06-10 Thread arei.gonglei
From: Gonglei Signed-off-by: ChenLiang Signed-off-by: Gonglei --- qobject/json-parser.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/qobject/json-parser.c b/qobject/json-parser.c index e46c264..4288267 100644 --- a/qobject/json-parser.c +++ b/qobject/jso

[Qemu-devel] [PATCH v3 2/4] qemu-bridge-helper: Fix fd leak in main()

2014-06-10 Thread arei.gonglei
From: Gonglei initialize fd and ctlfd, and close them at the end Signed-off-by: Gonglei --- qemu-bridge-helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c index 6a0974e..36eb3bc 100644 --- a/qemu-bridge-helper.c +++

[Qemu-devel] [PATCH v3 4/4] vga: Fix divide-by-zero in vga_update_text

2014-06-10 Thread arei.gonglei
From: Gonglei Spotted by Coverity: (20) Event cond_true: Condition "cursor_visible", taking true branch (21) Event cond_true: Condition "cursor_offset < size", taking true branch (22) Event cond_true: Condition "cursor_offset >= 0", taking true branch 2097if (cursor_visible && cursor_off

[Qemu-devel] [PATCH v3 0/4] Fix some errors spotted by Coverity

2014-06-10 Thread arei.gonglei
From: Gonglei Fix some errors spotted by Coverity. Changes since v2: * remove a duplicate patch about block * fix changelog about json-parser suggested by Luiz * remove a patch which have been applied about vnc. Changes since v1: * rebase on Laszlo's patch set about dump * remove a patch f

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-10 Thread Hu Tao
On Tue, Jun 10, 2014 at 10:56:42AM +0200, Paolo Bonzini wrote: > Il 10/06/2014 10:30, Hu Tao ha scritto: > >On Tue, Jun 10, 2014 at 01:09:32AM -0400, Paolo Bonzini wrote: > >> > >+#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" > how about naming it after what it really is? "memory-b

Re: [Qemu-devel] [PATCH v2] rdma: Fix block during rdma migration

2014-06-10 Thread Gonglei (Arei)
> -Original Message- > From: Amit Shah [mailto:amit.s...@redhat.com] > Sent: Tuesday, June 10, 2014 3:20 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; yamah...@private.email.ne.jp; Huangweidong > (C); quint...@redhat.com; m...@tls.msk.ru; owass...@redhat.com; > mrhi...@us.ibm.com; Mo

[Qemu-devel] [PATCHv4] migration: catch unknown flags in ram_load

2014-06-10 Thread Peter Lieven
if a saved vm has unknown flags in the memory data qemu currently simply ignores this flag and continues which yields in an unpredictable result. This patch catches all unknown flags and aborts the loading of the vm. Additionally error reports are thrown if the migration aborts abnormally. Signed

Re: [Qemu-devel] [PATCHv3] migration: catch unknown flags in ram_load

2014-06-10 Thread Juan Quintela
Peter Lieven wrote: > On 10.06.2014 10:45, Amit Shah wrote: >> On (Tue) 10 Jun 2014 [10:04:23], Peter Lieven wrote: >>> if a saved vm has unknown flags in the memory data qemu >>> currently simply ignores this flag and continues which >>> yields in an unpredictable result. >>> >>> this patch catch

Re: [Qemu-devel] [Bug 1324112] [NEW] qemu parallel building error on libcacard.la

2014-06-10 Thread tal zilcer
I didn’t mention it but im building qemu out of the source tree(running the configure in a different directory). I tried to find the missing dependency but no luck. The build error keeps happening Here is the end of the log(please note that I don’t see here "CC trace/generated-events.o"):. lt CC

Re: [Qemu-devel] [PATCH v4 24/29] Introduce signed range.

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 02:51:49PM +0800, Hu Tao wrote: > On Mon, Jun 09, 2014 at 01:59:04PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 09, 2014 at 11:42:14AM +0100, Peter Maydell wrote: > > > On 9 June 2014 11:25, Hu Tao wrote: > > > > Signed-off-by: Hu Tao > > > > --- > > > > include/qem

Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements

2014-06-10 Thread Hu Tao
On Mon, Jun 09, 2014 at 02:40:30PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 09, 2014 at 01:30:05PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 09, 2014 at 06:25:05PM +0800, Hu Tao wrote: > > > note: this series is based on MST's pci tree. > > > > No, please rebase on top of numa branch

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 11:07:35AM +0200, Igor Mammedov wrote: > On Tue, 10 Jun 2014 16:30:06 +0800 > Hu Tao wrote: > > > On Tue, Jun 10, 2014 at 01:09:32AM -0400, Paolo Bonzini wrote: > > > > > > > > > +#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" > > > > > how about naming it after w

Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 05:51:48PM +0800, Hu Tao wrote: > On Mon, Jun 09, 2014 at 02:40:30PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 09, 2014 at 01:30:05PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Jun 09, 2014 at 06:25:05PM +0800, Hu Tao wrote: > > > > note: this series is based on M

Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements

2014-06-10 Thread Hu Tao
On Tue, Jun 10, 2014 at 12:56:56PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 05:51:48PM +0800, Hu Tao wrote: > > On Mon, Jun 09, 2014 at 02:40:30PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Jun 09, 2014 at 01:30:05PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Jun 09, 201

Re: [Qemu-devel] [PATCH v4 18/29] hostmem: add file-based HostMemoryBackend

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 10:56:42AM +0200, Paolo Bonzini wrote: > Il 10/06/2014 10:30, Hu Tao ha scritto: > >On Tue, Jun 10, 2014 at 01:09:32AM -0400, Paolo Bonzini wrote: > >> > >+#define TYPE_MEMORY_BACKEND_FILE "memory-backend-file" > how about naming it after what it really is? "memory-b

Re: [Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10

2014-06-10 Thread Peter Maydell
On 10 June 2014 06:56, Paolo Bonzini wrote: > The following changes since commit 7721a3044234c46cd6f5f899e7467dc9351f3c8d: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140609-1' into staging (2014-06-09 > 17:04:13 +0100) > > are available in the git repository at

[Qemu-devel] [PATCH v10-fix 15/18] Add the vhost-user netdev backend to the command line

2014-06-10 Thread Nikolay Nikolaev
The supplied chardev id will be inspected for supported options. Only a socket backend, with a set path (i.e. a Unix socket) and optionally the server parameter set, will be allowed. Other options (nowait, telnet) will make the chardev unusable and the netdev will not be initialised. Additional ch

[Qemu-devel] [PATCH v10-fix 18/18] Add qtest for vhost-user

2014-06-10 Thread Nikolay Nikolaev
This test creates a 'server' chardev to listen for vhost-user messages. Once VHOST_USER_SET_MEM_TABLE is received it mmaps each received region, and read 1k bytes from it. The read data is compared to data from readl. The test requires hugetlbfs to be already mounted and writable. The mount point

[Qemu-devel] [PATCH v10-fix 16/18] Add vhost-user protocol documentation

2014-06-10 Thread Nikolay Nikolaev
This document describes the basic message format used by vhost-user for communication over a unix domain socket. The protocol is based on the existing ioctl interface used for the kernel version of vhost. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- docs/specs/vhost-user.

Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fini_out()

2014-06-10 Thread Peter Maydell
On 10 June 2014 10:20, wrote: > From: Gonglei > > Spotted by Coverity: > > (8) Event freed_arg: "fclose(FILE *)" frees "wav->f". > (9) Event cond_true: Condition "fclose(wav->f)", taking true branch > Also see events: [pass_freed_arg] > > 212 if (fclose (wav->f)) { > (10) Event pass_

Re: [Qemu-devel] [PATCH V2 3/3] virtio-net: announce self by guest

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 11:50:33AM +0530, Amit Shah wrote: > On (Tue) 20 May 2014 [14:01:44], Jason Wang wrote: > > It's hard to track all mac addresses and their configurations (e.g > > vlan or ipv6) in qemu. Without this information, it's impossible to > > build proper garp packet after migration

Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements

2014-06-10 Thread Hu Tao
On Tue, Jun 10, 2014 at 12:56:56PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 05:51:48PM +0800, Hu Tao wrote: > > On Mon, Jun 09, 2014 at 02:40:30PM +0300, Michael S. Tsirkin wrote: > > > On Mon, Jun 09, 2014 at 01:30:05PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Jun 09, 201

Re: [Qemu-devel] [PATCH v10-fix 16/18] Add vhost-user protocol documentation

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 01:02:57PM +0300, Nikolay Nikolaev wrote: > This document describes the basic message format used by vhost-user > for communication over a unix domain socket. The protocol is based > on the existing ioctl interface used for the kernel version of vhost. > > Signed-off-by: An

Re: [Qemu-devel] Problems compiling HEAD on Mac OS X 10.9.2

2014-06-10 Thread Rainer Müller
On 2014-06-06 04:04, Fam Zheng wrote: >> Ugh. This was supposed to be fixed by commit 6295b98d7b767c. >> Fam, can you re-check your fix, please? >> > > I don't understand that fix now, looks like it was moved onto a wrong list. > > Rainer, does this below patch work for you? (we can't duplicate o

Re: [Qemu-devel] [PATCH v4 00/29] NUMA series and hostmem improvements

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 06:19:35PM +0800, Hu Tao wrote: > On Tue, Jun 10, 2014 at 12:56:56PM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 10, 2014 at 05:51:48PM +0800, Hu Tao wrote: > > > On Mon, Jun 09, 2014 at 02:40:30PM +0300, Michael S. Tsirkin wrote: > > > > On Mon, Jun 09, 2014 at 01:30:0

Re: [Qemu-devel] [PATCH v10-fix 15/18] Add the vhost-user netdev backend to the command line

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 01:02:16PM +0300, Nikolay Nikolaev wrote: > The supplied chardev id will be inspected for supported options. Only > a socket backend, with a set path (i.e. a Unix socket) and optionally > the server parameter set, will be allowed. Other options (nowait, telnet) > will make t

Re: [Qemu-devel] [PULL 00/10] s390 patches

2014-06-10 Thread Peter Maydell
available in the git repository at: > > > git://github.com/cohuck/qemu.git tags/s390x-20140610 > > for you to fetch changes up to bbd8bb8e3245cf6fc6d12b10b3320ab183adb866: > > s390x/kvm: inject via flic (2014-06-10 09:50:27 +0200) Applied, thanks. -- PMM

Re: [Qemu-devel] Problems compiling HEAD on Mac OS X 10.9.2

2014-06-10 Thread Fam Zheng
On Tue, 06/10 12:23, Rainer Müller wrote: > On 2014-06-06 04:04, Fam Zheng wrote: > >> Ugh. This was supposed to be fixed by commit 6295b98d7b767c. > >> Fam, can you re-check your fix, please? > >> > > > > I don't understand that fix now, looks like it was moved onto a wrong list. > > > > Rainer,

Re: [Qemu-devel] [PULL 6/8] rules.mak: Rewrite unnest-vars

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 07:56, Paolo Bonzini ha scritto: > +$(foreach v,$(filter %-m,$2), > +# All .o found in *-m variables are single object modules, create .mo > +# for them > +$(foreach o,$(filter %.o,$($v)), > +$(eval $(o:%.o=%.mo)-objs := $o)) > +# Now un

Re: [Qemu-devel] [PATCH v10-fix 18/18] Add qtest for vhost-user

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 01:03:23PM +0300, Nikolay Nikolaev wrote: > This test creates a 'server' chardev to listen for vhost-user messages. > Once VHOST_USER_SET_MEM_TABLE is received it mmaps each received region, > and read 1k bytes from it. The read data is compared to data from readl. > > The

Re: [Qemu-devel] [PATCH v10-fix 15/18] Add the vhost-user netdev backend to the command line

2014-06-10 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 01:34:13PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 01:02:16PM +0300, Nikolay Nikolaev wrote: > > The supplied chardev id will be inspected for supported options. Only > > a socket backend, with a set path (i.e. a Unix socket) and optionally > > the server

[Qemu-devel] [PULL 0/2] console patches

2014-06-10 Thread Gerd Hoffmann
Hi, Two little console bugfixes. please pull, Gerd The following changes since commit 7b0140e49b1c239c880c90235548917086f53cdc: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20140610' into staging (2014-06-10 10:59:26 +0100) are available in the git repository a

[Qemu-devel] [PULL 1/2] console: kill MAX_CONSOLES, alloc consoles dynamically

2014-06-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/console.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/ui/console.c b/ui/console.c index 2ce55a6..b5dac64 100644 --- a/ui/console.c +++ b/ui/console.c @@ -30,7 +30,6 @@ #include "trace.h" #define DEFAULT_BACKSCROLL 512 -

Re: [Qemu-devel] [PATCH] qtest: fix qtest_clock_warp() for no deadline case

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 11:10, Sergey Fedorov ha scritto: Use dedicated qemu_soonest_timeout() instead of MIN(). Signed-off-by: Sergey Fedorov --- cpus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index dd7ac13..af06dc0 100644 --- a/cpus.c +++ b/cpus.c @@ -347,7

[Qemu-devel] [PULL 2/2] console: fix -vga none -sdl crash

2014-06-10 Thread Gerd Hoffmann
Call get_alloc_displaystate() for proper initialization instead of allocating with g_new(). Signed-off-by: Gerd Hoffmann --- ui/console.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ui/console.c b/ui/console.c index b5dac64..7dc4c14 100644 --- a/ui/console.c +++ b/ui/

Re: [Qemu-devel] [PATCH 0/2] pc: memory hotplug fixes

2014-06-10 Thread Michael S. Tsirkin
On Mon, Jun 09, 2014 at 07:27:59PM +0200, Igor Mammedov wrote: > Series is build on mst/pci tree that includes memory hotplug bits. > > patch 2/2, fixes incorrect address auto-allocation caused by wrong > sorting order due to overflow in pc_dimm_addr_sort() comparator. > > Test-case is to build q

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v10-fix 15/18] Add the vhost-user netdev backend to the command line

2014-06-10 Thread Nikolay Nikolaev
Hello, On Tue, Jun 10, 2014 at 1:50 PM, Michael S. Tsirkin wrote: > > On Tue, Jun 10, 2014 at 01:34:13PM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 10, 2014 at 01:02:16PM +0300, Nikolay Nikolaev wrote: > > > The supplied chardev id will be inspected for supported options. Only > > > a sock

  1   2   3   4   >