Eric Blake writes:
> On 06/04/2014 08:09 PM, Fam Zheng wrote:
>
>>> Sounds like we have an off-by-one condition if empty files behave
>>> differently from other files. We ought to fix that bug (not that your
>>> normal guest will ever have a 0-length backing file, but this was what I
>>> was try
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Amos Kong
> Sent: Thursday, June 05, 2014 1:45 PM
> To: qemu-devel@nongnu.org
> Cc: stefa...@gmail.com; afaer...@suse.de; m...@r
Il 05/06/2014 08:09, sonia verma ha scritto:
Hi Paolo
I'm running this on ubuntu with powerpc arch with kernel
3.8.13-rt9-QorIQ-SDK-V1.4.
I'll note that this is a fairly old kernel for PowerPC KVM. However,
the problem looks like libguestfs supporting only "server" PowerPC (also
known as "b
So what can be the solution for this?
On Thu, Jun 5, 2014 at 1:13 PM, Paolo Bonzini wrote:
> Il 05/06/2014 08:09, sonia verma ha scritto:
>
> Hi Paolo
>>
>> I'm running this on ubuntu with powerpc arch with kernel
>> 3.8.13-rt9-QorIQ-SDK-V1.4.
>>
>
> I'll note that this is a fairly old kernel
On Wed, Jun 04, 2014 at 05:31:48PM +0200, Peter Lieven wrote:
> Am 04.06.2014 17:12, schrieb Stefan Hajnoczi:
> > On Fri, May 30, 2014 at 11:40:37PM +0200, Peter Lieven wrote:
> >> this patch introduces a new flag to indicate that we are going to
> >> sequentially
> >> read from a file and do not
> Am 05.06.2014 um 09:45 schrieb sonia verma :
>
>
> So what can be the solution for this?
Please don't top post.
You're running on QorIQ which is a Freescale chip. The pseries target only
works on IBM PPC chips.
The target you're looking for is ppce500:
$ qemu-system-ppc64 -M ppce500 -n
Chaos Shu writes:
> Hi
>
> I'm running SPEC CPU2006 on three kinds of situation, native aarch64 binary
> and emulator x86_64 system running SPEC CPU2006 and linux user mode level
> running x86_64 SPEC CPU2006 binary.
>
> To find where the performance lose, translator ? or execution of instructi
On 05.06.2014 09:53, Stefan Hajnoczi wrote:
On Wed, Jun 04, 2014 at 05:31:48PM +0200, Peter Lieven wrote:
Am 04.06.2014 17:12, schrieb Stefan Hajnoczi:
On Fri, May 30, 2014 at 11:40:37PM +0200, Peter Lieven wrote:
this patch introduces a new flag to indicate that we are going to sequentially
r
Am 05.06.2014 um 10:09 hat Peter Lieven geschrieben:
> On 05.06.2014 09:53, Stefan Hajnoczi wrote:
> >On Wed, Jun 04, 2014 at 05:31:48PM +0200, Peter Lieven wrote:
> >>Am 04.06.2014 17:12, schrieb Stefan Hajnoczi:
> >>>On Fri, May 30, 2014 at 11:40:37PM +0200, Peter Lieven wrote:
> this patch i
On Wed, Jun 04, 2014 at 08:02:06PM +0200, Paolo Bonzini wrote:
> Il 04/06/2014 14:37, Stefan Hajnoczi ha scritto:
> >Why is this design cleaner? Because NBD code doesn't have to worry
> >about fd handlers. It uses straightforward coroutine send/recv for
> >socket I/O inside nbd_read_req() and nbd
Am 05.06.2014 um 09:06 hat Markus Armbruster geschrieben:
> Eric Blake writes:
>
> > On 06/04/2014 08:09 PM, Fam Zheng wrote:
> >
> >>> Sounds like we have an off-by-one condition if empty files behave
> >>> differently from other files. We ought to fix that bug (not that your
> >>> normal guest
There is a change in qemu-io sub-commands "aio_read" and "aio_write", which
makes the aio requests accounted and the statistics reflected in blockstats.
Note that IO throttling implementation allows overcommiting of requests, so the
actual IO happened in a time unit may be a bit larger than given
This will enable accounting of aio requests issued from qemu-io aio
read/write commands.
Signed-off-by: Fam Zheng
Reviewed-by: Benoit Canet
---
qemu-io-cmds.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 60c1ceb..ae6c299 100644
--- a/qemu
This removes the dummy scripts/qtest and adds scripts/qtest/qtest.py as
a python library for qtest protocol.
This is a skeleton with a basic "cmd" method to execute a command,
reading and parsing of qtest output will be added later on demand.
Signed-off-by: Fam Zheng
Reviewed-by: Benoit Canet
-
This will allow test case to run command in qtest protocol. It's
write-only for now.
Signed-off-by: Fam Zheng
Reviewed-by: Benoit Canet
---
tests/qemu-iotests/iotests.py | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/
On Wed, Jun 4, 2014 at 6:26 PM, Stefan Hajnoczi wrote:
> On Sat, May 31, 2014 at 01:56:46PM +0400, Maria Kustova wrote:
>
> Please add a --format qcow2 (or maybe --image-generator) option using
> __import__() to load the image generator module. That way people can
> drop in new image generator mo
This case utilizes qemu-io command "aio_{read,write} -a -q" to verify
the effectiveness of IO throttling options.
The "-a" option will cause qemu-io requests to be accounted.
It's implemented by driving the vm timer from qtest protocol, so the
throttling timers are signaled with determinied time
QMP command "block_set_io_throttle" expects underscores in parameters
instead of dashes: {iops,bps}_{rd,wr,max}.
Add optional argument conv_keys (defaults to True, backward compatible),
it will be used in IO throttling test case.
Reviewed-by: Benoit Canet
Signed-off-by: Fam Zheng
---
tests/qem
04.06.2014 18:00, ronnie sahlberg wrote:
> That would mean you get to use the 10 version of the cdb even for very
> large devices (as long as the IO is for blocks at the beginning of the
> device) and thus provide partial avoidance of this issue for those
> large devices.
That may make some bugs "
On Thu, 06/05 06:09, Paolo Bonzini wrote:
> Il 05/06/2014 05:50, Fam Zheng ha scritto:
> >>> Can you try moving the req allocation and assignments inside
> >>> process_request
> >>> instead? Then you can fill in req->out directly without the struct
> >>> assignment.
> >>>
> >The owners of req are
In later patch, qemu_opt_get_del functions will be added, they will
first get the option value, then call qemu_opt_del to remove the option
from opt list. To prepare for that purpose, move qemu_opt_del ahead first.
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Chunyan Liu
qemu_opt_del() already assumes that all QemuOpt instances contain
malloc'd name and value; but it had to cast away const because
opts_start_struct() was doing its own thing and using static storage
instead. By using the correct type and malloced strings everywhere, the
usage of this struct becomes
Add def_value_str (default value) to QemuOptDesc, to replace function of the
default value in QEMUOptionParameter.
Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise,
if desc->def_value_str is set, return desc->def_value_str; otherwise, return
input defval.
Improve qemu_op
Kevin Wolf writes:
> Am 05.06.2014 um 09:06 hat Markus Armbruster geschrieben:
>> Eric Blake writes:
>>
>> > On 06/04/2014 08:09 PM, Fam Zheng wrote:
>> >
>> >>> Sounds like we have an off-by-one condition if empty files behave
>> >>> differently from other files. We ought to fix that bug (not
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/iscsi.c | 34 --
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 3892cc5..76d4623 100644
--- a/block/iscsi.c
+++ b/bl
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
qapi-schema.json | 5 -
qmp-commands.hx| 2
Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
qemu_opt_get_size_del to replace the same handling of QEMUOptionParameter
(get and delete).
Several drivers are coded to parse a known subset of options, then
remove them from the list before handing all remaining options to
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Signed-off-by: Chunyan Liu
---
util/qemu-option.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 324e4c5..c188c5c 100644
--- a/util/qemu-option.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/qcow.c | 72 ++--
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 32651eb..bcacfb8 100644
--- a
Add two temp conversion functions between QEMUOptionParameter to QemuOpts,
so that next patch can use it. It will simplify later patch for easier
review. And will be finally removed after all backend drivers switch to
QemuOpts.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Le
For later merge .create_opts of drv and proto_drv in qemu-img commands.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Chunyan Liu
---
include/qemu/option.h | 5
util/qemu-option.c| 67
To simplify later using of qemu_opts_del, accept NULL input.
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Chunyan Liu
---
util/qemu-option.c | 4
1 file changed, 4 insertions(+)
diff --git a/util/qemu-option.c b/util/qemu-option.c
inde
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Signed-off-by: Chunyan Liu
---
block/nfs.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/block/nfs.c b/block/nfs.c
index 539bd95..20a90e2 100644
--- a/block/nfs.c
+++ b/block/nfs.c
@@ -361,20 +361,14 @@ stat
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/gluster.c | 81 ++---
1 file changed, 42 insertions(+), 39 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
inde
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/sheepdog.c | 111 ---
1 file changed, 56 insertions(+), 55 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 4ecbf5f..c971117 1006
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
Changes:
* same as v27
* changes to v26:
split v26 qcow2.c patch into two, move qemu_opt_find to a separate patch.
block/qcow2.c | 261 +++---
1 file changed, 139 insertions(+)
Change block layer to support both QemuOpts and QEMUOptionParameter.
After this patch, it will change backend drivers one by one. At the end,
QEMUOptionParameter will be removed and only QemuOpts is kept.
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
Reviewed-by: Eric Blake
---
block.
vvfat shares create options of qcow driver. To avoid vvfat breaking when
qcow driver changes from QEMUOptionParameter to QemuOpts, let it able
to handle both cases.
Signed-off-by: Chunyan Liu
Reviewed-by: Eric Blake
---
block/vvfat.c | 24 +---
1 file changed, 17 insertions(
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/vdi.c | 73 +
1 file changed, 35 insertions(+), 38 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index 27737af..fe5cad2 100644
--- a/b
One extra change is to define QED_DEFAULT_CLUSTER_SIZE = 65536 instead
of 64 * 1024; because:
according to existing create_options, "cluster size" has default value =
QED_DEFAULT_CLUSTER_SIZE, after switching to create_opts, this has to be
stringized and set to .def_value_str. That is,
.def_value
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/rbd.c | 63 +
1 file changed, 30 insertions(+), 33 deletions(-)
diff --git a/block/rbd.c b/block/rbd.c
index 09af484..d7f22af 100644
--- a/b
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/cow.c | 54 ++
1 file changed, 26 insertions(+), 28 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 7e61024..af85
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/vhdx.c | 99 +---
block/vhdx.h | 1 +
2 files changed, 48 insertions(+), 52 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index ca7d533
Export qemu_opt_find for qcow2 driver using it.
After replacing QEMUOptionParameter with QemuOpts, qcow2 driver will
use qemu_opt_find to judge if an option is explicitly set, to replace
the usage of .assigned in QEMUOptionParameter.
Signed-off-by: Chunyan Liu
---
Changes:
* same as v27.
* ch
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/ssh.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index b212971..b6d55bc 100644
--- a/block/ssh.c
+++ b/block/ssh.c
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/vpc.c | 62 +
1 file changed, 34 insertions(+), 28 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 2e25f57..8ebf424 100644
--- a/b
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/raw-win32.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 064ea31..e5ac297 100644
--- a/block/
On 30.05.2014 11:05, Paolo Bonzini wrote:
Il 30/05/2014 11:04, Peter Lieven ha scritto:
Am 30.05.2014 07:50, schrieb Paolo Bonzini:
Il 29/05/2014 22:25, Peter Lieven ha scritto:
Am 29.05.2014 21:17, schrieb Paolo Bonzini:
Il 29/05/2014 20:41, Peter Lieven ha scritto:
static inline unsigned g
Now that all backend drivers are using QemuOpts, remove all
QEMUOptionParameter related codes.
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block.c | 93 ++
block/cow.c | 4 +-
block/gluster.c | 8 +-
block/iscsi.c
On Thu, Jun 05, 2014 at 01:45:16PM +0800, Amos Kong wrote:
> Signed-off-by: Amos Kong
> ---
> tests/libqtest.c | 16
> tests/libqtest.h | 8
> 2 files changed, 24 insertions(+)
>
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 71468ac..ceb1734 100644
> --- a
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/vmdk.c | 123 ++-
1 file changed, 63 insertions(+), 60 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 79d55b0..78d7312 100644
--- a
On Thu, Jun 05, 2014 at 01:45:17PM +0800, Amos Kong wrote:
> This patch adds a new subtest, it hotplugs 29 * 8 = 232 virtio-blk
> devices to guest, and try to hot-unplug them.
>
> Note: the hot-unplug can't work without cooperation of guest OS.
>
> Signed-off-by: Amos Kong
> ---
> tests/virtio-
On Thu, Jun 05, 2014 at 01:45:18PM +0800, Amos Kong wrote:
> Signed-off-by: Amos Kong
> ---
> tests/blockdev-test.c | 23 ++-
> 1 file changed, 2 insertions(+), 21 deletions(-)
Reviewed-by: Stefan Hajnoczi
We tell the guest its page size via AUX vectors. The guest process then uses
this page size as information on which boundaries it can mmap() things.
However, if the host has a bigger page size granularity than the guest, it can
not fulfill these mmap() requests - which falls apart when MAP_FIXED i
Currently this function is not used anywhere. In later patches, it will
replace print_option_parameters. To avoid print info changes, change
qemu_opts_print from fprintf stderr to printf, and remove last printf.
Signed-off-by: Chunyan Liu
Reviewed-by: Eric Blake
---
include/qemu/option.h | 2 +
Il 05/06/2014 11:29, Peter Lieven ha scritto:
It might be that we need a LIBS+= -lm to the Makefile in the root
directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.
cat > $TMPC << EOF
#include
int main(void) { return isnan(sin(0.0)); }
EOF
if compile_prog "" "" ; then
:
On 5 June 2014 00:36, Alexey Kardashevskiy wrote:
> I'd rather remove return value at all, my mistake, I cannot see how NMI
> handler can possibly fail - noone can mask it after all :) If callback
> exists, I just call it and that's it. If it does not exist, it is
> "unsupported" and that's it. Wo
On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote:
> Il 05/06/2014 00:33, Hani Benhabiles ha scritto:
> >> IIUC, what this does is ensure that the other side gets a FIN before it
> >> gets
> >> a RST. Is this correct?
> >
> >Yes. Without shutdown(), this could be reproduced (unreliabl
This patch changes some readfns/writefns to use raw_write
and raw_read functions, which use the fieldoffset specified
in ARMCPRegInfo instead of directly accessing the field.
This will simplify patches for EL3 & Security Extensions.
Reviewed-by: Peter Crosthwaite
Signed-off-by: Fabian Aggeler
--
Il 05/06/2014 10:12, Stefan Hajnoczi ha scritto:
On Wed, Jun 04, 2014 at 08:02:06PM +0200, Paolo Bonzini wrote:
Il 04/06/2014 14:37, Stefan Hajnoczi ha scritto:
Why is this design cleaner? Because NBD code doesn't have to worry
about fd handlers. It uses straightforward coroutine send/recv fo
On Fri, 30 May 2014 09:44:20 -0600
Eric Blake wrote:
> On 05/30/2014 09:39 AM, Igor Mammedov wrote:
>
> >>> +# @source_event: Arg0 - An Integer containing the source event
> >>> +#
> >>> +# @status_code: Arg1 – An Integer containing the status code
> >>
>
> >>> +{ 'type': 'ACPIOSTInfo',
> >>> +
print_option_help takes QEMUOptionParameter as parameter, add
qemu_opts_print_help to take QemuOptsList as parameter for later
replace work.
Reviewed-by: Eric Blake
Reviewed-by: Leandro Dorileo
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
include/qemu/option.h | 1 +
util/qemu-
On 05.06.2014 11:44, Paolo Bonzini wrote:
Il 05/06/2014 11:29, Peter Lieven ha scritto:
It might be that we need a LIBS+= -lm to the Makefile in the root
directory. I had strange problems when linking qemu-img/qemu-io/qemu-nbd.
cat > $TMPC << EOF
#include
int main(void) { return isnan(sin(0.
This patch series is to replace QEMUOptionParameter with QemuOpts, so that only
one Qemu Option structure is kept in QEMU code.
---
Changes to v27:
* rebase to git master (code has been updated in this part since v27 sent
so rebase to make the patch series work.)
All patches are also availa
Il 05/06/2014 11:58, Hani Benhabiles ha scritto:
On Thu, Jun 05, 2014 at 03:55:40AM +0200, Paolo Bonzini wrote:
Il 05/06/2014 00:33, Hani Benhabiles ha scritto:
IIUC, what this does is ensure that the other side gets a FIN before it gets
a RST. Is this correct?
Yes. Without shutdown(), this
Il 05/06/2014 07:33, Paul Janzen ha scritto:
In scsi-disk.c, if you #define DEBUG_SCSI=1, you get:
hw/scsi/scsi-disk.c: In function 'scsi_disk_emulate_command':
hw/scsi/scsi-disk.c:2018: error: 'SCSIRequest' has no member named 'buf'
Change the debugging statement to match the actual value teste
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/raw-posix.c | 59 +--
1 file changed, 27 insertions(+), 32 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index b7f0f26..e0a75db 10
Corrected handling of writes to TTBCR for ARMv8 (previously UNK/SBZP
bits are not RES0) and ARMv7 (new bits PD0/PD1 for CPUs with Security
Extensions).
Bits PD0/PD1 are now respected in get_phys_addr_v6/v5() and
get_level1_table_address.
Signed-off-by: Fabian Aggeler
---
v1 -> v2:
* dropped chan
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Dong Xu Wang
Signed-off-by: Chunyan Liu
---
block/raw_bsd.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 9ae5fc2..ee797fd 100644
--- a/block/raw_bsd.c
+++ b/b
Now only qemu_opts_append uses 'allocated' to indicate free memory.
For this function only, we can also let result list's (const char *)
members point to input list's members, only if the input list has
longer lifetime than result list. In current code, that is true.
So, we can remove the 'allocate
On 05.06.2014 11:12, Michael Tokarev wrote:
04.06.2014 18:00, ronnie sahlberg wrote:
That would mean you get to use the 10 version of the cdb even for very
large devices (as long as the IO is for blocks at the beginning of the
device) and thus provide partial avoidance of this issue for those
la
Il 04/06/2014 19:52, mtosa...@redhat.com ha scritto:
Allowing addition of a link without keeping pointer-to-pointer.
Signed-off-by: Marcelo Tosatti
---
include/qom/object.h | 13 +
qom/object.c | 73 +--
2 files changed, 72 i
On Thu, Jun 05, 2014 at 11:42:34AM +0800, Fam Zheng wrote:
> diff --git a/block/mirror.c b/block/mirror.c
> index 94c8661..2bef5f3 100644
> --- a/block/mirror.c
> +++ b/block/mirror.c
> @@ -324,9 +324,18 @@ static void coroutine_fn mirror_run(void *opaque)
> }
>
> s->common.len = bdrv_g
On Thu, Jun 05, 2014 at 11:42:35AM +0800, Fam Zheng wrote:
> @@ -48,8 +49,11 @@ class ImageCommitTestCase(iotests.QMPTestCase):
> self.assert_qmp(event, 'data/device', 'drive0')
> self.assert_qmp(event, 'data/offset', self.image_len)
>
Both Marcelo's rtc patches and Peter's MemoryRegion patches showed
the interest in having link properties with a custom representation
and/or a different way to store the property.
Such properties would still be link<>s for the outside world, but
the internal implementation in QEMU would be differ
Similar to object_property_add_link, alias properties provide an
alternative, non-canonical path to an object. In fact, external
observers cannot distinguish alias properties from other links.
Aliases differ from links in that they are immutable and typically
managed by the target of the alias i
It may be desirable to have custom link<> properties that do more
than just store an object. Even the addition of a "check"
function is not enough if setting the link has side effects
or if a non-standard reference counting is preferrable.
Avoid the assumption that the opaque field of a link<> is
Il 05/06/2014 13:17, Stefan Hajnoczi ha scritto:
On Thu, Jun 05, 2014 at 11:42:34AM +0800, Fam Zheng wrote:
diff --git a/block/mirror.c b/block/mirror.c
index 94c8661..2bef5f3 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -324,9 +324,18 @@ static void coroutine_fn mirror_run(void *opaque)
On Thu, Jun 05, 2014 at 11:42:36AM +0800, Fam Zheng wrote:
> +class TestSingleDriveZeroLength(TestSingleDrive):
> +def setUp(self):
> +TestSingleDrive.image_len = 0
> +return TestSingleDrive.setUp(self)
This is buggy since it assigns to TestSingleDrive.image_len. It
modifies t
in v2:
squash commits [Stefan]
Get rid of dependency on quorum maintainance series [Stefan]
Add proper GPL V2 license in headers [Eric]
Benoît Canet (5):
qapi: Extract qapi/common.json definitions
qapi: create two block related json modules
qapi: Extract qapi/block-co
Signed-off-by: Benoit Canet
---
qapi-schema.json | 4
qapi/block-core.json | 4
qapi/block.json | 4
qapi/common.json | 4
4 files changed, 16 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index 14b498b..870d3f6 100644
--- a/qapi-schema.json
+++
Signed-off-by: Benoit Canet
---
qapi-schema.json | 87 ++
qapi/common.json | 89
2 files changed, 91 insertions(+), 85 deletions(-)
create mode 100644 qapi/common.json
diff --git a/qapi-
Signed-off-by: Benoit Canet
---
qapi-schema.json | 159 ---
qapi/block.json | 159 +++
2 files changed, 159 insertions(+), 159 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
in
qapi/block-core.json contains block definitions unrelated to emulation.
qapi/block.json is a superset of the previous and contains definitions related
to emulation.
The purpose of these extractions is to be able to hook qapi/block-core.json
generated code on qemu-nbd.
Signed-off-by: Benoit Canet
On Mon, 2014-06-02 at 12:21 -0300, Eduardo Habkost wrote:
> On Sun, Jun 01, 2014 at 11:21:49AM +0300, Marcel Apfelbaum wrote:
> > On Fri, 2014-05-30 at 16:25 -0300, Eduardo Habkost wrote:
> > > On Mon, May 26, 2014 at 03:40:58PM +0300, Marcel Apfelbaum wrote:
> > > [...]
> > > > +static void machin
The Wednesday 04 Jun 2014 à 09:51:12 (-0400), Jeff Cody wrote :
> This allows a user to make a live change to the backing file recorded in
> an open image.
>
> The image file to modify can be specified 2 ways:
>
> 1) image filename
> 2) image node-name
>
> Note: this does not cause the backing f
On 05.06.14 08:53, Gavin Shan wrote:
The emulation for EEH RTAS requests from guest isn't covered
by QEMU yet and the patch implements them.
The patch defines constants used by EEH RTAS calls and adds
callback sPAPRPHBClass::eeh_handler, which is going to be used
this way:
1. RTAS calls are re
On 05.06.14 08:53, Gavin Shan wrote:
The patch introduces helper function vfio_pci_container_ioctl() to
pass ioctl commands to the specified VFIO container that is identified
by IOMMU group id. On sPAPR platform, each container only has one
IOMMU group.
Signed-off-by: Gavin Shan
---
hw/misc/
On 05.06.14 08:53, Gavin Shan wrote:
The series of patches adds support EEH for VFIO PCI devices on sPAPR platform.
It requires corresponding host kernel support. Also, it is based on top of
Alexey's VFIO-for-sPAPR git repository.
QEMU: git://github.com/aik/qemu.git (branch: vfio)
Kernel: git
The block layer fails such reads and writes just fine. However, they
then get treated like valid operations that fail: the error action
gets executed. Unwanted; reporting the error to the guest is the only
sensible action.
Reject them before passing them to the block layer. This bypasses the
er
When a device model's I/O operation fails, we execute the error
action. This lets layers above QEMU implement thin provisioning, or
attempt to correct errors before they reach the guest. But when the
I/O operation fails because its invalid, reporting the error to the
guest is the only sensible ac
When a device model's I/O operation fails, we execute the error
action. This lets layers above QEMU implement thin provisioning, or
attempt to correct errors before they reach the guest. But when the
I/O operation fails because its invalid, reporting the error to the
guest is the only sensible ac
Signed-off-by: Markus Armbruster
---
hw/block/virtio-blk.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 8a568e5..f2b4dca 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -281,6 +
This file holds some functions that do not need to be generated.
Signed-off-by: Wenchao Xia
Reviewed-by: Eric Blake
---
include/qapi/qmp-event.h | 27 +
qapi/Makefile.objs |1 +
qapi/qmp-event.c | 74 ++
3 files c
The Tuesday 29 Apr 2014 à 08:21:16 (+0200), Stefan Weil wrote :
> Those options were not enabled by default, even when the build
> environment would have supported them, so the corresponding
> code was not compiled in normal test builds like on build bots.
>
> Signed-off-by: Stefan Weil
> ---
>
qapi-event.py will parse the schema and generate qapi-event.c, then
the API in qapi-event.c can be used to handle event in qemu code.
All API have prefix "qapi_event".
The script mainly includes two parts: generate API for each event
define, generate an enum type for all defined events.
Since in
This series add support for tag/keyword 'event' in qapi-schema.
A new file was created to store some helper functions in patch 2, patch 4 is
the test case, patch 5 is a convert example.
The implemention is done by generate API and a batch of parameters for each
event define, it doesn't generate a
This patch also eliminates build time warning caused by
QAPI_EVENT_MAX = 0.
Signed-off-by: Wenchao Xia
---
docs/qmp/qmp-events.txt | 15 ---
qapi-event.json | 12
vl.c|3 ++-
3 files changed, 14 insertions(+), 16 deletions(-)
diff --g
These cases will verify whether the expected qdict is built.
Signed-off-by: Wenchao Xia
---
tests/Makefile | 16 ++-
tests/qapi-schema/qapi-schema-test.json | 12 ++
tests/qapi-schema/qapi-schema-test.out | 10 +-
tests/test-qmp-event.c | 265 +++
Signed-off-by: Wenchao Xia
---
docs/qmp/qmp-events.txt | 12
qapi-event.json |9 +
vl.c|2 +-
3 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
index c241a07..cda67d4 100644
1 - 100 of 424 matches
Mail list logo
