On Fri, 2014-05-30 at 16:45 -0300, Eduardo Habkost wrote:
> On Mon, May 26, 2014 at 03:40:58PM +0300, Marcel Apfelbaum wrote:
> > Make machine's QemuOpts QOM properties of machine. The properties
> > are automatically filled in. This opens the possiblity to create
> > opts per machine rather than g
On Fri, 2014-05-30 at 16:25 -0300, Eduardo Habkost wrote:
> On Mon, May 26, 2014 at 03:40:58PM +0300, Marcel Apfelbaum wrote:
> [...]
> > +static void machine_initfn(Object *obj)
> > +{
> > +object_property_add_str(obj, "accel",
> > +machine_get_accel, machine_set_ac
On Fri, 2014-05-30 at 17:02 -0300, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost
> ---
> Cc: Marcel Apfelbaum
> Cc: Andreas Färber
> ---
> hw/core/machine.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index cbba679..df612bb
On Fri, 2014-05-30 at 17:41 -0300, Eduardo Habkost wrote:
> The kvm-type machine option was left out when MachineState was
> introduced, preventing the kvm-type option from being used. Add the
> missing property.
Very interesting how did I miss that.
Thanks!
Marcel
>
> Signed-off-by: Eduardo Habk
On Sat, May 31, 2014 at 11:33:14PM -0400, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> Signed-off-by: Romain Dolbeau
> Signed-off-by: Gabriel Somlo
> ---
> hw/net/e1000.c | 120
>
On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
Looks good to me.
If possible pls address a nit I noted in one of the patches.
Besides that:
Reviewed-by
Hi Juan,
I want to add to the call "Machine as QOM" next steps:
- Solve the 'sensible' issues.
- Choose as first tasks the ones that will be more useful.
- Select solutions agreed by everyone.
Thanks,
Marcel
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> Signed-off-by: Romain Dolbeau
> Signed-off-by: Gabriel Somlo
Reviewed-by: Peter Crosthwaite
> ---
> hw/net/e1000.
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo wrote:
> Update e1000-test.c to check all currently supported devices.
>
> Suggested-by: Andreas Färber
> Signed-off-by: Gabriel Somlo
> Reviewed-by: Michael S. Tsirkin
Reviewed-by: Peter Crosthwaite
> ---
> tests/e1000-test.c | 34 ++
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo wrote:
> Currently, e1000 support is based on the manual for the 8254xx
> model series. 82573x models are documented in a separate manual
> (see
> http://www.intel.com/content/dam/www/public/us/en/documents/manuals/pcie-gbe-controllers-open-source-
On Sun, Jun 1, 2014 at 1:33 PM, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> New in v3:
>
> - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with:
> - s/TYPE_E1000/TYPE_
Hi,
I managed to run VMWare ESXi hypervisor (type 1) inside KVM. From there, I
can install & run nested guest Linux on this ESXi.
However, I find this very strange: I put some printk() at the top of
function nested_vmx_run(), which should run to handle nested KVM. Below is
the definition of neste
On Sun, Jun 01, 2014 at 05:54:25PM +0700, Jun Koi wrote:
> So this means ESXi never uses VMResume/VMLaunch? How is this
> possible, because it uses VMX for its implementation?
ESXi will fall back to binary translation if it decides that it cannot
use VMX for some reason. Look at the L2's log file
Signed-off-by: Hani Benhabiles
---
util/readline.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/util/readline.c b/util/readline.c
index 8baec55..08d07e3 100644
--- a/util/readline.c
+++ b/util/readline.c
@@ -345,6 +345,12 @@ static void readline_completion(ReadLineState *rs)
On 05/31/2014 12:08 AM, Lluís Vilanova wrote:
> Alexey Kardashevskiy writes:
>
>> On 05/29/2014 10:42 PM, Lluís Vilanova wrote:
>>> Alexey Kardashevskiy writes:
>>>
This replaces fprintf(stderr) with error_report.
This prints line number of the trace which does not exist or is not
t
The latest Nvidia driver (337.88) specifically checks for KVM as the
hypervisor and reports Code 43 for the driver in a Windows guest when
found. Removing or changing the KVM signature is sufficient to allow
the driver to load. This patch adds an option to easily allow the KVM
hypervisor signatur
On Sun, Jun 1, 2014 at 5:59 PM, Muli Ben-Yehuda wrote:
> On Sun, Jun 01, 2014 at 05:54:25PM +0700, Jun Koi wrote:
>
> > So this means ESXi never uses VMResume/VMLaunch? How is this
> > possible, because it uses VMX for its implementation?
>
> ESXi will fall back to binary translation if it decide
Il 31/05/2014 20:29, Marcin Gibuła ha scritto:
@@ -185,6 +191,14 @@ restart:
}
if (elem->state == THREAD_DONE && elem->common.cb) {
QLIST_REMOVE(elem, all);
+/* If more completed requests are waiting, notifier needs
+ * to be rearmed so call
Il 01/06/2014 03:22, Cole Robinson ha scritto:
Hi all,
There was a bit of discussion recently about exposing q35 in virt-manager:
http://www.redhat.com/archives/virt-tools-list/2014-May/msg1.html
In that thread, Gerd suggested a 'rule of thumb' to use q35 for any guest OS
released in 2010
Il 01/06/2014 18:25, Alex Williamson ha scritto:
The latest Nvidia driver (337.88) specifically checks for KVM as the
hypervisor and reports Code 43 for the driver in a Windows guest when
found. Removing or changing the KVM signature is sufficient to allow
the driver to load. This patch adds an
Good catch! The main problem with the patch is that you need to use
atomic_inc/atomic_dec to increment and decrement pool->pending_completions.
Ok.
Secondarily, event_notifier_set is pretty heavy-weight, does it work if
you wrap the loop like this?
restart:
QLIST_FOREACH_SAFE(elem, &poo
Alexey Kardashevskiy writes:
> On 05/31/2014 12:08 AM, Lluís Vilanova wrote:
>> Alexey Kardashevskiy writes:
>>
>>> On 05/29/2014 10:42 PM, Lluís Vilanova wrote:
Alexey Kardashevskiy writes:
> This replaces fprintf(stderr) with error_report.
> This prints line number of the tra
On Sun, 2014-06-01 at 20:29 +0200, Paolo Bonzini wrote:
> Il 01/06/2014 18:25, Alex Williamson ha scritto:
> > The latest Nvidia driver (337.88) specifically checks for KVM as the
> > hypervisor and reports Code 43 for the driver in a Windows guest when
> > found. Removing or changing the KVM sign
Ping!
On Tue, May 27, 2014 at 10:39 AM, Peter Crosthwaite
wrote:
> Certain parts of the QOM framework test this pointer to determine if
> an object is parented. Nuke it when the object is unparented to allow
> for reuse of an object after unparenting.
>
> Signed-off-by: Peter Crosthwaite
> ---
>
On Fri, May 30, 2014 at 05:28:29PM +1000, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias"
>
> Signed-off-by: Edgar E. Iglesias
> ---
> target-arm/cpu.h | 1 +
> target-arm/helper-a64.c| 1 +
> target-arm/helper.c| 6 ++
> target-arm/helper.h| 1 +
> ta
On Wed, May 28, 2014 at 2:24 AM, Paolo Bonzini wrote:
> Il 27/05/2014 11:02, Peter Crosthwaite ha scritto:
>
>>
>> +void memory_region_destroy(MemoryRegion *mr)
>> +{
>> +/*FIXME: whatever the opposite of object initialize is, do it here */
>> +memory_region_finalize(OBJECT(mr));
>> +}
>>
On Tue, May 27, 2014 at 7:03 PM, Peter Crosthwaite
wrote:
> Expose the already existing .parent and .addr fields as QOM properties.
> .parent (i.e. the field describing the memory region that contains this
> one in Memory hierachy) is renamed "container". This is to avoid
> confusion with the owne
On Tue, May 27, 2014 at 7:04 PM, Peter Crosthwaite
wrote:
> QOM propertyify the .may-overlap and .priority fields. The setters
> will re-add the memory as a subregion if needed (i.e. the values change
> when the memory region is already contained).
>
> Signed-off-by: Peter Crosthwaite
> ---
> cha
Hi Paolo, Andreas,
This patch series QOMifies Memory regions. This is the Memory API
specific subset of patches forming part of the Memory/GPIO/Sysbus
QOMification.
I think Paolo already has P1 enqeued. Including for ease of review.
some QOM patches in P2-3 that cut down on later boilerplate. TBH
This if else is not needed. The previous call to memory_region_add
(whether _overlap or not) will always set priority and may_overlap
to desired values. And its not possible to get here without having
called memory_region_add_subregion due to the null guard on parent.
So we can just directly call m
Just do nothing if passed NULL for a ref or unref. This avoids
call sites that manage a combination of NULL or non-NULL pointers
having to add iffery around every ref and unref.
Signed-off-by: Peter Crosthwaite
---
qom/object.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-
The lower level API object_resolve_path is already published to the
world as part of the QOM API. Add object_resolve link as well. This
allows QOM clients to roll their own link property setters without
having to fallback to the less safe object_resolve_path.
Signed-off-by: Peter Crosthwaite
---
Split off the core looping code that actually adds subregions into
it's own fn. This prepares support for Memory Region qomification
where setting the MR address or parent via QOM will back onto this more
minimal function.
Signed-off-by: Peter Crosthwaite
---
memory.c | 18 --
1
QOMify memory regions as an Object. The former init() and destroy()
routines become instance_init() and instance_finalize() resp.
memory_region_init() is re-implemented to be:
object_initialize() + set fields
memory_region_destroy() is re-implemented to call finalize().
Signed-off-by: Peter Cros
memory_region_set_address is mostly just a function that deletes and
re-adds a memory region. Factor this generic functionality out into a
re-usable function. This prepares support for further QOMification
of MemoryRegion.
Signed-off-by: Peter Crosthwaite
---
memory.c | 30 +++--
Expose the already existing .parent and .addr fields as QOM properties.
.parent (i.e. the field describing the memory region that contains this
one in Memory hierachy) is renamed "container". This is to avoid
confusion with the owner field, which is much more akin to an actual QOM
parent.
Setting
QOM propertyify the .may-overlap and .priority fields. The setters
will re-add the memory as a subregion if needed (i.e. the values change
when the memory region is already contained).
Signed-off-by: Peter Crosthwaite
---
changed since v2:
Fixed priority getter
Support signed values in priority s
To allow devices to dynamically resize the device. The motivation is
to allow devices with variable size to init their memory_region
without size early and then correctly populate size at realize() time.
Signed-off-by: Peter Crosthwaite
---
memory.c | 38 ++
Max Reitz writes:
> On 30.05.2014 18:30, Markus Armbruster wrote:
>> They clutter the code. Unfortunately, I can't figure out how to make
>> Coccinelle drop all of them, so I have to settle for common special
>> cases:
>>
>> @@
>> type T;
>> T *pt;
>> void *pv;
>> @@
>>
Max Reitz writes:
> img_check() should report that the format of the given image does not
> support checks even if JSON output is desired. JSON data is output to
> stdout, as opposed to error messages, which are (in the case of
> qemu-img) printed to stderr. Therefore, it is easy to distinguish
>
This replaces fprintf(stderr) with error_report.
This moves local variables to the beginning of the function to comply
with QEMU's coding style.
Suggested-by: Lluís Vilanova
Signed-off-by: Alexey Kardashevskiy
---
Changes:
v2:
* polished commit log
---
trace/control.c | 31 ++--
41 matches
Mail list logo
