[Qemu-devel] [Bug 1321684] Re: block_stream command stalls

To Stefan: yes, I can reproduce this on qemu.git/master. Actually, I've found the cause of this bug and sent a patch to qemu-devel mailing list a few days ago: http://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg05777.html It's very kind of you helping review the patch and give some com

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

Il 28/05/2014 18:53, Fabio Fantoni ha scritto: 2014-05-28 18:41 GMT+02:00 Stefano Stabellini >: On Wed, 28 May 2014, Stefano Stabellini wrote: > On Wed, 28 May 2014, Fabio Fantoni wrote: > > Il 26/05/2014 10:00, Fabio Fantoni ha scritto:

[Qemu-devel] Expansion Ratio Issue

Hi all I'm new to the list, and recently I'm digging in Qemu's source code, I've got something confused me much, simply list the items: 1. Any benchmarks paying attention to TCG code generate quality measured by code expansion ratio? Of course I've got some news said that the ratio ma

Re: [Qemu-devel] [RFC PATCH 2/2] qemu: support xen hvm direct kernel boot

Il 29/05/2014 05:23, Chunyan Liu ha scritto: > [support xen HVM direct kernel boot] > qemu side patch: if -kernel exists, calls xen_load_linux(), which > will read kernel/initrd and add a linuxboot.bin or multiboot.bin > option rom. The linuxboot.bin/multiboot.bin will load kernel/initrd > and jump

Re: [Qemu-devel] [PATCH v2 1/7] qom: add object_property_add_alias()

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > Sometimes an object needs to present a property which is actually on > another object, or it needs to provide an alias name for an existing > property. > > Examples: > a.foo -> b.foo > a.old_name -> a.new_name > > The new object_propert

Re: [Qemu-devel] [PATCH v2 2/7] virtio-blk: avoid qdev property definition duplication

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > It becomes unwiedly to duplicate all virtio-blk qdev property > definitions due to an #ifdef. The C preprocessor syntax makes it a > little hard to resolve this cleanly but we can extract the #ifdef and > call a macro it defines later. > >

Re: [Qemu-devel] [PATCH v2 3/7] virtio-blk: move x-data-plane qdev property to virtio-blk.h

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > Move the x-data-plane property. Originally it was outside since not > every transport may wish to support dataplane. But that makes little > sense when we have a dedicated CONFIG_VIRTIO_BLK_DATA_PLANE ifdef > already. > > This move makes

Re: [Qemu-devel] [PATCH v2 4/7] virtio-blk: use aliases instead of duplicate qdev properties

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > virtio-blk-pci, virtio-blk-s390, and virtio-blk-ccw all duplicate the > qdev properties of their VirtIOBlock child. This approach does not work > well with string or pointer properties since we must be careful about > leaking or double-fre

Re: [Qemu-devel] [PATCH v2 5/7] virtio-blk: drop virtio_blk_set_conf()

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > This function is no longer used since parent objects now use child > aliases to set the VirtIOBlkConf directly. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Peter Crosthwaite > --- > hw/block/virtio-blk.c | 6 -- > incl

Re: [Qemu-devel] Expansion Ratio Issue

On 29 May 2014 08:58, Chaos Shu wrote: > 1. Any benchmarks paying attention to TCG code generate quality > measured by code expansion ratio? Of course I’ve got some news said that the > ratio maybe 4 or 5 in X86 to MIPS, that is to say 1 x86 insn to 4 or 5 mips > insns, Does it mean the indu

Re: [Qemu-devel] [PATCH v2 6/7] virtio: fix virtio-blk child refcount in transports

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > object_initialize() leaves the object with a refcount of 1. > object_property_add_child() adds its own reference which is dropped > again when the property is deleted. > > The upshot of this is that we always have a refcount >= 1. Upon hot

Re: [Qemu-devel] [PATCH v2 7/7] virtio-blk: move qdev properties into virtio-blk.c

On Fri, May 23, 2014 at 1:40 AM, Stefan Hajnoczi wrote: > There is no need to make DEFINE_VIRTIO_BLK_PROPERTIES() public. Inline > it into virtio-blk.c so it cannot be used by mistake from other source > files. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Peter Crosthwaite > --- > hw/bloc

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

On Tue, 27 May 2014 17:01:38 +0200 Paolo Bonzini wrote: > Il 14/05/2014 17:42, Greg Kurz ha scritto: > > +{ .name = "virtio/is_big_endian", > > + .version_id = 1, > > + .save = virtio_save_device_endian, > > + .load = virtio_load_device_endian, > > +}, > > { .name = NU

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

On Wed, 28 May 2014 18:38:13 +0200 Vasilis Liaskovitis wrote: > On Wed, May 28, 2014 at 03:26:42PM +0200, Igor Mammedov wrote: > > On Wed, 28 May 2014 14:23:13 +0200 > > Vasilis Liaskovitis wrote: > > > > > On Wed, May 28, 2014 at 10:07:22AM +0200, Igor Mammedov wrote: > > > > On Tue, 27 May 20

[Qemu-devel] [PATCH microblaze v1 0/6] Microblaze Device QOM cleanups

Hi Andreas, Edgar, Another 4 users of SysBusDevice::init bite the dust! A round of styling cleanup for Microblaze devices as per QOM conventions. Tested with published MB test images. Regards, Peter Peter Crosthwaite (6): timer: xilinx_timer: Convert to realize() net: xilinx_ethlite: Don't

[Qemu-devel] [PATCH microblaze v1 0/6] Microblaze Device QOM cleanups

Hi Andreas, Edgar, Another 4 users of SysBusDevice::init bite the dust! A round of styling cleanup for Microblaze devices as per QOM conventions. Tested with published MB test images. Regards, Peter Peter Crosthwaite (6): timer: xilinx_timer: Convert to realize() net: xilinx_ethlite: Don't

[Qemu-devel] [PATCH microblaze v1 2/6] net: xilinx_ethlite: Don't reset from init

This zeroing-out of the rxbuf variable (ping pong state) is a reset side effect. Extract into a proper reset. Signed-off-by: Peter Crosthwaite --- hw/net/xilinx_ethlite.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.

[Qemu-devel] [PATCH microblaze v1 1/6] timer: xilinx_timer: Convert to realize()

SysBusDevice::init is depracated. Convert to Object::init and Device::realize as prescribed by QOM conventions. Signed-off-by: Peter Crosthwaite --- hw/timer/xilinx_timer.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/timer/xilinx_timer.c b/hw/tim

[Qemu-devel] [PATCH microblaze v1 3/6] net: xilinx_ethlite: Convert to realize()

SysBusDevice::init is depracated. Convert to Object::init and Device::realize as prescribed by QOM conventions. Signed-off-by: Peter Crosthwaite --- hw/net/xilinx_ethlite.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/net/xilinx_ethlite.c b/

[Qemu-devel] [PATCH microblaze v1 4/6] char: xilinx_uartlite: Don't reset from init

This refresh of the device state is intended to be a reset side effect. Move it to a proper reset handler rather than do it at init time. Signed-off-by: Peter Crosthwaite --- hw/char/xilinx_uartlite.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/char/xilinx_uart

[Qemu-devel] [PATCH microblaze v1 5/6] char: xilinx_uartlite: Convert to realize()

SysBusDevice::init is depracated. Convert to Object::init and Device::realize as prescribed by QOM conventions. Signed-off-by: Peter Crosthwaite --- hw/char/xilinx_uartlite.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/char/xilinx_uartlite.c

[Qemu-devel] [PATCH microblaze v1 6/6] intc: xilinx_uartlite: Convert SBD::init -> instance_init

SysBusDevice::init is depracated. Convert to Object::init as prescribed by QOM conventions. Signed-off-by: Peter Crosthwaite --- hw/intc/xilinx_intc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index c3682

Re: [Qemu-devel] [PATCH microblaze v1 0/6] Microblaze Device QOM cleanups

Sorry about the dup mail. Sent this one with the wrong SMTP server then aborted it. Proper send on list. Regards, Peter On Thu, May 29, 2014 at 7:21 PM, Peter Crosthwaite wrote: > Hi Andreas, Edgar, > > Another 4 users of SysBusDevice::init bite the dust! > > A round of styling cleanup for Micr

[Qemu-devel] [PATCH microblaze v1 1/6] timer: xilinx_timer: Convert to realize()

SysBusDevice::init is depracated. Convert to Object::init and Device::realize as prescribed by QOM conventions. Signed-off-by: Peter Crosthwaite --- hw/timer/xilinx_timer.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/timer/xilinx_timer.c b/hw/tim

[Qemu-devel] [PATCH microblaze v1 2/6] net: xilinx_ethlite: Don't reset from init

This zeroing-out of the rxbuf variable (ping pong state) is a reset side effect. Extract into a proper reset. Signed-off-by: Peter Crosthwaite --- hw/net/xilinx_ethlite.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.

[Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

... fixes freeing constant from vl.c by machine_finalize() Signed-off-by: Igor Mammedov --- hw/core/machine.c |3 +++ vl.c |7 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index cbba679..37bd676 100644 --- a/hw/

[Qemu-devel] 答复: Expansion Ratio Issue

On 29 May 2014 08:58, Chaos Shu wrote: > 1. Any benchmarks paying attention to TCG code generate quality > measured by code expansion ratio? Of course I’ve got some news said > that the ratio maybe 4 or 5 in X86 to MIPS, that is to say 1 x86 insn > to 4 or 5 mips insns, Does it mean the in

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

Il 29/05/2014 11:12, Greg Kurz ha scritto: int virtio_load(VirtIODevice *vdev, QEMUFile *f) { [...] nheads = vring_avail_idx(&vdev->vq[i]) - vdev->vq[i].last_avail_idx; ^^^ /* Check it isn't doing very strange things with descriptor numbers.

Re: [Qemu-devel] [PATCH v2 6/7] virtio: fix virtio-blk child refcount in transports

Il 29/05/2014 11:11, Peter Crosthwaite ha scritto: > object_initialize() leaves the object with a refcount of 1. > object_property_add_child() adds its own reference which is dropped > again when the property is deleted. > > The upshot of this is that we always have a refcount >= 1. Upon hot > u

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 2014-05-29 at 11:47 +0200, Igor Mammedov wrote: > ... fixes freeing constant from vl.c by machine_finalize() Nice cleanup, thanks! Reviewed-by: Marcel Apfelbaum > > Signed-off-by: Igor Mammedov > --- > hw/core/machine.c |3 +++ > vl.c |7 +-- > 2 files changed

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

Am 29.05.2014 11:47, schrieb Igor Mammedov: > ... fixes freeing constant from vl.c by machine_finalize() > > Signed-off-by: Igor Mammedov Did you check whether there are any others in need of changes? I could imagine kernel_irqchip does, and I see that we forgot to fix the underscore in the prop

[Qemu-devel] [PATCH] slirp: Remove unused zero_ethaddr[] variable

The zero_ethaddr[] array is never used; delete it. Signed-off-by: Peter Maydell --- clang 3.4 warns about unused const variables like this and also about unused functions; we have over 400 such warnings currently, of which some are simple "forgot to clean up redundant code" like this one, some ar

[Qemu-devel] [PATCH] hw/i386/pc.c: Remove unused parallel_io and parallel_irq variables

The variables parallel_io and parallel_irq are unused; delete them. Signed-off-by: Peter Maydell --- hw/i386/pc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e6369d5..32d1632 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -922,9 +922,6 @@ static const

[Qemu-devel] [PATCH] hw/pci-host/ppce500: Fix typo in vmstate definition

Fix a typo in the ppce500_pci vmstate definition which meant that we were migrating the struct pci_inbound using the vmstate for pci_outbound. Fortunately the two structures have exactly the same format at the moment (four uint32_ts) so this was harmless, and we can correcting the typo without a mi

Re: [Qemu-devel] Expansion Ratio Issue

Peter Maydell writes: > On 29 May 2014 08:58, Chaos Shu wrote: >> 1. Any benchmarks paying attention to TCG code generate quality >> measured by code expansion ratio? Of course I’ve got some news said that the >> ratio maybe 4 or 5 in X86 to MIPS, that is to say 1 x86 insn to 4 or 5 mips

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 29 May 2014 12:47:45 +0200 Andreas Färber wrote: > Am 29.05.2014 11:47, schrieb Igor Mammedov: > > ... fixes freeing constant from vl.c by machine_finalize() > > > > Signed-off-by: Igor Mammedov > > Did you check whether there are any others in need of changes? I could > imagine kernel

Re: [Qemu-devel] [PATCH] libcacard: improve documentation

On 05/28/2014 07:15 PM, Paolo Bonzini wrote: > Using the file-backed smartcard backend is black magic, but it can > be useful if your only smartcard bricks itself if it is accessed > the wrong way too many times. > > Complete the documentation to include the art of creating certificates > and usin

Re: [Qemu-devel] [PATCH] hw/i386/pc.c: Remove unused parallel_io and parallel_irq variables

On Thu, May 29, 2014 at 12:01:49PM +0100, Peter Maydell wrote: > The variables parallel_io and parallel_irq are unused; delete them. > > Signed-off-by: Peter Maydell Thanks, applied. Reviewed-by: Michael S. Tsirkin > --- > hw/i386/pc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > Am 29.05.2014 11:47, schrieb Igor Mammedov: > > ... fixes freeing constant from vl.c by machine_finalize() > > > > Signed-off-by: Igor Mammedov > > Did you check whether there are any others in need of changes? I could > imagine kernel_i

[Qemu-devel] [PATCH v4 02/10] trace: [tcg] Argument type transformation rules

Signed-off-by: Lluís Vilanova --- scripts/tracetool/transform.py | 166 1 file changed, 166 insertions(+) create mode 100644 scripts/tracetool/transform.py diff --git a/scripts/tracetool/transform.py b/scripts/tracetool/transform.py new file mode 100644

[Qemu-devel] [PATCH v4 00/10] trace: [tcg] Allow tracing guest events in TCG-generated code

NOTE: TCG code for execution-time event tracing is always generated, regardless of wether the event has been dynamically disabled or not (unless the event has the static "disable" property). This approach keeps this series simple, and a future series will handle the case of

[Qemu-devel] [PATCH v4 04/10] trace: [tcg] Add 'tcg' event property

Transforms event: tcg name(...) "...", "..." into two internal events: tcg-trans name_trans(...) "..." tcg-exec name_exec(...) "..." Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py| 64 +++--- scripts/tracetool/format/events_h.py |

[Qemu-devel] [PATCH v4 03/10] trace: [tcg] Argument type transformation machinery

Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index e8e8edc..bd3fd85 100644 --- a/scripts/tracetool/__init__.py +++

[Qemu-devel] [PATCH v4 01/10] trace: [tcg] Add documentation

Signed-off-by: Lluís Vilanova --- docs/tracing.txt | 40 1 file changed, 40 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index c6ab1c1..2e035a5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -307,3 +307,43 @@ guard such comput

[Qemu-devel] [PATCH v4 05/10] trace: [tcg] Declare TCG tracing helper routines

Generate header "trace/generated-helpers.h" with the necessary TCG helper declarations for tracing events in guest code at execution time: * gen_helper_trace_${event}_exec Routine to transform mixed native and TCG argument types to TCG types and call TCG helper 'gen_helper_trace_${event}_exec

[Qemu-devel] [PATCH v4 07/10] trace: [tcg] Include TCG-tracing helpers

Signed-off-by: Lluís Vilanova --- include/exec/helper-gen.h |3 +++ include/exec/helper-proto.h |1 + include/exec/helper-tcg.h |1 + 3 files changed, 5 insertions(+) diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h index a04a034..ba5a379 100644 --- a/include/ex

[Qemu-devel] [PATCH v4 10/10] trace: [tcg] Include TCG-tracing header on all targets

Signed-off-by: Lluís Vilanova --- target-alpha/translate.c |3 +++ target-arm/translate-a64.c|2 ++ target-arm/translate.c|3 +++ target-cris/translate.c |3 +++ target-i386/translate.c |3 +++ target-lm32/translate.c |3 +++ target-m68k/

[Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

From: Grant Likely Right now to run firmware inside the QEMU VExpress model requires padding out the firmware image to the size of the virtual flash and passing it in via the -pflash argument. If the firmware image is passed without padding, then QEMU will fail. Also, when passed as a -pflash arg

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: >> Am 29.05.2014 11:47, schrieb Igor Mammedov: >>> ... fixes freeing constant from vl.c by machine_finalize() >>> >>> Signed-off-by: Igor Mammedov >> >> Did you check whether there are any oth

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 29 May 2014 14:25:31 +0200 Andreas Färber wrote: > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > >> Am 29.05.2014 11:47, schrieb Igor Mammedov: > >>> ... fixes freeing constant from vl.c by machine_finalize() > >>> > >>> Sign

[Qemu-devel] [PATCH v4 06/10] trace: [tcg] Define TCG tracing helper routines

Generate file "trace/generated-helpers.c" with the necessary TCG helper routines for tracing events in guest code at execution time: * helper_trace_${event}_exec_proxy TCG helper implementation to cast TCG-compatible argument types to native types and call tracing routine 'trace_${event}_exec

Re: [Qemu-devel] [PATCH] trace: Replace fprintf with error_report and print location

Alexey Kardashevskiy writes: > This replaces fprintf(stderr) with error_report. > This prints line number of the trace which does not exist or is not > traceable. A little nit pick; it shows an error when some of the events in the list of events to enable (not the trace) does not exist or is not

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

On Thu, May 29, 2014 at 10:24 PM, Peter Maydell wrote: > From: Grant Likely > > Right now to run firmware inside the QEMU VExpress model requires > padding out the firmware image to the size of the virtual flash and > passing it in via the -pflash argument. If the firmware image is passed > witho

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 02:58:20AM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > From MIPS documentation (Volume III): > > UserLocal Register (CP0 Register 4, Select 2) > Compliance Level: Recommended. > > The UserLocal register is a read-write register that is not interpreted by >

[Qemu-devel] [PATCH v4 09/10] trace: [tcg] Include event definitions in "trace.h"

Otherwise the user has to explicitly include an auto-generated header. Signed-off-by: Lluís Vilanova --- include/trace.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/trace.h b/include/trace.h index c15f498..44a1f1f 100644 --- a/include/trace.h +++ b/include/trace.h @@ -2,5 +2,6

Re: [Qemu-devel] [PATCH] slirp: Remove unused zero_ethaddr[] variable

Am 29.05.2014 13:00, schrieb Peter Maydell: > The zero_ethaddr[] array is never used; delete it. > > Signed-off-by: Peter Maydell > --- > clang 3.4 warns about unused const variables like this and > also about unused functions; we have over 400 such warnings > currently, of which some are simple

Re: [Qemu-devel] [PATCH] target-arm/cpu64.c: Actually register Cortex-A57 impdef registers

On Wed, May 28, 2014 at 7:30 AM, Peter Maydell wrote: > cpu64.c contains a reginfo list for the impdef registers on > the Cortex-A57; however we forgot to actually call define_arm_cp_regs(), > so it was sitting there doing nothing. Remedy this omission. > > Signed-off-by: Peter Maydell I have th

[Qemu-devel] [PATCH v4 08/10] trace: [tcg] Generate TCG tracing routines

Generate header "trace/generated-tcg-tracers.h" with the necessary routines for tracing events in guest code: * trace_${event}_tcg Convenience wrapper that calls the translation-time tracer 'trace_${event}_trans', and calls 'gen_helper_trace_${event}_exec to generate the TCG code to later t

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: > On Thu, 29 May 2014 14:25:31 +0200 > Andreas Färber wrote: > > > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > > >> Am 29.05.2014 11:47, schrieb Igor Mammedov: > > >>> ... f

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

> While adding MIPS_HFLAG_HWRENA_ULR is a good idea for performance > reasons, I don't think we should add MIPS_HFLAG_CP0UL. This value is > always the same (true or false) during all the run time of the > qemu-system-mips binary, and thus we don't need to take care of code > generated with it bein

Re: [Qemu-devel] [PATCH] slirp: Remove unused zero_ethaddr[] variable

On 29 May 2014 13:52, Stefan Weil wrote: > I can add some more: > > * Missing 'static' attributes for local variables and functions Those seem worth fixing. > * Use of 0 instead of NULL for pointers (do we want to fix those?) I wouldn't bother personally. There's also still a tail of coverity

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 01:01:38PM +, Petar Jovanovic wrote: > > While adding MIPS_HFLAG_HWRENA_ULR is a good idea for performance > > reasons, I don't think we should add MIPS_HFLAG_CP0UL. This value is > > always the same (true or false) during all the run time of the > > qemu-system-mips bin

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 29 May 2014 15:56:16 +0300 Marcel Apfelbaum wrote: > On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: > > On Thu, 29 May 2014 14:25:31 +0200 > > Andreas Färber wrote: > > > > > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färbe

Re: [Qemu-devel] [PATCH v2 1/1] bsd-user: refresh freebsd system call numbers

On 28 May 2014 19:00, Sean Bruno wrote: > From: Stacey Son > > Update FreeBSD system call numbers in freebsd/syscall_nr.h. > > Signed-off bY: Stacey Son (stray uppercase Y) > Signed-off-by: Sean Bruno > > Reviewed-by: Ed Maste Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: > On Thu, 29 May 2014 15:56:16 +0300 > Marcel Apfelbaum wrote: > > > On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: > > > On Thu, 29 May 2014 14:25:31 +0200 > > > Andreas Färber wrote: > > > > > > > Am 29.05.2014 14:21, schrieb Ma

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29/05/14 14:08, Aurelien Jarno wrote: > On Thu, May 29, 2014 at 01:01:38PM +, Petar Jovanovic wrote: >>> While adding MIPS_HFLAG_HWRENA_ULR is a good idea for performance >>> reasons, I don't think we should add MIPS_HFLAG_CP0UL. This value is >>> always the same (true or false) during all t

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

On Thu, 2014-05-29 at 14:25 +0200, Andreas Färber wrote: > Am 29.05.2014 14:21, schrieb Marcel Apfelbaum: > > On Thu, 2014-05-29 at 12:47 +0200, Andreas Färber wrote: > >> Am 29.05.2014 11:47, schrieb Igor Mammedov: > >>> ... fixes freeing constant from vl.c by machine_finalize() > >>> > >>> Signed

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29 May 2014 14:22, James Hogan wrote: > loadvm/migration will write Config3, possibly with a different value if > the snapshot being loaded is an older one without userlocal support. Migration load always happens with a freshly reset system, so this isn't a problem. thanks -- PMM

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

Am 29.05.2014 15:21, schrieb Marcel Apfelbaum: > On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: >> On Thu, 29 May 2014 15:56:16 +0300 >> Marcel Apfelbaum wrote: >>> On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: Maybe we can hack QemuOpts to do s/foo_moo/foo-moo/ ? Than

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

> change as CP0_Config3 is a read-only register. If I am right, probably > the best is to check directly env->CP0_Config3. If you take a look at v1 of the patch, that's what was done. In the code review, this was marked as unacceptable because it required [1] passing env within the translator. [

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

Am 29.05.2014 15:35, schrieb Petar Jovanovic: >> change as CP0_Config3 is a read-only register. If I am right, probably >> the best is to check directly env->CP0_Config3. > > If you take a look at v1 of the patch, that's what was done. > In the code review, this was marked as unacceptable because

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 01:35:17PM +, Petar Jovanovic wrote: > > change as CP0_Config3 is a read-only register. If I am right, probably > > the best is to check directly env->CP0_Config3. > > If you take a look at v1 of the patch, that's what was done. > In the code review, this was marked as

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29 May 2014 14:35, Petar Jovanovic wrote: >> change as CP0_Config3 is a read-only register. If I am right, probably >> the best is to check directly env->CP0_Config3. > > If you take a look at v1 of the patch, that's what was done. > In the code review, this was marked as unacceptable because i

Re: [Qemu-devel] [Qemu-ppc] [V4 PATCH 1/6] target-ppc: Support little-endian PPC64 in user mode.

On 5/28/2014 5:59 PM, Alexander Graf wrote: > > On 28.05.14 22:34, Tom Musta wrote: >> Look at ELF header to determine ABI version on PPC64. This is required >> for executing the first instruction correctly. Also print correct machine >> name in uname() system call. >> >> Signed-off-by: Doug Kwa

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > Provides framework for splitting host RAM allocation/ > policies into a separate backend that could be used > by devices. > > Initially only legacy RAM backend is provided, which > uses memory_region_init_ram() allocator and compatible > wit

Re: [Qemu-devel] [PATCH v3 06/34] vl.c: extend -m option to support options for memory hotplug

On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > Add following parameters: > "slots" - total number of hotplug memory slots > "maxmem" - maximum possible memory > > "slots" and "maxmem" should go in pair and "maxmem" should be greater > than "mem" for memory hotplug to be enabled. > >

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 02:48:28PM +0100, Peter Maydell wrote: > On 29 May 2014 14:35, Petar Jovanovic wrote: > >> change as CP0_Config3 is a read-only register. If I am right, probably > >> the best is to check directly env->CP0_Config3. > > > > If you take a look at v1 of the patch, that's what

[Qemu-devel] [V4 PATCH (resend) 0/6] Adding New Target ppc64le-linux-user

This is a follow up to the patch series initiated by Doug Kwan http://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg01936.html The resubmission of V4 cleans up some attribution issues (corrects Doug's email address in the Signed-off-by and also cites Doug as the author of the first three pa

[Qemu-devel] [V4 PATCH (resend) 1/6] target-ppc: Support little-endian PPC64 in user mode.

From: Doug Kwan Look at ELF header to determine ABI version on PPC64. This is required for executing the first instruction correctly. Also print correct machine name in uname() system call. Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V3: Addressing Peter Maydell's comments regardi

[Qemu-devel] [V4 PATCH (resend) 3/6] target-ppc: Add a new user mode target for little-endian PPC64.

From: Doug Kwan Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V3: Addressing comment from Peter Maydell. Adding libdecnumber enable. configure |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0e516f9..3ccbe4b 100755 --- a/conf

[Qemu-devel] [V4 PATCH (resend) 5/6] target-ppc: Confirm That .bss Pages Are Valid

The existing code does a check to ensure that a .bss region is properly mmap'd. When additional mmap is required, the (guest) pages are also validated. However, this code has a bug: when host page size is larger than target page size, it is possible for the .bss pages to already be (host) mapped

[Qemu-devel] [V4 PATCH (resend) 6/6] target-ppc: Store Quadword Conditional Drops Size Bit

The size and register information are encoded into the reserve_info field of CPU state in the store conditional translation code. Specifically, the size is shifted left by 5 bits (see target-ppc/translate.c gen_conditional_store). The user-mode store conditional code erroneously extracts the siz

[Qemu-devel] [V4 PATCH (resend) 4/6] target-ppc: Support VSX in PPC User Mode

Some modern tool chains use VSX instructions. Therefore attempt to enable the VSX MSR bit by default, just like similar bits (FP, VEC, SPE, etc.). Signed-off-by: Tom Musta --- V3: new patch target-ppc/translate_init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/t

[Qemu-devel] [V4 PATCH (resend) 2/6] target-ppc: Allow little-endian user mode.

From: Doug Kwan This allows running PPC64 little-endian in user mode if target is configured that way. In PPC64 LE user mode we set MSR.LE during initialization. Signed-off-by: Doug Kwan Signed-off-by: Tom Musta --- V2: Overhaul handling of byteswapping in code generation and mem helpers. V

Re: [Qemu-devel] [PATCH v3 10/34] dimm: implement dimm device abstraction

On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > From: Vasilis Liaskovitis > > Each hotplug-able memory slot is a DimmDevice. > A hot-add operation for a DIMM: > - creates a new DimmDevice and makes hotplug controller to map it into > guest address space > > Hotplug operations are done

[Qemu-devel] [PATCH] target-mips: copy CP0_Config1 into DisasContext

In order to avoid access to the CPUMIPSState structure in the translator, keep a copy of CP0_Config1 into DisasContext. The whole register is read-only so it can be copied as a single value. Signed-off-by: Aurelien Jarno --- target-mips/translate.c | 20 +++- 1 file changed, 11

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On Thu, May 29, 2014 at 04:06:56PM +0200, Aurelien Jarno wrote: > On Thu, May 29, 2014 at 02:48:28PM +0100, Peter Maydell wrote: > > On 29 May 2014 14:35, Petar Jovanovic wrote: > > >> change as CP0_Config3 is a read-only register. If I am right, probably > > >> the best is to check directly env->

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29/05/14 14:26, Peter Maydell wrote: > On 29 May 2014 14:22, James Hogan wrote: >> loadvm/migration will write Config3, possibly with a different value if >> the snapshot being loaded is an older one without userlocal support. > > Migration load always happens with a freshly reset system, > so

Re: [Qemu-devel] [PATCH v3 11/34] memory: add memory_region_is_mapped() API

On Tue, May 27, 2014 at 11:01 PM, Igor Mammedov wrote: > which allows to check if MemoryRegion is already mapped. > > Signed-off-by: Igor Mammedov > --- > include/exec/memory.h |8 > memory.c | 15 ++- > 2 files changed, 22 insertions(+), 1 deletions(-) >

Re: [Qemu-devel] [PATCH v3 00/34] pc: ACPI memory hotplug

On Tue, May 27, 2014 at 11:00 PM, Igor Mammedov wrote: > NOTE to commiter: > * update precompiled ACPI hex files for iasl-less hosts >and ACPI tables test to match new ACPI tables. > > What's new since v9: > * drop usage of error_is_set() > * exit QEMU if it's started with memory hotplug bu

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

CC'ing Drew, Eric and Michal. On 05/29/14 14:45, Peter Crosthwaite wrote: > On Thu, May 29, 2014 at 10:24 PM, Peter Maydell > wrote: >> From: Grant Likely >> >> Right now to run firmware inside the QEMU VExpress model requires >> padding out the firmware image to the size of the virtual flash an

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

Il 29/05/2014 16:05, Peter Crosthwaite ha scritto: > +path = object_get_canonical_path_component(OBJECT(backend)); > +memory_region_init_ram(&backend->mr, OBJECT(backend), path, Passing the full canonical path as the name of memory region is redundant as that information is already passe

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

On Fri, May 30, 2014 at 12:46 AM, Laszlo Ersek wrote: > CC'ing Drew, Eric and Michal. > > On 05/29/14 14:45, Peter Crosthwaite wrote: >> On Thu, May 29, 2014 at 10:24 PM, Peter Maydell >> wrote: >>> From: Grant Likely >>> >>> Right now to run firmware inside the QEMU VExpress model requires >>>

Re: [Qemu-devel] [PATCH v3 11/34] memory: add memory_region_is_mapped() API

Il 29/05/2014 16:22, Peter Crosthwaite ha scritto: > > +bool memory_region_is_mapped(MemoryRegion *mr) > +{ Is it not enough to just return mr->parent? Memory mapping assertion will happen if you try and map the same twice, even if one of the mappings is not contained within an AddressSpace. Che

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29 May 2014 15:29, James Hogan wrote: > On 29/05/14 14:26, Peter Maydell wrote: >> On 29 May 2014 14:22, James Hogan wrote: >>> loadvm/migration will write Config3, possibly with a different value if >>> the snapshot being loaded is an older one without userlocal support. >> >> Migration load

Re: [Qemu-devel] [PATCH v2] vexpress: Add support for the -bios flag to provide firmware

On 29 May 2014 15:46, Laszlo Ersek wrote: > (2) Can anyone post / link a concise, *up-to-date* command line for > upstream qemu, in connection with *upstream* edk2 build instructions, so > that I can test aarch64 UEFI stuff on an x86_64 host (with TCG)? Note that AArch64 isn't relevant to this pa

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

Il 29/05/2014 17:39, Peter Crosthwaite ha scritto: > It's not the full canonical path, it's basically the id. > Fair enough. Although its still redundant though isn't it? Should we ever clean up messages etc in memory api to include both owner and name this is going to come out: "foo/bar/baz:b

Re: [Qemu-devel] [PATCH v3 05/34] add memdev backend infrastructure

On Fri, May 30, 2014 at 1:25 AM, Paolo Bonzini wrote: > Il 29/05/2014 16:05, Peter Crosthwaite ha scritto: > >>> > +path = object_get_canonical_path_component(OBJECT(backend)); >>> > +memory_region_init_ram(&backend->mr, OBJECT(backend), path, >> >> Passing the full canonical path as the n

Re: [Qemu-devel] [PATCH] machine: set default kernel_cmdline in machine_initfn()

Il 29/05/2014 15:26, Andreas Färber ha scritto: Am 29.05.2014 15:21, schrieb Marcel Apfelbaum: On Thu, 2014-05-29 at 15:08 +0200, Igor Mammedov wrote: On Thu, 29 May 2014 15:56:16 +0300 Marcel Apfelbaum wrote: On Thu, 2014-05-29 at 14:40 +0200, Igor Mammedov wrote: Maybe we can hack QemuOpts

Re: [Qemu-devel] [v3 PATCH] target-mips: implement UserLocal Register

On 29/05/14 16:38, Peter Maydell wrote: > On 29 May 2014 15:29, James Hogan wrote: >> On 29/05/14 14:26, Peter Maydell wrote: >>> On 29 May 2014 14:22, James Hogan wrote: loadvm/migration will write Config3, possibly with a different value if the snapshot being loaded is an older one wi

  1   2   >