On Sun, May 25, 2014 at 05:12:55PM +0100, Hani Benhabiles wrote:
> On Fri, May 23, 2014 at 02:05:03PM +0200, Stefan Hajnoczi wrote:
> > On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote:
> > > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > > index 919af6e..6aaec1b 100644
> > > ---
On Mon, May 26, 2014 at 09:07:43AM +0400, M.Kustova wrote:
> Hello,
>
> My name is Maria and I'm a participant of the Outreach Program for Women.
> My project is fuzz testing of support of qcow2 image format.
>
> The project git:
> https://github.com/maxalab/qemu_fuzzer.git
>
> It's pubic, so w
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 2 +-
trace-events | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 54dea16..72308e0 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2856,7 +2856,7 @@ static void
Signed-off-by: Gerd Hoffmann
---
ui/console.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index 75ec3af..3bc18cf 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -30,7 +30,6 @@
#include "trace.h"
#define DEFAULT_BACKSCROLL 512
-
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c| 44
include/hw/i386/pc.h | 4
2 files changed, 40 insertions(+), 8 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 72308e0..3f1b7ce 100644
--- a/hw/usb/hcd-xhci.c
+++
v3:
* In this case, as we discussed we will give priority to devices to
reserve a specific devfn by passing
"device_model_args_hvm = ['-device', 'xen-platform,addr=0x3']" and
"vga=none", so withdraw patch #1, #2 and #4.
* Fix some typos.
* Add more comments to make that readable.
* To unmap
ISA bridge is needed since Intel gfx drive will probe it instead
of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that
only need to expose ISA bridge to let driver know the real hardware underneath.
The original patch is from Allen Kay [allen.m@intel.com]
Signed-off-by: Ya
Implement that pci host bridge to specific to passthrough. Actually
thsi just inherit the standard one.
Signed-off-by: Tiejun Chen
---
v3:
* Just fix this patch head description typo.
v2:
* New patch.
hw/pci-host/piix.c | 56 --
1 file chan
basic gfx passthrough support:
- add a vga type for gfx passthrough
- retrieve VGA bios from sysfs, then load it to guest 0xC
- register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx
The original patch is from Weidong Han
Signed-off-by: Yang Zhang
Signed-off-by: Tiejun Che
The OpRegion shouldn't be mapped 1:1 because the address in the host
can't be used in the guest directly.
This patch traps read and write access to the opregion of the Intel
GPU config space (offset 0xfc).
The original patch is from Jean Guyader
Signed-off-by: Yang Zhang
Signed-off-by: Tiejun
Some registers of Intel IGD are mapped in host bridge, so it needs to
passthrough these registers of physical host bridge to guest because
emulated host bridge in guest doesn't have these mappings.
The original patch is from Weidong Han < weidong.han @ intel.com >
Signed-off-by: Yang Zhang
Signe
Please ignore this series since I have some typos to some email address :(
Sorry for any inconveniences.
Thanks
Tiejun
> -Original Message-
> From: qemu-devel-bounces+tiejun.chen=intel@nongnu.org
> [mailto:qemu-devel-bounces+tiejun.chen=intel@nongnu.org] On Behalf Of
> Tiejun Che
v3:
* In this case, as we discussed we will give priority to devices to
reserve a specific devfn by passing
"device_model_args_hvm = ['-device', 'xen-platform,addr=0x3']" and
"vga=none", so withdraw patch #1, #2 and #4.
* Fix some typos.
* Add more comments to make that readable.
* To unmap
basic gfx passthrough support:
- add a vga type for gfx passthrough
- retrieve VGA bios from sysfs, then load it to guest 0xC
- register/unregister legacy VGA I/O ports and MMIOs for passthroughed gfx
The original patch is from Weidong Han
Signed-off-by: Yang Zhang
Signed-off-by: Tiejun Che
ISA bridge is needed since Intel gfx drive will probe it instead
of Dev31:Fun0 to make graphics device passthrough work easy for VMM, that
only need to expose ISA bridge to let driver know the real hardware underneath.
The original patch is from Allen Kay [allen.m@intel.com]
Signed-off-by: Ya
The OpRegion shouldn't be mapped 1:1 because the address in the host
can't be used in the guest directly.
This patch traps read and write access to the opregion of the Intel
GPU config space (offset 0xfc).
The original patch is from Jean Guyader
Signed-off-by: Yang Zhang
Signed-off-by: Tiejun
Some registers of Intel IGD are mapped in host bridge, so it needs to
passthrough these registers of physical host bridge to guest because
emulated host bridge in guest doesn't have these mappings.
The original patch is from Weidong Han < weidong.han @ intel.com >
Signed-off-by: Yang Zhang
Signe
Implement that pci host bridge to specific to passthrough. Actually
thsi just inherit the standard one.
Signed-off-by: Tiejun Chen
---
v3:
* Just fix this patch head description typo.
v2:
* New patch.
hw/pci-host/piix.c | 56 --
1 file chan
Hello Kevin,
Thanks a lot for your feedback.
Your first guess is absolutely correct. For now, 'action' can be
freely interpret as an image block will be corrupted. It's possible,
that in the future this term will be extended to a set of fuzzing
rules necessary to corrupt some image block, e.g. not
Il 26/05/2014 11:18, Christoffer Dall ha scritto:
Hi,
I noticed that commit 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1 broke
KVM/ARM, because the realize function (arm_cpu_realizefn()) now calls
cpu_reset() before qemu_init_vcpu(), which causes kvm_arm_reset_cpu() to
segfault because it dereferenc
On 26.05.14 11:55, Paolo Bonzini wrote:
Il 26/05/2014 11:18, Christoffer Dall ha scritto:
Hi,
I noticed that commit 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1 broke
KVM/ARM, because the realize function (arm_cpu_realizefn()) now calls
cpu_reset() before qemu_init_vcpu(), which causes kvm_arm_res
It indicates the number of elements in ncs field and makes sense to have
int inside NICPeers. Also in parse_netdev we do not need to access
container and work with NICPeers only.
Signed-off-by: Jiri Pirko
---
hw/core/qdev-properties-system.c | 3 +--
hw/net/virtio-net.c | 2 +-
incl
Am 26.05.2014 11:57, schrieb Alexander Graf:
>
> Any reason we're so incredibly inconsistent in what we do during realize
> with reset? I would really prefer to ensure we're doing the same thing
> on all targets.
>
>
> Alex
>
> $ grep -R -A 3 -B 3 qemu_init_vcpu target-*
> target-alpha/cpu.c-
Am 26.05.2014 12:04, schrieb Jiri Pirko:
> It indicates the number of elements in ncs field and makes sense to have
> int inside NICPeers. Also in parse_netdev we do not need to access
> container and work with NICPeers only.
>
> Signed-off-by: Jiri Pirko
> ---
> hw/core/qdev-properties-system.c
On 26.05.14 12:20, Andreas Färber wrote:
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure we're doing the same thing
on all targets.
Alex
$ grep -R -A 3 -B 3 qemu_init_vcpu target
On Mon, May 26, 2014 at 11:25:56AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> hw/usb/hcd-xhci.c| 44
> include/hw/i386/pc.h | 4
> 2 files changed, 40 insertions(+), 8 deletions(-)
>
> diff --git a/hw/usb/hcd-xhci.c b
On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote:
> On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote:
> > On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote:
> > > > If you implement this in the net layer then that problem is easy to
> > > > resolve sinc
On Mon, May 26, 2014 at 01:48:13PM +0200, Stefan Hajnoczi wrote:
> On Wed, May 14, 2014 at 03:46:48PM +0300, Michael S. Tsirkin wrote:
> > On Wed, May 14, 2014 at 02:30:26PM +0200, Stefan Hajnoczi wrote:
> > > On Thu, May 08, 2014 at 12:51:05PM +, Zhanghailiang wrote:
> > > > > If you implement
On Wed, May 07, 2014 at 07:24:09PM +0200, Stefan Hajnoczi wrote:
> This series adds a pid field to the simpletrace record. This allows
> aggregation of simpletrace files as well as host-wide tracing since records
> can
> now be associated with a particular QEMU process.
>
> Stefan Hajnoczi (2):
On Fri, May 23, 2014 at 01:18:50PM +0200, Kevin Wolf wrote:
> Am 22.05.2014 um 11:42 hat Stefan Hajnoczi geschrieben:
> > diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
> > index f19536a..a46ee57 100644
> > --- a/docs/specs/qcow2.txt
> > +++ b/docs/specs/qcow2.txt
> > @@ -4,6 +4,10 @@ A q
On Fri, May 23, 2014 at 05:15:41PM +0100, Peter Maydell wrote:
> In the MacOSX specific code in raw-posix.c we use the define
> LONG_LONG_MAX. This is actually a non-standard pre-C99 define;
> switch to using the standard LLONG_MAX instead.
>
> This apparently fixes a compilation failure with cert
On Mon, May 26, 2014 at 12:04:08PM +0200, Jiri Pirko wrote:
> It indicates the number of elements in ncs field and makes sense to have
> int inside NICPeers. Also in parse_netdev we do not need to access
> container and work with NICPeers only.
>
> Signed-off-by: Jiri Pirko
Reviewed-by: Michael
On 21/05/14 23:43, Juan Quintela wrote:
>
> Hi
>
> Please, send any topic that you are interested in covering.
(mostly) Michael Mueller
-
CPU models on s390 and other platforms. Interfaces/requirements/Contraints etc.
> Thanks, Juan.
>
> Call details:
>
> 15:00
Bring the memory map closer to a PowerMac3,1 model by removing unused
areas and adding the VGA and network cards after the macio to let the
latter be mapped from 0x8000 like on real hardware. (On real
hardware the graphics and network cards are on separate buses but we
don't model that yet.)
S
On Fri, May 23, 2014 at 06:25:31PM +0200, Marcin Gibuła wrote:
> >If you see a pending request on a RADOS block device (rbd) then it would
> >be good to dig deeper into QEMU's block/rbd.c driver to see why it's not
> >completing that request.
> >
> >Are you using qcow2 on top of rbd?
>
> Hi,
> I'v
Am 26.05.2014 12:31, schrieb Alexander Graf:
>
> On 26.05.14 12:20, Andreas Färber wrote:
>> Am 26.05.2014 11:57, schrieb Alexander Graf:
>>> Any reason we're so incredibly inconsistent in what we do during realize
>>> with reset? I would really prefer to ensure we're doing the same thing
>>> on a
- Andreas Färber 写道：
> Am 26.05.2014 11:57, schrieb Alexander Graf:
> >
> > Any reason we're so incredibly inconsistent in what we do during realize
> > with reset? I would really prefer to ensure we're doing the same thing
> > on all targets.
> >
> >
> > Alex
> >
> > $ grep -R -A 3 -B 3
On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
> have been removed because @fmt of error_report() should not contain newline.
>
> Signed
Checks the output visitor behaviour for NULL values.
Signed-off-by: Marcel Apfelbaum
---
tests/test-qmp-output-visitor.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/tests/test-qmp-output-visitor.c b/tests/test-qmp-output-visitor.c
index 9c15458..74020de 100644
--- a/tests/te
V1 -> V2:
- Rebased on qom-next queue.
- Patch 1/4:
- Since there are a lot of discussions on the correct
way to do the fix, added a FIXME comment to find a better way.
- Patch 2/4:
- Addressed Michael Roth's comments:
- Added output visitor test
- Tweaked it as advised
-
Filter out also 'type' property when setting
object's properties
Reviewed-by: Paolo Bonzini
Signed-off-by: Marcel Apfelbaum
---
vl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 2de90fb..2153b9e 100644
--- a/vl.c
+++ b/vl.c
@@ -2889,7 +2889,8 @@ static
Make machine's QemuOpts QOM properties of machine. The properties
are automatically filled in. This opens the possiblity to create
opts per machine rather than global.
Signed-off-by: Marcel Apfelbaum
---
hw/core/machine.c | 256
include/hw/b
A NULL value is not added to visitor's stack, but there
is no check for that when the visitor tries to return
that value, leading to Qemu crash.
Reviewed-by: Eric Blake
Acked-by: Luiz Capitulino
Signed-off-by: Marcel Apfelbaum
---
qapi/qmp-output-visitor.c | 6 ++
1 file changed, 6 inserti
On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote:
> V1 -> V2:
> - Rebased on qom-next queue.
> - Patch 1/4:
>- Since there are a lot of discussions on the correct
> way to do the fix, added a FIXME comment to find a better way.
> - Patch 2/4:
>- Addressed Michael Ro
The Thursday 22 May 2014 à 11:42:50 (+0200), Stefan Hajnoczi wrote :
> Normally one would expect that qcow2 image file lengths are multiples of
> the cluster size. This is not true in all cases and the spec should
> document this so implementers remember to accept such files.
>
> $ qemu-img creat
Two options for making progress on this bug:
1. Debug bdrv_drain_all() and find out whether there are any I/O
requests remaining.
Yes, there is one request pending on active layer of disk that is being
commited (on bs->tracked_requests list). IO threads die off because they
have nothing t
>[quoted lines by Peter Maydell on 2014/05/25 at 10:11 +0100]
>Ah, I see. Still, I think it makes more sense for the queue and delay
>to be in the common key handling code, not in the curses frontend
>specifically.
This patch, attached as qemu-kbddelay-1.patch, is a rework of the former curses
U
On 23/05/2014 10:40, Eric Auger wrote:
> On 05/11/2014 07:13 PM, Alvise Rigo wrote:
>> The flag is mandatory for the ARM SMMU so we always add it if the MMIO
>> handles it.
>
> Hi Alvise,
>
> Refering to the root problem explanation found in
> https://lkml.org/lkml/2014/2/8/176, I understand the
On Sa, 2014-05-24 at 21:21 -0400, Dave Mielke wrote:
> [quoted lines by Peter Maydell on 2014/05/25 at 01:04 +0100]
>
> >Why is this a problem only for the curses UI frontend, and not for
> >any of the other UIs which might send key events?
>
> One reason is that most UIs send key events as they
On Tue, May 13, 2014 at 08:04:13PM +0200, Lluís Vilanova wrote:
> Adds support to compile QEMU with multiple tracing backends at the same time.
>
> For example, you can compile QEMU with:
>
> $ ./configure --enable-trace-backends=ftrace,dtrace
>
> Where 'ftrace' can be handy for having an in-f
On 26/05/14 09:32, Alexander Graf wrote:
The macio IDE controller has some pretty nasty magic in its implementation to
allow for unaligned sector accesses. We used to handle these accesses
synchronously inside the IO callback handler.
However, the block infrastructure changed below our feet and
Hallo to all, this is my first post here.
I have exactly the same problem occurred after Distribution Update
Ubuntu Server x64 from 12.04.4 to 14.04.
1. I have Windows 7 32/64-Bit and Windows 2008 Server 64-Bit VMs, all
show the same error with two dedicated cores (no pinning). In
combination wit
Stefan Hajnoczi writes:
> On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
>> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
>> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt argument
>> have been removed because @fmt of error_report() should n
Am 26.05.2014 um 17:02 hat Markus Armbruster geschrieben:
> Stefan Hajnoczi writes:
>
> > On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
> >> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
> >> block-migration.c and blockdev.c. The trailing "\n"s of the @fmt a
[quoted lines by Gerd Hoffmann on 2014/05/26 at 15:38 +0200]
>Tried to make the curses ui a bit more clever? You could try caching
>the modifier state, then send only the changes. That gets the number of
>events down to 6 max (4 to update modifier state, 2 for the actual key).
Yes, except that,
From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson
[r...@twiddle.net]
Sent: Saturday, May 17, 2014 8:11 PM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/2] ta
From: James Hogan [ja...@albanarts.com]
Sent: Thursday, May 22, 2014 2:03 AM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; Petar Jovanovic; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal Register
> I think you
From: James Hogan [ja...@albanarts.com] on behalf of James Hogan
Sent: Thursday, May 22, 2014 2:19 AM
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic; Petar Jovanovic; aurel...@aurel32.net
Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips: implement UserLocal
On 05/22/2014 04:08 AM, Tom Musta wrote:
> On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
>> This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
>> EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
>>
>> This adds MMCR2/FSCR/MMCRS SPRs.
>>
>> Signed-off-by: Alexey Kardashevskiy
>> -
On 05/21/2014 08:47 PM, Alexander Graf wrote:
>
> On 21.05.14 08:20, Alexey Kardashevskiy wrote:
>> This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
>> EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
>>
>> This adds MMCR2/FSCR/MMCRS SPRs.
>>
>> Signed-off-by: Alexey Kardashevskiy
Hi,
When using virtio disk plug/unplug with Q35 machine I see two problems.
Note that when using the same sequence with default 440FX I see no issues.
A) 'pcie.0' does not support hotplugging'
I can workaround this problem if I manually specify "-readconfig
/usr/share/qemu-153/Q35-chipset.cf
Kevin Wolf writes:
> Am 26.05.2014 um 17:02 hat Markus Armbruster geschrieben:
>> Stefan Hajnoczi writes:
>>
>> > On Mon, May 26, 2014 at 09:44:03AM +0800, Le Tan wrote:
>> >> Replace fprintf(stderr,...) with error_report() in files block/*, block.c,
>> >> block-migration.c and blockdev.c. The
Am 26.05.2014 14:40, schrieb Marcel Apfelbaum:
> Make machine's QemuOpts QOM properties of machine. The properties
> are automatically filled in. This opens the possiblity to create
> opts per machine rather than global.
>
> Signed-off-by: Marcel Apfelbaum
> ---
> hw/core/machine.c | 256
> ++
Am 26.05.2014 14:48, schrieb Michael S. Tsirkin:
> On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote:
>> V1 -> V2:
>> - Rebased on qom-next queue.
>> - Patch 1/4:
>>- Since there are a lot of discussions on the correct
>> way to do the fix, added a FIXME comment to find a
Hi list,
Many services timeout in OpenIndiana (151a8 Server Build 32 bit x86) during
boot when i use the tcg accelerator. This is pushing the boot time of the
OS to more than 45 mins depending on the number of CPUs activated.
I did the tests with qemu-system-i386 -smp sockets=4,cores=1,threads=1
On 05/26/2014 03:20 AM, Andreas Färber wrote:
> Alpha is the main blocker for unifying CPU reset iirc. It does not
> implement reset at all and thus is not calling it. The struct was not
> designed for zero'ing things, so there's a mix of data fields and
> pointers without clear separation to allow
From: Petar Jovanovic
>From MIPS documentation (Volume III):
UserLocal Register (CP0 Register 4, Select 2)
Compliance Level: Recommended.
The UserLocal register is a read-write register that is not interpreted by
the hardware and conditionally readable via the RDHWR instruction.
This register
Most of them are probably harmless. Copying qemu-stable anyway, just
in case. Also fix two qemu-io bugs I found while investigating its
leaks.
Markus Armbruster (14):
qemu-img: Plug memory leak on block option help error path
block/vvfat: Plug memory leak in enable_write_target()
qcow2: Pl
blockdev_init() leaks bs_opts when qemu_opts_create() fails, i.e. when
the ID is bad. Missed in commit ec9c10d.
Signed-off-by: Markus Armbruster
---
blockdev.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 1cbcc1c..6460c70 100644
--- a/bl
Instead of ignoring all option values but the last one, multiple -o
options now have the same meaning as having a single option with all
settings in the order of their respective -o options.
Same as commit 2dc8328 for qemu-img convert, except here we do it with
QemuOpts rather than QEMUOptionParam
Reproducer: "open -o a=b". Broken in commit fd0fee3.
Signed-off-by: Markus Armbruster
---
qemu-io.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index ffbad25..0daf413 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -61,7 +61,8 @@ static int openfile(
On error path. Introduced in commit a046433a. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 6a0d246..2c82a5c 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1864
Has always been leaky. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block/vvfat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 2c82a5c..389704a 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -787,7 +787,9 @@ static in
Introduced in commit f298d07. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
blockdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 6460c70..7ec7d79 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -941,6 +941,7 @@ DriveInfo *drive_init(QemuOpts *al
Has always been leaky. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block/sheepdog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 2c3fb01..9a9a307 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -2149,6 +2
Introduced in commit 661a0f7. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 62ea27e..d118da5 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1455,7 +1455,7 @@ static int img_con
Introduced in commit a283cb6; mostly harmless. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
qemu-img.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-img.c b/qemu-img.c
index 1ad899e..62ea27e 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -287,6 +287,7 @@ static int print_bl
Introduced in commit a8d8ecb. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block/qapi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qapi.c b/block/qapi.c
index 75f44f1..97e1641 100644
--- a/block/qapi.c
+++ b/block/qapi.c
@@ -475,6 +475,7 @@ static void dump_qobject(f
Quoting Andreas Färber (2014-05-26 11:42:45)
> Am 26.05.2014 14:48, schrieb Michael S. Tsirkin:
> > On Mon, May 26, 2014 at 03:40:54PM +0300, Marcel Apfelbaum wrote:
> >> V1 -> V2:
> >> - Rebased on qom-next queue.
> >> - Patch 1/4:
> >>- Since there are a lot of discussions on the correct
>
Introduced in commit da557a. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block.c b/block.c
index 40c5e1a..1996f84 100644
--- a/block.c
+++ b/block.c
@@ -1196,6 +1196,7 @@ int bdrv_open_image(BlockDriverState **pbs, const
Introduced in commit 5a8a30d. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block/qcow2.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index a4b97e8..a54d2ba 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1308,6 +1308,7 @@ s
Introduced in commit b543c5c. Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
qemu-io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qemu-io.c b/qemu-io.c
index ef3fef6..ffbad25 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -175,6 +175,7 @@ static int open_f(BlockDriverState *bs, i
I figure the leak originated in bdrv_create2(), and was duplicated
into callers when commit 91a073ak dropped that function. Looks like
the other places have since been fixed.
Spotted by Coverity.
Signed-off-by: Markus Armbruster
---
block/vvfat.c | 1 +
1 file changed, 1 insertion(+)
diff --g
On 26.05.14 17:45, Alexey Kardashevskiy wrote:
On 05/22/2014 04:08 AM, Tom Musta wrote:
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
This adds MMCR2/FSCR/MMCRS SPRs.
Signed-
On 26.05.14 17:50, Alexey Kardashevskiy wrote:
On 05/21/2014 08:47 PM, Alexander Graf wrote:
On 21.05.14 08:20, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/TEXASR/TEXASRU SPRs.
This adds MMCR2/FSCR/MMCRS SPRs.
Signe
On 26.05.14 15:56, Mark Cave-Ayland wrote:
On 26/05/14 09:32, Alexander Graf wrote:
The macio IDE controller has some pretty nasty magic in its
implementation to
allow for unaligned sector accesses. We used to handle these accesses
synchronously inside the IO callback handler.
However, the b
On 26.05.14 14:36, Andreas Färber wrote:
Am 26.05.2014 12:31, schrieb Alexander Graf:
On 26.05.14 12:20, Andreas Färber wrote:
Am 26.05.2014 11:57, schrieb Alexander Graf:
Any reason we're so incredibly inconsistent in what we do during realize
with reset? I would really prefer to ensure we'r
Am 26.05.2014 19:28, schrieb Petar Jovanovic:
> From: Petar Jovanovic
>
> From MIPS documentation (Volume III):
>
> UserLocal Register (CP0 Register 4, Select 2)
> Compliance Level: Recommended.
>
> The UserLocal register is a read-write register that is not interpreted by
> the hardware and co
On 05/26/2014 10:28 AM, Petar Jovanovic wrote:
> void helper_mtc0_hwrena(CPUMIPSState *env, target_ulong arg1)
> {
> -env->CP0_HWREna = arg1 & 0x000F;
> +uint32_t mask = 0x000F;
> +
> +if (env->CP0_Config3 & (1 << CP0C3_ULRI)) {
> +mask |= 0x2000;
> +}
> +
> +
The timer registers on our KeyLargo macio emulation are read as byte reversed
from the big endian guest, so we better expose them endian reversed as well.
This fixes initial hickups of booting Mac OS X with -M mac99 for me.
Signed-off-by: Alexander Graf
---
hw/misc/macio/macio.c | 2 +-
1 file
On 05/27/2014 06:09 AM, Alexander Graf wrote:
>
> On 26.05.14 17:45, Alexey Kardashevskiy wrote:
>> On 05/22/2014 04:08 AM, Tom Musta wrote:
>>> On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU/
EBBHR/EBBRR/BESCR/TFHAR/TFIAR/
On 27.05.14 02:23, Alexey Kardashevskiy wrote:
On 05/27/2014 06:09 AM, Alexander Graf wrote:
On 26.05.14 17:45, Alexey Kardashevskiy wrote:
On 05/22/2014 04:08 AM, Tom Musta wrote:
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
This adds helper which adds TAR/BESCRS/BESCRSU/BESCRR/BESCRRU
Certain parts of the QOM framework test this pointer to determine if
an object is parented. Nuke it when the object is unparented to allow
for reuse of an object after unparenting.
Signed-off-by: Peter Crosthwaite
---
qom/object.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qom/object.c
From: Richard Henderson [rth7...@gmail.com] on behalf of Richard Henderson
[r...@twiddle.net]
Sent: Tuesday, May 27, 2014 12:53 AM
To: Petar Jovanovic; qemu-devel@nongnu.org
Cc: Petar Jovanovic; aurel...@aurel32.net; James Hogan
Subject: Re: [v2 PATCH] tar
On 05/26/2014 06:21 PM, Petar Jovanovic wrote:
> Because we do not know the content of CP0_HWREna.
We can know the same way we know the content of CP0_Config3.
r~
From: Gonglei
Spotted by Coverity:
(7) Event closed_arg: "write_dump_pages(DumpState *)" closes "s->fd". [details]
Also see events: [pass_closed_arg]
1490ret = write_dump_pages(s);
(8) Event cond_false: Condition "ret < 0", taking false branch
1491if (ret < 0) {
1492
From: Gonglei
Fix some errors spotted by Coverity.
Gonglei (8):
vnc-enc-tight: Fix divide-by-zero in
tight_detect_smooth_image{16,24,32}
vga: Fix divide-by-zero in vga_update_text
json-parser: fix two coverity defects
qcow2-cluster: Fix memory leak in copy_sectors
qemu-bridge-helpe
From: Gonglei
potted by Coverity:
(20) Event cond_true: Condition "cursor_visible", taking true branch
(21) Event cond_true: Condition "cursor_offset < size", taking true branch
(22) Event cond_true: Condition "cursor_offset >= 0", taking true branch
2097if (cursor_visible && cursor_offs
From: Gonglei
Pointer "token" returned by "parser_context_pop_token(ctxt)" is never used.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
qobject/json-parser.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qobject/json-parser.c b/qobject/json-parser.c
index e46
From: Gonglei
Spotted by Coverity:
(1) Event unreachable: This code cannot be reached: "abort();".
112 abort();
Signed-off-by: Gonglei
---
hw/i2c/pm_smbus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c
index fedb5fb..da09eb0 100644
--- a/h
101 - 200 of 234 matches
Mail list logo
