[Qemu-devel] [PATCH 2/8] bitmap dump code via QAPI framework

2014-05-26 Thread Sanidhya Kashyap
Following are the changes made with respect to the previous version: Chen's advice 1) Replaced DIRTY_MEMORY_LOG_BITMAP with DIRTY_MEMORY_MIGRATION and completely removed the DIRTY_MEMORY_LOG_BITMAP flag. Eric's advice 2) Replaced FILE pointer with file descriptor. 3) Replaced fopen/fclose with qem

[Qemu-devel] [PULL 04/23] nbd: Miscellaneous typo fixes.

2014-05-26 Thread Michael Tokarev
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Acked-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev --- nbd.c |2 +- qemu-nbd.c|2 +- qemu-nbd.texi |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/nbd.c b/nbd.c

[Qemu-devel] [PULL 00/23] Trivial patches for 2014-05-26

2014-05-26 Thread Michael Tokarev
Here's another trivial patches pull request. This time it accumulated 23 patches, in many areas, with a focus, for some reason, on libcacard, which received quite some cleanups and a fix for a fun bug. More interesting changes this time are by Peter Maydell, -- these are the bswap.h macros renami

[Qemu-devel] [PULL 02/23] iohandler.c: Properly initialize sigaction struct

2014-05-26 Thread Michael Tokarev
From: Peter Maydell The code in qemu_init_child_watch() wasn't clearing the 'struct sigaction' before passing it to sigaction(); this meant that we would block a random set of signals while executing the SIGCHLD handler. Initialize properly by using memset() on the struct, as we do in similar cas

[Qemu-devel] [PULL 01/23] libcacard: g_malloc cleanups

2014-05-26 Thread Michael Tokarev
This patch replaces g_malloc() in libcacard into g_new() or g_new0() where appropriate (removing some init-to-zero surrounding code), g_malloc+memcpy into g_memdup() and the like. Signed-off-by: Michael Tokarev Reviewed-by: Alon Levy --- libcacard/cac.c| 11 +++ libcacard/

[Qemu-devel] [PULL 07/23] jazz_led: Add missing break in switch case

2014-05-26 Thread Michael Tokarev
From: Saravanakumar Signed-off-by: Saravanakumar Reviewed-by: Paolo Bonizni Signed-off-by: Michael Tokarev --- hw/display/jazz_led.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/jazz_led.c b/hw/display/jazz_led.c index e9bb005..12b1707 100644 --- a/hw/display/jazz_led.c +

[Qemu-devel] [PULL 05/23] configure: Automatically select GTK+ 3.0 if GTK+ 2.0 is unavailable

2014-05-26 Thread Michael Tokarev
From: Stefan Weil The configure option --with-gtkabi=3.0 is still supported, but no longer needed when GTK+-2.0 is missing. When no GTK+ ABI is selected by the user, configure first tries 2.0, then 3.0. For some platforms (e.g. Windows) newer binaries of GTK+ are only available for GTK+ 3.0. Now

[Qemu-devel] [PULL 13/23] libcacard/vscclient: Bury some dead code

2014-05-26 Thread Michael Tokarev
From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy Signed-off-by: Michael Tokarev --- libcacard/vscclient.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 3477a

[Qemu-devel] [PULL 19/23] libcacard: fix wrong array expansion logic

2014-05-26 Thread Michael Tokarev
The currrent code in libcacard/vcard_emul_nss.c:vcard_emul_options() has a weird bug in variable usage around expanding opts->vreader array. There's a helper variable, vreaderOpt, which is first needlessly initialized to NULL, next, conditionally, only we have to expand opts->vreader, receives arr

[Qemu-devel] [PULL 10/23] dma-helpers: avoid calling dma_bdrv_unmap() twice

2014-05-26 Thread Michael Tokarev
From: Jules Wang Calling dma_bdrv_unmap() twice is not necessary and may cause potential problems if some code changes. Signed-off-by: Jules Wang Reviewed-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- dma-helpers.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Qemu-devel] [PULL 08/23] pci: move dereferencing of root only after verifying valid root pointer

2014-05-26 Thread Michael Tokarev
From: Saravanakumar Signed-off-by: Saravanakumar Reviewed-by: Andreas Färber Reviewed-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- hw/pci/pci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 22fe5ee..8d6a8d4 100644 --- a/h

[Qemu-devel] [PULL 21/23] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-05-26 Thread Michael Tokarev
From: Le Tan Replace fprintf(stderr,...) with error_report() in files bsd-user/*. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan Signed-off-by: Michael Tokarev --- bsd-user/bsdload.c |2 +- bsd-use

[Qemu-devel] [PULL 20/23] audio: replace fprintf(stderr, ...) with error_report() in audio

2014-05-26 Thread Michael Tokarev
From: Le Tan Replace fprintf(stderr,...) with error_report() in files audio/*. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan Signed-off-by: Michael Tokarev --- audio/spiceaudio.c |2 +- audio/wavc

[Qemu-devel] [PULL 09/23] arch_init: replace fprintf(stderr, ...) with error_report()

2014-05-26 Thread Michael Tokarev
From: Le Tan Replace fprintf(stderr,...) with error_report() in the file arch_init.c. The trailing "\n"s of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan Reviewed-by: Andreas Färber Signed-off-by: Michael Tokarev --- arch

[Qemu-devel] [PULL 14/23] libcacard: Plug memory leaks around vreader_get_reader_list()

2014-05-26 Thread Michael Tokarev
From: Markus Armbruster Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy Signed-off-by: Michael Tokarev --- libcacard/vcard_emul_nss.c |4 libcacard/vscclient.c |1 + 2 files changed, 5 insertions(+) diff --git a/libcacard/vcard_emul_nss.c b/lib

[Qemu-devel] [PULL 16/23] libcacard/vreader: Tighten assertion to clarify intent

2014-05-26 Thread Michael Tokarev
From: Markus Armbruster Bonus: hushes up Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy Signed-off-by: Michael Tokarev --- libcacard/vreader.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/vreader.c b/libcacard/vreader.c index 93b01c8..f1

[Qemu-devel] [PULL 15/23] libcacard/vreader: Drop broken recovery from failed assertion

2014-05-26 Thread Michael Tokarev
From: Markus Armbruster We suppress some code when we got unexpected status and assertion checking is off: assert(card_status == VCARD_DONE); if (card_status == VCARD_DONE) { int size = MIN(*receive_buf_len, response->b_total_len); memcpy(receive_buf, response->b_data

[Qemu-devel] [PULL 23/23] libcacard: remove useless initializers

2014-05-26 Thread Michael Tokarev
libcacard has many functions which initializes local variables at declaration time, which are always assigned some values later (often right after declaration). Clean up these initializers. Signed-off-by: Michael Tokarev --- libcacard/cac.c| 14 +++--- libcacard/card_7816.

Re: [Qemu-devel] [Qemu-trivial] [PATCH net v1 0/4] Cadence GEM patches

2014-05-26 Thread Peter Crosthwaite
On Sat, May 24, 2014 at 5:17 PM, Michael Tokarev wrote: > 24.05.2014 03:06, Peter Crosthwaite wrote: >> Ping^2! >> >> I'll try trivial queue too :) > > Actually this looks like trivial material. > > I'll comment in one place, for all. > > Peter Crosthwaite (4): net: cadence_gem: Fix Tx

Re: [Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits

2014-05-26 Thread Gerd Hoffmann
On Sa, 2014-05-24 at 11:02 +0400, Michael Tokarev wrote: > 24.05.2014 04:16, Andrew Oates wrote: > > Without the mask, control bits are passed on in the keycode, generating > > incorrect PS/2 sequences when SHIFT, ALT, etc are held down. > > While the patch itself appears to be trivial, it may hav

[Qemu-devel] [PULL 03/10] input: add name to input_event_key_number

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 2 +- ui/input.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/trace-events b/trace-events index b6d289d..0870204 100644 --- a/trace-events +++ b/trace-events @@ -1050,7 +1050,7 @@ gd_update(int x, int y, int w, int h)

[Qemu-devel] [PULL 09/10] usb: add input routing support for tablet and keyboard

2014-05-26 Thread Gerd Hoffmann
Add display property to the keyboard. Add display and head properties to the tablet. If properties are set bind device to the display specified to setup input routing. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hid.c | 13 + 1 file changed, 13 insertions(+) diff --git a/hw/usb/dev

[Qemu-devel] [PULL 01/10] input (curses): mask keycodes to remove modifier bits

2014-05-26 Thread Gerd Hoffmann
From: Andrew Oates Without the mask, control bits are passed on in the keycode, generating incorrect PS/2 sequences when SHIFT, ALT, etc are held down. Cc: qemu-sta...@nongnu.org Signed-off-by: Andrew Oates Signed-off-by: Gerd Hoffmann --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+)

[Qemu-devel] [PULL 00/10] input: add event routing and multiseat support.

2014-05-26 Thread Gerd Hoffmann
Hi, Input layer continued: Adding input routing for multiseat. Also has some bugfixes. please pull, Gerd The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-22 19:04:49 +0100) a

[Qemu-devel] [PULL 04/10] input: keymap: add meta keys

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-keymap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/input-keymap.c b/ui/input-keymap.c index 4c4f0d0..5d29935 100644 --- a/ui/input-keymap.c +++ b/ui/input-keymap.c @@ -13,6 +13,8 @@ static const int qcode_to_number[] = { [Q_KEY_CODE_CT

[Qemu-devel] [PULL 02/10] input: add qemu_input_key_number_to_qcode

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input-keymap.c | 11 --- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h index 3d3d487..d84ed8b 100644 --- a/include/ui/input.h +++ b/include/ui/input.h @@ -36,6 +36,7 @@

[Qemu-devel] [PULL 07/10] input: bind devices and input routing

2014-05-26 Thread Gerd Hoffmann
Add function to bind input devices to display devices. Implementing input routing on top of this: Events coming from the display device in question are routed to the input device bound to it (if there is one). Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 3 +++ ui/input.c | 4

[Qemu-devel] [PULL 05/10] input: switch hid keyboard to new input layer api.

2014-05-26 Thread Gerd Hoffmann
Minimal patch to get the switchover done. We continue processing ps/2 scancodes for now as they are part of the live migration stream. Fixing that, then mapping directly from QKeyValue to HID keycodes is left as excercise for another day. Signed-off-by: Gerd Hoffmann --- hw/input/hid.c

[Qemu-devel] [PULL 08/10] sdl: pass key event source to input layer

2014-05-26 Thread Gerd Hoffmann
So the input layer knows where the input is coming from and input routing works correctly. Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index 361de61..0e884f9 100644 --- a/ui/sdl2.c +++

[Qemu-devel] [PULL 06/10] input: switch hid mouse and tablet to the new input layer api.

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/input/hid.c | 193 +++-- include/hw/input/hid.h | 1 - 2 files changed, 123 insertions(+), 71 deletions(-) diff --git a/hw/input/hid.c b/hw/input/hid.c index ff75e41..295bdab 100644 --- a/hw/input/hid.c +++

[Qemu-devel] [PULL 10/10] docs: add multiseat.txt

2014-05-26 Thread Gerd Hoffmann
Howto on setting up multiseat for guests. Signed-off-by: Gerd Hoffmann --- docs/multiseat.txt | 76 ++ 1 file changed, 76 insertions(+) create mode 100644 docs/multiseat.txt diff --git a/docs/multiseat.txt b/docs/multiseat.txt new file mode 1

[Qemu-devel] [PULL 12/23] vl: fix 'name' option to work with -readconfig

2014-05-26 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" The 'name' option silently failed when used in config files ( http://lists.gnu.org/archive/html/qemu-devel/2014-04/msg00378.html ) -readconfig stores the configuration read in QemuOpts. Command line option parsing should do the same, and no more. In particular it

[Qemu-devel] [PULL 17/23] libcacard: Convert two leftover realloc() to GLib

2014-05-26 Thread Michael Tokarev
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy Signed-off-by: Michael Tokarev --- libcacard/cac.c| 13 ++--- libcacard/vcard_emul_nss.c |7 ++- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/libcacard/cac.c b/libc

[Qemu-devel] [PULL 03/23] nbd: Close socket on negotiation failure.

2014-05-26 Thread Michael Tokarev
From: Hani Benhabiles Otherwise, the nbd client may hang waiting for the server response. Signed-off-by: Hani Benhabiles Acked-by: Paolo Bonzini Signed-off-by: Michael Tokarev --- blockdev-nbd.c |4 ++-- qemu-nbd.c |4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff -

[Qemu-devel] [PULL 22/23] net: cadence_gem: Fix top comment

2014-05-26 Thread Michael Tokarev
From: Peter Crosthwaite To indicate Cadence GEM not Xilinx. Signed-off-by: Peter Crosthwaite Signed-off-by: Michael Tokarev --- hw/net/cadence_gem.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 47e7038..a26861e 100644

Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: change default QEMU machine to pc-i440fx-1.6

2014-05-26 Thread Fabio Fantoni
Il 25/05/2014 16:14, Stefano Stabellini ha scritto: On Fri, 23 May 2014, Fabio Fantoni wrote: Il 23/05/2014 18:07, Stefano Stabellini ha scritto: Choose pc-i440fx-1.6 instead of pc for HVM guests, so that we know for sure what is the machine that we are emulating. Use pc-i440fx-1.6 regardless

[Qemu-devel] [PULL 06/23] bswap.h: Rename ldl_p, stl_p, etc to ldl_he_p, stl_he_p, etc

2014-05-26 Thread Michael Tokarev
From: Peter Maydell We have an unfortunate naming clash between the functions ldl_p, stl_p, etc defined in bswap.h (which have semantics "load/store in host endianness") and the #defines of the same name in cpu-all.h (which have the semantics "load/store in target endianness"). Fortunately it tu

[Qemu-devel] [PULL 05/24] gtk: remove page numbering assumtions from the code

2014-05-26 Thread Gerd Hoffmann
Lookup page numbers using gtk_notebook_page_num() instead. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6a3fe00..49753ef 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -

[Qemu-devel] [PULL 00/24] gtk: ui overhaul, multiwindow support.

2014-05-26 Thread Gerd Hoffmann
Hi, This series adds multiwindow support to the gtk ui. Also brings some cleanups and bugfixes. cheers, Gerd The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-22 19:04:49 +0100)

[Qemu-devel] [PULL 09/24] gtk: use device type as label

2014-05-26 Thread Gerd Hoffmann
IMO useful than showing VGA for any graphic device even in case it is something completely different. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 0756432..a8393dd 100644 --- a/ui/gtk.c +++

[Qemu-devel] [PULL 04/24] gtk: Add a scrollbar for text consoles

2014-05-26 Thread Gerd Hoffmann
From: Cole Robinson Only show the scrollbar if the content doesn't fit on the visible space. [ kraxel: fix box packing ] Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) d

[Qemu-devel] [PULL 01/24] gtk: zap scrolled_window

2014-05-26 Thread Gerd Hoffmann
The vte widget implements the scrollable interface, placing it into a scrolled window is pointless and creates a bunch of strange effects. Zap it. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.

[Qemu-devel] [PULL 03/24] gtk: cleanup CONFIG_VTE ifdef a bit.

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 776e72d..068a39b 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -108,8 +108,8 @@ static const int modifier_keycode[] = {

[Qemu-devel] [PULL 19/24] gtk: detached window pointer grabs

2014-05-26 Thread Gerd Hoffmann
Make ungrab hotkey work with detached windows. Enable pointer grabs for detached windows. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 8215841..298419b 100644 --- a/ui/gtk.c +++ b

[Qemu-devel] [PULL 08/24] gtk: support multiple gfx displays

2014-05-26 Thread Gerd Hoffmann
Each display gets its own tab. Tab switching continues to work like it did, just the hotkeys of the vte consoles changes in case a secondary display is present as it will get ctrl-alt-2 assigned and the vtes are shifted by one. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 80

[Qemu-devel] [PULL 15/24] gtk: skip keyboard grab when hover autograb is active

2014-05-26 Thread Gerd Hoffmann
It's pointless. With grab on hover enabled the keyboard grab is already active when you press Ctrl-Alt-G ;) Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index d87bd1b..f804813 100644 --- a/ui/gtk.c +++ b/ui/

[Qemu-devel] [PULL 20/24] gtk: enable untabify for gfx

2014-05-26 Thread Gerd Hoffmann
Now we have all grab fixes in place, so we can allow detaching graphic display tabs too. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 298419b..79dc8db 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -33

[Qemu-devel] [PULL 10/24] gtk: simplify resize

2014-05-26 Thread Gerd Hoffmann
Simply ask for a small window size. When the widgets don't fit in gtk will automatically make the window large enougth to make things fit, no need to try (and fail) duplicate that logic in qemu. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 40 ++-- 1 file chan

[Qemu-devel] [PULL 18/24] gtk: update all windows on mouse mode changes

2014-05-26 Thread Gerd Hoffmann
We might have multiple graphic displays now which all need a cursor update. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 91b6824..8215841 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -553,6 +553,7 @@ stati

[Qemu-devel] [PULL 13/24] gtk: add gd_grab trace event

2014-05-26 Thread Gerd Hoffmann
Input grab code is tricky, add some debug & trouble shooting aid. Signed-off-by: Gerd Hoffmann --- trace-events | 1 + ui/gtk.c | 4 2 files changed, 5 insertions(+) diff --git a/trace-events b/trace-events index 3a41abf..e42 100644 --- a/trace-events +++ b/trace-events @@ -1048,6

[Qemu-devel] [PULL 12/24] gtk: add tab to trace events

2014-05-26 Thread Gerd Hoffmann
So you can see which of multiple displays (if present) was resized ;) Signed-off-by: Gerd Hoffmann --- trace-events | 6 +++--- ui/gtk.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/trace-events b/trace-events index b6d289d..3a41abf 100644 --- a/trace-events +++

[Qemu-devel] [PULL 07/24] gtk: move vga state into VirtualGfxConsole

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 615 ++- 1 file changed, 337 insertions(+), 278 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 78f6ccc..bc42f68 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -105,6 +105,18 @@ static const int

[Qemu-devel] [PULL 16/24] gtk: update gd_update_caption

2014-05-26 Thread Gerd Hoffmann
Adapt to recent changes, handle multiple windows. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index f804813..7d6a20d 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -271,

[Qemu-devel] [PULL 14/24] gtk: keep track of grab owner

2014-05-26 Thread Gerd Hoffmann
Simplifies grab state tracking and makes ungrab more reliable. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 0e35abf..d87bd1b 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -185,6 +18

[Qemu-devel] [PULL 02/24] gtk: zap vte size requests

2014-05-26 Thread Gerd Hoffmann
The vte tabs simply get the size of the vga tab then, with whatever cols and lines are fitting in. I find this bahavior more useful than resizing the qemu window all day long. YMMV. Comments are welcome. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 14 -- 1 file changed, 14 deletio

[Qemu-devel] [PULL 22/24] gtk: zap unused global_state

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a55ceb4..0d86025 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -204,8 +204,6 @@ struct GtkDisplayState { bool has_evdev; }; -static GtkDisplayState *global_state; - static

[Qemu-devel] [PULL 17/24] gtk: fix grab checks

2014-05-26 Thread Gerd Hoffmann
Make it handle multiple windows case correctly. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 7d6a20d..91b6824 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -201,6 +201,9 @@

[Qemu-devel] [PULL 24/24] gtk: workaround gtk2 vte resize issue

2014-05-26 Thread Gerd Hoffmann
Hack isn't pretty, but gets the job done. See source code comment for details. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 40 1 file changed, 40 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index ac5dbe0..b908936 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @

[Qemu-devel] [PULL 23/24] gtk: window sizing overhaul

2014-05-26 Thread Gerd Hoffmann
Major overhaul for window size handling. This basically switches qemu over to use geometry hints for the window manager instead of trying to get the job done with widget resize requests. This allows to specify better what we need and also avoids window resizes. FIXME: on gtk2 someone overwrites

[Qemu-devel] [PATCH] macio ide: Do remainder access asynchronously

2014-05-26 Thread Alexander Graf
The macio IDE controller has some pretty nasty magic in its implementation to allow for unaligned sector accesses. We used to handle these accesses synchronously inside the IO callback handler. However, the block infrastructure changed below our feet and now it's impossible to call a synchronous b

[Qemu-devel] [PULL 06/24] gtk: VirtualConsole restruction

2014-05-26 Thread Gerd Hoffmann
Move all vte-related items into VirtualVteConsole substruct. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 119 +++ 1 file changed, 73 insertions(+), 46 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 49753ef..78f6ccc 100644 --- a/ui

Re: [Qemu-devel] [PATCH v2 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-05-26 Thread Peter Maydell
On 26 May 2014 05:25, Edgar E. Iglesias wrote: > On Thu, May 22, 2014 at 09:30:06PM -0500, Rob Herring wrote: >> From: Rob Herring >> >> Add the infrastructure to handle and emulate hvc and smc exceptions. >> This will enable emulation of things such as PSCI calls. This commit >> does not change

[Qemu-devel] [PULL 11/23] configure: Put tempfiles in a subdir of the build directory

2014-05-26 Thread Michael Tokarev
From: Peter Maydell When libtool support was added to configure, the new temporary files were left out of the list of files cleaned up on exit; this results in a lot of stale .lo files being left around in /tmp. Worse, libtool creates a /tmp/.libs directory which we can't easily clean up. Put al

[Qemu-devel] [PULL 4/5] console: rework text terminal cursor logic

2014-05-26 Thread Gerd Hoffmann
Have a global timer. Update all visible terminal windows syncronously. Right now this can be the active_console only, but that will change soon. The global timer will disable itself if not needed, so we only have to care start it if needed. Which might be at console switch time or when a new dis

[Qemu-devel] [PULL 0/5] console: text terminal updates

2014-05-26 Thread Gerd Hoffmann
Hi, This pull prepares qemu text consoles (-chardev vc) for multiwindow support. Also some small fixes. please pull, Gerd The following changes since commit 178ac111bca16c08a79b2609ebdc75197bea976a: Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging (2014-05-22 1

[Qemu-devel] [PULL 3/5] console: update text terminal surface unconditionally

2014-05-26 Thread Gerd Hoffmann
These days each QemuConsole has its own private DisplaySurface, so we can simply render updates all the time. Signed-off-by: Gerd Hoffmann --- ui/console.c | 127 ++- 1 file changed, 56 insertions(+), 71 deletions(-) diff --git a/ui/consol

[Qemu-devel] [PATCH trivial v2 0/4] Cadence GEM patches

2014-05-26 Thread Peter Crosthwaite
Hi Michael, Found a bug in the Cadence GEM. Fixed in P1. Have some follow up trivials as well (P2-4). Changed since v1: Addressed mjt review Dropped "top comment patch" (applied to trivial already). Fixed other &foo[0] usages Regards, Peter Peter Crosthwaite (4): net: cadence_gem: Fix Tx de

[Qemu-devel] [PULL 1/5] console: Abort on property access errors

2014-05-26 Thread Gerd Hoffmann
From: Kirill Batuzov All defined properties of QemuConsole are mandatory and no access to them should fail. Nevertheless not checking returned errors is bad because in case of unexpected failure it will hide the bug and cause a memory leak. Abort in case of unexpected property access errors. Thi

[Qemu-devel] [PULL 2/5] console: nicer initial screen

2014-05-26 Thread Gerd Hoffmann
Now that we have a function to create a fancy DisplaySurface with a message for the user, to handle non-existing graphics hardware, we can make it more generic and use it for other things too. This patch adds a text line to the in initial DisplaySurface, notifying the user that the display isn't i

[Qemu-devel] [PATCH trivial v2 1/4] net: cadence_gem: Fix Tx descriptor update

2014-05-26 Thread Peter Crosthwaite
The local variable "desc" was being used to read-modify-write the first descriptor (of a multi-desc packet) upon packet completion. desc however continues to be used by the code as the current descriptor. Give this first desc RMW it's own local variable to avoid trampling. Signed-off-by: Peter Cro

[Qemu-devel] [PATCH trivial v2 3/4] net: cadence_gem: Comment spelling sweep

2014-05-26 Thread Peter Crosthwaite
Fix some typos in comments. Signed-off-by: Peter Crosthwaite --- hw/net/cadence_gem.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index f0e9f5b..7cd4b54 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c

[Qemu-devel] [PATCH trivial v2 2/4] net: cadence_gem: Add Tx descriptor fetch printf

2014-05-26 Thread Peter Crosthwaite
Add a debug printf for TX descriptor fetching. This helpful to anyone needing to debug TX ring buffer traversal. Its also now consistent with the RX code which has a similar printf. Signed-off-by: Peter Crosthwaite --- changed since v1: don't cast to unsigned (mjt review). hw/net/cadence_gem.c

[Qemu-devel] [PULL 03/10] xhci: add xhci_get_flag

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index a203bc6..54dea16 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -621,6 +621,11 @@ static const char *ep_state_name

[Qemu-devel] [PULL 00/10] usb queue: usb3 streams, xhci + mtp fixes

2014-05-26 Thread Gerd Hoffmann
Hi, Finally support for usb3 streams is coming. The depending bits landed upstream (kernel 3.15, libusbx 1.0.19, usbredir 0.7), time to get the qemu support upstream too. This pull also has some xhci and mtp bugfixes. please pull, Gerd The following changes since commit 178ac111bca16c08a79

[Qemu-devel] [PULL 04/10] usb-mtp: use bool to track MTPObject init status

2014-05-26 Thread Gerd Hoffmann
Stop setting nchildren to -1. Use separate bool variable to track whenever we've already fetched the child objects instead. Also make nchildren unsigned. Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 14 -- 1 file changed, 8 insertions(+), 6 deleti

[Qemu-devel] [PULL 09/10] usb-host-libusb: Add alloc / free streams ops

2014-05-26 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 3fdbd93..401eb74 100644 --- a/hw/usb/

[Qemu-devel] [PULL 02/10] xhci: add endpoint cap on express bus only

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 6753a42..a203bc6 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -3594,8 +3594,10 @@ static int usb_xhci_initfn(struct

[Qemu-devel] [PULL 08/10] usb-host-libusb: Fill in endpoint max_streams when available

2014-05-26 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 57bed09..3fdbd93 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb

[Qemu-devel] [PULL 01/10] xhci: child detach fix

2014-05-26 Thread Gerd Hoffmann
xhci_child_detach() zaps the wrong slot when unplugging a device connected via usb-hub: Instead of the device's slot the slot of the usb-hub is used. Fix it. https://bugzilla.redhat.com/show_bug.cgi?id=1075846 Signed-off-by: Gerd Hoffmann Reviewed-by: Gonglei --- hw/usb/hcd-xhci.c | 2 +- 1

[Qemu-devel] [PATCH trivial v2 4/4] net: cadence_gem: Remove &desc[0] usages

2014-05-26 Thread Peter Crosthwaite
Just use desc instead. Signed-off-by: Peter Crosthwaite --- hw/net/cadence_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 7cd4b54..7d3355e 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -883,7 +883

[Qemu-devel] [PULL 05/10] usb-mtp: handle lseek failure

2014-05-26 Thread Gerd Hoffmann
Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index c2750e4..a95298b 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -702,7 +702,10 @@ static MTPData

Re: [Qemu-devel] Disk image fuzz testing (OPW)

2014-05-26 Thread Kevin Wolf
Hi Maria, Am 26.05.2014 um 07:07 hat M.Kustova geschrieben: > My name is Maria and I'm a participant of the Outreach Program for Women. > My project is fuzz testing of support of qcow2 image format. > > The project git: > https://github.com/maxalab/qemu_fuzzer.git > > It's pubic, so welcome, ma

[Qemu-devel] [PULL] target-xtensa: fix cross-page jumps/calls at the end of TB

2014-05-26 Thread Max Filippov
t: git://github.com/OSLL/qemu-xtensa.git tags/20140526-xtensa for you to fetch changes up to 57a740514d2f68330ae408894b4c5ab01cfb0a83: target-xtensa: add tests for cross-page TB (2014-05-26 12:33:54 +0400) Xtensa fixes queue 2014-05

[Qemu-devel] [PULL 10/10] usb-host-libusb: Set stream id when submitting bulk-stream transfers

2014-05-26 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 401eb74..8007d1d 100644 --- a/hw/usb/host-libusb.c

[Qemu-devel] [PULL 07/10] usb-redir: Add support for bulk streams

2014-05-26 Thread Gerd Hoffmann
From: Hans de Goede Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 137 -- 1 file changed, 132 insertions(+), 5 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 287a505..4c6187b 100644

[Qemu-devel] [PULL 06/10] usb-mtp: handle usb_mtp_get_object failure

2014-05-26 Thread Gerd Hoffmann
Cc: Dr. David Alan Gilbert Signed-off-by: Gerd Hoffmann --- hw/usb/dev-mtp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index a95298b..380b465 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -46,6 +46,7 @@ enum mtp_cod

[Qemu-devel] [PATCH 5/5] usb: improve ehci/uhci test

2014-05-26 Thread Gerd Hoffmann
* Attach usb devices to the bus. * Check initial port status register state. * Flip ehci initialization bit. * Check port status register state again to see whenever device handover to ehci worked. Signed-off-by: Gerd Hoffmann --- tests/Makefile| 4 +- tests/usb-hcd-ehci-tes

[Qemu-devel] [PATCH 2/5] usb: move uhci register defines to header file

2014-05-26 Thread Gerd Hoffmann
So we can easily use them in tests. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-uhci.c | 36 +--- include/hw/usb/uhci-regs.h | 39 +++ 2 files changed, 40 insertions(+), 35 deletions(-) create mode 100644 include/hw/us

[Qemu-devel] [PATCH 4/5] usb: move ehci register defines to header file

2014-05-26 Thread Gerd Hoffmann
So we can easily use them in tests. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 79 +--- include/hw/usb/ehci-regs.h | 82 ++ 2 files changed, 83 insertions(+), 78 deletions(-) create mode 10064

[Qemu-devel] [PATCH 1/5] qtest: fix qpci_config_writel

2014-05-26 Thread Gerd Hoffmann
Found by Paolo. Signed-off-by: Gerd Hoffmann --- tests/libqos/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c index 7e0907b..c9a0b91 100644 --- a/tests/libqos/pci.c +++ b/tests/libqos/pci.c @@ -103,7 +103,7 @@ void qpci_config_wri

[Qemu-devel] [PATCH] usb: add usb_pick_speed

2014-05-26 Thread Gerd Hoffmann
We can pick the usb port speed in generic code, by looking at the port and device speed masks and looking for the fastest match. So add a function to do exactly that, and drop the speed setting code from usb_desc_attach as it isn't needed any more. This way we can set the device speed before call

[Qemu-devel] [PATCH 0/5] usb: improve ehci/uhci test

2014-05-26 Thread Gerd Hoffmann
Hi, Started hacking on the ehci test case. please review, Gerd Gerd Hoffmann (5): qtest: fix qpci_config_writel usb: move uhci register defines to header file usb: add uhci port status reserved bit usb: move ehci register defines to header file usb: improve ehci/uhci test hw/usb/

[Qemu-devel] [PATCH] usb-host: allow attaching usb3 devices to ehci

2014-05-26 Thread Gerd Hoffmann
Extend compatibility test function to also figure whenever usb3 devices can be supported on ehci. Tweak ep0 maxpacketsize field due to usb2 <-> usb3 difference. Signed-off-by: Gerd Hoffmann --- hw/usb/host-libusb.c | 62 +--- 1 file changed, 54 in

[Qemu-devel] [PATCH 3/5] usb: add uhci port status reserved bit

2014-05-26 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/hw/usb/uhci-regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/usb/uhci-regs.h b/include/hw/usb/uhci-regs.h index 63c8223..c7315c5 100644 --- a/include/hw/usb/uhci-regs.h +++ b/include/hw/usb/uhci-regs.h @@ -27,6 +27,7 @@ #define UHCI_P

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039

2014-05-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben: >> On Wed, 05/14 15:12, Markus Armbruster wrote: >> > The shell script attempts to suppress core dumps like this: >> > >> > old_ulimit=$(ulimit -c) >> > ulimit -c 0 >> > $QEMU_IO arg... >> > ulimit -c "$old_ul

[Qemu-devel] [PULL 5/5] console: add kbd_put_keysym_console

2014-05-26 Thread Gerd Hoffmann
So you can send keysyms to a specific (text terminal) console. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 + ui/console.c | 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 8a86617..b513e20 100644

[Qemu-devel] [PULL 18/23] libcacard/vcard_emul_nss: Drop a redundant conditional

2014-05-26 Thread Michael Tokarev
From: Markus Armbruster Bailing out when PK11_FindGenericObjects() returns null ensures the loop that follows it executes at least once. The "loop did not execute" test right after it is useless. Drop it. Spotted by Coverity. Signed-off-by: Markus Armbruster Reviewed-by: Alon Levy Signed-of

[Qemu-devel] [PULL 11/24] gtk: allow moving tabs to windows and back.

2014-05-26 Thread Gerd Hoffmann
"View->Detach tab" will move to tab to a new window. Simply closing the window will move it back into a notebook tab. The label will be permamently stored in VirtualConsole->label, so it can easily be reused to (re-)label tabs and windows. Works for vte tabs only for now. pointer/kbd grab code nee

[Qemu-devel] BUG: commit 50a2c6e breaks KVM/ARM (reset/init vcpu order)

2014-05-26 Thread Christoffer Dall
Hi, I noticed that commit 50a2c6e55fa2ce5a2916a2c206bad2c6b0e06df1 broke KVM/ARM, because the realize function (arm_cpu_realizefn()) now calls cpu_reset() before qemu_init_vcpu(), which causes kvm_arm_reset_cpu() to segfault because it dereferences cpu->cpreg_reset_values, which is not allocated b

[Qemu-devel] [PULL 21/24] gtk: Add handling for the xfree86 keycodes

2014-05-26 Thread Gerd Hoffmann
From: Bruce Rogers Currently only evdev keycodes are handled by the gtk-ui. SDL has code to handle both. This patch adds similar processing so that both keycode types will be handled via the gtk-ui. Signed-off-by: Bruce Rogers Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 36 +++

  1   2   3   >