Hi,
> > According to our discussions, I realize we may have some plans or policies
> > dedicated to how to assign devfn, but to support GFX passthrough for XEN, I
> > think currently it may be a better solution to adopt #1 simply like this:
> >
> > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_pi
> > /* lookup */
> > -if (port_offset)
> > -snprintf(port, sizeof(port), "%d", atoi(port) + port_offset);
> > +if (port_offset) {
> > +unsigned long long baseport;
>
> unsigned long long is not necessary, unsigned long is enough.
>
> > +if (parse_uint_full(por
Don't use atoi() function which doesn't detect errors, switch to
strtol and error out on failures. Also add a range check while
being at it.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Markus Armbruster
---
util/qemu-sockets.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-
On Do, 2014-05-22 at 04:05 +, Gonglei (Arei) wrote:
> > -Original Message-
> > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> > Behalf Of Gerd Hoffmann
> > Sent: Wednesday, May 21, 2014 6:54 PM
> > To:
Hi,
> > Works perfectly fine for me.
> > What vnc client is this?
> >
> I tested two kinds of vnc clients:
> 1) VNC Viewer Free Edition 4.1.2
> 2) TightVNC Viewer for Windows Version 2.6.4
Ah, windows vnc clients. I've tested with linux.
I'll have a look. Do you have download links for me?
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, May 22, 2014 2:00 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org
> Subject: Re: [RFC] How to deal with the conflict between DE keymap and qemu
> console ?
>
> Hi,
>
> > > Works perfectly fine fo
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, May 22, 2014 1:44 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking
>
> > > /* lookup */
> > > -if (port_offset)
> > >
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, May 22, 2014 1:40 PM
> To: Chen, Tiejun
> Cc: Anthony PERARD; Daniel P. Berrange; peter.mayd...@linaro.org;
> xen-de...@lists.xensource.com; m...@redhat.com;
> stefano.stabell...@eu.citrix.com; Kay, Alle
Hi,
> I noticed that some issues with the old code still exist: when "Show
> tabs" is enabled and disabled again, QEMU adds some black scan lines at
> the top of the VGA screen. This can be easily reproduced.
Easily fixed, was just a missing "gd_update_windowsize" call.
> Another small
> probl
This makes the SG_IO code of non-dataplane available to dataplane, so that
dataplane can use to allow scsi=on.
Fam
Fam Zheng (2):
virtio-blk: Factor out virtio_blk_handle_scsi_req from
virtio_blk_handle_scsi
dataplane: Support VIRTIO_BLK_T_SCSI_CMD
hw/block/dataplane/virtio-blk.c | 19
The common logic to process a scsi request in a VirtQueueElement is
extracted to a function to share with dataplane.
Signed-off-by: Fam Zheng
---
hw/block/virtio-blk.c | 77 ++
include/hw/virtio/virtio-blk.h | 3 ++
2 files changed, 43 insertions
Signed-off-by: Fam Zheng
---
hw/block/dataplane/virtio-blk.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c
index 46a6824..6a66196 100644
--- a/hw/block/dataplane/virtio-blk.c
+++ b/hw/bloc
Hi,
> > Another useful thing would be to not create the xen platform device in case
> > "-nodefaults" was specified on the command line (that switch turns off a
> > bunch
> > of other devices present by default: vga, nic, cdrom, ...).
>
> Currently looks 'xen-platform' itself can't be created,
On Tue, 05/20 22:23, Max Reitz wrote:
> As out-of-tree builds are preferred for qemu, running the qemu-iotests
> in that out-of-tree build should be supported as well. To do so, a
> symbolic link has to be created pointing to the check script in the
> source directory. That script will check whethe
On Thu, May 22, 2014 at 08:44:41AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > Another useful thing would be to not create the xen platform device in
> > > case
> > > "-nodefaults" was specified on the command line (that switch turns off a
> > > bunch
> > > of other devices present by default: v
On 05/21/2014 10:42 PM, Alexey Kardashevskiy wrote:
> On 05/21/2014 08:35 PM, Alexander Graf wrote:
>>
>> On 21.05.14 12:13, Alexey Kardashevskiy wrote:
>>> On 05/21/2014 07:50 PM, Alexander Graf wrote:
On 21.05.14 11:33, Alexey Kardashevskiy wrote:
> On 05/21/2014 07:13 PM, Alexander Graf
Il 22/05/2014 08:24, Gerd Hoffmann ha scritto:
I suspect this is the menu bar. Current code tries to hide it by
forcing the widget size to 0x0. In gtk2 this results in a small white
line at the top of the screen, probably because the minimum widget size
in gtk is 1x1. In gtk3 this doesn't work
301 - 317 of 317 matches
Mail list logo
