Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-06 Thread Alexander Graf
On 06.05.14 01:27, Marcelo Tosatti wrote: On Mon, May 05, 2014 at 08:26:04PM +0200, Marcin Gibuła wrote: is it possible to have kvmclock jumping forward? Because I've reproducible case when at about 1 per 20 vm restores, VM freezes for couple of hours and then resumes with date few hundreds y

Re: [Qemu-devel] [PATCH 20/35] acpi: memory hotplug ACPI hardware implementation

2014-05-06 Thread Igor Mammedov
On Mon, 5 May 2014 14:20:25 +0200 Vasilis Liaskovitis wrote: > Hi, > > On Fri, Apr 04, 2014 at 03:36:45PM +0200, Igor Mammedov wrote: > > - implements QEMU hardware part of memory hotplug protocol > > described at "docs/specs/acpi_mem_hotplug.txt" > > - handles only memory add notification eve

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-06 Thread Alexander Graf
On 06.05.14 01:23, Marcelo Tosatti wrote: Hi Alexander, On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote: When we migrate we ask the kernel about its current belief on what the guest time would be. KVM_GET_CLOCK which returns the time in "struct kvm_clock_data". Yes :) How

Re: [Qemu-devel] [PATCH 34/35] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2014-05-06 Thread Igor Mammedov
On Mon, 05 May 2014 10:25:09 -0600 Eric Blake wrote: > On 04/04/2014 07:36 AM, Igor Mammedov wrote: > > also make handler edge based to avoid loosing events, the same as > > s/loosing/losing/ Thanks, I'll fix it. > > (loose rhymes with goose and means the opposite of "tight"; lose rhymes > wit

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-06 Thread Alexander Graf
On 06.05.14 01:31, Marcelo Tosatti wrote: On Mon, May 05, 2014 at 08:23:43PM -0300, Marcelo Tosatti wrote: Hi Alexander, On Mon, May 05, 2014 at 03:51:22PM +0200, Alexander Graf wrote: When we migrate we ask the kernel about its current belief on what the guest time would be. KVM_GET_CLOCK w

Re: [Qemu-devel] [RFC 0/5] Allow object-add on X86CPU subclasses, for CPU model probing

2014-05-06 Thread Igor Mammedov
On Fri, 2 May 2014 11:43:05 -0300 Eduardo Habkost wrote: > On Fri, May 02, 2014 at 03:45:03PM +0200, Igor Mammedov wrote: > > On Wed, 30 Apr 2014 17:29:28 -0300 > > Eduardo Habkost wrote: > > > > > This series allows management code to use object-add on X86CPU > > > subclasses, so it > > Is th

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-06 Thread Marcin Gibuła
What is the host clocksource? (cat /sys/devices/system/clocksource/clocksource0/current_clocksource). tsc And kernel version? 3.12.17 But I've seen this problem on earlier versions as well (3.8, 3.10). -- mg

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-06 Thread Peter Maydell
On 6 May 2014 07:08, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > I've been doing some work on modeling parts of EL2 and 3 + some of > the system-wide virtualization features for ARMv8. A lot is missing > but I've got a series with enough to for example run KVM A64 guests > on

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

2014-05-06 Thread Gonglei (Arei)
Hi, > > > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto: > > > > Public bug reported: > > > > > > > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu > > > upstream > > > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589a), but I am failed > at > > > the > > > > second time h

Re: [Qemu-devel] [PATCH v3 00/12] block/json: Add JSON protocol driver

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 06:19:07PM +0200, Max Reitz wrote: > On 10.04.2014 20:43, Max Reitz wrote: > >This series adds a passthrough JSON protocol block driver. Its filenames > >are JSON objects prefixed by "json:". The objects are used as options > >for opening another block device which will be t

Re: [Qemu-devel] [PATCH 009/124] vmstate: Refactor opening of files

2014-05-06 Thread Amit Shah
On (Mon) 21 Apr 2014 [16:39:49], Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/test-vmstate.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3

2014-05-06 Thread Alexander Graf
On 05/06/2014 08:08 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Hi, I've been doing some work on modeling parts of EL2 and 3 + some of the system-wide virtualization features for ARMv8. A lot is missing but I've got a series with enough to for example run KVM A64 guests on top of EL

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 05:32:09PM +0200, Kevin Wolf wrote: > Am 05.05.2014 um 17:21 hat Stefan Hajnoczi geschrieben: > > On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > > > This adds some common functionality to control QEMU for qemu-iotests. > > > > > > Additionally, test 085 is upd

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 11:44:55AM -0400, Jeff Cody wrote: > On Mon, May 05, 2014 at 05:32:09PM +0200, Kevin Wolf wrote: > > Am 05.05.2014 um 17:21 hat Stefan Hajnoczi geschrieben: > > > On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > > > > This adds some common functionality to contro

Re: [Qemu-devel] [PATCH 00/22] dataplane: use QEMU block layer

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 02:46:09PM +0200, Christian Borntraeger wrote: > On 05/05/14 14:05, Stefan Hajnoczi wrote: > > On Mon, May 05, 2014 at 11:17:44AM +0200, Christian Borntraeger wrote: > >> On 01/05/14 16:54, Stefan Hajnoczi wrote: > >>> This patch series switches virtio-blk data-plane from a

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-06 Thread Kevin Wolf
Am 06.05.2014 um 10:29 hat Stefan Hajnoczi geschrieben: > On Mon, May 05, 2014 at 05:32:09PM +0200, Kevin Wolf wrote: > > Am 05.05.2014 um 17:21 hat Stefan Hajnoczi geschrieben: > > > On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > > > > This adds some common functionality to control Q

Re: [Qemu-devel] [PATCH 1/3] s390x/helper: Fixed real-to-absolute address translation

2014-05-06 Thread Alexander Graf
On 05/05/2014 05:10 PM, Cornelia Huck wrote: From: Thomas Huth The real-to-absolute address translation in mmu_translate() was missing the second part for translating the page at the prefix address back to the 0 page. And while we're at it, also moved the code into a separate helper function si

Re: [Qemu-devel] [PATCH 0/5] glib thread interface and libcacard cleanups

2014-05-06 Thread Alon Levy
On 05/05/2014 07:36 PM, Michael Tokarev wrote: > 05.05.2014 18:49, Alon Levy wrote: >> On 04/29/2014 09:02 AM, Michael Tokarev wrote: >>> Basically libgthread has been rewritten in glib version 2.31, and old ways >>> to use thread primitives stopped working while new ways appeared. The two >>> int

[Qemu-devel] [PATCH v3.1 11/31] numa: introduce memory_region_allocate_system_memory

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- hw/i386/pc.c| 4 +--- include/hw/boards.h | 6 +- include/sysemu/sysemu.h | 1 + numa.c | 9 + 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc.c b/

[Qemu-devel] [PATCH v3.1 02/31] NUMA: check if the total numa memory size is equal to ram_size

2014-05-06 Thread Hu Tao
From: Wanlong Gao If the total number of the assigned numa nodes memory is not equal to the assigned ram size, it will write the wrong data to ACPI table, then the guest will ignore the wrong ACPI table and recognize all memory to one node. It's buggy, we should check it to ensure that we write t

[Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-06 Thread Hu Tao
This series includes work on QOMifying the memory backends. the idea is to delegate all properties of the memory backend to a new QOM class hierarchy, in which the concrete classes are hostmem-ram and hostmem-file. The backend is passed to the machine via "-numa node,memdev=foo" where "foo" is the

[Qemu-devel] [PATCH v3.1 09/31] qmp: improve error reporting for -object and object-add

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Use QERR_INVALID_PARAMETER_VALUE for consistency. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- qmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qmp.c b/qmp.c index ee99d3a..636e6f2 100644 --- a/qmp.c +++ b/qmp.c @@ -546,7 +546,8 @@ void

[Qemu-devel] [PATCH v3.1 08/31] qmp: allow object-add completion handler to get canonical path

2014-05-06 Thread Hu Tao
From: Igor Mammedov Add object to /objects before calling user_creatable_complete() handler, so that object might be able to call object_get_canonical_path() in its completion handler. Signed-off-by: Igor Mammedov Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- qmp.c | 11 ---

[Qemu-devel] [PATCH v3.1 15/31] memory: move mem_path handling to memory_region_allocate_system_memory

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Like the previous patch did in exec.c, split memory_region_init_ram and memory_region_init_ram_from_file, and push mem_path one step further up. Other RAM regions than system memory will now be backed by regular RAM. Also, boards that do not use memory_region_allocate_system_

[Qemu-devel] [PATCH v3.1 12/31] add memdev backend infrastructure

2014-05-06 Thread Hu Tao
From: Igor Mammedov Provides framework for splitting host RAM allocation/ policies into a separate backend that could be used by devices. Initially only legacy RAM backend is provided, which uses memory_region_init_ram() allocator and compatible with every CLI option that affects memory_region_i

[Qemu-devel] [PATCH v3.1 03/31] NUMA: Add numa_info structure to contain numa nodes info

2014-05-06 Thread Hu Tao
From: Wanlong Gao Add the numa_info structure to contain the numa nodes memory, VCPUs information and the future added numa nodes host memory policies. Reviewed-by: Eduardo Habkost Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao [Fix hw/ppc/spapr.c - Paolo] Signed-off-by: Paolo Bonzi

[Qemu-devel] [PATCH v3.1 07/31] vl: redo -object parsing

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Follow the lines of the HMP implementation, using OptsVisitor to parse the options. This gives access to OptsVisitor's rich parsing of integer lists. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- vl.c | 87 +++--

[Qemu-devel] [PATCH v3.1 18/31] memory: move RAM_PREALLOC_MASK to exec.c, rename

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Prepare for adding more flags. The "_MASK" suffix is unique, kill it. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- exec.c | 9 ++--- include/exec/cpu-all.h | 3 --- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/exec.c b/exec.

[Qemu-devel] [PATCH v3.1 06/31] man: improve -numa doc

2014-05-06 Thread Hu Tao
From: Luiz Capitulino The -numa option documentation in qemu's manpage lacks the command-line options and some information regarding how it relates to options -m and -smp. This commit fills in the missing text. Signed-off-by: Luiz Capitulino Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao

[Qemu-devel] [PATCH v3.1 28/31] qapi: make string output visitor parse int list

2014-05-06 Thread Hu Tao
Signed-off-by: Hu Tao --- qapi/string-output-visitor.c | 230 +++-- tests/test-string-output-visitor.c | 34 ++ 2 files changed, 254 insertions(+), 10 deletions(-) diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c index fb1d2e8..c

[Qemu-devel] [PATCH v3.1 10/31] pc: pass QEMUMachineInitArgs to pc_memory_init

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- hw/i386/pc.c | 11 +-- hw/i386/pc_piix.c| 8 +++- hw/i386/pc_q35.c | 4 +--- include/hw/i386/pc.h | 7 +++ 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/hw/i386/pc.c

[Qemu-devel] [PATCH v3.1 14/31] memory: reorganize file-based allocation

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Split the internal interface in exec.c to a separate function, and push the check on mem_path up to memory_region_init_ram. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- exec.c | 105 +--- include/exec/c

[Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy

2014-05-06 Thread Hu Tao
Signed-off-by: Hu Tao [Raise errors on setting properties if !CONFIG_NUMA. Add BUILD_BUG_ON checks. - Paolo] Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- backends/hostmem.c | 109 ++- include/sysemu/hostmem.h | 4 ++ qapi-schema.j

Re: [Qemu-devel] [PULL 28/31] curl: Remove unnecessary explicit calls to internal event handler

2014-05-06 Thread Laurent Desnogues
Hello, sorry for another late detection of the use of too recent features. On Wed, Apr 30, 2014 at 8:24 PM, Kevin Wolf wrote: > From: Matthew Booth > > Remove calls to curl_multi_do where the relevant handles are already > registered to the event loop. > > Ensure that we kick off socket handlin

[Qemu-devel] [PATCH v3.1 16/31] memory: add error propagation to file-based RAM allocation

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Right now, -mem-path will fall back to RAM-based allocation in some cases. This should never happen with "-object memory-file", prepare the code by adding correct error propagation. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- exec.c | 36 ++

[Qemu-devel] [PATCH v3.1 19/31] hostmem: add file-based HostMemoryBackend

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- backends/Makefile.objs | 1 + backends/hostmem-file.c | 108 2 files changed, 109 insertions(+) create mode 100644 backends/hostmem-file.c diff --git a/backends/Make

[Qemu-devel] [PATCH v3.1 24/31] configure: add Linux libnuma detection

2014-05-06 Thread Hu Tao
From: Wanlong Gao Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao Signed-off-by: Paolo Bonzini Signed-off-by: Hu Ta

[Qemu-devel] [PATCH v3.1 27/31] qapi: make string input visitor parse int list

2014-05-06 Thread Hu Tao
Signed-off-by: Hu Tao --- qapi/string-input-visitor.c | 181 -- tests/test-string-input-visitor.c | 39 2 files changed, 212 insertions(+), 8 deletions(-) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c index 793548a..0f6

[Qemu-devel] [PATCH v3.1 31/31] hmp: add info memdev

2014-05-06 Thread Hu Tao
This is the hmp counterpart of qmp query-memdev. Signed-off-by: Hu Tao --- hmp.c | 36 hmp.h | 1 + monitor.c | 7 +++ 3 files changed, 44 insertions(+) diff --git a/hmp.c b/hmp.c index ca869ba..bde0df9 100644 --- a/hmp.c +++ b/hmp.c @@ -22,6 +

[Qemu-devel] [PATCH v3.1 30/31] qmp: add query-memdev

2014-05-06 Thread Hu Tao
Add qmp command query-memdev to query for information of memory devices Signed-off-by: Hu Tao --- numa.c | 72 qapi-schema.json | 34 ++ qmp-commands.hx | 32 + 3 files changed, 13

[Qemu-devel] [PATCH v3.1 20/31] hostmem: separate allocation from UserCreatable complete method

2014-05-06 Thread Hu Tao
From: Paolo Bonzini This allows the superclass to set various policies on the memory region that the subclass creates. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- backends/hostmem-file.c | 9 - backends/hostmem-ram.c | 7 +++ backends/hostmem.c | 12 +

[Qemu-devel] [PATCH v3.1 22/31] hostmem: allow preallocation of any memory region

2014-05-06 Thread Hu Tao
From: Paolo Bonzini And allow preallocation of file-based memory even without -mem-prealloc. Some care is necessary because -mem-prealloc does not allow disabling preallocation for hostmem-file. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- backends/hostmem-file.c | 3 +++ backends

[Qemu-devel] [PATCH v3.1 29/31] qom: introduce object_property_get_enum and object_property_get_uint16List

2014-05-06 Thread Hu Tao
Signed-off-by: Hu Tao --- include/qom/object.h | 28 qom/object.c | 35 +++ 2 files changed, 63 insertions(+) diff --git a/include/qom/object.h b/include/qom/object.h index a641dcd..b882ccc 100644 --- a/include/qom/object.h +++

[Qemu-devel] [PATCH v3.1 26/31] Introduce signed range.

2014-05-06 Thread Hu Tao
Signed-off-by: Hu Tao --- include/qemu/range.h | 124 +++ 1 file changed, 124 insertions(+) diff --git a/include/qemu/range.h b/include/qemu/range.h index aae9720..8879f8a 100644 --- a/include/qemu/range.h +++ b/include/qemu/range.h @@ -3,6 +3,7 @@

[Qemu-devel] [PATCH v3.1 23/31] hostmem: add property to map memory with MAP_SHARED

2014-05-06 Thread Hu Tao
From: Paolo Bonzini A new "share" property can be used with the "memory-file" backend to map memory with MAP_SHARED instead of MAP_PRIVATE. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- backends/hostmem-file.c | 26 +- exec.c | 18 ++--

Re: [Qemu-devel] [Crucial bug] Qemu-2.0.0 do not support virtio-net hot plug/unplug exceed two times

2014-05-06 Thread Markus Armbruster
"Gonglei (Arei)" writes: > Hi, > >> > > Il 26/04/2014 10:56, Gonglei (Arei) ha scritto: >> > > > Public bug reported: >> > > > >> > > > I want to repeated hot-plug/unplug the virtio-net in the latest qemu >> > > upstream >> > > > (commit 839a5547574e57cce62f49bfc50fe1f04b00589a), but I am failed

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Allow setting default values for optional parameters

2014-05-06 Thread Markus Armbruster
Eric Blake writes: > On 05/05/2014 11:34 AM, Markus Armbruster wrote: >>> >>> Or, putting the question in reverse, you are asking if: >>> >>> data: { '*foo': 'str' } >>> >>> can blindly be rewritten into: >>> >>> data: { 'foo': { 'type': 'str', 'default': null } } >>> >>> and the rest of the intr

[Qemu-devel] [PATCH v3.1 17/31] memory: move preallocation code out of exec.c

2014-05-06 Thread Hu Tao
From: Paolo Bonzini So that backends can use it. Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- exec.c | 44 +-- include/qemu/osdep.h | 2 ++ util/oslib-posix.c | 73 3 files changed, 76

Re: [Qemu-devel] [PULL 28/31] curl: Remove unnecessary explicit calls to internal event handler

2014-05-06 Thread Kevin Wolf
Am 06.05.2014 um 11:44 hat Laurent Desnogues geschrieben: > Hello, > > sorry for another late detection of the use of too recent features. > > On Wed, Apr 30, 2014 at 8:24 PM, Kevin Wolf wrote: > > From: Matthew Booth > > > > Remove calls to curl_multi_do where the relevant handles are already

[Qemu-devel] Help needed testing on ppc

2014-05-06 Thread BALATON Zoltan
Hello, As I got no reply on the qemu-ppc list so far I try here maybe there are some people who read this list but don't follow the ppc one. I don't have the necessary hardware to do the testing needed for the patch below. Some context for the discussion can be found in this message: http://

[Qemu-devel] [PATCH v3.1 05/31] NUMA: expand MAX_NODES from 64 to 128

2014-05-06 Thread Hu Tao
From: Wanlong Gao libnuma choosed 128 for MAX_NODES, so we follow libnuma here. Signed-off-by: Wanlong Gao Reviewed-by: Eduardo Habkost Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- include/sysemu/sysemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/

Re: [Qemu-devel] [PATCH 34/35] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2014-05-06 Thread Laszlo Ersek
On 05/05/14 18:28, Paolo Bonzini wrote: > Il 05/05/2014 18:25, Eric Blake ha scritto: >>> > also make handler edge based to avoid loosing events, the same as >> s/loosing/losing/ >> >> (loose rhymes with goose and means the opposite of "tight"; lose rhymes >> with use and means the opposite of "gai

[Qemu-devel] [PATCH v3.1 04/31] NUMA: convert -numa option to use OptsVisitor

2014-05-06 Thread Hu Tao
From: Wanlong Gao Signed-off-by: Wanlong Gao Signed-off-by: Igor Mammedov Tested-by: Eduardo Habkost Reviewed-by: Eduardo Habkost Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- include/sysemu/sysemu.h | 3 +- numa.c | 145 +++--

[Qemu-devel] [PATCH v3.1 21/31] hostmem: add merge and dump properties

2014-05-06 Thread Hu Tao
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- backends/hostmem.c | 85 +++- include/qemu/osdep.h | 10 ++ include/sysemu/hostmem.h | 1 + 3 files changed, 95 insertions(+), 1 deletion(-) diff --git a/backe

[Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-06 Thread Kevin Wolf
The immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the backing file to be read-only, ignoring the r/w reopen of bdrv_commit(). The bigger

[Qemu-devel] [PATCH v3.1 01/31] NUMA: move numa related code to new file numa.c

2014-05-06 Thread Hu Tao
From: Wanlong Gao Signed-off-by: Wanlong Gao Reviewed-by: Eduardo Habkost Signed-off-by: Paolo Bonzini Signed-off-by: Hu Tao --- Makefile.target | 2 +- cpus.c| 14 include/exec/cpu-all.h| 2 - include/exec/cpu-common.h | 2 + include/sysemu/cpus

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 06:25:38PM +0200, Max Reitz wrote: > On 05.05.2014 14:26, Stefan Hajnoczi wrote: > >On Sat, May 03, 2014 at 04:47:08PM +0200, Max Reitz wrote: > >>@@ -56,22 +57,22 @@ for IMGOPTS in "compat=0.10" "compat=1.1"; do > >> echo === Create image with unknown header extension

[Qemu-devel] [PATCH v3.1 13/31] numa: add -numa node, memdev= option

2014-05-06 Thread Hu Tao
From: Paolo Bonzini This option provides the infrastructure for binding guest NUMA nodes to host NUMA nodes. For example: -object memory-ram,size=1024M,policy=bind,host-nodes=0,id=ram-node0 \ -numa node,nodeid=0,cpus=0,memdev=ram-node0 \ -object memory-ram,size=1024M,policy=interleave,host-n

Re: [Qemu-devel] [PULL v2 00/15] linux-user update

2014-05-06 Thread Peter Maydell
On 5 May 2014 20:00, wrote: > From: Riku Voipio > > The following changes since commit fdaad4715ae9e998fd0595bedfb16fdaf0c68ccc: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20140501' into staging (2014-05-02 > 11:32:00 +0100) > > are available in the git reposit

Re: [Qemu-devel] [PULL 7/8] gtk: Fix -serial vc

2014-05-06 Thread Jan Kiszka
On 2014-05-05 16:46, Gerd Hoffmann wrote: > On Mo, 2014-05-05 at 13:55 +0200, Gerd Hoffmann wrote: >> Hi, >> >>> Looks better thanks to "gtk: zap scrolled_window" (monitor is properly >>> formatted again). But the whole queue spits this out on the terminal: >>> >>> (:13169): Gtk-CRITICAL **: IA__

[Qemu-devel] [PATCH] Fix 'name' option to work with -readconfig

2014-05-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'name' option silently failed when used in config files ( http://lists.gnu.org/archive/html/qemu-devel/2014-04/msg00378.html ) Signed-off-by: Dr. David Alan Gilbert Reported-by: William Dauchy --- vl.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deleti

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-06 Thread Jan Kiszka
On 2014-05-06 12:19, Kevin Wolf wrote: > The immediately visible effect of this patch is that it fixes committing > a temporary snapshot to its backing file. Previously, it would fail with > a "permission denied" error because bdrv_inherited_flags() forced the > backing file to be read-only, ignori

Re: [Qemu-devel] [PULL] target-alpha update

2014-05-06 Thread Peter Maydell
On 3 May 2014 04:46, Richard Henderson wrote: > Ouch. Silly typo that wasn't found in the sniff-test kernel boots > I was using to test the branch. One must boot all the way to init > to see the breakage. > > Please pull. Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH] [v2 PATCH] qemu-img: sort block formats in help message

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 12:53:34PM -0400, Mike Day wrote: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints th

Re: [Qemu-devel] [PATCH] block/nfs: Check for NULL server part

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 08:27:49PM +0200, Max Reitz wrote: > After the URL has been parsed make sure the server part is valid in > order to avoid a segmentation fault when calling nfs_mount(). > > Signed-off-by: Max Reitz > --- > block/nfs.c | 4 > 1 file changed, 4 insertions(+) Thanks, a

Re: [Qemu-devel] [PATCH v5 12/21] block: define get_block_status return value

2014-05-06 Thread Kevin Wolf
Am 05.05.2014 um 16:58 hat Paolo Bonzini geschrieben: > Il 05/05/2014 16:34, Kevin Wolf ha scritto: > > I think we're missing the information whether the BDRV_BLOCK_ZERO flag > > actually comes from bs itself or from the backing chain. Do we need > > another flag or does someone have a better idea?

Re: [Qemu-devel] [PATCH] block/raw-posix: Fall back to SEEK_HOLE/SEEK_DATA

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 10:01:39PM +0200, Max Reitz wrote: > The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if > FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even > compiled in in this case. However, there may be implementations which > support the latter but not t

Re: [Qemu-devel] [PATCH v3 7/7] hw/net/stellaris_enet: Convert to vmstate

2014-05-06 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > Convert this device to use vmstate for its save/load, including > providing a post_load function that sanitizes inbound data to > avoid possible buffer overflows if it is malicious. > > The sanitizing fixes CVE-2013-4532 (though nobody should be

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Allow setting default values for optional parameters

2014-05-06 Thread Markus Armbruster
Eric Blake writes: > On 05/05/2014 07:30 PM, Fam Zheng wrote: > >>> NAME: { 'type': TYPE, 'default': DEFAULT } >>> >>> where >>> >>> NAME: { 'type': TYPE } >>> >>> can be abbreviated to >>> >>> NAME: TYPE > >> >> In data definition, we allow inline sub-structure: >> >> { 'type': 'Ve

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Allow setting default values for optional parameters

2014-05-06 Thread Markus Armbruster
Fam Zheng writes: > On Mon, 05/05 21:09, Eric Blake wrote: >> On 05/05/2014 07:30 PM, Fam Zheng wrote: >> >> >> NAME: { 'type': TYPE, 'default': DEFAULT } >> >> >> >> where >> >> >> >> NAME: { 'type': TYPE } >> >> >> >> can be abbreviated to >> >> >> >> NAME: TYPE >> >> > >> > In d

[Qemu-devel] [PATCH 03/22] gtk: cleanup CONFIG_VTE ifdef a bit.

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 45 ++--- 1 file changed, 26 insertions(+), 19 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 776e72d..068a39b 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -108,8 +108,8 @@ static const int modifier_keycode[] = {

[Qemu-devel] [PATCH 00/22] gtk: ui overhaul

2014-05-06 Thread Gerd Hoffmann
Hi, Here is the current gtk patch queue, featuring a ui overhaul. Overall goal is better multihead/multiseat support. Changes in this patch series: (1) Restruct code+data, move graphical display state to separate struct so we can have multiple instances. (2) Add support for multiple dis

[Qemu-devel] [PATCH 13/22] gtk: add gd_grab trace event

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 1 + ui/gtk.c | 4 2 files changed, 5 insertions(+) diff --git a/trace-events b/trace-events index 9b9d9d9..c93440d 100644 --- a/trace-events +++ b/trace-events @@ -1041,6 +1041,7 @@ ppm_save(const char *filename, void *display_surface) "%

[Qemu-devel] [PATCH 01/22] gtk: zap scrolled_window

2014-05-06 Thread Gerd Hoffmann
The vte widget implements the scrollable interface, placing it into a scrolled window is pointless and creates a bunch of strange effects. Zap it. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 19 ++- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.

[Qemu-devel] [PATCH 10/22] gtk: simplify resize

2014-05-06 Thread Gerd Hoffmann
Simply ask for a small window size. When the widgets don't fit in gtk will automatically make the window large enougth to make things fit, no need to try (and fail) duplicate that logic in qemu. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 40 ++-- 1 file chan

[Qemu-devel] [PATCH 12/22] gtk: add tab to trace events

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 6 +++--- ui/gtk.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/trace-events b/trace-events index a5218ba..9b9d9d9 100644 --- a/trace-events +++ b/trace-events @@ -1038,9 +1038,9 @@ displaychangelistener_unregister(

[Qemu-devel] [PATCH 09/22] gtk: use device type as label

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 0756432..a8393dd 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -67,6 +67,7 @@ #include "x_keymap.h" #include "keymaps.h" #include "sysemu/char.h" +#

[Qemu-devel] [PATCH 04/22] gtk: Add a scrollbar for text consoles

2014-05-06 Thread Gerd Hoffmann
From: Cole Robinson Only show the scrollbar if the content doesn't fit on the visible space. [ kraxel: fix box packing ] Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) d

[Qemu-devel] [PATCH 05/22] gtk: remove page numbering assumtions from the code

2014-05-06 Thread Gerd Hoffmann
Lookup page numbers using gtk_notebook_page_num() instead. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 40 ++-- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6a3fe00..49753ef 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -

[Qemu-devel] [PATCH 15/22] gtk: skip keyboard grab when hover autograb is active

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 02e4685..a00635a 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1183,7 +1183,9 @@ static void gd_menu_grab_input(GtkMenuItem *item, void *opaque) VirtualConso

[Qemu-devel] [PATCH 19/22] gtk: enable window pointer grabs

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 3754246..6cfb09c 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -773,10 +773,7 @@ static gboolean gd_button_event(GtkWidget *widget, GdkEvent

[Qemu-devel] [PATCH 07/22] gtk: move vga state into VirtualGfxConsole

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 615 ++- 1 file changed, 337 insertions(+), 278 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 78f6ccc..bc42f68 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -105,6 +105,18 @@ static const int

[Qemu-devel] [PATCH 06/22] gtk: VirtualConsole restruction

2014-05-06 Thread Gerd Hoffmann
Move all vte-related items into VirtualVteConsole substruct. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 119 +++ 1 file changed, 73 insertions(+), 46 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 49753ef..78f6ccc 100644 --- a/ui

[Qemu-devel] [PATCH 14/22] gtk: keep track of grab owner

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index b251976..02e4685 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -185,6 +185,8 @@ struct GtkDisplayState { int last_y; int grab_x

[Qemu-devel] [PATCH 16/22] gtk: update gd_update_caption

2014-05-06 Thread Gerd Hoffmann
Adapt to recent changes, handle multiple windows. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a00635a..2739cc8 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -271,

[Qemu-devel] [PATCH 02/22] gtk: zap vte size requests

2014-05-06 Thread Gerd Hoffmann
The vte tabs simply get the size of the vga tab then, with whatever cols and lines are fitting in. I find this bahavior more useful than resizing the qemu window all day long. YMMV. Comments are welcome. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 14 -- 1 file changed, 14 deletio

[Qemu-devel] [PATCH 11/22] gtk: allow moving tabs to windows and back.

2014-05-06 Thread Gerd Hoffmann
View->Untabify will move to tab to a new window. Simply closing the window will move it back into a notebook tab. The label will be permamently stored in VirtualConsole->label, so it can easily be reused to (re-)label tabs and windows. Works for vte tabs only for now. pointer/kbd grab code needs a

[Qemu-devel] [PATCH 08/22] gtk: support multiple gfx displays

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 80 ++-- 1 file changed, 43 insertions(+), 37 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index bc42f68..0756432 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1206,6 +1206,26 @@ static gboolean g

[Qemu-devel] [PATCH 17/22] gtk: fix grab checks

2014-05-06 Thread Gerd Hoffmann
--- ui/gtk.c | 35 +++ 1 file changed, 23 insertions(+), 12 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 2739cc8..5b1af8b 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -201,6 +201,9 @@ struct GtkDisplayState { static GtkDisplayState *global_state; +static voi

Re: [Qemu-devel] [PATCH v3 7/7] hw/net/stellaris_enet: Convert to vmstate

2014-05-06 Thread Peter Maydell
On 6 May 2014 12:53, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> +{ >> +stellaris_enet_state *s = opaque; >> +int i; >> + >> +/* Sanitize inbound state. Note that next_packet is an index but >> + * np is a size; hence their valid upper bound

[Qemu-devel] [PATCH 18/22] gtk: update all windows on mouse mode changes

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 5b1af8b..3754246 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -553,6 +553,7 @@ static void gd_change_runstate(void *opaque, int running, RunState state) static

Re: [Qemu-devel] [PATCH] improve emulation correctness

2014-05-06 Thread poletaev
Thank you for attention :) This patch not needed, according to QEMU dev policy, and so I will not sent it any more. I found another defect, and it not related with undefined flags. -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Friday, May 02, 2014 1:09 PM To:

Re: [Qemu-devel] [PATCH 5/6] input: switch sparc32 kbd to new input api

2014-05-06 Thread Gerd Hoffmann
Hi, > - put_queue(s, 0); // XXX, layout? > + put_queue(s, 0x21); // USA layout > Here is a mapping with corrected codes for arrows/pgup/pgdown... : > > static const uint8_t qcode_to_keycode[Q_KEY_CODE_MAX] = { [ ... ] Picked it up, thanks. > I have tried a 119 keys Sun USB ke

[Qemu-devel] [PATCH 20/22] gtk: enable untabify for gfx

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6cfb09c..37fe4a2 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -338,7 +338,11 @@ static void gd_update_windowsize(VirtualConsole *vc) gtk_widget_set_si

[Qemu-devel] [PATCH 22/22] gtk: zap unused global_state

2014-05-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index a9136ed..3355cb4 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -204,8 +204,6 @@ struct GtkDisplayState { bool has_evdev; }; -static GtkDisplayState *global_state; - static

Re: [Qemu-devel] [PATCH v8 0/4] qemu-img: add preallocation=full

2014-05-06 Thread Stefan Hajnoczi
On Wed, Apr 09, 2014 at 03:12:33PM +0800, Hu Tao wrote: > The purpose of this series is to use posix_fallocate() when creating > img file to ensure there are disk space for it which is way fast than > acturally writing to disk. But this only works in file system level. > For cases like thin provisi

Re: [Qemu-devel] Help needed testing on ppc

2014-05-06 Thread Tom Musta
On 5/6/2014 5:03 AM, BALATON Zoltan wrote: > Hello, > > As I got no reply on the qemu-ppc list so far I try here maybe there are some > people who read this list but don't follow the ppc one. > > I don't have the necessary hardware to do the testing needed for the patch > below. Some context fo

Re: [Qemu-devel] [PATCH net v1 1/1] net: xilinx_ethlite: Fix Rx-pong interrupt

2014-05-06 Thread Stefan Hajnoczi
On Mon, May 05, 2014 at 09:39:38PM -0700, Peter Crosthwaite wrote: > There is no CTRL_I bit in the pong buffer control register. The > CTRL_I bit from the ping buffer masks both ping and pong buffers. > Fix. > > Signed-off-by: Peter Crosthwaite > --- > > hw/net/xilinx_ethlite.c | 3 ++- > 1 fil

Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows

2014-05-06 Thread Stefan Hajnoczi
On Fri, Apr 18, 2014 at 08:24:03PM +0400, Stanislav Vorobiov wrote: > From: Sangho Park > > g_poll has a problem on Windows when using > timeouts < 10ms, in glib/gpoll.c: > > /* If not, and we have a significant timeout, poll again with > * timeout then. Note that this will return indication fo

Re: [Qemu-devel] [PATCH] block/raw-posix: Fall back to SEEK_HOLE/SEEK_DATA

2014-05-06 Thread Eric Blake
On 05/06/2014 05:49 AM, Stefan Hajnoczi wrote: > On Mon, May 05, 2014 at 10:01:39PM +0200, Max Reitz wrote: >> The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if >> FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even >> compiled in in this case. However, there may be

  1   2   3   >