Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Stefan Hajnoczi
On Fri, May 02, 2014 at 09:11:15AM -0400, Mike Day wrote: > The help message for qemu-img lists the supported block formats, of > which there are 27 as of version 2.0.50. The formats are printed in > the order of their driver's position in a linked list, which appears > random. This patch prints th

Re: [Qemu-devel] [RFC PATCH V4 5/6] target-arm: Common kvm_arm_vcpu_init() for KVM ARM and KVM ARM64

2014-05-05 Thread Rob Herring
On Mon, May 5, 2014 at 6:42 AM, Pranavkumar Sawargaonkar wrote: > Hi Peter, > > On 5 May 2014 16:14, Peter Maydell wrote: >> On 5 May 2014 10:00, Pranavkumar Sawargaonkar wrote: >>> Introduce a common kvm_arm_vcpu_init() for doing KVM_ARM_VCPU_INIT >>> ioctl in KVM ARM and KVM ARM64. This also h

[Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-05 Thread Alexander Graf
When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the kvm returned time. To make sure we never go backwards, calculate what the guest would have seen as time at t

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-05 Thread Eric Blake
On 05/05/2014 06:26 AM, Stefan Hajnoczi wrote: >> -[ ! -x $seq ] && chmod u+x $seq # ensure we can run it >> + >> +if [ "$(head -n 1 $seq)" == "#!/usr/bin/env python" ]; then >> +run_command="$PYTHON $seq" > > The code generally uses the older `` notation instead of $(

[Qemu-devel] [Bug 1314667] Building a USB-Drive with EasyToBoot (E2B) and PMPrebUSB

2014-05-05 Thread Ohlerth Hans
Hello Steve, I had a lot of trouble over the weekend building a sufficiently working bootable "USB-Rescue-Drive". I summed it up in an attached Word-Dokument and I am sure, you have the knowledge to solve my problems. For your detailed help I will expect with lots of kind regards H.Ohlerth A

Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2 compatible when kernel supports it

2014-05-05 Thread Rob Herring
On Mon, May 5, 2014 at 3:57 AM, Pranavkumar Sawargaonkar wrote: > If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then > we enable PSCI v0.2 for each VCPU at the time of VCPU init hence we > need to provide PSCI v0.2 compatible string via generated DTB. > > This patch updates generat

Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2 compatible when kernel supports it

2014-05-05 Thread Rob Herring
On Mon, May 5, 2014 at 9:06 AM, Rob Herring wrote: > On Mon, May 5, 2014 at 3:57 AM, Pranavkumar Sawargaonkar > wrote: >> If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then >> we enable PSCI v0.2 for each VCPU at the time of VCPU init hence we >> need to provide PSCI v0.2 compatib

Re: [Qemu-devel] [PATCH] configure: remove bashism

2014-05-05 Thread Paolo Bonzini
Il 02/05/2014 13:41, Michael Tokarev ha scritto: Commit e26110cfc67d48 added a check for shacmd to create a hash for modules. This check in configure is using bash construct &> to redirect both stdout and stderr, whcih does fun things on some shells. Get rid of it, use standard redirection inst

Re: [Qemu-devel] [PATCH v6 4/5] virtio: validate config_len on load

2014-05-05 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > Malformed input can have config_len in migration stream > exceed the array size allocated on destination, the > result will be heap overflow. > > To fix, that config_len matches on both sides. > > CVE-2014-0182 > > Reported-by: "Dr. David Alan Gilbert" > Signed-off-b

Re: [Qemu-devel] [PATCH v6 4/5] virtio: validate config_len on load

2014-05-05 Thread Juan Quintela
Juan Quintela wrote: > "Michael S. Tsirkin" wrote: >> Malformed input can have config_len in migration stream >> exceed the array size allocated on destination, the >> result will be heap overflow. >> >> To fix, that config_len matches on both sides. >> >> CVE-2014-0182 >> >> Reported-by: "Dr. Da

Re: [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup

2014-05-05 Thread Eric Blake
On 05/02/2014 06:44 AM, Markus Armbruster wrote: > Input and output marshalling functions do it differently. Change them > to work the same: initialize the I/O visitor, use it, clean it up, > initialize the dealloc visitor, use it, clean it up. > > This delays dealloc visitor initialization in ou

Re: [Qemu-devel] [PATCH v5 12/21] block: define get_block_status return value

2014-05-05 Thread Kevin Wolf
Am 04.09.2013 um 19:00 hat Paolo Bonzini geschrieben: > Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 > are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8 > are left for future extensions. > > The return code is compatible with the old is_allocated API: if a d

Re: [Qemu-devel] [RFC PATCH V4 4/6] hw/arm/virt: Use PSCI v0.2 compatible when kernel supports it

2014-05-05 Thread Peter Maydell
On 5 May 2014 15:09, Rob Herring wrote: > On Mon, May 5, 2014 at 9:06 AM, Rob Herring wrote: >> This does not compile for me: >> >> CCaarch64-softmmu/hw/arm/virt.o >> hw/arm/virt.c: In function ‘create_fdt’: >> hw/arm/virt.c:186:44: error: ‘KVM_CAP_ARM_PSCI_0_2’ undeclared (first >> use in

Re: [Qemu-devel] [PATCH] qapi: Document optional arguments' backwards compatibility

2014-05-05 Thread Eric Blake
On 05/05/2014 01:17 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > docs/qapi-code-gen.txt | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt > index d78921f..d7b19ab 100644 > --- a/docs/qapi-code-gen.txt > +++ b

Re: [Qemu-devel] [PULL 7/8] gtk: Fix -serial vc

2014-05-05 Thread Gerd Hoffmann
On Mo, 2014-05-05 at 13:55 +0200, Gerd Hoffmann wrote: > Hi, > > > Looks better thanks to "gtk: zap scrolled_window" (monitor is properly > > formatted again). But the whole queue spits this out on the terminal: > > > > (:13169): Gtk-CRITICAL **: IA__gtk_window_resize: assertion `width > > > 0

Re: [Qemu-devel] [PATCH 0/5] glib thread interface and libcacard cleanups

2014-05-05 Thread Alon Levy
On 04/29/2014 09:02 AM, Michael Tokarev wrote: > Basically libgthread has been rewritten in glib version 2.31, and old ways > to use thread primitives stopped working while new ways appeared. The two > interfaces were sufficiently different to warrant large ifdeffery across all > code using it. >

[Qemu-devel] [v5 PATCH 2/2] apic: use emulated lapic version 0x14 on pc machines >= 2.1

2014-05-05 Thread Gabriel L. Somlo
Add "version" property to local apic, and have it default to 0x14 for pc machines starting at 2.1. For compatibility with previous releases, pc machines up to 2.0 will have their local apic version set to 0x11. Signed-off-by: Gabriel L. Somlo --- hw/intc/apic.c | 2 +- hw/intc/a

[Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

2014-05-05 Thread Gabriel L. Somlo
On Mon, May 05, 2014 at 01:42:00PM +0200, Alexander Graf wrote: > From what I understand about the compat bits (which is little) this > makes a lot of sense. And the version is a proper property now, > which is great :). > > Acked-by: Alexander Graf Thanks! Here's a new version with only 8 bits

Re: [Qemu-devel] [PATCH v5 12/21] block: define get_block_status return value

2014-05-05 Thread Paolo Bonzini
Il 05/05/2014 16:34, Kevin Wolf ha scritto: > I think we're missing the information whether the BDRV_BLOCK_ZERO flag > actually comes from bs itself or from the backing chain. Do we need > another flag or does someone have a better idea? Not sure if it is a better idea :) but we can duplicate the

[Qemu-devel] [v5 PATCH 1/2] pc: add compat_props placeholder for 2.0 machine type

2014-05-05 Thread Gabriel L. Somlo
Add the "boilerplate" necessary for subsequent patches to simply drop in compat_props for pc machines 2.0 and older. This patch contains no functional changes. Signed-off-by: Gabriel Somlo --- hw/i386/pc_piix.c| 4 hw/i386/pc_q35.c | 4 include/hw/i386/pc.h | 9 + 3 fi

[Qemu-devel] [PATCH 0/3] qemu: pending s390 patches

2014-05-05 Thread Cornelia Huck
Here are some improvements for s390, available on https://github.com/cohuck/qemu.git s390-next Two patches deal with address translation, one fixes a problem in the channel subsystem code. Cornelia Huck (1): s390x/css: Don't save orb in subchannel. Thomas Huth (2): s390x/helper: Fixed real-

[Qemu-devel] [PATCH 3/3] s390x/css: Don't save orb in subchannel.

2014-05-05 Thread Cornelia Huck
Current css code saves the operation request block (orb) in the subchannel structure for later consumption by the start function handler. This might make sense for asynchronous execution of the start function (which qemu doesn't support), but not in our case; it would even be wrong since orb contai

[Qemu-devel] [PATCH 1/3] s390x/helper: Fixed real-to-absolute address translation

2014-05-05 Thread Cornelia Huck
From: Thomas Huth The real-to-absolute address translation in mmu_translate() was missing the second part for translating the page at the prefix address back to the 0 page. And while we're at it, also moved the code into a separate helper function since this might come in handy for other parts of

[Qemu-devel] [PATCH 2/3] s390x/helper: Added format control bit to MMU translation

2014-05-05 Thread Cornelia Huck
From: Thomas Huth With the EDAT-1 facility, the MMU translation can stop at the segment table already, pointing to a 1 MB block. And while we're at it, move the page table entry handling to a separate function, too, as suggested by Alexander Graf. Acked-by: Alexander Graf Signed-off-by: Thomas

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Allow setting default values for optional parameters

2014-05-05 Thread Eric Blake
On 05/05/2014 03:51 AM, Markus Armbruster wrote: >> Also, is the default value allowed to change between qemu versions? >> What are the back-compat ramifications if two different releases want to >> tweak an omitted variable to different defaults? The documentation >> should mention the rule of t

Re: [Qemu-devel] [PATCH 01/13] qapi: Update qapi-code-gen.txt example to match current code

2014-05-05 Thread Eric Blake
On 05/05/2014 12:49 AM, Markus Armbruster wrote: > Eric Blake writes: > >>> Example: >>> >>> mdroth@illuin:~/w/qemu2.git$ cat qapi-generated/example-qmp-marshal.c >> >> The file was missing the example command line that generated this file; >> I figured it out: >> >> mdroth@illuin:~/

[Qemu-devel] [Bug 1316115] [NEW] linux-user qemu-arm NEON support

2014-05-05 Thread Christopher Horler
Public bug reported: I was reading the mailing list and saw NEON support in QEmu was making progress. Is it not supported in user mode? or am I running into something else here? (I've tried to include some what may be useful information) using qemu from git (last commits as below): fdaad47 Mer

[Qemu-devel] [Bug 1297487] Re: MTU not honored in virtio vnet

2014-05-05 Thread Pierre Schweitzer
ii libselinux1 2.1.0-4.1ubuntu1 SELinux runtime shared libraries ii linux-firmware 1.79.12 Firmware for Linux kernel drivers ii linux-headers-3.2.0-60 3.2.0-60.91 Head

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Allow setting default values for optional parameters

2014-05-05 Thread Eric Blake
On 05/05/2014 05:06 AM, Markus Armbruster wrote: >> >> { 'command': 'block-commit', >> 'data': { 'device': 'str', '*base': 'str', 'top': 'str', >> '*speed': 'int' }, >> 'defaults': {'base': 'earthquake', 'speed': 100 } } >> > > Can we keep a parameter's properties

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-05 Thread Stefan Hajnoczi
On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > This adds some common functionality to control QEMU for qemu-iotests. > > Additionally, test 085 is updated to use this new functionality. > > Some minor fixups along the way, to clear up spaced pathname issues, > for common.rc, test 0

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-05 Thread Kevin Wolf
Am 05.05.2014 um 17:21 hat Stefan Hajnoczi geschrieben: > On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > > This adds some common functionality to control QEMU for qemu-iotests. > > > > Additionally, test 085 is updated to use this new functionality. > > > > Some minor fixups along t

Re: [Qemu-devel] [Bug 1316115] [NEW] linux-user qemu-arm NEON support

2014-05-05 Thread Peter Maydell
On 5 May 2014 13:09, Christopher Horler wrote: > Public bug reported: > > I was reading the mailing list and saw NEON support in QEmu was making > progress. > > Is it not supported in user mode? or am I running into something else > here? (I've tried to include some what may be useful informatio

Re: [Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

2014-05-05 Thread Jeff Cody
On Mon, May 05, 2014 at 05:32:09PM +0200, Kevin Wolf wrote: > Am 05.05.2014 um 17:21 hat Stefan Hajnoczi geschrieben: > > On Wed, Apr 30, 2014 at 10:55:07AM -0400, Jeff Cody wrote: > > > This adds some common functionality to control QEMU for qemu-iotests. > > > > > > Additionally, test 085 is upd

Re: [Qemu-devel] [PATCH 12/22] quorum: implement .bdrv_detach/attach_aio_context()

2014-05-05 Thread Benoît Canet
The Thursday 01 May 2014 à 16:54:36 (+0200), Stefan Hajnoczi wrote : > Implement .bdrv_detach/attach_aio_context() interfaces to propagate > detach/attach to BDRVQuorumState->bs[] children. The block layer takes > care of ->file and ->backing_hd but doesn't know about our ->bs[] > BlockDriverState

Re: [Qemu-devel] [PATCH] qcow2: Fix alloc_clusters_noref() overflow detection

2014-05-05 Thread Max Reitz
On 05.05.2014 11:36, Kevin Wolf wrote: Am 04.05.2014 um 05:31 hat Max Reitz geschrieben: If the very first allocation has a length of 0, the free_cluster_index is still 0 after the for loop, which means that subtracting one from it will underflow and signal an invalid range of clusters by return

Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

2014-05-05 Thread Michael S. Tsirkin
On Mon, May 05, 2014 at 10:52:49AM -0400, Gabriel L. Somlo wrote: > On Mon, May 05, 2014 at 01:42:00PM +0200, Alexander Graf wrote: > > From what I understand about the compat bits (which is little) this > > makes a lot of sense. And the version is a proper property now, > > which is great :). > >

Re: [Qemu-devel] [PATCH 33/35] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole

2014-05-05 Thread Vasilis Liaskovitis
Hi, On Mon, Apr 14, 2014 at 06:44:42PM +0200, Igor Mammedov wrote: > On Mon, 14 Apr 2014 15:25:01 +0800 > Hu Tao wrote: > > > On Fri, Apr 04, 2014 at 03:36:58PM +0200, Igor Mammedov wrote: > Could you be more specific, what and how doesn't work and why there is > need for SRAT entries per DIMM?

[Qemu-devel] [PATCH 2/7] target-arm: add powered off cpu state

2014-05-05 Thread Rob Herring
From: Rob Herring Add tracking of cpu power state in order to support powering off of cores in system emuluation. The initial state is determined by the start-powered-off QOM property. Signed-off-by: Rob Herring --- target-arm/cpu-qom.h | 1 + target-arm/cpu.c | 7 ++- 2 files changed,

Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

2014-05-05 Thread Andreas Färber
Am 05.05.2014 17:51, schrieb Michael S. Tsirkin: > On Mon, May 05, 2014 at 10:52:49AM -0400, Gabriel L. Somlo wrote: >> On Mon, May 05, 2014 at 01:42:00PM +0200, Alexander Graf wrote: >>> From what I understand about the compat bits (which is little) this >>> makes a lot of sense. And the version i

[Qemu-devel] [PATCH 0/7] ARM: add PSCI enulation support

2014-05-05 Thread Rob Herring
From: Rob Herring This series adds support for enulating ARM PSCI calls. PSCI or Power State Coordination Interface is an ARM standard for controlling cpu power states. This series supports both AArch32 and AArch64 using HVC or SMC calls. This series is based on Pranavkumar Sawargaonkar's ser

[Qemu-devel] [PATCH 1/7] target-arm: use correct do_interrupt handler for AArch64 user mode

2014-05-05 Thread Rob Herring
From: Rob Herring User mode emulation should never get interrupts and thus should not use the system emulation exception handler function. Signed-off-by: Rob Herring --- target-arm/cpu64.c | 4 target-arm/helper-a64.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/target-arm

[Qemu-devel] [PATCH 7/7] arm/highbank: enable PSCI emulation support

2014-05-05 Thread Rob Herring
From: Rob Herring Enable PSCI enulation on highbank and midway platforms. Note that this requires fixing the PSCI function IDs in the DTB to match what QEMU is using. This should get fixed. Signed-off-by: Rob Herring --- hw/arm/highbank.c | 8 1 file changed, 8 insertions(+) diff --

[Qemu-devel] [PATCH 3/7] target-arm: add hvc and smc exception emulation handling infrastructure

2014-05-05 Thread Rob Herring
From: Rob Herring Add the infrastructure to handle and emulate hvc and smc exceptions. This will enable emulation of things such as PSCI calls. This commit does not change the behavior and will exit with unknown exception. Signed-off-by: Rob Herring --- target-arm/cpu-qom.h | 3 +++ tar

[Qemu-devel] [PATCH 6/7] arm/virt: enable PSCI emulation support for system emulation

2014-05-05 Thread Rob Herring
From: Rob Herring Now that we have PSCI emulation, enable it for the virt platform. This simplifies the virt machine a bit now that PSCI and SMP no longer need to be KVM only features. Signed-off-by: Rob Herring --- Note: This will need to be rebased as comments on KVM PSCI 0.2 support are ad

[Qemu-devel] [PATCH 4/7] target-arm: support AArch64 for arm_cpu_set_pc

2014-05-05 Thread Rob Herring
From: Rob Herring Add AArch64 support to arm_cpu_set_pc and make it available to other files. Signed-off-by: Rob Herring --- target-arm/cpu.c | 7 --- target-arm/cpu.h | 12 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c in

Re: [Qemu-devel] [PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Mike Day
Thanks for the review! I've been able to shorten the next version quite a bit. On Mon, May 5, 2014 at 9:42 AM, Stefan Hajnoczi wrote: >> +static void GFunc_print_format(gpointer data, gpointer user) > > QEMU coding style is lowercase function and variable names. The > scripts/checkpatch.pl scri

Re: [Qemu-devel] [PATCH 1/7] target-arm: use correct do_interrupt handler for AArch64 user mode

2014-05-05 Thread Peter Maydell
On 5 May 2014 17:00, Rob Herring wrote: > From: Rob Herring > > User mode emulation should never get interrupts and thus should not > use the system emulation exception handler function. This is true, but arm_cpu_do_interrupt() is also a system emulation exception handler function, so it's no be

[Qemu-devel] [Bug 1316115] Re: linux-user qemu-arm NEON support

2014-05-05 Thread Christopher Horler
> Are you trying to execute a DLL on purpose? Yes - it's executable and should print out something like this (this from my host system): chorler@linux-foxtrot:~> /usr/lib64/libQt5Core.so.5 This is the QtCore library version 5.1.1 Copyright (C) 2013 Digia Plc and/or its subsidiary(-ies). Contact:

Re: [Qemu-devel] [PATCH v3 0/4] Add max-ram-below-4g (was Add pci_hole_min_size machine option)

2014-05-05 Thread Don Slutz
On 05/05/14 04:12, Michael S. Tsirkin wrote: On Tue, Apr 22, 2014 at 12:31:16PM -0400, Don Slutz wrote: On 04/18/14 10:10, Andreas Färber wrote: Am 25.03.2014 10:08, schrieb Michael S. Tsirkin: On Mon, Mar 24, 2014 at 07:55:32PM -0400, Don Slutz wrote: Changes v2 to v3: Stefano Stabellini:

Re: [Qemu-devel] [PATCH v3 00/12] block/json: Add JSON protocol driver

2014-05-05 Thread Max Reitz
On 10.04.2014 20:43, Max Reitz wrote: This series adds a passthrough JSON protocol block driver. Its filenames are JSON objects prefixed by "json:". The objects are used as options for opening another block device which will be the child of the JSON device. Regarding this child device, the JSON d

Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

2014-05-05 Thread Gabriel L. Somlo
Andreas, On Mon, May 05, 2014 at 06:00:22PM +0200, Andreas F?rber wrote: > Objection! .compat_props are being added to the current pc and q35 > machines rather than introducing pc-i440fx-2.1 and pc-q35-2.1 machines > and adding the compat_props for the 2.0 versions only. > > If 2.1 machines witho

Re: [Qemu-devel] [PATCH 4/7] target-arm: support AArch64 for arm_cpu_set_pc

2014-05-05 Thread Peter Maydell
On 5 May 2014 17:00, Rob Herring wrote: > From: Rob Herring > > Add AArch64 support to arm_cpu_set_pc and make it available to other files. > > Signed-off-by: Rob Herring > --- > target-arm/cpu.c | 7 --- > target-arm/cpu.h | 12 > 2 files changed, 12 insertions(+), 7 deletion

Re: [Qemu-devel] [PATCH 34/35] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2014-05-05 Thread Eric Blake
On 04/04/2014 07:36 AM, Igor Mammedov wrote: > also make handler edge based to avoid loosing events, the same as s/loosing/losing/ (loose rhymes with goose and means the opposite of "tight"; lose rhymes with use and means the opposite of "gain" - it is a very frequent typo to see people put too m

Re: [Qemu-devel] [PATCH 2/7] target-arm: add powered off cpu state

2014-05-05 Thread Peter Maydell
On 5 May 2014 17:00, Rob Herring wrote: > From: Rob Herring > > Add tracking of cpu power state in order to support powering off of > cores in system emuluation. The initial state is determined by the > start-powered-off QOM property. > > Signed-off-by: Rob Herring > --- > target-arm/cpu-qom.h

Re: [Qemu-devel] [PATCH 34/35] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines

2014-05-05 Thread Paolo Bonzini
Il 05/05/2014 18:25, Eric Blake ha scritto: > also make handler edge based to avoid loosing events, the same as s/loosing/losing/ (loose rhymes with goose and means the opposite of "tight"; lose rhymes with use and means the opposite of "gain" - it is a very frequent typo to see people put too

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-05 Thread Max Reitz
On 05.05.2014 14:26, Stefan Hajnoczi wrote: On Sat, May 03, 2014 at 04:47:08PM +0200, Max Reitz wrote: @@ -56,22 +57,22 @@ for IMGOPTS in "compat=0.10" "compat=1.1"; do echo === Create image with unknown header extension === echo _make_test_img 64M -./qcow2.py "$TEST_IMG" a

Re: [Qemu-devel] [PATCH] iotests: Use configured python

2014-05-05 Thread Eric Blake
On 05/05/2014 10:25 AM, Max Reitz wrote: >> The code generally uses the older `` notation instead of $(). Please >> use ``. > > If I'd send a v2 with ``, Eric would probably want me to send a v3 with > $(). ;-) I won't make you resend if you are consistent with other code in the same file. But

[Qemu-devel] [Bug 1316115] Re: linux-user qemu-arm NEON support

2014-05-05 Thread Christopher Horler
Now I look at the two sets of architecture specific information for the two versions of the library it's almost certain this has nothing to do with NEON. I'll build a version of Qt5 of my own to test, if that works then from my perspective it's not a qemu bug. -- You received this bug notificati

[Qemu-devel] [PATCH 5/7] target-arm: add emulation of PSCI calls for system emulation

2014-05-05 Thread Rob Herring
From: Rob Herring Add support for handling PSCI calls in system emulation. Both version 0.1 and 0.2 of the PSCI spec are supported. Platforms can enable support by setting "psci-method" QOM property on the cpus to SMC or HVC emulation and having PSCI binding in their dtb. Signed-off-by: Rob Herr

Re: [Qemu-devel] [PATCH 0/5] glib thread interface and libcacard cleanups

2014-05-05 Thread Michael Tokarev
05.05.2014 18:49, Alon Levy wrote: > On 04/29/2014 09:02 AM, Michael Tokarev wrote: >> Basically libgthread has been rewritten in glib version 2.31, and old ways >> to use thread primitives stopped working while new ways appeared. The two >> interfaces were sufficiently different to warrant large

Re: [Qemu-devel] [PATCH v3] PortioList: Store PortioList in device state

2014-05-05 Thread Andreas Färber
Am 29.04.2014 15:38, schrieb Kirill Batuzov: > PortioList is an abstraction used for construction of MemoryRegionPortioList > from MemoryRegionPortio. It can be used later to unmap created memory regions. > It also requires proper cleanup because some of the memory inside is allocated > dynamically

[Qemu-devel] [Bug 1312561] Re: libstdc++-6.dll is missing from your computer

2014-05-05 Thread Paolo Bonzini
I think dynamic is fine, after all how is libstdc++ different from glib? Both of them need to be deployed together with the executable on Windows, because they aren't a common prerequisite. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH 03/13] qapi: Remove unused Visitor callbacks start_handle(), end_handle()

2014-05-05 Thread Eric Blake
On 05/02/2014 06:44 AM, Markus Armbruster wrote: > These have never been called or implemented by anything, and their > intended use is undocumented, like all of the visitor API. > > Signed-off-by: Markus Armbruster > --- > include/qapi/visitor-impl.h | 3 --- > qapi/qapi-visit-core.c | 15

[Qemu-devel] [PATCH] [v2 PATCH] qemu-img: sort block formats in help message

2014-05-05 Thread Mike Day
The help message for qemu-img lists the supported block formats, of which there are 27 as of version 2.0.50. The formats are printed in the order of their driver's position in a linked list, which appears random. This patch prints the formats in sorted order, making it easier to read and to find a

Re: [Qemu-devel] [PATCH 04/13] qapi: Replace start_optional()/end_optional() by optional()

2014-05-05 Thread Eric Blake
On 05/02/2014 06:44 AM, Markus Armbruster wrote: > Semantics of end_optional() differ subtly from the other end_FOO() > callbacks: when start_FOO() succeeds, the matching end_FOO() gets > called regardless of what happens in between. end_optional() gets > called only when everything in between suc

Re: [Qemu-devel] [PATCH 00/10] qtest: Cleanups, more PCI tests

2014-05-05 Thread Andreas Färber
Am 24.04.2014 14:49, schrieb Andreas Färber: > qtest: Assure that init_socket()'s listen() does not fail > qtest: Add error reporting to socket_accept() > qtest: Be paranoid about accept() addrlen argument > tests: Add ac97 qtest > tests: Add es1370 qtest > tests: Add intel-hda qtests >

Re: [Qemu-devel] [PATCH 05/13] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use

2014-05-05 Thread Eric Blake
On 05/02/2014 06:44 AM, Markus Armbruster wrote: > Changing implicit indentation in the middle of generating a block > makes following the code being generated unnecessarily hard. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi-visit.py | 32 ++-- > 1 file c

Re: [Qemu-devel] [PATCH v2 2/2] qapi: Allow setting default values for optional parameters

2014-05-05 Thread Markus Armbruster
Eric Blake writes: > On 05/05/2014 05:06 AM, Markus Armbruster wrote: > >>> >>> { 'command': 'block-commit', >>> 'data': { 'device': 'str', '*base': 'str', 'top': 'str', >>> '*speed': 'int' }, >>> 'defaults': {'base': 'earthquake', 'speed': 100 } } >>> > >> >> Can

[Qemu-devel] [Bug 1312561] Re: libstdc++-6.dll is missing from your computer

2014-05-05 Thread Peter Maydell
Ah, we're dynamically linking with glib too? In that case, yes, whatever mechanism we're currently using to distribute the glib DLL we should use for the libstdc++ too. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.laun

Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

2014-05-05 Thread Andreas Färber
Am 05.05.2014 18:21, schrieb Gabriel L. Somlo: > Andreas, > > On Mon, May 05, 2014 at 06:00:22PM +0200, Andreas F?rber wrote: >> Objection! .compat_props are being added to the current pc and q35 >> machines rather than introducing pc-i440fx-2.1 and pc-q35-2.1 machines >> and adding the compat_pro

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-05 Thread Marcin Gibuła
W dniu 2014-05-05 15:51, Alexander Graf pisze: When we migrate we ask the kernel about its current belief on what the guest time would be. However, I've seen cases where the kvmclock guest structure indicates a time more recent than the kvm returned time. Hi, is it possible to have kvmclock ju

[Qemu-devel] [PULL 03/22] qga: Fix typo (plural) in comment

2014-05-05 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- qga/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/main.c b/qga/main.c index d838c3e..38219c9 100644 --- a/qga/main.c +++ b/qga/main.c @@ -1110,7 +1110,7 @@ int main(int argc, cha

[Qemu-devel] [PULL 00/22] Trivial patches for 2014-05-05

2014-05-05 Thread Michael Tokarev
Here's another pull request for trival patches. This time, it includes: - many cleanups from Stefan Weil, mostly adding `static' attrs - some more trivial patches from glib cleanups, by me and Stefan Hajnoczi - some more trivial changes for libcacard, from me and Alon Levy - small fixes from C

[Qemu-devel] [PULL 04/22] tests/tcg: Fix compilation of test_path

2014-05-05 Thread Michael Tokarev
From: Peter Maydell The test_path binary is (unlike the other test binaries in tests/tcg) actually intended to be compiled with the same compiler used to build the main QEMU executables. It actually #includes a number of the QEMU source files in an attempt to unit-test the util/path.c functions,

[Qemu-devel] [PATCH v4 2/2] qdev: Add test of qdev_prop_check_global

2014-05-05 Thread Don Slutz
This will generate a warning from "make check": ... GTESTER tests/test-qdev-global-props Warning: "-global dynamic-prop-type-bad.prop3=103" not used GTESTER tests/check-qom-interface ... If the warning is not generated, the test will fail. Signed-off-by: Don Slutz --- tests/test-qdev-global-pr

[Qemu-devel] [PULL 01/22] Makefiles: convert some obj-specific CFLAGS to use new foo.o-cflags syntax

2014-05-05 Thread Michael Tokarev
Current Makefile system allows using foo.o-cflags variables to store object-specific CFLAGS. Convert some usages of old syntax (using QEMU_CFLAGS += construct) to the new syntax. Do not touch multifile modules for now, as build system isn't ready for this. Signed-off-by: Michael Tokarev Reviewe

[Qemu-devel] [PULL 02/22] configure: remove bashism

2014-05-05 Thread Michael Tokarev
Commit e26110cfc67d48 added a check for shacmd to create a hash for modules. This check in configure is using bash construct &> to redirect both stdout and stderr, which does fun things on some shells. Get rid of it, use standard redirection instead. Signed-off-by: Michael Tokarev Reviewed-by:

[Qemu-devel] [PATCH v4 0/2] qdev: Display warning about unused -global

2014-05-05 Thread Don Slutz
I might have named this v2, but since this is a split out of: [PATCH v3 2/4] GlobalProperty: Display warning about unused -global From: [PATCH v3 0/4] Add max-ram-below-4g (was Add pci_hole_min_size machine option) I feel v4 is better. Changes v3 to v4: Add a new patch to add a check in test

[Qemu-devel] [PATCH v4 1/2] qdev: Display warning about unused -global

2014-05-05 Thread Don Slutz
This can help a user understand why -global was ignored. For example: with "-vga cirrus"; "-global vga.vgamem_mb=16" is just ignored when "-global cirrus-vga.vgamem_mb=16" is not. This is currently clear when the wrong property is provided: out/x86_64-softmmu/qemu-system-x86_64 -global cirrus-vg

Re: [Qemu-devel] [v5 PATCH 0/2] apic: bump emulated lapic version to 0x14

2014-05-05 Thread Gabriel L. Somlo
On Mon, May 05, 2014 at 07:38:58PM +0200, Andreas F?rber wrote: > Yes, with that patch it's okay, you just forgot to mention that > dependency in your cover letter - also a change log from v1 is missing. > Instead of quoting Alex in the cover letter, you should've placed his > Acked-by before your

[Qemu-devel] [PULL 11/22] qemu-timer: Add missing 'static' attribute

2014-05-05 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- qemu-timer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-timer.c b/qemu-timer.c index e15ce47..9be1a41 100644 --- a/qemu

[Qemu-devel] [PULL 07/22] hw/mips: Add missing 'static' and 'const' attributes

2014-05-05 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev Acked-by: Aurelien Jarno --- hw/mips/mips_fulong2e.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/mips_fulong2e.c b/hw/mi

[Qemu-devel] [PULL 22/22] libcacard: remove unnecessary EOL from debug prints

2014-05-05 Thread Michael Tokarev
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Michael Tokarev --- libcacard/vreader.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libcacard/vreader.c b/libcacard/vreader.c index 5793d73..7720295 100644 --- a/libcacard/vreader.c +++ b/libcacard/vreader.c

[Qemu-devel] [PULL 18/22] qmp: report path ambiguity error

2014-05-05 Thread Michael Tokarev
Without this, ambiguous path is reported to the user as "not found", which is confusing at least. Signed-off-by: Michael Tokarev --- qmp.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qmp.c b/qmp.c index 74107be..37bd7dc 100644 --- a/qmp.c +++ b/qmp.c @@ -200,7 +20

[Qemu-devel] [PULL 21/22] docs/memory.txt: Fix document on MMIO operations

2014-05-05 Thread Michael Tokarev
From: Fam Zheng .impl.valid should be .impl.unaligned and the description needs some fixes. .old_portio is removed since commit b40acf99b (ioport: Switch dispatching to memory core layer). Signed-off-by: Fam Zheng Signed-off-by: Michael Tokarev --- docs/memory.txt | 10 +- in

[Qemu-devel] [PULL 06/22] hw/9pfs: Add missing 'static' attributes

2014-05-05 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/9pfs/virtio-9p-synth.c |2 +- hw/core/qdev.c|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/virtio-9p-synth.c b/hw/9pfs/virtio-9p-synth.c index 840e4eb..71262b

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-05 Thread Alexander Graf
> Am 05.05.2014 um 19:46 schrieb Marcin Gibuła : > > W dniu 2014-05-05 15:51, Alexander Graf pisze: >> When we migrate we ask the kernel about its current belief on what the guest >> time would be. However, I've seen cases where the kvmclock guest structure >> indicates a time more recent than t

[Qemu-devel] [PULL 16/22] glib: move g_poll() replacement into glib-compat.h

2014-05-05 Thread Michael Tokarev
From: Stefan Hajnoczi We have a dedicated header file for wrappers to smooth over glib version differences. Move the g_poll() definition into glib-compat.h for consistency. Signed-off-by: Stefan Hajnoczi Signed-off-by: Michael Tokarev Cc: qemu-triv...@nongnu.org --- include/glib-compat.h |

[Qemu-devel] [PULL 14/22] hw/9pfs: Add include file for exported symbol

2014-05-05 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/9pfs/virtio-9p-local.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c index 56b302c..3b0b6a9 100644 --- a/hw/9pfs/virtio-9p-local.c +++ b/hw/9pfs/vir

[Qemu-devel] [PULL 17/22] libcacard: replace pstrcpy() with memcpy()

2014-05-05 Thread Michael Tokarev
Commit 2e679780ae86c6ca8 replaced strncpy() with pstrcpy() in one place in libcacard. This is a qemu-specific function, while libcacard is a stand-alone library (or tries to be). But since we know the exact length of the string to copy, and know that it definitely will fit in the destination buffe

[Qemu-devel] [PULL 10/22] ui: Add missing 'static' attribute

2014-05-05 Thread Michael Tokarev
From: Stefan Weil There was already a forward declaration using 'static', but the attribute was missing in the implementation. This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- ui/console.c |2 +- 1 file changed, 1

[Qemu-devel] [PULL 20/22] readline: Sort completions before printing them.

2014-05-05 Thread Michael Tokarev
From: Hani Benhabiles Signed-off-by: Hani Benhabiles Signed-off-by: Michael Tokarev --- util/readline.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/util/readline.c b/util/readline.c index a3fd2cb..8baec55 100644 --- a/util/readline.c +++ b/util/readline.c @@ -272,6 +272,11 @@

[Qemu-devel] [PULL 09/22] monitor: Add missing 'static' attribute

2014-05-05 Thread Michael Tokarev
From: Stefan Weil This fixes a warning from the static code analysis (smatch). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- monitor.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor.c b/monitor.c index 1266ba0..2d3fb3f 100644 --- a/monitor.c +++

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-05 Thread Marcin Gibuła
is it possible to have kvmclock jumping forward? Because I've reproducible case when at about 1 per 20 vm restores, VM freezes for couple of hours and then resumes with date few hundreds years ahead. Happens only with kvmclock. And this patch seems to fix very similar issue so maybe it's all t

[Qemu-devel] [PATCH] block/nfs: Check for NULL server part

2014-05-05 Thread Max Reitz
After the URL has been parsed make sure the server part is valid in order to avoid a segmentation fault when calling nfs_mount(). Signed-off-by: Max Reitz --- block/nfs.c | 4 1 file changed, 4 insertions(+) diff --git a/block/nfs.c b/block/nfs.c index 9fa831f..539bd95 100644 --- a/block/n

[Qemu-devel] [PULL 05/22] arch_init: Be sure of only one exit entry with DPRINTF() for ram_load()

2014-05-05 Thread Michael Tokarev
From: Chen Gang When DPRINTF() has effect, the original author wants to print all ram_load() calling results. So need use 'goto' instead of 'return' within ram_load(), just like other areas have done. Signed-off-by: Chen Gang Signed-off-by: Michael Tokarev --- arch_init.c | 12

Re: [Qemu-devel] [PATCH v12 0/4] qapi: Allow modularization of QAPI schema files

2014-05-05 Thread Luiz Capitulino
On Fri, 2 May 2014 15:52:19 +0200 Lluís Vilanova wrote: > Adds an include primitive to the syntax of QAPI schema files, allowing these > to > be modularized into multiple per-topic files in the future. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Eric Blake > Reviewed-by: Markus Armbrust

Re: [Qemu-devel] [PATCH] monitor: Add info qom-tree subcommand.

2014-05-05 Thread Luiz Capitulino
On Sun, 27 Apr 2014 11:29:30 +0100 Hani Benhabiles wrote: > Signed-off-by: Hani Benhabiles Who can review this one? I'm not familiar enough with QOM to do it. > --- > > Not sure whether the qobject stringifying functions could fit or be of some > use > elsewhere. Thus, I kept them as static

[Qemu-devel] [PULL 08/22] hw/s390x: Add missing 'static' attribute

2014-05-05 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/s390x/event-facility.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index 0777a93..2e9e62f 100644 --- a/hw/s390x/event-facility.c +

[Qemu-devel] [PULL 15/22] do not call g_thread_init() for glib >= 2.31

2014-05-05 Thread Michael Tokarev
glib >= 2.31 always enables thread support and g_thread_supported() is #defined to 1, there's no need to call g_thread_init() anymore, and it definitely does not need to report error which never happens. Keep code for old < 2.31 glibc anyway for now, just #ifdef it differently. Signed-off-by: Mich

<    1   2   3   4   >