Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as Memory API maintainer

Am 29.04.2014 18:51, schrieb Paolo Bonzini: > I'm not including Avi since he has already removed himself from the > KVM entry. I'm not going to commit my patches without review. > > Signed-off-by: Paolo Bonzini > --- > MAINTAINERS | 10 ++ > 1 file changed, 10 insertions(+) > > diff --

Re: [Qemu-devel] [PATCH V3 0/5] remove QEMUMachine indirection from MachineClass

On Tue, 2014-04-29 at 16:55 +0200, Andreas Färber wrote: > Am 27.04.2014 11:08, schrieb Marcel Apfelbaum: > > On Sat, 2014-04-26 at 00:30 +0200, Andreas Färber wrote: > >> Am 09.04.2014 19:34, schrieb Marcel Apfelbaum: > >>> Next steps: > >>> - Replace QemuOpts queries by MachineState fields. > >>

Re: [Qemu-devel] [PATCH V3 0/5] remove QEMUMachine indirection from MachineClass

> Good. Maybe it makes sense to track these TODO items on a Wiki page, > such as http://wiki.qemu-project.org/Features/QOM/Machine? I posted a draft of this page. Feel free to add/make it more clear... Thanks, Marcel > > Cheers, > Andreas >

Re: [Qemu-devel] [PATCH v3] QemuOpt: add unit tests

Leandro Dorileo writes: > Hi Andreas, > > On Mon, Apr 28, 2014 at 09:02:12PM +0200, Andreas Färber wrote: >> Am 28.04.2014 20:55, schrieb Leandro Dorileo: >> > ping? >> > >> > >> > On Tue, Mar 25, 2014 at 10:27:19AM -0300, Leandro Dorileo wrote: >> >> Cover basic aspects and API usage for QemuO

Re: [Qemu-devel] [PATCHv2 0/4] Set eflags prior to segments; fix cpl in SMM

Il 29/04/2014 22:37, Kevin O'Connor ha scritto: This patch series is an update to the patch I sent at: https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04028.html The goal of the patch series is to fix the SMM handler so that it runs with the proper cpl. I've broken the series up based

Re: [Qemu-devel] [PATCH] target-i386: kvm: Don't enable MONITOR by default on any CPU model

Il 29/04/2014 23:17, Eduardo Habkost ha scritto: KVM never supported the MONITOR flag so it doesn't make sense to have it enabled by default when KVM is enabled. The rationale here is similar to the cases where it makes sense to have a feature enabled by default on all CPU models when on KVM mod

Re: [Qemu-devel] [PATCHv2 0/4] Set eflags prior to segments; fix cpl in SMM

Am 30.04.2014 10:37, schrieb Paolo Bonzini: > Il 29/04/2014 22:37, Kevin O'Connor ha scritto: >> This patch series is an update to the patch I sent at: >> >> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04028.html >> >> The goal of the patch series is to fix the SMM handler so that it r

Re: [Qemu-devel] [PATCH] target-i386: kvm: Don't enable MONITOR by default on any CPU model

Il 30/04/2014 03:11, Marcelo Tosatti ha scritto: > On Tue, Apr 29, 2014 at 06:17:17PM -0300, Eduardo Habkost wrote: >> KVM never supported the MONITOR flag so it doesn't make sense to have it >> enabled by default when KVM is enabled. >> >> The rationale here is similar to the cases where it makes

Re: [Qemu-devel] For 2.0? Re: [PATCH v5 00/10] migration: Optimizate the xbzrle and fix one corruption issue

Hi, Ping, what's the patch sets status? Thanks. Best regards, -Gonglei > -Original Message- > From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com] > Sent: Saturday, April 05, 2014 1:41 AM > To: Eric Blake > Cc: Gonglei (Arei); qemu-devel@nongnu.org; quint...@redhat.com; > pbonz..

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc64-dump: Support dump for little endian ppc64

On Tue, 29 Apr 2014 11:19:40 +0200 Alexander Graf wrote: > > On 28.04.14 13:29, Greg Kurz wrote: > > From: Bharata B Rao > > > > Fix ppc64 arch specific dump code to work correctly for little endian > > guests. > > > > Signed-off-by: Bharata B Rao > > [ rebased on top of current master branch,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/4] ppc64-dump: Support dump for little endian ppc64

On 30.04.14 11:14, Greg Kurz wrote: On Tue, 29 Apr 2014 11:19:40 +0200 Alexander Graf wrote: On 28.04.14 13:29, Greg Kurz wrote: From: Bharata B Rao Fix ppc64 arch specific dump code to work correctly for little endian guests. Signed-off-by: Bharata B Rao [ rebased on top of current mast

Re: [Qemu-devel] [PATCH v3 07/16] tcg-ppc64: DefineTCG_TARGET_INSN_UNIT_SIZEE

Richard Henderson writes: > On 04/29/2014 08:41 AM, Alex Bennée wrote: >> >> Richard Henderson writes: >>> On 04/29/2014 04:25 AM, Alex Bennée wrote: > +*pc = (*pc & ~0x3fc) | reloc_pc24_val(pc, target); Should 0x3fc be a #define'd mask? Can the PC ever actually be >>

[Qemu-devel] [PATCH] gtk: Add a scrollbar for text consoles

From: Cole Robinson Only show the scrollbar if the content doesn't fit on the visible space. [ kraxel: fix box packing ] Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 42 -- 1 file changed, 40 insertions(+), 2 deletions(-) d

Re: [Qemu-devel] [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP

Il 11/04/2014 19:40, H. Peter Anvin ha scritto: On 04/11/2014 10:35 AM, Jet Chen wrote: As Peter said, QEMU probably should *not* set the hypervisor bit. But based on my testing, I think KVM works properly in this case. Either way, unless there is a CPUID interface exposed in CPUID levels 0

Re: [Qemu-devel] [PATCH 6/7] slirp: Add description of new "dhcpvendopt" suboption to the help and man page

On Tue, Apr 29, 2014 at 4:00 AM, Eric Blake wrote: > On 04/25/2014 04:11 PM, Fedor Lyakhov wrote: >> Signed-off-by: Fedor Lyakhov >> --- >> qemu-options.hx | 16 +--- >> 1 file changed, 13 insertions(+), 3 deletions(-) > >> +" >> [,hostname=host][,dhcpstart=addr][,dns=ad

Re: [Qemu-devel] [PATCH v1 1/3] qdev: Expose the qdev id string as a prop

Il 16/04/2014 19:20, Andreas Färber ha scritto: qdev paths used for VMState currently still depend on a bus, which Alex or Alexey wanted to look into fixing. By default -1 is supplied by DeviceState for registering dc->vmsd, which can be overridden by inlining the corresponding qdev.c code or mor

Re: [Qemu-devel] [PATCH] audio/intel-hda: support FIFORDY

On Di, 2014-04-29 at 16:48 +0400, Stanislav Vorobiov wrote: > linux kernel 3.12 has changed intel-hda > driver to always check for FIFORDY, this > causes long hangs in guest since QEMU > always has this bit set to 0. We now simply set > it to 1 always, since we're synchronous anyway > and always re

Re: [Qemu-devel] [RFC 1/4] Allocate non-RAM MemoryRegion from user pointer

Il 17/04/2014 19:29, Alvise Rigo ha scritto: + +void memory_region_init_ptr(MemoryRegion *mr, +Object *owner, +const char *name, +uint64_t size, +void *ptr) +{ +memo

Re: [Qemu-devel] [PATCH] block: Use error_abort in bdrv_image_info_specific_dump()

Am 29.04.2014 um 18:32 hat Max Reitz geschrieben: > Currently, bdrv_image_info_specific_dump() uses an error variable for > visit_type_ImageInfoSpecific, but ignores the result. As this function > is used here with an output visitor to transform the ImageInfoSpecific > object to a generic QDict, an

Re: [Qemu-devel] [PATCH v4 1/3] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests

On Wed, Apr 30, 2014 at 10:10:02AM +0800, Fam Zheng wrote: > On Tue, 04/29 18:39, Jeff Cody wrote: > > This creates some common functions for bash language qemu-iotests > > to control, and communicate with, a running QEMU process. > > > > 4 functions are introduced: > > > > 1. _launch_qemu()

Re: [Qemu-devel] [PATCH v4 3/3] block: qemu-iotests - test for live migration

On Wed, Apr 30, 2014 at 10:28:11AM +0800, Fam Zheng wrote: > On Tue, 04/29 18:39, Jeff Cody wrote: > > This is an initial, simple live migration test from one > > running VM to another, using monitor commands. > > > > This is also an example of using the new common.qemu functions > > for controlli

Re: [Qemu-devel] [PATCH 1/6] qcow2: Avoid overflow in alloc_clusters_noref()

Am 29.04.2014 um 19:03 hat Max Reitz geschrieben: > alloc_clusters_noref() stores the cluster index in a uint64_t. However, > offsets are often represented as int64_t (as for example the return > value of alloc_clusters_noref() itself demonstrates). Therefore, we > should make sure all offsets in t

Re: [Qemu-devel] [PATCH 0/6] block: Several fixes

Am 29.04.2014 um 19:03 hat Max Reitz geschrieben: > Max Reitz (6): > qcow2: Avoid overflow in alloc_clusters_noref() > block: Use correct width in format strings > qcow2: Catch bdrv_getlength() error > qcow2: Check min_size in qcow2_grow_l1_table() > block/bochs: Fix error handling for se

Re: [Qemu-devel] [PATCH v4 3/3] block: qemu-iotests - test for live migration

On Wed, 04/30 08:40, Jeff Cody wrote: > On Wed, Apr 30, 2014 at 10:28:11AM +0800, Fam Zheng wrote: > > On Tue, 04/29 18:39, Jeff Cody wrote: > > > This is an initial, simple live migration test from one > > > running VM to another, using monitor commands. > > > > > > This is also an example of usi

[Qemu-devel] [PATCH 0/3] curl: Add sslverify option and documentation

[PATCH 1/3] curl: Fix parsing of readahead option from filename [PATCH 2/3] curl: Add sslverify option [PATCH 3/3] curl: Add usage documentation Parsing the readahead option from a curl filename seems to have been broken for some time. The first patch restores what seems to have been its undocumen

[Qemu-devel] [PATCH 3/3] curl: Add usage documentation

Signed-off-by: Matthew Booth --- qemu-options.hx | 70 + 1 file changed, 70 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 781af14..e076e1c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2191,6 +2191,76 @@ qemu-s

[Qemu-devel] [PATCH 1/3] curl: Fix parsing of readahead option from filename

curl_parse_filename wasn't removing the option string from the url, resulting in a 404. This change is a essentially a rewrite of that function as I also need to extend it to handle more options. The rewrite is also much easier to read. Signed-off-by: Matthew Booth --- block/curl.c | 59 +++

[Qemu-devel] [PATCH 2/3] curl: Add sslverify option

This allows qemu to use images over https with a self-signed certificate. It defaults to verifying the certificate. Signed-off-by: Matthew Booth --- block/curl.c | 28 1 file changed, 28 insertions(+) diff --git a/block/curl.c b/block/curl.c index 2a03924..8731f63 1

Re: [Qemu-devel] [PATCH 6/7] slirp: Add description of new "dhcpvendopt" suboption to the help and man page

On 04/30/2014 04:13 AM, Fedor Lyakhov wrote: >> >> Rather than inventing YET ANOTHER command line quoting idiom in order to >> cram multiple strings into one option, can you instead manage to rework >> things so that the user can pass multiple dhcpvendopt= options, one per >> string? That is, dhc

Re: [Qemu-devel] [PATCH] target-i386: kvm: Don't enable MONITOR by default on any CPU model

On Tue, Apr 29, 2014 at 10:11:08PM -0300, Marcelo Tosatti wrote: > On Tue, Apr 29, 2014 at 06:17:17PM -0300, Eduardo Habkost wrote: > > KVM never supported the MONITOR flag so it doesn't make sense to have it > > enabled by default when KVM is enabled. > > > > The rationale here is similar to the

Re: [Qemu-devel] [PATCH 00/16] PCI device assignment: improve error reporting over QMP

Hi Luiz, On 04/10/14 10:24, Laszlo Ersek wrote: > This is for . > > In general, we want to propagate non-fatal (ie. non-exit()ing, > non-abort()ing) errors to the QMP caller, rather than printing them > on-site. The series focuses on errors rais

[Qemu-devel] [PULL 0/3] kvm/s390x/ppc: kvm_enable_cap helpers

The following changes since commit b006f8162e11f0395689a684d6e871b047c23481: Merge remote-tracking branch 'remotes/rth/tags/tcg-sparc-pull-20140428' into staging (2014-04-29 13:03:25 +0100) are available in the git repository at: https://github.com/cohuck/qemu.git tags/kvm_cap_helpers for

[Qemu-devel] [PULL 2/3] s390x: use kvm_vcpu_enable_cap()

Make kvm_s390_enable_css_support() use new interface. Reviewed-by: Thomas Huth Reviewed-by: Alexander Graf Signed-off-by: Cornelia Huck --- target-s390x/kvm.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c index a30d1bc..b7b0ed

[Qemu-devel] [PULL 3/3] ppc: use kvm_vcpu_enable_cap()

Convert existing users of KVM_ENABLE_CAP to new helper. Reviewed-by: Thomas Huth Reviewed-by: Alexander Graf Signed-off-by: Cornelia Huck --- hw/intc/openpic_kvm.c |8 ++-- hw/intc/xics_kvm.c|8 ++-- target-ppc/kvm.c | 21 - 3 files changed, 8 ins

[Qemu-devel] [PULL 1/3] kvm: add kvm_{vm,vcpu}_enable_cap

Provide helper functions for enabling capabilities (on a vcpu and on a vm). Reviewed-by: Thomas Huth Reviewed-by: Alexander Graf Signed-off-by: Cornelia Huck --- include/sysemu/kvm.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/include/sysemu/kvm.h b/in

Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages

On Sun, Apr 27, 2014 at 9:55 PM, Fam Zheng wrote: >> > /* not found */ >> > -help(); >> > -return 0; >> > +error_exit("Command not found: %s", cmdname); >> >> Looks like we just relied previously on the default 'not found' case >> for help() to provide the "--help" option. >> > >

[Qemu-devel] [PATCH v2 0/4] little-endian dump for ppc64

Hi, Second take: it addresses Alex's remarks (see changelog in each patch). Regards. --- Bharata B Rao (3): dump: Make DumpState and endian conversion routines available for arch-specific dump code ppc64-dump: Support dump for little endian ppc64 ppc64 dump: Set the correct e

[Qemu-devel] [PATCH v2 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

From: Bharata B Rao Make DumpState and endian conversion routines available for arch-specific dump code by moving into dump.h. DumpState will be needed by arch-specific dump code to access target endian information from DumpState->ArchDumpInfo. Also break the dependency of dump.h from stubs/dump.

[Qemu-devel] [PATCH v3 3/4] target-ppc: ppc can be either endian

POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR special purpose register to decide the endianness to use when entering interrupt handlers. When running a Linux guest, this provides a hint on the endianness used by the kernel. From a QEMU point of view, the information is needed for

[Qemu-devel] [PATCH v2 2/4] ppc64-dump: Support dump for little endian ppc64

From: Bharata B Rao Fix ppc64 arch specific dump code to work correctly for little endian guests. We introduce a NoteFuncArg type to avoid adding extra arguments to all note functions. Signed-off-by: Bharata B Rao [ rebased on top of current master branch, added dump_ prefix and pass a DumpS

Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages

On 04/30/2014 08:12 AM, Mike Day wrote: > On Sun, Apr 27, 2014 at 9:55 PM, Fam Zheng wrote: /* not found */ -help(); -return 0; +error_exit("Command not found: %s", cmdname); >>> >>> Looks like we just relied previously on the default 'not found' case >>> for h

[Qemu-devel] [PATCH v2 4/4] ppc64 dump: Set the correct endianness in ELF dump header

From: Bharata B Rao Signed-off-by: Bharata B Rao [ use PowerPCCPUClass::interrupts_big_endian(), Greg Kurz ] Signed-off-by: Greg Kurz --- Changes in v2: - use PowerPCCPUClass::interrupts_big_endian() target-ppc/arch_dump.c | 12 1 file changed, 8 insertions(+), 4 deletions(

[Qemu-devel] [PATCH 1/3] curl: Fix parsing of readahead option from filename

curl_parse_filename wasn't removing the option string from the url, resulting in a 404. This change is a essentially a rewrite of that function as I also need to extend it to handle more options. The rewrite is also much easier to read. Signed-off-by: Matthew Booth --- block/curl.c | 81 +++

[Qemu-devel] V2 curl: Fixup option parsing and add sslverify and documentation

[PATCH 1/3] curl: Fix parsing of readahead option from filename [PATCH 2/3] curl: Add sslverify option [PATCH 3/3] curl: Add usage documentation This updated version fixes a couple of bugs in the previously posted patch, and adds some addition code tidy-up. Matt

[Qemu-devel] [PATCH 3/3] curl: Add usage documentation

Signed-off-by: Matthew Booth --- qemu-options.hx | 70 + 1 file changed, 70 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 781af14..e076e1c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2191,6 +2191,76 @@ qemu-s

[Qemu-devel] [PATCH 2/3] curl: Add sslverify option

This allows qemu to use images over https with a self-signed certificate. It defaults to verifying the certificate. Signed-off-by: Matthew Booth --- block/curl.c | 33 + 1 file changed, 33 insertions(+) diff --git a/block/curl.c b/block/curl.c index 4de6856..e427

Re: [Qemu-devel] [PULL 14/16] qemu-img: Improve error messages

On Wed, Apr 30, 2014 at 10:16 AM, Eric Blake wrote: > Additional patches: > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04074.html > https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04468.html > both already on the queue for the next PULL request of the block branch. Excellen

Re: [Qemu-devel] [PATCH 0/8] curl: Fix hang reading from slow connections

Am 29.04.2014 um 17:03 hat Matthew Booth geschrieben: > [PATCH 1/8] curl: Fix long line > [PATCH 2/8] curl: Remove unnecessary use of goto > [PATCH 3/8] curl: Fix return from curl_read_cb with invalid state > [PATCH 4/8] curl: Remove erroneous sleep waiting for curl completion > [PATCH 5/8] curl: R

[Qemu-devel] [PATCH v5 0/3] Add common QEMU control functionality to qemu-iotests

Prior cover letter details: Changes from v4: Patch 1: - Allow option in _send_qemu_cmd() to not exit on error, similar to _timed_wait_for() (Thanks Fam) - Renamed the option variable to not exit on error, to make it clearer the function. - Updated com

[Qemu-devel] [PATCH v5 1/3] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests

This creates some common functions for bash language qemu-iotests to control, and communicate with, a running QEMU process. 4 functions are introduced: 1. _launch_qemu() This launches the QEMU process(es), and sets up the file descriptors and fifos for communication. You can

[Qemu-devel] [PATCH v5 3/3] block: qemu-iotests - test for live migration

This is an initial, simple live migration test from one running VM to another, using monitor commands. This is also an example of using the new common.qemu functions for controlling multiple running qemu instances, for tests that need a live qemu vm. Reviewed-by: Fam Zheng Signed-off-by: Jeff Co

[Qemu-devel] [PATCH v5 2/3] block: qemu-iotests - update 085 to use common.qemu

The new functionality of common.qemu implements the QEMU control and communication functionality that was originally in test 085. This removes that now-duplicate functionality, and uses the common.qemu functions. The QEMU commandline changes slightly due to this; in addition to monitor and qmp i/

Re: [Qemu-devel] [PATCH 2/3] s390x/helper: Fixed real-to-absolute address translation

On Thu, 24 Apr 2014 10:51:33 +0200 Jens Freimann wrote: > From: Thomas Huth > > The real-to-absolute address translation in mmu_translate() was > missing the second part for translating the page at the prefix > address back to the 0 page. And while we're at it, also moved the > code into a sepa

Re: [Qemu-devel] [PATCH] s390x/helper: Added format control bit to MMU translation

On Fri, 25 Apr 2014 15:37:19 +0200 Thomas Huth wrote: > With the EDAT-1 facility, the MMU translation can stop at the > segment table already, pointing to a 1 MB block. And while we're > at it, move the page table entry handling to a separate function, > too, as suggested by Alexander Graf. > >

Re: [Qemu-devel] [PATCH 1/3] curl: Fix parsing of readahead option from filename

Am 30.04.2014 um 16:20 hat Matthew Booth geschrieben: > curl_parse_filename wasn't removing the option string from the url, > resulting in a 404. > > This change is a essentially a rewrite of that function as I also need > to extend it to handle more options. The rewrite is also much easier > to r

Re: [Qemu-devel] [PATCH 6/7] slirp: Add description of new "dhcpvendopt" suboption to the help and man page

Eric Blake writes: > On 04/30/2014 04:13 AM, Fedor Lyakhov wrote: > >>> >>> Rather than inventing YET ANOTHER command line quoting idiom in order to >>> cram multiple strings into one option, can you instead manage to rework >>> things so that the user can pass multiple dhcpvendopt= options, one

Re: [Qemu-devel] [PATCH 2/3] curl: Add sslverify option

Am 30.04.2014 um 16:20 hat Matthew Booth geschrieben: > This allows qemu to use images over https with a self-signed certificate. It > defaults to verifying the certificate. > > Signed-off-by: Matthew Booth > --- > block/curl.c | 33 + > 1 file changed, 33 inserti

Re: [Qemu-devel] [PATCH] savevm: check vmsd for migratability status (v2)

(CCing Juan) On Tue, Apr 29, 2014 at 09:39:03PM -0300, Marcelo Tosatti wrote: > Check vmsd for unmigratable field, allowing migratibility status > to be modified after vmstate_register. > > Signed-off-by: Marcelo Tosatti Reviewed-by: Eduardo Habkost > > diff --git a/savevm.c b/savevm.c > ind

Re: [Qemu-devel] [PATCH] qdev: fix crash by validating the object type

Am 16.04.2014 09:02, schrieb Markus Armbruster: > Amos Kong writes: > >> QEMU crashed when I try to list device parameters, the driver name is >> actually the available bus name. >> >> # qemu -device virtio-pci-bus,? >> # qemu -device virtio-bus,? >> # qemu -device virtio-serial-bus,? >> qdev

[Qemu-devel] [PATCH v4 10/18] target-i386: Loop-based copying and setting/unsetting of feature words

Now that we have the feature word arrays, we don't need to manually copy each array item, we can simply iterate through each feature word. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 35 ++- 1 file changed, 10 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [PATCH v4 09/18] target-i386: Define TCG_*_FEATURES earlier on cpu.c

Those macros will be used in the feature_word_info array data, so need to be defined earlier. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase to latest qom-cpu (commit 90c5d39c) Changes v2 -> v3: * Trivial rebase after QEMU 2.0 (onto commit 2d03b49) --- target-i386/cpu.c | 117 ++

[Qemu-devel] [PATCH v4 11/18] target-i386: Loop-based feature word filtering in TCG mode

Instead of manually filtering each feature word, add a tcg_features field to FeatureWordInfo, and use that field to filter all feature words in TCG mode. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (

[Qemu-devel] [PATCH v4 17/18] target-i386: block migration and savevm if invariant tsc is exposed

From: Marcelo Tosatti Invariant TSC documentation mentions that "invariant TSC will run at a constant rate in all ACPI P-, C-. and T-states". This is not the case if migration to a host with different TSC frequency is allowed, or if savevm is performed. So block migration/savevm. Also do not ex

[Qemu-devel] [PATCH v4 12/18] target-i386: Support check/enforce flags in TCG mode, too

If enforce/check is specified in TCG mode, QEMU will ensure all CPU features are supported by TCG, so no CPU feature is silently disabled. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by lin

[Qemu-devel] [PATCH v4 13/18] target-i386: Support "-cpu host" in TCG mode

As "-cpu host" simply means "enable every bit that can be enabled on this host", we can emulate similar behavior even if KVM is not enabled. We just need to set all feature bits supported by TCG, accordingly. Signed-off-by: Eduardo Habkost --- Changes v2: * Coding style fix (break long lines) --

Re: [Qemu-devel] [PATCH 2/4] Set eflags and cr0 prior to calling cpu_x86_load_seg_cache() in smm_helper.c.

On 04/29/2014 01:38 PM, Kevin O'Connor wrote: > cpu_load_eflags(env, 0, ~(CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C | >DF_MASK)); > env->eip = 0x8000; > +cpu_x86_update_cr0(env, > + env->cr[0] & ~(CR0_PE_MASK | CR0_EM_MASK | > C

[Qemu-devel] [PATCH v4 08/18] target-i386: Filter KVM and 0xC0000001 features on TCG

TCG doesn't support any of the feature flags on FEAT_KVM and FEAT_C000_0001_EDX feature words, so clear all bits on those feature words. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by line

[Qemu-devel] [PATCH v4 06/18] target-i386: Make TCG feature filtering more readable

Instead of an #ifdef in the middle of the code, just set TCG_EXT2_FEATURES to a different value depending on TARGET_X86_64. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by line kept) Changes

[Qemu-devel] [PATCH v4 05/18] target-i386: Isolate KVM-specific code on CPU feature filtering logic

This will allow us to re-use the feature filtering logic (and the check/enforce flag logic) for TCG. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Trivial rebase to latest qom-cpu (commit 90c5d39c) (Reviewed-by line kept) Changes v2 -> v3: * Trivial r

[Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model

This flag will allow the user to choose between two modes: * All flags that can be enabled on the host, even if unmigratable (migratable=no); * All flags that can be enabled on the host, known to QEMU, and migratable (migratable=yes). The default is still migratable=false, to keep current

[Qemu-devel] [PATCH v4 00/18] target-i386: CPU feature flag queue

This started as a TCG vs KVM feature flag code cleanup, but now it is a queue which includes other feature-flag-related patches that depend on each other. Changes v3 -> v4: * New patch: target-i386: kvm: Don't enable MONITOR by default on any CPU model * New patch: target-i386: Add "migratable"

Re: [Qemu-devel] [PATCH 4/4] The x86 CPL is stored in CS.selector - auto update hflags accordingly.

On 04/29/2014 01:38 PM, Kevin O'Connor wrote: > +if (!(env->cr[0] & CR0_PE_MASK)) > +cpl = 0; > +else if (env->eflags & VM_MASK) > +cpl = 3; CODING_STYLE. r~

[Qemu-devel] [PATCH v4 16/18] savevm: check vmsd for migratability status

From: Marcelo Tosatti Check vmsd for unmigratable field, allowing migratibility status to be modified after vmstate_register. Cc: Juan Quintela Signed-off-by: Marcelo Tosatti Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- savevm.c | 5 + 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature filtering/checking functions

Merge filter_features_for_kvm() and kvm_check_features_against_host(). Both functions made exactly the same calculations, the only difference was that filter_features_for_kvm() changed the bits on cpu->features[], and kvm_check_features_against_host() did error reporting. Reviewed-by: Richard Hen

Re: [Qemu-devel] [PATCHv2 0/4] Set eflags prior to segments; fix cpl in SMM

On 04/30/2014 01:37 AM, Paolo Bonzini wrote: > Il 29/04/2014 22:37, Kevin O'Connor ha scritto: >> This patch series is an update to the patch I sent at: >> >> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg04028.html >> >> The goal of the patch series is to fix the SMM handler so that it

[Qemu-devel] [PATCH v4 02/18] target-i386: Simplify reporting of unavailable features

Instead of checking and calling unavailable_host_feature() once for each bit, simply call the function (now renamed to report_unavailable_features()) once for each feature word. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase to latest qom-cpu (commit 90c5d39c) Changes v2 -> v3: *

[Qemu-devel] [PATCH v4 04/18] target-i386: Pass FeatureWord argument to report_unavailable_features()

This will help us simplify the code that calls report_unavailable_features() later. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rebase to latest qom-cpu (commit 90c5d39c) Changes v2 -> v3: * Trivial rebase after QEMU 2.0 (onto commit 2d03b49) --- target-i386/cpu.c | 5 +++-- 1 file

[Qemu-devel] [PATCH v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too

The TCG_7_0_EBX_FEATURES macro was defined but never used (it even had a typo that was never noticed). Make the existing TCG feature filtering code use it. Change the TCG feature flag filtering code to use it. Reviewed-by: Richard Henderson Signed-off-by: Eduardo Habkost --- Changes v1 -> v2:

[Qemu-devel] [PATCH v4 18/18] target-i386: support "invariant tsc" flag

From: Marcelo Tosatti Expose "Invariant TSC" flag, if KVM is enabled. From Intel documentation: 17.13.1 Invariant TSC The time stamp counter in newer processors may support an enhancement, referred to as invariant TSC. Processor’s support for invariant TSC is indicated by CPUID.8007H:EDX[8].

Re: [Qemu-devel] [PATCH 2/4] Set eflags and cr0 prior to calling cpu_x86_load_seg_cache() in smm_helper.c.

Il 30/04/2014 18:54, Richard Henderson ha scritto: On 04/29/2014 01:38 PM, Kevin O'Connor wrote: cpu_load_eflags(env, 0, ~(CC_O | CC_S | CC_Z | CC_A | CC_P | CC_C | DF_MASK)); env->eip = 0x8000; +cpu_x86_update_cr0(env, + env

Re: [Qemu-devel] [PATCH] target-i386: kvm: Don't enable MONITOR by default on any CPU model

On Wed, Apr 30, 2014 at 10:44:33AM +0200, Paolo Bonzini wrote: > Il 30/04/2014 03:11, Marcelo Tosatti ha scritto: > > On Tue, Apr 29, 2014 at 06:17:17PM -0300, Eduardo Habkost wrote: > >> KVM never supported the MONITOR flag so it doesn't make sense to have it > >> enabled by default when KVM is en

Re: [Qemu-devel] [PATCH] target-i386: kvm: Don't enable MONITOR by default on any CPU model

On Wed, Apr 30, 2014 at 02:14:00PM -0300, Marcelo Tosatti wrote: > On Wed, Apr 30, 2014 at 10:44:33AM +0200, Paolo Bonzini wrote: > > Il 30/04/2014 03:11, Marcelo Tosatti ha scritto: > > > On Tue, Apr 29, 2014 at 06:17:17PM -0300, Eduardo Habkost wrote: > > >> KVM never supported the MONITOR flag s

[Qemu-devel] [PATCH v4 15/18] target-i386: Set migratable=yes by default

Having only migratable flags reported by default on the "host" CPU model is safer for the following reasons: * Existing users may expect "-cpu host" to be migration-safe, if they take care of always using compatible host CPUs, host kernels, and QEMU versions. * Users who don't care aboug m

[Qemu-devel] [PATCH v4 01/18] target-i386: kvm: Don't enable MONITOR by default on any CPU model

KVM never supported the MONITOR flag so it doesn't make sense to have it enabled by default when KVM is enabled. The rationale here is similar to the cases where it makes sense to have a feature enabled by default on all CPU models when on KVM mode (e.g. x2apic). In this case we are having a featu

Re: [Qemu-devel] [PATCH v2 1/4] dump: Make DumpState and endian conversion routines available for arch-specific dump code

On 30.04.14 16:14, Greg Kurz wrote: From: Bharata B Rao Make DumpState and endian conversion routines available for arch-specific dump code by moving into dump.h. DumpState will be needed by arch-specific dump code to access target endian information from DumpState->ArchDumpInfo. Also break th

Re: [Qemu-devel] [PATCH v2 0/4] little-endian dump for ppc64

On 30.04.14 16:13, Greg Kurz wrote: Hi, Second take: it addresses Alex's remarks (see changelog in each patch). Patches 2-4 are Reviewed-by: Alexander Graf Alex

[Qemu-devel] [Bug 1314667] [NEW] PMPrebUSB - appcrash of qemu in Win-7-64bit

Public bug reported: I am not sure if this issue is a bug of qemu or by Win-7. I want to test in advance with QEMU the ability if my USB-Rescue-Drive is booting correctly. I have Win-7-64 and run qemu v.o.15.1.0 out of the installed RMPrepUSB v.2.1.719 program. The settings for the preparation

Re: [Qemu-devel] [Qemu-trivial] [PATCH V5 1/1] qmp: add pmemload command

Sorry for reply late Michael (my gmail priority inbox didn't sort this email into my inbox), I thought the change is trivial compare to the huge patch set in the mailing list :) I'm OK with the change not one in the -trivial tree. Best Regards Baojun On Sun, Apr 27, 2014 at 2:18 AM, Michael Toka

[Qemu-devel] [PULL 00/31] Block patches

The following changes since commit e2da502c003b9a91b4aea7684959192bd07c1f1d: Merge remote-tracking branch 'remotes/otubo/seccomp' into staging (2014-04-28 14:14:35 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up

[Qemu-devel] [PULL 11/31] block: Create bdrv_inherited_flags()

Instead of having bdrv_open_flags() as a function that creates flags for several unrelated places and then adding open-coded flags on top, create a new function that derives the flags for bs->file from the flags for bs. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c | 28 +

[Qemu-devel] [PULL 10/31] iotests: Discarding compressed clusters on qcow2

From: Max Reitz Add a test which discards a compressed cluster on qcow2. This should work without any problems. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/090 | 61 ++ tests/qemu-iotests/090.out | 12 + tes

[Qemu-devel] [PULL 01/31] block: fix qemu-img --help invocation

From: Jeff Cody This fixes a bug introduced in commit ac1307ab, that caused the '--help' option to not be recognized as a valid command, and not print any help. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- qemu-img.c | 15 +-- 1 file changed, 13

[Qemu-devel] [PULL 20/31] qcow2: Catch bdrv_getlength() error

From: Max Reitz The call to bdrv_getlength() from qcow2_check_refcounts() may result in an error. Check this and abort if necessary. Signed-off-by: Max Reitz Signed-off-by: Kevin Wolf --- block/qcow2-refcount.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/qcow2-refcount.c b/

[Qemu-devel] [PULL 22/31] block/bochs: Fix error handling for seek_to_sector()

From: Max Reitz Currently, seek_to_sector() returns -1 both for errors and unallocated sectors, resulting in silent errors. As 0 is an invalid offset of data clusters (bitmap_offset is greater than 0 because s->data_offset is greater than 0), just return 0 for unallocated sectors and -errno in ca

[Qemu-devel] [PULL 02/31] mirror: Use DIV_ROUND_UP

From: Fam Zheng Although bdrv_getlength() was just called above this, and checked for error, it is better to just use the value we already get, and use DIV_ROUND_UP. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[Qemu-devel] [PULL 18/31] qcow2: Avoid overflow in alloc_clusters_noref()

From: Max Reitz alloc_clusters_noref() stores the cluster index in a uint64_t. However, offsets are often represented as int64_t (as for example the return value of alloc_clusters_noref() itself demonstrates). Therefore, we should make sure all offsets in the allocated range of clusters are repre

[Qemu-devel] [PULL 19/31] block: Use correct width in format strings

From: Max Reitz Instead of blindly relying on a normal integer having a width of 32 bits (which is a pretty good assumption, but we should not rely on it if there is no need), use the correct format string macros. This does not touch DEBUG output. Signed-off-by: Max Reitz Signed-off-by: Kevin

[Qemu-devel] [PULL 21/31] qcow2: Check min_size in qcow2_grow_l1_table()

From: Max Reitz First, new_l1_size is an int64_t, whereas min_size is a uint64_t. Therefore, during the loop which adjusts new_l1_size until it equals or exceeds min_size, new_l1_size might overflow and become negative. The comparison in the loop condition however will take it as an unsigned valu

[Qemu-devel] [PULL 27/31] curl: Remove erroneous sleep waiting for curl completion

From: Matthew Booth The driver will not start more than a fixed number of curl sessions. If it needs more, it must wait for the completion of an existing one. The driver was sleeping, which will prevent the main loop from running, and therefore the event it's waiting on. It was also directly call

[Qemu-devel] [PULL 26/31] curl: Fix return from curl_read_cb with invalid state

From: Matthew Booth A curl write callback is supposed to return the number of bytes it handled. curl_read_cb would have erroneously reported it had handled all bytes in the event that the internal curl state was invalid. Signed-off-by: Matthew Booth Tested-by: Richard W.M. Jones Signed-off-by

  1   2   >