It's ugly to add const prefix for parameter type by a if statement
outsider c_type(). This patch adds a parameter to do it.
Signed-off-by: Amos Kong
Suggested-by: Markus Armbruster
---
scripts/qapi-commands.py | 4 +---
scripts/qapi.py | 4 +++-
2 files changed, 4 insertions(+), 4 dele
Not a serious issue, but it's helpful if we can fix it.
V2: split change of scripts/qapi-visit.py to a split patch,
eat space by using a special char as Markus suggested
V3: update commitlog, update special string, fix of adding
const replace string by pattern
Amos Kong (3):
qapi: fix c
The space before pointers is redundant.
Signed-off-by: Amos Kong
---
scripts/qapi-visit.py | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index 45ce3a9..8ffed3d 100644
--- a/scripts/qapi-visit.py
+++ b/scri
On win*, we build QEMU_PROGW (GUI) and create a console app QEMU_PROG
from it, while on non-win*, we make only QEMU_PROG using the same
rules as used for QEMU_PROGW on win*. Make just one rule for building
main executable, and an additional rule for win* to make console app
from it. Also consolid
We always generate a space between type and identifier in parameter
and variable declarations, even when idiomatic C style doesn't have
a space there. Suppress it.
Signed-off-by: Amos Kong
---
scripts/qapi.py | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git
Amos Kong writes:
> On Fri, Apr 25, 2014 at 02:52:09PM +0200, Markus Armbruster wrote:
>> Amos Kong writes:
>
> Hi Markus,
>
>> > Currently we always add a space after c_type in mcgen(), there is
>> > some redundant space in generated code. The space isn't needed for
>> > points by the coding
Hi
Please, send any topic that you are interested in covering.
Thanks, Juan.
Call details:
15:00 CEST
13:00 UTC
09:00 EDT
Every two weeks
If you need phone number details, contact me privately.
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/i386/kvm/pci-assign.c | 18 ++
hw/i386/multiboot.c | 15 ++-
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/dma/i82374.c | 17 ++---
hw/dma/i8257.c | 24 +---
hw/dma/rc
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/tpm/tpm_passthrough.c | 17 ++---
hw/tpm/tpm_tis.c | 17 ++---
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/net/cadence_gem.c| 19 ---
hw/net/eepro100.c | 15 ++-
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/s390x/s390-virtio-bus.c | 17 ++---
hw/s390x/s390-virtio.c | 17 ++---
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/isa/vt82c686.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --g
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/sd/sd.c | 14 +-
hw/sd/ssi-sd.c | 24
2 files change
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/pci-host/bonito.c | 15 ++-
hw/pci-host/ppce500.c | 15 +++
2 files
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
target-i386/kvm.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff -
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
slirp/bootp.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
migration-rdma.c | 47 ---
page_cache.c | 17 +++
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
hw/scsi/lsi53c895a.c | 26 +-
hw/scsi/scsi-generic.c | 16 ++--
From: Marc Marí <5.markm...@gmail.com>
Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
Signed-off-by: Marc Marí <5.markm...@gmail.com>
---
target-s390x/helper.c | 32 ++--
target-s390x/kvm.c| 17
On Sun, Apr 27, 2014 at 02:34:09PM +0300, Riku Voipio wrote:
> Hi,
> It looks good in my opinion. I'll include them in my next pull request.
Great, thanks!
> Do you have a testcase for this, I didn't see one in ltp.
No, I don't have a testcase, my use case is Wine. I can take
a look at getting
Il 25/04/2014 17:51, Andreas Färber ha scritto:
if (ambiguous) {
error_setg(errp, "Path '%s' is ambiguous.", path);
} else {
error_set(errp, QERR_DEVICE_NOT_FOUND, path);
}
My reasoning is that an ambiguous path might deliver unpredictable
results (whichever it encounters first), across
Il 26/04/2014 02:46, Hani Benhabiles ha scritto:
if (ambiguous) {
> error_setg(errp, "Path '%s' is ambiguous.", path);
> } else {
> error_set(errp, QERR_DEVICE_NOT_FOUND, path);
> }
>
Probably, you meant something like this:
if (ambiguous) {
error_set(errp, QERR_AMBIGUOUS_PATH, path
Il 24/04/2014 14:49, Andreas Färber ha scritto:
Invented by Anthony. Maintenance has been handled by me lately.
Note that the tests themselves are intentionally not part of this entry;
they are considered part of the device or subsystem they are covering.
Cc: Anthony Liguori
Cc: Stefan Hajnocz
Il 24/04/2014 14:49, Andreas Färber ha scritto:
Invented by Anthony. Maintenance has been handled by me lately.
Note that the tests themselves are intentionally not part of this entry;
they are considered part of the device or subsystem they are covering.
Cc: Anthony Liguori
Cc: Stefan Hajnocz
Il 24/04/2014 15:04, Andreas Färber ha scritto:
Invented by Anthony. Maintained through my qom-next tree lately.
Cc: Anthony Liguori
Cc: Paolo Bonzini
Signed-off-by: Andreas Färber
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
28.04.2014 12:26, Marc Marí пишет:
> From: Marc Marí <5.markm...@gmail.com>
>
> Modify debug macros as explained in
> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
>
> Signed-off-by: Marc Marí <5.markm...@gmail.com>
> ---
> hw/dma/i82374.c | 17 ++---
> hw/dm
Il 18/04/2014 10:29, Alex Bligh ha scritto:
I suspect the easiest fix (certainly for debug purposes) would be to make all
polls for non-zero time at least 10ms long. IE after the assignment of 'ms',
do something like
#ifdef BROKEN_POLL
if (ms < 10) {
ms = 10;
#endif
}
If you're
Am 28.04.2014 um 10:26 hat Marc Marí geschrieben:
> From: Marc Marí <5.markm...@gmail.com>
>
> Modify debug macros as explained in
> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
>
> Signed-off-by: Marc Marí <5.markm...@gmail.com>
> ---
> hw/dma/i82374.c | 17 ++-
Signed-off-by: Gerd Hoffmann
---
tests/Makefile | 5 +
tests/display-vga-test.c | 38 ++
2 files changed, 43 insertions(+)
create mode 100644 tests/display-vga-test.c
diff --git a/tests/Makefile b/tests/Makefile
index 88f7105..c6b6614 100644
--
Hi,
This series adds a standard vga variant which doesn't occupy any legacy
ressources and thus can easily be used as secondary (or legacy-free)
graphics adapter. Programming must be done using the MMIO bar.
bochsdrm (linux 3.14+) can drive the card. You can use loginctl to
attach the second
Need a way to opt-out from vga.vram being global vmstate, for
secondary vga cards. Add a bool parameter to vga_common_init
to support this.
Signed-off-by: Gerd Hoffmann
---
hw/display/cirrus_vga.c | 4 ++--
hw/display/qxl.c| 2 +-
hw/display/vga-isa-mm.c | 2 +-
hw/display/vga-isa.c
Add a standard vga variant which doesn't occupy any legacy
resources and thus can easily be used as secondary (or legacy-free)
graphics adapter. Programming must be done using the MMIO bar.
Signed-off-by: Gerd Hoffmann
---
docs/specs/standard-vga.txt | 13 +++---
hw/display/vga-pci.c
Signed-off-by: Gerd Hoffmann
---
tests/display-vga-test.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/tests/display-vga-test.c b/tests/display-vga-test.c
index 23be88f..17f5910 100644
--- a/tests/display-vga-test.c
+++ b/tests/display-vga-test.c
@@ -24,6 +24,18 @@ static v
28.04.2014 12:26, Marc Marí wrote:
[]
> +#define linfo(...) \
> +do { \
> +if(DEBUG_DMA) { \
> +fprintf(stderr, "dma: " __VA_ARGS__); \
> +} \
> +} while (0)
> +
> +#define ldebug(...) \
> +do { \
> +if(DEBUG_DMA) { \
> +fprintf(stderr
Il 22/04/2014 19:08, Roger Pau Monne ha scritto:
> On FreeBSD polling a master pty while the other end is not connected
> with G_IO_OUT only results in an endless wait. This is different from
> the Linux behaviour, that returns immediately. In order to demonstrate
> this, I have the following examp
Il 22/04/2014 11:41, Stanislav Vorobiov ha scritto:
>m.b. it makes sense to move entire qemu_poll_ns to oslib then ? like
>this patch to oslib-win32.c and the rest of the stuff to oslib-posix.c ?
But Stefan proposed to make it this
way (which is also reasonable, since we replace buggy g_poll wit
Il 22/04/2014 11:21, Marcel Apfelbaum ha scritto:
Here is the *real* problem: fw_boot_order list is not queried
again on guest reboot, so 'touching' the list has no effect.
While your code is correct (as far as I can tell), it seems
that his place is after the above problem is solved.
Doesn't J
19.03.2014 12:19, Deepak Kathayat wrote:
> Signed-off-by: Deepak Kathayat
> ---
> The len variable is a signed integer whereas the backing file name
> length in the image header is unsigned. Therefore, it may
> overflow. Furthermore, backing file name length cannot be
> zero. These two cases mu
On 28/04/14 11:19, Paolo Bonzini wrote:
> Il 22/04/2014 19:08, Roger Pau Monne ha scritto:
>> On FreeBSD polling a master pty while the other end is not connected
>> with G_IO_OUT only results in an endless wait. This is different from
>> the Linux behaviour, that returns immediately. In order to d
Hi Rob,
On 26 April 2014 00:17, Rob Herring wrote:
> On Thu, Apr 10, 2014 at 6:46 AM, Pranavkumar Sawargaonkar
> wrote:
>> If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then
>> we enable PSCI v0.2 for each VCPU at the time of VCPU init hence we
>> need to provide PSCI v0.2 functi
On Fr, 2014-04-25 at 16:46 -0400, Cole Robinson wrote:
> On 04/25/2014 05:11 AM, Gerd Hoffmann wrote:
> > On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
> >> When keyboard focus is grabbed, current qemu wants to pass every
> >> keypress to the VM, unless the user is pressing a UI accelerato
On Mon, 2014-04-28 at 11:22 +0200, Paolo Bonzini wrote:
> Il 22/04/2014 11:21, Marcel Apfelbaum ha scritto:
> > Here is the *real* problem: fw_boot_order list is not queried
> > again on guest reboot, so 'touching' the list has no effect.
> > While your code is correct (as far as I can tell), it se
Hi,
> > If the kernel has booted up, the check will not happen, so the Linux kernel
> > will not get confused.
>
> I didn't find that the checking is necessary in protocol docs.
> any hint?
>
> If we still use 256 size buffer in qemu, guest ps2 driver will drop
> some input keys? or just del
On Sa, 2014-04-26 at 23:02 +1000, Alexey Kardashevskiy wrote:
> On 04/13/2014 08:42 PM, Alexey Kardashevskiy wrote:
> > This adds migration support for OHCI.
> >
> > This defines a descriptor for OHCIState.
> > This changes some OHCIState field types to be migration compatible.
> > This adds a des
Il 16/04/2014 04:09, Fam Zheng ha scritto:
More often it is that bdrv_ioctl fails due to not supported by driver or
whatever reason, in this case we should be specific, because "interface
too old" is very confusing.
Signed-off-by: Fam Zheng
---
hw/scsi/scsi-disk.c | 9 +++--
1 file changed
On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote:
> /* Debug EEPRO100 card. */
> #if 0
> -# define DEBUG_EEPRO100
> +#define DEBUG_EEPRO100 1
> #endif
There seem to be a few ways of doing this (commenting out the line,
putting it in #if 0, etc).
Feel free to get rid of #define DEBUG_f
Il 22/01/2014 15:32, Fabio Fantoni ha scritto:
Il 28/10/2013 10:38, Jan Beulich ha scritto:
On 24.10.13 at 14:17, "Gonglei (Arei)"
wrote:
Now I test the patch based on the codes of trunk, which works well.
The patch has been modified after your suggestion.
Partly. I looks reasonable now, but
Make the message the same for both scsi-block and scsi-generic,
including the strerror() output in both and making an explicit
reference to SG_IO. Also s/can not/cannot/.
Signed-off-by: Paolo Bonzini
---
hw/scsi/scsi-disk.c| 5 +++--
hw/scsi/scsi-generic.c | 8 ++--
2 files changed, 9 i
On 27 April 2014 17:26, Michael Tokarev wrote:
> Replace QemuMutex with GMutex and QemuCond with GCond
> (with corresponding function changes), to make libcacard
> independent of qemu internal functions.
> --- a/libcacard/event.c
> +++ b/libcacard/event.c
> @@ -43,13 +43,13 @@ vevent_delete(VEven
I left the original definition as it was, just adding the "1", that's why
there is so much diversity. I'll remove them for v2.
2014-04-28 12:10 GMT+02:00 Stefan Hajnoczi :
> On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote:
> > /* Debug EEPRO100 card. */
> > #if 0
> > -# define DEBUG_
On Mon, 2014-04-28 at 12:14 +0200, Fabio Fantoni wrote:
> Il 22/01/2014 15:32, Fabio Fantoni ha scritto:
> > Il 28/10/2013 10:38, Jan Beulich ha scritto:
> > On 24.10.13 at 14:17, "Gonglei (Arei)"
> > wrote:
> >>> Now I test the patch based on the codes of trunk, which works well.
> >>> T
On Fri, Apr 04, 2014 at 12:45:20PM +0300, Dmitry Fleytman wrote:
> CVE-2013-4544
>
> Signed-off-by: Dmitry Fleytman
> Reported-by: Michael S. Tsirkin
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Michael S. Tsirkin
> ---
> hw/net/vmxnet3.c | 19 ++-
> 1 file changed, 18
On 25 April 2014 13:02, Cornelia Huck wrote:
> No further comments had been made on the patches below, so sending a
> pull request.
>
> The following changes since commit 0e96643c98eb22a5f2e11ac500852133032d38e4:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-5' into staging
> (
On Thu, Apr 03, 2014 at 08:04:23PM +0200, Alexander Graf wrote:
>
> On 03.04.2014, at 18:51, Michael S. Tsirkin wrote:
>
> > From: Michael Roth
> >
> > CVE-2013-4534
> >
> > opp->nb_cpus is read from the wire and used to determine how many
> > IRQDest elements to read into opp->dst[]. If the
Il 17/04/2014 15:44, Michael S. Tsirkin ha scritto:
I'm fine with this.
And I'm not against a runtime switch to get rid of per-target build of virtio.
I am merely asking for separatable patchsets, e.g. structured like this:
1. implement bi-endian support with no data path overhead for fixed endi
On Tue, Apr 01, 2014 at 11:14:48PM +0100, Peter Maydell wrote:
> This patchset overhauls the stellaris_enet TX and RX handling code,
> and converts it to use vmstate.
>
> The principal motivation is to fix the buffer overrun noted
> in the first patch, and to reimplement things using simpler
> sta
The old_portio mechanism in the memory API has been removed, but
we forgot to update the documentation to match. Remove the stray
reference to this now-vanished bit of back-compatibility API.
Signed-off-by: Peter Maydell
---
docs/memory.txt | 5 ++---
1 file changed, 2 insertions(+), 3 deletions
On 25 April 2014 15:09, Stefan Hajnoczi wrote:
> The following changes since commit 0e96643c98eb22a5f2e11ac500852133032d38e4:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-5' into staging
> (2014-04-24 16:16:57 +0100)
>
> are available in the git repository at:
>
>
> git://gi
On Tue, Apr 01, 2014 at 11:14:55PM +0100, Peter Maydell wrote:
> Convert this device to use vmstate for its save/load, including
> providing a post_load function that sanitizes inbound data to
> avoid possible buffer overflows if it is malicious.
>
> Signed-off-by: Peter Maydell
Might be a good
QEMU tends to have rather a lot of half-finished API or coding style
transitions, as an inevitable consequence of our having such a large
code base with wildly varying levels of maintainedness. I thought it
would be useful to at least document them on the wiki:
http://wiki.qemu.org/CodeTransitions
Paolo Bonzini writes:
> Make the message the same for both scsi-block and scsi-generic,
> including the strerror() output in both and making an explicit
> reference to SG_IO. Also s/can not/cannot/.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/scsi/scsi-disk.c| 5 +++--
> hw/scsi/scsi-gener
this patch implements a cache that tracks if a page on the
iscsi target is allocated or not. The cache is implemented in
a way that it allows for false positives
(e.g. pretending a page is allocated, but it isn't), but
no false negatives.
The cached allocation info is then used to speed up the
rea
Signed-off-by: Peter Lieven
---
block/iscsi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index a636ea4..0819945 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -2,7 +2,7 @@
* QEMU Block driver for iSCSI images
*
* Copyright (c) 201
Hi Marc,
On such a long series, it's usual to include a cover letter
summarising the entire series. Its subject is "PATCH 00/NN" and can be
generated by adding the --cover-letter switch to git send-email. Hand
edit the file them send along with the autogenerated patches.
On Mon, Apr 28, 2014 at 6
if the iscsi driver receives a write zeroes request with
the BDRV_REQ_MAY_UNMAP flag set it fails with -ENOTSUP
if the iscsi target does not support WRITE SAME with
UNMAP. However, the BDRV_REQ_MAY_UNMAP is only a hint
and writing zeroes with WRITE SAME will still be
better than falling back to wri
POWER7, POWER7+ and POWER8 families use the ILE bit of the LPCR
special purpose register to decide the endianness to use when
entering interrupt handlers. When running a linux guest, this
provides a hint on the endianness used by the kernel. From a
qemu point of view, the information is needed for
From: Bharata B Rao
Make DumpState and endian conversion routines available for arch-specific dump
code by moving into dump.h. DumpState will be needed by arch-specific dump
code to access target endian information from DumpState->ArchDumpInfo. Also
break the dependency of dump.h from stubs/dump.
Hi,
This patch set allows to dump a little-endian ppc64 guest.
Note that the "target-ppc: ppc can be either endian" patch will also
benefit to cross-endian virtio.
Cheers.
---
Bharata B Rao (3):
dump: Make DumpState and endian conversion routines available for
arch-specific dump code
From: Bharata B Rao
Fix ppc64 arch specific dump code to work correctly for little endian
guests.
Signed-off-by: Bharata B Rao
[ rebased on top of current master branch,
Greg Kurz ]
Signed-off-by: Greg Kurz
---
target-ppc/arch_dump.c | 62 ++--
From: Bharata B Rao
Signed-off-by: Bharata B Rao
[ use ppc_cpu_interrupts_big_endian(),
Greg Kurz ]
Signed-off-by: Greg Kurz
---
target-ppc/arch_dump.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/target-ppc/arch_dump.c b/target-ppc/arch_dump.c
index a85c8
Peter Maydell writes:
> QEMU tends to have rather a lot of half-finished API or coding style
> transitions, as an inevitable consequence of our having such a large
> code base with wildly varying levels of maintainedness. I thought it
> would be useful to at least document them on the wiki:
>
> h
Remove the "scsi-block:" prefix for error messages as suggested
by Markus.
Improve the previous patch by making the message the same for both
scsi-block and scsi-generic, including the strerror() output in both
and making an explicit reference to SG_IO. Also s/can not/cannot/.
Signed-off-by: Pao
Il 17/04/2014 17:01, Michael S. Tsirkin ha scritto:
On Thu, Apr 17, 2014 at 03:41:56PM +0200, Hannes Reinecke wrote:
On 04/17/2014 02:07 PM, Andreas Färber wrote:
Am 17.04.2014 08:20, schrieb Hannes Reinecke:
On 04/16/2014 07:52 PM, Michael S. Tsirkin wrote:
On Wed, Apr 16, 2014 at 07:47:37PM
28.04.2014 14:19, Peter Maydell wrote:
> On 27 April 2014 17:26, Michael Tokarev wrote:
>> -static QemuMutex vevent_queue_lock;
>> -static QemuCond vevent_queue_condition;
>> +static GMutex vevent_queue_lock;
>> +static GCond vevent_queue_condition;
>>
>> void vevent_queue_init(void)
>> {
>> -
On 04/28/2014 01:45 PM, Paolo Bonzini wrote:
Hannes Reinecke wrote:
I'm happy to continue with having the original implementation at
PCI, and only moving to PCIe with the gen2 emulation.
Ok, for now I'm applying this patch without the PCI->PCIE change.
Hmm. Better let me send a new patch whic
The Monday 28 Apr 2014 à 09:07:58 (+0400), Michael Tokarev wrote :
> From: Stefan Weil
>
> The "Q" of the logo is already included in pc-bios/qemu_logo_no_text.svg.
>
> This file now adds the complete logo as it was designed by Benoît Canet.
> Benoît licensed it under CC-BY 3.0, see
> http://li
Il 28/04/2014 13:49, Hannes Reinecke ha scritto:
Ok, for now I'm applying this patch without the PCI->PCIE change.
Hmm. Better let me send a new patch which reverts the PCI->PCIE change
and make only megasas-gen2 a PCIE board.
If I push patches 1-3 and 7 to scsi-next, you can start from ther
Am 28.04.2014 um 12:56 hat Peter Maydell geschrieben:
> QEMU tends to have rather a lot of half-finished API or coding style
> transitions, as an inevitable consequence of our having such a large
> code base with wildly varying levels of maintainedness. I thought it
> would be useful to at least do
On 04/28/2014 01:51 PM, Paolo Bonzini wrote:
Il 28/04/2014 13:49, Hannes Reinecke ha scritto:
Ok, for now I'm applying this patch without the PCI->PCIE change.
Hmm. Better let me send a new patch which reverts the PCI->PCIE
change
and make only megasas-gen2 a PCIE board.
If I push patches 1
2014-04-28 11:05 GMT+02:00 Michael Tokarev :
>
> 28.04.2014 12:26, Marc Marí пишет:
> > From: Marc Marí <5.markm...@gmail.com>
> >
> > Modify debug macros as explained in
https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
> >
> > Signed-off-by: Marc Marí <5.markm...@gmail.com>
> >
Am 28.04.2014 um 12:10 hat Stefan Hajnoczi geschrieben:
> On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote:
> > /* Debug EEPRO100 card. */
> > #if 0
> > -# define DEBUG_EEPRO100
> > +#define DEBUG_EEPRO100 1
> > #endif
>
> There seem to be a few ways of doing this (commenting out the l
On 25 April 2014 17:07, Stefan Hajnoczi wrote:
> The following changes since commit 411f491e0af173cf8f39347574941bd26fbae381:
>
> Merge remote-tracking branch 'remotes/rth/tags/tgt-axp-pull-20140424' into
> staging (2014-04-25 13:25:22 +0100)
>
> are available in the git repository at:
>
>
>
Il 28/04/2014 11:38, Marcel Apfelbaum ha scritto:
> Doesn't Jun's patch fix a dangling pointer? If so, that would come
> first anyway.
It removes pointers from a "dead" list, and it only deals with
some symptom.
Yeah, but dangling pointers are bad anyway. I think we should include
Jun's pat
Hi,
> Subject: Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply
> _EJ0 methods for PCIslots that support hotplug by runtime patching
>
> On Mon, 2014-04-28 at 12:14 +0200, Fabio Fantoni wrote:
> > Il 22/01/2014 15:32, Fabio Fantoni ha scritto:
> > > Il 28/10/2013 10:38, Jan Beul
Am 25.04.2014 um 23:02 hat Jeff Cody geschrieben:
> This fixes a bug introduced in commit ac1307ab, that caused the
> '--help' option to not be recognized as a valid command, and not
> print any help.
>
> Signed-off-by: Jeff Cody
Thanks, applied to the block branch.
Kevin
Am 28.04.2014 um 04:59 hat Fam Zheng geschrieben:
> Although bdrv_getlength() was just called above this, and checked for
> error, it is better to just use the value we already get, and use
> DIV_ROUND_UP.
>
> Signed-off-by: Fam Zheng
The subject line is kind of hiding the real intention of the
Hi, Gerd.
What's your opinion about this issue? Thanks!
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Wednesday, March 26, 2014 4:15 PM
> To: 'Gerd Hoffmann'
> Cc: qemu-devel@nongnu.org; Huangweidong (C)
> Subject: RE: [PATCH] uhci: Lower uhci timer freq w
Am 28.04.2014 11:02, schrieb Paolo Bonzini:
> Il 24/04/2014 14:49, Andreas Färber ha scritto:
>> Invented by Anthony. Maintenance has been handled by me lately.
>>
>> Note that the tests themselves are intentionally not part of this entry;
>> they are considered part of the device or subsystem they
Am 28.04.2014 um 04:57 hat Fam Zheng geschrieben:
> bdrv_get_info could fail. Add check before using the returned value.
>
> Signed-off-by: Fam Zheng
>
> ---
> V2: Handle error case (Stefan).
>
> Signed-off-by: Fam Zheng
> ---
> block/mirror.c | 6 +-
> 1 file changed, 5 insertions(+), 1
Il 24/04/2014 16:15, Kirill Batuzov ha scritto:
v1 -> v2:
I tried adding PortioList to AdlibState, PCIQXLDevice etc like Paolo suggested.
It worked fine for all cases except for isa_register_portio_list.
isa_register_portio_list can be called:
- with NULL instead of real ISADevice *,
- sev
Il 28/04/2014 14:21, Michael S. Tsirkin ha scritto:
A more practical way is when make runs configure automatically:
1. cd /; ./configure
SRC_PATH=/ is written into config_host.mak
2. cd /; touch configure; make
make now runs /configure, so configure
assumes it's an out of tree build
Hi Marc,
Am 28.04.2014 10:26, schrieb Marc Marí:
> From: Marc Marí <5.markm...@gmail.com>
>
> Modify debug macros as explained in
> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
>
> Signed-off-by: Marc Marí <5.markm...@gmail.com>
> ---
> hw/dma/i82374.c | 17 ++-
Amos Kong writes:
> The space before pointers is redundant.
Eric suggested "A space after * when declaring a pointer type is
redundant." Did you see that?
> Signed-off-by: Amos Kong
Keeping Reviewed-by: Eric Blake around would've been
nice. Next time :)
Amos Kong writes:
> It's ugly to add const prefix for parameter type by a if statement
> outsider c_type(). This patch adds a parameter to do it.
"outside".
The rx_fifo pointer is awkward to migrate, and is actually
redundant since it is always possible to determine it from
the current rx[].len/.data and rx_fifo_len. Remove both
rx_fifo and rx_fifo_len from the state, replacing them with
a simple rx_fifo_offset which points at the current location
in t
This patchset overhauls the stellaris_enet TX and RX handling code,
and converts it to use vmstate.
The principal motivation is to fix the buffer overrun noted
in the first patch, and to reimplement things using simpler
state fields which are easier to migrate and to validate in
post_load. I also
From: Paul Moore
Additional testing reveals that PulseAudio requires shmctl() and the
mlock()/munlock() syscalls on some systems/configurations. As before,
on systems that do require these syscalls, the problem can be seen with
the following command line:
# qemu -monitor stdio -sandbox on \
On Mon, Apr 28, 2014 at 10:25 PM, Andreas Färber wrote:
> Hi Marc,
>
> Am 28.04.2014 10:26, schrieb Marc Marí:
>> From: Marc Marí <5.markm...@gmail.com>
>>
>> Modify debug macros as explained in
>> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
>>
>> Signed-off-by: Marc Marí
From: Felix Geyer
libusb calls timerfd_create() and timerfd_settime() when it's built with
timerfd support.
Command to reproduce:
-device usb-host,hostbus=1,hostaddr=3,id=hostdev0
Log messages:
audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4294967295
1 - 100 of 311 matches
Mail list logo
