Eric Blake writes:
> On 04/25/2014 09:05 AM, Markus Armbruster wrote:
>> Using error_is_set(errp) to check whether a function call failed is
>> fragile: it breaks when errp is null. I'm not aware of actual
>> breakage, but checking return values instead when convenient is more
>> robust and more
Hi,
Are you talking about running KVM(hardware virtualization) enabled
support on top of a Linux host running on only QEMU (software
virtualization)? I doubt if this is nesting is possible. To be sure,
you can check for the following flags on your host:
cat /proc/cpuinfo | grep -e svm -e vmx
If e
On Wed, Apr 23, 2014 at 12:04:49PM +0200, Kevin Wolf wrote:
> From: Fam Zheng
>
> Previously, when there is a user error in argv parsing, qemu-img prints
> help text and exits.
>
> Add an error_exit function to print a helpful error message and a hint
> to run 'qemu-img --help' for more informat
On 04/25/2014 12:06 PM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 04/25/2014 09:05 AM, Markus Armbruster wrote:
>>> Using error_is_set(errp) to check whether a function call failed is
>>> fragile: it breaks when errp is null. I'm not aware of actual
>>> breakage, but checking return
On Fri, 25 Apr 2014 12:21:22 -0600
Eric Blake wrote:
> On 04/25/2014 12:06 PM, Markus Armbruster wrote:
> > Eric Blake writes:
> >
> >> On 04/25/2014 09:05 AM, Markus Armbruster wrote:
> >>> Using error_is_set(errp) to check whether a function call failed is
> >>> fragile: it breaks when errp i
This fixes a bug introduced in commit ac1307ab, that caused the
'--help' option to not be recognized as a valid command, and not
print any help.
This also restores the previous behavior of qemu-img printing the full
help when called with no arguments.
Signed-off-by: Jeff Cody
---
qemu-img.c | 5
The following changes since commit 7931b05987564b07ada5a4467d8e78a786a3e7d4:
Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging
(2014-04-25 12:22:37 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/qmp-unstable.git queue/qmp
for you to fetch ch
On 04/25/2014 09:05 AM, Markus Armbruster wrote:
> I got a private branch getting rid of it entirely. This is the fifth
> part, covering QMP and the guest agent up to the point where I start
> messing with the QAPI code generators. That's left for the final
> part.
>
> Luiz, Mike, do I need to s
On 04/25/2014 12:27 PM, Jeff Cody wrote:
> This fixes a bug introduced in commit ac1307ab, that caused the
> '--help' option to not be recognized as a valid command, and not
> print any help.
>
> This also restores the previous behavior of qemu-img printing the full
> help when called with no argu
Am 25.04.2014 20:02, schrieb Luiz Capitulino:
> On Fri, 25 Apr 2014 17:57:12 +0200
> Andreas Färber wrote:
>> Am 25.04.2014 17:12, schrieb Luiz Capitulino:
>>> On Wed, 16 Apr 2014 14:39:38 -0300
>>> Eduardo Habkost wrote:
>>>
Currently it is very easy to crash QEMU by issuing an object-add c
From: Cole Robinson
Just hardcode them in the callers
Cc: Luiz Capitulino
Cc: Markus Armbruster
Signed-off-by: Cole Robinson
Reviewed-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
block/commit.c| 2 +-
blockdev.c| 9 ---
hw/9pfs/virtio-9p.c |
From: Cole Robinson
Cc: Luiz Capitulino
Cc: Markus Armbruster
Signed-off-by: Cole Robinson
Reviewed-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
include/qapi/qmp/qerror.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.
From: Qiao Nuohan
Dumping guest memory is available to specify the dump format now. This patch
adds options '-z|-l|-s' to HMP command dump-guest-memory to specify dumping in
kdump-compression format, with zlib/lzo/snappy compression. And without these
options ELF format will be used.
The discuss
On Thu, Apr 10, 2014 at 6:46 AM, Pranavkumar Sawargaonkar
wrote:
> If we have in-kernel emulation of PSCI v0.2 for KVM ARM/ARM64 then
> we enable PSCI v0.2 for each VCPU at the time of VCPU init hence we
> need to provide PSCI v0.2 function IDs via generated DTB.
>
> This patch updates generated D
From: Cole Robinson
The former is only used twice, the latter is used over 30 times, and
has a nicer error message.
Cc: Luiz Capitulino
Cc: Markus Armbruster
Signed-off-by: Cole Robinson
Reviewed-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
blockjob.c | 2 +-
includ
From: Eduardo Habkost
Currently it is very easy to crash QEMU by issuing an object-add command
using an abstract class or a class that doesn't support
TYPE_USER_CREATABLE as parameter.
Example: with the following QMP command:
(QEMU) object-add qom-type=cpu id=foo
QEMU aborts at:
ERROR
From: Cole Robinson
Makes it a bit clear how the interdependencies work.
Cc: Luiz Capitulino
Cc: Markus Armbruster
Signed-off-by: Cole Robinson
Reviewed-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
include/qapi/qmp/qerror.h | 1 -
util/error.c | 5 +
2 files change
From: Cole Robinson
monitor_printf will drop the requested output if cur_mon is qmp (for
good reason). However these messages are often helpful for debugging
issues with via libvirt.
If we know the message won't hit the monitor, send it to stderr.
Cc: Luiz Capitulino
Cc: Markus Armbruster
Sig
From: Hani Benhabiles
Also fix device_add completion including non-hotpluggable devices.
Signed-off-by: Hani Benhabiles
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 2 ++
hmp.h | 2 ++
monitor.c | 38 --
3 files changed, 28 inserti
From: Hani Benhabiles
Convert object_add and object_del commands to use the new callback.
Signed-off-by: Hani Benhabiles
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 2 ++
hmp.h | 3 +++
monitor.c | 19 +--
3 files changed, 18 insertions(+), 6 deletio
From: Stefan Hajnoczi
qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to
the caller. Therefore all code paths in qmp_getfd() should either
register the file descriptor somewhere or close it.
Signed-off-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
Signed-off-by: Luiz C
From: Cole Robinson
These errors don't seem user initiated, so forcibly printing to the
monitor doesn't seem right. Just use error_report.
Cc: Anthony Liguori
Cc: Gerd Hoffmann
Signed-off-by: Cole Robinson
Reviewed-by: Paolo Bonzini
Signed-off-by: Luiz Capitulino
---
ui/vnc.c | 4 ++--
1 f
From: Qiao Nuohan
Signed-off-by: Qiao Nuohan
Reviewed-by: Markus Armbruster
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 19 ++-
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 4c4d261..d79cb97 100644
--- a/hmp-com
From: Hani Benhabiles
Signed-off-by: Hani Benhabiles
Signed-off-by: Luiz Capitulino
---
hmp-commands.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index f3fc514..6bf4797 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -176,7 +176
On Thu, Apr 10, 2014 at 6:46 AM, Pranavkumar Sawargaonkar
wrote:
> Provide QEMU PSCI v0.2 constants for non-KVM code; this will
> allow us to avoid an #ifdef in boards which set up a PSCI v0.2
> node in the device tree.
>
> Signed-off-by: Pranavkumar Sawargaonkar
> Signed-off-by: Anup Patel
> --
On Fri, Apr 25, 2014 at 12:39:03PM -0600, Eric Blake wrote:
> On 04/25/2014 12:27 PM, Jeff Cody wrote:
> > This fixes a bug introduced in commit ac1307ab, that caused the
> > '--help' option to not be recognized as a valid command, and not
> > print any help.
> >
> > This also restores the previou
Am 09.04.2014 19:34, schrieb Marcel Apfelbaum:
> This minimizes QEMUMachine usage, as part of machine QOM-ification.
>
> Signed-off-by: Marcel Apfelbaum
> ---
> include/hw/xen/xen.h| 2 +-
> include/qemu/typedefs.h | 1 +
> include/sysemu/kvm.h| 2 +-
> include/sysemu/qtest.h | 2 +-
On Fri, Apr 25, 2014 at 08:42:59PM +0200, Andreas Färber wrote:
> Am 25.04.2014 20:02, schrieb Luiz Capitulino:
> > On Fri, 25 Apr 2014 17:57:12 +0200
> > Andreas Färber wrote:
> >> Am 25.04.2014 17:12, schrieb Luiz Capitulino:
> >>> On Wed, 16 Apr 2014 14:39:38 -0300
> >>> Eduardo Habkost wrote:
Jeff Cody writes:
> On Wed, Apr 23, 2014 at 12:04:49PM +0200, Kevin Wolf wrote:
>> From: Fam Zheng
>>
>> Previously, when there is a user error in argv parsing, qemu-img prints
>> help text and exits.
>>
>> Add an error_exit function to print a helpful error message and a hint
>> to run 'qemu-
On Thu, Apr 24, 2014 at 06:32:42PM -0300, Marcelo Tosatti wrote:
> On Thu, Apr 24, 2014 at 04:21:59PM -0300, Eduardo Habkost wrote:
> > On Wed, Apr 23, 2014 at 06:04:45PM -0300, Marcelo Tosatti wrote:
> > >
> > > Invariant TSC documentation mentions that "invariant TSC will run at a
> > > constant
On 04/25/2014 05:09 AM, Gerd Hoffmann wrote:
> On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
>> The accelerator was ctrl+shift+'+', but '+' required a shift key already,
>> so the accelerator didn't trigger. Switch it to ctrl+shift+'='
>
> Hmm? For me the accelerator is ctrl+alt.
>
> Al
On 04/25/2014 05:11 AM, Gerd Hoffmann wrote:
> On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
>> When keyboard focus is grabbed, current qemu wants to pass every
>> keypress to the VM, unless the user is pressing a UI accelerator.
>>
>> That's exactly how things work without any of the fanc
This fixes a bug introduced in commit ac1307ab, that caused the
'--help' option to not be recognized as a valid command, and not
print any help.
Signed-off-by: Jeff Cody
---
qemu-img.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
in
Il 25/04/2014 01:18, Eduardo Habkost ha scritto:
On Fri, Apr 25, 2014 at 12:57:48AM +0200, Paolo Bonzini wrote:
Il 24/04/2014 22:57, Eduardo Habkost ha scritto:
If that didn't break other use cases, I would agree.
But "-cpu host" today covers two use cases: 1) enabling everything that
can be e
On 04/25/2014 03:02 PM, Jeff Cody wrote:
> This fixes a bug introduced in commit ac1307ab, that caused the
> '--help' option to not be recognized as a valid command, and not
> print any help.
>
> Signed-off-by: Jeff Cody
> ---
> qemu-img.c | 15 +--
> 1 file changed, 13 insertions(+)
On 04/25/14 18:05, Eric Blake wrote:
> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>> get_real_id() has two thin wrappers (and no other callers),
>> get_real_vendor_id() and get_real_device_id(); it's easiest to convert
>> them in one fell swoop.
>>
>> Signed-off-by: Laszlo Ersek
>> ---
>> hw/i38
On 25 April 2014 20:24, Rob Herring wrote:
> I don't see the point of MISMATCH_CHECK with 0.2 PSCI. The values are
> fixed and the header is the ABI. Why can't all of QEMU use the psci.h
> header?
That would depend on where the psci.h header comes from.
In general we can't use kernel headers beca
Some drivers probe PHY addresses beyond the first one, and
also (unfortunately) don't check for MDIC_ERROR on reads. It appears
that the driver assumes that the data reads will return zero in this
case (invalid PHY address). Anecdotally, hardware is believed to do
this; but qemu wasn't, and instead
Some drivers set RDT=RDH. Oddly, this works on real hardware. To work
around this, autodecrement RDT when this happens.
Signed-off-by: Richard Tollerton
Signed-off-by: Jeff Westfahl
---
hw/net/e1000.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
inde
The 8254x driver in certain versions of Phar Lap ETS hasn't been
initializing the e1000 device properly in qemu. It looks like the driver
is relying on two specific pieces of behavior which (anecdotally) exist
in hardware, although I can't cite any datasheets on the matter; in any
case, these two p
Am 09.04.2014 19:34, schrieb Marcel Apfelbaum:
>
> This is a continuation of 'QEMU Machine as QOM object' effort.
> The scope of this series is to allow machine QOM-ification
> of all machines gradually, by removing the need for QEMUMachine registration
> through vl.c .
>
> Now we will have 2 pa
On Fri, Apr 25, 2014 at 05:38:08PM -0300, Eduardo Habkost wrote:
> Have you tested if your patch actually blocks savevm?
Yes, with -smp 2.
Can you please include the savevm.c patch in your queue?
TIA.
Check vmsd for unmigratable field, allowing migratibility status
to be modified after vmstate_register.
Signed-off-by: Marcelo Tosatti
diff --git a/savevm.c b/savevm.c
index 22123be..61a25c0 100644
--- a/savevm.c
+++ b/savevm.c
@@ -452,7 +452,7 @@ bool qemu_savevm_state_blocked(Error **errp)
When an array of mount point paths is specified as 'mountpoints' argument
of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file
systems mounted on specified paths in Linux.
This would be useful when the host wants to create partial disk snapshots.
Signed-off-by: Tomoki Sekiya
Am 25.04.2014 12:44, schrieb Markus Armbruster:
> Using error_is_set(ERRP) to find out whether a function failed is
> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
> may be null, because errors go undetected when it is. It's fragile
> when proving ERRP non-null involves a n
Am 25.04.2014 14:55, schrieb Markus Armbruster:
> Andreas Färber writes:
>> Am 25.04.2014 12:44, schrieb Markus Armbruster:
>>> Using error_is_set(ERRP) to find out whether a function failed is
>>> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
>>> may be null, because error
John Baboval Wrote:
>I assume Windows 7 or newer?
>
>In order to speed boot time, Windows will remove the AHCI driver from the
>critical driver database when you boot with no AHCI controller on the bus. If
>you later want >to switch to AHCI mode, you have to boot with IDE again, and
>re-add the
On Fri, Apr 25, 2014 at 08:39:48AM -0700, Guenter Roeck wrote:
> The TCSR register has only 11 valid bits. This is now used by the
> linux kernel to auto-detect endianness, and causes Linux 3.15-rc1
> and later to hang when run under qemu-microblaze. Mask valid bits
> before writing the register to
New module dhcp_vendopt.c provides translate_dhcp_vendopt() function to convert
command-line DHCP vendor option string into internal DHCP TLV (tag-length-
value) uint8_t buffer. The buffer is stored in global Slirp instance.
Signed-off-by: Fedor Lyakhov
---
slirp/Makefile.objs | 1 +
slirp/dh
Hello qemu-devel,
This patch series adds support of vendor-specific info option to built-in
(slirp)
DHCP server. This feature would be useful for those who develop and test
DHCP-based
systems (e.g. auto-configuration) using QEMU.
Vendor-specific information option is defined in RFC2132 - this
Signed-off-by: Fedor Lyakhov
---
slirp/bootp.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/slirp/bootp.c b/slirp/bootp.c
index b7db9fa..df8d527 100644
--- a/slirp/bootp.c
+++ b/slirp/bootp.c
@@ -21,7 +21,7 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE
Signed-off-by: Fedor Lyakhov
---
slirp/debug.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/slirp/debug.h b/slirp/debug.h
index 6cfa61e..84754d4 100644
--- a/slirp/debug.h
+++ b/slirp/debug.h
@@ -5,6 +5,9 @@
* terms and conditions of the copyright.
*/
+#ifndef SLIRP_DEBUG_H
+#de
Current slirp/bootp.h is bloated - it contains both BOOTP/DHCP protocol
definitions and implementation-related structs. Protocol definitions are needed
in other modules, but the structs are unwanted there as introducing unrelated
dependency. To solve this issue, bootp.h is split into two files:
-
Signed-off-by: Fedor Lyakhov
---
tests/Makefile| 3 +
tests/test-dhcp-vendopt.c | 203 ++
2 files changed, 206 insertions(+)
create mode 100644 tests/test-dhcp-vendopt.c
diff --git a/tests/Makefile b/tests/Makefile
index 88f7105..e82914e
New command-line suboption "[,dhcpvendopt=optstring]" is defined in the
qapi-schema.json. If supplied, the optstring is passed to SLIRP initialization.
Signed-off-by: Fedor Lyakhov
---
net/slirp.c | 9 +
qapi-schema.json | 3 +++
slirp/libslirp.h | 3 ++-
slirp/slirp.c| 2 +-
4
Signed-off-by: Fedor Lyakhov
---
qemu-options.hx | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 6457034..8be86e1 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1373,10 +1373,10 @@ DEF("net", HAS_ARG, QEMU_OPTIO
On Fri, Apr 25, 2014 at 09:48:33AM -0400, Luiz Capitulino wrote:
> On Sun, 13 Apr 2014 16:25:04 +0100
> Hani Benhabiles wrote:
>
> > This patch series adds a new callback to mon_cmd_t which will make adding
> > completion support for more commands cleaner.
> >
> > It moves some existing commands
Am 25.04.2014 12:44, schrieb Markus Armbruster:
> I got a private branch getting rid of it entirely. This is the fourth
> part, covering devices, except for two places I need to cover together
> with QAPI, in a future series.
>
> Could this one go through Andreas's tree?
>
> Markus Armbruster (4
On Fri, Apr 25, 2014 at 05:51:33PM +0200, Andreas Färber wrote:
> Am 25.04.2014 17:40, schrieb Luiz Capitulino:
> > On Tue, 22 Apr 2014 22:44:03 +0100
> > Hani Benhabiles wrote:
> >
> >> Signed-off-by: Hani Benhabiles
> >> ---
> >> qmp.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions
On 24/04/2014 12:37, Gerd Hoffmann wrote:
> Nasty 0xe0 logic is gone. We map through QKeyCode now, giving us a
> nice, readable mapping table.
>
> Quick smoke test in OpenFirmware looks ok. Careful check from arch
> maintainers would be very nice, especially on the capslock and numlock
> logic.
Hi,
> On Do, 2014-04-24 at 20:06 +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer
> size
> > is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the
> very
> > beginning.
>
> Hmm, seems there
Hi Pradeep,
On Thu, Apr 24, 2014 at 11:16 PM, Pradeep Kiruvale
wrote:
> Hi Stefan,
>
> Thanks I will follow your suggestion.
>
> Regards,
> Pradeep
>
>
> On 24 April 2014 14:10, Stefan Hajnoczi wrote:
>>
>> On Wed, Apr 09, 2014 at 07:28:15PM +0200, Pradeep Kiruvale wrote:
>> > I am new to qemu
On 04/25/2014 05:01 PM, Tomoki Sekiyama wrote:
> When an array of mount point paths is specified as 'mountpoints' argument
> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file
> systems mounted on specified paths in Linux.
> This would be useful when the host wants to creat
On 04/25/2014 04:10 PM, Fedor Lyakhov wrote:
> New command-line suboption "[,dhcpvendopt=optstring]" is defined in the
> qapi-schema.json. If supplied, the optstring is passed to SLIRP
> initialization.
>
> Signed-off-by: Fedor Lyakhov
> ---
> net/slirp.c | 9 +
> qapi-schema.json
On Thu, Apr 24, 2014 at 08:06:19PM +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer size
> is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the very
> beginning.
>
> When I started a redhat5.6
Andreas Färber writes:
> Am 25.04.2014 14:55, schrieb Markus Armbruster:
>> Andreas Färber writes:
>>> Am 25.04.2014 12:44, schrieb Markus Armbruster:
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
Hi,
> On Thu, Apr 24, 2014 at 08:06:19PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer
> size
> > is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the
> very
> > beginning.
> >
> > When
201 - 267 of 267 matches
Mail list logo
