"Michael S. Tsirkin" writes:
> On Thu, Apr 24, 2014 at 09:21:00AM +0100, Dr. David Alan Gilbert wrote:
>> * Markus Armbruster (arm...@redhat.com) wrote:
>> > "Dr. David Alan Gilbert" writes:
>> >
>> > > * Eric Blake (ebl...@redhat.com) wrote:
>> > >> On 04/23/2014 10:37 AM, Dr. David Alan Gilbe
Hi,
I'm looking at xen hvm guest direct kernel boot and interested to do
it. I found there were some discussions about it and an early work
around by Daniel (based on xen qemu-dm).
[1]http://old-list-archives.xenproject.org/xen-devel/2011-08/msg00414.html
[2]http://old-list-archives.xenproject.or
On 24 April 2014 21:11, Peter Maydell wrote:
>
> This patchset updates our copy of libvixl to the upstream
> 1.3 release. I don't think there's anything particularly
> earthshattering in 1.3 compared to what we had before.
>
> I had a bit of a dilemma with this patchset:
> * separate out the "pri
On 2014-04-24 08:19, Jan Kiszka wrote:
> On 2014-04-23 11:25, Stefan Hajnoczi wrote:
>> Dear QEMU, Libvirt, and KVM communities,
>> We are participating in Google Summer of Code 2014
>> (http://google-melange.com/) and Outreach Program for Women
>> (http://opw.gnome.org/). Both programs fund candi
bdrv_get_info could fail. Add check before using the returned value.
Signed-off-by: Fam Zheng
---
block/mirror.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 0ef41f9..fafcc93 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -339
Stefan Hajnoczi writes:
> qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to
> the caller. Therefore all code paths in qmp_getfd() should either
> register the file descriptor somewhere or close it.
>
> Signed-off-by: Stefan Hajnoczi
Reviewed-by: Markus Armbruster
I'm now looking at the conditional fprintf's. I'll need a bit of help later
in sending the patches :D.
Marc
2014-04-25 9:24 GMT+02:00 Jan Kiszka :
> On 2014-04-24 08:19, Jan Kiszka wrote:
> > On 2014-04-23 11:25, Stefan Hajnoczi wrote:
> >> Dear QEMU, Libvirt, and KVM communities,
> >> We are p
Not a serious issue, but it's helpful if we can fix it.
V2: split change of scripts/qapi-visit.py to a split patch,
eat space by using a special char as Markus suggested
Amos Kong (2):
qapi: fix coding style in parameters list
qapi: add a special string in c_type()'s result to each redund
Currently we always add a space after c_type in mcgen(), there is
some redundant space in generated code. The space isn't needed for
points by the coding style.
char * value;
^
qapi_free_NameInfo(NameInfo * obj)
^
This patch added a special string 'EATSP
The space before point is redundant.
Signed-off-by: Amos Kong
---
scripts/qapi-visit.py | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index 45ce3a9..8ffed3d 100644
--- a/scripts/qapi-visit.py
+++ b/scripts
Previouly, convert from ISO to VMDK with subformat=streamOptimized fails:
$ ./qemu-img convert -O vmdk -o subformat=streamOptimized foo.iso bar.vmdk
VMDK: can't write to allocated cluster for streamOptimized
qemu-img: error while writing sector 64: Input/output error
Because current c
This will return cluster_size and is_compressed to caller, if all the
extents has the same value (or there's only one extent). Otherwise
return -ENOTSUP.
cluster_size is only reported for sparse formats.
Signed-off-by: Fam Zheng
---
block/vmdk.c | 21 +
tests/q
Add a wrapper function to support "compressed" path in qemu-img convert.
Only support streamOptimized subformat case for now (num_extents == 1
and extent compression is true).
Signed-off-by: Fam Zheng
---
block/vmdk.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/block/vmdk
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/059 | 7 +++
tests/qemu-iotests/059.out | 7 +++
2 files changed, 14 insertions(+)
diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
index ca5aa16..26a2fd3 100755
--- a/tests/qemu-iotests/059
+++ b/tests/qemu-iotests/059
@@ -
There is a set of test, that checks QEMU CPU for similar behavior with real
hardware (http://roberto.greyhats.it/projects/pills.html). Test reg/pill2579.c
can detect, that program is execute in emulated environment. It is related with
behavior of rcl instruction. If the number of shifted bits mo
On Fri, 04/25 15:56, Amos Kong wrote:
> The space before point is redundant.
s/point/pointer
Fam
>
> Signed-off-by: Amos Kong
> ---
> scripts/qapi-visit.py | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/scripts/qapi-visit.py b/scripts/qapi-vis
Am 25.04.2014 um 08:29 hat Markus Armbruster geschrieben:
> "Michael S. Tsirkin" writes:
>
> > On Thu, Apr 24, 2014 at 12:43:56PM +0200, Kevin Wolf wrote:
> >> Am 24.04.2014 um 09:55 hat Michael S. Tsirkin geschrieben:
> >> > On Thu, Apr 24, 2014 at 09:15:25AM +0200, Markus Armbruster wrote:
> >>
If target block driver forces compression, qemu-img convert needs to
write by cluster size as well as "-c" option.
Particularly, this applies for converting to VMDK streamOptimized
format.
Signed-off-by: Fam Zheng
---
include/block/block.h | 4
qemu-img.c| 1 +
2 files changed,
Mike Day writes:
> On Thu, Apr 24, 2014 at 3:31 AM, Markus Armbruster wrote:
>>> I believe someone on the list mentioned they are seeing a couple
>>> problems entering and exiting the Monitor. I'd like to look at this more
>>> closely, starting with my most pending issue: losing the terminal ech
Hi,
> Apparently requesting the vte terminal size isn't sufficient, we need
> to force a size_request so text doesn't line wrap. We use slightly
> different APIs for gtk3, since on 3.10 the size_request trick doesn't
> seem to work.
Something is fishy there indeed. I somehow feel like we are d
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
> Drop use of a pty and just use vte infrastructure for reading and
> writing.
Makes perfect sense. pty is poinless in our vte usage szenario.
cheers,
Gerd
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
may be null, because errors go undetected when it is. It's fragile
when proving ERRP non-null involves a non-local argument. Else, it's
unnecessarily opaque (see
Using error_is_set(errp) to check whether a function call failed is
fragile: it breaks when errp is null. Check perfectly suitable return
values instead when possible. As far as I can tell, errp can't be
null there, but this is more robust and more obviously correct
Signed-off-by: Markus Armbrus
I got a private branch getting rid of it entirely. This is the third
part, covering character backends.
Markus Armbruster (3):
char: Use return values instead of error_is_set(errp)
char: Clean up fragile use of error_is_set()
char: Explain qmp_chardev_add()'s unusual error handling
qemu-c
Character backend open hasn't been fully converted to the Error API.
Some opens fail without setting an error. qmp_chardev_add() needs to
detect when that happens, and set a generic error. Explain that in a
comment, and inline error_is_set() for clarity.
Signed-off-by: Markus Armbruster
---
qe
From: ChenLiang
version_id is checked twice in the ram_load.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c | 68 ++---
1 file changed, 33 insertions(+), 35 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 60c9
Hi Eric,
Thank you for reviewing it.
On 23/04/2014 17:00, Eric Auger wrote:
> Hi Alvise,
>
> Thank you for the patch. Indeed I am very interested in further
> discussing the vfio-platform integration with you.
>
> On 04/17/2014 07:29 PM, Alvise Rigo wrote:
>> The user can specify the location o
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
> The accelerator was ctrl+shift+'+', but '+' required a shift key already,
> so the accelerator didn't trigger. Switch it to ctrl+shift+'='
Hmm? For me the accelerator is ctrl+alt.
Also which keys need shift and which don't depends on the k
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
> When keyboard focus is grabbed, current qemu wants to pass every
> keypress to the VM, unless the user is pressing a UI accelerator.
>
> That's exactly how things work without any of the fancy handling. Drop
> the special handling, which see
On 24/04/2014 02:25, Peter Crosthwaite wrote:
> On Fri, Apr 18, 2014 at 3:29 AM, Alvise Rigo
> wrote:
>> The flag is mandatory for the ARM SMMU, add it.
>> When VFIO will be able to tell about the IOMMU being used, we will add
>> it only if necessary.
>>
>> Signed-off-by: Alvise Rigo
>> ---
>> h
On Do, 2014-04-24 at 13:35 -0400, Cole Robinson wrote:
> A collection of fixes related to the gtk UI. See individual patches for
> details.
cherry-picked #1 + #3 for now.
FYI: current gtk patch queue looks like this:
https://www.kraxel.org/cgit/qemu/log/?h=rebase/ui-gtk-next
cheers,
Gerd
Il 24/04/2014 02:16, Peter Crosthwaite ha scritto:
> On Thu, Apr 24, 2014 at 1:21 AM, Eric Auger wrote:
>> On 04/17/2014 07:29 PM, Alvise Rigo wrote:
>>> These patches were born after trying the current work on device
>>> passthrough (see thread "[Qemu-devel] [RFC v2 0/6] KVM platform device
>>> p
Hi,
> -nographic without -nodefaults sets up a default serial line and a
> monitor, multiplexed onto stdio. Another way to get that is -serial
> mon:stdio.
>
> Maybe the multiplexing has regressed. I'm not sure, as I don't use it
> myself. Gerd (cc'ed) might know more.
Works for me. Serial
On Fri, Apr 25, 2014 at 5:55 PM, Marc Marí wrote:
> I'm now looking at the conditional fprintf's. I'll need a bit of help later
> in sending the patches :D.
>
CC me in on the results.
Regards,
Peter
> Marc
>
>
> 2014-04-25 9:24 GMT+02:00 Jan Kiszka :
>
>> On 2014-04-24 08:19, Jan Kiszka wrote:
On 23/04/2014 17:21, Eric Auger wrote:
> On 04/17/2014 07:29 PM, Alvise Rigo wrote:
>> These patches were born after trying the current work on device
>> passthrough (see thread "[Qemu-devel] [RFC v2 0/6] KVM platform device
>> passthrough") with a DMA330 and FastModels. This work want to be the
>
On Fri, Apr 25, 2014 at 12:02 AM, Andreas Färber wrote:
> Am 09.04.2014 01:45, schrieb Peter Crosthwaite:
>> Implement named GPIOs on the Device layer. Listifies the existing GPIOs
>> stuff using string keys. Legacy un-named GPIOs are preserved by using
>> a NULL name string - they are just a sing
On Thu, Apr 24, 2014 at 08:19:19AM +0200, Jan Kiszka wrote:
> On 2014-04-23 11:25, Stefan Hajnoczi wrote:
> > Dear QEMU, Libvirt, and KVM communities,
> > We are participating in Google Summer of Code 2014
> > (http://google-melange.com/) and Outreach Program for Women
> > (http://opw.gnome.org/).
On Thu, Apr 24, 2014 at 06:54:40PM +0100, Peter Maydell wrote:
> This patchset wires up our new Cortex-A57 emulation into
> the "virt" machine model. Rather than the somewhat hacky
> approach in the previous system emulation patchsets, I've
> decided that our best approach is to have the board mode
Hi,
> > +trace_usb_mtp_op_get_device_info(s->dev.addr);
> > +
> > +usb_mtp_add_u16(d, 0x0100);
>
> Sect. 5.1.1.1 says:
>
> "This identifies the PTP version this device can support in
> hundredths. For MTP devices implemented under this specification,
> this shall contain t
Signed-off-by: Markus Armbruster
---
hw/core/qdev-properties-system.c | 10 +-
hw/dma/xilinx_axidma.c | 16
hw/net/xilinx_axienet.c | 16
3 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/hw/core/qdev-properties-system.c
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
may be null, because errors go undetected when it is. It's fragile
when proving ERRP non-null involves a non-local argument. Else, it's
unnecessarily opaque (see
I got a private branch getting rid of it entirely. This is the fourth
part, covering devices, except for two places I need to cover together
with QAPI, in a future series.
Could this one go through Andreas's tree?
Markus Armbruster (4):
hw: Consistently name Error * objects err, and not errp
Signed-off-by: Markus Armbruster
---
hw/core/qdev.c | 20 ++--
hw/intc/i8259.c | 4 ++--
hw/timer/i8254.c | 4 ++--
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 60f9df1..2fd5100 100644
--- a/hw/core/qdev.c
+++ b/hw/co
Using error_is_set(ERRP) to find out whether a function failed is
either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
may be null, because errors go undetected when it is. It's fragile
when proving ERRP non-null involves a non-local argument. Else, it's
unnecessarily opaque (see
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 775dc8d..45f9562 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -669,6 +669,7 @@ static MTPData *usb_mtp_get_object(MTPState *s, MTPControl
*
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 17df447..063a426 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -416,7 +416,7 @@ static void usb_mtp_add_u32(MTPData *data,
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 82d5b64..536a23d 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1049,7 +1049,7 @@ static int usb_mtp_initfn(USBDevice *dev)
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 8
trace-events | 3 +++
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 8b44032..17df447 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -294,7 +294,7 @@ static MTPOb
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 536a23d..6bd6a82 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -1014,8 +1014,7 @@ static void usb_mtp_handle_data(USBDevice *
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 063a426..dff2618 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -533,7 +533,7 @@ static MTPData *usb_mtp_get_device_info(MTPStat
Hi,
Here is a bunch of incremental fixes for the just merged
usb mtp device, coming from patch review by Peter and Stefan.
cheers,
Gerd
Gerd Hoffmann (9):
usb: mtp: replace debug printfs with trace points
usb: mtp: fix usb_mtp_add_u64
usb: mtp: fix version (is decimal not bcd)
usb: m
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 6bd6a82..8e1a1b7 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -50,6 +50,7 @@ enum mtp_code {
RES_INVALID_TRANSACTION_ID
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 45f9562..82d5b64 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -998,6 +998,9 @@ static void usb_mtp_handle_data(USBDevice *dev, USBPacket
*
Signed-off-by: Gerd Hoffmann
---
hw/usb/dev-mtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index dff2618..775dc8d 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -548,7 +548,7 @@ static MTPData *usb_mtp_get_device_info(MTPStat
On Thursday 24 April 2014 17:01:47 Gerd Hoffmann wrote:
> PS: Funny thing that the reviews start coming in when I send pull
> requests. The patches have been on the list a few weeks back
> already (during 2.0 freeze, thats why the long delay between
> [patch] and [pull]). No comments.
Am 25.04.2014 12:44, schrieb Markus Armbruster:
> Signed-off-by: Markus Armbruster
Thanks a lot,
Reviewed-by: Andreas Färber
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
Am 25.04.2014 12:44, schrieb Markus Armbruster:
> Signed-off-by: Markus Armbruster
> ---
> hw/core/qdev.c | 20 ++--
> hw/intc/i8259.c | 4 ++--
> hw/timer/i8254.c | 4 ++--
> 3 files changed, 14 insertions(+), 14 deletions(-)
Reviewed-by: Andreas Färber
Andreas
--
SUSE
On Friday 25 April 2014 12:48:11 Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> hw/usb/dev-mtp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 45f9562..82d5b64 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev-mtp.c
> @@ -99
On Friday 25 April 2014 12:48:14 Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann
> ---
> hw/usb/dev-mtp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
> index 6bd6a82..8e1a1b7 100644
> --- a/hw/usb/dev-mtp.c
> +++ b/hw/usb/dev
On 25 April 2014 11:42, Christoffer Dall wrote:
> So we're adding an incompletely modelled A57 to the virt board, and
> adding a "board mounted" GICv2. Doesn't sound like something that could
> ever exist in real life, but I agree that the way we are tying things
> together, semantically letting
Am 25.04.2014 12:44, schrieb Markus Armbruster:
> Using error_is_set(ERRP) to find out whether a function failed is
> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
> may be null, because errors go undetected when it is. It's fragile
> when proving ERRP non-null involves a n
On Friday 25 April 2014 12:48:05 Gerd Hoffmann wrote:
> Hi,
>
> Here is a bunch of incremental fixes for the just merged
> usb mtp device, coming from patch review by Peter and Stefan.
>
> cheers,
> Gerd
>
> Gerd Hoffmann (9):
> usb: mtp: replace debug printfs with trace points
> usb: mt
On Do, 2014-04-24 at 20:06 +0800, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> According to the PS/2 Mouse/Keyboard Protocol, the keyboard outupt buffer size
> is 16 bytes. And the PS2_QUEUE_SIZE 256 was introduced in Qemu from the very
> beginning.
Hmm, seems there is no maintainer for ps
On Thu, Apr 10, 2014 at 04:47:35PM -0400, Jeff Cody wrote:
> Changes from v2:
>
> Updated Reviewed-by for Fam and Benoit (Benoit's from the v1 patch, I forgot
> to
> add those to v2)
>
> Patch 1: * updated commit message (Thanks Fam)
> * Addded '-machine accel=qtest' to qemu lau
On Tue, Apr 08, 2014 at 06:52:39PM -0700, Peter Crosthwaite wrote:
> From: Nathan Rossi
>
> Clear the BMCR Reset when writing to registers.
>
> Signed-off-by: Nathan Rossi
> [ PC:
> * Trivial style fixes to commit message
> ]
> Signed-off-by: Peter Crosthwaite
> ---
>
> hw/net/xilinx_axiene
On 25 April 2014 12:25, Andreas Färber wrote:
> I do wonder, and maybe Peter can comment as native speaker, whether it
> should be "uses" (plural) or "usage" in both subjects?
In this subject I would consider all of "use", "uses" and
"usage" as acceptable variations.
thanks
-- PMM
Am 25.04.2014 08:38, schrieb Markus Armbruster:
> Andreas Färber writes:
>
>> Am 24.04.2014 08:19, schrieb Jan Kiszka:
>>> On 2014-04-23 11:25, Stefan Hajnoczi wrote:
Dear QEMU, Libvirt, and KVM communities, We are participating in
Google Summer of Code 2014 (http://google-melange.com/)
in the git repository at:
https://github.com/cohuck/qemu.git tags/s390x-20140425
for you to fetch changes up to 44b0c0bbb50818e995702cf76d8e07dd36f479bf:
s390x/kvm: sync gbea and pp register (2014-04-25 12:59:57 +0200)
Some s39
From: Christian Borntraeger
Some ONE_REGS on s390 are not protected by a capability. Older kernels
might not provide those and return an error. Fortunately these registers
are only critical for the migration path. There is no need to error out
on reset and normal runtime. Furthermore, these kerne
From: Christian Borntraeger
We also need to sync guest breaking event address and program parameter
register for migration support.
Signed-off-by: Christian Borntraeger
Reviewed-by: Cornelia Huck
Signed-off-by: Cornelia Huck
---
target-s390x/cpu.h |3 +++
target-s390x/kvm.c |4
linux-headers update against v3.15-rc2 (a798c10f)
Signed-off-by: Cornelia Huck
---
linux-headers/asm-s390/kvm.h | 24
linux-headers/linux/kvm.h| 17 +
linux-headers/linux/vfio.h |6 ++
3 files changed, 47 insertions(+)
diff --git a/linu
From: David Hildenbrand
This patch creates empty function stubs (used by the gdbserver) in preparation
for the hw debugging support by kvm on s390, which will enable the
__KVM_HAVE_GUEST_DEBUG define in the linux headers and require these methods on
the qemu side.
Signed-off-by: David Hildenbran
Am 24.04.2014 19:35, schrieb Cole Robinson:
> Try kicking off a rhel5 text install over serial, the text menu navigation
> is all messed up, and some of the kernel boot messages are randomly
> corrupted.
>
> Drop use of a pty and just use vte infrastructure for reading and writing.
> This fixes th
Hi,
> The bogus data packet is sent with usb_packet_copy, shouldn't you return
> USB_RET_NAK for now?
I don't think so. The transfer must be completed, even if we don't send
valid data, because the guest expects a certain number of data bytes
before the result packet with the status code. If
Hi Alex,
On Thu, 24 Apr 2014 18:36:18 +0200
Alexander Graf wrote:
>
> On 24.04.14 17:34, Jens Freimann wrote:
> > From: Thomas Huth
> >
> > With the EDAT-1 facility, the MMU translation can stop at the
> > segment table already, pointing to a 1 MB block.
...
> > diff --git a/target-s390x/help
On Apr 16, 2014, at 17:22 PM, Andreas Färber wrote:
> Am 02.09.2013 13:31, schrieb Michael S. Tsirkin:
>> On Mon, Jul 29, 2013 at 02:27:01AM +0200, Andreas Färber wrote:
>>> Use it conditional on msix_present() and drop msix_{save,load}() calls
>>> following pci_device_{save,load}().
>>>
>>> Th
Signed-off-by: Huw Davies
---
linux-user/syscall.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index cf4372e..e9ae9c5 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -1269,6 +1269,17 @@ static inline abi_long host_to
This set has been on the mailing list unreviewed for more than a week.
It implements copying of the SCM_CREDENTIALS msg payload.
Patch 1 changes an if-else block to a more expandable switch block.
Patch 2 is the actual implementation.
The following changes since commit 0e96643c98eb22a5f2e11ac500
This makes adding more message types cleaner.
Signed-off-by: Huw Davies
---
linux-user/syscall.c | 51 +--
1 file changed, 33 insertions(+), 18 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9864813..cf4372e 100644
---
Am 25.04.2014 11:22, schrieb Peter Crosthwaite:
> On Fri, Apr 25, 2014 at 5:55 PM, Marc Marí
> wrote:
>> I'm now looking at the conditional fprintf's. I'll need a bit of help later
>> in sending the patches :D.
For starters, please use plain text format mails and don't top-post. :)
> CC me in o
On 25.04.14 14:02, Cornelia Huck wrote:
From: Christian Borntraeger
Some ONE_REGS on s390 are not protected by a capability. Older kernels
might not provide those and return an error. Fortunately these registers
are only critical for the migration path. There is no need to error out
on reset a
> > -qemu_chr_be_write(vc->chr, buffer, len);
> > +VirtualConsole *vc = user_data;
>
> Gerd, can we retain the white line here please? :)
>
> Andreas
>
> > +qemu_chr_be_write(vc->chr, (uint8_t *)text, (unsigned int)size);
Fixed in my local copy.
cheers,
Gerd
On 25.04.14 14:24, Christian Borntraeger wrote:
On 25/04/14 14:04, Alexander Graf wrote:
On 25.04.14 14:02, Cornelia Huck wrote:
From: Christian Borntraeger
Some ONE_REGS on s390 are not protected by a capability. Older kernels
might not provide those and return an error. Fortunately these r
On Fri, Apr 11, 2014 at 01:54:06AM +0800, Chunyan Liu wrote:
> To simplify later using of qemu_opts_del, accept NULL input.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Chunyan Liu
> ---
> util/qemu-option.c | 4
> 1 file changed, 4 insertions(+)
Reviewed-by: Stefan Hajnoczi
On 23 April 2014 11:04, Kevin Wolf wrote:
> The following changes since commit 2d03b49c3f225994c4b0b46146437d8c887d6774:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20140417-1' into staging (2014-04-17
> 21:37:26 +0100)
>
> are available in the git repository at:
On 25/04/14 14:04, Alexander Graf wrote:
>
> On 25.04.14 14:02, Cornelia Huck wrote:
>> From: Christian Borntraeger
>>
>> Some ONE_REGS on s390 are not protected by a capability. Older kernels
>> might not provide those and return an error. Fortunately these registers
>> are only critical for the
On Fri, Apr 25, 2014 at 02:50:29PM +0800, Fam Zheng wrote:
> bdrv_get_info could fail. Add check before using the returned value.
>
> Signed-off-by: Fam Zheng
> ---
> block/mirror.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/mirror.c b/block/mirror.c
> in
On 25.04.14 14:15, Thomas Huth wrote:
Hi Alex,
On Thu, 24 Apr 2014 18:36:18 +0200
Alexander Graf wrote:
On 24.04.14 17:34, Jens Freimann wrote:
From: Thomas Huth
With the EDAT-1 facility, the MMU translation can stop at the
segment table already, pointing to a 1 MB block.
...
diff --gi
On 04/25/2014 01:56 AM, Amos Kong wrote:
> The space before point is redundant.
Would sound better as:
A space after * when declaring a pointer type is redundant.
>
> Signed-off-by: Amos Kong
> ---
> scripts/qapi-visit.py | 20 ++--
> 1 file changed, 10 insertions(+), 10 delet
Am 25.04.2014 14:19, schrieb Huw Davies:
> This set has been on the mailing list unreviewed for more than a week.
>
> It implements copying of the SCM_CREDENTIALS msg payload.
>
> Patch 1 changes an if-else block to a more expandable switch block.
> Patch 2 is the actual implementation.
a) Patch
On 04/25/2014 01:56 AM, Amos Kong wrote:
> Currently we always add a space after c_type in mcgen(), there is
> some redundant space in generated code. The space isn't needed for
> points by the coding style.
s/points/pointers/
>
> char * value;
> ^
> qapi_free_NameInfo(NameInfo * obj
On Fri, Apr 11, 2014 at 01:54:26AM +0800, Chunyan Liu wrote:
> Now that all backend drivers are using QemuOpts, remove all
> QEMUOptionParameter related codes.
>
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> block.c | 86 ++
> block/cow.c
On Wed, Apr 16, 2014 at 02:46:52AM +, zhuxiaodong wrote:
> I don't doubt about the algorithm of level interrupts.
> The problem may come from the level value tested by GIC_TEST_LEVEL(irq, cm).
> It is set in gic_set_irq_generic():
> > 115 static void gic_set_irq_generic(GICState *s, int irq, i
They don't advertise mixer support, but still allow the guest change
mixer settings. Add a check to avoid it.
Signed-off-by: Gerd Hoffmann
---
hw/audio/hda-codec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index a67ca91..48c6ead 100644
--
Amos Kong writes:
> Currently we always add a space after c_type in mcgen(), there is
> some redundant space in generated code. The space isn't needed for
> points by the coding style.
You mean pointers.
>
> char * value;
> ^
> qapi_free_NameInfo(NameInfo * obj)
>
On Fri, Apr 25, 2014 at 12:24:29PM +0100, Peter Maydell wrote:
> On 25 April 2014 11:42, Christoffer Dall wrote:
> > So we're adding an incompletely modelled A57 to the virt board, and
> > adding a "board mounted" GICv2. Doesn't sound like something that could
> > ever exist in real life, but I a
Andreas Färber writes:
> Am 25.04.2014 12:44, schrieb Markus Armbruster:
>> Using error_is_set(ERRP) to find out whether a function failed is
>> either wrong, fragile, or unnecessarily opaque. It's wrong when ERRP
>> may be null, because errors go undetected when it is. It's fragile
>> when pro
On Fri, 25 Apr 2014 14:36:11 +0200
Alexander Graf wrote:
>
> On 25.04.14 14:15, Thomas Huth wrote:
> >
> > On Thu, 24 Apr 2014 18:36:18 +0200
> > Alexander Graf wrote:
[...]
> >> I also think we should rather align the
> >> code with the PTE handling somehow. This way it gets pretty confusing to
On 25.04.14 14:56, Thomas Huth wrote:
On Fri, 25 Apr 2014 14:36:11 +0200
Alexander Graf wrote:
On 25.04.14 14:15, Thomas Huth wrote:
On Thu, 24 Apr 2014 18:36:18 +0200
Alexander Graf wrote:
[...]
I also think we should rather align the
code with the PTE handling somehow. This way it gets p
On Fri, Apr 11, 2014 at 01:54:04AM +0800, Chunyan Liu wrote:
> Add two temp conversion functions between QEMUOptionParameter to QemuOpts,
> so that next patch can use it. It will simplify later patch for easier
> review. And will be finally removed after all backend drivers switch to
> QemuOpts.
>
1 - 100 of 267 matches
Mail list logo
