Re: [Qemu-devel] [PATCH 0/3] target-arm: support setend instruction

2014-04-22 Thread Peter Maydell
On 22 April 2014 03:42, Paolo Bonzini wrote: > Il 21/04/2014 18:08, Peter Maydell ha scritto: >> If we take an exception while the E bit is set we'll now incorrectly >> start executing the exception handler in big-endian mode. >> Minimally, we need to force "always little endian". Ideally, we >> w

Re: [Qemu-devel] [PATCH] qemu-img: Exit with code 0 if there is no error

2014-04-22 Thread Markus Armbruster
Michael Tokarev writes: > 18.04.2014 18:29, Eric Blake wrote: >> On 04/18/2014 12:23 AM, Fam Zheng wrote: >>> Signed-off-by: Fam Zheng >>> --- >>> qemu-img.c | 68 >>> +++--- >>> 1 file changed, 34 insertions(+), 34 deletions(-) >>> >> >>

Re: [Qemu-devel] [PATCH RFC] ps2: set the keybord output buffer size as the same as kernel

2014-04-22 Thread Gerd Hoffmann
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c > index 3412079..a754fef 100644 > --- a/hw/input/ps2.c > +++ b/hw/input/ps2.c > @@ -71,7 +71,7 @@ > #define MOUSE_STATUS_ENABLED0x20 > #define MOUSE_STATUS_SCALE210x10 > > -#define PS2_QUEUE_SIZE 256 > +#define PS2_QUEUE_SIZE 16 /* Key

Re: [Qemu-devel] [PATCH] qapi: generate space in c_type() to fix coding style

2014-04-22 Thread Markus Armbruster
Paolo Bonzini writes: > Il 18/04/2014 23:56, Amos Kong ha scritto: >> Currently we always add a space after c_type in mcgen(), there is >> some redundant space in generated code. The space isn't needed for >> points by the coding style. >> >> char * value; >> ^ >> qapi_free_NameInfo(N

Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h

2014-04-22 Thread Markus Armbruster
"john.liuli" writes: > libfdt_env.h is missing in some stable installs (<1.3.0-3), > some released linux distributions(e.g. Ubuntu 12.04) depending > on it still complain missing libfdt even if already installed. > So give more detailed hint for such OS users. > > Signed-off-by: Liu Li > --- >

Re: [Qemu-devel] [PATCH v2 1/2] HMP: fix doc of dump-guest-memory

2014-04-22 Thread Markus Armbruster
Qiao Nuohan writes: > Signed-off-by: Qiao Nuohan > --- > hmp-commands.hx | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index f3fc514..c242770 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -999,25 +

Re: [Qemu-devel] [PATCH v2 0/2] HMP: support specifying dump format for dump-guest-memory

2014-04-22 Thread Markus Armbruster
Qiao Nuohan writes: > The last version is here: > > http://lists.nongnu.org/archive/html/qemu-devel/2014-04/msg00018.html > > ChangLog: > Changes from v7 to v8: > 1. add a patch to fix doc of dump-guest-memory > > Qiao Nuohan (2): > HMP: fix doc of dump-guest-memory > HMP: support specifying

Re: [Qemu-devel] [PATCH v2 2/2] HMP: support specifying dump format for dump-guest-memory

2014-04-22 Thread Christian Borntraeger
On 17/04/14 10:15, Qiao Nuohan wrote: > Dumping guest memory is available to specify the dump format now. This patch > adds options '-z|-l|-s' to HMP command dump-guest-memory to specify dumping in > kdump-compression format, with zlib/lzo/snappy compression. And without these > options ELF format

Re: [Qemu-devel] [PATCH v2 4/4] nvram: fw_cfg: Fix -boot options in nvram/fw_cfg

2014-04-22 Thread Markus Armbruster
Peter Crosthwaite writes: > When accessing boot options, we query whatever options come first in > the boot opts list. This is wrong. You could copy a bit more text from commit 36ad0e9 to explain how exactly it is wrong. First three paragraphs, perhaps. > Use qemu_get_boot_opts() to fix these

Re: [Qemu-devel] Controlling SDL2 output with Ctrl+Alt+*

2014-04-22 Thread Gerd Hoffmann
On Mo, 2014-04-21 at 18:14 -0400, Cole Robinson wrote: > On 04/18/2014 02:28 PM, Michael Tokarev wrote: > > SDL2 display apparently does not work with standard keyboard > > shortcuts documented in the qemu manpage. In particular, > > Ctrl+Alt+(123) does not switch between monitor, serial and > > g

Re: [Qemu-devel] [PATCH RFC] ps2: set the keybord output buffer size as the same as kernel

2014-04-22 Thread Gonglei (Arei)
> > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > > index 3412079..a754fef 100644 > > --- a/hw/input/ps2.c > > +++ b/hw/input/ps2.c > > @@ -71,7 +71,7 @@ > > #define MOUSE_STATUS_ENABLED0x20 > > #define MOUSE_STATUS_SCALE210x10 > > > > -#define PS2_QUEUE_SIZE 256 > > +#define PS2_QUEU

Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h

2014-04-22 Thread Peter Maydell
On 21 April 2014 07:18, john.liuli wrote: > libfdt_env.h is missing in some stable installs (<1.3.0-3), > some released linux distributions(e.g. Ubuntu 12.04) depending > on it still complain missing libfdt even if already installed. > So give more detailed hint for such OS users. > > Signed-off-b

Re: [Qemu-devel] [PATCH 0/4] Fix memory leaks in QEMU

2014-04-22 Thread Markus Armbruster
Kirill Batuzov writes: > I tried running QEMU under Valgrind's Memcheck tool and managed to find > some memory leaks. I only checked "definitely lost" reports. I ignored > reports related to SDL/GTK because it is hard to tell if memory leak occurred > in QEMU or in the library. > > All found er

Re: [Qemu-devel] [Spice-devel] Automatic spice port selection

2014-04-22 Thread Gerd Hoffmann
Hi, > > Can someone add spice automatic port selection on qemu similar to vnc ones > > please? Not so easy as this is handled by spice-server not qemu, so this requires some new interfaces to communicate the listening address to qemu. Otherwise you can't see the port selected in 'info spice',

Re: [Qemu-devel] Controlling SDL2 output with Ctrl+Alt+*

2014-04-22 Thread Kevin Wolf
Am 22.04.2014 um 10:14 hat Gerd Hoffmann geschrieben: > On Mo, 2014-04-21 at 18:14 -0400, Cole Robinson wrote: > > On 04/18/2014 02:28 PM, Michael Tokarev wrote: > > > SDL2 display apparently does not work with standard keyboard > > > shortcuts documented in the qemu manpage. In particular, > > >

Re: [Qemu-devel] [PATCH RFC] ps2: set the keybord output buffer size as the same as kernel

2014-04-22 Thread Gerd Hoffmann
On Di, 2014-04-22 at 08:16 +, Gonglei (Arei) wrote: > > > > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > > > index 3412079..a754fef 100644 > > > --- a/hw/input/ps2.c > > > +++ b/hw/input/ps2.c > > > @@ -71,7 +71,7 @@ > > > #define MOUSE_STATUS_ENABLED0x20 > > > #define MOUSE_STATUS_S

Re: [Qemu-devel] Controlling SDL2 output with Ctrl+Alt+*

2014-04-22 Thread Peter Maydell
On 22 April 2014 09:44, Kevin Wolf wrote: > Am 22.04.2014 um 10:14 hat Gerd Hoffmann geschrieben: >> On (a): I personally almost never use the qemu terminals. When running >> qemu directly I usually use "-monitor stdio" or "-serial stdio" instead, >> so chardev goes to my normal xterm, which work

[Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Fam Zheng
If guest driver behaves abnormally, emulation code could mark the device as "broken". Once "broken" is set, device emulation will typically wait for a reset command and ignore any other operations, but it could also return error responds. In other words, whether and how does guest know about this

[Qemu-devel] [PATCH 2/3] virtio-blk: Don't exit on invalid VQ data

2014-04-22 Thread Fam Zheng
Set vdev's broken flag, instead of exit, if the VQ has invalid data. Check VirtIODevice.broken in VQ output handler, and don't pop any more request if set, until the device is reset. Signed-off-by: Fam Zheng --- hw/block/virtio-blk.c | 20 +++- 1 file changed, 15 insertions(+),

[Qemu-devel] [PATCH 0/3] virtio: Eliminate "exit(1)" upon invalid request in virtio-blk and virtio-scsi

2014-04-22 Thread Fam Zheng
Today, buggy or malicous guests that submit invalid requests can cause QEMU's exit with an error message, which is not friendly to neither user/admin nor guest. When passing through a virtio device to a nested vm, there is also an D.O.S. vulnerability. This series adds "broken" flag to VirtIODevic

[Qemu-devel] [PATCH 3/3] virtio-scsi: Don't exit on bad request

2014-04-22 Thread Fam Zheng
Set "broken" flag on vdev if there is a bad request, and ignore all further requests. The guest will find this device inresponsive, it's a little better for guest because now it gets a chance to reset the device, instead of disappearing. Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi.c | 40 ++

Re: [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > If there is an error while loading a field, we should stop reading and > not continue with the rest of fields. And we should also set an error > in qemu_file. > > Signed-off-by: Juan Quintela > --- > vmstate.c | 6 ++ > 1 file changed, 6 insert

Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows

2014-04-22 Thread Stanislav Vorobiov
Hi everyone, Any comments on this v3 patch ? On 04/18/2014 08:24 PM, Stanislav Vorobiov wrote: > From: Sangho Park > > g_poll has a problem on Windows when using > timeouts < 10ms, in glib/gpoll.c: > > /* If not, and we have a significant timeout, poll again with > * timeout then. Note that t

Re: [Qemu-devel] [PATCH 1/4] Replace acpi_pcihp_get_bsel with generic object_property_get_int

2014-04-22 Thread Igor Mammedov
On Sun, 20 Apr 2014 11:32:23 +0300 "Michael S. Tsirkin" wrote: > On Fri, Apr 18, 2014 at 06:30:37PM +0200, Andreas Färber wrote: > > Am 18.04.2014 15:41, schrieb Kirill Batuzov: > > > acpi_pcihp_get_bsel implements functionality of object_property_get_int > > > for > > > specific property named

Re: [Qemu-devel] [ceph-users] qemu + rbd block driver with cache=writeback, is live migration safe ?

2014-04-22 Thread Kevin Wolf
Am 19.04.2014 um 00:33 hat Josh Durgin geschrieben: > On 04/18/2014 10:47 AM, Alexandre DERUMIER wrote: > >Thanks Kevin for for the full explain! > > > >>>cache.writeback=on,cache.direct=off,cache.no-flush=off > > > >I didn't known about the cache options split,thanks. > > > > > >>>rbd does, to my

Re: [Qemu-devel] Regression (?) due to c4177479 ('spapr: make sure RMA is in first mode of first memory node')

2014-04-22 Thread Alexey Kardashevskiy
On 04/19/2014 05:58 AM, Benjamin Herrenschmidt wrote: > On Fri, 2014-04-18 at 23:29 +1000, Alexey Kardashevskiy wrote: >> Which would be what in the current QEMU? >> >> If I read the current QEMU code correctly, NUMA nodes and device tree >> nodes >> are the same thing for SPAPR now, see spapr_popu

Re: [Qemu-devel] [PATCH 1/4] Replace acpi_pcihp_get_bsel with generic object_property_get_int

2014-04-22 Thread Michael S. Tsirkin
On Tue, Apr 22, 2014 at 11:04:37AM +0200, Igor Mammedov wrote: > On Sun, 20 Apr 2014 11:32:23 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Apr 18, 2014 at 06:30:37PM +0200, Andreas Färber wrote: > > > Am 18.04.2014 15:41, schrieb Kirill Batuzov: > > > > acpi_pcihp_get_bsel implements functio

Re: [Qemu-devel] Fwd: Local storage-migration plus network disks

2014-04-22 Thread Kevin Wolf
Am 20.04.2014 um 14:33 hat Blair Bethwaite geschrieben: > Hi, just wondering if devs think this behaviour is bug-worthy? > > -- Forwarded message -- > From: Blair Bethwaite > Date: 16 April 2014 16:29 > Subject: Local storage-migration plus network disks > To: qemu-disc...@nongnu.

Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows

2014-04-22 Thread Alex Bligh
On 22 Apr 2014, at 10:03, Stanislav Vorobiov wrote: >> + */ >> +#define g_poll(fds, nfds, timeout) g_poll_fixed(fds, nfds, timeout) >> +gint g_poll_fixed(GPollFD *fds, guint nfds, gint timeout); I can't comment on the Windows specific bits of this patch (though I have commented on what needs fix

Re: [Qemu-devel] [PATCH v2] Add remove_boot_device_path() function for hot-unplug device

2014-04-22 Thread Marcel Apfelbaum
On Wed, 2014-04-16 at 22:20 +0800, Jun Li wrote: > Add remove_boot_device_path() function to remove bootindex when hot-unplug > a device. This patch fixed virtio-blk/virtio-net/scsi-disk/scsi-generic > device. > So it has fixed bug1086603, ref: > https://bugzilla.redhat.com/show_bug.cgi?id=1086603

Re: [Qemu-devel] [PATCH 1/4] Replace acpi_pcihp_get_bsel with generic object_property_get_int

2014-04-22 Thread Andreas Färber
Am 22.04.2014 11:12, schrieb Michael S. Tsirkin: > On Tue, Apr 22, 2014 at 11:04:37AM +0200, Igor Mammedov wrote: >> On Sun, 20 Apr 2014 11:32:23 +0300 >> "Michael S. Tsirkin" wrote: >> >>> On Fri, Apr 18, 2014 at 06:30:37PM +0200, Andreas Färber wrote: Am 18.04.2014 15:41, schrieb Kirill Bat

Re: [Qemu-devel] Regression (?) due to c4177479 ('spapr: make sure RMA is in first mode of first memory node')

2014-04-22 Thread Benjamin Herrenschmidt
On Tue, 2014-04-22 at 19:12 +1000, Alexey Kardashevskiy wrote: > I already have in plan to fix non-power-of-two sized memory nodes so I will > this too. > > What exactly is the point in having NUMA memoryless nodes now? We do not > support memory hotplug yet and balloon is not memory hotplug at al

Re: [Qemu-devel] [PATCH v3] glib: fix g_poll early timeout on windows

2014-04-22 Thread Stanislav Vorobiov
Hi, see below On 04/22/2014 01:21 PM, Alex Bligh wrote: > > On 22 Apr 2014, at 10:03, Stanislav Vorobiov wrote: > >>> + */ >>> +#define g_poll(fds, nfds, timeout) g_poll_fixed(fds, nfds, timeout) >>> +gint g_poll_fixed(GPollFD *fds, guint nfds, gint timeout); > > I can't comment on the Windows

Re: [Qemu-devel] [Spice-devel] Automatic spice port selection

2014-04-22 Thread Fabio Fantoni
Il 22/04/2014 10:35, Gerd Hoffmann ha scritto: Hi, Can someone add spice automatic port selection on qemu similar to vnc ones please? Not so easy as this is handled by spice-server not qemu, so this requires some new interfaces to communicate the listening address to qemu. Otherwise you ca

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Jason Wang
On 04/22/2014 04:55 PM, Fam Zheng wrote: > If guest driver behaves abnormally, emulation code could mark the device > as "broken". > > Once "broken" is set, device emulation will typically wait for a reset > command and ignore any other operations, but it could also return error > responds. In othe

Re: [Qemu-devel] [PATCH 008/124] vmstate: Reduce code duplication

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > From: "Michael S. Tsirkin" > > Move size offset and number of elements math out > to functions, to reduce code duplication. In my original review of Michael's patch I said I was OK with it, but I'd prefer if we had something better than 'int' for v

Re: [Qemu-devel] [PATCH 2/3] virtio-blk: Don't exit on invalid VQ data

2014-04-22 Thread Jason Wang
On 04/22/2014 04:55 PM, Fam Zheng wrote: > Set vdev's broken flag, instead of exit, if the VQ has invalid data. > > Check VirtIODevice.broken in VQ output handler, and don't pop any more > request if set, until the device is reset. > > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 20 +

Re: [Qemu-devel] [PATCH v2 3/4] block: Catch duplicate IDs in bdrv_new()

2014-04-22 Thread Kevin Wolf
Am 21.04.2014 um 17:01 hat Eric Blake geschrieben: > On 04/17/2014 09:48 AM, Kevin Wolf wrote: > > Since commit f298d071, block devices added with blockdev-add don't have > > a QemuOpts around in dinfo->opts. Consequently, we can't rely any more > > on QemuOpts catching duplicate IDs for block devi

Re: [Qemu-devel] [PATCH v2 4/4] qemu-iotests: Check common namespace for id and node-name

2014-04-22 Thread Kevin Wolf
Am 21.04.2014 um 09:01 hat Fam Zheng geschrieben: > On Thu, 04/17 17:48, Kevin Wolf wrote: > > A name that is taken by an ID can't be taken by a node-name at the same > > time. Check that conflicts are correctly detected. > > > > Signed-off-by: Kevin Wolf > > --- > > tests/qemu-iotests/087 |

Re: [Qemu-devel] [PATCH 1/4] Replace acpi_pcihp_get_bsel with generic object_property_get_int

2014-04-22 Thread Igor Mammedov
On Tue, 22 Apr 2014 11:25:28 +0200 Andreas Färber wrote: > Am 22.04.2014 11:12, schrieb Michael S. Tsirkin: > > On Tue, Apr 22, 2014 at 11:04:37AM +0200, Igor Mammedov wrote: > >> On Sun, 20 Apr 2014 11:32:23 +0300 > >> "Michael S. Tsirkin" wrote: > >> > >>> On Fri, Apr 18, 2014 at 06:30:37PM +0

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Andreas Färber
Am 22.04.2014 10:55, schrieb Fam Zheng: > If guest driver behaves abnormally, emulation code could mark the device > as "broken". > > Once "broken" is set, device emulation will typically wait for a reset > command and ignore any other operations, but it could also return error > responds. In othe

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Russell King - ARM Linux
On Tue, Apr 22, 2014 at 10:53:07AM +0100, Daniel Thompson wrote: > On 17/04/14 22:35, Russell King - ARM Linux wrote: > > On Thu, Apr 17, 2014 at 04:18:45PM -0500, Rob Herring wrote: > >> The problem here is more than just the TEXT_OFFSET changed. From what > >> I've heard, there are some QC chips

Re: [Qemu-devel] [PATCH v2 4/4] qemu-iotests: Check common namespace for id and node-name

2014-04-22 Thread Fam Zheng
On Tue, 04/22 12:04, Kevin Wolf wrote: > Am 21.04.2014 um 09:01 hat Fam Zheng geschrieben: > > On Thu, 04/17 17:48, Kevin Wolf wrote: > > > A name that is taken by an ID can't be taken by a node-name at the same > > > time. Check that conflicts are correctly detected. > > > > > > Signed-off-by: Ke

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Fam Zheng
On Tue, 04/22 17:58, Jason Wang wrote: > On 04/22/2014 04:55 PM, Fam Zheng wrote: > > If guest driver behaves abnormally, emulation code could mark the device > > as "broken". > > > > Once "broken" is set, device emulation will typically wait for a reset > > command and ignore any other operations,

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Andreas Färber
Am 22.04.2014 12:12, schrieb Fam Zheng: > On Tue, 04/22 17:58, Jason Wang wrote: >> On 04/22/2014 04:55 PM, Fam Zheng wrote: >>> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c >>> index aeabf3a..222bb73 100644 >>> --- a/hw/virtio/virtio.c >>> +++ b/hw/virtio/virtio.c [...] >>> @@ -995,6 +1006

Re: [Qemu-devel] [PATCH 1/3] virtio: Introduce VirtIODevice.broken

2014-04-22 Thread Fam Zheng
On Tue, 04/22 12:05, Andreas Färber wrote: > Am 22.04.2014 10:55, schrieb Fam Zheng: > > If guest driver behaves abnormally, emulation code could mark the device > > as "broken". > > > > Once "broken" is set, device emulation will typically wait for a reset > > command and ignore any other operati

Re: [Qemu-devel] [PATCH 2/3] virtio-blk: Don't exit on invalid VQ data

2014-04-22 Thread Fam Zheng
On Tue, 04/22 18:00, Jason Wang wrote: > On 04/22/2014 04:55 PM, Fam Zheng wrote: > > Set vdev's broken flag, instead of exit, if the VQ has invalid data. > > > > Check VirtIODevice.broken in VQ output handler, and don't pop any more > > request if set, until the device is reset. > > > > Signed-off

Re: [Qemu-devel] [PATCH 069/124] vmstate: Remove VMSTATE_BUFFER_MULTIPLY

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It was unused. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/vmstate.h | 13 - > vmstate.c | 3 --- > 2 files changed, 16 deletions(-) > > diff --git a/include/migra

Re: [Qemu-devel] Controlling SDL2 output with Ctrl+Alt+*

2014-04-22 Thread Gerd Hoffmann
Hi, > Agreed. I think it's also worthwhile that the no-options out-of-the-box > setup gives access to all of serial/monitor/graphics (preferably in a > reasonably discoverable way, ie with tabs or menus). tabs+menus are tricky with SDL, but gtk is the default ui for a reason ... > >> On (b): S

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Russell King - ARM Linux
On Tue, Apr 22, 2014 at 11:26:53AM +0100, Daniel Thompson wrote: > On 18/04/14 05:34, Nicolas Pitre wrote: > >> I'm not suggesting to break anything or changing existing platforms, > >> > but how do we improve the Image format in a compatible way. If > >> > bootloaders want to support booting Image

Re: [Qemu-devel] [PATCH 009/124] vmstate: Refactor opening of files

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert I guess it's a bit simpler this way. Dave > --- > tests/test-vmstate.c | 38 +++--- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)

2014-04-22 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 21/04/2014 13:34, Peter Maydell ha scritto: > >Mostly just that I think that for vmstate definitions "this new field > >was added in version X" is natural and normal, whereas other > >test functions are odd and generally the exception. So a simple >

Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h

2014-04-22 Thread john.liuli
On 2014/4/22 17:38, john.liuli wrote: "john.liuli" writes: libfdt_env.h is missing in some stable installs (<1.3.0-3), some released linux distributions(e.g. Ubuntu 12.04) depending on it still complain missing libfdt even if already installed. So give more detailed hint for such OS users.

Re: [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-22 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> If there is an error while loading a field, we should stop reading and >> not continue with the rest of fields. And we should also set an error >> in qemu_file. >> >> Signed-off-by: Juan Quintela >> --- >> vmstat

Re: [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> If there is an error while loading a field, we should stop reading and > >> not continue with the rest of fields. And we should also set an error > >> in qemu_file.

Re: [Qemu-devel] [PATCH] qemu-img: Exit with code 0 if there is no error

2014-04-22 Thread Kevin Wolf
Am 18.04.2014 um 08:23 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > --- > qemu-img.c | 68 > +++--- > 1 file changed, 34 insertions(+), 34 deletions(-) Is this patch obsoleted by "qemu-img: Improve error message"? Kevin

[Qemu-devel] [PULL 1/2] usb: add CompatibleID support to msos

2014-04-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/desc-msos.c | 6 +- hw/usb/desc.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c index ed8d62c..334d1ae 100644 --- a/hw/usb/desc-msos.c +++ b/hw/usb/desc-msos.c @@ -44,7 +44,7 @@ typedef

[Qemu-devel] [PULL 0/2] usb: mtp filesharing

2014-04-22 Thread Gerd Hoffmann
Hi, Here comes the usb patch queue, featuring the MTP (media transfer protocol) device usable for file sharing. For now it is supported on linux hosts and read-only. please pull, Gerd The following changes since commit 2d03b49c3f225994c4b0b46146437d8c887d6774: Merge remote-tracking branc

[Qemu-devel] [PULL 2/2] usb: mtp filesharing

2014-04-22 Thread Gerd Hoffmann
Implementation of a USB Media Transfer Device device for easy filesharing. Read-only. No access control inside qemu, it will happily export any file it is able to open to the guest, i.e. standard unix access rights for the qemu process apply. Signed-off-by: Gerd Hoffmann --- default-configs/us

Re: [Qemu-devel] [PATCH RFC] ps2: set the keybord output buffer size as the same as kernel

2014-04-22 Thread Juan Quintela
Gerd Hoffmann wrote: > On Di, 2014-04-22 at 08:16 +, Gonglei (Arei) wrote: >> > >> > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c >> > > index 3412079..a754fef 100644 >> > > --- a/hw/input/ps2.c >> > > +++ b/hw/input/ps2.c >> > > @@ -71,7 +71,7 @@ >> > > #define MOUSE_STATUS_ENABLED0x2

Re: [Qemu-devel] [PULL 2/2] usb: mtp filesharing

2014-04-22 Thread Eric Blake
On 04/22/2014 06:03 AM, Gerd Hoffmann wrote: > Implementation of a USB Media Transfer Device device for easy > filesharing. Read-only. No access control inside qemu, it will > happily export any file it is able to open to the guest, i.e. > standard unix access rights for the qemu process apply. >

Re: [Qemu-devel] [PATCH v2] vmdk: Fix "%x" to PRIx32 in format strings for cid

2014-04-22 Thread Kevin Wolf
Am 17.04.2014 um 12:43 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > > --- > v2: PRIx32 -> SCNx32. (Kevin) > > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-22 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> >> If there is an error while loading a field, we should stop reading and >> >> not continue with the rest of fields. And we shou

Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h

2014-04-22 Thread Markus Armbruster
"john.liuli" writes: > On 2014/4/22 17:38, john.liuli wrote: >>"john.liuli" writes: >> >>> libfdt_env.h is missing in some stable installs (<1.3.0-3), some >>> released linux distributions(e.g. Ubuntu 12.04) depending on it still >>> complain missing libfdt even if already installed. >>> So give

Re: [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-22 Thread Juan Quintela
Juan Quintela wrote: > "Dr. David Alan Gilbert" wrote: >> * Juan Quintela (quint...@redhat.com) wrote: >>> If there is an error while loading a field, we should stop reading and >>> not continue with the rest of fields. And we should also set an error >>> in qemu_file. >>> >>> Signed-off-by: Ju

Re: [Qemu-devel] [PATCH] configure: add more detailed hint of old libfdt-dev missing libfdt_env.h

2014-04-22 Thread john.liuli
On 2014/4/22 19:56, john.liuli wrote: On 21 April 2014 07:18, john.liuli wrote: libfdt_env.h is missing in some stable installs (<1.3.0-3), some released linux distributions(e.g. Ubuntu 12.04) depending on it still complain missing libfdt even if already installed. So give more detailed hint

Re: [Qemu-devel] [PATCH] vmdk: Optimize cluster allocation

2014-04-22 Thread Kevin Wolf
Am 18.04.2014 um 14:39 hat Fam Zheng geschrieben: > On mounted NFS filesystem, ftruncate is much much slower than doing a > zero write. Changing this significantly speeds up cluster allocation. > > Comparing by converting a cirros image (296M) to VMDK on an NFS mount > point, over 1Gbe LAN: > >

Re: [Qemu-devel] [PATCH v3] qemu-img: Improve error messages

2014-04-22 Thread Kevin Wolf
Am 22.04.2014 um 07:36 hat Fam Zheng geschrieben: > Previously, when there is a user error in argv parsing, qemu-img prints > help text and exits. > > Add an error_exit function to print a helpful error message and a hint > to run 'qemu-img --help' for more information. > > As a bonus, "qemu-img

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-22 Thread Gabriel L. Somlo
On Tue, Apr 22, 2014 at 08:42:29AM +0200, Gerd Hoffmann wrote: > acpi is pretty much in the same boat ... > > /me looks ... > > Ah, there is a notifier where you (hopefully) can hook in easily: > pc_guest_info_machine_done (see hw/i386/pc.c). Not sure this can help me though. The order in which

Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneeded error descriptions

2014-04-22 Thread Kirill Batuzov
On Tue, 22 Apr 2014, Gerd Hoffmann wrote: > > > if (dev) { > > > -object_property_set_link(OBJECT(s), OBJECT(dev), > > > - "device", &local_err); > > > -object_property_set_int(OBJECT(s), head, > > > -"head", &loca

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-22 Thread Dave Anderson
- Original Message - > On Mon, Apr 21, 2014 at 4:48 PM, Greg Kurz wrote: > > > On Mon, 21 Apr 2014 09:56:48 +0200 > > Alexander Graf wrote: > > > > > > > > > > > > Am 21.04.2014 um 06:16 schrieb Bharata B Rao : > > > > > > > >> On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz > > wrote: > >

Re: [Qemu-devel] Who signed gemu-1.7.1.tar.bz2?

2014-04-22 Thread Stefan Hajnoczi
On Wed, Apr 02, 2014 at 05:40:23PM -0700, Alex Davis wrote: > and where is their gpg key? Michael Roth is doing releases: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x3353C9CEF108B584 $ gpg --verify qemu-2.0.0.tar.bz2.sig gpg: Signature made Thu 17 Apr 2014 03:49:55 PM CEST using RSA key I

Re: [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Juan Quintela wrote: > > "Dr. David Alan Gilbert" wrote: > >> * Juan Quintela (quint...@redhat.com) wrote: > >>> If there is an error while loading a field, we should stop reading and > >>> not continue with the rest of fields. And we should also se

Re: [Qemu-devel] [PULL 01/02] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-04-22 Thread Eduardo Otubo
On 04/14/2014 03:00 PM, Eduardo Otubo wrote: From: Felix Geyer libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 Log messages: audit(1390730418.924:135): auid=4294967295

Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU

2014-04-22 Thread Gerd Hoffmann
On Di, 2014-04-22 at 09:01 -0400, Gabriel L. Somlo wrote: > On Tue, Apr 22, 2014 at 08:42:29AM +0200, Gerd Hoffmann wrote: > > acpi is pretty much in the same boat ... > > > > /me looks ... > > > > Ah, there is a notifier where you (hopefully) can hook in easily: > > pc_guest_info_machine_done (s

Re: [Qemu-devel] [PATCH v5 01/12] qcow2: Allow "full" discard

2014-04-22 Thread Kevin Wolf
Am 17.04.2014 um 23:59 hat Max Reitz geschrieben: > Normally, discarded sectors should read back as zero. However, there are > cases in which a sector (or rather cluster) should be discarded as if > they were never written in the first place, that is, reading them should > fall through to the backi

Re: [Qemu-devel] [PATCH 010/124] vmstate: Refactor & increase tests for primitive types

2014-04-22 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This commit refactor the simple tests to test all integer types. We > move to hex because it is easier to read values of different types. > > Signed-off-by: Juan Quintela > --- > tests/test-vmstate.c | 277 > +++-

Re: [Qemu-devel] Who signed gemu-1.7.1.tar.bz2?

2014-04-22 Thread Peter Maydell
On 22 April 2014 14:31, Stefan Hajnoczi wrote: > On Wed, Apr 02, 2014 at 05:40:23PM -0700, Alex Davis wrote: >> and where is their gpg key? > > Michael Roth is doing releases: > > http://pgp.mit.edu/pks/lookup?op=vindex&search=0x3353C9CEF108B584 > > $ gpg --verify qemu-2.0.0.tar.bz2.sig > gpg: Si

Re: [Qemu-devel] [PULL 01/02] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-04-22 Thread Peter Maydell
On 22 April 2014 14:56, Eduardo Otubo wrote: > > > On 04/14/2014 03:00 PM, Eduardo Otubo wrote: >> >> From: Felix Geyer >> >> libusb calls timerfd_create() and timerfd_settime() when it's built with >> timerfd support. >> >> Command to reproduce: >> >> -device usb-host,hostbus=1,hostaddr=

Re: [Qemu-devel] [PATCH v5 02/12] qcow2: Implement bdrv_make_empty()

2014-04-22 Thread Kevin Wolf
Am 17.04.2014 um 23:59 hat Max Reitz geschrieben: > Implement bdrv_make_empty() by making all clusters in the image fall > through to the backing file (via the now modified discard). > > Signed-off-by: Max Reitz > --- > block/qcow2.c | 22 ++ > 1 file changed, 22 insertions(+

Re: [Qemu-devel] [PATCH v5 04/12] blockjob: Add "ready" field

2014-04-22 Thread Eric Blake
On 04/17/2014 03:59 PM, Max Reitz wrote: > When a block job signals readiness, this is currently reported only > through QMP. If qemu wants to use block jobs for internal tasks, there > needs to be another way to correctly detect when a block job may be > completed. > > For this reason, introduce

Re: [Qemu-devel] Who signed gemu-1.7.1.tar.bz2?

2014-04-22 Thread Michael Roth
Quoting Stefan Hajnoczi (2014-04-22 08:31:08) > On Wed, Apr 02, 2014 at 05:40:23PM -0700, Alex Davis wrote: > > and where is their gpg key? > > Michael Roth is doing releases: > > http://pgp.mit.edu/pks/lookup?op=vindex&search=0x3353C9CEF108B584 > > $ gpg --verify qemu-2.0.0.tar.bz2.sig > gpg:

Re: [Qemu-devel] [PATCH 3/4] graphic_console_init: do not receive unneeded error descriptions

2014-04-22 Thread Gerd Hoffmann
Hi, > We need either to initialize it in new_console with right head value or > to change it to simple struct field. It depends entirely on our future > plans for it. It'll never change after initialization, so keeping it read-only and initialize in new_console sounds good to me. cheers, Ger

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Michal Simek
On 04/17/2014 10:35 PM, Jason Gunthorpe wrote: > On Thu, Apr 17, 2014 at 02:33:43PM -0400, Christopher Covington wrote: >> On 04/16/2014 07:21 PM, Nicolas Pitre wrote: >>> On Wed, 16 Apr 2014, Christopher Covington wrote: >> Thank you for the suggestion. This approach also came to mind, but it

Re: [Qemu-devel] [PATCH 1/4] Replace acpi_pcihp_get_bsel with generic object_property_get_int

2014-04-22 Thread Kirill Batuzov
On Tue, 22 Apr 2014, Igor Mammedov wrote: > On Tue, 22 Apr 2014 11:25:28 +0200 > Andreas Färber wrote: > > > Am 22.04.2014 11:12, schrieb Michael S. Tsirkin: > > > On Tue, Apr 22, 2014 at 11:04:37AM +0200, Igor Mammedov wrote: > > >> On Sun, 20 Apr 2014 11:32:23 +0300 > > >> "Michael S. Tsirkin"

Re: [Qemu-devel] [PATCH v5 04/12] blockjob: Add "ready" field

2014-04-22 Thread Kevin Wolf
Am 17.04.2014 um 23:59 hat Max Reitz geschrieben: > When a block job signals readiness, this is currently reported only > through QMP. If qemu wants to use block jobs for internal tasks, there > needs to be another way to correctly detect when a block job may be > completed. > > For this reason, i

[Qemu-devel] Running an executable on QEMU

2014-04-22 Thread mohammed umar
Hi, Is it possible to run an executable file for qemu-system-sparc having instruction like load, store, add? Or we have to go for user mode emulation of QEMU. Can I install User mode and system mode on same host machine? Will it create any problem? If yes, it would be great if someone help

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Daniel Thompson
On 22/04/14 11:40, Russell King - ARM Linux wrote: > On Tue, Apr 22, 2014 at 11:26:53AM +0100, Daniel Thompson wrote: >> On 18/04/14 05:34, Nicolas Pitre wrote: I'm not suggesting to break anything or changing existing platforms, > but how do we improve the Image format in a compatible way

Re: [Qemu-devel] [PATCH for-2.0] virtio-net: fix guest-triggerable buffer overrun

2014-04-22 Thread Alin Dobre
Hello, For the 1.6 branch, is this as straight forward as the following diff, or is there anything I'm missing? diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 5320aab..a42d241 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -655,7 +655,7 @@ static int virtio_net_handle

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Daniel Thompson
On 17/04/14 21:35, Jason Gunthorpe wrote: >>> The above is useful for loading the raw uncompressed Image without >>> carrying the full ELF baggage. >> >> What exactly is the full ELF baggage? Aren't there existing mechanisms to >> omit >> debugging symbols, for example, if size is of concern? >

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Daniel Thompson
On 17/04/14 22:35, Russell King - ARM Linux wrote: > On Thu, Apr 17, 2014 at 04:18:45PM -0500, Rob Herring wrote: >> The problem here is more than just the TEXT_OFFSET changed. From what >> I've heard, there are some QC chips which need much more reserved RAM >> than the 2MB discussed here. Changin

Re: [Qemu-devel] [PATCH v5 07/12] qemu-img: Empty images after commit

2014-04-22 Thread Eric Blake
On 04/17/2014 03:59 PM, Max Reitz wrote: > After the top image has been committed into an image in its backing > chain, all images above that base image should be emptied to restore the > old qemu-img commit behavior. > > Signed-off-by: Max Reitz > --- > qemu-img.c | 87 > ++

Re: [Qemu-devel] Change of TEXT_OFFSET for multi_v7_defconfig

2014-04-22 Thread Daniel Thompson
On 18/04/14 05:34, Nicolas Pitre wrote: >> I'm not suggesting to break anything or changing existing platforms, >> > but how do we improve the Image format in a compatible way. If >> > bootloaders want to support booting Image files or vmlinux directly, >> > then we should support that including an

Re: [Qemu-devel] [PATCH v5 08/12] qemu-img: Enable progress output for commit

2014-04-22 Thread Eric Blake
On 04/17/2014 03:59 PM, Max Reitz wrote: > Implement progress output for the commit command by querying the > progress of the block job. > > Signed-off-by: Max Reitz > --- > qemu-img-cmds.hx | 4 ++-- > qemu-img.c | 24 ++-- > qemu-img.texi| 2 +- > 3 files change

Re: [Qemu-devel] [PATCH for-2.0] virtio-net: fix guest-triggerable buffer overrun

2014-04-22 Thread Michael S. Tsirkin
On Tue, Apr 22, 2014 at 02:43:42PM +0100, Alin Dobre wrote: > Hello, > > For the 1.6 branch, is this as straight forward as the following diff, > or is there anything I'm missing? I think it's the same. > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > index 5320aab..a42d241 100644 > --

Re: [Qemu-devel] [PATCH v5 03/12] blockjob: Introduce block_job_complete_sync()

2014-04-22 Thread Kevin Wolf
Am 17.04.2014 um 23:59 hat Max Reitz geschrieben: > Implement block_job_complete_sync() by doing the exact same thing as > block_job_cancel_sync() does, only with calling block_job_complete() > instead of block_job_cancel(). > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 11/12] iotests: Add test for backing-chain commits

2014-04-22 Thread Eric Blake
On 04/17/2014 03:59 PM, Max Reitz wrote: > Add a test for qemu-img commit on backing chains with more than two > images. This test also checks whether the images above the base image > are emptied and does therefore not work for qed and vmdk which requires > it to be separate from 020. > > Signed-

Re: [Qemu-devel] [PATCH 010/124] vmstate: Refactor & increase tests for primitive types

2014-04-22 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> This commit refactor the simple tests to test all integer types. We >> move to hex because it is easier to read values of different types. >> >> Signed-off-by: Juan Quintela >> --- >> tests/test-vmstate.c | 277 >

Re: [Qemu-devel] [PATCH v5 12/12] iotests: Omit length/offset test in 040 and 041

2014-04-22 Thread Eric Blake
On 04/17/2014 03:59 PM, Max Reitz wrote: > As the length of a mirror block job no longer directly depends on the > size of the block device, drop the related checks from this test. > > As 041 uses the wait_until_completed function from iotests.py, that > check has to be dropped there as well which

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-22 Thread Greg Kurz
On Tue, 22 Apr 2014 09:19:48 -0400 (EDT) Dave Anderson wrote: > > > - Original Message - > > On Mon, Apr 21, 2014 at 4:48 PM, Greg Kurz wrote: > > > > > On Mon, 21 Apr 2014 09:56:48 +0200 > > > Alexander Graf wrote: > > > > > > > > > > > > > > > > Am 21.04.2014 um 06:16 schrieb Bharat

  1   2   >