On 04/17/2014 09:48 AM, Kevin Wolf wrote:
> Since commit f298d071, block devices added with blockdev-add don't have
> a QemuOpts around in dinfo->opts. Consequently, we can't rely any more
> on QemuOpts catching duplicate IDs for block devices.
>
> This patch add a new check for duplicate IDs to b
On 04/21/2014 08:39 AM, Juan Quintela wrote:
s/unneded/unneeded/ in the subject
> After previous Peter patch, they are redundant. This way we don't asign them
s/asign/assign/
> except when needed. Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
> .fiel
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 363 ++-
1 file changed, 185 insertions(+), 178 deletions(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index caf90ec..9743039 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 3fd13e7..e8a7949 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -332
On 04/21/2014 08:39 AM, Juan Quintela wrote:
> After previous Peter patch, they are redundant. This way we don't asign them
Same typos in subject and commit message as in 2; probably true for
several patches in the series.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualizat
On Mon, Apr 21, 2014 at 4:48 PM, Greg Kurz wrote:
> On Mon, 21 Apr 2014 09:56:48 +0200
> Alexander Graf wrote:
>
> >
> >
> > > Am 21.04.2014 um 06:16 schrieb Bharata B Rao :
> > >
> > >> On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz
> wrote:
> > >>
> > >> +
> > >> +#if !defined(CONFIG_USER_ONLY)
>
On 04/21/2014 08:40 AM, Juan Quintela wrote:
> We intruduce another full test.
s/intruduce/introduce/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 04/20/2014 06:05 AM, Chen Gang wrote:
> After finish 'writeconfig' to stdout (with '-'), we want to copy/past
> the related information mannually, not for redirection ('readconfig'
> does not support '-').
>
> So we can not close the stdout, or next options which may use stdout
> will not be di
The other didn't exist anymore.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 38a7566..cde875e 100644
--- a/include/migration/vmstate.
Remove VMSTATE_UINT32_V, we are removing versioning.
Move all users to VMSTATE_UINT32_TEST.
Signed-off-by: Juan Quintela
---
hw/arm/stellaris.c | 2 +-
hw/display/pl110.c | 2 +-
hw/gpio/pl061.c | 2 +-
hw/intc/ioapic_common.c | 2 +-
hw/misc/arm_sysctl.c
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 1fa2899..8a6ca48 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1211,6 +1211,8 @@ static void test_pointer
On Sat, Apr 19, 2014 at 03:16:52PM -0600, Eric Blake wrote:
> On 04/18/2014 09:56 PM, Amos Kong wrote:
> > Currently we always add a space after c_type in mcgen(), there is
> > some redundant space in generated code. The space isn't needed for
> > points by the coding style.
>
> Second sentence is
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index e223758..f64ad8c 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -203,15 +203,6 @@
On 04/20/2014 04:06 AM, Jun Li wrote:
> Currently, when using blockdev-add to add a drive, qemu can not insert
> this new drive to QemuOptsList. So this will cause the bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=1088176
>
> This patch check the ID is duplicate or not firstly, then if not, i
On 21 April 2014 15:39, Juan Quintela wrote:
> - version_mimium_id_old patches splitted as for Peter requests in:
> * usb
> * x86
> * arm
> * ppc
> * rest
>
> I splitted basically on that order, so, if a device appears on more
> than one architecture, 1st one on the list wins
Thanks
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 93537f7..c7ecaeb 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1415,6 +1415,7
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index c937661..fa69209 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1660,6 +1660,7 @@ typedef stru
On 21 April 2014 15:39, Juan Quintela wrote:
> After previous Peter patch, they are redundant. This way we don't asign them
> except when needed. Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
> .fields = (VMStateField []) {
> and
> .fields = (V
And after all this work, fields don't have version_id anymore.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 1 -
vmstate.c | 5 +
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index
In this two cases we have a 2D array, result is exactly the same, and
one typechecks and the other don't, so change it.
Signed-off-by: Juan Quintela
---
hw/display/g364fb.c | 4 ++--
hw/net/smc91c111.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/display/g364fb.c b/
On 04/21/2014 06:14 AM, Stefan Weil wrote:
> That commit changed the use of the GETPC macro. I just tried to debug
> the tci.c code and noticed that cputlb.c no longer works as expected:
Ouch, yes, I see that.
> This is not specific for the TCG interpreter, but I don't know how the
> normal TCG i
On 21 April 2014 15:39, Juan Quintela wrote:
> After previous Peter patch, they are redundant. This way we don't asign them
> except when needed. Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
> .fields = (VMStateField []) {
> and
> .fields = (V
Peter Maydell wrote:
> On 21 April 2014 15:39, Juan Quintela wrote:
>> - version_mimium_id_old patches splitted as for Peter requests in:
>> * usb
>> * x86
>> * arm
>> * ppc
>> * rest
>>
>> I splitted basically on that order, so, if a device appears on more
>> than one architecture,
Signed-off-by: Juan Quintela
---
docs/migration.txt | 2 +-
hw/block/fdc.c | 2 +-
hw/display/qxl.c| 2 +-
hw/display/vmware_vga.c | 2 +-
hw/ide/core.c | 2 +-
hw/pci/pci.c| 3 +--
include/migration/vmstate.h | 3 +--
target-arm
No user used versions, so easy to change.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 977a35a..38a7566 100644
--- a/includ
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 25e162f..8ccf07d 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1655,6 +1655,8 @@ typedef
I have to refactor object creation to allow for zero arrays at the end
of the struct.
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 8a6ca48..edceaee 1
This is more consistent with VMSTATE_VBUFFER_UINT32 that also exist
Signed-off-by: Juan Quintela
---
hw/block/onenand.c | 2 +-
include/migration/vmstate.h | 7 +--
tests/test-vmstate.c| 2 +-
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/block/onenand.c
On 21 April 2014 17:31, Juan Quintela wrote:
> Patches are easy to review in sequence, any of them is very simple, and
> the few ones that are long (minimum_version_id_old) review is just
> looking that the previous line is minimum_version_id = .
But there are simply _far too many_ of them in thi
No test created, because it is basically imposible to create a timer by hand :-(
Signed-off-by: Juan Quintela
---
hw/timer/mc146818rtc.c | 2 +-
include/migration/vmstate.h | 7 ++-
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818
All users used 0 anyways. Rename VMSTATE_BUFFER_UNSAFE_INFO to
VMSTATE_BUFFER_UNSAFE_TEST to be consistent with rest of fields.
Signed-off-by: Juan Quintela
---
hw/display/g364fb.c | 4 ++--
hw/net/smc91c111.c | 2 +-
hw/pci/pci.c| 10 ++
hw/scsi/esp-p
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index eef5484..c937661 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1659,6 +1659,7 @@ typedef stru
Remove VMSTATE_UINT8_ARRAY_V that was unused.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 9 +++--
tests/test-vmstate.c| 13 +
2 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
ind
On 04/21/2014 10:28 AM, Peter Maydell wrote:
> On 21 April 2014 15:39, Juan Quintela wrote:
>> After previous Peter patch, they are redundant. This way we don't asign them
>>
>> The biggest problem (appart of aesthetics) was that checkpatch complained
As suspected, 4-6 have the same typos as I
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 3c4c0f8..c16b0f0 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -869,12 +869,14 @@ typedef struct
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 031c117..fcd2c8a 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -296
Eric Blake wrote:
> On 04/21/2014 08:39 AM, Juan Quintela wrote:
>
> s/unneded/unneeded/ in the subject
>
>> After previous Peter patch, they are redundant. This way we don't asign them
>
> s/asign/assign/
>
>> except when needed. Once there, there were lots of case where the ".fields"
>> indent
Saves one bundle for the common case of exit_tb 0.
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 2d8e00c..7407011 100644
--- a/tcg/ia64/tcg-target.c
+
The only differences were in the bswap insns emitted.
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 61 ---
1 file changed, 24 insertions(+), 37 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 802ec33..
This sequencing requires 5 stop bits instead of 6, and has room left
over to pre-load the tlb addend, and bswap data prior to being stored.
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 77 ---
1 file changed, 54 insertions(+), 23 de
rth7680/qemu.git tags/tcg-ia64-pull-20140421
for you to fetch changes up to 0374f5089ac94d7c58f3f55201b70e8578b35c64:
tcg-ia64: Convert to new ldst opcodes (2014-04-17 16:56:20 -0400)
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index ca1f6e2..008dee4 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1142,6 +1142,7
Saving at least two cycles per store, and cleaning up the code.
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 94 +--
1 file changed, 31 insertions(+), 63 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index cdc7487..802ec33 100644
--- a/tcg/ia64/tcg-target.c
+++ b/tcg/ia64/tcg-target.c
@@ -1569,7
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 118 +++
1 file changed, 118 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 3d8ba20..f4ff93d 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1649
On 04/17/2014 09:48 AM, Kevin Wolf wrote:
> qemu-img used to use "image" as ID for all block devices. This means
> that e.g. img_convert() ended up with potentially multiple source images
> and one target image, all with the same ID. The next patch will catch
> this and fail to open the block devic
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 176 --
1 file changed, 114 insertions(+), 62 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 3000a6b..76abb46 100644
--- a/tcg/ia64/tcg-target.c
+++ b/tcg/i
And use it on piix4 acpi.
Comment asks for why this things happen!
Signed-off-by: Juan Quintela
---
hw/acpi/piix4.c | 15 +++
include/migration/vmstate.h | 8
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index
It is used for fields that don't exist on the State. They are
generated on the fly for migration.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 14 ++
target-alpha/machine.c | 16 +++-
target-arm/machine.c| 18 ++
3 files cha
After previous Peter patch, they are redundant. This way we don't asign them
except when needed. Once there, there were lots of case where the ".fields"
indentation was wrong:
.fields = (VMStateField []) {
and
.fields = (VMStateField []) {
Change all the combinations to:
.f
Signed-off-by: Juan Quintela
---
include/hw/ptimer.h | 2 +-
include/migration/vmstate.h | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h
index ef852bf..57a65e6 100644
--- a/include/hw/ptimer.h
+++ b/include/hw/ptimer.h
@@
On 04/21/2014 08:40 AM, Juan Quintela wrote:
> CHange users of _V to _TEST.
s/CHange/Change/
>
> Signed-off-by: Juan Quintela
> ---
> include/migration/vmstate.h | 12 ++--
> target-i386/machine.c | 5 +++--
> tests/test-vmstate.c| 24
> 3 files
On 04/21/2014 08:41 AM, Juan Quintela wrote:
> Use it instead of hard-ecoding it on ich9 for GPE.
s/ecoding/coding/
>
> Signed-off-by: Juan Quintela
> ---
> hw/acpi/ich9.c | 11 ++-
> include/migration/vmstate.h | 10 ++
> 2 files changed, 12 insertions(+), 9 delet
Remove unused _V version.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 9 +++--
tests/test-vmstate.c| 17 +
2 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 5b03660..6255
Still inline, but updated to the new routines. Always use the LE
helpers, reusing the bswap between the fast and slot paths.
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 142 --
1 file changed, 80 insertions(+), 62 deletions(-)
di
Signed-off-by: Richard Henderson
---
tcg/ia64/tcg-target.c | 100 +-
tcg/ia64/tcg-target.h | 2 +-
2 files changed, 35 insertions(+), 67 deletions(-)
diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c
index 76abb46..afcfd36 100644
--- a/t
Peter Maydell wrote:
> On 21 April 2014 17:31, Juan Quintela wrote:
>> Patches are easy to review in sequence, any of them is very simple, and
>> the few ones that are long (minimum_version_id_old) review is just
>> looking that the previous line is minimum_version_id = .
>
> But there are simply
Remove unused VMSTATE_UINT32_EQUAL_V.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 9 +++--
tests/test-vmstate.c| 2 ++
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 9a64315..c0b823d 10
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 62552ab..c22f5db 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -654,
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 49 +
1 file changed, 49 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index 308f94d..0a4f81a 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -802,6 +8
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index e1e2523..9f7256c 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
No user of it.
Signed-off-by: Juan Quintela
---
hw/dma/pl330.c | 4 ++--
hw/timer/a9gtimer.c | 2 +-
hw/timer/arm_mptimer.c | 2 +-
hw/usb/hcd-xhci.c | 6 +++---
include/migration/vmstate.h | 3 +--
5 files changed, 8 insertions(+), 9 deletions(-)
diff --git
On 21 April 2014 18:25, Juan Quintela wrote:
> I can split the series at any point (they make sense even without the
> rest).
>
> What about:
>
> 1,7,8: bug fixes/simplification
>
> 2-6: massive Unneeded version_minimum_id_old removal, but trivial per se
>
> 9-47: New testing framework and tests f
The tb flag for be8 mode comes from the CPSR E bit. This will let us
implement setend in the next patch.
Signed-off-by: Paolo Bonzini
---
linux-user/main.c | 1 +
target-arm/cpu.h | 7 +++
target-arm/translate.c | 29 +++--
target-arm/translate.h | 1 +
As we haven't yet moved everything that uses VMSTATE_STRUCT_TEST we create a
temporary VMSTATE_STRUCT_INFO. This would allows us to not having to move
fields to VMSTATE_STRUCT_TEST and then remove the version parameter.
Signed-off-by: Juan Quintela
---
hw/acpi/piix4.c | 2 +-
includ
Signed-off-by: Juan Quintela
---
tests/test-vmstate.c | 88
1 file changed, 88 insertions(+)
diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c
index c7ecaeb..3d8ba20 100644
--- a/tests/test-vmstate.c
+++ b/tests/test-vmstate.c
@@ -1416,
This series adds setend support by using the MO_BE/MO_LE that Richard
implemented. This is used by Raspbian's faster memcmp implementation.
Paolo Bonzini (3):
target-arm: pass DisasContext to gen_aa32_ld*/st*
target-arm: introduce be8 tbflag
target-arm: implement setend
linux-user/main.c
Since this is not a high-performance path, just use a helper to
flip the E bit and force a lookup in the hash table since the
flags have changed.
Signed-off-by: Paolo Bonzini
---
target-arm/helper.h| 1 +
target-arm/op_helper.c | 5 +
target-arm/translate.c | 12 ++--
3 files c
Remove unused VMSTATE_INT16_ARRAY_V
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 9 +++--
tests/test-vmstate.c| 6 ++
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 7c8bc54..db8f295
Needed in the next patch to retrieve the desired endianness.
Signed-off-by: Paolo Bonzini
---
target-arm/translate.c | 256 -
1 file changed, 128 insertions(+), 128 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index fb
Il 21/04/2014 13:34, Peter Maydell ha scritto:
Mostly just that I think that for vmstate definitions "this new field
was added in version X" is natural and normal, whereas other
test functions are odd and generally the exception. So a simple
way to indicate minimum version for fields seems useful
Remove unused _V version.
Signed-off-by: Juan Quintela
---
include/migration/vmstate.h | 5 +
tests/test-vmstate.c| 11 +++
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index eeff224..5b03660 100644
This is trick, to use devices that haven't been converted inside
vmstate state. It was already used on the "wild", so create a macro
and convert the users.
Signed-off-by: Juan Quintela
---
hw/pci/msix.c | 10 +-
hw/scsi/scsi-bus.c | 10 +-
hw/usb/redirect.
On 04/10/2014 11:53 AM, Chunyan Liu wrote:
> Add def_value_str (default value) to QemuOptDesc, to replace function of the
> default value in QEMUOptionParameter.
>
> Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise,
> if desc->def_value_str is set, return desc->def_value_
Peter Maydell wrote:
> On 21 April 2014 18:25, Juan Quintela wrote:
>> I can split the series at any point (they make sense even without the
>> rest).
>>
>> What about:
>>
>> 1,7,8: bug fixes/simplification
>>
>> 2-6: massive Unneeded version_minimum_id_old removal, but trivial per se
>>
>> 9-47:
On 04/21/2014 10:43 AM, Paolo Bonzini wrote:
> @@ -1157,6 +1161,9 @@ static inline void cpu_get_tb_cpu_state(CPUARMState
> *env, target_ulong *pc,
> if (privmode) {
> *flags |= ARM_TBFLAG_PRIV_MASK;
> }
> +if (env->uncached_cpsr & CPSR_E) {
> +*fl
On 04/21/2014 10:43 AM, Paolo Bonzini wrote:
> Since this is not a high-performance path, just use a helper to
> flip the E bit and force a lookup in the hash table since the
> flags have changed.
>
> Signed-off-by: Paolo Bonzini
> ---
> target-arm/helper.h| 1 +
> target-arm/op_helper.c |
On 04/21/2014 10:43 AM, Paolo Bonzini wrote:
> Needed in the next patch to retrieve the desired endianness.
>
> Signed-off-by: Paolo Bonzini
> ---
> target-arm/translate.c | 256
> -
> 1 file changed, 128 insertions(+), 128 deletions(-)
Reviewed-
On 04/10/2014 11:53 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when querying
> command line options.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> changes:
> * Following Leandro's comment:
> upda
On 04/10/2014 11:54 AM, Chunyan Liu wrote:
> qemu_opt_del() already assumes that all QemuOpt instances contain
> malloc'd name and value; but it had to cast away const because
> opts_start_struct() was doing its own thing and using static storage
> instead. By using the correct type and malloced s
On 04/10/2014 11:54 AM, Chunyan Liu wrote:
> Add qemu_opt_get_del, qemu_opt_get_bool_del, qemu_opt_get_number_del and
> qemu_opt_get_size_del to replace the same handling of QEMUOptionParamter
s/Paramter/Parameter/
> (get and delete).
>
> Several drivers are coded to parse a known subset of opti
On 04/10/2014 11:54 AM, Chunyan Liu wrote:
> print_option_help takes QEMUOptionParameter as parameter, add
> qemu_opts_print_help to take QemuOptsList as parameter for later
> replace work.
>
> Reviewed-by: Leandro Dorileo
> Signed-off-by: Dong Xu Wang
> Signed-off-by: Chunyan Liu
> ---
> incl
On 04/10/2014 11:54 AM, Chunyan Liu wrote:
> Add two temp conversion functions between QEMUOptionParameter to QemuOpts,
> so that next patch can use it. It will simplify later patch for easier
> review. And will be finally removed after all backend drivers switch to
> QemuOpts.
>
> Signed-off-by:
This patch contains no functional changes.
Signed-off-by: Gabriel Somlo
---
hw/i386/pc_piix.c | 13 -
hw/i386/pc_q35.c | 13 -
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index cca310b..3d3f4b7 100644
--- a/hw/i38
The function smbios_set_defaults() uses a repeating code pattern
for each field. This patch replaces that pattern with a macro.
This patch contains no functional changes.
Signed-off-by: Gabriel Somlo
---
hw/i386/smbios.c | 27 +--
1 file changed, 13 insertions(+), 14 del
Add definitions for smbios entry point (anchor), and for type 2
(base board) structure which is required by some versions of OS X.
Remove definition for type 20 (memory device mapped address)
structure, which is no longer required as of smbios spec v2.5.
Update all other structure definitions to
Rename the following symbols:
- smbios_set_type1_defaults() to the more general smbios_set_defaults();
- bool smbios_type1_defaults to the more general smbios_defaults;
- smbios_get_table() to smbios_get_table_legacy();
This patch contains no functional changes.
Signed-off-by: Gabriel Soml
Add the following two functions:
- e820_get_num_entries() - query the size of the e820 table
- e820_get_entry() - grab an entry matching a given set of criteria
This interface is currently necessary for creating type 19
(memory array mapped address) structures in smbios.
Signed-off-by: Gabri
Build an aggregate set of smbios tables and an entry point structure.
Insert tables and entry point into fw_cfg respectively under
"etc/smbios/smbios-tables" and "etc/smbios/smbios-anchor".
Machine types <= 2.0 will for now continue using field-by-field
overrides to SeaBIOS defaults, but for mach
New in version 7 of the patch set:
- patch set now down to only 7 patches;
- machine versions 2.0 and older currently unaffected by this patch set,
will continue using field overrides as before
- patches 1..6 are very small and simple, and set the stage for patch #7
- patch 7 introd
Replace existing smbios_check_collision() functionality with
a pair of bitmaps: have_binfile_bitmap and have_fields_bitmap.
Bits corresponding to each smbios type are set by smbios_entry_add(),
which also uses the bitmaps to ensure that binary blobs and field
values are never accepted for the same
On 21 April 2014 18:43, Paolo Bonzini wrote:
> The tb flag for be8 mode comes from the CPSR E bit. This will let us
> implement setend in the next patch.
>
> Signed-off-by: Paolo Bonzini
> ---
> linux-user/main.c | 1 +
> target-arm/cpu.h | 7 +++
> target-arm/translate.c | 29
On 04/10/2014 11:54 AM, Chunyan Liu wrote:
> For later merge .create_opts of drv and proto_drv in qemu-img commands.
>
> Reviewed-by: Leandro Dorileo
> Signed-off-by: Chunyan Liu
> ---
> include/qemu/option.h | 5
> util/qemu-option.c| 65
> +++
On 21 April 2014 18:43, Paolo Bonzini wrote:
> Since this is not a high-performance path, just use a helper to
> flip the E bit and force a lookup in the hash table since the
> flags have changed.
If we take an exception while the E bit is set we'll now incorrectly
start executing the exception h
On 21 April 2014 18:43, Paolo Bonzini wrote:
> This series adds setend support by using the MO_BE/MO_LE that Richard
> implemented. This is used by Raspbian's faster memcmp implementation.
There are also "by hand" loads done in linux-user/main.c's implementation
of ldrex/strex which need to hono
This patch series adds emulation of the PowerPC Decimal Floating Point (DFP)
instructions.
The complete set of DFP instructions defined by the Power ISA is introduced.
The foundation of the emulation code is libdecnumber, a software library that
models DFP
numbers and operations in a manner sim
Fix a simple bug in the decNumberSetBCD() function. This function
encodes a decNumber with "n" BCD digits. The original code erroneously
computed the number of declets from the dn argument, which is the output
decNumber value, and hence may contain garbage. Instead, the input "n"
value is used.
Consistent with other libraries in QEMU, the libdecnumber header files were
placed in include/libdecnumber, separate from the C code. This is different
from the original libdecnumber source, where they were co-located.
Change the libdecnumber source code so that it reflects this split.
Specific
Add emulation of the PowerPC Decimal Floating Point Add instructions dadd[q][.]
Various GCC unused annotations are removed since it is now safe to remove them.
Signed-off-by: Tom Musta
---
V2: Modified post-processor handling per Richard Henderson's review.
target-ppc/dfp_helper.c | 127 +
Introduce two conversion functions to the libdecnumber library.
These conversions transform 64 bit integers to the internal decNumber
representation. Both a signed and unsigned version is added.
Signed-off-by: Tom Musta
---
V2: Simplified negative integer handling in the signed converter per
Ric
101 - 200 of 253 matches
Mail list logo
