Re: [Qemu-devel] [PATCH v2 4/4] qemu-iotests: Check common namespace for id and node-name

2014-04-21 Thread Fam Zheng
On Thu, 04/17 17:48, Kevin Wolf wrote: > A name that is taken by an ID can't be taken by a node-name at the same > time. Check that conflicts are correctly detected. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/087 | 52 > ++ > tests/q

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Alexander Graf
> Am 21.04.2014 um 06:16 schrieb Bharata B Rao : > >> On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz wrote: >> >> + >> +#if !defined(CONFIG_USER_ONLY) >> +bool virtio_is_big_endian(void) >> +{ >> +PowerPCCPU *cp = POWERPC_CPU(first_cpu); >> +CPUPPCState *env = &cp->env; >> + >> +/* NOT

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Bharata B Rao
On Mon, Apr 21, 2014 at 1:26 PM, Alexander Graf wrote: > > > Am 21.04.2014 um 06:16 schrieb Bharata B Rao : > > On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz wrote: > >> >> + >> +#if !defined(CONFIG_USER_ONLY) >> +bool virtio_is_big_endian(void) >> +{ >> +PowerPCCPU *cp = POWERPC_CPU(first_cpu);

[Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-21 Thread Michael Tokarev
libtool has an argument for .syms file, which is -export-symbols. There's no argument `-export-syms', and it looks like at least on linux, -export-syms is just ignored. Use the correct argument, -export-symbols, to actually get the right export list. Signed-off-by: Michael Tokarev --- libcacard

Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

2014-04-21 Thread Michael Tokarev
21.04.2014 13:01, Michael Tokarev wrote: > libtool has an argument for .syms file, which is -export-symbols. > There's no argument `-export-syms', and it looks like at least on > linux, -export-syms is just ignored. Use the correct argument, > -export-symbols, to actually get the right export list

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Greg Kurz
On Mon, 21 Apr 2014 09:46:59 +0530 Bharata B Rao wrote: > On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz wrote: > > > > > + > > +#if !defined(CONFIG_USER_ONLY) > > +bool virtio_is_big_endian(void) > > +{ > > +PowerPCCPU *cp = POWERPC_CPU(first_cpu); > > +CPUPPCState *env = &cp->env; > > + >

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Alexander Graf
> Am 21.04.2014 um 10:55 schrieb Bharata B Rao : > >> On Mon, Apr 21, 2014 at 1:26 PM, Alexander Graf wrote: >> >> >>> Am 21.04.2014 um 06:16 schrieb Bharata B Rao : >>> >> On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz wrote: + +#if !defined(CONFIG_USER_ONLY) +

Re: [Qemu-devel] [PATCH RFC] ps2: set the keybord output buffer size as the same as kernel

2014-04-21 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, April 17, 2014 9:16 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; aligu...@amazon.com; Huangweidong (C); Gonglei > (Arei) > Subject: [PATCH RFC] ps2: set the keybord output buffer size as the same as > kernel > >

Re: [Qemu-devel] [PATCH v5] target-ppc: ppc64 target's virtio can be either endian

2014-04-21 Thread Greg Kurz
On Mon, 21 Apr 2014 09:56:48 +0200 Alexander Graf wrote: > > > > Am 21.04.2014 um 06:16 schrieb Bharata B Rao : > > > >> On Mon, Apr 14, 2014 at 5:42 PM, Greg Kurz > >> wrote: > >> > >> + > >> +#if !defined(CONFIG_USER_ONLY) > >> +bool virtio_is_big_endian(void) > >> +{ > >> +PowerPCCPU

Re: [Qemu-devel] [PATCH v3 3/4] pc & q35: Add new object pc-memory-layout.

2014-04-21 Thread Paolo Bonzini
Il 24/03/2014 19:55, Don Slutz ha scritto: This new object has the property max-ram-below-4g. If you add enough PCI devices then all mmio for them will not fit below 4G which may not be the layout the user wanted. This allows you to increase the below 4G address space that PCI devices can use (a

[Qemu-devel] [Bug 1308542] Re: hang in qemu_gluster_init

2014-04-21 Thread John Eckersberg
Also I should add a note to this related bug I filed against gluster - https://bugzilla.redhat.com/show_bug.cgi?id=1088589 This bug is what causes the glfs_set_logging call to fail, and fall into the hang case. ** Bug watch added: Red Hat Bugzilla #1088589 https://bugzilla.redhat.com/show_bug.

Re: [Qemu-devel] [Bug 1310324] [NEW] Commit 0f842f8a introduces regression when using tcg-interpreter

2014-04-21 Thread Stefan Weil
Am 20.04.2014 19:19, schrieb Giovanni Mascellani: > Public bug reported: > > Hi. > > Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 apparently introduces a > regression when using --enable-tcg-interpreter. The regression is > manifested as follows: > That commit changed the use of the GETPC ma

[Qemu-devel] [PATCH 013/124] vmstate: Remove VMSTATE_UINTL_EQUAL_V

2014-04-21 Thread Juan Quintela
It was not used anywhere. Signed-off-by: Juan Quintela --- include/hw/hw.h | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/include/hw/hw.h b/include/hw/hw.h index 33bdb92..2b68ac3 100644 --- a/include/hw/hw.h +++ b/include/hw/hw.h @@ -51,22 +51,20 @@ int qemu_boot_

[Qemu-devel] [PATCH 001/124] savevm: Ignore minimum_version_id_old if there is no load_state_old

2014-04-21 Thread Juan Quintela
From: Peter Maydell At the moment we require vmstate definitions to set minimum_version_id_old to the same value as minimum_version_id if they do not provide a load_state_old handler. Since the load_state_old functionality is required only for a handful of devices that need to retain migration co

[Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)

2014-04-21 Thread Juan Quintela
ging (2014-04-17 21:37:26 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/vmstate-simplification/20140421 for you to fetch changes up to d587ef5f4657c9c6ba26fe27fc2d78a0d051e30f: vmstate: Test for VMSTATE_ARRAY

[Qemu-devel] [PATCH 006/124] savevm: Remove all the unneded version_minimum_id_old (rest)

2014-04-21 Thread Juan Quintela
After previous Peter patch, they are redundant. This way we don't asign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .f

[Qemu-devel] [PATCH 020/124] vmstate: test for VMSTATE_INT64_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_INT64_V, we are removing versioning. Move all users to VMSTATE_INT64_TEST. Signed-off-by: Juan Quintela --- cpus.c | 2 +- hw/timer/mc146818rtc.c | 2 +- hw/usb/hcd-uhci.c | 2 +- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c

[Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm)

2014-04-21 Thread Juan Quintela
After previous Peter patch, they are redundant. This way we don't asign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .f

[Qemu-devel] [PATCH 012/124] vmstate: Create test functions for versions until 15

2014-04-21 Thread Juan Quintela
Using macros, just to avoid repeating code. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 16 vmstate.c | 22 ++ 2 files changed, 38 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

[Qemu-devel] [PATCH 008/124] vmstate: Reduce code duplication

2014-04-21 Thread Juan Quintela
From: "Michael S. Tsirkin" Move size offset and number of elements math out to functions, to reduce code duplication. Signed-off-by: Michael S. Tsirkin Cc: "Dr. David Alan Gilbert" Signed-off-by: Juan Quintela --- vmstate.c | 100 --

[Qemu-devel] [PATCH 031/124] vmstate: Test for VMSTATE_UINT64_EQUAL

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_UINT64_EQUAL_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 2 ++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index c0b823d..3d55344 10

[Qemu-devel] [PATCH 009/124] vmstate: Refactor opening of files

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 30cc721..8b242c4 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -44

[Qemu-devel] [PATCH 015/124] vmstate: Remove unused VMSTATE_UINTTL_ARRAY_V

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/hw/hw.h | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/include/hw/hw.h b/include/hw/hw.h index 211eb8b..2c19297 100644 --- a/include/hw/hw.h +++ b/include/hw/hw.h @@ -53,21 +53,18 @@ int qemu_boot_set(const char *boot_order

[Qemu-devel] [PATCH 032/124] vmstate: Test for VMSTATE_INT32_EQUAL

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 2 +- tests/test-vmstate.c| 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 3d55344..9765973 100644 --- a/include/migration/vmstate.h +++ b/in

[Qemu-devel] [PATCH 010/124] vmstate: Refactor & increase tests for primitive types

2014-04-21 Thread Juan Quintela
This commit refactor the simple tests to test all integer types. We move to hex because it is easier to read values of different types. Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 277 +++ 1 file changed, 216 insertions(+), 61 deletions

[Qemu-devel] [PATCH 016/124] vmstate: Test for VMSTATE_BOOL_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_BOOL_V, we are removing versioning, would use only tests. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c| 44 2 files changed, 47 insertions(+), 3 deletions(-) diff --git a/includ

[Qemu-devel] [PATCH 027/124] vmstate: Test for VMSTATE_BITMAP

2014-04-21 Thread Juan Quintela
Remove the unused version field (was unused). Signed-off-by: Juan Quintela --- hw/sd/sd.c | 2 +- include/migration/vmstate.h | 4 +-- tests/test-vmstate.c| 75 + 3 files changed, 78 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 039/124] vmstate: Test for VMSTATE_UINT32_ARRAY{_TEST}

2014-04-21 Thread Juan Quintela
Once there, change only user of VMSTATE_UInT32_ARRAY_V. Signed-off-by: Juan Quintela --- hw/misc/arm_sysctl.c| 3 ++- include/migration/vmstate.h | 15 ++- tests/test-vmstate.c| 20 3 files changed, 28 insertions(+), 10 deletions(-) diff --git a

[Qemu-devel] [PATCH 018/124] vmstate: Test for VMSTATE_INT16_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATES_INT16_V, we are removing versioning, would use only tests. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c| 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration

[Qemu-devel] [PATCH 017/124] vmstate: Test for VMSTATE_INT8_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_INT8_V, we are removing versioning, would use only tests. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- tests/test-vmstate.c| 4 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/v

[Qemu-devel] [PATCH 040/124] vmstate: Test for VMSTATE_UINT64_ARRAY{_TEST}

2014-04-21 Thread Juan Quintela
CHange users of _V to _TEST. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 12 ++-- target-i386/machine.c | 5 +++-- tests/test-vmstate.c| 24 3 files changed, 33 insertions(+), 8 deletions(-) diff --git a/include/migration/vmstat

[Qemu-devel] [PATCH 019/124] vmstate: Test for VMSTATE_INT32_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_INT32_V, we are removing versioning. Move all users to use tests. Signed-off-by: Juan Quintela --- hw/input/ps2.c | 2 +- include/migration/vmstate.h | 6 +++--- target-i386/machine.c | 4 ++-- tests/test-vmstate.c| 4 4 files changed, 10 insertions

[Qemu-devel] [PATCH 043/124] vmstate: Test for VMSTATE_INT64_ARRAY

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_INT64_ARRAY_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 10 ++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 49446a8..

[Qemu-devel] [PATCH 021/124] vmstate: Test for VMSTATE_UINT8_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_UINT8_V, we are removing versioning. Move all users to VMSTATE_UINT8_TEST. Signed-off-by: Juan Quintela --- hw/char/serial.c| 2 +- hw/ide/core.c | 2 +- hw/net/ne2000.c | 2 +- hw/timer/ds1338.c | 2 +- hw/timer/hpet.c

[Qemu-devel] [PATCH 028/124] vmstate: Test for VMSTATE_UINT8_EQUAL

2014-04-21 Thread Juan Quintela
We intruduce another full test. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 2 +- tests/test-vmstate.c| 42 ++ 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstat

[Qemu-devel] [PATCH 022/124] vmstate: Test for VMSTATE_UINT16_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_UINT16_V, we are removing versioning. Move all users to VMSTATE_UINT16_TEST. Signed-off-by: Juan Quintela --- hw/char/serial.c| 2 +- hw/net/lan9118.c| 4 ++-- include/migration/vmstate.h | 9 +++-- target-i386/machine.c | 8 tests/test-vm

[Qemu-devel] [PATCH 042/124] vmstate: Test for VMSTATE_INT32_ARRAY{_TEST}

2014-04-21 Thread Juan Quintela
Change only user of _V to _TEST. Signed-off-by: Juan Quintela --- hw/pci-host/piix.c | 4 ++-- include/migration/vmstate.h | 12 ++-- tests/test-vmstate.c| 20 3 files changed, 28 insertions(+), 8 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/p

[Qemu-devel] [PATCH 025/124] vmstate: Test for VMSTATE_FLOAT64

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_FLOAT64_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 5 + tests/test-vmstate.c| 5 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 0940340..717c7fb 100644 -

[Qemu-devel] [PATCH 051/124] vmstate: All ptimers users were at least at version 1 or more

2014-04-21 Thread Juan Quintela
So we can remove the version field. Signed-off-by: Juan Quintela --- include/hw/ptimer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ptimer.h b/include/hw/ptimer.h index 8ebacbb..ef852bf 100644 --- a/include/hw/ptimer.h +++ b/include/hw/ptimer.h @@ -28,7 +28,7

[Qemu-devel] [PATCH 050/124] vmstate: Remove unused version fields from ARM

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- target-ppc/machine.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target-ppc/machine.c b/target-ppc/machine.c index d7807f8..4540fe2 100644 --- a/target-ppc/machine.c +++ b/target-ppc/machine.c @@ -120,11 +120,8 @@ static con

[Qemu-devel] [PATCH 029/124] vmstate: Test for VMSTATE_UINT16_EQUAL

2014-04-21 Thread Juan Quintela
We change only user of VMSTATE_UINT16_EQUAL_V to VMSTATE_UINT16_EQUAL_TEST. Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 7 ++- include/migration/vmstate.h | 8 tests/test-vmstate.c| 8 +++- 3 files changed, 17 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 052/124] vmstate: Remove version from all variants of VMSTATE_STRUCT_POINTER*

2014-04-21 Thread Juan Quintela
There were no more users of them. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 17 ++--- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index a715904..f0c99d9 100644 --- a/include/migration/vm

[Qemu-devel] [PATCH 033/124] vmstate: Test for VMSTATE_INT32_LE

2014-04-21 Thread Juan Quintela
Add tests for less/more than the value on destination. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 4 ++-- tests/test-vmstate.c| 20 +++- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vm

[Qemu-devel] [PATCH 053/124] vmstate: Port last 3 users of VMSTATE_ARRAY to VMSTATE_ARRAY_TEST

2014-04-21 Thread Juan Quintela
And then remove VMSTATE_ARRAY. Signed-off-by: Juan Quintela --- hw/net/vmxnet3.c| 13 +++-- include/migration/vmstate.h | 10 -- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d8e8d59..1faf58d 100644 --- a/hw/

[Qemu-devel] [PATCH 034/124] vmstate: s/VMSTATE_INT32_LE/VMSTATE_INT32_POSITIVE_LE/

2014-04-21 Thread Juan Quintela
From: "Michael S. Tsirkin" As the macro verifies the value is positive, rename it to make the function clearer. Signed-off-by: Michael S. Tsirkin Signed-off-by: Juan Quintela --- hw/pci/pci.c| 4 ++-- include/migration/vmstate.h | 3 +-- target-arm/machine.c| 2 +- tes

[Qemu-devel] [PATCH 036/124] vmstate: Test for VMSTATE_ARRAY_BOOL_TEST

2014-04-21 Thread Juan Quintela
We add all the boilerplate code for testing arrays. We change only user of VMSTATE_ARRAY_BOOL_V to VMSTATE_ARRAY_BOOL_TEST. Signed-off-by: Juan Quintela --- hw/audio/hda-codec.c| 3 +- include/migration/vmstate.h | 8 +-- tests/test-vmstate.c| 117

[Qemu-devel] [PATCH 038/124] vmstate: Test for VMSTATE_UINT16_ARRAY

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_UINT16_ARRAY_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 7 ++- tests/test-vmstate.c| 6 ++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 19789c4..5935d60

[Qemu-devel] [PATCH 056/124] vmstate: Rename VMSTATE_SINGLE_TEST to VMSTATE_SINGLE

2014-04-21 Thread Juan Quintela
And as no user used the version_id, just remove the parameter. Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 2 +- hw/nvram/fw_cfg.c | 2 +- hw/timer/twl92230.c | 2 +- include/migration/vmstate.h | 36 +--- target-i386/machin

[Qemu-devel] [PATCH 069/124] vmstate: Remove VMSTATE_BUFFER_MULTIPLY

2014-04-21 Thread Juan Quintela
It was unused. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 13 - vmstate.c | 3 --- 2 files changed, 16 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index f5687b7..7e3877d 100644 --- a/include/migration/vms

[Qemu-devel] [PATCH 061/124] vmstate: Remove version_id fields that were not used

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 4 1 file changed, 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index dfb59e2..e84da16 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -342,7 +342,6 @@ exter

[Qemu-devel] [PATCH 045/124] vmstate: Test for VMSTATE_UINT8_2DARRAY

2014-04-21 Thread Juan Quintela
Remove unused _V version. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 28 ++-- 2 files changed, 29 insertions(+), 8 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 37

[Qemu-devel] [PATCH 072/124] vmstate: Move all users of versioning of VMSTATE_STRUCT_ARRAY to _TEST

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/char/escc.c | 4 ++-- hw/ide/internal.h | 3 ++- hw/timer/i8254_common.c | 5 +++-- target-i386/machine.c | 15 +-- 4 files changed, 16 insertions(+), 11 deletions(-) diff --git a/hw/char/escc.c b/hw/char/escc.c index 4875a2b..d

[Qemu-devel] [PATCH 073/124] vmstate: Remove version parameter from VMSTATE_STRUCT_ARRAY

2014-04-21 Thread Juan Quintela
No users of that field left. Signed-off-by: Juan Quintela --- hw/arm/musicpal.c | 2 +- hw/audio/ac97.c | 2 +- hw/audio/es1370.c | 2 +- hw/audio/hda-codec.c | 3 +-- hw/audio/intel-hda.c | 3 +-- hw/block/fdc.c| 2 +-

[Qemu-devel] [PATCH 014/124] vmstate: Change VMSTATE_INTTL_V to VMSTATE_INTTL_TEST

2014-04-21 Thread Juan Quintela
And fix all users. VMSTATE_UINT64_TEST don't exist. Create it. Signed-off-by: Juan Quintela --- include/hw/hw.h | 10 +- include/migration/vmstate.h | 3 +++ target-i386/machine.c | 4 ++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/include/hw/hw

[Qemu-devel] [PATCH 044/124] vmstate: Test for VMSTATE_FLOAT64_ARRAY

2014-04-21 Thread Juan Quintela
Remove unused VMSTATE_FLOAT64_ARRAY_V. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 9 +++-- tests/test-vmstate.c| 11 +++ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 0a562a

[Qemu-devel] [PATCH 074/124] vmstate: Remove version parameter from VMSTATE_STRUCT_ARRAY_TEST

2014-04-21 Thread Juan Quintela
No users left. Signed-off-by: Juan Quintela --- hw/char/escc.c | 2 +- hw/ide/internal.h | 2 +- hw/timer/i8254_common.c | 2 +- hw/timer/pxa2xx_timer.c | 2 +- hw/usb/hcd-xhci.c | 2 +- include/hw/acpi/pcihp.h | 2 +- include/migration/vmstate.h | 5

[Qemu-devel] [PATCH 067/124] vmstate: Remove version, test and start parameter from VMSTATE_VBUFFER_UINT32

2014-04-21 Thread Juan Quintela
None of its users use them. Signed-off-by: Juan Quintela --- hw/char/exynos4210_uart.c | 2 +- hw/display/g364fb.c | 2 +- hw/dma/pl330.c | 8 hw/intc/exynos4210_gic.c| 2 +- hw/net/vmxnet3.c| 3 +-- hw/nvram/mac_nvram.c| 2 +- hw/sd/sdhci.

[Qemu-devel] [PATCH 059/124] vmstate: Rename VMSTATE_ARRAY_TEST to VMSTATE_ARRAY

2014-04-21 Thread Juan Quintela
VMSTATE_ARRAY is not being used anymore. Signed-off-by: Juan Quintela --- hw/net/vmxnet3.c| 9 - include/migration/vmstate.h | 20 ++-- target-i386/machine.c | 11 +++ target-ppc/machine.c| 4 ++-- 4 files changed, 23 insertions(+), 21

[Qemu-devel] [PATCH 078/124] vmstate: Remove version parameter from VMSTATE_VARRAY_UINT32

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/nvram/ds1225y.c | 2 +- hw/ppc/spapr_iommu.c| 3 ++- include/migration/vmstate.h | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/nvram/ds1225y.c b/hw/nvram/ds1225y.c index 332598b..cfedfa8 100644 --- a/hw/nvram/ds1225y

[Qemu-devel] [PATCH 060/124] vmstate: Remove version_id from VMSTATE_VBUFFER

2014-04-21 Thread Juan Quintela
None of its two users use it. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e4839a2..dfb59e2 100644 --- a/include/migration/vmstate.h +++ b/in

[Qemu-devel] [PATCH 064/124] vmstate: Remove version_id from VMSTATE_VARRAY_UINT16_UNSAFE

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/nvram/eeprom93xx.c | 2 +- include/migration/vmstate.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/nvram/eeprom93xx.c b/hw/nvram/eeprom93xx.c index 7e09037..8f59509 100644 --- a/hw/nvram/eeprom93xx.c +++ b/hw/nvram/eeprom93x

[Qemu-devel] [PATCH 054/124] vmstate: Port last user of VMSTATE_SINGLE to VMSTATE_SINGLE_TEST

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/timer/twl92230.c | 2 +- include/migration/vmstate.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/timer/twl92230.c b/hw/timer/twl92230.c index 7ded4ba..3aacaeb 100644 --- a/hw/timer/twl92230.c +++ b/hw/timer/twl92230.c @@ -7

[Qemu-devel] [PATCH 070/124] vmstate: Remove version parameter from VMSTATE_STATIC_BUFFER

2014-04-21 Thread Juan Quintela
No user for it. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 7e3877d..1afbf5a 100644 --- a/include/migration/vmstate.h +++ b/include/mig

[Qemu-devel] [PATCH 062/124] vmstate: Remove version_id from VMSTATE_SUB_ARRAY

2014-04-21 Thread Juan Quintela
None of its two users used it. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index e84da16..1acba4b 100644 --- a/include/migration/vmstate.h +++ b/i

[Qemu-devel] [PATCH 080/124] vmstate: Move all users of versioning to VMSTATE_STRUCT_TEST

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/usb/hcd-ehci-pci.c| 3 ++- hw/usb/hcd-ehci-sysbus.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 505741a..6ada623 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @

[Qemu-devel] [PATCH 026/124] vmstate: Test for VMSTATE_UNUSED

2014-04-21 Thread Juan Quintela
Remove VMSTATE_UNUSED_V and fix only user. Signed-off-by: Juan Quintela --- hw/intc/ioapic_common.c | 3 ++- include/migration/vmstate.h | 11 ++- tests/test-vmstate.c| 5 + 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/intc/ioapic_common.c b/hw/int

[Qemu-devel] [PATCH 066/124] vmstate: remove version parameter from VMSTATE_BUFFER_POINTER_UNSAFE

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/block/onenand.c | 2 +- hw/sd/sd.c | 2 +- include/migration/vmstate.h | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/block/onenand.c b/hw/block/onenand.c index 60d5311..87fbf00 100644 --- a/hw/block/onenand

[Qemu-devel] [PATCH 089/124] vmstate: Test for VMSTATE_UINT32_SUB_ARRAY

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 0a4f81a..8b45ea5 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -811,6 +811,8 @@ static const VMStateDescription

[Qemu-devel] [PATCH 081/124] vmstate: Remove version from all VMSTATE_STRUCT calls

2014-04-21 Thread Juan Quintela
It has no users at this point. Signed-off-by: Juan Quintela --- hw/acpi/piix4.c| 4 ++-- hw/arm/spitz.c | 2 +- hw/audio/pl041.c | 16 ++-- hw/block/fdc.c | 4 ++-- hw/char/exynos4210_uart.c |

[Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb)

2014-04-21 Thread Juan Quintela
After previous Peter patch, they are redundant. This way we don't asign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .f

[Qemu-devel] [PATCH 093/124] vmstate: Test for VMSTATE_BUFFER_TEST

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 36 1 file changed, 36 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 8b114fa..3c4c0f8 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -928,6 +928,41 @@ stat

[Qemu-devel] [PATCH 024/124] vmstate: Test for VMSTATE_UINT64_TEST

2014-04-21 Thread Juan Quintela
Remove VMSTATE_UINT64_V, we are removing versioning. Move all users to VMSTATE_UINT64_TEST. Signed-off-by: Juan Quintela --- hw/timer/mc146818rtc.c | 6 +++--- include/migration/vmstate.h | 9 +++-- target-i386/machine.c | 30 +++--- tests/test-vmstate.c

[Qemu-devel] [PATCH 076/124] vmstate: Remove unused version parameter from VMSTATE_STRUCT_VARRAY_UINT8

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/timer/hpet.c | 2 +- include/migration/vmstate.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 2148568..0fd2eb0 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -304,7 +304,7 @@

[Qemu-devel] [PATCH 075/124] vmstate: Remove unused version parameter from VMSTATE_STRUCT_VARRAY_INT32

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/input/stellaris_input.c | 2 +- include/migration/vmstate.h | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/input/stellaris_input.c b/hw/input/stellaris_input.c index 0609e80..07e7856 100644 --- a/hw/input/stellaris_input.c +++ b/hw/

[Qemu-devel] [PATCH 096/124] vmstate: Remove unused VMSTATE_SUB_VBUFFER

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index b363eca..98c5602 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -644,9 +644,6 @@ extern

[Qemu-devel] [PATCH 087/124] vmstate: Test for VMSTATE_SYNTHETIC

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 24 1 file changed, 24 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index a56c5cc..308f94d 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -187,6 +187,28 @@ TestSimple obj_s

[Qemu-devel] [PATCH 077/124] vmstate: Introduce VMSTATE_VARRAY_UINT32_TEST

2014-04-21 Thread Juan Quintela
Use it on the only case were a version was used. Signed-off-by: Juan Quintela --- hw/misc/arm_sysctl.c| 5 +++-- include/migration/vmstate.h | 7 +-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/misc/arm_sysctl.c b/hw/misc/arm_sysctl.c index 0f61241..668681f 1006

[Qemu-devel] [PATCH 097/124] vmstate: Remove unused VMSTATE_PARTIAL_VBUFFER_UINT32

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 98c5602..7117239 100644 --- a/include/migration/vmstate.h +++ b/include/migration/vmstate.h @@ -641,9 +641,6 @@ extern

[Qemu-devel] [PATCH 090/124] vmstate: Test for VMSTATE_BUFFER

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 8b45ea5..cea5984 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -865,6 +

[Qemu-devel] [PATCH 082/124] vmstate: Create VMSTATE_VARRAY macro

2014-04-21 Thread Juan Quintela
Use it instead of hard-ecoding it on ich9 for GPE. Signed-off-by: Juan Quintela --- hw/acpi/ich9.c | 11 ++- include/migration/vmstate.h | 10 ++ 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 407ae89..f4801d1 10

[Qemu-devel] [PATCH 104/124] vmstate: Test for VMSTATE_POINTER

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 61 1 file changed, 61 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 79bdf9d..c284bfc 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1057,

[Qemu-devel] [PATCH 101/124] vmstate: Rename VMS_VBUFFER to VMST_VBUFFER_INT32 for consintency

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 6 +++--- vmstate.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index a2d1aae..cf27366 100644 --- a/include/migration/vmstate.h +++

[Qemu-devel] [PATCH 091/124] vmstate: Test for VMSTATE_PARTIAL_BUFFER

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index cea5984..ddfa017 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -867,10 +867,12 @@ static void test_array_sub(void)

[Qemu-devel] [PATCH 102/124] vmstate: Test for VMSTATE_VBUFFER_UINT32

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index ae27679..79bdf9d 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -974,6 +974,8 @@ static void test_buffer_test(

[Qemu-devel] [PATCH 098/124] vmstate: Test for VMSTATE_PARTIAL_VBUFFER

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 75 1 file changed, 75 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index c16b0f0..31acb15 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -971,6

[Qemu-devel] [PATCH 108/124] vmstate: Test for VMSTATE_ARRAY_INT32_UNSAFE

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index a8a1dfe..f7fd3e2 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -535,11 +535,13 @@ static void test_sim

[Qemu-devel] [PATCH 123/124] vmstate: Test for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 105 +++ 1 file changed, 105 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index fa69209..ca1f6e2 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1916

[Qemu-devel] [PATCH 105/124] vmstate: Test for VMSTATE_POINTER_UNSAFE

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index c284bfc..e1e2523 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1059,6 +1059,7 @@ static voi

[Qemu-devel] [PATCH 092/124] vmstate: Test for VMSTATE_BUFFER_START_MIDDLE

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index ddfa017..8b114fa 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -868,11 +868,13 @@ static void test_array_sub(void)

[Qemu-devel] [PATCH 109/124] vmstate: Test for VMSTATE_VARRAY

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 127 +++ 1 file changed, 127 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index f7fd3e2..1fa2899 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1208

[Qemu-devel] [PATCH 103/124] vmstate: VMSTATE_POINTER() used the wrong type to calculate the size

2014-04-21 Thread Juan Quintela
We need the the pointer to foo for the type of the field, but not for the size. Fix its only user. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index

[Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error

2014-04-21 Thread Juan Quintela
If there is an error while loading a field, we should stop reading and not continue with the rest of fields. And we should also set an error in qemu_file. Signed-off-by: Juan Quintela --- vmstate.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/vmstate.c b/vmstate.c index bfa34cc..bc

[Qemu-devel] [PATCH 100/124] vmstate: Create VMS_VBUFFER_UINT32

2014-04-21 Thread Juan Quintela
We were dereferencing an uint32_t as int32_t. Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 3 ++- vmstate.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 84efec5..a2d1aae 1

[Qemu-devel] [PATCH 112/124] vmstate: Test for VMSTATE_VARRAY_INT32{_TEST}

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index edceaee..7e69b14 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1213,6 +1213,9 @@ typedef

[Qemu-devel] [PATCH 118/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_UINT32

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 33 + 1 file changed, 33 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index f4ff93d..25e162f 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1653,6 +1653,8 @@ static

[Qemu-devel] [PATCH 107/124] vmstate: Test for VMSTATE_BUFFER_POINTER_UNSAFE

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 9f7256c..a8a1dfe 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -865,12 +865,15 @@ static void test_arr

[Qemu-devel] [PATCH 113/124] vmstate: Test for VMSTATE_STRUCT{_TEST}

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 148 +++ 1 file changed, 148 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 7e69b14..93537f7 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1393

Re: [Qemu-devel] [PATCH] qemu-img: Improve error messages

2014-04-21 Thread Eric Blake
On 04/21/2014 12:23 AM, Fam Zheng wrote: > Previously, when there is an user error in argv parsing, qemu-img prints s/an user/a user/ (The rule of thumb for selecting which article to use for a leading 'u' is pronunciation: anything starting with "you" uses "a", anything with "uh" uses "an" [e.g.

Re: [Qemu-devel] [PATCH v2 1/4] block: Add errp to bdrv_new()

2014-04-21 Thread Eric Blake
On 04/17/2014 09:48 AM, Kevin Wolf wrote: > This patch adds an errp parameter to bdrv_new() and updates all its > callers. The next patches will make use of this in order to check for > duplicate IDs. Most of the callers know that their ID is fine, so they > can simply assert that there is no error

[Qemu-devel] [PATCH 120/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_POINTER_UINT16

2014-04-21 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/test-vmstate.c | 32 1 file changed, 32 insertions(+) diff --git a/tests/test-vmstate.c b/tests/test-vmstate.c index 8ccf07d..eef5484 100644 --- a/tests/test-vmstate.c +++ b/tests/test-vmstate.c @@ -1657,6 +1657,8 @@ typedef

  1   2   3   >