qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. As
qemu-img itself has no access to QMP (since this would basically require
just everything being linked into qemu-img), imitate QMP's
implementation of block-comm
Implement progress output for the commit command by querying the
progress of the block job.
Signed-off-by: Max Reitz
---
qemu-img-cmds.hx | 4 ++--
qemu-img.c | 24 ++--
qemu-img.texi| 2 +-
3 files changed, 25 insertions(+), 5 deletions(-)
diff --git a/qemu-img-
Instead of taking the total length of the block device as the block
job's length, use the number of dirty sectors. The progress is now the
number of sectors mirrored to the target block device. Note that this
may result in the job's length increasing during operation, which is
however in fact desir
As the length of a mirror block job no longer directly depends on the
size of the block device, drop the related checks from this test.
As 041 uses the wait_until_completed function from iotests.py, that
check has to be dropped there as well which in turn affects test 055. On
the other hand, a blo
After the top image has been committed into an image in its backing
chain, all images above that base image should be emptied to restore the
old qemu-img commit behavior.
Signed-off-by: Max Reitz
---
qemu-img.c | 87 +++---
1 file changed,
Introduce a new parameter for qemu-img commit which may be used to
explicitly specify the backing file into which an image should be
committed if the backing chain has more than a single layer.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Fam Zheng
---
qemu-img-cmds.hx | 4 ++
Add a test for qemu-img commit on backing chains with more than two
images. This test also checks whether the images above the base image
are emptied and does therefore not work for qed and vmdk which requires
it to be separate from 020.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/089 |
When a block job signals readiness, this is currently reported only
through QMP. If qemu wants to use block jobs for internal tasks, there
needs to be another way to correctly detect when a block job may be
completed.
For this reason, introduce a bool "ready" which is set when the block
job may be
On Fri, Apr 18, 2014 at 3:32 AM, Stefan Weil wrote:
> Signed-off-by: Stefan Weil
Reviewed-by: Peter Crosthwaite
> ---
> hw/net/xilinx_axienet.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/xilinx_axienet.c b/hw/net/xilinx_axienet.c
> index 839d97c..6dc665
As different image formats most probably map guest addresses to
different host addresses, add a filter to filter the host addresses out;
also, the image filename should be filtered.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/common.filter | 7 +++
1 file changed, 7 insertions(+)
diff -
Implement bdrv_make_empty() by making all clusters in the image fall
through to the backing file (via the now modified discard).
Signed-off-by: Max Reitz
---
block/qcow2.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 1e7b7d5..4d7
On 04/18/2014 06:25 AM, Nishanth Aravamudan wrote:
> Hi Alexey,
>
> Prior to the $SUBJECT commit, we could present memoryless node0s to
> guests. Now, we indicate that we don't have the requisite 128M for the
> RMA if node 0 has no memory. Note that a memoryless node0 is possible
> under PowerVM (
On Fri, 2014-04-18 at 08:43 +1000, Alexey Kardashevskiy wrote:
> On 04/18/2014 06:25 AM, Nishanth Aravamudan wrote:
> > Hi Alexey,
> >
> > Prior to the $SUBJECT commit, we could present memoryless node0s to
> > guests. Now, we indicate that we don't have the requisite 128M for the
> > RMA if node
On 18.04.2014 [08:46:55 +1000], Benjamin Herrenschmidt wrote:
> On Fri, 2014-04-18 at 08:43 +1000, Alexey Kardashevskiy wrote:
> > On 04/18/2014 06:25 AM, Nishanth Aravamudan wrote:
> > > Hi Alexey,
> > >
> > > Prior to the $SUBJECT commit, we could present memoryless node0s to
> > > guests. Now,
I found some newer Windows binaries at http://qemu.weilnetz.de/ and can
confirm I do not see the issue any more.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1223467
Title:
Unable to use USB as hd
On Thu, 04/17 06:00, Eric Blake wrote:
> On 04/17/2014 04:43 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng
> >
> > ---
> > v2: PRIx32 -> SCNx32. (Kevin)
> >
> > Signed-off-by: Fam Zheng
> > ---
>
> > +++ b/block/vmdk.c
> > @@ -262,7 +262,7 @@ static uint32_t vmdk_read_cid(BlockDriverState
Hi, maintainers.
Could you check this patch?
http://www.mail-archive.com/qemu-devel@nongnu.org/msg227161.html
Thanks
ps)
We've checked the http://wiki.qemu.org/Contribute/SubmitAPatch. Yet, if we
made any violation or mistake, let us know. We will appreciate your favor.
-Original Message---
On Thu, Apr 17, 2014 at 4:35 PM, Russell King - ARM Linux
wrote:
> On Thu, Apr 17, 2014 at 04:18:45PM -0500, Rob Herring wrote:
>> The problem here is more than just the TEXT_OFFSET changed. From what
>> I've heard, there are some QC chips which need much more reserved RAM
>> than the 2MB discusse
Hi Markus,
This series introduces qemu_get_boot_opts(), in much the same way as
was done for qemu_get_machine_opts().
As usual, I have out-of-scope and out-of-tree usages :) But P3 does
clean up the three existing instances of the long-and-awkward form of
this query and makes the one in vl.c cons
This "nofail" (i.e. does not return NULL) mechanism driving
qemu_get_machine_opts() does not need to be specific to machine opts
- its applicable to other types of opts. Generalise and re-implement
qemu_get_machine_opts() as a caller of the generalisation.
Signed-off-by: Peter Crosthwaite
---
v
Same basic idea as qemu_get_machine_opts().
Signed-off-by: Peter Crosthwaite
---
include/sysemu/sysemu.h | 1 +
vl.c| 11 +++
2 files changed, 12 insertions(+)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index ba5c7f8..d41748d 100644
--- a/includ
To simplfiy and make consistent with surrounding code using
qemu_get_machine_opts(). Create a new local variable name boot_opts
for consistency as well.
Signed-off-by: Peter Crosthwaite
---
vl.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
dif
When accessing boot options, we query whatever options come first in
the boot opts list. This is wrong.
Use qemu_get_boot_opts() to fix these bugs.
This change is similar to and based on 36ad0e9.
We also take to opportunity to remove the now unneeded null boot-opts
conditional, removing a level
On Thu, 17 Apr 2014, Rob Herring wrote:
> Here's a simple test of what I was trying to point out. I took a
> working kernel with TEXT_OFFSET of 0x8000 and booted it on QEMU using
> the "virt" machine which RAM normally starts at 0x4000. Then
> varying the RAM base, I get these results:
>
> 0x
Il 14/04/2014 09:25, Peter Maydell ha scritto:
(More generally it feels like either the code using this
needs to be able to cope with "might only get TARGET_PAGE_SIZE"
semantics, or we need to fix the Xen code paths so that
they provide the whole requested section as well. The
patch looks more li
Il 17/04/2014 01:51, Jan Kiszka ha scritto:
On 2014-04-17 07:46, Shiru Ren wrote:
Hi, all
I’m trying to figure out how do_savevm works in QEMU. But there is one
thing has bothered me quite a lot. I found that vm_stop invoke
qemu_cpu_kick_thread to send SIG_IPI to a vcpu thread, and I have
under
Il 18/04/2014 00:25, Peter Crosthwaite ha scritto:
This "nofail" (i.e. does not return NULL) mechanism driving
qemu_get_machine_opts() does not need to be specific to machine opts
- its applicable to other types of opts. Generalise and re-implement
qemu_get_machine_opts() as a caller of the gener
Hi All -
I would like to generate a trace of all memory accesses (i.e. read or
write, physical address, and data content/payload). The end goal is to use
this trace to drive a separate memory system simulator. Ideally, the trace
would also provide core-id and a timestamp (but I am not as optimis
Signed-off-by: Fam Zheng
---
qemu-img.c | 68 +++---
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 8455994..756ccb1 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -58,7 +58,7 @@ static void format
There are two paths to show help and exit, one is with "-h" or "--help",
one is with invalid options.
Only "exit 1" with the latter case.
Signed-off-by: Fam Zheng
---
configure | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index 69b9f56..b195ef
On Fri, 18 Apr 2014 00:03:57 +1000
Peter Crosthwaite wrote:
> On Thu, Apr 17, 2014 at 7:40 PM, Igor Mammedov wrote:
> > On Thu, 17 Apr 2014 09:46:28 +1000
> > Peter Crosthwaite wrote:
> >
> >> On Fri, Apr 4, 2014 at 11:36 PM, Igor Mammedov wrote:
> >> > Adds get_hotplug_handler() method to mac
18.04.2014 10:25, Fam Zheng wrote:
> There are two paths to show help and exit, one is with "-h" or "--help",
> one is with invalid options.
>
> Only "exit 1" with the latter case.
I'd rather put `exit 1' right in invalid option case, instead of jumping
to help. Because help output is huge, and
English language grammar does not allow usage
of the word "allows" directly followed by an
infinitive, declaring constructs like "something
allows to do somestuff" un-grammatical. Often
it is possible to just insert "one" between "allows"
and "to" to make the construct grammatical, but
usually it
nd the changed patch as a reply to this message.
Please consider pulling.
The following changes since commit 2d03b49c3f225994c4b0b46146437d8c887d6774:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20140417-1' into staging (2014-04-17
21:37:26 +0100)
are avai
On Fri, Apr 18, 2014 at 2:53 PM, Paolo Bonzini wrote:
> Il 18/04/2014 00:25, Peter Crosthwaite ha scritto:
>
>> This "nofail" (i.e. does not return NULL) mechanism driving
>> qemu_get_machine_opts() does not need to be specific to machine opts
>> - its applicable to other types of opts. Generalise
Hi,
sorry, your patch was too late for QEMU 2.0. It remained unnoticed for
two reasons:
* Patches for some special version should show this in the subject line:
[PATCH for 2.0] instead of [PATCH]
* CC'ing the maintainers helps a lot, as you see now :-)
More comments below.
Am 18.04.2014 04:
Old:
There are two paths to show help and exit 1, one is with "-h" or
"--help", one is with invalid options.
New:
Show help and exit 0 for --help.
On invalid option, don't show the long help and bury the early "ERROR:"
line, just give a message pointing to --help.
Signed-off-by: Fam Zheng
---
c
201 - 237 of 237 matches
Mail list logo
