On Fri, Mar 28, 2014 at 02:22:49PM +, Peter Maydell wrote:
> Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get()
> does not return zero-initialized memory. Spotted by the clang sanitizer
> (which complained when the value loaded in dma_complete() was not valid
> for a bool
Currently it is UINT16_MAX*16 = 65536*16 = 1048560 which is not
a round number and therefore a bit confusing.
This defines MAX_NVRAM_SIZE precisely as 1MB.
Suggested-by: Thomas Huth
Signed-off-by: Alexey Kardashevskiy
---
hw/nvram/spapr_nvram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
On Mon, Mar 31, 2014 at 03:39:19PM +0100, anton.iva...@kot-begemot.co.uk wrote:
> +static void net_l2tpv3_process_queue(NetL2TPV3State *s)
> +{
> +int size = 0;
> +struct iovec *vec;
> +bool bad_read;
> +int data_size;
> +struct mmsghdr *msgvec;
> +
> +/* go into ring mode o
Hi Alex,
Seems to works for me ;).
On 03/04/2014 20:48, Alexander Graf wrote:
We now reset SPRs to their reset values on CPU reset. So if we want
to have an SPR persistently changed, we need to change its default
reset value rather than the value itself manually.
Do this for SPR_BOOKE_PIR, fix
On Thu, Apr 03, 2014 at 03:46:32PM +0200, Kevin Wolf wrote:
> If lazy refcounts are enabled for a backing file, committing to this
> backing file may leave it in a dirty state even if the commit succeeds.
> The reason is that the bdrv_flush() call in bdrv_commit() doesn't flush
> refcount updates w
On 4 April 2014 06:32, Peter Crosthwaite wrote:
>> +if (arm_feature(env, ARM_FEATURE_AARCH64)) {
>> +/* 32 bit view is [31:18] 0...0 [43:32]. */
>> +uint32_t cbar32 = cpu->reset_cbar
>
> Should you extract64 on the lower order bits as well to avoid weird |
> results
Markus Armbruster writes:
> Nikunj A Dadhania writes:
>
> Have you considered extending QEMUMachineInitArgs instead of adding this
> function?
Did not think of this option earlier. You mean doing something like
this?
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 3a13231..936a17f 100644
---
Il 03/04/2014 20:56, Anirudha Bose ha scritto:
Hi Paolo !
I would like to volunteer to develop Documentation tools for QEMU during
my summer holidays. Yesterday I had expressed my intent to work on this
project in the IRC channel of QEMU. This is a follow up email of your reply.
That's awesome
"Michael S. Tsirkin" wrote:
> move size offset and number of elements math out
> to functions, to reduce code duplication.
>
> Signed-off-by: Michael S. Tsirkin
> Cc: "Dr. David Alan Gilbert"
Reviewed-by: Juan Quintela
Added to migration branch for 2.1
When you ask for an accelerator not supported for your target, you get
a bogus "accelerator does not exist" message:
$ qemu-system-arm -machine none,accel=kvm
KVM not supported for this target
"kvm" accelerator does not exist.
No accelerator found!
Suppress it.
Signed-off-by: Chen Gang
"Michael S. Tsirkin" wrote:
> Can be used to verify a required field exists or validate
> state in some other way.
>
> Signed-off-by: Michael S. Tsirkin
> Reviewed-by: Dr. David Alan Gilbert
What should this do?
We can change the semantics of ->field_exist() to add this functionality
if neede
"Michael S. Tsirkin" wrote:
> CVE-2013-4531
>
> cpreg_vmstate_indexes is a VARRAY_INT32. A negative value for
> cpreg_vmstate_array_len will cause a buffer overflow.
>
> VMSTATE_INT32_LE was supposed to protect against this
> but doesn't because it doesn't validate that input is
> non-negative.
>
"Michael S. Tsirkin" wrote:
> As the macro verifies the value is positive, rename it
> to make the function clearer.
>
> Signed-off-by: Michael S. Tsirkin
Reviewed-by: Juan Quintela
"Michael S. Tsirkin" wrote:
> From: Peter Maydell
>
> At the moment we require vmstate definitions to set minimum_version_id_old
> to the same value as minimum_version_id if they do not provide a
> load_state_old handler. Since the load_state_old functionality is
> required only for a handful of
CVE-2013-4544
Signed-off-by: Dmitry Fleytman
Reported-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/vmxnet3.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 0b317f8..4fefc7b 100644
--- a/hw
CVE-2013-4544
Signed-off-by: Dmitry Fleytman
Reported-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/vmxnet3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index a0723c0..ddcee4b 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.
CVE-2013-4544
Signed-off-by: Dmitry Fleytman
Reported-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/vmxnet3.c | 36 ++--
1 file changed, 34 insertions(+), 2 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 5be807c..0b317
Changes since V1:
* Comments added and extended as sugested by Dave and Michael
Dmitry Fleytman (4):
vmxnet3: validate interrupt indices coming from guest
vmxnet3: validate queues configuration coming from quest
vmxnet3: validate interrupt indices read on migration
vmxnet3: validate queu
CVE-2013-4544
Signed-off-by: Dmitry Fleytman
Reported-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/net/vmxnet3.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 4fefc7b..a0723c0 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet
On Apr 3, 2014, at 19:07 PM, Michael S. Tsirkin wrote:
> On Tue, Apr 01, 2014 at 02:07:52PM +0100, Dr. David Alan Gilbert wrote:
>> * Dmitry Fleytman (dmi...@daynix.com) wrote:
>>>
>>> On Apr 1, 2014, at 14:33 PM, Dr. David Alan Gilbert
>>> wrote:
>>>
* Michael S. Tsirkin (m...@redhat.c
"Michael S. Tsirkin" wrote:
> CVE-2013-4527 hw/timer/hpet.c buffer overrun
>
> hpet is a VARRAY with a uint8 size but static array of 32
>
> To fix, make sure num_timers is valid using VMSTATE_VALID hook.
>
> Reported-by: Anthony Liguori
> Signed-off-by: Michael S. Tsirkin
> Reviewed-by: Dr. Dav
* Juan Quintela (quint...@redhat.com) wrote:
> "Michael S. Tsirkin" wrote:
> > Can be used to verify a required field exists or validate
> > state in some other way.
> >
> > Signed-off-by: Michael S. Tsirkin
> > Reviewed-by: Dr. David Alan Gilbert
>
>
> What should this do?
>
> We can change
From: ChenLiang
V5-->V4
* Fix two issues: one is cache_insert don't update the page which
has been in the cache. Another avoiding the risk that run
xbzrle_encode_buffer on changing data.
a. Optimization the xbzrle remarkable decrease the cache misses.
The efficiency of compress increase
From: ChenLiang
Reducing data copy can reduce cpu overhead.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 84a4bd3..94b62e2 100644
--- a/arch_init.c
+++ b/arch_init.c
@
From: ChenLiang
clear the dead code
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Juan Quintela
---
arch_init.c | 13 -
page_cache.c | 58 --
2 files changed, 71 deletions(-)
diff --git a/arch_init.c b/arch_
From: ChenLiang
expose xbzrle cache miss rate
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Eric Blake
---
arch_init.c | 18 ++
hmp.c | 2 ++
include/migration/migration.h | 1 +
migration.c | 1 +
From: ChenLiang
Rebuild the cache_is_cached function by cache_get_by_addr. And
drops the asserts because the caller is also asserting the same
thing.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
---
page_cache.c | 38
From: ChenLiang
expose the count that logs the times of updating the dirty bitmap to
end user.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Eric Blake
---
arch_init.c | 1 +
hmp.c | 2 ++
include/migration/migration.h | 1 +
migrat
From: ChenLiang
Avoid hot pages being replaced by others to remarkably decrease cache
misses
Sample results with the test program which quote from xbzrle.txt ran in
vm:(migrate bandwidth:1GE and xbzrle cache size 8MB)
the test program:
include
include
int main()
{
char *buf = (char
From: ChenLiang
xbzrle_encode_buffer checks the value in the vm ram repeatedly.
It is risk if runs xbzrle_encode_buffer on changing data.
And it is not necessary.
Reported-by: Dr. David Alan Gilbert
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
xbzrle.c | 20 +++-
1 fil
From: ChenLiang
The logic of old code is correct. But Checking byte by byte will
consume time after an concurrency scene.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
xbzrle.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/xbzrle.c b/
From: ChenLiang
The page may not be inserted into cache after executing save_xbzrle_page.
In case of failure to insert, the original page should be sent rather
than the page in the cache.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Juan Quintela
---
arch_init.c | 25
From: ChenLiang
Add counts to log the times of updating the dirty bitmap.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Eric Blake
---
arch_init.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch_init.c b/arch_init.c
index 2ac68c2..200af0e 100644
--- a/arch_init.c
I simply like it better, you don't? :)
Signed-off-by: Takashi Iwai
---
ui/gtk.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index 6668bd8226d5..4427d9f6c1e9 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -141,6 +141,7 @@ typedef struct GtkDisplayState
G
It's pretty annoying that the pointer reappears at a random place once
after grabbing and ungrabbing the input. Better to restore to the
original position where the pointer was grabbed.
Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Tested-by: Cole Robinson
Reviewed-by: Cole Robin
The GDK motion-notify-event isn't generated when the pointer goes out
of the target window even if the pointer is grabbed, which essentially
means to lose the pointer tracking in gtk-ui.
Meanwhile the generic "event" signal is sent when the pointer is
grabbed, so we can use this and pick the motio
The relative pointer tracking mode was still buggy even after the
previous fix of the motion-notify-event since the events are filtered
out when the pointer moves outside the drawing window due to the
boundary check for the absolute mode.
This patch fixes the issue by moving the unnecessary bounda
Hi,
this is the revisited patch series. The only difference from v2
is that now they are checkpatch-clean and Cole's acks have been
added to patches 1-3.
Takashi
Chen Gang writes:
> When you ask for an accelerator not supported for your target, you get
> a bogus "accelerator does not exist" message:
>
> $ qemu-system-arm -machine none,accel=kvm
> KVM not supported for this target
> "kvm" accelerator does not exist.
> No accelerator found!
>
> Supp
Nikunj A Dadhania writes:
> Markus Armbruster writes:
>> Nikunj A Dadhania writes:
>>
>> Have you considered extending QEMUMachineInitArgs instead of adding this
>> function?
>
> Did not think of this option earlier. You mean doing something like
> this?
Yes. Looks nicer, doesn't it?
Il 04/04/2014 12:58, Markus Armbruster ha scritto:
>>
>> Have you considered extending QEMUMachineInitArgs instead of adding this
>> function?
>
> Did not think of this option earlier. You mean doing something like
> this?
Yes. Looks nicer, doesn't it?
I still think it's a libvirt bug. Mixi
Il 04/04/2014 07:28, Nikunj A Dadhania ha scritto:
>>
>> And -usb is translated to adding "pci-ohci" controller for spapr
>
> Yeah, but with -nodefaults it's better to use -device directly.
I think there is special handling for this in vl.c
bool usb_enabled(bool default_usb)
{
return qemu_
Paolo Bonzini writes:
> Il 04/04/2014 12:58, Markus Armbruster ha scritto:
>>
>> Have you considered extending QEMUMachineInitArgs instead of adding this
>> function?
>>> >
>>> > Did not think of this option earlier. You mean doing something like
>>> > this?
>> Yes. Looks nicer, d
Paolo Bonzini writes:
> Il 04/04/2014 07:28, Nikunj A Dadhania ha scritto:
>>
>> And -usb is translated to adding "pci-ohci" controller for spapr
>>> >
>>> > Yeah, but with -nodefaults it's better to use -device directly.
>> I think there is special handling for this in vl.c
>>
>> bool
Il 04/04/2014 13:40, Nikunj A Dadhania ha scritto:
> Sure. However, I'm saying that it's fine for spapr to make -usb mean
> "OHCI, and also keyboard & mouse if there is a VGA card in the system".
>
> If libvirt used "-device pci-ohci" unconditionally, it would fix the bug
> *and* it would ensure
This patch series fixes bugs reported by Andrei Warkentin involving
signal handling in linux-user mode. The first is Andrei's first patch
(though I have tweaked the commit message a little). The second
patch is aimed at fixing the locking bug that Andrei noted, in
a somewhat simpler way than his pa
This eliminates the possible assertion failure in error_setg().
Signed-off-by: Fam Zheng
---
block/iscsi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 21c18a3..64a509f 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1101,8 +110
From: Andrei Warkentin
When checking a page range, if we found that a page was
made read-only by QEMU because it contained translated code,
we were incorrectly returning immediately after unprotecting
that page, rather than continuing to check the entire range,
so we might fail to unprotect pages
If the guest attempts to execute from unreadable memory, this will
cause us to longjmp back to the main loop from inside the
target frontend decoder. For linux-user mode, this means we will
still hold the tb_ctx.tb_lock, and will deadlock when we try to
start executing code again. Unlock the lock i
Il 04/04/2014 13:53, Fam Zheng ha scritto:
This eliminates the possible assertion failure in error_setg().
Signed-off-by: Fam Zheng
---
block/iscsi.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 21c18a3..64a509f 100644
--- a/bloc
Kevin Wolf (3):
block: Don't parse 'filename' option
qemu-iotests: Remove CR line endings in reference output
block: Fix snapshot=on for protocol parsed from filename
block.c| 152 +++--
include/block/block.h | 1 +
tests/qe
Since commit 9fd3171a, BDRV_O_SNAPSHOT uses an option QDict to specify
the originally requested image as the backing file of the newly created
temporary snapshot. This means that the filename is stored in
"file.filename", which is an option that is not parsed for protocol
names. Therefore things li
When using the QDict option 'filename', it is supposed to be interpreted
literally. The code did correctly avoid guessing the protocol from any
string before the first colon, but it still called bdrv_parse_filename()
which would, for example, incorrectly remove a 'file:' prefix in the
raw-posix dri
qemu doesn't print these CRs any more. The test still didn't fail
because the output comparison ignores line endings, but the change turns
up each time when you want to update the output.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/051.out | 10 +-
1 file changed, 5 insertions(+), 5
Am 04.04.2014 um 13:57 hat Paolo Bonzini geschrieben:
> Il 04/04/2014 13:53, Fam Zheng ha scritto:
> >This eliminates the possible assertion failure in error_setg().
> >
> >Signed-off-by: Fam Zheng
> >---
> > block/iscsi.c | 6 --
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> >diff
On Fri, Mar 28, 2014 at 10:10 PM, Paolo Bonzini wrote:
> Il 28/03/2014 12:43, Don Slutz ha scritto:
>
>> Ping. (Since this is a bug fix, I think it can go into 2.0)
>> -Don Slutz
>
>
> I think the problem is that not many people understand the 8250 device
> model. CCing someone who hopefully
On 04/04/2014 02:57 AM, Alexey Kardashevskiy wrote:
The change log is:
> Isolate sc 1 detection logic
> build: auto-detect ppc64 architecture
> cas: increase hcall buffer size to accomodate 256 cpus
> usb: change device tree naming
> usb-core: adjust port numbers in set_address
On 04/04/2014 09:26 AM, Alexey Kardashevskiy wrote:
Currently it is UINT16_MAX*16 = 65536*16 = 1048560 which is not
a round number and therefore a bit confusing.
This defines MAX_NVRAM_SIZE precisely as 1MB.
Suggested-by: Thomas Huth
Signed-off-by: Alexey Kardashevskiy
Thanks, applied to pp
When qcow2_get_cluster_offset() sees a zero cluster in a version 2
image, it (rightfully) returns an error. But in doing so it shouldn't
leak an L2 table cache reference.
Signed-off-by: Kevin Wolf
---
block/qcow2-cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-cluster.c
On Fri, Apr 04, 2014 at 07:53:29PM +0800, Fam Zheng wrote:
> This eliminates the possible assertion failure in error_setg().
>
> Signed-off-by: Fam Zheng
> ---
> block/iscsi.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
On 04/04/2014 08:13 AM, Alexey Kardashevskiy wrote:
On 04/04/2014 12:19 AM, Alexander Graf wrote:
On 03.04.14 15:14, Alexey Kardashevskiy wrote:
This advertises Data Address Breakpoint Register Extension (DABRX) to
the guest via hyperrtas list and enables it to migrate.
Do all CPUs we support
On 04/04/2014 08:58 AM, Alexey Kardashevskiy wrote:
On 04/04/2014 06:12 AM, Tom Musta wrote:
On 4/3/2014 8:33 AM, Alexander Graf wrote:
On 03.04.14 15:14, Alexey Kardashevskiy wrote:
This enabled KVM and migration support for a number of POWER8 registers:
Tom, please have a look through th
On 04/04/2014 07:17 AM, Alexey Kardashevskiy wrote:
On 03/24/2014 04:28 PM, Alexey Kardashevskiy wrote:
Currently only migration fails if CPU version is different even a bit.
For example, migration from POWER7 v2.0 to POWER7 v2.1 fails because of
that. Since there is no difference between CPU ve
On Fri, Apr 4, 2014 at 6:25 PM, Peter Maydell wrote:
> On 4 April 2014 06:32, Peter Crosthwaite wrote:
>>> +if (arm_feature(env, ARM_FEATURE_AARCH64)) {
>>> +/* 32 bit view is [31:18] 0...0 [43:32]. */
>>> +uint32_t cbar32 = cpu->reset_cbar
>>
>> Should you extract
On 4/3/2014 7:51 PM, Alexey Kardashevskiy wrote:
> Since I'll be touching this code soon, I can make copy content of
> init_proc_POWER7 to init_proc_POWER8 and remove DABRX if this is what you
> mean. Ok?
Yes it is. Thanks, Alexey.
On 4 April 2014 13:32, Peter Crosthwaite wrote:
> On Fri, Apr 4, 2014 at 6:25 PM, Peter Maydell
> wrote:
>> On 4 April 2014 06:32, Peter Crosthwaite
>> wrote:
+if (arm_feature(env, ARM_FEATURE_AARCH64)) {
+/* 32 bit view is [31:18] 0...0 [43:32]. */
+
Am 04.04.2014 10:28, schrieb Nikunj A Dadhania:
> diff --git a/vl.c b/vl.c
> index 017f92d..0d6c36c 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4348,7 +4348,8 @@ int main(int argc, char **argv, char **envp)
> .kernel_filename = kernel_filename,
>
On 1 April 2014 04:10, Peter Crosthwaite wrote:
> On Sat, Mar 29, 2014 at 2:09 AM, Peter Maydell
> wrote:
>> +static inline uint32_t syn_insn_abort(bool same_el, int ea, int s1ptw, int
>> fsc)
>
> Why the mix of bools and ints for the 1 bit fields?
Lack of a strong opinion plus writing the cod
On 4/1/2014 3:03 PM, Thomas Falcon wrote:
> This patch allows registers to be properly read from and written to
> when using the gdbstub to debug a ppc guest running in little
> endian mode. It accomplishes this goal by byte swapping the values of
> any registers if the MSR:LE value is set.
>
> S
From: Paolo Bonzini
Reviewed-by: Laszlo Ersek
Reviewed-by: Andreas Färber
Signed-off-by: Paolo Bonzini
Signed-off-by: Igor Mammedov
---
include/qemu/config-file.h | 2 ++
util/qemu-config.c | 14 ++
vl.c | 11 +--
3 files changed, 17 inserti
What's new since v7:
* Per Andreas' suggestion dropped DIMMBus concept.
* Added hotplug binding for bus-less devices
* DIMM device is split to backend and frontend. Therefore following
command/options were added for supporting it:
For memory-ram backend:
CLI: -object-add memory-ram,
Add following parameters:
"slots" - total number of hotplug memory slots
"maxmem" - maximum possible memory
"slots" and "maxmem" should go in pair and "maxmem" should be greater
than "mem" for memory hotplug to be enabled.
Signed-off-by: Igor Mammedov
---
include/hw/boards.h | 2 ++
qemu-o
Provides framework for splitting host RAM allocation/
policies into a separate backend that could be used
by devices.
Initially only legacy RAM backend is provided, which
uses memory_region_init_ram() allocator and compatible
with every CLI option that affects memory_region_init_ram().
Signed-off
Adds option to -m
"size" - startup memory amount
For compatibility with legacy CLI if suffix-less number is passed,
it assumes amount in Mb.
Otherwise user is free to use suffixed number using suffixes b,k/K,M,G
Signed-off-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
Reviewed-by: Eric Blake
Adds get_hotplug_handler() method to machine, and
makes bus-less device to use it during hotplug
as a means to discover hotplug handler controller.
Returned controller is used to permorm a hotplug
action.
Signed-off-by: Igor Mammedov
---
hw/core/qdev.c | 13 +
include/hw/boards.
... which is current ACPI implementation limit.
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 69e4225..6fe1803 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1204,6 +1204,12 @@ FWCfgState *pc_memory_ini
which allows to check if MemoryRegion is already mapped.
Signed-off-by: Igor Mammedov
---
include/exec/memory.h | 8
memory.c | 15 ++-
2 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index c084db2..2
Propeties of object should be available after its instances_init()
callback is finished and not added in PCIDeviceClass.init which is
roughly corresponds to realize() method.
Moving properties adding into instances_init will fix missing
property error when global/compat property mechanism is used.
it will be used for PC specific options/variables
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 36
hw/i386/pc_piix.c| 36 ++--
hw/i386/pc_q35.c | 12 ++--
include/hw/i386/pc.h | 24 +++
initialize and map hotplug memory address space container
into guest's RAM address space.
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 19 +--
include/hw/i386/pc.h | 10 ++
2 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/p
replace magic numbers with enum describing Flags field of
memory affinity in SRAT table.
MemoryAffinityFlags enum will define flags decribed by:
ACPI spec 5.0, "5.2.16.2 Memory Affinity Structure",
"Table 5-69 Flags - Memory Affinity Structure"
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-bu
that will perform mapping of DIMM device into guest's RAM address space
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 52
include/hw/i386/pc.h | 8
2 files changed, 60 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
... to make sure that IO range used by memory hotlug won't be used by PCI
devices.
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-dsdt.dsl | 10 +-
hw/i386/q35-acpi-dsdt.dsl | 10 +-
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i38
- if slot property is not specified on -device/device_add command,
treat default value as request for assigning DimmDevice to
the first free slot.
- if slot is provided with -device/device_add command, attempt to
use it or fail command if it's already occupied.
Signed-off-by: Igor Mammedov
---
Each hotplug-able memory slot is a DimmDevice.
A hot-add operation for a DIMM:
- creates a new DimmDevice and makes hotplug controller to map it into
guest address space
Hotplug operations are done through normal device_add commands.
For migration case, all hotplugged DIMMs on source should be s
to make it more generic, so it could be used for memory hotplug
as well.
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-dsdt.dsl | 2 +-
hw/i386/q35-acpi-dsdt.dsl | 2 +-
include/hw/acpi/acpi_defs.h| 32
include/hw/acpi/cpu_hotplug.
Needed for Windows to use hotplugged memory device, otherwise
it complains that server is not configured for memory hotplug.
Tests shows that aftewards it uses dynamically provided
proximity value from _PXM() method if available.
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-build.c | 14 +++
... and report error if plugged in device is not supported.
Later generic callbacks will be used by memory hotplug.
Signed-off-by: Igor Mammedov
---
hw/acpi/piix4.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix
Add memory hotplug initialization/handling to ICH9 LPC device
and enable it by default for post 2.0 machine types
Signed-off-by: Igor Mammedov
---
hw/acpi/ich9.c | 38 ++
hw/i386/pc_q35.c | 4
hw/isa/lpc_ich9.c | 20 +++
- provides static SSDT object for memory hotplug
- SSDT template for memory devices and runtime generator
of them in SSDT table.
Signed-off-by: Vasilis Liaskovitis
Signed-off-by: Igor Mammedov
---
hw/i386/Makefile.objs | 3 +-
hw/i386/acpi-build.c | 37
hw/i386/ssdt-mem.dsl
also make handler edge based to avoid loosing events, the same as
it has been done for PCI and CPU hotplug handlers.
Signed-off-by: Igor Mammedov
---
hw/i386/acpi-dsdt.dsl | 5 -
hw/i386/q35-acpi-dsdt.dsl | 5 -
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/i386/a
On 04.04.2014 14:03, Kevin Wolf wrote:
qemu doesn't print these CRs any more. The test still didn't fail
because the output comparison ignores line endings, but the change turns
up each time when you want to update the output.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/051.out | 10
Adds an optional vmstate field that allows to migrate current
state of acpi_memory_hotplug of ACPI PM device.
Signed-off-by: Igor Mammedov
---
hw/acpi/ich9.c | 8
hw/acpi/memory_hotplug.c | 27 +++
hw/acpi/piix4.c | 8
On 04.04.2014 14:03, Kevin Wolf wrote:
When using the QDict option 'filename', it is supposed to be interpreted
literally. The code did correctly avoid guessing the protocol from any
string before the first colon, but it still called bdrv_parse_filename()
which would, for example, incorrectly rem
Add mhp_pc_dimm_assigned_slot & mhp_pc_dimm_assigned_address
events to trace which address and slot where assigned to
plugged in DIMM device on target-i386 machine.
Signed-off-by: Igor Mammedov
---
hw/i386/pc.c | 3 +++
trace-events | 4
2 files changed, 7 insertions(+)
diff --git a/hw/i38
On 04/01/2014 10:03 PM, Thomas Falcon wrote:
This patch allows registers to be properly read from and written to
when using the gdbstub to debug a ppc guest running in little
endian mode. It accomplishes this goal by byte swapping the values of
any registers if the MSR:LE value is set.
Signed-o
Il 04/04/2014 15:36, Igor Mammedov ha scritto:
+acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find();
+if (!acpi_dev) {
+error_setg(&local_err,
+ "memory hotplug is not enabled: missing acpi device");
errp, not &local_err.
Paolo
+retu
On 04/04/2014 04:52 AM, Peter Maydell wrote:
> If the guest attempts to execute from unreadable memory, this will
> cause us to longjmp back to the main loop from inside the
> target frontend decoder. For linux-user mode, this means we will
> still hold the tb_ctx.tb_lock, and will deadlock when we
On 28 March 2014 18:42, Richard Henderson wrote:
> On 03/28/2014 09:09 AM, Peter Maydell wrote:
>> +for (i = 0; i < maxidx; i++) {
>> +hostaddr[i] = tlb_vaddr_to_host(env,
>> +vaddr + TARGET_PAGE_SIZE *
>> i,
>> +
Il 04/04/2014 15:36, Igor Mammedov ha scritto:
Adds an optional vmstate field that allows to migrate current
state of acpi_memory_hotplug of ACPI PM device.
Signed-off-by: Igor Mammedov
---
hw/acpi/ich9.c | 8
hw/acpi/memory_hotplug.c | 27 ++
1 - 100 of 180 matches
Mail list logo
