Re: [Qemu-devel] [PATCH 2/4] spapr-pci: introduce a finish_realize() callback

2014-03-13 Thread Alexey Kardashevskiy
On 03/13/2014 12:56 PM, Andreas Färber wrote: > Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy: >> The spapr-pci PHB initializes IOMMU for emulataed devices only. > > "emulated" > >> The upcoming VFIO support will do it different. However both emulated >> and VFIO PHB types share most of the i

Re: [Qemu-devel] [PATCH 3/4] spapr-pci: add spapr_pci trace

2014-03-13 Thread Alexey Kardashevskiy
On 03/13/2014 12:46 PM, Andreas Färber wrote: > Am 21.11.2013 05:08, schrieb Alexey Kardashevskiy: >> Signed-off-by: Alexey Kardashevskiy >> --- >> trace-events | 1 + >> 1 file changed, 1 insertion(+) > > Unused trace event? I'll better drop it at all since Paolo dislikes generalized trace eve

Re: [Qemu-devel] [PATCH 02/16] target-arm: A64: Fix bug in add_sub_ext handling of rn

2014-03-13 Thread Laurent Desnogues
On Sun, Mar 9, 2014 at 4:10 PM, Peter Maydell wrote: > From: Alex Bennée > > rn == 31 always means SP (not XZR) whether an add_sub_ext > instruction is setting the flags or not; only rd has behaviour > dependent on whether we are setting flags. > > Reported-by: Laurent Desnogues > Signed-off-by:

Re: [Qemu-devel] SMBIOS vs. NUMA (was: Build full type 19 tables)

2014-03-13 Thread Gerd Hoffmann
> > | Type16 0x1000 | > > ^ ^ ^ ^

[Qemu-devel] [Bug 1289898] Re: qemu-system-ppc64 easily cause file corruption

2014-03-13 Thread wzis
and lots of dependency issue . -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1289898 Title: qemu-system-ppc64 easily cause file corruption Status in QEMU: New Bug description: the qemu-system

[Qemu-devel] [PATCH v6] spapr-vfio: add spapr-pci-vfio-host-bridge to support vfio

2014-03-13 Thread Alexey Kardashevskiy
The patch adds a spapr-pci-vfio-host-bridge device type which is a PCI Host Bridge with VFIO support. The new device inherits from the spapr-pci-host-bridge device and adds the following properties: iommu - IOMMU group ID which represents a Partitionable Endpoint, QEMU/ppc64

[Qemu-devel] [Bug 1280961] Re: editing the file when mount the file system using 9pfs. it will report fsync failed.

2014-03-13 Thread chchen
resovled it, this is because in the kernel 2.6.32; the 9pfs doesn't implement the fsync function. just back port the code from higher version, can resolve it. like this patch https://gitorious.org/linux- gemini/mainline/commit/7a4439c406c21b1e900ed497cec1a79d05b38c07 ** Changed in: qemu As

Re: [Qemu-devel] [PATCH 0/4] vga: new display devices

2014-03-13 Thread Gerd Hoffmann
> +-->IS_PCI_VGA (Pci): > | "Found PCI VGA device" > > +k->class_id = PCI_CLASS_DISPLAY_OTHER; > > and from qemu's "include/hw/pci/pci_ids.h": > > > #define PCI_CLASS_DISPLAY_VGA0x0300 > > #define PCI_CLASS_DISPLAY_OTHER 0x0380 > > I think th

Re: [Qemu-devel] [PATCH 0/4] vga: new display devices

2014-03-13 Thread Laszlo Ersek
On 03/13/14 09:22, Gerd Hoffmann wrote: >> +-->IS_PCI_VGA (Pci): >> | "Found PCI VGA device" > >>> +k->class_id = PCI_CLASS_DISPLAY_OTHER; >> >> and from qemu's "include/hw/pci/pci_ids.h": >> >>> #define PCI_CLASS_DISPLAY_VGA0x0300 >>> #define PCI_CLASS_

[Qemu-devel] [Bug 1256546] Re: qemu-s390x-static: segmentation fault entering chroot

2014-03-13 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1256546 Title: qemu-s390x-static: segmentation fault entering chroot Status

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-13 Thread Gerd Hoffmann
Hi, > One thing to do is add this to the virtio spec. > Need help with that? What is the authoritative spec these days? The virtio 1.0 draft? Where can I find the latest revision? Where should I send patches? > > docs/specs/virtio-gpu.txt | 89 + Some docs are here. cheers, G

[Qemu-devel] [PATCH for-2.0] qemu-iotests: remove 085 and 087 from 'quick' group

2014-03-13 Thread Stefan Hajnoczi
The 'quick' group in qemu-iotests are not allowed to run QEMU since we don't know which targets are available. In other words, they may only use qemu-img, qemu-io, and qemu-nbd. Drop 085 and 087 from the 'quick' group since they run QEMU. This makes "make check-block" pass again. Reported-by: M

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Fam Zheng
On Wed, 03/12 18:00, Markus Armbruster wrote: > Opening an encrypted image takes an additional step: setting the key. > Between open and the key set, the image must not be used. > > We have some protection against accidental use in place: you can't > unpause a guest while we're missing keys. You

Re: [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes

2014-03-13 Thread Paolo Bonzini
Il 13/03/2014 04:32, Alexey Kardashevskiy ha scritto: I am about to respin the series against the latest QOM stuff and I am about to change commit message in the "The benefit would be to QEMU in having simpler code" part - what part of QEMU gets simpler? I am avoiding fixing SLOF and I am fixing

[Qemu-devel] [PATCH 0/2] qtest: crash fix and improved "make check" output

2014-03-13 Thread Stefan Hajnoczi
These patches stem from the Marcel's discussion about qtest_init() failures. He posted the qtest_init() deadlock fix and I was picky about how to fix two other issues, so here are the patches. Stefan Hajnoczi (2): tests: show the name of each executing qtest qtest: fix crash if SIGABRT during

[Qemu-devel] [PATCH 1/2] tests: show the name of each executing qtest

2014-03-13 Thread Stefan Hajnoczi
When a qtest fails only the assertion failure is printed but you do not know which qtest binary was running: GTESTER check-qtest-x86_64 main-loop: WARNING: I/O thread spun for 1000 iterations blkdebug: Suspended request 'A' blkdebug: Resuming request 'A' check-qtest-x86_64 is actually a m

[Qemu-devel] [PATCH 2/2] qtest: fix crash if SIGABRT during qtest_init()

2014-03-13 Thread Stefan Hajnoczi
If an assertion fails during qtest_init() the SIGABRT handler is invoked. This is the correct behavior since we need to kill the QEMU process to avoid leaking it when the test dies. The global_qtest pointer used by the SIGABRT handler is currently only assigned after qtest_init() returns. This r

[Qemu-devel] [PULL 1/1] char: restore read callback on a reattached (hotplug) chardev

2014-03-13 Thread Gerd Hoffmann
From: Gal Hammer Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transferred from the host to the guest (e.g. via the virtio-serial port). https://bug

[Qemu-devel] [PULL for-2.0 0/1] char: restore read callback on a reattached (hotplug) chardev

2014-03-13 Thread Gerd Hoffmann
Hi, Bugfix for chardev hotplug. please pull, Gerd The following changes since commit 239618707637ec87eba8c452d2b2f75dc5ca20c7: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-03-11 19:39:17 +) are available in the git repository at: git://git.kraxel.org/q

[Qemu-devel] [PULL for-2.0 0/2] input: two more fixes

2014-03-13 Thread Gerd Hoffmann
Hi, Two more input bugfixes. Well, the gtk wheel support could be considered a new feature. On top of the input layer rewrite it is pretty simple and straight forward patch, so I think it is fine for 2.0 nevertheless. please pull, Gerd The following changes since commit 239618707637ec87eba

[Qemu-devel] [PULL 1/2] input: activate legacy kbd

2014-03-13 Thread Gerd Hoffmann
Restores traditional behavior: Keyboard input will be routed to the most recently added keyboard. Without this all kbd input goes to the ps/2 keyboard, even if you add a usb keyboard to your guest. Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 1 + 1 file changed, 1 insertion(+) diff -

[Qemu-devel] [PULL 2/2] gtk: Add mouse wheel support

2014-03-13 Thread Gerd Hoffmann
From: Jan Kiszka Hook into scroll-event to properly forward mouse wheel movements to the guest, just like we already do in SDL. Signed-off-by: Jan Kiszka Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c

Re: [Qemu-devel] [PATCH 3/4] virtio-gpu: v0.3 of the virtio based GPU code.

2014-03-13 Thread Paolo Bonzini
Il 12/03/2014 21:26, Michael S. Tsirkin ha scritto: +Event queue: +The only current event passed is a message to denote the host +wants to update the layout of the screens. It contains the same +info as the response to VIRTGPU_CMD_GET_DISPLAY_INFO. I wonder if an event queue is the best mechani

Re: [Qemu-devel] [PULL 1/1] char: restore read callback on a reattached (hotplug) chardev

2014-03-13 Thread Paolo Bonzini
Il 13/03/2014 11:31, Gerd Hoffmann ha scritto: From: Gal Hammer Fix a bug that was introduced in commit 386a5a1e. A removal of a device set the chr handlers to NULL. However when the device is plugged back, its read callback is not restored so data can't be transferred from the host to the gues

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Paolo Bonzini
Il 12/03/2014 18:00, Markus Armbruster ha scritto: +} else if (!runstate_check(RUN_STATE_PRELAUNCH) +&& !runstate_check(RUN_STATE_PAUSED)) { /* HACK */ Why not "if (runstate_is_running())"? Paolo +error_setg(errp, + "Guest must be stopped for opening

[Qemu-devel] [PULL 0/7] gtk: cleanups and fixes

2014-03-13 Thread Gerd Hoffmann
Hi, Looks like I've became the default victim for gtk patches, with anthony being busy and /me recently picking up the gtk mouse wheel patch. So here is a collection of gtk patches hitting my inbox over the last few days. Not strictly bugfixes-only, but the cleanups are simple enouth that I th

[Qemu-devel] [PULL 1/7] gtk: Allow to activate grab-on-hover from the command line

2014-03-13 Thread Gerd Hoffmann
From: Jan Kiszka As long as we have no persistent GTK configuration, this allows to enable the useful grab-on-hover feature already when starting the VM. Signed-off-by: Jan Kiszka Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 +- qemu-options.hx | 5 + ui/gtk.c

[Qemu-devel] [PULL 2/7] gtk: Don't use deprecated gtk_image_menu_item_new_with_mnemonic

2014-03-13 Thread Gerd Hoffmann
From: Cole Robinson In these cases we weren't using an image in the menu item anyways, so just do as the suggestion says. Should be fine for all qemu supported gtk versions. ui/gtk.c: In function ‘gd_create_menu_machine’: ui/gtk.c:1284:5: error: ‘gtk_image_menu_item_new_with_mnemonic’ is depreca

[Qemu-devel] [PULL 7/7] gtk: Don't warp absolute pointer

2014-03-13 Thread Gerd Hoffmann
From: Cole Robinson This matches the behavior of SDL, and makes the mouse usable when using -display gtk -vga qxl https://bugzilla.redhat.com/show_bug.cgi?id=1051724 Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 8 1 file changed, 8 insertions(+) diff --gi

[Qemu-devel] [PULL 3/7] gtk: Don't use deprecated vte_terminal_get_adjustment

2014-03-13 Thread Gerd Hoffmann
From: Cole Robinson Guard this with a VTE version check, since I'm not sure if this is backwards compatible. ui/gtk.c: In function ‘gd_vc_init’: ui/gtk.c:1176:5: error: ‘vte_terminal_get_adjustment’ is deprecated (declared at /usr/include/vte-2.90/vte/vtedeprecated.h:101) [-Werror=deprecated-d

[Qemu-devel] [PULL 6/7] gtk: Fix mouse warping with gtk3

2014-03-13 Thread Gerd Hoffmann
From: Cole Robinson We were using the wrong coordinates, this fixes things to match the original gtk2 implementation. You can see this error in action by using -vga qxl, however even after this patch the mouse warps in small increments up and to the left, -7x and -3y pixels at a time, until the

[Qemu-devel] [PULL 5/7] gtk: Use ctrl+alt+q for quit accelerator

2014-03-13 Thread Gerd Hoffmann
From: Cole Robinson Using the standard ctrl+q makes it too easy to kill the whole VM. Using ctrl+alt+FOO is consistent with our other accelerators. https://bugzilla.redhat.com/show_bug.cgi?id=1062393 Signed-off-by: Cole Robinson Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 2 +- 1 file changed

[Qemu-devel] [PULL 4/7] gtk: Remove use of deprecated stock items

2014-03-13 Thread Gerd Hoffmann
From: Cole Robinson Stock items are deprecated. As are ImageMenuItems. Convert everything to text only MenuItems, with the same text content as mentioned in the conversion guide: https://docs.google.com/spreadsheet/pub?key=0AsPAM3pPwxagdGF4THNMMUpjUW5xMXZfdUNzMXhEa2c&output=html gtk2 users lose

Re: [Qemu-devel] [RFC PATCH v2] kvm: x86: ignore ioapic polarity

2014-03-13 Thread Paolo Bonzini
Il 28/02/2014 05:06, Gabriel L. Somlo ha scritto: > +NOTE: For each level-triggered interrupt managed by a virtual ioapic, > +the guest OS may set a polarity value (bit 13 of each corresponding I/O > +redirection table register). The polarity bit defines the relationship > +between an irq line's lo

[Qemu-devel] Question in savevm.c

2014-03-13 Thread Veronia Bahaa
Hello, i need help in understanding the qemu_loadvm_state function 1- I don't get what QEMU_SECTION_START, FULL, END, PART are. I know they are hexadecimal numbers but i don't get the meaning. 2- what's the difference between LoadStateEntry and SaveStateEntry? Thanks!

Re: [Qemu-devel] [PATCH 2/2] qtest: fix crash if SIGABRT during qtest_init()

2014-03-13 Thread Marcel Apfelbaum
On Thu, 2014-03-13 at 10:41 +0100, Stefan Hajnoczi wrote: > If an assertion fails during qtest_init() the SIGABRT handler is > invoked. This is the correct behavior since we need to kill the QEMU > process to avoid leaking it when the test dies. > > The global_qtest pointer used by the SIGABRT ha

Re: [Qemu-devel] [PATCH 0/2] qtest: crash fix and improved "make check" output

2014-03-13 Thread Marcel Apfelbaum
On Thu, 2014-03-13 at 10:41 +0100, Stefan Hajnoczi wrote: > These patches stem from the Marcel's discussion about qtest_init() failures. > He posted the qtest_init() deadlock fix and I was picky about how to fix two > other issues, so here are the patches. Tested-by: Marcel Apfelbaum > > Stefan

Re: [Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch queue 2014-03-12

2014-03-13 Thread Peter Maydell
On 13 March 2014 00:27, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue. Please pull. > > v2 changes qom-test. No, this is still broken: /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In function ‘qmp’: /home/petmay01/linaro/qemu-for-merges/tests/libqtest.h:

[Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions

2014-03-13 Thread Peter Maydell
Older versions of gcc (eg 4.6) can't handle varargs functions declared inline for anything other than completely trivial uses, and complain: tests/qom-test.c: In function 'qmp': tests/libqtest.h:359:60: sorry, unimplemented: function 'qmp' can never be inlined because it uses variable argument lis

Re: [Qemu-devel] [PATCH v22 01/25] add def_value_str to QemuOptDesc

2014-03-13 Thread Stefan Hajnoczi
On Thu, Mar 13, 2014 at 10:46:45AM +0800, Chunyan Liu wrote: > 2014-03-12 16:27 GMT+08:00 Stefan Hajnoczi : > > > On Wed, Mar 12, 2014 at 10:45:57AM +0800, Chunyan Liu wrote: > > > 2014-03-11 21:29 GMT+08:00 Stefan Hajnoczi : > > > > > > > On Mon, Mar 10, 2014 at 03:31:37PM +0800, Chunyan Liu wrot

Re: [Qemu-devel] Question in savevm.c

2014-03-13 Thread Peter Maydell
On 13 March 2014 11:05, Veronia Bahaa wrote: > Hello, i need help in understanding the qemu_loadvm_state function > 1- I don't get what QEMU_SECTION_START, FULL, END, PART are. I know they are > hexadecimal numbers but i don't get the meaning. They're part of the file/stream format for migration

Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions

2014-03-13 Thread Andreas Färber
Am 13.03.2014 12:31, schrieb Peter Maydell: > Older versions of gcc (eg 4.6) can't handle varargs functions declared > inline for anything other than completely trivial uses, and complain: > > tests/qom-test.c: In function 'qmp': tests/libqtest.h:359:60: sorry, > unimplemented: function 'qmp' can

Re: [Qemu-devel] [PATCH v2 0/3] nbd: fix issues when connection breaks

2014-03-13 Thread Stefan Hajnoczi
On Wed, Mar 12, 2014 at 07:01:34PM +0100, Paolo Bonzini wrote: > Il 12/03/2014 10:17, Stefan Hajnoczi ha scritto: > >On Wed, Feb 26, 2014 at 03:30:17PM +0100, Stefan Hajnoczi wrote: > >>v2: > >> * Use qemu-iotests 083 test number to avoid conflicts [kwolf] > >> * Test class negotiation without expo

Re: [Qemu-devel] [PULL 00/24] Block patches for QEMU 2.0

2014-03-13 Thread Stefan Hajnoczi
On Wed, Mar 12, 2014 at 03:48:16PM +, Peter Maydell wrote: > On 12 March 2014 10:29, Stefan Hajnoczi wrote: > > > > The following changes since commit b304bf0021a2dfb24fa91f704a1d976b74f56f20: > > > > s390/kvm: Add Maintainers for s390/kvm (2014-03-10 16:43:11 +) > > > > are available in

Re: [Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch queue 2014-03-12

2014-03-13 Thread Andreas Färber
Am 13.03.2014 12:22, schrieb Peter Maydell: > On 13 March 2014 00:27, Andreas Färber wrote: >> Hello Peter, >> >> This is my QOM (devices) patch queue. Please pull. >> >> v2 changes qom-test. > > No, this is still broken: > /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In function ‘qmp’

Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions

2014-03-13 Thread Peter Maydell
On 13 March 2014 12:31, Andreas Färber wrote: > Am 13.03.2014 12:31, schrieb Peter Maydell: >> Older versions of gcc (eg 4.6) can't handle varargs functions declared >> inline for anything other than completely trivial uses, and complain: >> >> tests/qom-test.c: In function 'qmp': tests/libqtest.h

Re: [Qemu-devel] [PATCH] Avoiding extra iterations while closing file fd

2014-03-13 Thread Stefan Hajnoczi
On Wed, Mar 12, 2014 at 10:24:27PM +0530, Pankaj Gupta wrote: > Avoiding iterations for fd 0, 1 & 2 when we are closing file fds in child > process. > > Signed-off-by: Pankaj Gupta > --- > net/tap.c | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) POSIX defines the value

Re: [Qemu-devel] [PATCH 2/2] qtest: fix crash if SIGABRT during qtest_init()

2014-03-13 Thread Stefan Hajnoczi
On Thu, Mar 13, 2014 at 01:07:05PM +0200, Marcel Apfelbaum wrote: > On Thu, 2014-03-13 at 10:41 +0100, Stefan Hajnoczi wrote: > > If an assertion fails during qtest_init() the SIGABRT handler is > > invoked. This is the correct behavior since we need to kill the QEMU > > process to avoid leaking i

[Qemu-devel] different IDTs of the same VCPU

2014-03-13 Thread Alexander Binun
Dear Friends, Thanks for your assistance! We would like to ask you a question about the KVM internals. Our module includes a timer which (once in every second) fetches the IDT value of every online VCPU in the system using the kvm_x86_ops->get_idt ; the code looks like: struct kvm_vc

Re: [Qemu-devel] [PULL 01/12] util: Split out exec_dir from os_find_datadir

2014-03-13 Thread Andreas Färber
Am 20.02.2014 13:28, schrieb Paolo Bonzini: > From: Fam Zheng > > With this change, main() calls qemu_init_exec_dir and uses argv[0] to > init exec_dir. The saved value can be retrieved with > qemu_get_exec_dir later. It will be reused by module loading. > > Signed-off-by: Fam Zheng > Signed-of

Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions

2014-03-13 Thread Tom Musta
On 3/12/2014 5:40 PM, Richard Henderson wrote: > On 03/10/2014 12:04 PM, Tom Musta wrote: >> This patch series addresses concerns raised by Richard Henderson regarding >> redundant >> copies of Advanced Encryption Standard (AES) data and code (see >> http://lists.nongnu.org/archive/html/qemu-devel

Re: [Qemu-devel] [PATCH v2 1/9] qapi: Add optional field "name" to block dirty bitmap

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:30:56 (+0800), Fam Zheng wrote : > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes c

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Markus Armbruster
Paolo Bonzini writes: > Il 12/03/2014 18:00, Markus Armbruster ha scritto: >> +} else if (!runstate_check(RUN_STATE_PRELAUNCH) >> +&& !runstate_check(RUN_STATE_PAUSED)) { /* HACK */ > > Why not "if (runstate_is_running())"? The predicate actually wanted here is "monitor command '

Re: [Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch queue 2014-03-12

2014-03-13 Thread Peter Maydell
On 13 March 2014 00:27, Andreas Färber wrote: > Hello Peter, > > This is my QOM (devices) patch queue. Please pull. > > v2 changes qom-test. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Anthony Liguori > > Cc: Markus Armbruster > Cc: Peter Crosthwaite > Cc: Alexander Graf > Cc: Stefan H

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 03/12 18:00, Markus Armbruster wrote: >> Opening an encrypted image takes an additional step: setting the key. >> Between open and the key set, the image must not be used. >> >> We have some protection against accidental use in place: you can't >> unpause a guest whil

Re: [Qemu-devel] [PATCH v2 2/9] qmp: Add dirty-bitmap-add and dirty-bitmap-remove

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:30:57 (+0800), Fam Zheng wrote : > The new command pair is added to manage user created dirty bitmap. The > dirty bitmap's name is mandatory and must be unique for the same device, > but different devices can have bitmaps with the same names. > > Signed-off-by: Fam Z

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Eric Blake
On 03/13/2014 04:43 AM, Paolo Bonzini wrote: > Il 12/03/2014 18:00, Markus Armbruster ha scritto: >> +} else if (!runstate_check(RUN_STATE_PRELAUNCH) >> +&& !runstate_check(RUN_STATE_PAUSED)) { /* HACK */ > > Why not "if (runstate_is_running())"? Because that lacks PRELAUNCH, but

[Qemu-devel] [PATCH buildfix] oslib-posix: Fix build on FreeBSD

2014-03-13 Thread Andreas Färber
Commit 10f5bff622cad71645e22c027b77ac31e51008ef (util: Split out exec_dir from os_find_datadir) moved code from os-posix.c to util/oslib-posix.c but forgot to move a FreeBSD #include alongside, needed for CTL_KERN among others. Cc: Fam Zheng Cc: Paolo Bonzini Signed-off-by: Andreas Färber ---

Re: [Qemu-devel] [PATCH v2 3/9] block: Handle error of bdrv_getlength in bdrv_create_dirty_bitmap

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:30:58 (+0800), Fam Zheng wrote : > bdrv_getlength could fail, check the return value before using it. > > Signed-off-by: Fam Zheng > --- > block.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index ce48fff..9de

Re: [Qemu-devel] [PATCH v2 4/9] block: Introduce bdrv_dirty_bitmap_granularity()

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:30:59 (+0800), Fam Zheng wrote : > This returns the granularity (in sectors) of dirty bitmap. > > Signed-off-by: Fam Zheng > --- > block.c | 6 ++ > include/block/block.h | 2 ++ > 2 files changed, 8 insertions(+) > > diff --git a/block.c b/block

Re: [Qemu-devel] [PATCH] hw/i386: Use unaligned store functions building acpi tables

2014-03-13 Thread Richard Henderson
On 03/12/2014 04:26 PM, Peter Maydell wrote: > On 12 March 2014 22:25, Richard Henderson wrote: >> Hosts that don't support native unaligned stores will SIGBUS >> without additional help. >> >> Signed-off-by: Richard Henderson >> --- >> hw/i386/acpi-build.c | 29 +++-- >>

[Qemu-devel] [PULL 00/02] seccomp: adding new syscalls to the whitelist

2014-03-13 Thread Eduardo Otubo
The following changes since commit 750036a848ea913ba6343718ffa70da98f7eef6b: Merge remote-tracking branch 'remotes/afaerber/tags/prep-for-upstream' into staging (2014-03-12 17:53:37 +) are available in the git repository at: git://github.com/otubo/qemu.git seccomp Felix Geyer (1):

[Qemu-devel] [PULL 02/02] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist

2014-03-13 Thread Eduardo Otubo
From: Paul Moore Additional testing reveals that PulseAudio requires shmctl() and the mlock()/munlock() syscalls on some systems/configurations. As before, on systems that do require these syscalls, the problem can be seen with the following command line: # qemu -monitor stdio -sandbox on \

[Qemu-devel] [PULL 01/02] seccomp: add timerfd_create and timerfd_settime to the whitelist

2014-03-13 Thread Eduardo Otubo
From: Felix Geyer libusb calls timerfd_create() and timerfd_settime() when it's built with timerfd support. Command to reproduce: -device usb-host,hostbus=1,hostaddr=3,id=hostdev0 Log messages: audit(1390730418.924:135): auid=4294967295 uid=121 gid=103 ses=4294967295

Re: [Qemu-devel] [PATCH v2 5/9] hbitmap: Add hbitmap_copy

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:31:00 (+0800), Fam Zheng wrote : > This makes a deep copy of an HBitmap. > > Signed-off-by: Fam Zheng > --- > include/qemu/hbitmap.h | 8 > util/hbitmap.c | 13 + > 2 files changed, 21 insertions(+) > > diff --git a/include/qemu/hbitmap

Re: [Qemu-devel] [RFC PATCH v2] kvm: x86: ignore ioapic polarity

2014-03-13 Thread Gabriel L. Somlo
On Thu, Mar 13, 2014 at 11:53:04AM +0100, Paolo Bonzini wrote: > Instead of this, I'm adding the following to the KVM_IRQ_LINE ioctl: > > +On real hardware, interrupt pins can be active-low or active-high. This > +does not matter for the level field of struct kvm_irq_level: 1 always > +means acti

Re: [Qemu-devel] [PATCH v2 7/9] qmp: Add dirty-bitmap-enable and dirty-bitmap-disable

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:31:02 (+0800), Fam Zheng wrote : > This allows to put the dirty bitmap into a disabled state where no more > writes will be tracked. > > It will be used before backup or writing to persistent file. > > Signed-off-by: Fam Zheng > --- > block.c | 15 ++

[Qemu-devel] [Question] unexpected block during RDMA migration

2014-03-13 Thread Wangyufei (James)
Hello, Recently I did a test like this: 1. I have host A and host B. I set ib0 on host A 192.168.0.1, I set ib0 on host B 192.168.0.2. 2. I start a guestOS C on host A, and I do a RDMA migration from host A to host B. 3. During the RDMA migration, I make host B power off(It simula

[Qemu-devel] [PULL v2 for-2.0 00/24] Block patches

2014-03-13 Thread Stefan Hajnoczi
v2: * Fixed merge conflict with qemu_thread_create() naming [Peter] The following changes since commit 750036a848ea913ba6343718ffa70da98f7eef6b: Merge remote-tracking branch 'remotes/afaerber/tags/prep-for-upstream' into staging (2014-03-12 17:53:37 +) are available in the git repository

[Qemu-devel] [PULL v2 for-2.0 01/24] qcow2-refcount: Sanitize refcount table entry

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz When reading the refcount table entry in get_refcount(), only bits which are actually significant for the refcount block offset should be taken into account. Signed-off-by: Max Reitz Reviewed-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 3 ++-

[Qemu-devel] [PULL v2 for-2.0 03/24] qcow2: Check bs->drv in copy_sectors()

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz Before dereferencing bs->drv for a call to its member bdrv_co_readv(), copy_sectors() should check whether that pointer is indeed valid, since it may have been set to NULL by e.g. a concurrent write triggering the corruption prevention mechanism. Signed-off-by: Max Reitz Signed-

[Qemu-devel] [PULL v2 for-2.0 07/24] object: add object_get_canonical_path_component()

2014-03-13 Thread Stefan Hajnoczi
It is often useful to find an object's child property name. Also use this new function to simplify the implementation of object_get_canonical_path(). Reviewed-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- include/qom/object.h | 8 qom/object.c | 54 +++

[Qemu-devel] [PULL v2 for-2.0 02/24] block: Update image size in bdrv_invalidate_cache()

2014-03-13 Thread Stefan Hajnoczi
From: Kevin Wolf After migration has completed, we call bdrv_invalidate_cache() so that drivers which cache some data drop their stale copy of the data and reread it from the image file to get a new version of data that the source modified while the migration was running. Reloading metadata from

[Qemu-devel] [PULL v2 for-2.0 12/24] iothread: add "iothread" qdev property type

2014-03-13 Thread Stefan Hajnoczi
Add a "iothread" qdev property type so devices can be hooked up to an IOThread from the comand-line: qemu -object iothread,id=iothread0 \ -device some-device,x-iothread=iothread0 Note that Paolo Bonzini has suggested using QOM links instead. This way the relationship between the object

[Qemu-devel] [PULL v2 for-2.0 22/24] block/raw-posix: bdrv_parse_filename() for cdrom

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz The "host_cdrom" protocol drivers should strip the "host_cdrom:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/bloc

[Qemu-devel] [PULL v2 for-2.0 09/24] aio: add aio_context_acquire() and aio_context_release()

2014-03-13 Thread Stefan Hajnoczi
It can be useful to run an AioContext from a thread which normally does not "own" the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all requests have been completed. The following pattern should work: /* Event loop thread

[Qemu-devel] [PULL v2 for-2.0 06/24] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-13 Thread Stefan Hajnoczi
From: Benoît Canet This patch keep the recursive way of doing things but simplify it by giving two responsabilities to all block filters implementors. They will need to do two things: -Set the is_filter field of their block driver to true. -Implement the bdrv_recurse_is_first_non_filter method

[Qemu-devel] [PULL v2 for-2.0 19/24] qemu-io: Fix warnings from static code analysis

2014-03-13 Thread Stefan Hajnoczi
From: Stefan Weil Smatch complains about several global symbols which should be local. Add the missing 'static' attributes and move the 'extern' declaration of variable qemuio_misalign to qemu-io.h. This variable also changes the type from 'int' to 'bool' which better fits documents its use. Si

[Qemu-devel] [PULL v2 for-2.0 11/24] qdev: make get_pointer() handle temporary strings

2014-03-13 Thread Stefan Hajnoczi
From: Igor Mammedov get_pointer()'s print() callback might return a heap allocated string, to avoid adding dedicated get_pointer_foo for this case convert current print() callbacks to return temporary heap allocated string and make get_pointer() free it. Reviewed-by: Andreas Färber Signed-off-b

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Paolo Bonzini
Il 13/03/2014 14:27, Eric Blake ha scritto: >> +} else if (!runstate_check(RUN_STATE_PRELAUNCH) >> +&& !runstate_check(RUN_STATE_PAUSED)) { /* HACK */ > > Why not "if (runstate_is_running())"? Because that lacks PRELAUNCH, but PRELAUNCH also needs the protection. Nope, PRELAUN

[Qemu-devel] [PULL v2 for-2.0 24/24] block/raw-win32: bdrv_parse_filename() for hdev

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz The "host_device" protocol driver should strip the "host_device:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-win32.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/ra

[Qemu-devel] [PULL v2 for-2.0 04/24] block: bs->drv may be NULL in bdrv_debug_resume()

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz Currently, bdrv_debug_resume() requires every bs->drv in the BDS stack to be NULL until a bs->drv with an implementation of bdrv_debug_resume() is found. For a normal function, this would be fine, but this is a function for debugging purposes and should therefore allow intermediat

[Qemu-devel] [PULL v2 for-2.0 20/24] block/raw-posix: bdrv_parse_filename() for hdev

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz The "host_device" protocol driver should strip the "host_device:" prefix from filenames if present. Signed-off-by: Max Reitz Reviewed-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/ra

[Qemu-devel] [V2 PATCH 1/6] util: Add S-Box and InvS-Box Arrays to Common AES Utils

2014-03-13 Thread Tom Musta
This patch adds tables for the S-Box and InvS-Box transformations commonly used by various Advanced Encription Standard (AES) instruction models. Signed-off-by: Tom Musta Reviewed-by: Richard Henderson --- include/qemu/aes.h |3 ++ util/aes.c | 70

[Qemu-devel] [V2 PATCH 3/6] util: Add InvMixColumns

2014-03-13 Thread Tom Musta
This patch adds the table implementation of the Advanced Encryption Standard (AES) InvMixColumns transformation. The patch is intentionally asymmetrical -- the MixColumns table is not added because there is no known use for it at this time. Signed-off-by: Tom Musta Reviewed-by: Richard Henders

[Qemu-devel] [PULL v2 for-2.0 13/24] dataplane: replace internal thread with IOThread

2014-03-13 Thread Stefan Hajnoczi
Today virtio-blk dataplane uses a 1:1 device-per-thread model. Now that IOThreads have been introduced we can generalize this to N:M devices per threads. This patch drops thread code from dataplane in favor of running inside an IOThread AioContext. As a bonus we solve the case where a guest keep

[Qemu-devel] [V2 PATCH 4/6] target-i386: Use Common ShiftRows and InvShiftRows Tables

2014-03-13 Thread Tom Musta
This patch eliminates the (now) redundant copy of the Advanced Encryption Standard (AES) ShiftRows and InvShiftRows tables; the code is updated to use the common tables declared in include/qemu/aes.h. Signed-off-by: Tom Musta Reviewed-by: Richard Henderson --- target-i386/ops_sse.h | 32 +++

[Qemu-devel] [PULL v2 for-2.0 23/24] block/raw-posix: Strip protocol prefix on creation

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz The hdev_create() implementation in block/raw-posix.c is used by the "host_device", "host_cdrom" and "host_floppy" protocol block drivers together. Thus, any of the associated prefixes may occur and exactly one should should be stripped, if it does (thus, "host_device:host_cdrom:/

Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused

2014-03-13 Thread Paolo Bonzini
Il 13/03/2014 14:18, Markus Armbruster ha scritto: > Paolo Bonzini writes: > >> Il 12/03/2014 18:00, Markus Armbruster ha scritto: >>> +} else if (!runstate_check(RUN_STATE_PRELAUNCH) >>> +&& !runstate_check(RUN_STATE_PAUSED)) { /* HACK */ >> >> Why not "if (runstate_is_running())

[Qemu-devel] [V2 PATCH 5/6] target-arm: Use Common Tables in AES Instructions

2014-03-13 Thread Tom Musta
This patch refactors the ARM cryptographic instructions to use the (newly) added common tables from include/qemu/aes.h. Signed-off-by: Tom Musta Reviewed-by: Richard Henderson --- V2: corrected sbox definition to be constant pointer to constant per Richard Henderson's review. target-arm/crypto

[Qemu-devel] [V2 PATCH 6/6] target-ppc: Refactor AES Instructions

2014-03-13 Thread Tom Musta
This patch refactors the PowerPC Advanced Encryption Standard (AES) instructions to use the common AES tables (include/qemu/aes.h). Specifically: - vsbox is recoded to use the AES_sbox table. - vcipher, vcipherlast and vncipherlast are all recoded to use the optimized AES_t[ed][0-4]

Re: [Qemu-devel] [PATCH] main-loop: Suppress "I/O thread spun" warnings for qtest

2014-03-13 Thread Andreas Färber
Am 13.03.2014 15:17, schrieb Peter Maydell: > When running under qtest we don't actually have any vcpu threads > to be starved, so the warning about the I/O thread spinning isn't > relevant, and the way qtest manipulates the simulated clock means > the warning is produced a lot as a false positive.

Re: [Qemu-devel] [PATCH v2 8/9] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2014-03-13 Thread Benoît Canet
The Wednesday 12 Mar 2014 à 14:31:03 (+0800), Fam Zheng wrote : > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. >

[Qemu-devel] [V2 PATCH 0/6] Refactor AES Instructions

2014-03-13 Thread Tom Musta
This patch series addresses concerns raised by Richard Henderson regarding redundant copies of Advanced Encryption Standard (AES) data and code (see http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). The patches declare commonly used AES tables in the include/qemu/aes.h heade

[Qemu-devel] [PULL v2 for-2.0 15/24] qmp: add query-iothreads command

2014-03-13 Thread Stefan Hajnoczi
The "query-iothreads" command returns a list of information about iothreads. See the patch for API documentation. Reviewed-by: Eric Blake Signed-off-by: Stefan Hajnoczi --- iothread.c | 36 qapi-schema.json | 29 + qmp-comm

Re: [Qemu-devel] [PATCH v2 5/9] hbitmap: Add hbitmap_copy

2014-03-13 Thread Paolo Bonzini
Il 13/03/2014 14:45, Benoît Canet ha scritto: This feel wrong: struct HBitmap { /* Number of total bits in the bottom level. */ uint64_t size; The comment about size imply that size apply only to the bottom level. Moreover the bitmaps are progressivelly less coarse so I think the size

[Qemu-devel] [PULL v2 for-2.0 18/24] block: Unlink temporary file

2014-03-13 Thread Stefan Hajnoczi
From: Max Reitz If the image file cannot be opened and was created as a temporary file, it should be deleted; thus, in this case, we should jump to the "unlink_and_fail" label and not just to "fail". Reported-by: Benoît Canet Signed-off-by: Max Reitz Acked-by: Stefan Hajnoczi Signed-off-by: S

[Qemu-devel] [PULL v2 for-2.0 16/24] qcow2: Keep option in qcow2_invalidate_cache()

2014-03-13 Thread Stefan Hajnoczi
From: Kevin Wolf Instead of manually building a list of all options from BDRVQcowState values just reuse the options that were used to open the image. qcow2_open() won't fully use all of the options in the QDict, but that's okay. This fixes all of the driver-specific options in qcow2, except for

Re: [Qemu-devel] [PULL for-2.0-rc0 0/6] PowerPC patch queue 2014-03-13

2014-03-13 Thread Peter Maydell
On 13 March 2014 02:53, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC queue into qemu.git master. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Cc: Alexander Graf > Cc: Alexey Kardashevskiy > Cc: Paolo Bonzini > > The following changes since commit

[Qemu-devel] Building QMP in qemu-nbd

2014-03-13 Thread Benoît Canet
Hi, I want to make qemu-nbd QMP aware so the cloud stack my customer work on could start lxc containers with qcow2 KVM images and still benefit from the quorum and snapshot goodness. Stefan mentioned the nice idea of splitting qapi-schema.json in small files in a subdirectory so qemu-nbd could u

  1   2   3   >