[Qemu-devel] Disk I/O in QEMU

2014-03-11 Thread Le Tan
Hi, I am now studying the disk I/O in QEMU, but I know little about QEMU. I want to know how QEMU implements or emulates the disk I/O? Where to find some materials about this? And if I can get all the disk I/O request from the guest in QEMU? Thanks!

Re: [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands.

2014-03-11 Thread Hani Benhabiles
On Mon, Mar 10, 2014 at 10:44:45AM -0400, Luiz Capitulino wrote: > On Sun, 9 Mar 2014 12:16:10 +0100 > Hani Benhabiles wrote: > > > This patch series adds a new callback to mon_cmd_t which will make adding > > completion support for more commands cleaner. > > > > It then adds full or partial ar

Re: [Qemu-devel] [PATCH v22 03/25] improve some functions in qemu-option.c

2014-03-11 Thread Chunyan Liu
2014-03-11 5:21 GMT+08:00 Eric Blake : > On 03/10/2014 02:29 PM, Eric Blake wrote: > > >> +opt = qemu_opt_find(opts, name); > >> +if (opt) { > >> +g_free((char *)opt->str); > > > > ...which means the cast is pointless here. > > > > Hmm. This means that you are giving opt_set() the

Re: [Qemu-devel] [PATCH v2 4/5] w32: Replace Windows specific data types in common header files

2014-03-11 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 7:34 PM, Stefan Weil wrote: > Am 10.03.2014 16:17, schrieb Stefan Hajnoczi: >> On Fri, Mar 07, 2014 at 11:17:46PM +0100, Stefan Weil wrote: >>> diff --git a/include/qemu/thread-win32.h b/include/qemu/thread-win32.h >>> index 7ade61a..b8b8e61 100644 >>> --- a/include/qemu/th

Re: [Qemu-devel] [PATCH 2.1 17/28] memory: move mem_path handling to memory_region_allocate_system_memory

2014-03-11 Thread Paolo Bonzini
Il 11/03/2014 04:50, Hu Tao ha scritto: On Tue, Mar 04, 2014 at 03:00:45PM +0100, Paolo Bonzini wrote: Like the previous patch did in exec.c, split memory_region_init_ram and memory_region_init_ram_from_file, and push mem_path one step further up. Other RAM regions than system memory will now be

Re: [Qemu-devel] [PATCH v2 4/5] w32: Replace Windows specific data types in common header files

2014-03-11 Thread Paolo Bonzini
Il 10/03/2014 19:34, Stefan Weil ha scritto: As you noticed, the problem is include/qemu/thread.h which includes include/qemu/thread-win32.h to define QemuMutex. Unfortunately, QemuMutex is used by value in include/block/aio.h and in include/exec/cpu-all.h. Most QEMU files depend on these two fil

Re: [Qemu-devel] [PATCH v4 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-11 Thread Markus Armbruster
Eric Blake writes: > On 03/07/2014 02:54 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 03/05/2014 07:36 PM, Amos Kong wrote: vm_config_groups[] only contains part of the options which have argument, and all options which have no argument aren't added to vm_config_g

Re: [Qemu-devel] [PATCH] tests/qapi-schema: Fix enum misuse in flat union type tests

2014-03-11 Thread Markus Armbruster
Luiz Capitulino writes: > On Mon, 10 Mar 2014 15:54:50 +0100 > Markus Armbruster wrote: > >> Screwed up in commit 2fc0043. Currently harmless, because the enum >> values happen to be identical. > > I'm afraid this conflicts with Wenchao's series: > > [PATCH V9 00/10] qapi script: support enum

[Qemu-devel] [PATCH v6] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-11 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS synthetic instruction uses an ASI of 0x80. If TARGET_SPARC

[Qemu-devel] [PATCH v6] target-sparc: Add and use CPU_FEATURE_CASA

2014-03-11 Thread Sebastian Huber
v5: Fix two typos. Generate an IU instead of FPU exception in case CASA is not supported by the CPU. Define CASA feature for all SPARC64 CPUs (due to the #ifndef TARGET_SPARC64 it must go into the #else branch). v6: Move CHECK_IU_FEATURE(dc, CASA); in #ifndef TARGET_SPARC64 block since SPARC64 has

Re: [Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-11 Thread Mark Wu
On 03/10/2014 10:52 PM, Paolo Bonzini wrote: Il 10/03/2014 15:37, Mark Wu ha scritto: Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series, spapr_vga_i

Re: [Qemu-devel] [PATCH v3 2/2] Fix return value of vga initlization on ppc

2014-03-11 Thread Paolo Bonzini
Il 11/03/2014 10:52, Mark Wu ha scritto: Reviewed-by: Paolo Bonzini Thanks a lot for the review. You contributed a lot on this patch, but I forgot to acknowledge it in commit message. I think re-sending a new patch to include it could cause some noise. May I ask the maintainer add the follow

[Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()

2014-03-11 Thread Kevin Wolf
After migration has completed, we call bdrv_invalidate_cache() so that drivers which cache some data drop their stale copy of the data and reread it from the image file to get a new version of data that the source modified while the migration was running. Reloading metadata from the image file is

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-11 Thread Gerd Hoffmann
Hi, > On Thu, Mar 06, 2014 at 10:03:32AM +0100, Gerd Hoffmann wrote: > > So, if we manage to get the patches into shape in time for qemu 2.0 your > > way to do that is fine. We are pretty close to the 2.0 freeze though, > > so maybe we should better plan for post-2.0 anyway, especially as you >

[Qemu-devel] [PATCH V2 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
'socket_accept' waits for Qemu to init its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. Using a timeout for sockets fixes the issue. Signed-off-by: Marcel Apfelbaum --- tests/libqtest.c | 11 +-- 1 file

[Qemu-devel] [PATCH V2 0/2] tests: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
V1 -> V2: Addressed Stefan Hajnoczi's review: - Dropped qtest_state_valid API - Moved socket options in socket_accept. 'socket_accept' waits for Qemu to init its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication cha

[Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output.

2014-03-11 Thread Marcel Apfelbaum
From: Stefan Hajnoczi The effect is that the output will grow, but we will know which qtest failed. This helps when an asert is made on other code and not in the test itself. Signed-off-by: Stefan Hajnoczi Signed-off-by: Marcel Apfelbaum --- tests/Makefile | 2 +- 1 file changed, 1 insertion(

Re: [Qemu-devel] [PATCH 0/2] tests: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
On Mon, 2014-03-10 at 20:13 +0100, Stefan Hajnoczi wrote: > On Mon, Mar 10, 2014 at 05:21:17PM +0200, Marcel Apfelbaum wrote: > > On Mon, 2014-03-10 at 16:02 +0100, Stefan Hajnoczi wrote: > > > On Mon, Mar 10, 2014 at 02:12:12PM +0200, Marcel Apfelbaum wrote: > > > > 'socket_accept' waits for Qemu

Re: [Qemu-devel] [PATCH 0/3] qcow2: Fix crash during copy_sectors() after corruption

2014-03-11 Thread Kevin Wolf
Am 10.03.2014 um 23:44 hat Max Reitz geschrieben: > This series fixes a call to a NULL function pointer during > copy_sectors(), if a concurrent write request triggered the corruption > prevention mechanism. > > > Max Reitz (3): > qcow2: Check bs->drv in copy_sectors() > block: bs->drv may be

Re: [Qemu-devel] [PATCH 1/3] qcow2: Check bs->drv in copy_sectors()

2014-03-11 Thread Kevin Wolf
Am 11.03.2014 um 00:16 hat Laszlo Ersek geschrieben: > On 03/10/14 23:44, Max Reitz wrote: > > Before dereferencing bs->drv for a call to its member bdrv_co_readv(), > > copy_sectors() should check whether that pointer is indeed valid, since > > it may have been set to NULL by e.g. a concurrent wri

[Qemu-devel] [PULL 3/3] target-i386: bugfix of Intel MPX

2014-03-11 Thread Paolo Bonzini
From: "Liu, Jinsong" The correct size of cpuid 0x0d sub-leaf 4 is 0x40, not 0x10. This is confirmed by Anvin H Peter and Mallick Asit K. Signed-off-by: Liu Jinsong Cc: H. Peter Anvin Cc: Asit K Mallick Signed-off-by: Paolo Bonzini Signed-off-by: Liu, Jinsong --- target-i386/cpu.c | 2 +-

[Qemu-devel] [PULL 0/3] KVM uq/master changes for 2013-03-14

2014-03-11 Thread Paolo Bonzini
The following changes since commit 9fbee91a131a05e443d7108d7fbdf3ca91020290: Merge remote-tracking branch 'remotes/kvm/uq/master' into staging (2014-02-27 16:00:31 +) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for you to fetch

[Qemu-devel] [PULL 1/3] kvm-all: exit in case max vcpus exceeded

2014-03-11 Thread Paolo Bonzini
From: Marcelo Tosatti Rather than fall back to TCG (so the user has to discover whats happening, in case of no access to qemu stdout/stderr). Signed-off-by: Marcelo Tosatti Signed-off-by: Paolo Bonzini --- kvm-all.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kvm-all

[Qemu-devel] [PULL 2/3] file_ram_alloc: unify mem-path, mem-prealloc error handling

2014-03-11 Thread Paolo Bonzini
From: Marcelo Tosatti -mem-prealloc asks to preallocate memory residing on -mem-path path. Currently QEMU exits in case: - Memory file has been created but allocation via explicit write fails. And it fallbacks to malloc in case: - Querying huge page size fails. - Lack of sync MMU support. - Op

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Peter Maydell
On 10 March 2014 19:05, Michael S. Tsirkin wrote: > On Mon, Mar 10, 2014 at 03:38:11PM +, Peter Maydell wrote: >> On 9 March 2014 19:19, Michael S. Tsirkin wrote: >> > Changes from v2: >> > fix for OSx by Gabriel >> > fixed build on systems without IASL >> > >> > The following changes

[Qemu-devel] [RFC v3 0/3] prebuild cpu QOM tree /machine/node/socket/core ->link-cpu

2014-03-11 Thread chen.fan.fnst
From: "chen.fan.fnst" at present, after hotplug a discontinuous cpu id on source, then done migration, on target, it will fail to add the unoccupied cpu id which was skipped at source, this cause is on target Qemu prebuild CPU with continuous cpu_index. so after migration, the cpu infrastructure

[Qemu-devel] [RFC v3 1/3] cpu: introduce CpuTopoInfo structure for argument simplification

2014-03-11 Thread chen.fan.fnst
From: "chen.fan.fnst" Signed-off-by: Chen Fan --- target-i386/topology.h | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/target-i386/topology.h b/target-i386/topology.h index 07a6c5f..7843976 100644 --- a/target-i386/topology.h +++ b/targe

[Qemu-devel] [RFC v3 2/3] i386: use CpuTopoInfo instead apic_id as argument for pc_new_cpu()

2014-03-11 Thread chen.fan.fnst
From: "chen.fan.fnst" Signed-off-by: Chen Fan --- hw/i386/pc.c | 12 target-i386/cpu.c | 2 -- target-i386/cpu.h | 3 +++ 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e715a33..c754042 100644 --- a/hw/i386/pc.c +++ b/hw/i38

[Qemu-devel] [RFC v3 3/3] i386: introduce cpu QOM hierarchy tree

2014-03-11 Thread chen.fan.fnst
From: "chen.fan.fnst" add cpu-topology.h cpu-topology.c files for prebuilding cpu qom tree "/machine/node[X]/socket[Y]/core[Z]->link cpu" Signed-off-by: Chen Fan --- hw/i386/pc.c | 3 + target-i386/Makefile.objs | 2 +- target-i386/cpu-topology.c | 198 ++

Re: [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser

2014-03-11 Thread Kevin Wolf
Am 08.03.2014 um 19:47 hat Leandro Dorileo geschrieben: > The following patchset introduces a general purpose argument parser and > migrates > qemu-img to make use of it. qemu-img is just the first user of it, if we see a > good feedback here I move forward and migrate all the other possible users

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Michael S. Tsirkin
On Tue, Mar 11, 2014 at 10:55:17AM +, Peter Maydell wrote: > On 10 March 2014 19:05, Michael S. Tsirkin wrote: > > On Mon, Mar 10, 2014 at 03:38:11PM +, Peter Maydell wrote: > >> On 9 March 2014 19:19, Michael S. Tsirkin wrote: > >> > Changes from v2: > >> > fix for OSx by Gabriel > >

Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-11 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 09:58:54AM +0100, Paolo Bonzini wrote: > Il 09/03/2014 19:06, Michael S. Tsirkin ha scritto: > >we put copy of ROMs in MR for migration. > >but the name rom_in_ram makes one think we > >load it in guest RAM. > >Rename has_mr to make intent clearer. > > > >Signed-off-by: Mich

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Peter Maydell
On 11 March 2014 11:22, Michael S. Tsirkin wrote: > BTW I still see these warnings in the logs: > # gpg: WARNING: This key is not certified with a trusted signature! > # gpg: There is no indication that the signature belongs to > # the > > These seem counter-productive: people

Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()

2014-03-11 Thread Juan Quintela
Kevin Wolf wrote: > After migration has completed, we call bdrv_invalidate_cache() so that > drivers which cache some data drop their stale copy of the data and > reread it from the image file to get a new version of data that the > source modified while the migration was running. > > Reloading me

Re: [Qemu-devel] [PULL 0/9] vnc patches

2014-03-11 Thread Peter Maydell
On 10 March 2014 12:49, Gerd Hoffmann wrote: > Hi, > > Picked up a collection of vnc patches send to the list over the last > months. Reviewed, picked into a branch, smoke-tested. Here is the > pull req for them. > > If anyone has pending vnc bits not included here please resend & Cc /me. > >

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Michael S. Tsirkin
On Tue, Mar 11, 2014 at 11:32:41AM +, Peter Maydell wrote: > On 11 March 2014 11:22, Michael S. Tsirkin wrote: > > BTW I still see these warnings in the logs: > > # gpg: WARNING: This key is not certified with a trusted signature! > > # gpg: There is no indication that the sig

Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-11 Thread Marcel Apfelbaum
On Sun, 2014-03-09 at 20:06 +0200, Michael S. Tsirkin wrote: > we put copy of ROMs in MR for migration. > but the name rom_in_ram makes one think we > load it in guest RAM. > Rename has_mr to make intent clearer. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/loader.h | 2 +- > hw/core

Re: [Qemu-devel] [PATCH v22 05/25] add some QemuOpts functions for replace work

2014-03-11 Thread Eric Blake
On 03/10/2014 11:29 PM, Chunyan Liu wrote: >> >> Why are your later callers using a common helper function, but >> qemu_opt_get_del() repeating a lot of the body of qemu_opt_get()? >> Shouldn't qemu_opt_get() and qemu_opt_get_del() call into a common helper? >> >> qemu_opt_get_del must return (char

Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output.

2014-03-11 Thread Eric Blake
On 03/11/2014 04:09 AM, Marcel Apfelbaum wrote: > From: Stefan Hajnoczi > > The effect is that the output will grow, but we will know > which qtest failed. This helps when an asert is made on s/asert/assert/ > other code and not in the test itself. > > Signed-off-by: Stefan Hajnoczi > Signed-

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Peter Maydell
On 11 March 2014 11:49, Michael S. Tsirkin wrote: > On Tue, Mar 11, 2014 at 11:32:41AM +, Peter Maydell wrote: >> That won't help with removing the warning. What gpg >> is saying here is "I found this key in the keyring, >> and the signature checks out, but there's no chain >> of trust between

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Michael S. Tsirkin
On Tue, Mar 11, 2014 at 12:09:40PM +, Peter Maydell wrote: > On 11 March 2014 11:49, Michael S. Tsirkin wrote: > > On Tue, Mar 11, 2014 at 11:32:41AM +, Peter Maydell wrote: > >> That won't help with removing the warning. What gpg > >> is saying here is "I found this key in the keyring, >

Re: [Qemu-devel] Disk I/O in QEMU

2014-03-11 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 03:08:52PM +0800, Le Tan wrote: > Hi, I am now studying the disk I/O in QEMU, but I know little about QEMU. I > want to know how QEMU implements or emulates the disk I/O? Where to find > some materials about this? And if I can get all the disk I/O request from > the guest in

[Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
V2 -> V3: Addressed Eric Blake's review: - Corrected a typo. - Replace the commented Makefile part V1 -> V2: Addressed Stefan Hajnoczi's review: - Dropped qtest_state_valid API - Moved socket options in socket_accept. 'socket_accept' waits for Qemu to initialize its un

Re: [Qemu-devel] [PATCH] tap: avoid deadlocking rx

2014-03-11 Thread Stefan Hajnoczi
On Sat, Mar 08, 2014 at 04:00:43PM +0100, Stefan Hajnoczi wrote: > The net subsystem has a control flow mechanism so peer NetClientStates > can tell each other to stop sending packets. This is used to stop > monitoring the tap file descriptor for incoming packets if the guest rx > ring has no spar

[Qemu-devel] [PATCH V3 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
'socket_accept' waits for Qemu to initialize its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. Using a timeout for sockets fixes the issue. Signed-off-by: Marcel Apfelbaum --- tests/libqtest.c | 11 +-- 1

[Qemu-devel] [PATCH V3 2/2] tests: Tweak the Makefile to produce per-test output.

2014-03-11 Thread Marcel Apfelbaum
From: Stefan Hajnoczi The effect is that the output will grow, but we will know which qtest failed. This helps when an assert is made on other code and not in the test itself. Signed-off-by: Stefan Hajnoczi Signed-off-by: Marcel Apfelbaum --- tests/Makefile | 2 +- 1 file changed, 1 insertion

[Qemu-devel] strange kernel panic

2014-03-11 Thread Vasiliy Tolstov
I have strange kernel panic Kernel 3.13.3 vanilla root is mounted via 9p virtfs (readonly). virsh --version 1.2.1 qemu --version QEMU emulator version 1.7.0, Copyright (c) 2003-2008 Fabrice Bellard systemd version 210 Domain config: build 328891df-b3c3-aee9-eb5d-7e7934f7 512 512

Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output.

2014-03-11 Thread Marcel Apfelbaum
On Tue, 2014-03-11 at 06:07 -0600, Eric Blake wrote: > On 03/11/2014 04:09 AM, Marcel Apfelbaum wrote: > > From: Stefan Hajnoczi > > > > The effect is that the output will grow, but we will know > > which qtest failed. This helps when an asert is made on > > s/asert/assert/ Sure, > > > other c

Re: [Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-11 Thread Peter Maydell
On 10 March 2014 19:56, Michael S. Tsirkin wrote: > casting an unaligned address to e.g. > uint32_t can trigger undefined behaviour in C. > Replace cast + assignment with memcpy. > > Reported-by: Peter Maydell > Signed-off-by: Michael S. Tsirkin This does fix the clang warnings. > -/* Get poin

Re: [Qemu-devel] test-qapi-visit causes clang -fsanitize=undefined warning

2014-03-11 Thread Kevin Wolf
Am 10.03.2014 um 19:21 hat Markus Armbruster geschrieben: > Peter Maydell writes: > > > On 10 March 2014 13:36, Markus Armbruster wrote: > >> Peter Maydell writes: > >> Turns out my clang installation doesn't support -fsanitize=undefined: it > >> lacks libclang_rt.san-x86_64.a. > >> > >> Test w

Re: [Qemu-devel] [PULL v3 00/14] acpi, pc, pci, virtio, memory bug fixes

2014-03-11 Thread Peter Maydell
On 11 March 2014 12:22, Michael S. Tsirkin wrote: > But a chain of trust can still be established. > A bunch of people signed my key: > http://pgp.mit.edu/pks/lookup?op=vindex&search=0xC3503912AFBE8E67 > maybe you trust some of these keys? If we want to (a) collectively decide what we're going to

[Qemu-devel] [PULL 2/6] pc: avoid duplicate names for ROM MRs

2014-03-11 Thread Michael S. Tsirkin
Since commit 04920fc0faa4760f9c4fc0e73b992b768099be70 loader: store FW CFG ROM files in RAM RAM MRs including ROM files in FW CFGs are created and named using the file basename. This becomes problematic if these names are supplied by user, since the basename might not be unique. There are two

[Qemu-devel] [PULL 4/6] q35: Correct typo BRDIGE -> BRIDGE

2014-03-11 Thread Michael S. Tsirkin
From: BALATON Zoltan Signed-off-by: BALATON Zoltan Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/i386/ich9.h| 2 +- include/hw/pci-host/q35.h | 24 hw/pci-host/q35.c | 10 +- 3 files changed, 18 insertions(+), 18

[Qemu-devel] [PULL 1/6] loader: rename in_ram/has_mr

2014-03-11 Thread Michael S. Tsirkin
we put copy of ROMs in MR for migration. but the name rom_in_ram makes one think we load it in guest RAM. Rename has_mr to make intent clearer. Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 2 +- hw/core/loader.c| 6 +++--- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c| 2 +-

[Qemu-devel] [PULL 3/6] configure: don't modify .status on error

2014-03-11 Thread Michael S. Tsirkin
./configure --help make will try to re-run configure with --help which isn't what was intended. The reason is that config.status was written even on configure error. Defer writing config.status until configure has completed successfully. Signed-off-by: Michael S. Tsirkin Reviewed-by: Peter Mayd

[Qemu-devel] [PULL 5/6] acpi-build: don't access unaligned addresses

2014-03-11 Thread Michael S. Tsirkin
casting an unaligned address to e.g. uint32_t can trigger undefined behaviour in C. Replace cast + assignment with memcpy. Reported-by: Peter Maydell Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-

[Qemu-devel] [PULL 6/6] acpi-test: update expected SSDT files

2014-03-11 Thread Michael S. Tsirkin
SSDT doesn't have _SUN for non hotpluggable slots anymore. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/SSDT | Bin 2275 -> 2363 bytes tests/acpi-test-data/q35/SSDT | Bin 564 -> 652 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/acpi-test-data/pc/SS

Re: [Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization

2014-03-11 Thread Eric Blake
On 03/11/2014 06:24 AM, Marcel Apfelbaum wrote: > V2 -> V3: > Addressed Eric Blake's review: > - Corrected a typo. > - Replace the commented Makefile part > > V1 -> V2: > Addressed Stefan Hajnoczi's review: > - Dropped qtest_state_valid API > - Moved socket options in so

Re: [Qemu-devel] [PATCH v2] acpi-build: don't access unaligned addresses

2014-03-11 Thread Michael S. Tsirkin
On Tue, Mar 11, 2014 at 12:29:05PM +, Peter Maydell wrote: > On 10 March 2014 19:56, Michael S. Tsirkin wrote: > > casting an unaligned address to e.g. > > uint32_t can trigger undefined behaviour in C. > > Replace cast + assignment with memcpy. > > > > Reported-by: Peter Maydell > > Signed-o

Re: [Qemu-devel] [PATCH V2 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-11 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 12:09:09PM +0200, Marcel Apfelbaum wrote: > @@ -78,12 +79,16 @@ static int socket_accept(int sock) > struct sockaddr_un addr; > socklen_t addrlen; > int ret; > +struct timeval timeout = { .tv_sec = SOCKET_TIMEOUT, > + .tv_usec

[Qemu-devel] [PATCH v3] net: L2TPv3 transport

2014-03-11 Thread anton . ivanov
From: Anton Ivanov This tranport allows to connect a qemu nic to a static Ethernet over L2TPv3 tunnel. The transport supports all options present in the linux kernel implementation. It allows qemu to connect to any linux host running kernel 3.3+, most routers and network devices as well as other

Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output.

2014-03-11 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 12:09:10PM +0200, Marcel Apfelbaum wrote: > From: Stefan Hajnoczi > > The effect is that the output will grow, but we will know > which qtest failed. This helps when an asert is made on > other code and not in the test itself. > > Signed-off-by: Stefan Hajnoczi > Signed-

Re: [Qemu-devel] [PATCH] block: Update image size in bdrv_invalidate_cache()

2014-03-11 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 10:58:39AM +0100, Kevin Wolf wrote: > After migration has completed, we call bdrv_invalidate_cache() so that > drivers which cache some data drop their stale copy of the data and > reread it from the image file to get a new version of data that the > source modified while th

Re: [Qemu-devel] [PATCH V2 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
On Tue, 2014-03-11 at 13:40 +0100, Stefan Hajnoczi wrote: > On Tue, Mar 11, 2014 at 12:09:09PM +0200, Marcel Apfelbaum wrote: > > @@ -78,12 +79,16 @@ static int socket_accept(int sock) > > struct sockaddr_un addr; > > socklen_t addrlen; > > int ret; > > +struct timeval timeout =

Re: [Qemu-devel] [PATCH 1/1] s390-cpu: qom interface for S390 cpu states array

2014-03-11 Thread Jason J. Herne
On 03/07/2014 12:03 PM, Paolo Bonzini wrote: Il 07/03/2014 17:29, Jason J. Herne ha scritto: From: "Jason J. Herne" Rename the S390 ipi_states array to cpu_states to better reflect its contents. Create machine/cpu[cpu_addr] links within the qom tree when creating a new cpu. Encapsulate the q

Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output.

2014-03-11 Thread Marcel Apfelbaum
On Tue, 2014-03-11 at 13:45 +0100, Stefan Hajnoczi wrote: > On Tue, Mar 11, 2014 at 12:09:10PM +0200, Marcel Apfelbaum wrote: > > From: Stefan Hajnoczi > > > > The effect is that the output will grow, but we will know > > which qtest failed. This helps when an asert is made on > > other code and

[Qemu-devel] [PATCH 00/10] migration: Optimization the xbzrle and fix two corruption issues

2014-03-11 Thread arei.gonglei
From: ChenLiang V1-->V2 * expose the counter that logs the times of updating the dirty bitmap to end user. a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than fifty times. Before the patch set, the cache almost totally miss whe

[Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function

2014-03-11 Thread arei.gonglei
From: ChenLiang Rebuild the cache_is_cached function. Signed-off-by: ChenLiang Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake --- page_cache.c | 33 +++-- 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/page_cac

[Qemu-devel] [PATCH 03/10] XBZRLE: optimize XBZRLE to decrease the cache missing

2014-03-11 Thread arei.gonglei
From: ChenLiang Avoid the hot pages being replaced by others to remarkable decrease cache missing. The counter of updating dirty bitmap is used to indicate the cached page age. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c| 8 +--- include/migration/

[Qemu-devel] [PATCH 10/10] XBZRLE: update the doc of XBZRLE

2014-03-11 Thread arei.gonglei
From: ChenLiang Signed-off-by: ChenLiang Signed-off-by: Gonglei --- docs/xbzrle.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt index cc3a26a..cdf1e3e 100644 --- a/docs/xbzrle.txt +++ b/docs/xbzrle.txt @@ -71,6 +71,13 @@ encoded buffer: encoded

[Qemu-devel] [PATCH 05/10] migration: Fix the migrate auto converge process

2014-03-11 Thread arei.gonglei
From: ChenLiang It is inaccuracy and complex that using the transfer speed of migration thread to determine whether the convergence migration. The dirty page may be compressed by XBZRLE or ZERO_PAGE.The counter of updating dirty bitmap will be increasing continuously if the migration can't conver

[Qemu-devel] [PATCH 01/10] XBZRLE: Fix one XBZRLE corruption issues

2014-03-11 Thread arei.gonglei
From: ChenLiang The page may not be inserted into cache after executing save_xbzrle_page. In case of failure to insert, the original page should be sent rather than the page in the cache. Signed-off-by: ChenLiang Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert --- arch_init.c | 25

[Qemu-devel] [PULL 0/6] acpi,pc,test bug fixes

2014-03-11 Thread Michael S. Tsirkin
The following changes since commit 220c8ed536491315b4040d820328b8dfd60d67a7: qemu: x86: ignore ioapic polarity (2014-03-09 21:09:38 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 13f65b2e1073

[Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user

2014-03-11 Thread arei.gonglei
From: ChenLiang expose the counter that log the times of updating the dirty bitmap to end user. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c | 1 + hmp.c | 2 ++ include/migration/migration.h | 1 + migration.c | 2

[Qemu-devel] [PATCH 07/10] migraion: clear the death code

2014-03-11 Thread arei.gonglei
From: ChenLiang Clear the death code Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c | 13 - page_cache.c | 58 -- 2 files changed, 71 deletions(-) diff --git a/arch_init.c b/arch_init.c index 7ef3ebb..461a1

[Qemu-devel] [PATCH 06/10] migraion: optimiztion xbzrle by reducing data copy

2014-03-11 Thread arei.gonglei
From: ChenLiang Reducing data copy can reduce cpu overhead. Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch_init.c b/arch_init.c index d79535c..7ef3ebb 100644 --- a/arch_init.c +++ b/arch_init.c @

[Qemu-devel] [PATCH 08/10] migration: s/uint64_t/int64_t the definitions of it_age

2014-03-11 Thread arei.gonglei
From: ChenLiang Signed-off-by: ChenLiang Signed-off-by: Gonglei --- arch_init.c| 4 ++-- include/migration/page_cache.h | 4 ++-- page_cache.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch_init.c b/arch_init.c index 461a10

[Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap

2014-03-11 Thread arei.gonglei
From: ChenLiang Add counters to log the times of updating the dirty bitmap. Signed-off-by: ChenLiang Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Eric Blake --- arch_init.c | 20 1 file changed, 20 insertions(+) diff --git a/arch_init.c b/arc

Re: [Qemu-devel] [PATCH V2 1/2] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
On Tue, 2014-03-11 at 14:51 +0200, Marcel Apfelbaum wrote: > On Tue, 2014-03-11 at 13:40 +0100, Stefan Hajnoczi wrote: > > On Tue, Mar 11, 2014 at 12:09:09PM +0200, Marcel Apfelbaum wrote: > > > @@ -78,12 +79,16 @@ static int socket_accept(int sock) > > > struct sockaddr_un addr; > > > so

Re: [Qemu-devel] [PULL 0/2] input: two bugfixes.

2014-03-11 Thread Peter Maydell
On 10 March 2014 12:54, Gerd Hoffmann wrote: > Hi, > > Two bugs in the input layer rewrite poped up, > here are the bugfixes for then. > > please pull, > Gerd > > The following changes since commit f53f3d0a00b6df39ce8dfca942608e5b6a9a4f71: > > Merge remote-tracking branch 'remotes/kvaneesh/f

[Qemu-devel] [PATCH V4] tests/libqtest: Fix possible deadlock in qtest initialization

2014-03-11 Thread Marcel Apfelbaum
'socket_accept' waits for Qemu to init its unix socket. If Qemu encounters an error during command line parsing, it can exit before initializing the communication channel. Using a timeout for sockets fixes the issue. Reviewed-by: Eric Blake Signed-off-by: Marcel Apfelbaum --- tests/libqtest.c

Re: [Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap

2014-03-11 Thread Eric Blake
On 03/11/2014 06:53 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > Add counters to log the times of updating the dirty bitmap. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Wait - how did my Reviewed-by get he

Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function

2014-03-11 Thread Eric Blake
On 03/11/2014 06:53 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > Rebuild the cache_is_cached function. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Once again, I did NOT give R-b in v1. > --- > page_cache

Re: [Qemu-devel] [PATCH] tests/qapi-schema: Fix enum misuse in flat union type tests

2014-03-11 Thread Luiz Capitulino
On Tue, 11 Mar 2014 10:19:20 +0100 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Mon, 10 Mar 2014 15:54:50 +0100 > > Markus Armbruster wrote: > > > >> Screwed up in commit 2fc0043. Currently harmless, because the enum > >> values happen to be identical. > > > > I'm afraid this c

Re: [Qemu-devel] [PATCH 0/3] qcow2: Fix crash during copy_sectors() after corruption

2014-03-11 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 11:44:06PM +0100, Max Reitz wrote: > This series fixes a call to a NULL function pointer during > copy_sectors(), if a concurrent write request triggered the corruption > prevention mechanism. > > > Max Reitz (3): > qcow2: Check bs->drv in copy_sectors() > block: bs->d

Re: [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user

2014-03-11 Thread Eric Blake
On 03/11/2014 06:53 AM, arei.gong...@huawei.com wrote: > From: ChenLiang > > expose the counter that log the times of updating the dirty bitmap to > end user. > > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > +++ b/qapi-schema.json > @@ -651,13 +651,15 @@ > # > # @mbps: throughp

Re: [Qemu-devel] [PULL 0/3] spice patch queue

2014-03-11 Thread Peter Maydell
On 10 March 2014 13:16, Gerd Hoffmann wrote: > Hi, > > Flushing the spice patch queue with a small collection > of three patches. No major changes in there. > > please pull, > Gerd > > The following changes since commit f53f3d0a00b6df39ce8dfca942608e5b6a9a4f71: > > Merge remote-tracking bra

[Qemu-devel] [Help-Request] how to determine EVERY read/write to/from memory?

2014-03-11 Thread Rudolf Woerndle
Hi! This is my first post, sorry in case I might accidentally not comply to all rules. My goal: To implement a race- condition detection using trace- data from QEMU. Finally, I'd hope to contribute my result. As a start I printed out all used addresses in include/exec/softmmu_template.h (IO

Re: [Qemu-devel] SMBIOS (Set of 10 patches)

2014-03-11 Thread Kevin O'Connor
On Tue, Mar 11, 2014 at 11:03:06AM +0100, Gerd Hoffmann wrote: > Issue #3: Running a diff on the dmidecode output with and without the > patches yields this: I think it would be best to get the patch series to the point that there is no diff between old and new. That will make review easier, and

Re: [Qemu-devel] [PATCH v22 01/25] add def_value_str to QemuOptDesc

2014-03-11 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 03:31:37PM +0800, Chunyan Liu wrote: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. And improved related functions. > > Signed-off-by: Dong Xu Wang The address should be . Stefan

[Qemu-devel] [PULL for-2.0 00/11] QMP queue

2014-03-11 Thread Luiz Capitulino
The following changes since commit c57ec3249e9839c7ea2e3789f6e40f9ec1c92f55: Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-5' into staging (2014-03-11 12:52:08 +) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch c

[Qemu-devel] [PULL 05/11] qapi script: code move for generate_enum_name()

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia Later both qapi-types.py and qapi-visit.py need a common function for enum name generation. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- scripts/qapi-types.py | 10 -- scripts/qapi.py | 1

Re: [Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap

2014-03-11 Thread Gonglei (Arei)
> On 03/11/2014 06:53 AM, arei.gong...@huawei.com wrote: > > From: ChenLiang > > > > Add counters to log the times of updating the dirty bitmap. > > > > Signed-off-by: ChenLiang > > Signed-off-by: Gonglei > > Reviewed-by: Dr. David Alan Gilbert > > Reviewed-by: Eric Blake > > Wait - how did m

[Qemu-devel] [PULL 01/11] qapi script: remember explicitly defined enum values

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia Later other scripts will need to check the enum values. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- scripts/qapi.py| 16 +++- tests/qapi-schema/comments.out

[Qemu-devel] [PULL 06/11] qapi script: use same function to generate enum string

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia Prior to this patch, qapi-visit.py used custom code to generate enum names used for handling a qapi union. Fix it to instead reuse common code, with identical generated results, and allowing future updates to generation to only need to touch one place. Signed-off-by: Wenchao Xi

[Qemu-devel] [PULL 02/11] qapi script: add check for duplicated key

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia It is bad that same key was specified twice, especially when a union has two branches with same condition. This patch can prevent it. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- scripts/qapi.py

[Qemu-devel] [PULL 03/11] qapi script: remember line number in schema parsing

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia Before this patch, 'QAPISchemaError' scans whole input until 'pos' to get error line number. After this patch, the scan is avoided since line number is remembered in schema parsing. This patch also benefits other error report functions, which would be introduced later. Signed-o

[Qemu-devel] [PULL 08/11] qapi: convert BlockdevOptions to use enum discriminator

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia After this patch, hidden enum type BlockdevOptionsKind will not be generated, and other API can use enum BlockdevDriver. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- qapi-schema.json | 14 +

[Qemu-devel] [PULL 07/11] qapi script: support enum type as discriminator in union

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia By default, any union will automatically generate a enum type as "[UnionName]Kind" in C code, and it is duplicated when the discriminator is specified as a pre-defined enum type in schema. After this patch, the pre-defined enum type will be really used as the switch case conditi

[Qemu-devel] [PULL 10/11] qapi script: do not add "_" for every capitalized char in enum

2014-03-11 Thread Luiz Capitulino
From: Wenchao Xia Now "enum AIOContext" will generate AIO_CONTEXT instead of A_I_O_CONTEXT, "X86CPU" will generate X86_CPU instead of X86_C_P_U. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake Reviewed-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- include/qapi/qmp/qerror.h |

  1   2   3   4   >