Re: [Qemu-devel] [PATCH 1/3] hw/9pfs/virtio-9p-local.c: move v9fs_string_free() to below "err_out:"

2014-03-03 Thread Aneesh Kumar K.V
Chen Gang writes: > When "goto err_out", 'v9fs_string' already was allocated, so still need > free 'v9fs_string' before return. > > Signed-off-by: Chen Gang Reviewed-by: Aneesh Kumar K.V > --- > hw/9pfs/virtio-9p-local.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Qemu-devel] [PATCH 05/10] block/json: Add bdrv_co_get_block_status()

2014-03-03 Thread Max Reitz
Implement this function in the same way as raw_bsd does: Acknowledge that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID and BDRV_BLOCK_DATA and derive the offset directly from the sector index) and add BDRV_BLOCK_RAW to the returned value. Signed-off-by: Max Reitz --- block

[Qemu-devel] [PATCH 01/10] qdict: Add qdict_join()

2014-03-03 Thread Max Reitz
This function joins two QDicts by absorbing one into the other. Signed-off-by: Max Reitz --- include/qapi/qmp/qdict.h | 3 +++ qobject/qdict.c | 32 2 files changed, 35 insertions(+) diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h inde

[Qemu-devel] [PATCH 07/10] block/json: Add bdrv_get_specific_info()

2014-03-03 Thread Max Reitz
Add a passthrough function for bdrv_get_specific_info(). Signed-off-by: Max Reitz --- block/json.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/json.c b/block/json.c index ce718e8..6aa0544 100644 --- a/block/json.c +++ b/block/json.c @@ -185,6 +185,11 @@ static int json_get_in

[Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-03 Thread Max Reitz
Add a test for the JSON protocol driver. Signed-off-by: Max Reitz --- tests/qemu-iotests/084 | 114 + tests/qemu-iotests/084.out | 39 tests/qemu-iotests/group | 1 + 3 files changed, 154 insertions(+) create mode 100755 test

[Qemu-devel] [PATCH 09/10] block/qapi: Ignore filters on top for format name

2014-03-03 Thread Max Reitz
bdrv_query_image_info() currently deduces the image filename and the format name from the top BDS. However, it is probably more reasonable to ignore as many filters as possible on top of the BDS chain since those neither change the type nor the filename of the underlying image. Filters like quorum

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Aneesh Kumar K.V
Chen Gang writes: > On 03/03/2014 04:34 PM, Markus Armbruster wrote: >> Chen Gang writes: >> >>> 'ctx->fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so >>> need use snprintf() instead of sprintf() just like another area have done >>> in 9pfs. >>> >>> Signed-off-by: Chen Gang

[Qemu-devel] [PATCH 03/10] block/json: Add functions for cache control

2014-03-03 Thread Max Reitz
Add passthrough functions for bdrv_aio_flush() and bdrv_invalidate_cache(). Signed-off-by: Max Reitz --- block/json.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/block/json.c b/block/json.c index 6d63cf6..2f885cc 100644 --- a/block/json.c +++ b/block/json.c @@ -91,6 +91,

[Qemu-devel] [PATCH 08/10] block/raw_bsd: Add bdrv_get_specific_info()

2014-03-03 Thread Max Reitz
Add a passthrough function for bdrv_get_specific_info(). Signed-off-by: Max Reitz --- block/raw_bsd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 01ea692..e93ccd3 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -90,6 +90,11 @@ static in

[Qemu-devel] [PATCH 06/10] block/json: Add ioctl etc.

2014-03-03 Thread Max Reitz
Add passthrough functions for bdrv_aio_ioctl(), bdrv_is_inserted(), bdrv_media_changed(), bdrv_eject(), bdrv_lock_medium() and bdrv_ioctl(). Signed-off-by: Max Reitz --- block/json.c | 40 1 file changed, 40 insertions(+) diff --git a/block/json.c b/bloc

Re: [Qemu-devel] [PATCH v4 1/3] qapi: Use an explicit input file

2014-03-03 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: > [...] >>> diff --git a/scripts/qapi.py b/scripts/qapi.py >>> index 9b3de4c..59c2b9b 100644 >>> --- a/scripts/qapi.py >>> +++ b/scripts/qapi.py >>> @@ -12,6 +12,7 @@ >>> # See the COPYING.LIB file in the top-level di

[Qemu-devel] [PCTCH v4] qdev: set properties after device's parent is assigned

2014-03-03 Thread Amos Kong
Test steps: (qemu) device_add e1000,addr=adsf Property 'e1000.addr' doesn't take value 'adsf' (qemu) info qtree Then qemu crashed. Currently we set a link to the new device for qdev parent bus, but the device hasn't been added to QOM tree. When it fails to set properties, object_unparent() c

Re: [Qemu-devel] [PATCH v3] qdev: move the code adding the device out of realize

2014-03-03 Thread Andreas Färber
Am 03.03.2014 14:34, schrieb Igor Mammedov: > On Mon, 3 Mar 2014 15:57:55 +0800 > Amos Kong wrote: > > s/subj/qdev: set properties after device's parent is assigned/ > >> Test steps: >> (qemu) device_add e1000,addr=adsf >> Property 'e1000.addr' doesn't take value 'adsf' >> (qemu) info qtree

Re: [Qemu-devel] [PCTCH v4] qdev: set properties after device's parent is assigned

2014-03-03 Thread Andreas Färber
Hi, Am 03.03.2014 16:55, schrieb Amos Kong: > Test steps: > (qemu) device_add e1000,addr=adsf > Property 'e1000.addr' doesn't take value 'adsf' > (qemu) info qtree > Then qemu crashed. > > Currently we set a link to the new device for qdev parent bus, but the > device hasn't been added to Q

Re: [Qemu-devel] [PATCH 2/3] hw/9pfs/virtio-9p-local.c: use snprintf() instead of sprintf()

2014-03-03 Thread Aneesh Kumar K.V
Chen Gang writes: > 'ctx->fs_root' + 'path'/'fullname.data' may be larger than PATH_MAX, so > need use snprintf() instead of sprintf() just like another area have done in > 9pfs. > > Signed-off-by: Chen Gang Will take care of Markus feedback. Reviewed-by: Aneesh Kumar K.V > --- > hw/9pfs/v

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Introduce hypervisor call H_GET_TCE

2014-03-03 Thread Alexander Graf
Laurent Dufour wrote: > On 21/02/2014 10:29, Laurent Dufour wrote: > >> This patch introduces the hypervisor call H_GET_TCE which is basically the >> reverse of H_PUT_TCE, as defined in the Power Architecture Platform >> Requirements (PAPR). >> >> The hcall H_GET_TCE is required by the kdump ker

Re: [Qemu-devel] [PCTCH v4] qdev: set properties after device's parent is assigned

2014-03-03 Thread Amos Kong
On Mon, Mar 03, 2014 at 05:01:34PM +0100, Andreas Färber wrote: > Hi, > > Am 03.03.2014 16:55, schrieb Amos Kong: > > Test steps: > > (qemu) device_add e1000,addr=adsf > > Property 'e1000.addr' doesn't take value 'adsf' > > (qemu) info qtree > > Then qemu crashed. > > > > Currently we set a

Re: [Qemu-devel] [PATCH 3/3] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-03-03 Thread Aneesh Kumar K.V
Chen Gang writes: > When path is truncated by PATH_MAX limitation, it causes QEMU to access > incorrect file. So use original full path instead of PATH_MAX within > 9pfs (need check/process ENOMEM for related memory allocation). > > The related test: > > - Environments (for qemu-devel): > >-

Re: [Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code

2014-03-03 Thread Luiz Capitulino
On Sat, 1 Mar 2014 08:40:26 +0100 Markus Armbruster wrote: > Coverity is unhappy with the generated code. Nothing serious, just > heaps of valid DEADCODE defects topped off with a few bogus > FORWARD_NULL defects. > > I had a look at the generator, and decided I don't want to mess with > it wi

Re: [Qemu-devel] [PATCH 0/3] Enable x2apic by default on KVM

2014-03-03 Thread Andreas Färber
Am 19.02.2014 20:13, schrieb Michael S. Tsirkin: > On Wed, Feb 19, 2014 at 11:58:09AM -0300, Eduardo Habkost wrote: >> This is the approach I believe was agreed upon during the last QEMU >> developers >> conf call (sorry I didn't join, the meeting timezone change confused me). > > Yes. Matches m

Re: [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64

2014-03-03 Thread Richard Henderson
On 03/02/2014 11:36 AM, Peter Maydell wrote: > Alexander Graf (1): > linux-user: Implement sendmmsg syscall > > Andreas Schwab (1): > linux-user: Don't use UID16 on AArch64 > > Michael Matz (1): > linux-user: AArch64: Implement SA_RESTORER for signal handlers > > Peter Maydell (2): > lin

Re: [Qemu-devel] [PATCH qom-cpu v10 0/2] target-i386: X86CPU subclasses

2014-03-03 Thread Andreas Färber
Am 25.02.2014 08:36, schrieb Andreas Färber: > Hello, > > Here's my cleaned up version of slim x86 CPU subclasses. > Second patch didn't get a lot of testing yet. > > Loading cpudef is still in main initfn since otherwise the host type > would need to be relocated. Can be cleaned up as follow-ups

Re: [Qemu-devel] [PATCH] qapi: output visitor crashes qemu if it encounters a NULL value

2014-03-03 Thread Luiz Capitulino
On Sun, 02 Mar 2014 12:15:45 +0200 Marcel Apfelbaum wrote: > On Fri, 2014-02-28 at 11:37 -0500, Luiz Capitulino wrote: > > On Mon, 17 Feb 2014 20:01:42 +0200 > > Marcel Apfelbaum wrote: > > > > > On Mon, 2014-02-17 at 10:38 -0700, Eric Blake wrote: > > > > On 02/17/2014 04:52 AM, Marcel Apfelba

Re: [Qemu-devel] [PATCH v4 1/3] qapi: Use an explicit input file

2014-03-03 Thread Lluís Vilanova
Markus Armbruster writes: [...] self.fp = schema.fp self.msg = msg self.line = self.col = 1 @@ -50,12 +52,17 @@ class QAPISchemaError(Exception): self.col += 1 def __str__(self): - return "%s:%s:%s: %s" % (self.fp.name, self.line, self.col, self.msg) >>

Re: [Qemu-devel] [PATCH v4 2/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-03-03 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Adds the "include(...)" primitive to the syntax of QAPI schema files. Signed-off-by: Lluís Vilanova --- docs/qapi-code-gen.txt |8 scripts/qa

[Qemu-devel] [PULL 00/32] QMP queue

2014-03-03 Thread Luiz Capitulino
The following changes since commit d844a7b6569fb2b5252773444b18841426e5b906: modules: Fix building with --enable-modules (2014-02-28 12:30:13 +) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to b774539743c52ef605c6e2

[Qemu-devel] [PULL 02/32] MAINTAINERS: update status for HMP, QAPI and QMP trees

2014-03-03 Thread Luiz Capitulino
This commit updates the status for the HMP, QAPI and QMP trees from "Supported" to "Maintained". In practice this means that patch review and pull requests may take longer. Also, I'll rely more on reviewers such as Eric Blake so that I'm able to send pull requests regularly. Reviewed-by: Eric Bla

[Qemu-devel] [PULL 01/32] QMP: Allow dot separated dict path arguments in qmp-shell

2014-03-03 Thread Luiz Capitulino
From: Fam Zheng As another convenience to allow using commands that expect a dict as argument, this patch adds support for foo.bar=value syntax, similar to command line argument style: (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=... Signed-off-by: Fam Zheng Rev

[Qemu-devel] [PULL 04/32] dump: add argument to write_elfxx_notes

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose the method of writing elf notes Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --

[Qemu-devel] [PULL 08/32] dump: add support for lzo/snappy

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan kdump-compressed format supports three compression format, zlib/lzo/snappy. Currently, only zlib is available. This patch is used to support lzo/snappy. '--enable-lzo/--enable-snappy' is needed to be specified with configure to make lzo/snappy available for qemu Signed-off-by: Q

[Qemu-devel] [PULL 11/32] dump: add API to write dump_bitmap

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan functions are used to write 1st and 2nd dump_bitmap of kdump-compressed format, which is used to indicate whether the corresponded page is existed in vmcore. 1st and 2nd dump_bitmap are same, because dump level is specified to 1 here. Signed-off-by: Qiao Nuohan Reviewed-by: Las

[Qemu-devel] [PULL 07/32] dump: add API to write elf notes to buffer

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan the function can be used by write_elf32_notes/write_elf64_notes to write notes to a buffer. If fd_write_vmcore is used, write_elf32_notes/write_elf64_notes will write elf notes to vmcore directly. Instead, if buf_write_note is used, elf notes will be written to opaque->note_buf a

[Qemu-devel] [PULL 09/32] dump: add members to DumpState and init some of them

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan add some members to DumpState that will be used in writing vmcore in kdump-compressed format. some of them, like page_size, will be initialized in the patch. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c| 28 ++

[Qemu-devel] [PULL 06/32] dump: add API to write vmcore

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan Function is used to write vmcore in flatten format. In flatten format, data is written block by block, and in front of each block, a struct MakedumpfileDataHeader is stored there to indicate the offset and size of the data block. struct MakedumpfileDataHeader { int64_t offse

[Qemu-devel] [PULL 05/32] dump: add API to write header of flatten format

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan flatten format will be used when writing kdump-compressed format. The format is also used by makedumpfile, you can refer to the following URL to get more detailed information about flatten format of kdump-compressed format: http://sourceforge.net/projects/makedumpfile/ The two f

[Qemu-devel] [PULL 12/32] dump: add APIs to operate DataCache

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan DataCache is used to store data temporarily, then the data will be written to vmcore. These functions will be called later when writing data of page to vmcore. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c| 47

[Qemu-devel] [PULL 14/32] dump: make kdump-compressed format available for 'dump-guest-memory'

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'kdump-zlib': kdu

[Qemu-devel] [PULL 10/32] dump: add API to write dump header

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan the functions are used to write header of kdump-compressed format to vmcore. Header of kdump-compressed format includes: 1. common header: DiskDumpHeader32 / DiskDumpHeader64 2. sub header: KdumpSubHeader32 / KdumpSubHeader64 3. extra information: only elf notes here Signed-off-

[Qemu-devel] [PULL 13/32] dump: add API to write dump pages

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan functions are used to write page to vmcore. vmcore is written page by page. page desc is used to store the information of a page, including a page's size, offset, compression format, etc. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino ---

[Qemu-devel] [PULL 16/32] dump: add 'query-dump-guest-memory-capability' command

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan 'query-dump-guest-memory-capability' is used to query the available formats for 'dump-guest-memory'. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "formats": ["elf", "kdump-zlib", "kdump-lzo",

[Qemu-devel] [PULL 03/32] dump: const-qualify the buf of WriteCoreDumpFunction

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan WriteCoreDumpFunction is a function pointer that points to the function used to write content in "buf" into core file, so "buf" should be const-qualify. Signed-off-by: Qiao Nuohan Reviewed-by: Laszlo Ersek Signed-off-by: Luiz Capitulino --- dump.c| 2 +- include/

[Qemu-devel] [PULL 17/32] qmp: Check for returned data from __json_read in get_events

2014-03-03 Thread Luiz Capitulino
From: Fam Zheng When QEMU process aborts and socket is closed, qmp client will not detect it. When this happens, some qemu-iotests scripts will enter an endless loop waiting for qmp events. It's better we raise an exception in qmp.py to catch this and make the test script stop. Signed-off-by: F

[Qemu-devel] [PULL 15/32] Define the architecture for compressed dump format

2014-03-03 Thread Luiz Capitulino
From: qiaonuohan Signed-off-by: Ekaterina Tumanova Reviewed-by: Laszlo Ersek Reviewed-by: Qiao Nuohan Signed-off-by: Luiz Capitulino --- dump.c | 7 +-- target-i386/cpu.h | 2 ++ target-s390x/cpu.h | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dump.c

[Qemu-devel] [PULL 31/32] qapi: Clean up superfluous null check in qapi_dealloc_type_str()

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Argument can't be null. No other Visitor method type_str() checks for null. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi/qapi-dealloc-visitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PULL 24/32] tests/qapi-schema: Cover complex types with base

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/qapi-schema/qapi-schema-test.json | 6 +- tests/qapi-schema/qapi-schema-test.out | 6 -- tests/test-qmp-commands.c | 15 ++- tests/tes

[Qemu-devel] [PULL 22/32] tests/qapi-schema: Cover simple argument types

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/qapi-schema/qapi-schema-test.json | 2 ++ tests/qapi-schema/qapi-schema-test.out | 1 + tests/test-qmp-commands.c | 16 3 files changed,

[Qemu-devel] [PULL 20/32] tests/qapi-schema: Actually check successful QMP command response

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/test-qmp-commands.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/tests/test-qmp-commands.c b/tests/test

[Qemu-devel] [PULL 23/32] tests/qapi-schema: Cover anonymous union types

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/qapi-schema/qapi-schema-test.json | 4 tests/qapi-schema/qapi-schema-test.out | 6 +- tests/test-qmp-input-strict.c | 32

[Qemu-devel] [PULL 25/32] tests/qapi-schema: Cover union types with base

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/qapi-schema/qapi-schema-test.json | 1 + tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-input-strict.c | 4 ++-- tests/test-qmp-input-visitor.c

[Qemu-devel] [PULL 26/32] tests/qapi-schema: Cover flat union types

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster The test demonstrates a generator bug: the generated struct UserDefFlatUnion doesn't include members for the indirect base UserDefZero. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/qapi-schema/qapi-schema-test.json

[Qemu-devel] [PULL 29/32] qapi: Drop unused code in qapi-commands.py

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 20 1 file changed, 20 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 38c2347..9734ab0 1006

Re: [Qemu-devel] [PATCH v3] qdev: move the code adding the device out of realize

2014-03-03 Thread Igor Mammedov
On Mon, 03 Mar 2014 16:56:19 +0100 Andreas Färber wrote: > Am 03.03.2014 14:34, schrieb Igor Mammedov: > > On Mon, 3 Mar 2014 15:57:55 +0800 > > Amos Kong wrote: > > > > s/subj/qdev: set properties after device's parent is assigned/ > > > >> Test steps: > >> (qemu) device_add e1000,addr=adsf

[Qemu-devel] [PCTCH v2 0/2] fix query-command-line-options

2014-03-03 Thread Amos Kong
This patchset fixed some issues of query-command-line-options: * some new options haven't arguments can't be queried. (eg: -enable-fips) * some legcy options have arguments can't be queried. (eg: -vnc display) More discussion: http://marc.info/?l=qemu-devel&m=139081830416684&w=2 V2: remove d

[Qemu-devel] [PCTCH v2 1/2] qmp: rename query_option_descs() to get_param_infolist()

2014-03-03 Thread Amos Kong
Signed-off-by: Amos Kong --- util/qemu-config.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/qemu-config.c b/util/qemu-config.c index 9298f55..d624d92 100644 --- a/util/qemu-config.c +++ b/util/qemu-config.c @@ -39,7 +39,7 @@ QemuOptsList *qemu_find_opts(const

[Qemu-devel] [PCTCH v2 2/2] query-command-line-options: query all the options in qemu-options.hx

2014-03-03 Thread Amos Kong
vm_config_groups[] only contains part of the options which have argument, and all options which have no argument isn't added to vm_config_groups[]. Current query-command-line-options only checkes options from vm_config_groups[], so some options will be lost. We have some macros in qemu-options.hx

[Qemu-devel] [PULL 19/32] monitor: Remove left-over code in do_info_profile.

2014-03-03 Thread Luiz Capitulino
From: Hani Benhabiles This is a left-over from 4a1418e. Signed-off-by: Hani Benhabiles Signed-off-by: Luiz Capitulino --- monitor.c | 4 1 file changed, 4 deletions(-) diff --git a/monitor.c b/monitor.c index aebcbd8..3863d83 100644 --- a/monitor.c +++ b/monitor.c @@ -2021,10 +2021,6 @@

Re: [Qemu-devel] [PATCH 0/3] hw/9pfs: fix 3 issues which related with path string

2014-03-03 Thread Eric Blake
On 03/01/2014 10:33 AM, Chen Gang wrote: > Patch 1/3: move v9fs_string_free() to below "err_out:" > > Patch 2/3: use snprintf() instead of sprintf() >(which will be replaced of by Path 3/3) > > Patch 3/3: use g_strdup_printf() instead of PATH_MAX limitation By sending this series as

Re: [Qemu-devel] [PATCH] Modify qemu-img can not create local filename contain ":"

2014-03-03 Thread Max Reitz
On 03.03.2014 15:02, Jun Li wrote: Such as how to visit glusterfs: file=gluster://1.2.3.4/testvol/a.img file=gluster+tcp://1.2.3.4/testvol/a.img file=gluster+tcp://1.2.3.4:24007/testvol/dir/a.img file=gluster+tcp://[1:2:3:4:5:6:7:8]/testvol/dir/a.img file=gluster+tcp://[1:2:3:4:5:6:7:8]:24007/tes

Re: [Qemu-devel] [PATCH RFC V2 1/9] hw/core: introduced qemu machine as QOM object

2014-03-03 Thread Andreas Färber
Am 02.03.2014 14:07, schrieb Marcel Apfelbaum: > The main functionality change is to convert QEMUMachine into QemuMachineClass > and QEMUMachineInitArgs into QemuMachineState, instance of QemuMachineClass. I wonder why go from QEMUMachine* to QemuMachine*? I don't spot a name clash, and keeping QE

Re: [Qemu-devel] [PATCH v4 2/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-03-03 Thread Eric Blake
On 03/03/2014 08:27 AM, Markus Armbruster wrote: +The QAPI schema definitions can be modularized using the 'include' directive: + + include("sub-system/qapi.json") >> >>> And now it isn't JSON anymore. >> >>> To keep it JSON, use syntax like >> >>> { "include": "sub-system/

Re: [Qemu-devel] [PATCH] Modify qemu-img can not create local filename contain ":"

2014-03-03 Thread Eric Blake
On 03/03/2014 10:47 AM, Max Reitz wrote: > > Currently, a protocol prefix is only defined to end with a colon, not > with ":/" or "://". There are already protocol block drivers which do > not require a slash after the colon such as blkdebug or blkverify and I > deem it rather impossible to redef

[Qemu-devel] [PULL 27/32] qapi: Fix licensing of scripts

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster The scripts carry this copyright notice: # This work is licensed under the terms of the GNU GPLv2. # See the COPYING.LIB file in the top-level directory. The sentences contradict each other, as COPYING.LIB contains the LGPL 2.1. Michael Roth says this was a simp

Re: [Qemu-devel] [PATCH] Modify qemu-img can not create local filename contain ":"

2014-03-03 Thread Max Reitz
On 03.03.2014 19:03, Eric Blake wrote: On 03/03/2014 10:47 AM, Max Reitz wrote: Currently, a protocol prefix is only defined to end with a colon, not with ":/" or "://". There are already protocol block drivers which do not require a slash after the colon such as blkdebug or blkverify and I dee

Re: [Qemu-devel] Request for openhackware.git mirror

2014-03-03 Thread Mark Cave-Ayland
On 02/03/14 20:41, Andreas Färber wrote: Hello Stefan, We have a file pc-bios/ppc_rom.bin in qemu.git, used by PReP emulation, to which we do not have available the full GPL source code. I would like to replace the current file with a new binary built from original OpenHack'Ware sources plus ou

[Qemu-devel] [PULL 32/32] qapi: Add missing null check to opts_start_struct()

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+),

[Qemu-devel] [PATCH] Rewrite block filter snapshot authorization mechanism

2014-03-03 Thread Benoît Canet
Rewrite the snapshot authorization mechanism for block filter as suggested by Paolo. run testsuite and Tested BlockBackend snapshots Tested quorum snapshot Tested that snapshot below or above the active qcow2 file are not authorized Benoît Canet (1): block: Rewrite the snapshot authorization

[Qemu-devel] [PULL 28/32] qapi: Drop nonsensical header guard in generated qapi-visit.c

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index b2a1c1c..97e9b11 100644 --- a/scripts/qapi-visit.p

[Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Benoît Canet
This patch keep the recursive way of doing things but simplify it by giving two responsabilities to all block filters implementors. They will need to do two things: -Set the is_filter field of their block driver to true. -Implement the bdrv_recurse_is_first_non_filter method of their block drive

Re: [Qemu-devel] [PATCH RFC V2 2/9] vl: use qemu machine QOM class instead of global machines list

2014-03-03 Thread Andreas Färber
Am 02.03.2014 14:07, schrieb Marcel Apfelbaum: > The machine registration flow is refactored to use the QOM functionality. > Instead of linking the machines into a list, each machine has a type > and the types can be traversed in the QOM way. > > Signed-off-by: Marcel Apfelbaum > --- > include/h

Re: [Qemu-devel] [PATCH 1/2] qemu-img convert: Fix progress output

2014-03-03 Thread Eric Blake
On 03/03/2014 06:57 AM, Kevin Wolf wrote: > Initialise progress output only when the -p and -q options have already > been parsed, otherwise it's always disabled. > > Reported-by: Peter Lieven > Signed-off-by: Kevin Wolf > --- > qemu-img.c | 20 +++- > 1 file changed, 11 inserti

[Qemu-devel] [PULL 30/32] qapi: Clean up null checking in generated visitors

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Visitors get passed a pointer to the visited object. The generated visitors try to cope with this pointer being null in some places, for instance like this: visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err); visit_start_optional() passes its seco

Re: [Qemu-devel] [PATCH 2/2] qemu-iotests: Test progress output for conversion

2014-03-03 Thread Eric Blake
On 03/03/2014 06:57 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/086 | 65 > ++ > tests/qemu-iotests/086.out | 18 + > tests/qemu-iotests/group | 1 + > 3 files changed, 84 insertions(+) > create mode

[Qemu-devel] [PULL 18/32] qerror: Improve QERR_DEVICE_NOT_ACTIVE message

2014-03-03 Thread Luiz Capitulino
From: Hani Benhabiles The error message as currently used is confusing as there are no "balloon" or "spice" devices. (qemu) balloon 1024 balloon: Device 'balloon' has not been activated With this patch: (qemu) balloon 1024 balloon: No balloon device has been activated Signed-off-by: Hani Benh

Re: [Qemu-devel] Request for openhackware.git mirror

2014-03-03 Thread Andreas Färber
Hi Mark, Am 03.03.2014 19:08, schrieb Mark Cave-Ayland: > On 02/03/14 20:41, Andreas Färber wrote: > >> [1] Using `make CROSS_COMPILE=powerpc-elf-` works for GCC 4.8.2 and >> binutils 2.24; I did not find a solution for my identically versioned >> CROSS_COMPILE=powerpc-eabi- setup (that I had bee

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 19:11, Benoît Canet ha scritto: diff --git a/block/blkverify.c b/block/blkverify.c index b98b08b..e1c3117 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -288,6 +288,20 @@ static BlockDriverAIOCB *blkverify_aio_flush(BlockDriverState *bs, return bdrv_aio_flush(s->tes

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Introduce hypervisor call H_GET_TCE

2014-03-03 Thread Andreas Färber
Am 03.03.2014 14:02, schrieb Laurent Dufour: > On 21/02/2014 10:29, Laurent Dufour wrote: >> This patch introduces the hypervisor call H_GET_TCE which is basically the >> reverse of H_PUT_TCE, as defined in the Power Architecture Platform >> Requirements (PAPR). >> >> The hcall H_GET_TCE is require

Re: [Qemu-devel] Request for openhackware.git mirror

2014-03-03 Thread Mark Cave-Ayland
On 03/03/14 18:31, Andreas Färber wrote: Am I missing something from the build in order for the final link to complete correctly? Hm, repository looks okay, and I didn't run into this yet. Possibly you are using different binutils? Presumably you did try make clean CROSS_COMPILE=... :) I cho

[Qemu-devel] [PULL 21/32] tests/qapi-schema: Cover optional command arguments

2014-03-03 Thread Luiz Capitulino
From: Markus Armbruster Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- tests/qapi-schema/qapi-schema-test.json | 4 +++- tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-commands.c | 8 +--- 3 files changed, 9 insert

Re: [Qemu-devel] [PULL 13/32] dump: add API to write dump pages

2014-03-03 Thread Eric Blake
On 03/03/2014 10:12 AM, Luiz Capitulino wrote: > From: qiaonuohan > > functions are used to write page to vmcore. vmcore is written page by page. > page desc is used to store the information of a page, including a page's size, > offset, compression format, etc. > > Signed-off-by: Qiao Nuohan H

Re: [Qemu-devel] [PATCH RFC V2 1/9] hw/core: introduced qemu machine as QOM object

2014-03-03 Thread Marcel Apfelbaum
On Mon, 2014-03-03 at 18:49 +0100, Andreas Färber wrote: > Am 02.03.2014 14:07, schrieb Marcel Apfelbaum: > > The main functionality change is to convert QEMUMachine into > > QemuMachineClass > > and QEMUMachineInitArgs into QemuMachineState, instance of QemuMachineClass. > > I wonder why go from

[Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including hw/Makefile.objs directly from Makefile.target. Hence we need to define the config in Makefile.target too to include virtio-9p-device.o in the build Signed-off-by: Aneesh Kumar K.V --- Makefile.targ

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Benoît Canet
The Monday 03 Mar 2014 à 19:35:13 (+0100), Paolo Bonzini wrote : > Il 03/03/2014 19:11, Benoît Canet ha scritto: > >diff --git a/block/blkverify.c b/block/blkverify.c > >index b98b08b..e1c3117 100644 > >--- a/block/blkverify.c > >+++ b/block/blkverify.c > >@@ -288,6 +288,20 @@ static BlockDriverAIO

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: From: "Aneesh Kumar K.V" After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including hw/Makefile.objs directly from Makefile.target. Hence we need to define the config in Makefile.target too to include virtio-9p-device.o in the build

Re: [Qemu-devel] [PATCH 3/3] hw/9pfs: use g_strdup_printf() instead of PATH_MAX limitation

2014-03-03 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > Chen Gang writes: > Can we keep this as > v9fs_co_run_in_worker( > { > >buf->data = __readlink(&s->ctx, path); > > } > > I can do that change for you if you want. I will also have to go through > the rest

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Aneesh Kumar K.V
Paolo Bonzini writes: > Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: >> From: "Aneesh Kumar K.V" >> >> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >> hw/Makefile.objs directly from Makefile.target. Hence we need to define >> the config in Makefile.target too to in

Re: [Qemu-devel] [PATCH v7 1/2] target-ppc: add PowerPCCPU::cpu_dt_id

2014-03-03 Thread Mike Day
On Sat, Feb 1, 2014 at 9:45 AM, Alexey Kardashevskiy wrote: > Normally CPUState::cpu_index is used to pick the right CPU for various > operations. However default consecutive numbering does not always work > for POWERPC. > > These indexes are reflected in /proc/device-tree/cpus/PowerPC,POWER7@XX >

Re: [Qemu-devel] [RFC]VM live snapshot proposal

2014-03-03 Thread Andrea Arcangeli
Hi Paolo, On Mon, Mar 03, 2014 at 02:47:31PM +0100, Paolo Bonzini wrote: > I'm not sure what's the status of the kernel infrastructure for > post-copy. Andrea? sys_userfaultfd is still work in progress but it shouldn't be much work left to completion. madvise(MADV_USERFAULT) and remap_anon_pa

Re: [Qemu-devel] [PATCH RFC V2 2/9] vl: use qemu machine QOM class instead of global machines list

2014-03-03 Thread Marcel Apfelbaum
On Mon, 2014-03-03 at 19:12 +0100, Andreas Färber wrote: > Am 02.03.2014 14:07, schrieb Marcel Apfelbaum: > > The machine registration flow is refactored to use the QOM functionality. > > Instead of linking the machines into a list, each machine has a type > > and the types can be traversed in the

Re: [Qemu-devel] [PATCH v7 2/2] target-ppc: spapr: e500: fix to use cpu_dt_id

2014-03-03 Thread Mike Day
On Sat, Feb 1, 2014 at 9:45 AM, Alexey Kardashevskiy wrote: > This makes use of @cpu_dt_id and related API in: > 1. emulated XICS hypercall handlers as they receive fixed CPU indexes; > 2. XICS-KVM to enable in-kernel XICS on right CPU; > 3. device-tree renderer. > > This removes @cpu_index fixup

Re: [Qemu-devel] [PULL v2 33/37] block: vhdx - add .bdrv_create() support

2014-03-03 Thread Jeff Cody
On Fri, Feb 21, 2014 at 01:06:43PM +0100, Alexander Graf wrote: > > On 08.11.2013, at 11:12, Stefan Hajnoczi wrote: > > > From: Jeff Cody > > > > This adds support for VHDX image creation, for images of type "Fixed" > > and "Dynamic". "Differencing" types (i.e., VHDX images with backing > > f

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Aneesh Kumar K.V
"Aneesh Kumar K.V" writes: > Paolo Bonzini writes: > >> Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: >>> From: "Aneesh Kumar K.V" >>> >>> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >>> hw/Makefile.objs directly from Makefile.target. Hence we need to define >>> t

Re: [Qemu-devel] [Bug 1286253] [NEW] virtio-net acceleration features not set when plugged into backend dynamically

2014-03-03 Thread Mario Smarduch
I don't have an x86 setup handy, but looking through the code 'virtio-net-pci' will work but not 'virtio-net-device'. My understanding was the goal is for any backend to plug into any transport on any platform. I'll try an x86 test with 'virtio-net-device' option and see what happens. Ye

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-03-03 Thread Neil Skrypuch
On Saturday 01 March 2014 10:34:03 陈梁 wrote: > > On Thursday 30 January 2014 13:23:04 Neil Skrypuch wrote: > >> First, let me briefly outline the way we use live migration, as it is > >> probably not typical. We use live migration (with block migration) to > >> make > >> backups of VMs with zero do

Re: [Qemu-devel] [PATCH] hw/9pfs: Include virtio-9p-device.o in build

2014-03-03 Thread Aneesh Kumar K.V
Paolo Bonzini writes: > Il 03/03/2014 20:08, Aneesh Kumar K.V ha scritto: >> From: "Aneesh Kumar K.V" >> >> After commit ba1183da9a10b94611cad88c44a5c6df005f9b55 we are including >> hw/Makefile.objs directly from Makefile.target. Hence we need to define >> the config in Makefile.target too to in

Re: [Qemu-devel] [PATCH] seccomp: add shmctl(), mlock(), and munlock() to the syscall whitelist

2014-03-03 Thread Paul Moore
On Wednesday, February 26, 2014 10:25:01 AM Paul Moore wrote: > Additional testing reveals that PulseAudio requires shmctl() and the > mlock()/munlock() syscalls on some systems/configurations. As before, > on systems that do require these syscalls, the problem can be seen with > the following com

Re: [Qemu-devel] [PATCH 2/7] KVM: s390: virtio-ccw adapter interrupt support.

2014-03-03 Thread Christian Borntraeger
On 25/02/14 18:24, Cornelia Huck wrote: > Implement the new CCW_CMD_SET_IND_ADAPTER command and try to enable > adapter interrupts for every device on the first startup. If the host > does not support adapter interrupts, fall back to normal I/O interrupts. > > virtio-ccw adapter interrupts use the

Re: [Qemu-devel] [PATCH 0/5] linux-user: various fixes for AArch64

2014-03-03 Thread Riku Voipio
On Sun, Mar 02, 2014 at 07:36:37PM +, Peter Maydell wrote: > Riku: do you want to take these via linux-user or should I > put them in via target-arm? linux-user seems like it makes more > sense to me; there's no dependency on target-arm patches and > some of the patches are generic fixes. Eithe

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 20:13, Benoît Canet ha scritto: Hmm I did not even though it was a bug, I merely rewrote the code to adapt to the new way of doing. Should I mention the bugfix and repost ? Up to Kevin. Paolo

Re: [Qemu-devel] e1000 memory corruption in guest OS

2014-03-03 Thread Don Slutz
On 03/03/14 05:47, Alexey Kardashevskiy wrote: On 03/03/2014 07:33 PM, Paolo Bonzini wrote: Il 03/03/2014 02:58, Alexey Kardashevskiy ha scritto: On 03/02/2014 08:31 AM, Paolo Bonzini wrote: Il 01/03/2014 13:30, Alexey Kardashevskiy ha scritto: Corrupted DMA buffer is 0x e0 -- 0x7f15c313f

Re: [Qemu-devel] [RFC 4/4] Relevant changes to enable KVM to TCG migration

2014-03-03 Thread Peter Maydell
On 26 February 2014 10:02, alvise rigo wrote: > I agree that this is a sort of workaround, but it seems to me that a > proper solution is not possible without changing the ideas contemplated > now in the migration code. > Are we willing to accept some major changes in the code to embrace > this ty

<    1   2   3   >