Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread 陈梁
> On 02/27/2014 09:05 PM, Gonglei (Arei) wrote: >> a. Optimization the xbzrle remarkable decrease the cache misses. >>The efficiency of compress increases more than fifty times. >>Before the patch set, the cache almost totally miss when the >>number of cache item less than the dirty p

Re: [Qemu-devel] [PATCH 0/7] migration: Optimization the xbzrle and fix two corruption issues

2014-02-28 Thread 陈梁
> * Gonglei (arei.gong...@huawei.com) wrote: >> On 2014/2/28 17:19, Dr. David Alan Gilbert wrote: >> >>> * Gonglei (Arei) (arei.gong...@huawei.com) wrote: >>> >>> Hi, >>> a. Optimization the xbzrle remarkable decrease the cache misses. The efficiency of compress increases more than

[Qemu-devel] QEMU on ARM64

2014-02-28 Thread Chalamarla, Tirumalesh
Hi, Is there any one, trying out cross compiling and running qemu on aarch64 host. if so is there a development branch where this wrok is progressing. Some one could please let me know the plan/time frame, for qemu on arm64 hosts running arm64 guests. Regards,

Re: [Qemu-devel] [PATCH 1/2] [RFC] Convert active timers list to use RCU V2

2014-02-28 Thread Alex Bligh
Mike, This one's nice and clear. A few comments in line. On 27 Feb 2014, at 19:35, Mike Day wrote: > @@ -184,16 +178,17 @@ bool qemu_clock_has_timers(QEMUClockType type) > bool timerlist_expired(QEMUTimerList *timer_list) > { > int64_t expire_time; > +bool ret; > > -qemu_mutex_lock(

[Qemu-devel] [Bug 1285505] Re: [ppa 2.0~git-20140225] SIGABRT with -virtfs

2014-02-28 Thread Serge Hallyn
type passed to type_get_by_name() was "virtio-9p-device". It returned NULL. Looking at the compile output, in fact ./hw/9pfs/virtio-9p-device.o did not get compiled after commit ba1183da9a10b94611cad88c44a5c6df005f9b55. -- You received this bug notification because you are a member of qemu- de

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Richard Henderson
On 02/28/2014 11:28 AM, Thomas Falcon wrote: > How about this instead? > > int len = ppc_cpu_gdb_register_len(n); > if (len==4) { > bswap32s((uint32_t *)mem_buf); > } else { > bswap64s((uint64_t *)mem_buf); > } Looks much better, thanks. r~

Re: [Qemu-devel] [PATCH 2/2] [RFC] Convert Clock Timerlists to RCU V2

2014-02-28 Thread Alex Bligh
Mike On 27 Feb 2014, at 19:35, Mike Day wrote: > timerlists is a list of lists that holds active timers, among other > items. It is read-mostly. This patch converts read access to the > timerlists to use RCU. > > Rather than introduce a second mutex for timerlists, which would > require nested m

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-02-28 Thread Neil Skrypuch
On Thursday 30 January 2014 13:23:04 Neil Skrypuch wrote: > First, let me briefly outline the way we use live migration, as it is > probably not typical. We use live migration (with block migration) to make > backups of VMs with zero downtime. The basic process goes like this: > > 1) migrate src V

[Qemu-devel] [qom-cpu PATCH 02/10] target-i386: Merge feature filtering/checking functions

2014-02-28 Thread Eduardo Habkost
Merge filter_features_for_kvm() and kvm_check_features_against_host(). Both functions made exactly the same calculations, the only difference was that filter_features_for_kvm() changed the bits on cpu->features[], and kvm_check_features_against_host() did error reporting. Signed-off-by: Eduardo H

[Qemu-devel] [qom-cpu PATCH 00/10] target-i386: Support check/enforce flags in TCG mode, too

2014-02-28 Thread Eduardo Habkost
This removes some duplication in the CPU feature checking and filtering code in cpu.c, and as a nice side-effect, will make the "check" and "enforce" flags work in TCG mode too. Eduardo Habkost (10): target-i386: Simplify reporting of unavailable features target-i386: Merge feature filtering/c

[Qemu-devel] [qom-cpu PATCH 01/10] target-i386: Simplify reporting of unavailable features

2014-02-28 Thread Eduardo Habkost
Instead of checking and calling unavailable_host_feature() once for each bit, simply call the function (now renamed to report_unavailable_features()) once for each feature word. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletio

[Qemu-devel] [qom-cpu PATCH 04/10] target-i386: Isolate KVM-specific code on CPU feature filtering logic

2014-02-28 Thread Eduardo Habkost
This will allow us to re-use the feature filtering logic (and the check/enforce flag logic) for TCG. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index af82289

[Qemu-devel] [qom-cpu PATCH 05/10] target-i386: Make TCG feature filtering more readable

2014-02-28 Thread Eduardo Habkost
Instead of an #ifdef in the middle of the code, just set TCG_EXT2_FEATURES to a different value depending on TARGET_X86_64. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/c

[Qemu-devel] [qom-cpu PATCH 08/10] target-i386: Define TCG_*_FEATURES earlier on cpu.c

2014-02-28 Thread Eduardo Habkost
Those macros will be used in the feature_word_info array data, so need to be defined earlier. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 116 +++--- 1 file changed, 58 insertions(+), 58 deletions(-) diff --git a/target-i386/cpu.c b/tar

[Qemu-devel] [qom-cpu PATCH 10/10] target-i386: Support check/enforce flags in TCG mode, too

2014-02-28 Thread Eduardo Habkost
If enforce/check is specified in TCG mode, QEMU will ensure all CPU features are supported by TCG, so no CPU feature is silently disabled. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a

[Qemu-devel] [qom-cpu PATCH 09/10] target-i386: Loop-based feature word filtering in TCG mode

2014-02-28 Thread Eduardo Habkost
Instead of manually filtering each feature word, add a tcg_features field to FeatureWordInfo, and use that field to filter all feature words in TCG mode. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [qom-cpu PATCH 06/10] target-i386: Filter FEAT_7_0_EBX TCG features too

2014-02-28 Thread Eduardo Habkost
The TCG_7_0_EBX_FEATURES macro was defined but never used (it even had a typo that was never noticed). Make the existing TCG feature filtering code use it. Change the TCG feature flag filtering code to use it. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 3 ++- 1 file changed, 2 inser

[Qemu-devel] The unholy encrypted image key mess

2014-02-28 Thread Markus Armbruster
The encrypted images Saturday afternoon hack is a gift that keeps on giving. I wish we could rip it out and bury it deep. Or that I could continue to ignore it. Unfortunately, it looks like I need to touch it to clean up error propagation in the monitor. So here goes. A naive user might expect

[Qemu-devel] [qom-cpu PATCH 03/10] target-i386: Pass FeatureWord argument to report_unavailable_features()

2014-02-28 Thread Eduardo Habkost
This will help us simplify the code that calls report_unavailable_features() later. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b46478b..af82289 100644 --- a/target-i386/

[Qemu-devel] [Bug 1285508] Re: [ppa 2.0~git-20140225] mouse cursor invisible with Ubuntu live system

2014-02-28 Thread Serge Hallyn
Interestingly this only happens with sdl. Using vga it works fine. It also works fine in qxl/spice (qemu ... -spice disable- ticketing,port=5930; spicy -h localhost -p 5930). ** Changed in: qemu (Ubuntu) Importance: Undecided => Medium ** Changed in: qemu (Ubuntu) Status: New => Tria

[Qemu-devel] [qom-cpu PATCH 07/10] target-i386: Filter KVM and 0xC0000001 features on TCG

2014-02-28 Thread Eduardo Habkost
TCG doesn't support any of the feature flags on FEAT_KVM and FEAT_C000_0001_EDX feature words, so clear all bits on those feature words. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 4 1 file changed, 4 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1d954d

[Qemu-devel] [PATCH v6] target-ppc: gdbstub allow byte swapping for reading/writing registers

2014-02-28 Thread Thomas Falcon
This patch allows registers to be properly read from and written to when using the gdbstub to debug a ppc guest running in little endian mode. It accomplishes this goal by byte swapping the values of any registers if the MSR:LE value is set. Signed-off-by: Thomas Falcon --- Differences from v5:

Re: [Qemu-devel] [qom-cpu PATCH 00/10] target-i386: Support check/enforce flags in TCG mode, too

2014-02-28 Thread Richard Henderson
On 02/28/2014 12:21 PM, Eduardo Habkost wrote: > This removes some duplication in the CPU feature checking and filtering code > in > cpu.c, and as a nice side-effect, will make the "check" and "enforce" flags > work > in TCG mode too. > > Eduardo Habkost (10): > target-i386: Simplify reporting

Re: [Qemu-devel] The unholy encrypted image key mess

2014-02-28 Thread Eric Blake
On 02/28/2014 02:01 PM, Markus Armbruster wrote: > The encrypted images Saturday afternoon hack is a gift that keeps on > giving. I wish we could rip it out and bury it deep. Or that I could > continue to ignore it. Unfortunately, it looks like I need to touch it > to clean up error propagation

Re: [Qemu-devel] [PATCH V8 04/10] qapi script: check correctness of union

2014-02-28 Thread Wenchao Xia
于 2014/2/28 3:21, Eric Blake 写道: On 02/27/2014 04:09 AM, Wenchao Xia wrote: From: Wenchao Xia Signed-off-by: Wenchao Xia Signed-off-by: Wenchao Xia Double-S-o-B. I've also noticed that I'm getting undeliverable mail rejections from your linux.vnet.ibm.com address: TCVM.MEGACENTER.DE.IBM.COM u

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-28 Thread Wenchao Xia
Markus, do you like the way this version works?

Re: [Qemu-devel] [PATCH v3 21/31] target-arm: Implement AArch64 DAIF system register

2014-02-28 Thread Peter Crosthwaite
On Fri, Feb 28, 2014 at 11:48 PM, Peter Maydell wrote: > On 17 February 2014 00:17, Peter Crosthwaite > wrote: >> On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell >> wrote: >>> Implement the DAIF system register which is a view of the >>> DAIF bits in PSTATE. > >>> +static uint64_t aa64_daif_read

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Peter Maydell
On 28 February 2014 07:08, Chalamarla, Tirumalesh wrote: > Is there any one, trying out cross compiling and running qemu > on aarch64 host. if so is there a development branch where this wrok is > progressing. > >Some one could please let me know the plan/time frame,

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Xuebing wang
On 03/01/2014 08:28 AM, Peter Maydell wrote: (4) using QEMU to emulate an entire AArch64 system that can boot a guest kernel, typically running on an x86 host: we're working on this right now; we have work-in-progress code which will boot a kernel and are working on cleaning it up to upstream q

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Peter Maydell
On 1 March 2014 00:41, Xuebing wang wrote: > On 03/01/2014 08:28 AM, Peter Maydell wrote: >> >> (4) using QEMU to emulate an entire AArch64 system that can boot a guest >> kernel, typically running on an x86 host: we're working on this right now; >> we have work-in-progress code which will boot a

[Qemu-devel] [PATCH] block: qemu-iotests 085 - live snapshots tests

2014-02-28 Thread Jeff Cody
This adds tests for live snapshots, both through the single snapshot command, and the transaction group snapshot command. The snapshots are done through the QMP interface, using the following commands for snapshots: Single snapshot: { 'execute': 'blockdev-snapshot-sync', 'arguments':

Re: [Qemu-devel] Live migration results in non-working virtio-net device (sometimes)

2014-02-28 Thread 陈梁
> On Thursday 30 January 2014 13:23:04 Neil Skrypuch wrote: >> First, let me briefly outline the way we use live migration, as it is >> probably not typical. We use live migration (with block migration) to make >> backups of VMs with zero downtime. The basic process goes like this: >> >> 1) migra

Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Alexander Graf
> Am 01.03.2014 um 03:14 schrieb "Gabriel L. Somlo" : > > Some guests (e.g. 0S X) insist on a minimum lapic version of 0x14. > This patch bumps the emulated lapic version to 0x14 to accomodate that. > > Signed-off-by: Gabriel L. Somlo > --- > > Along with the TCG ioapic polarity fix, this all

Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Gabriel L. Somlo
On Sat, Mar 01, 2014 at 11:44:33AM +0800, Alexander Graf wrote: > Deja vu :). Should we really set this to thd least compatible version or > rather to a current one that resembles roughly what we support? Otherwise > patches like this will come up for every new osx release. > > What is the versi

Re: [Qemu-devel] [PATCH] qemu: x86: report lapic version as 0x14 instead of 0x11

2014-02-28 Thread Alexander Graf
Gabriel L. Somlo wrote: > On Sat, Mar 01, 2014 at 11:44:33AM +0800, Alexander Graf wrote: > >> Deja vu :). Should we really set this to thd least compatible version or >> rather to a current one that resembles roughly what we support? Otherwise >> patches like this will come up for every new o

Re: [Qemu-devel] QEMU on ARM64

2014-02-28 Thread Chalamarla, Tirumalesh
Hi Peter, Thanks for the reply, yes i am interested in (2). i will follow up on the suggested mailing list. Just in case if you know, does the gicv3 support available in QEMU, or there is a plan. Regards, Tirumaqlesh. On 01-Mar-2014, at 5:58 am, Peter Maydell wrote: > On 28 Februa

Re: [Qemu-devel] [PATCH RFC] kvm: ignore apic polarity

2014-02-28 Thread Alex Williamson
On Thu, 2014-02-27 at 19:05 +0200, Michael S. Tsirkin wrote: > apic polarity in KVM does not work: too many things assume active high. > Let's not pretend it works, let's just ignore polarity flag. If we ever > want to emulate it exactly, this will need a feature flag anyway. > > Also report this

Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name

2014-02-28 Thread Markus Armbruster
Wenchao Xia writes: > Markus, do you like the way this version works? I hope to review it early next week.

[Qemu-devel] [PATCH v3 00/13] qapi: Test coverage & clean up generated code

2014-02-28 Thread Markus Armbruster
Coverity is unhappy with the generated code. Nothing serious, just heaps of valid DEADCODE defects topped off with a few bogus FORWARD_NULL defects. I had a look at the generator, and decided I don't want to mess with it without decent test coverage. Unfortunately, a few features have been added

[Qemu-devel] [PATCH v3 02/13] tests/qapi-schema: Cover optional command arguments

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 4 +++- tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-commands.c | 8 +--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/qapi-schema/qa

[Qemu-devel] [PATCH v3 01/13] tests/qapi-schema: Actually check successful QMP command response

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/test-qmp-commands.c | 43 +++ 1 file changed, 35 insertions(+), 8 deletions(-) diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c index 5a3e82a..d039b87 100644 --- a/tests/

[Qemu-devel] [PATCH v3 04/13] tests/qapi-schema: Cover anonymous union types

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 4 tests/qapi-schema/qapi-schema-test.out | 6 +- tests/test-qmp-input-strict.c | 32 tests/test-qmp-input-visitor.c | 18 +++

[Qemu-devel] [PATCH v3 13/13] qapi: Add missing null check to opts_start_struct()

2014-02-28 Thread Markus Armbruster
Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opt

[Qemu-devel] [PATCH v3 06/13] tests/qapi-schema: Cover union types with base

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 1 + tests/qapi-schema/qapi-schema-test.out | 2 +- tests/test-qmp-input-strict.c | 4 ++-- tests/test-qmp-input-visitor.c | 3 ++- tests/test-qmp-output-visitor.c |

[Qemu-devel] [PATCH v3 10/13] qapi: Drop unused code in qapi-commands.py

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-commands.py | 20 1 file changed, 20 deletions(-) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 38c2347..9734ab0 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-comma

[Qemu-devel] [PATCH v3 12/13] qapi: Clean up superfluous null check in qapi_dealloc_type_str()

2014-02-28 Thread Markus Armbruster
Argument can't be null. No other Visitor method type_str() checks for null. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- qapi/qapi-dealloc-visitor.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c

[Qemu-devel] [PATCH v3 05/13] tests/qapi-schema: Cover complex types with base

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 6 +- tests/qapi-schema/qapi-schema-test.out | 6 -- tests/test-qmp-commands.c | 15 ++- tests/test-qmp-input-visitor.c | 4 ++-- tests/test-qmp-o

[Qemu-devel] [PATCH v3 07/13] tests/qapi-schema: Cover flat union types

2014-02-28 Thread Markus Armbruster
The test demonstrates a generator bug: the generated struct UserDefFlatUnion doesn't include members for the indirect base UserDefZero. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 7 +++ tests/qapi-schema/qapi-schema-test.out | 2

[Qemu-devel] [PATCH v3 03/13] tests/qapi-schema: Cover simple argument types

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/qapi-schema/qapi-schema-test.json | 2 ++ tests/qapi-schema/qapi-schema-test.out | 1 + tests/test-qmp-commands.c | 16 3 files changed, 19 insertions(+) diff --git a/tests/qapi-schema/qapi-sche

[Qemu-devel] [PATCH v3 11/13] qapi: Clean up null checking in generated visitors

2014-02-28 Thread Markus Armbruster
Visitors get passed a pointer to the visited object. The generated visitors try to cope with this pointer being null in some places, for instance like this: visit_start_optional(m, obj ? &(*obj)->has_name : NULL, "name", &err); visit_start_optional() passes its second argument to Visitor met

[Qemu-devel] [PATCH v3 09/13] qapi: Drop nonsensical header guard in generated qapi-visit.c

2014-02-28 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-visit.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index b2a1c1c..97e9b11 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -494,10 +494,8 @@ fdecl.w

[Qemu-devel] [PATCH v3 08/13] qapi: Fix licensing of scripts

2014-02-28 Thread Markus Armbruster
The scripts carry this copyright notice: # This work is licensed under the terms of the GNU GPLv2. # See the COPYING.LIB file in the top-level directory. The sentences contradict each other, as COPYING.LIB contains the LGPL 2.1. Michael Roth says this was a simple pasto, and he meant to

<    1   2   3