Re: [Qemu-devel] [PATCH] block: Don't throw away errno via error_setg

2014-02-13 Thread Kevin Wolf
Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben: > There are a handful of places in the block layer where a failure path > has a valid -errno value, yet error_setg() is used. Those instances > should instead use error_setg_errno(), to preserve as much error > information as possible. > > This pa

Re: [Qemu-devel] [PATCH] qemu-iotests: Don't run 005 on vmdk split formats

2014-02-13 Thread Kevin Wolf
Am 13.02.2014 um 03:05 hat Fam Zheng geschrieben: > There would be too many extents that VMDK driver can't open all of them: > > 005 0s ... - output mismatch (see 005.out.bad) > --- 005.out 2013-12-24 09:27:27.608181030 +0800 > +++ 005.out.bad 2014-02-13 10:00:15.282184557 +0800 >

Re: [Qemu-devel] [PATCH] linux-user: simplify/refactor socketcall implementation

2014-02-13 Thread Michael Tokarev
12 февраля 2014 г. 23:40:46 GMT+04:00, Peter Maydell : >I think it would be nice to have here: >assert(ac[num] <= ARRAY_SIZE(a)); > >just as a reminder to bump the ac[] array size if anybody adds a >7-argument >function in future. Yeah good point, I'll add this assert. Thank you! >Otherwise >

Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.

2014-02-13 Thread Kevin Wolf
Am 12.02.2014 um 20:49 hat Benoît Canet geschrieben: > The Tuesday 11 Feb 2014 à 16:12:17 (+0800), Fam Zheng wrote : > > On Mon, 02/10 22:49, Benoît Canet wrote: > > > Take into account the fact that a block filter like quorum will be in > > > bs->file > > > while a regular block driver device is

Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.

2014-02-13 Thread Kevin Wolf
Am 13.02.2014 um 02:51 hat Benoît Canet geschrieben: > Signed-off-by: Benoit Canet > --- > block.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Should be [PATCH v3] in the subject line. > diff --git a/block.c b/block.c > index 70d7f35..d9553ba 100644 > --- a/block.c > +++ b/bloc

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Max Filippov
Hi, On Thu, Feb 13, 2014 at 11:34 AM, Alexey Kardashevskiy wrote: > Hi! > > I am debugging spapr-vlan and hit the following issue. > > When I run QEMU as below, the kernel's DHCP client does not continue till I > hit any key in console. If I replace spapr-vlan with > e1000/rtl8139/virtio-net, eve

Re: [Qemu-devel] [PATCH] block: mirror - insure that errp is not NULL

2014-02-13 Thread Kevin Wolf
Am 12.02.2014 um 20:46 hat Jeff Cody geschrieben: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If e

Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.

2014-02-13 Thread Benoît Canet
The Thursday 13 Feb 2014 à 09:33:52 (+0100), Kevin Wolf wrote : > Am 13.02.2014 um 02:51 hat Benoît Canet geschrieben: > > Signed-off-by: Benoit Canet > > --- > > block.c | 6 +- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > Should be [PATCH v3] in the subject line. > > > diff --gi

Re: [Qemu-devel] [PATCH v2] RFC: Add blockdev-del QMP command

2014-02-13 Thread Kevin Wolf
Am 12.02.2014 um 18:36 hat Ian Main geschrieben: > This is the sister command to blockdev-add. In Fam's example he uses > the drive_del HMP command to clean up but it would be much nicer to > have a way to do this via QMP. > > Signed-off-by: Ian Main > diff --git a/qapi-schema.json b/qapi-schem

Re: [Qemu-devel] [PATCH V17 11/12] quorum: Add quorum_open() and quorum_close().

2014-02-13 Thread Benoît Canet
The Wednesday 12 Feb 2014 à 23:06:38 (+0100), Benoît Canet wrote : > From: Benoît Canet > > Example of command line: > -drive if=virtio,file.driver=quorum,\ > file.children.0.file.filename=1.raw,\ > file.children.0.node-name=1.raw,\ > file.children.0.driver=raw,\ > file.children.1.file.filename=2

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-13 Thread Alex Bligh
Mike, On 12 Feb 2014, at 19:09, Mike Day wrote: > Allow readers to use RCU when reading Qemu timer lists. Applies to > Paolo Bonzini's RCU branch, https://github.com/bonzini/qemu/tree/rcu. > > This patch is for comment and review only. The rcu branch needs to be > rebased on upstream. I'll cer

[Qemu-devel] [PATCH] hw/timer/grlib_gptimer: Avoid integer overflow

2014-02-13 Thread Sebastian Huber
The GPTIMER uses 32-bit registers. Use a 64-bit operation to get the ptimer count, otherwise we end up with a count of 0 for GPTIMER counter values of 0x. --- hw/timer/grlib_gptimer.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/timer/grlib_gptimer.c b/hw

[Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-13 Thread Christian Borntraeger
We have to set the cssid to 0, otherwise the stsch code will return an operand exception without the m bit. In the same way we should set m=0. This case was triggered in some cases during reboot, if for some reason the location of blk_schid.cssid contains 1 and m was 0. Turns out that the qemu elf

[Qemu-devel] [PULL 1/3] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx

2014-02-13 Thread Christian Borntraeger
The current code does not initialize next_idx as the qemu elf loader does not zero the bss section. Make the initialization explicit. Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw/virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-cc

[Qemu-devel] [PULL 3/3] s390-ccw.img: new binary rom to match latest fixes

2014-02-13 Thread Christian Borntraeger
Signed-off-by: Christian Borntraeger --- pc-bios/s390-ccw.img | Bin 9336 -> 9336 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 6727f0ca39d6bf6d114974d1535cb7ad9e56355f..f6223e77c2aacfa86652d63b773dc05eca55570d 100644 GIT b

[Qemu-devel] [PULL 0/3] s390-ccw.img: fix sporadic boot errors

2014-02-13 Thread Christian Borntraeger
u.git tags/ipl-20140213 for you to fetch changes up to 669d13daaf31e81463d081f59ee88e4f75dc7538: s390-ccw.img: new binary rom to match latest fixes (2014-02-13 09:59:21 +0100) These changes make the reipl more robust. This fixes tw

Re: [Qemu-devel] [PULL 0/3] s390-ccw.img: fix sporadic boot errors

2014-02-13 Thread Peter Maydell
+) > > are available in the git repository at: > > > git://github.com/borntraeger/qemu.git tags/ipl-20140213 > > for you to fetch changes up to 669d13daaf31e81463d081f59ee88e4f75dc7538: > > s390-ccw.img: new binary rom to match latest fixes (2014-02-13 09:59:21

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-13 Thread Paolo Bonzini
Il 13/02/2014 10:11, Alex Bligh ha scritto: Mike, On 12 Feb 2014, at 19:09, Mike Day wrote: Allow readers to use RCU when reading Qemu timer lists. Applies to Paolo Bonzini's RCU branch, https://github.com/bonzini/qemu/tree/rcu. This patch is for comment and review only. The rcu branch needs

Re: [Qemu-devel] [PULL 0/3] s390-ccw.img: fix sporadic boot errors

2014-02-13 Thread Christian Borntraeger
ull-libcacard.glusterfs' into >> staging (2014-02-12 17:53:31 +) >> >> are available in the git repository at: >> >> >> git://github.com/borntraeger/qemu.git tags/ipl-20140213 >> >> for you to fetch changes up to 669d13daaf31e81463d081f59ee

Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

2014-02-13 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 10/02/2014 16:28, Eric Blake ha scritto: | On 02/10/2014 07:20 AM, Markus Armbruster wrote: |> Argument is null when visiting an unboxed struct. I can't see |> such a visit in the current code. Fix it anyway. | | Is this a sign of missing testsui

Re: [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code

2014-02-13 Thread Paolo Bonzini
Il 10/02/2014 15:20, Markus Armbruster ha scritto: Coverity is unhappy with the generated code. Nothing serious, just heaps of valid DEADCODE defects topped off with a few bogus FORWARD_NULL defects. I had a look at the generator, and decided I don't want to mess with it without decent test cov

Re: [Qemu-devel] [PULL 1/3] s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx

2014-02-13 Thread Cornelia Huck
On Thu, 13 Feb 2014 10:17:09 +0100 Christian Borntraeger wrote: > The current code does not initialize next_idx as the qemu > elf loader does not zero the bss section. > Make the initialization explicit. > > Signed-off-by: Christian Borntraeger > --- > pc-bios/s390-ccw/virtio.c | 1 + > 1 file

Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-13 Thread Cornelia Huck
On Thu, 13 Feb 2014 10:17:10 +0100 Christian Borntraeger wrote: > We have to set the cssid to 0, otherwise the stsch code will > return an operand exception without the m bit. In the same way > we should set m=0. > > This case was triggered in some cases during reboot, if for some > reason the l

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-02-13 Thread Igor Mammedov
On Thu, 13 Feb 2014 14:14:08 +0800 Chen Fan wrote: > On Tue, 2014-01-21 at 11:10 +0100, Andreas Färber wrote: > > Am 21.01.2014 10:51, schrieb Chen Fan: > > > On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov wrote: > > >> On Tue, 21 Jan 2014 15:12:45 +0800 > > >> Chen Fan wrote: > > >>> On Mon,

[Qemu-devel] LWN article: "Best practices for a big patch series"

2014-02-13 Thread Paolo Bonzini
A large part of this article applies just as well to QEMU: http://lwn.net/SubscriberLink/585782/c50c5822364d5fd5/ Note: The "subscriber link" mechanism allows an LWN.net subscriber to generate a special URL for a subscription-only article. That URL can then be given to others, who will be

[Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-13 Thread Sebastian Huber
The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to generate C11 atomic operations. The CAS synthetic instruction uses an ASI of 0x80. If TARGET_SPARC

Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-13 Thread Peter Maydell
On 13 February 2014 09:17, Christian Borntraeger wrote: > static void virtio_setup(uint64_t dev_info) > { > +struct subchannel_id blk_schid = { .one = 1}; Missing space before the "}" I think. thanks -- PMM

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-02-13 Thread Igor Mammedov
On Tue, 21 Jan 2014 11:10:30 +0100 Andreas Färber wrote: > Am 21.01.2014 10:51, schrieb Chen Fan: > > On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov wrote: > >> On Tue, 21 Jan 2014 15:12:45 +0800 > >> Chen Fan wrote: > >>> On Mon, 2014-01-20 at 13:29 +0100, Igor Mammedov wrote: > On Fri,

Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-13 Thread Christian Borntraeger
On 13/02/14 10:55, Peter Maydell wrote: > On 13 February 2014 09:17, Christian Borntraeger > wrote: >> static void virtio_setup(uint64_t dev_info) >> { >> +struct subchannel_id blk_schid = { .one = 1}; > > Missing space before the "}" I think. checkpatch accepts both ways: a)struct su

[Qemu-devel] [PATCH] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1].

2014-02-13 Thread Huw Davies
It's this that should be subtracted from 0x20 when converting to a right rotate. Signed-off-by: Huw Davies --- tcg/arm/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 82658a1..c8884b3 100644 --- a/tcg/arm/tcg-targ

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Alexey Kardashevskiy
On 02/13/2014 07:40 PM, Max Filippov wrote: > Hi, > > On Thu, Feb 13, 2014 at 11:34 AM, Alexey Kardashevskiy wrote: >> Hi! >> >> I am debugging spapr-vlan and hit the following issue. >> >> When I run QEMU as below, the kernel's DHCP client does not continue till I >> hit any key in console. If I

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-13 Thread Greg Kurz
On Thu, 13 Feb 2014 08:29:28 +0530 "Aneesh Kumar K.V" wrote: > From: "Aneesh Kumar K.V" > > Correctly update the htab_mask using the return value of > KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 > on GET_SREGS for HV. We check for external htab and if > found true, we don't need to u

Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-13 Thread Peter Maydell
On 13 February 2014 10:05, Christian Borntraeger wrote: > On 13/02/14 10:55, Peter Maydell wrote: >> On 13 February 2014 09:17, Christian Borntraeger >> wrote: >>> static void virtio_setup(uint64_t dev_info) >>> { >>> +struct subchannel_id blk_schid = { .one = 1}; >> >> Missing space befor

Re: [Qemu-devel] [PATCH] hw/timer/grlib_gptimer: Avoid integer overflow

2014-02-13 Thread Fabien Chouteau
On 02/13/2014 10:16 AM, Sebastian Huber wrote: > The GPTIMER uses 32-bit registers. Use a 64-bit operation to get the > ptimer count, otherwise we end up with a count of 0 for GPTIMER counter > values of 0x. Looks good, thanks Sebastian. Reviewed-by: Fabien Chouteau > --- > hw/timer/g

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-13 Thread Fabien Chouteau
On 02/13/2014 10:52 AM, Sebastian Huber wrote: > The LEON3 processor has support for the CASA instruction which is > normally only available for SPARC V9 processors. Binutils 2.24 > and GCC 4.9 will support this instruction for LEON3. GCC uses it to > generate C11 atomic operations. > > The CAS

[Qemu-devel] [PATCH v8 00/17] Vhost and vhost-net support for userspace based backends

2014-02-13 Thread Antonios Motakis
In this patch series we would like to introduce our approach for putting a virtio-net backend in an external userspace process. Our eventual target is to run the network backend in the Snabbswitch ethernet switch, while receiving traffic from a guest inside QEMU/KVM which runs an unmodified virtio-

[Qemu-devel] [PATCH v8 05/17] Add G_IO_HUP handler for socket chardev

2014-02-13 Thread Antonios Motakis
This is used to detect that the remote end has disconnected. Just call tcp_char_disconnect on receiving this event. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- qemu-char.c | 16 1 file changed, 16 insertions(+) diff --git a/qemu-char.c b/qemu-char.c ind

[Qemu-devel] [PATCH v8 03/17] Add chardev API qemu_chr_fe_set_msgfds

2014-02-13 Thread Antonios Motakis
This will set an array of file descriptors to the internal structures. The next time a message is sent the array will be sent as ancillary data. This feature works with the Unix domain socket backend only. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- include/sysemu/char.h

[Qemu-devel] [PATCH v8 01/17] Convert -mem-path to QemuOpts and add prealloc and share properties

2014-02-13 Thread Antonios Motakis
Extend -mem-path with additional properties: - prealloc=on|off - default off, same as -mem-prealloc - share=on|off - default off, memory is mmapped with MAP_SHARED flag Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- exec.c | 30 +++

[Qemu-devel] [PATCH v8 02/17] Add chardev API qemu_chr_fe_read_all

2014-02-13 Thread Antonios Motakis
This function will attempt to read data from the chardev trying to fill the buffer up to the given length. Add tcp_chr_disconnect to reuse disconnection code where needed. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- include/sysemu/char.h | 14 + qemu-char.c

[Qemu-devel] [PATCH v8 06/17] vhost_net should call the poll callback only when it is set

2014-02-13 Thread Antonios Motakis
The poll callback needs to be called when bringing up or down the vhost_net instance. As it is not mandatory for an NetClient to implement it, invoke it only when it is set. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c | 13 ++--- 1 file changed

[Qemu-devel] [PATCH v8 11/17] Add vhost-backend and VhostBackendType

2014-02-13 Thread Antonios Motakis
Use vhost_set_backend_type to initialise a proper vhost_ops structure. In vhost_net_init and vhost_net_start_one call conditionally TAP related initialisation depending on the vhost backend type. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c

[Qemu-devel] [PATCH v8 04/17] Add chardev API qemu_chr_fe_get_msgfds

2014-02-13 Thread Antonios Motakis
This extends the existing qemu_chr_fe_get_msgfd by allowing to read a set of fds. The function for receiving the fds - unix_process_msgfd is extended to allocate the needed array size. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- include/sysemu/char.h | 15 - qemu

[Qemu-devel] [PATCH v8 07/17] Refactor virtio-net to use generic get_vhost_net

2014-02-13 Thread Antonios Motakis
This decouples virtio-net from the TAP netdev backend and allows support for other backends to be implemented. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c | 30 +++--- hw/net/virtio-net.c | 39 ++

[Qemu-devel] [PATCH v8 08/17] vhost_net_init will use VhostNetOptions to get all its arguments

2014-02-13 Thread Antonios Motakis
vhost_dev_init will replace devfd and devpath with a single opaque argument. This is initialised with a file descriptor. When TAP is used (through vhost_net), open /dev/vhost-net and pass the fd as an opaque parameter in VhostNetOptions. The same applies to vhost-scsi - open /dev/vhost-scsi and pas

[Qemu-devel] [PATCH v8 14/17] Add the vhost-user netdev backend to the command line

2014-02-13 Thread Antonios Motakis
The supplied chardev id will be inspected for supported options. Only a socket backend, with a set path (i.e. a Unix socket) and optionally the server parameter set, will be allowed. Other options (nowait, telnet) will make the chardev unusable and the netdev will not be initialised. Additional ch

[Qemu-devel] [PATCH v8 12/17] Add vhost-user as a vhost backend

2014-02-13 Thread Antonios Motakis
At initialization takes a chardev backed by a unix domain socket. It should implement qemu_fe_set_msgfds in order to be able to pass file descriptors to the remote process. Each ioctl request of vhost-kernel has a vhost-user message equivalent, which is sent over the control socket. The general a

[Qemu-devel] [PATCH v8 10/17] Add mandatory_features to vhost_dev

2014-02-13 Thread Antonios Motakis
This will be used in a following patch to ensure that a vhost-user client reconnecting to QEMU supports the features that were exposed by the first client that initiated the virtio-net session. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- hw/net/vhost_net.c| 10 ++

[Qemu-devel] [PATCH v8 15/17] Add vhost-user protocol documentation

2014-02-13 Thread Antonios Motakis
This document describes the basic message format used by vhost-user for communication over a unix domain socket. The protocol is based on the existing ioctl interface used for the kernel version of vhost. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev --- docs/specs/vhost-user.

[Qemu-devel] [PATCH v8 09/17] Add vhost_ops to vhost_dev struct and replace all relevant ioctls

2014-02-13 Thread Antonios Motakis
Decouple vhost from the Linux kernel by introducing vhost_ops. The intention is to provide different backends - 'kernel' backend based on the ioctl interface, and 'user' backend based on an Unix domain socket and shared memory. Signed-off-by: Antonios Motakis Signed-off-by: Nikolay Nikolaev ---

[Qemu-devel] [PATCH v8 13/17] Add new vhost-user netdev backend

2014-02-13 Thread Antonios Motakis
Add a new QEMU netdev backend that is intended to invoke vhost_net with the vhost-user backend. It uses an Unix socket chardev to establish a communication with the 'slave' (client and server mode supported). At runtime the netdev will handle OPEN/CLOSE events from the chardev. Upon disconnection

[Qemu-devel] [PATCH v8 16/17] libqemustub: add stubs to be able to use qemu-char.c

2014-02-13 Thread Antonios Motakis
chardev depends on lots of external symbols that are not necessarily needed to be able to use, for example, 'socket chardev'. So add stubs for these functions: - bdrv_commit_all - qemu_chr_open_msmouse - is_daemonized - qemu_add_machine_init_done_notifier - monitor_init - qemu_notify_event

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-13 Thread Mike Day
On Thu, Feb 13, 2014 at 4:25 AM, Paolo Bonzini wrote: > Il 13/02/2014 10:11, Alex Bligh ha scritto: >> >> I'll certainly have a look through this. However before I do, what >> problem is this trying to solve? Do we think there is possibility >> of contention on the active timers lock? I used to th

[Qemu-devel] [PATCH v8 17/17] Add qtest for vhost-user

2014-02-13 Thread Antonios Motakis
This test creates a 'server' chardev to listen for vhost-user messages. Once VHOST_USER_SET_MEM_TABLE is received it mmaps each received region, and read 1k bytes from it. The read data is compared to data from readl. The test requires hugetlbfs to be already mounted and writable. The mount point

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Max Filippov
On Thu, Feb 13, 2014 at 2:34 PM, Alexey Kardashevskiy wrote: > On 02/13/2014 07:40 PM, Max Filippov wrote: >> Hi, >> >> On Thu, Feb 13, 2014 at 11:34 AM, Alexey Kardashevskiy >> wrote: >>> Hi! >>> >>> I am debugging spapr-vlan and hit the following issue. >>> >>> When I run QEMU as below, the ke

Re: [Qemu-devel] [PATCH v13 02/14] block: Introduce op_blockers to BlockDriverState

2014-02-13 Thread Benoît Canet
The Wednesday 29 Jan 2014 à 13:07:29 (+0800), Fam Zheng wrote : > BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX > elements. Each list is a list of blockers of an operation type > (BlockOpType), that marks this BDS as currently blocked for a certain > type of operation wit

Re: [Qemu-devel] [PATCH v13 03/14] block: Replace in_use with operation blocker

2014-02-13 Thread Benoît Canet
The Wednesday 29 Jan 2014 à 13:07:30 (+0800), Fam Zheng wrote : > This drops BlockDriverState.in_use with op_blockers: > > - Call bdrv_op_block_all in place of bdrv_set_in_use(bs, 1). > - Call bdrv_op_unblock_all in place of bdrv_set_in_use(bs, 0). > - Check bdrv_op_is_blocked() in place of

Re: [Qemu-devel] [PATCH v13 02/14] block: Introduce op_blockers to BlockDriverState

2014-02-13 Thread Benoît Canet
The Wednesday 29 Jan 2014 à 13:07:29 (+0800), Fam Zheng wrote : > BlockDriverState.op_blockers is an array of lists with BLOCK_OP_TYPE_MAX > elements. Each list is a list of blockers of an operation type > (BlockOpType), that marks this BDS as currently blocked for a certain > type of operation wit

Re: [Qemu-devel] [PATCH 2/2] vl: convert -m to QemuOpts

2014-02-13 Thread Igor Mammedov
On Mon, 10 Feb 2014 18:38:59 +0100 Laszlo Ersek wrote: > comments below > > On 02/06/14 09:16, Igor Mammedov wrote: > > Adds option to -m > > "mem" - startup memory amount > > > > For compatibility with legacy CLI if suffix-less number is passed, > > it assumes amount in Mb. > > > > Otherwise

Re: [Qemu-devel] [PATCH v13 05/14] block: Add bdrv_set_backing_hd()

2014-02-13 Thread Benoît Canet
The Wednesday 29 Jan 2014 à 13:07:32 (+0800), Fam Zheng wrote : > This is the common but non-trivial steps to assign or change the > backing_hd of BDS. > > Signed-off-by: Fam Zheng > --- > block.c | 34 +- > include/block/block.h | 1 + > 2 files ch

Re: [Qemu-devel] [PATCH] [RFC] Convert Qemu Timer List and Active Timers to RCU

2014-02-13 Thread Alex Bligh
On 13 Feb 2014, at 12:06, Mike Day wrote: >> I think that, more than contention, it tries to reduce the cost of >> synchronization primitives, especially the locking and unlocking of the list >> around the invocation of timer callbacks. > > Yes, the assumption is that the active timers are a rea

Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

2014-02-13 Thread Christian Borntraeger
On 13/02/14 12:04, Peter Maydell wrote: > On 13 February 2014 10:05, Christian Borntraeger > wrote: >> On 13/02/14 10:55, Peter Maydell wrote: >>> On 13 February 2014 09:17, Christian Borntraeger >>> wrote: static void virtio_setup(uint64_t dev_info) { +struct subchannel_id

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-13 Thread Sebastian Huber
On 2014-02-13 13:01, Fabien Chouteau wrote: On 02/13/2014 10:52 AM, Sebastian Huber wrote: The LEON3 processor has support for the CASA instruction which is normally only available for SPARC V9 processors. Binutils 2.24 and GCC 4.9 will support this instruction for LEON3. GCC uses it to genera

Re: [Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-13 Thread Eric Blake
On 02/12/2014 06:48 PM, Qiao Nuohan wrote: >>From c729625031c88b0bf32bae50c39f81585303cc52 Mon Sep 17 00:00:00 2001 > From: qiaonuohan > Date: Thu, 13 Feb 2014 09:39:26 +0800 > Subject: [PATCH v11 13/13] dump: add 'query-dump-guest-memory-capability' > command > > 'query-dump-guest-memory-capab

Re: [Qemu-devel] [PATCH v13 07/14] block: Parse "backing" option to reference existing BDS

2014-02-13 Thread Benoît Canet
The Wednesday 29 Jan 2014 à 13:07:34 (+0800), Fam Zheng wrote : > Now it's safe to allow reference for backing_hd in the interface. > > Signed-off-by: Fam Zheng > --- > block.c | 26 -- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c

[Qemu-devel] Trying to write a new device / virtio-i2c ?

2014-02-13 Thread Alex David
Hello, I'm new to QEMU and kinda new to driver & QEMU programming in general, so please excuse my questions... I want to develop a new QEMU i2c device (qemu x86), that would get/send data to an application running on the guest. Thing is : I need these data onto the host, as a daemon will send/get

Re: [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code

2014-02-13 Thread Luiz Capitulino
On Thu, 13 Feb 2014 10:31:17 +0100 Paolo Bonzini wrote: > Il 10/02/2014 15:20, Markus Armbruster ha scritto: > > Coverity is unhappy with the generated code. Nothing serious, just > > heaps of valid DEADCODE defects topped off with a few bogus > > FORWARD_NULL defects. > > > > I had a look at th

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Alexey Kardashevskiy
On 02/13/2014 11:23 PM, Max Filippov wrote: > On Thu, Feb 13, 2014 at 2:34 PM, Alexey Kardashevskiy wrote: >> On 02/13/2014 07:40 PM, Max Filippov wrote: >>> Hi, >>> >>> On Thu, Feb 13, 2014 at 11:34 AM, Alexey Kardashevskiy >>> wrote: Hi! I am debugging spapr-vlan and hit the fol

Re: [Qemu-devel] [PATCH v13 10/14] qmp: Add command 'blockdev-backup'

2014-02-13 Thread Benoît Canet
The Wednesday 29 Jan 2014 à 13:07:37 (+0800), Fam Zheng wrote : > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Also add blocker on target bs, since the target is also a named device > now. > > Add check and report error for

[Qemu-devel] [PATCH v2 0/2] convert -m to QemuOpts

2014-02-13 Thread Igor Mammedov
changes since v1: - check for overflow - check for empty mem="" case - reshuffle code to avoid conflicts with another series on list - some style/typo fixes changes since RFC: - resolved conflict with error_abort change in qemu_get_machine_opts() git tree for testing: https://github.com/i

[Qemu-devel] [PATCH v2 1/2] QemuOpts: introduce qemu_find_opts_singleton

2014-02-13 Thread Igor Mammedov
From: Paolo Bonzini Allows to use singleton idiom for getting access to a specified option list pre-creating it if necessary. Signed-off-by: Paolo Bonzini Signed-off-by: Igor Mammedov Reviewed-by: Laszlo Ersek --- include/qemu/config-file.h |2 ++ util/qemu-config.c | 14 ++

Re: [Qemu-devel] [PATCH v2 00/13] qapi: Test coverage & clean up generated code

2014-02-13 Thread Luiz Capitulino
On Thu, 13 Feb 2014 08:41:48 -0500 Luiz Capitulino wrote: > On Thu, 13 Feb 2014 10:31:17 +0100 > Paolo Bonzini wrote: > > > Il 10/02/2014 15:20, Markus Armbruster ha scritto: > > > Coverity is unhappy with the generated code. Nothing serious, just > > > heaps of valid DEADCODE defects topped o

[Qemu-devel] [PATCH v2 2/2] vl: convert -m to QemuOpts

2014-02-13 Thread Igor Mammedov
Adds option to -m "mem" - startup memory amount For compatibility with legacy CLI if suffix-less number is passed, it assumes amount in Mb. Otherwise user is free to use suffixed number using suffixes b,k/K,M,G Signed-off-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- v2: - various fixes

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Max Filippov
On Thu, Feb 13, 2014 at 5:42 PM, Alexey Kardashevskiy wrote: > On 02/13/2014 11:23 PM, Max Filippov wrote: >> On Thu, Feb 13, 2014 at 2:34 PM, Alexey Kardashevskiy wrote: >>> On 02/13/2014 07:40 PM, Max Filippov wrote: Hi, On Thu, Feb 13, 2014 at 11:34 AM, Alexey Kardashevskiy >>

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Alexey Kardashevskiy
On 02/14/2014 01:02 AM, Max Filippov wrote: > On Thu, Feb 13, 2014 at 5:42 PM, Alexey Kardashevskiy wrote: >> On 02/13/2014 11:23 PM, Max Filippov wrote: >>> On Thu, Feb 13, 2014 at 2:34 PM, Alexey Kardashevskiy >>> wrote: On 02/13/2014 07:40 PM, Max Filippov wrote: > Hi, > > On

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Max Filippov
On Thu, Feb 13, 2014 at 6:06 PM, Alexey Kardashevskiy wrote: > On 02/14/2014 01:02 AM, Max Filippov wrote: >> On Thu, Feb 13, 2014 at 5:42 PM, Alexey Kardashevskiy wrote: >>> On 02/13/2014 11:23 PM, Max Filippov wrote: On Thu, Feb 13, 2014 at 2:34 PM, Alexey Kardashevskiy wrote: >

[Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Jeff Cody
When starting a block job, commit_active_start() relies on whether *errp is set by mirror_start_job. This allows it to determine if the mirror job start failed, so that it can clean up any changes to open flags from the bdrv_reopen(). If errp is NULL, then it will not be able to determine if mirr

Re: [Qemu-devel] tap networking - how?

2014-02-13 Thread Alexey Kardashevskiy
On 02/14/2014 01:17 AM, Max Filippov wrote: > On Thu, Feb 13, 2014 at 6:06 PM, Alexey Kardashevskiy wrote: >> On 02/14/2014 01:02 AM, Max Filippov wrote: >>> On Thu, Feb 13, 2014 at 5:42 PM, Alexey Kardashevskiy >>> wrote: On 02/13/2014 11:23 PM, Max Filippov wrote: > On Thu, Feb 13, 20

[Qemu-devel] [PATCH] hw/arm/vexpress: Set reset-cbar property for CPUs

2014-02-13 Thread Peter Maydell
Newer versions of the Linux kernel (as of commit bc41b8724 in 3.12) now assume that if the CPU is a Cortex-A9 and the reset value of the PERIPHBASE/CBAR register is zero then the CPU is a specific buggy single core A9 SoC, and will not try to start other cores. Since we now have a CPU property for

Re: [Qemu-devel] [PULL 28/48] tests: Add ipoctal232 qtest

2014-02-13 Thread Alberto Garcia
On Mon, Feb 10, 2014 at 07:36:45PM +0100, Andreas Färber wrote: > Cc: Alberto Garcia > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Andreas Färber > --- > tests/Makefile | 7 +++ > tests/ipoctal232-test.c | 33 + > 2 files changed, 40 insertions(+

Re: [Qemu-devel] [PULL 27/48] tests: Add tpci200 qtest

2014-02-13 Thread Alberto Garcia
On Mon, Feb 10, 2014 at 07:36:44PM +0100, Andreas Färber wrote: > Cc: Alberto Garcia > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Andreas Färber > --- > tests/Makefile | 3 +++ > tests/tpci200-test.c | 33 + > 2 files changed, 36 insertions(+) > creat

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Kevin Wolf
Am 13.02.2014 um 15:23 hat Jeff Cody geschrieben: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If e

Re: [Qemu-devel] [PATCH v3 1/1] Define the architecture for compressed dump format.

2014-02-13 Thread Luiz Capitulino
On Fri, 31 Jan 2014 16:04:41 +0100 Ekaterina Tumanova wrote: > Signed-off-by: Ekaterina Tumanova Applied to the qmp branch, thanks. > --- > dump.c | 7 +-- > target-i386/cpu.h | 2 ++ > target-s390x/cpu.h | 1 + > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-13 Thread Luiz Capitulino
On Thu, 13 Feb 2014 09:48:33 +0800 Qiao Nuohan wrote: > On 02/12/2014 10:49 PM, Luiz Capitulino wrote: > > On Wed, 12 Feb 2014 14:34:19 +0800 > > Qiao Nuohan wrote: > > > >> 'query-dump-guest-memory-capability' is used to query the available > >> formats for > >> 'dump-guest-memory'. The output

Re: [Qemu-devel] [PATCH RFC] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-02-13 Thread David Marchand
Hello, Can someone take a look at my previous email and tell me if my patch is just wrong ? Thank you. -- David Marchand On Tue, Feb 4, 2014 at 10:17 PM, David Marchand wrote: > Hello, > > First of all, this is a pure RFC patch, I did not take too much time to > dig into > qemu source code

Re: [Qemu-devel] [Qemu-ppc] [PATCH V10] target-ppc: Fix htab_mask calculation

2014-02-13 Thread Alexander Graf
On 13.02.2014, at 11:40, Greg Kurz wrote: > On Thu, 13 Feb 2014 08:29:28 +0530 > "Aneesh Kumar K.V" wrote: > >> From: "Aneesh Kumar K.V" >> >> Correctly update the htab_mask using the return value of >> KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1 >> on GET_SREGS for HV. We check f

Re: [Qemu-devel] [PATCH v2 1/4] target-mips: add CPU definition for MIPS32R5

2014-02-13 Thread Peter Maydell
On 10 February 2014 15:42, Peter Maydell wrote: > On 10 February 2014 13:51, Andreas Färber wrote: >> Am 24.01.2014 17:18, schrieb Petar Jovanovic: >>> From: Petar Jovanovic >>> --- a/target-mips/translate_init.c >>> +++ b/target-mips/translate_init.c >>> @@ -333,6 +333,31 @@ static const mips_d

Re: [Qemu-devel] [PATCH] target-ppc: fix warn_unused_result build break with in-kernel HTAB support

2014-02-13 Thread Alexander Graf
On 13.02.2014, at 04:00, Aneesh Kumar K.V wrote: > Greg Kurz writes: > >> The 7029677e4 commit introduced the following build break: >> >> target-ppc/kvm.c: In function ‘kvmppc_hash64_write_pte’: >> target-ppc/kvm.c:2017:10: error: ignoring return value of ‘write’, declared >> with attribute

[Qemu-devel] [PATCH 2/4] gtk: Fix the relative pointer tracking mode

2014-02-13 Thread Takashi Iwai
The relative pointer tracking mode was still buggy even after the previous fix of the motion-notify-event since the events are filtered out when the pointer moves outside the drawing window due to the boundary check for the absolute mode. This patch fixes the issue by moving the unnecessary bounda

Re: [Qemu-devel] [PATCH V6 09/10] tests: add cases for inherited struct and union with discriminator

2014-02-13 Thread Markus Armbruster
Wenchao Xia writes: > Test for inherit and complex union. This patch conflicts badly with my test coverage work in "[PATCH v2 00/13] qapi: Test coverage & clean up generated code". My series systematically covers code generation in scripts/qapi*py, and that takes me seven patches. If I put you

[Qemu-devel] [PATCH 4/4] gtk: Add "Grab On Click" option

2014-02-13 Thread Takashi Iwai
I simply like it better, you don't? :) Signed-off-by: Takashi Iwai --- ui/gtk.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index e04f0781ae6c..4942c8330505 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -133,6 +133,7 @@ typedef struct GtkDisplayState G

[Qemu-devel] [PATCH 3/4] gtk: Remember the last grabbed pointer position

2014-02-13 Thread Takashi Iwai
It's pretty annoying that the pointer reappears at a random place once after grabbing and ungrabbing the input. Better to restore to the original position where the pointer was grabbed. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Signed-off-by: Takashi Iwai --- ui/gtk.c | 16 +

Re: [Qemu-devel] [PATCH v2] SPARC: Add and use CPU_FEATURE_CASA

2014-02-13 Thread Fabien Chouteau
On 02/13/2014 02:00 PM, Sebastian Huber wrote: > On 2014-02-13 13:01, Fabien Chouteau wrote: >> On 02/13/2014 10:52 AM, Sebastian Huber wrote: >>> The LEON3 processor has support for the CASA instruction which is >>> normally only available for SPARC V9 processors. Binutils 2.24 >>> and GCC 4.9 wi

[Qemu-devel] [PATCH 0/4] Fix relative pointer tracking on Gtk UI

2014-02-13 Thread Takashi Iwai
Hi, this is a series of patches to fix / improve the behavior of Gtk UI in the relative pointer tracking mode. Most people didn't notice the bug likely because it doesn't appear as long as the aboslute mode is used, e.g. when vmmouse input driver is enabled. But I hit this annoying behavior beca

[Qemu-devel] [PATCH 1/4] gtk: Use gtk generic event signal instead of motion-notify-event

2014-02-13 Thread Takashi Iwai
The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic "event" signal is sent when the pointer is grabbed, so we can use this and pick the motio

Re: [Qemu-devel] [PATCH] target-ppc: fix 32 bit build break in the page table lookup code

2014-02-13 Thread Alexander Graf
On 13.02.2014, at 04:00, Aneesh Kumar K.V wrote: > Greg Kurz writes: > >> The 396bb9874 commit reworked page table lookup to support kvm. >> Unfortunately this breaks 32 bit build: >> >> target-ppc/mmu-hash64.h: In function ‘ppc_hash64_load_hpte0’: >> target-ppc/mmu-hash64.h:90:23: error: ca

Re: [Qemu-devel] [PULL 0/4] user-mode FR switch support for MIPS32r5

2014-02-13 Thread Peter Maydell
On 10 February 2014 16:19, Petar Jovanovic wrote: > The following changes since commit 1f6b12f75f2c22f861d0202374033a7594c91707: > > Merge remote-tracking branch 'remotes/mwalle/tags/lm32-fixes/20140204' into > staging (2014-02-08 15:57:51 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH] tcg-arm: The shift count of op_rotl_i32 is in args[2] not args[1].

2014-02-13 Thread Richard Henderson
On 02/13/2014 02:26 AM, Huw Davies wrote: > It's this that should be subtracted from 0x20 when converting to a right > rotate. > > Signed-off-by: Huw Davies > --- > tcg/arm/tcg-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PULL 0/3] PReP patch queue 2014-02-10

2014-02-13 Thread Peter Maydell
On 10 February 2014 16:22, Andreas Färber wrote: > Hello Peter, > > Please pull the PowerPC Reference Platform (PReP) queue into qemu.git master. Applied, thanks. -- PMM

Re: [Qemu-devel] [PATCH v2] block: mirror - use local_err to avoid NULL errp

2014-02-13 Thread Eric Blake
On 02/13/2014 07:23 AM, Jeff Cody wrote: > When starting a block job, commit_active_start() relies on whether *errp > is set by mirror_start_job. This allows it to determine if the mirror > job start failed, so that it can clean up any changes to open flags from > the bdrv_reopen(). If errp is NU

  1   2   >