Re: [Qemu-devel] [PATCH v2 1/8] block: Change BDS parameter of bdrv_open() to **

2014-02-11 Thread Max Reitz
On 10.02.2014 14:17, Benoît Canet wrote: Le Saturday 08 Feb 2014 à 18:39:12 (+0100), Max Reitz a écrit : Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS poin

Re: [Qemu-devel] [PATCH v2 2/8] block: Add reference parameter to bdrv_open()

2014-02-11 Thread Max Reitz
On 10.02.2014 14:30, Benoît Canet wrote: Le Saturday 08 Feb 2014 à 18:39:13 (+0100), Max Reitz a écrit : Allow bdrv_open() to handle references to existing block devices just as bdrv_file_open() is already capable of. Signed-off-by: Max Reitz --- block.c | 41 ++

Re: [Qemu-devel] [PATCH v2 7/8] block: Reuse success path from bdrv_open()

2014-02-11 Thread Max Reitz
On 10.02.2014 15:56, Kevin Wolf wrote: Am 08.02.2014 um 18:39 hat Max Reitz geschrieben: The fail and success paths of bdrv_file_open() may be further shortened by reusing code already existent in bdrv_open(). This includes bdrv_file_open() not taking the reference to options which allows the re

[Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups

2014-02-11 Thread Peter Crosthwaite
Hi Andreas, Here is a mixed bag of QOM cleanups, moving us slightly closer to QOMification of SSI. This prepares support for some major refactoring around SSI (in particular some QSPI patches). Regards, Peter Peter Crosthwaite (6): ssi: Convert legacy casts from SSI_SLAVE->DEVICE ssi: Remo

[Qemu-devel] [PATCH qom-next v1 1/6] ssi: Convert legacy casts from SSI_SLAVE->DEVICE

2014-02-11 Thread Peter Crosthwaite
Convert legacy ->qdev style casts from TYPE_SSI_SLAVE to TYPE_DEVICE. Signed-off-by: Peter Crosthwaite --- hw/arm/spitz.c | 9 + hw/display/ads7846.c | 2 +- hw/display/ssd0323.c | 4 ++-- hw/misc/max111x.c| 4 ++-- hw/sd/ssi-sd.c | 2 +- 5 files changed, 11 insertions(+

[Qemu-devel] [PATCH qom-next v1 2/6] ssi: Remove legacy SSI_BUS->BUS cast

2014-02-11 Thread Peter Crosthwaite
Remove two legacy ->qbus style casts from TYPE_SSI_BUS to TYPE_BUS in ssi.c. Signed-off-by: Peter Crosthwaite --- hw/ssi/ssi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c index 2c25260..f2bdf30 100644 --- a/hw/ssi/ssi.c +++ b/hw/ssi/ssi.c

[Qemu-devel] [PATCH qom-next v1 3/6] misc: max111x: Create abstract max111x class

2014-02-11 Thread Peter Crosthwaite
Create an abstract class that encompasses both max111x variants. This is needed for QOM cast macro creation (and is the right thing to do anyway). Macroify type-names in the process. Signed-off-by: Peter Crosthwaite --- hw/misc/max111x.c | 33 + 1 file changed, 2

[Qemu-devel] [PATCH qom-next v1 4/6] misc: max111x: QOM casting sweep

2014-02-11 Thread Peter Crosthwaite
Define and use QOM cast macro. Removes some usages of legacy casting systems. Signed-off-by: Peter Crosthwaite --- hw/misc/max111x.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/misc/max111x.c b/hw/misc/max111x.c index 9e50e7e..8c78979 100644 --- a/hw/misc/max

[Qemu-devel] [PATCH qom-next v1 5/6] ssi: Remove SSI_SLAVE_FROM_QDEV macro

2014-02-11 Thread Peter Crosthwaite
There are no usages left of this legacy cast. delete. Signed-off-by: Peter Crosthwaite --- include/hw/ssi.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/ssi.h b/include/hw/ssi.h index fdae317..38e5b03 100644 --- a/include/hw/ssi.h +++ b/include/hw/ssi.h @@ -62,7 +62,6 @@ struct

[Qemu-devel] [PATCH qom-next v1 6/6] block/m25p80: Remove FROM_SSI_SLAVE usages

2014-02-11 Thread Peter Crosthwaite
Signed-off-by: Peter Crosthwaite --- hw/block/m25p80.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 02a1544..bdbb139 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -545,7 +545,7 @@ static void decode_new_cmd(Flas

Re: [Qemu-devel] [PATCH] target-arm: make smc behave as a nop

2014-02-11 Thread Rob Herring
On Tue, Feb 11, 2014 at 5:29 PM, Peter Maydell wrote: > On 11 February 2014 23:19, Rob Herring wrote: >> From: Rob Herring >> >> Several platforms make smc calls for things such as PL310 cache setup. >> In these cases, making smc a nop rather than an illegal instruction >> is sufficient for qemu

Re: [Qemu-devel] [PATCH] QMP: allow dot separated dict path arguments in qmp-shell

2014-02-11 Thread Fam Zheng
On Tue, 02/11 14:28, Stefan Hajnoczi wrote: > On Tue, Feb 11, 2014 at 06:45:05PM +0800, Fam Zheng wrote: > > diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell > > index d374b35..9c84551 100755 > > --- a/scripts/qmp/qmp-shell > > +++ b/scripts/qmp/qmp-shell > > @@ -112,7 +112,14 @@ class QM

[Qemu-devel] [PULL] OpenRISC patch queue for 1.8

2014-02-11 Thread Jia Liu
Hi Anthony, This is my OpenRISC patch queue for 1.8, it have been well tested, please pull. Thanks to Richard Henderson, he made the LD/ST updated. Regards, Jia The following changes since commit a4550442b947d2c2b346bd2efc8fe3da16425f4d: petalogix-ml605: Create the CPU with object_new()

[Qemu-devel] [PULL] target-openrisc: Use new qemu_ld/st opcodes

2014-02-11 Thread Jia Liu
From: Richard Henderson Signed-off-by: Richard Henderson Acked-by: Jia Liu Signed-off-by: Jia Liu --- target-openrisc/translate.c | 99 +++-- 1 file changed, 32 insertions(+), 67 deletions(-) diff --git a/target-openrisc/translate.c b/target-openrisc/t

[Qemu-devel] [RFC/RFT v1 0/2] NAND QOMification - Round 1

2014-02-11 Thread Peter Crosthwaite
Or perhaps even round 0.5 ... Hi Andreas, I have a work-in-progress lengthy series that moves towards the full QOMification and BUSification of NAND. This will allow a few things: Attachment of multiple nand devs to one controller. Centralised CS GPIO control. info qtree sanity These patches ar

[Qemu-devel] [RFC/RFT v1 1/2] arm: tosa: QOMify NAND/display/irq controller

2014-02-11 Thread Peter Crosthwaite
First step QOMficiation of the tosa IO controller (NAND display and interrupts. Setup the memory regions and IRQ properly as per sysbus. Signed-off-by: Peter Crosthwaite --- hw/arm/tosa.c | 12 ++-- hw/display/tc6393xb.c | 36 +--- include/hw/devi

[Qemu-devel] [RFC/RFT v1 2/2] cris: axis_dev88: QOMify NAND controller

2014-02-11 Thread Peter Crosthwaite
First step QOMficiation of the Axis NAND controller. Setup the memory regions properly as per sysbus. Signed-off-by: Peter Crosthwaite --- hw/cris/axis_dev88.c | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/hw/cris/axis_dev88.c b/hw/c

[Qemu-devel] [PATCH v2] QMP: Allow dot separated dict path arguments in qmp-shell

2014-02-11 Thread Fam Zheng
As another convinience to allow using commands that expect a dict as argument, this patch adds support for foo.bar=value syntax, similar to command line argument style: (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=... Signed-off-by: Fam Zheng --- v2: Fix variable

Re: [Qemu-devel] [PATCH v5 RESEND 2/4] raw, qcow2: don't convert file size to sector size

2014-02-11 Thread Hu Tao
On Tue, Feb 11, 2014 at 04:53:30PM +0800, Fam Zheng wrote: > On Tue, 02/11 15:07, Hu Tao wrote: > > and avoid convert it back later. > > > > Signed-off-by: Hu Tao > > --- > > block/qcow2.c | 8 > > block/raw-posix.c | 4 ++-- > > 2 files changed, 6 insertions(+), 6 deletions(-) > >

Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-02-11 Thread Hu Tao
On Tue, Feb 11, 2014 at 06:20:03AM -0700, Eric Blake wrote: > On 02/11/2014 12:07 AM, Hu Tao wrote: > > This patch prepares for the subsequent patches. > > > > Signed-off-by: Hu Tao > > --- > > block/qcow2.c| 8 > > qapi-schema.json | 12 > > 2 files changed, 16 insert

Re: [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option

2014-02-11 Thread Hu Tao
On Tue, Feb 11, 2014 at 05:04:09PM +0800, Fam Zheng wrote: > On Tue, 02/11 15:07, Hu Tao wrote: > > This patch adds a new option preallocation for raw format, and implements > > full preallocation. > > > > Signed-off-by: Hu Tao > > --- > > block/raw-posix.c | 43 +

Re: [Qemu-devel] [PATCH v2] QMP: Allow dot separated dict path arguments in qmp-shell

2014-02-11 Thread Eric Blake
On 02/11/2014 06:22 PM, Fam Zheng wrote: > As another convinience to allow using commands that expect a dict as s/convinience/convenience/ > argument, this patch adds support for foo.bar=value syntax, similar to > command line argument style: > > (QEMU) blockdev-add options.driver=file options

[Qemu-devel] Ping for patch "linux-user: add binfmt wrapper for argv[0] handling"

2014-02-11 Thread Dennis Lan (dlan)
Hi Folks: Any chance to get this patch accepted into master branch? I found it useful when chroot into another system. Origianl post can be found here[1], would be quite easy to forward port to latest code. [1] https://lists.gnu.org/archive/html/qemu-devel/2011-09/msg03841.html

Re: [Qemu-devel] [PATCH target-arm v5 1/1] target-arm: Implements the ARM PMCCNTR register

2014-02-11 Thread Alistair Francis
Ping On Fri, Jan 31, 2014 at 2:44 PM, Alistair Francis wrote: > This patch implements the ARM PMCCNTR register including > the disable and reset components of the PMCR register. > > Signed-off-by: Alistair Francis > --- > This patch assumes that non-invasive debugging is not permitted > when det

[Qemu-devel] [PATCH v3] QMP: Allow dot separated dict path arguments in qmp-shell

2014-02-11 Thread Fam Zheng
As another convinience to allow using commands that expect a dict as argument, this patch adds support for foo.bar=value syntax, similar to command line argument style: (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=... Signed-off-by: Fam Zheng --- v3: Fix error me

[Qemu-devel] [PATCH v9 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Qiao Nuohan
'query-dump-guest-memory-capability' is used to query the available formats of 'dump-guest-memory'. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "formats": ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] }

Re: [Qemu-devel] [PATCH v9 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Eric Blake
On 02/11/2014 08:13 PM, Qiao Nuohan wrote: > 'query-dump-guest-memory-capability' is used to query the available > formats of > 'dump-guest-memory'. The output of the command will be like: > > -> { "execute": "query-dump-guest-memory-capability" } > <- { "return": { "formats": >

[Qemu-devel] [PATCH target-arm v1 0/2] More Cadence UART fixes

2014-02-11 Thread Peter Crosthwaite
Hi Peter, Two fixes to Cadence UART. First is a bug in the recently refactored TX code path around error handling. Second is the long known crashing-cadence-UART bug when there in no backing serial device (i.e. boot a kernel that talks to serial without adding -serial args). Chris recently repo

[Qemu-devel] [PATCH target-arm v1 2/2] char/cadence_uart: Add NULL guards against chr

2014-02-11 Thread Peter Crosthwaite
It's possible and valid for users of this device model to instantiate it without a backing chr device. To avoid crashes, guard all uses of the backing chr device against NULL. Signed-off-by: Peter Crosthwaite --- hw/char/cadence_uart.c | 14 ++ 1 file changed, 10 insertions(+), 4 de

[Qemu-devel] [PATCH target-arm v1 1/2] char/cadence_uart: Handle qemu_chr_fe_write errors

2014-02-11 Thread Peter Crosthwaite
By just ignoring them and trying again later. This handles the EGAIN case properly (the previous implementation was only dealing with short returns and not errors). Signed-off-by: Peter Crosthwaite --- hw/char/cadence_uart.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --g

Re: [Qemu-devel] [PATCH target-arm v5 4/5] arm: Implement reset GPIO.

2014-02-11 Thread Peter Crosthwaite
On Tue, Jan 28, 2014 at 7:22 PM, Peter Maydell wrote: > On 28 January 2014 00:48, Peter Crosthwaite > wrote: >> On Tue, Jan 28, 2014 at 3:52 AM, Peter Maydell >> wrote: >>> On 15 January 2014 09:14, Peter Crosthwaite >>> wrote: Implement a reset GPIO for ARM CPUs. This allows individual r

[Qemu-devel] [PATCH v20 02/26] qapi: output def_value_str when query command line options

2014-02-11 Thread Chunyan Liu
Change qapi interfaces to output the newly added def_value_str when query command line options. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- qapi-schema.json |8 ++-- qmp-commands.hx|2 ++ util/qemu-config.c |4 3 files changed, 12 insertions(+), 2 delet

[Qemu-devel] [PATCH v20 04/26] add some QemuOpts functions for replace work

2014-02-11 Thread Chunyan Liu
Add some qemu_opt functions to replace the same functionality of QEMUOptionParameter handling. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- include/qemu/option.h |9 +++ util/qemu-option.c| 134 + 2 files changed, 143 insert

[Qemu-devel] [PATCH v20 06/26] change block layer to support both QemuOpts and QEMUOptionParameter

2014-02-11 Thread Chunyan Liu
Change block layer to support both QemuOpts and QEMUOptionParameter. After this patch, it will change backend drivers one by one. At the end, QEMUOptionParameter will be removed and only QemuOpts is kept. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c | 11

[Qemu-devel] [PATCH v20 01/26] add def_value_str to QemuOptDesc

2014-02-11 Thread Chunyan Liu
Add def_value_str (default value) to QemuOptDesc, to replace function of the default value in QEMUOptionParameter. And improved related functions. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- include/qemu/option.h |3 +- util/qemu-option.c| 76 +++

[Qemu-devel] [PATCH v20 05/26] remove assertion of qemu_opt_get functions

2014-02-11 Thread Chunyan Liu
In qemu_opt_set functions, if desc doen't exist but opts_accepts_any is true, it won't report error, but can still alloc an opt for the option and save it. However, after that, when doing qemu_opt_get, this option could be found in opts but opt->desc is NULL. This is correct, should not be treated

[Qemu-devel] [PATCH v20 03/26] improve some functions in qemu-option.c

2014-02-11 Thread Chunyan Liu
Improve opt_get and opt_set group of functions. For opt_get, check and handle NUlL input; for opt_set, when set to an existing option, rewrite the option with new value. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- util/qemu-option.c | 84

[Qemu-devel] [PATCH v20 00/26] replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
This patch series is to replace QEMUOptionParameter with QemuOpts, so that only one Qemu Option structure is kept in QEMU code. --- Changes to v19: * fix format issue * according to Kevin's comments, add convert functions (params_to_opts and opts_to_params) to simplify the block layer patc

[Qemu-devel] [PATCH v20 10/26] qcow.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
qcow.c: replace QEMUOptionParamter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qcow.c | 61 - 1 files changed, 30 insertions(+), 31 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 992eed4..

[Qemu-devel] [PATCH v20 11/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in create

2014-02-11 Thread Chunyan Liu
qcow2.c: replace QEMUOptionParameter with QemuOpts in 'qemu-img create'. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qcow2.c | 176 1 files changed, 88 insertions(+), 88 deletions(-) diff --git a/block/qcow2.c b/blo

[Qemu-devel] [PATCH v20 12/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options

2014-02-11 Thread Chunyan Liu
qcow2.c: replace QEMUOptionParameter with QemuOpts in 'qemu-img amend' Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c |4 +- block/qcow2.c | 90 include/block/block.h |2 +- include/bloc

[Qemu-devel] [PATCH v20 08/26] gluster.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
gluster.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/gluster.c | 80 -- 1 files changed, 41 insertions(+), 39 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index

[Qemu-devel] [PATCH v20 23/26] vhdx.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vhdx.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vhdx.c | 93 +++-- block/vhdx.h |1 + 2 files changed, 45 insertions(+), 49 deletions(-) diff --git a/block/vhdx.c b/bloc

[Qemu-devel] [PATCH v20 09/26] iscsi.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
iscsi.c: replace QEMUOptionParamter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/iscsi.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 6f4af72..f94f935 100644 --- a/b

[Qemu-devel] [PATCH v20 15/26] raw-win32.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
raw-win32.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw-win32.c | 33 + 1 files changed, 17 insertions(+), 16 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index beb7f23..15a

[Qemu-devel] [PATCH v20 24/26] vvfat.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vvfat.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vvfat.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index c59cbdb..81733bc 100644 --- a/block/vvfat.c +++ b/blo

[Qemu-devel] [PATCH v20 14/26] raw-posix.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
raw-posix.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw-posix.c | 58 1 files changed, 27 insertions(+), 31 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c

[Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Qiao Nuohan
'query-dump-guest-memory-capability' is used to query the available formats for 'dump-guest-memory'. The output of the command will be like: -> { "execute": "query-dump-guest-memory-capability" } <- { "return": { "formats": ["elf", "kdump-zlib", "kdump-lzo", "kdump-snappy"] }

[Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
qed.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qed.c | 89 +-- block/qed.h |3 +- 2 files changed, 45 insertions(+), 47 deletions(-) diff --git a/block/qed.c b/block

[Qemu-devel] [PATCH v20 17/26] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
rbd.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/rbd.c | 63 +-- 1 files changed, 31 insertions(+), 32 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 121fae2..b

[Qemu-devel] [PATCH v20 19/26] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
ssh.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/ssh.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index aa63c9d..8fd2175 100644 --- a/block/ss

[Qemu-devel] [PATCH v20 16/26] raw_bsd.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
raw_bsd.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw_bsd.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 297e03f..4ae12dd 100644 --

[Qemu-devel] [PATCH v20 21/26] vmdk.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vmdk.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vmdk.c | 109 + 1 files changed, 55 insertions(+), 54 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 97e6608.

[Qemu-devel] [PATCH v20 22/26] vpc.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vpc.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vpc.c | 52 +++- 1 files changed, 27 insertions(+), 25 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 1d326cb..f77f4a5

[Qemu-devel] [PATCH v20 20/26] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vdi.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vdi.c | 71 -- 1 files changed, 34 insertions(+), 37 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 2d7490f..e5

[Qemu-devel] [PATCH v20 18/26] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
sheepdog.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/sheepdog.c | 101 +- 1 files changed, 47 insertions(+), 54 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c i

[Qemu-devel] [PATCH v20 25/26] cleanup QEMUOptionParameter

2014-02-11 Thread Chunyan Liu
Now all places using QEMUOptionParameter could use QemuOpts too, remove QEMUOptionParameter related code. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c | 57 ++- block/cow.c |2 +- block/qcow.c |2 +- block/qcow2.c

[Qemu-devel] [PATCH v20 26/26] change back to original name from bdrv_create2 to bdrv_create

2014-02-11 Thread Chunyan Liu
Rename the new driver callback bdrv_create2 to the old name bdrv_create. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c |4 ++-- block/cow.c |2 +- block/gluster.c |8 block/iscsi.c |2 +- block/q

[Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
cow.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/cow.c | 46 ++ 1 files changed, 22 insertions(+), 24 deletions(-) diff --git a/block/cow.c b/block/cow.c index 85c2971..0d06781 100644

Re: [Qemu-devel] Ping for patch "linux-user: add binfmt wrapper for argv[0] handling"

2014-02-11 Thread Alexander Graf
On 12.02.2014, at 03:30, Dennis Lan (dlan) wrote: > Hi Folks: > Any chance to get this patch accepted into master branch? > I found it useful when chroot into another system. Origianl post can > be found here[1], would be quite easy to forward port to latest code. > > [1] https://lists.gnu.or

Re: [Qemu-devel] [Qemu-ppc] PowerPC Decimal Floating Point

2014-02-11 Thread Alexander Graf
On 11.02.2014, at 18:14, Tom Musta wrote: > QEMU is currently lacking support for the Decimal Floating Point category of > instructions > (see Power ISA V2.07 Chapter 6). I intend to add this support. > > Has this topic been investigated before and if so can anyone point me to that > discuss

[Qemu-devel] PC value translation from guest VA to host VA.

2014-02-11 Thread Gaurav Sharma
Can anyone point it out to me where is the pc value translated from guest virtual address to host virtual address ? Thanks, Gaurav

Re: [Qemu-devel] [PATCH] virtio-net: remove function calls from assert

2014-02-11 Thread Joel Stanley
On Tue, Feb 11, 2014 at 3:40 PM, Michael S. Tsirkin wrote: > Just to clarify, I applied this because code looks nicer this way. > We don't support build with NDEBUG - a whole bunch of > stuff will break if you do. > I tweaked the commit log to make this clear. Ok. Thanks for clarifying that. Joe

Re: [Qemu-devel] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-11 Thread Eduardo Habkost
On Mon, Feb 10, 2014 at 11:39:51PM +0100, Andreas Färber wrote: > Am 10.02.2014 11:21, schrieb Eduardo Habkost: > > +static const TypeInfo x86_cpu_host_type_info = { > > +.name = CPU_CLASS_NAME("host"), > > +.parent = TYPE_X86_CPU, > > +.instance_size = sizeof(X86CPU), > > +.instanc

Re: [Qemu-devel] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 23:39, Andreas Färber ha scritto: I'd rather finish my investigations and discuss my v10 patches but Paolo is already asking whether Eduardo should send a PULL, so here's my textual reply informing of some thoughts and WIP. ;) Don't worry, :) I was asking you if you are fine with

Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.

2014-02-11 Thread Fam Zheng
On Mon, 02/10 22:49, Benoît Canet wrote: > Take into account the fact that a block filter like quorum will be in bs->file > while a regular block driver device is really on the top level. > > Signed-off-by: Benoit Canet > --- > block.c | 14 -- > 1 file changed, 8 insertions(+), 6 de

Re: [Qemu-devel] question about patch "send the gratuitous by guest"

2014-02-11 Thread Jason Wang
On 02/11/2014 03:43 PM, Huangweidong (C) wrote: > > Hi, > > I found the network was broken after migrating the vm, the same as you > said in "Send the > > gratuitous by guest".The vm modify the mac of network card.IN the > scenario with > > vlan the network was broken too. > > The guest driver of v

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-02-11 Thread Markus Armbruster
Fam Zheng writes: > On Mon, 02/10 15:54, Luiz Capitulino wrote: >> > @@ -875,13 +875,13 @@ DriveInfo *drive_init(QemuOpts *all_opts, >> > BlockInterfaceType block_default_type) >> > /* Actual block device init: Functionality shared with blockdev-add */ >> > dinfo = blockdev_init(filena

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Markus Armbruster
Eric Blake writes: > On 02/10/2014 02:16 PM, Luiz Capitulino wrote: >> On Sat, 1 Feb 2014 12:52:42 +0100 >> Martin Kletzander wrote: >> >>> Introduce 'query-chardev-backends' QMP command which lists all >>> supported character device backends. >>> >>> Signed-off-by: Martin Kletzander >>> ---

Re: [Qemu-devel] [PATCH v2 0/2] qapi: Allow modularization of QAPI schema files

2014-02-11 Thread Markus Armbruster
Lluís Vilanova writes: > Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing > these to be modularized into multiple per-topic files in the future. > > Signed-off-by: Lluís Vilanova > --- > > Changes in v2: > > * Change the scripts to use an explicit input file instead

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Kevin Wolf
Am 11.02.2014 um 02:39 hat Fam Zheng geschrieben: > On Wed, 01/29 12:17, Stefan Hajnoczi wrote: > > qmp-shell hides the QMP wire protocol JSON encoding from the user. Most > > of the time this is helpful and makes the command-line human-friendly. > > > > Some QMP commands take a dict as an argume

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 01/29 12:17, Stefan Hajnoczi wrote: >> qmp-shell hides the QMP wire protocol JSON encoding from the user. Most >> of the time this is helpful and makes the command-line human-friendly. >> >> Some QMP commands take a dict as an argument. In order to express this >> w

[Qemu-devel] [PATCH 1/6] target-xtensa: add RRRI4 opcode format fields

2014-02-11 Thread Max Filippov
This encoding is used by cache instructions. Signed-off-by: Max Filippov --- target-xtensa/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index dc5e78f..b0b7fa0 100644 --- a/target-xtensa/translate.c +++ b/target-xte

[Qemu-devel] [PATCH 2/6] target-xtensa: add basic checks to dcache opcodes

2014-02-11 Thread Max Filippov
Check privilege level for privileged instructions (DHI, DHU, DII, DIU, DIWB, DIWBI, DPFL are privileged), memory accessibility for instructions that reference memory (all DH* and DPFL) and windowed register validity for all data cache instructions. Signed-off-by: Max Filippov --- target-xtensa/t

[Qemu-devel] [PATCH 0/6] target-xtensa: add basic checks to cache opcodes

2014-02-11 Thread Max Filippov
Hello, this series adds basic checks (privilege level, address validity, windowed register validation) to all cache opcodes. This improves emulation quality and allows to debug cache-related issues that happen on real hardware. Max Filippov (6): target-xtensa: add RRRI4 opcode format fields t

[Qemu-devel] [PATCH 4/6] target-xtensa: add overridable test_init macro

2014-02-11 Thread Max Filippov
Some test suites, like MMU, need per-test initialization. Don't make them redefine test macro, add test_init for that purpose. Signed-off-by: Max Filippov --- tests/tcg/xtensa/macros.inc | 4 tests/tcg/xtensa/test_mmu.S | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH 3/6] target-xtensa: add basic checks to icache opcodes

2014-02-11 Thread Max Filippov
Check privilege level for privileged instructions (IHU, III, IIU and IPFL are privileged), memory accessibility for instructions that reference memory (IH* and IPFL) and windowed register validity for all instruction cache instructions. Signed-off-by: Max Filippov --- target-xtensa/helper.h|

[Qemu-devel] [PATCH 5/6] target-xtensa: allow using core configuration in tests

2014-02-11 Thread Max Filippov
Add path to the core configuration directory to test build command and replace .include asm directive with #include to enable preprocessing. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 11 +++ tests/tcg/xtensa/macros.inc | 2 ++ tests/tcg/xtensa/test_b.S

[Qemu-devel] [PATCH 6/6] target-xtensa: add basic tests for cache opcodes

2014-02-11 Thread Max Filippov
Test that non-locking prefetch operations don't cause exceptions on missing TLB and that other 'hit' cache operations do. Signed-off-by: Max Filippov --- tests/tcg/xtensa/Makefile | 1 + tests/tcg/xtensa/test_cache.S | 97 +++ 2 files changed, 98 inse

Re: [Qemu-devel] [PATCH v5 RESEND 2/4] raw, qcow2: don't convert file size to sector size

2014-02-11 Thread Fam Zheng
On Tue, 02/11 15:07, Hu Tao wrote: > and avoid convert it back later. > > Signed-off-by: Hu Tao > --- > block/qcow2.c | 8 > block/raw-posix.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index 30e36bc..e4bab70 100644

Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-02-11 Thread Fam Zheng
On Tue, 02/11 15:07, Hu Tao wrote: > This patch prepares for the subsequent patches. > > Signed-off-by: Hu Tao > --- > block/qcow2.c| 8 > qapi-schema.json | 12 > 2 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index

Re: [Qemu-devel] [PATCH v2 19/35] target-arm: A64: Make cache ID registers visible to AArch64

2014-02-11 Thread Hu Tao
On Fri, Feb 07, 2014 at 10:27:35AM +, Peter Maydell wrote: > On 7 February 2014 07:35, Hu Tao wrote: > > On Fri, Jan 31, 2014 at 03:45:27PM +, Peter Maydell wrote: > >> Make the cache ID system registers (CLIDR, CCSELR, CCSIDR, CTR) > > > > s/CCSELR/CSSELR/ > > > >> visible to AArch64. The

Re: [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option

2014-02-11 Thread Fam Zheng
On Tue, 02/11 15:07, Hu Tao wrote: > This patch adds a new option preallocation for raw format, and implements > full preallocation. > > Signed-off-by: Hu Tao > --- > block/raw-posix.c | 43 +++ > 1 file changed, 35 insertions(+), 8 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v2 00/35] AArch64 system mode: system register rework

2014-02-11 Thread Peter Maydell
On 11 February 2014 06:11, Peter Crosthwaite wrote: > Im finished with my review of this one, all outstanding > comments/queries are addressed so for any patches w/o my RB already: > > acked-by: Peter Crosthwaite Thanks. I'll put some of the reviewed patches into target-arm.next, respin with fix

Re: [Qemu-devel] [PATCH v8 03/13] dump: add API to write header of flatten format

2014-02-11 Thread Markus Armbruster
Laszlo Ersek writes: > On 02/10/14 23:48, Luiz Capitulino wrote: >> On Mon, 10 Feb 2014 22:57:15 +0100 >> Laszlo Ersek wrote: > >>> In short, -Werror and bisection don't mix. They already don't, and we >>> shouldn't expect them to. >> >> I understand what you're saying, and I don't want people

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 14:29, Markus Armbruster ha scritto: Markus Armbruster writes: Paolo Bonzini writes: Il 06/02/2014 15:30, Markus Armbruster ha scritto: Visitors get passed a pointer to the visited object. The generated visitors try to cope with this pointer being null in some places, for in

Re: [Qemu-devel] [PATCH v2 1/3] Rework --name to use QemuOpts

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 17:12, Laszlo Ersek ha scritto: > I'd checked every piece of output I'd found, but hadn't found > the query-command-line-options; I think you're right there > are no other \n's in there - but also all the other .help texts > are much briefer and less chatty; maybe I need to just c

Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:42PM +0100, Igor Mammedov wrote: > features family, model, stepping, level, hv_spinlocks are treated similarly > when passed from command line, so it's not necessary to handle each of them > individually. Collapse them to one catch-all branch which will treat > any not

Re: [Qemu-devel] [PATCH 03/16] target-i386: cpu: convert 'level' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:43PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH 04/16] target-i386: cpu: convert 'xlevel' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:44PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Fam Zheng
On Tue, 02/11 09:41, Kevin Wolf wrote: > Am 11.02.2014 um 02:39 hat Fam Zheng geschrieben: > > On Wed, 01/29 12:17, Stefan Hajnoczi wrote: > > > qmp-shell hides the QMP wire protocol JSON encoding from the user. Most > > > of the time this is helpful and makes the command-line human-friendly. > >

Re: [Qemu-devel] [PATCH 05/16] target-i386: cpu: convert 'family' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:45PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Fam Zheng
On Tue, 02/11 09:43, Markus Armbruster wrote: > Fam Zheng writes: > > > On Wed, 01/29 12:17, Stefan Hajnoczi wrote: > >> qmp-shell hides the QMP wire protocol JSON encoding from the user. Most > >> of the time this is helpful and makes the command-line human-friendly. > >> > >> Some QMP command

Re: [Qemu-devel] [PATCH 07/16] target-i386: cpu: convert 'stepping' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:47PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Dr. David Alan Gilbert
* Peter Crosthwaite (peter.crosthwa...@xilinx.com) wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. > > Signed-off-by: Peter Crosthwaite > --- Reviewed-by: Dr. David Alan Gilbert I think this brings it back to how it was on the old FIFO code. > >

Re: [Qemu-devel] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-11 Thread Stefan Hajnoczi
On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi wrote: > Project ideas > Please post project ideas on the wiki page below. Project ideas > should be suitable as a 12-week project that a student fluent in > C/Python/etc can complete. No prior knowledge of QEMU/KVM/libvirt > internals can be assum

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Martin Kletzander
On Mon, Feb 10, 2014 at 10:49:35PM -0800, Peter Crosthwaite wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. > > Signed-off-by: Peter Crosthwaite > --- Reviewed-by: Martin Kletzander With this patch qemu doesn't crash in my use-case. > > hw/char/se

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Michael Tokarev
11.02.2014 10:49, Peter Crosthwaite wrote: > This was guarding against a full fifo rather than an empty fifo when > popping. Fix. I've applied this to qemu-trivial for now, if no one will pick it up before the next -trivial pull, -- because the original change were merged using -trivial too. I al

Re: [Qemu-devel] [Qemu-trivial] [PATCH] net: Include iov.h in checksum.h

2014-02-11 Thread Michael Tokarev
10.02.2014 14:20, Stefan Hajnoczi пишет: > On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote: >> >> >>> Am 07.02.2014 um 08:05 schrieb Michael Tokarev : >>> >>> 06.02.2014 19:30, Alexander Graf wrote: The checksum calculation header exports a function that refers to struct io

Re: [Qemu-devel] [PATCH v3 2/5] qtest: Add scripts/qtest/qtest.py

2014-02-11 Thread Benoît Canet
The Tuesday 11 Feb 2014 à 14:40:59 (+0800), Fam Zheng wrote : > This removes the dummy scripts/qtest and adds scripts/qtest/qtest.py as > a python library for qtest protocol. > > This is a skeleton with a basic "cmd" method to execute a command, > reading and parsing of qtest output will be added

  1   2   3   >