Re: [Qemu-devel] [PATCH] drive-mirror:fix memory leak

2014-01-22 Thread Fam Zheng
On Wed, 01/22 15:56, Zhang Min wrote: > In the function mirror_iteration() -> qemu_iovec_init(), > it allocates memory for op->qiov.iov, when the write request calls back, > but in the function mirror_iteration_done(), it only frees the op, > not free the op->qiov.iov, so this causes memory leak. >

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-22 Thread Anup Patel
Hi Alex, On Wed, Jan 22, 2014 at 12:11 PM, Alexander Graf wrote: > > >> Am 22.01.2014 um 07:31 schrieb Anup Patel : >> >> On Wed, Jan 22, 2014 at 11:09 AM, Victor Kamensky >> wrote: >>> Hi Guys, >>> >>> Christoffer and I had a bit heated chat :) on this >>> subject last night. Christoffer, reall

Re: [Qemu-devel] [PATCH] sheepdog: fix 'qemu-img map'

2014-01-22 Thread Kevin Wolf
Am 21.01.2014 um 18:14 hat Liu Yuan geschrieben: > It was muted in the previous commit 4bc74be9. Let's revive it since nothing > prevents us to do it. > > With this patch, following command will work as other formats: > > $ qemu-img map sheepdog:image > > Cc: qemu-devel@nongnu.org > Cc: Kevin Wo

Re: [Qemu-devel] [PATCH] qapi: Add "backing" and "file" to BlockStats

2014-01-22 Thread Kevin Wolf
Am 22.01.2014 um 04:30 hat Fam Zheng geschrieben: > Currently there is no way to query BlockStats of the backing chain. This > adds "backing" and "file" fields into BlockStats to make it possible. > > The old optional field "parent", which has the information for "file", > is kept there for backwa

Re: [Qemu-devel] [PATCH] drive-mirror:fix memory leak

2014-01-22 Thread Kevin Wolf
Am 22.01.2014 um 08:56 hat Zhang Min geschrieben: > In the function mirror_iteration() -> qemu_iovec_init(), > it allocates memory for op->qiov.iov, when the write request calls back, > but in the function mirror_iteration_done(), it only frees the op, > not free the op->qiov.iov, so this causes me

Re: [Qemu-devel] [PATCH v3 1/4] qcow2: remove n_start and n_end of qcow2_alloc_cluster_offset()

2014-01-22 Thread Kevin Wolf
Am 22.01.2014 um 07:57 hat Hu Tao geschrieben: > n_start can be actually calculated from offset. The number of > sectors to be allocated(n_end - n_start) can be passed in in > num. By removing n_start and n_end, we can save two parameters. > > The side effect is there is a bug in qcow2.c:prealloca

Re: [Qemu-devel] [PATCH v3 4/4] qemu-iotests: add test for qcow2 preallocation with different cluster sizes

2014-01-22 Thread Kevin Wolf
Am 22.01.2014 um 07:57 hat Hu Tao geschrieben: > Signed-off-by: Hu Tao > --- > > Note: the current largest test case number is 074, but Kevin suggested picking > 079 as there are in-flight patches taken lower numbers. > > tests/qemu-iotests/079 | 69 > ++

Re: [Qemu-devel] [PATCH 3/3] add support for hyperv time parameter

2014-01-22 Thread Paolo Bonzini
Il 21/01/2014 22:12, Vadim Rozenfeld ha scritto: > > If you are planning some level of backwards compatibility with RHEL6, it > may make sense to use separate subsections. I believe we have to make it backward compatible. In RHEL6 we added support for relaxed timers only, but upstream doesn't ha

Re: [Qemu-devel] [PATCH 4/5] sclp-s390: Define new SCLP codes and structures

2014-01-22 Thread Christian Borntraeger
On 16/12/13 21:51, Matthew Rosato wrote: > Define new SCLP codes and structures that will be needed for s390 memory > hotplug. > > Signed-off-by: Matthew Rosato Can you rebase this patch against git://github.com/borntraeger/qemu.git s390-next and send it separately? This patch is pretty much

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2014-01-22 Thread Paolo Bonzini
Il 22/01/2014 05:19, Alexey Kardashevskiy ha scritto: On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: With the great help from Paolo, I am presenting yet another try of bootindex support on sPAPR, this time with some QOM fixes. Details are in the commit messages. Please, comment. Thanks. A

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-22 Thread Paolo Bonzini
Il 21/01/2014 19:27, Wei Liu ha scritto: > > Googling "disable tcg" would have provided an answer, but the patches > were old enough to be basically useless. I'll refresh the current > version in the next few days. Currently I am (or try to be) on > vacation, so I cannot really say when, but I'

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-22 Thread Peter Maydell
On 22 January 2014 05:39, Victor Kamensky wrote: > Hi Guys, > > Christoffer and I had a bit heated chat :) on this > subject last night. Christoffer, really appreciate > your time! We did not really reach agreement > during the chat and Christoffer asked me to follow > up on this thread. > Here it

Re: [Qemu-devel] [PATCH v3 1/4] KVM/X86: Fix xsave cpuid exposing bug

2014-01-22 Thread Paolo Bonzini
Il 21/01/2014 19:59, Liu, Jinsong ha scritto: From 3155a190ce6ebb213e6c724240f4e6620ba67a9d Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Fri, 13 Dec 2013 02:32:03 +0800 Subject: [PATCH v3 1/4] KVM/X86: Fix xsave cpuid exposing bug EBX of cpuid(0xD, 0) is dynamic per XCR0 features enable/dis

Re: [Qemu-devel] [PATCH v3 1/4] KVM/X86: Fix xsave cpuid exposing bug

2014-01-22 Thread H. Peter Anvin
On 01/22/2014 02:21 AM, Paolo Bonzini wrote: > Il 21/01/2014 19:59, Liu, Jinsong ha scritto: >> From 3155a190ce6ebb213e6c724240f4e6620ba67a9d Mon Sep 17 00:00:00 2001 >> From: Liu Jinsong >> Date: Fri, 13 Dec 2013 02:32:03 +0800 >> Subject: [PATCH v3 1/4] KVM/X86: Fix xsave cpuid exposing bug >> >

Re: [Qemu-devel] [PATCH 06/24] target-arm: A64: Implement store-exclusive for system mode

2014-01-22 Thread Peter Maydell
On 22 January 2014 02:19, Hu Tao wrote: > On Tue, Jan 21, 2014 at 08:12:12PM +, Peter Maydell wrote: >> +if (is_pair) { >> +TCGv_i64 addrhi = tcg_temp_new_i64(); >> +TCGv_i64 tmphi = tcg_temp_new_i64(); >> + >> +tcg_gen_addi_i64(addrhi, addr, 1 << size); >> +

Re: [Qemu-devel] [PATCH 08/24] target-arm: A64: Implement MSR (immediate) instructions

2014-01-22 Thread Peter Maydell
On 22 January 2014 03:10, Hu Tao wrote: > On Tue, Jan 21, 2014 at 08:12:14PM +, Peter Maydell wrote: >> +/* MSR_i to update PSTATE. This is OK from EL0 only if UMA is set. >> + * Note that SPSel is never OK from EL0; we rely on handle_msr_i() >> + * to catch that case at translate

Re: [Qemu-devel] [Qemu-ppc] KVM and variable-endianness guest CPUs

2014-01-22 Thread Alexander Graf
On 22.01.2014, at 08:26, Victor Kamensky wrote: > On 21 January 2014 22:41, Alexander Graf wrote: >> >> >> "Native endian" really is just a shortcut for "target endian" >> which is LE for ARM and BE for PPC. There shouldn't be >> a qemu-system-armeb or qemu-system-ppc64le. > > I disagree. Fu

Re: [Qemu-devel] [PATCH v3 1/4] KVM/X86: Fix xsave cpuid exposing bug

2014-01-22 Thread Paolo Bonzini
Il 21/01/2014 19:59, Liu, Jinsong ha scritto: From 3155a190ce6ebb213e6c724240f4e6620ba67a9d Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Fri, 13 Dec 2013 02:32:03 +0800 Subject: [PATCH v3 1/4] KVM/X86: Fix xsave cpuid exposing bug EBX of cpuid(0xD, 0) is dynamic per XCR0 features enable/dis

[Qemu-devel] [PATCH] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
The qemu-img.texi / qemu-doc.texi files currently describe the qcow2/qcow2 encryption thus "Encryption uses the AES format which is very secure (128 bit keys). Use a long password (16 characters) to get maximum protection." While AES is indeed a strong encryption system, the way that QCow

Re: [Qemu-devel] [PATCH v3 2/4] KVM/X86: Intel MPX vmx and msr handle

2014-01-22 Thread Paolo Bonzini
Il 21/01/2014 20:01, Liu, Jinsong ha scritto: From 31e68d752ac395dc6b65e6adf45be5324e92cdc8 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Fri, 13 Dec 2013 02:32:43 +0800 Subject: [PATCH v3 2/4] KVM/X86: Intel MPX vmx and msr handle This patch handle vmx and msr of Intel MPX feature. Signed-

Re: [Qemu-devel] [PATCH] qapi: Add "backing" and "file" to BlockStats

2014-01-22 Thread Eric Blake
On 01/22/2014 02:35 AM, Kevin Wolf wrote: > Am 22.01.2014 um 04:30 hat Fam Zheng geschrieben: >> Currently there is no way to query BlockStats of the backing chain. This >> adds "backing" and "file" fields into BlockStats to make it possible. >> >> The old optional field "parent", which has the inf

Re: [Qemu-devel] [v19 04/25] add some QemuOpts functions for replace work

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > Add some qemu_opt functions to replace the same functionality of > QEMUOptionParameter handling. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > include/qemu/option.h |7 +++ > util/qemu-option.c| 131 > +++

Re: [Qemu-devel] Simulate different network card vendors

2014-01-22 Thread rajan pathak
Thanks Stefan. I don't have source code of QEMU emulation of the network card? I do have the source code(driver code) of the devices the I wanted to emulate. Basically,Ethernet controller, I wanted to emulate has following two main part 1)Ethernet PHY 2)Ethernet MAC nd have driver code for t

Re: [Qemu-devel] [v19 05/25] change block layer to support both QemuOpts and QEMUOptionParameter

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > Change block layer to support both QemuOpts and QEMUOptionParameter. > After this patch, it will change backend drivers one by one. At the end, > QEMUOptionParameter will be removed and only QemuOpts is kept. > > Signed-off-by: Dong Xu Wang >

Re: [Qemu-devel] [v19 06/25] cow.c: replace QEMUOptionParameter with QemuOpts

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > cow.c: replace QEMUOptionParameter with QemuOpts This line is both in the subject and in the body and thus appears twice in the commit message. Please remove it from the body. > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > ---

Re: [Qemu-devel] [v19 01/25] add def_value_str to QemuOptDesc

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > Add def_value_str (default value) to QemuOptDesc, to replace function of the > default value in QEMUOptionParameter. And improved related functions. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu It would be worth mentioning t

Re: [Qemu-devel] [v19 03/25] improve some functions in qemu-option.c

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > Improve opt_get and opt_set group of functions. For opt_get, check and handle > NUlL input; for opt_set, when set to an existing option, rewrite the option > with new value. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu Why do

Re: [Qemu-devel] [PATCH] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Eric Blake
On 01/22/2014 04:36 AM, Daniel P. Berrange wrote: > The qemu-img.texi / qemu-doc.texi files currently describe the > qcow2/qcow2 encryption thus > > "Encryption uses the AES format which is very secure (128 bit >keys). Use a long password (16 characters) to get maximum >protection." > >

Re: [Qemu-devel] [v19 07/25] gluster.c: replace QEMUOptionParameter with QemuOpts

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > gluster.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu This conflicts with the queued patch "gluster: Add support for creating zero-filled image". Can you please rebase on top of my

Re: [Qemu-devel] [PATCH] kvm: print suberror on all internal errors

2014-01-22 Thread Paolo Bonzini
Il 21/01/2014 18:11, Radim Krčmář ha scritto: KVM introduced internal error exit reason and suberror at the same time, and later extended it with internal error data. QEMU does not report suberror on hosts between these two events because we check for the extension. (half a year in 2009, but it i

Re: [Qemu-devel] [v19 12/25] qed.c: replace QEMUOptionParameter with QemuOpts

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > qed.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/qed.c | 89 > +-- > block/qed.h |3 +- > 2 files chang

Re: [Qemu-devel] [PATCH] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
On Wed, Jan 22, 2014 at 11:49:21AM +, Peter Maydell wrote: > On 22 January 2014 11:36, Daniel P. Berrange wrote: > > Recommend against any use of QCow/QCow2 encryption, directing > > users to dm-crypt / LUKS which can meet modern cryptography > > best practices. > > Couple of minor typo nits

Re: [Qemu-devel] [v19 22/25] vhdx.c: replace QEMUOptionParameter with QemuOpts

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:20 hat Chunyan Liu geschrieben: > vhdx.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/vhdx.c | 93 +++-- > block/vhdx.h |1 + > 2 files changed,

Re: [Qemu-devel] [PATCH] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Peter Maydell
On 22 January 2014 11:36, Daniel P. Berrange wrote: > Recommend against any use of QCow/QCow2 encryption, directing > users to dm-crypt / LUKS which can meet modern cryptography > best practices. Couple of minor typo nits I spotted: > diff --git a/qemu-doc.texi b/qemu-doc.texi > index 4e9c6e9..c

Re: [Qemu-devel] [Xen-devel] Project idea: make QEMU more flexible

2014-01-22 Thread Wei Liu
On Wed, Jan 22, 2014 at 11:20:38AM +0100, Paolo Bonzini wrote: > Il 21/01/2014 19:27, Wei Liu ha scritto: > >>> > >>> Googling "disable tcg" would have provided an answer, but the patches > >>> were old enough to be basically useless. I'll refresh the current > >>> version in the next few days. C

Re: [Qemu-devel] [Xen-devel] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-01-22 Thread Fabio Fantoni
Il 28/10/2013 10:38, Jan Beulich ha scritto: On 24.10.13 at 14:17, "Gonglei (Arei)" wrote: Now I test the patch based on the codes of trunk, which works well. The patch has been modified after your suggestion. Partly. I looks reasonable now, but still not pretty. But the tools maintainers will

Re: [Qemu-devel] [v19 24/25] cleanup QEMUOptionParameter

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:20 hat Chunyan Liu geschrieben: > Now all places using QEMUOptionParameter could use QemuOpts too, remove > QEMUOptionParameter related code. > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block.c | 147 ++- > bloc

Re: [Qemu-devel] [v19 00/25] replace QEMUOptionParameter with QemuOpts

2014-01-22 Thread Kevin Wolf
Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > only > one Qemu Option structure is kept in QEMU code. > > This version is based on Dong Xu's previous patches, to move the work forward. > https://lists.gnu.org/arch

Re: [Qemu-devel] [PATCH] qapi: Add "backing" and "file" to BlockStats

2014-01-22 Thread Eric Blake
On 01/21/2014 08:30 PM, Fam Zheng wrote: > Currently there is no way to query BlockStats of the backing chain. This > adds "backing" and "file" fields into BlockStats to make it possible. > > The old optional field "parent", which has the information for "file", > is kept there for backward compat

[Qemu-devel] [PATCH v2] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
The qemu-img.texi / qemu-doc.texi files currently describe the qcow2/qcow2 encryption thus "Encryption uses the AES format which is very secure (128 bit keys). Use a long password (16 characters) to get maximum protection." While AES is indeed a strong encryption system, the way that QCow

Re: [Qemu-devel] [PATCH v3 0/4] X86/KVM: enable Intel MPX for KVM

2014-01-22 Thread Paolo Bonzini
Il 22/01/2014 06:29, Liu, Jinsong ha scritto: These patches are version 3 to enalbe Intel MPX for KVM. Version 1: * Add some Intel MPX definiation * Fix a cpuid(0x0d, 0) exposing bug, dynamic per XCR0 features enable/disable * vmx and msr handle for MPX support at KVM * enalbe MPX featur

[Qemu-devel] [PATCH] cpu: implementing victim TLB for QEMU system emulated TLB

2014-01-22 Thread Xin Tong
This patch adds a victim TLB to the QEMU system mode TLB. QEMU system mode page table walks are expensive. Taken by running QEMU qemu-system-x86_64 system mode on Intel PIN , a TLB miss and walking a 4-level page tables in guest Linux OS takes ~450 X86 instructions on average. QEMU system mode TL

Re: [Qemu-devel] [PATCH v3 2/4] KVM/X86: Intel MPX vmx and msr handle

2014-01-22 Thread Paolo Bonzini
Il 22/01/2014 12:38, Paolo Bonzini ha scritto: Il 21/01/2014 20:01, Liu, Jinsong ha scritto: From 31e68d752ac395dc6b65e6adf45be5324e92cdc8 Mon Sep 17 00:00:00 2001 From: Liu Jinsong Date: Fri, 13 Dec 2013 02:32:43 +0800 Subject: [PATCH v3 2/4] KVM/X86: Intel MPX vmx and msr handle This patch h

Re: [Qemu-devel] [PATCH v4 0/8] spapr: bootindex support

2014-01-22 Thread Alexey Kardashevskiy
On 01/22/2014 09:16 PM, Paolo Bonzini wrote: > Il 22/01/2014 05:19, Alexey Kardashevskiy ha scritto: >> On 12/11/2013 09:22 PM, Alexey Kardashevskiy wrote: >>> With the great help from Paolo, I am presenting yet another try of >>> bootindex >>> support on sPAPR, this time with some QOM fixes. Detai

Re: [Qemu-devel] [PATCH v2] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Eric Blake
On 01/22/2014 05:28 AM, Daniel P. Berrange wrote: > > Recommend against any use of QCow/QCow2 encryption, directing > users to dm-crypt / LUKS which can meet modern cryptography > best practices. > > Signed-off-by: Daniel P. Berrange > --- > qemu-doc.texi | 23 --- > qemu-i

Re: [Qemu-devel] outlined TLB lookup on x86

2014-01-22 Thread Xin Tong
On Wed, Nov 27, 2013 at 8:12 PM, Richard Henderson wrote: > On 11/27/2013 08:41 PM, Xin Tong wrote: >> I am trying to implement a out-of-line TLB lookup for QEMU softmmu-x86-64 on >> x86-64 machine, potentially for better instruction cache performance, I have >> a >> few questions. >> >> 1. I se

Re: [Qemu-devel] [PATCH uq/master] kvm: always update the MPX model specific register

2014-01-22 Thread Marcelo Tosatti
On Mon, Jan 20, 2014 at 02:25:36PM +0100, Paolo Bonzini wrote: > The original patch from Liu Jinsong restricted them to reset or full > state updates, but that's unnecessary (and wrong) since the BNDCFGS > MSR has no side effects. Why is it necessary to save/restore BNDCFGS MSR on states other tha

Re: [Qemu-devel] [PATCH v2] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The qemu-img.texi / qemu-doc.texi files currently describe the > qcow2/qcow2 encryption thus > > "Encryption uses the AES format which is very secure (128 bit >keys). Use a long password (16 characters) to get maximum >protection." > > While AES is indeed

Re: [Qemu-devel] [PATCH v2] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
On Wed, Jan 22, 2014 at 08:24:00AM -0700, Eric Blake wrote: > On 01/22/2014 05:28 AM, Daniel P. Berrange wrote: > > > > > Recommend against any use of QCow/QCow2 encryption, directing > > users to dm-crypt / LUKS which can meet modern cryptography > > best practices. > > > > Signed-off-by: Danie

[Qemu-devel] [PATCH v3] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Daniel P. Berrange
The qemu-img.texi / qemu-doc.texi files currently describe the qcow2/qcow2 encryption thus "Encryption uses the AES format which is very secure (128 bit keys). Use a long password (16 characters) to get maximum protection." While AES is indeed a strong encryption system, the way that QCow

[Qemu-devel] [PATCH] s390: Storage key global access

2014-01-22 Thread Jason J. Herne
From: "Jason J. Herne" Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne --- hw/s390x/s390-virtio-ccw.c | 3 +-- hw/s390x/s390-virtio.c | 6 +++--- hw/s390x/s390-virtio.h | 2 +- target-s390x

Re: [Qemu-devel] [PATCH 01/13 v7] dump: const-qualify the buf of WriteCoreDumpFunction

2014-01-22 Thread Laszlo Ersek
On 01/17/14 08:46, qiaonuohan wrote: > WriteCoreDumpFunction is a function pointer that points to the function used > to > write content in "buf" into core file, so "buf" should be const-qualify. > > Signed-off-by: Qiao Nuohan > --- > dump.c|2 +- > include/qom/cpu.h |3 ++-

Re: [Qemu-devel] [PATCH v3] Describe flaws in qcow/qcow2 encryption in the docs

2014-01-22 Thread Eric Blake
On 01/22/2014 08:47 AM, Daniel P. Berrange wrote: > The qemu-img.texi / qemu-doc.texi files currently describe the > qcow2/qcow2 encryption thus > > Recommend against any use of QCow/QCow2 encryption, directing > users to dm-crypt / LUKS which can meet modern cryptography > best practices. > > S

Re: [Qemu-devel] [PATCH 02/13 v7] dump: add argument to write_elfxx_notes

2014-01-22 Thread Laszlo Ersek
On 01/17/14 08:46, qiaonuohan wrote: > write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to > vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to > choose > the method of writing elf notes > > Signed-off-by: Qiao Nuohan > Reviewed-by: Laszlo Ersek >

Re: [Qemu-devel] Simulate different network card vendors

2014-01-22 Thread Stefan Hajnoczi
On Wed, Jan 22, 2014 at 06:30:42PM +0530, rajan pathak wrote: > But I don't know what are the steps to emulate it for QEMU. > > Would you suggest me some links where I can get some idea of how emulating > a Device for QEMU? Look at existing code in hw/net/*.c, for example e1000.c. Stefan

Re: [Qemu-devel] [PATCH 03/13 v7] dump: add API to write header of flatten format

2014-01-22 Thread Laszlo Ersek
On 01/17/14 08:46, qiaonuohan wrote: > flatten format will be used when writing kdump-compressed format. The format > is > also used by makedumpfile, you can refer to the following URL to get more > detailed information about flatten format of kdump-compressed format: > http://sourceforge.net/proj

[Qemu-devel] [PATCH v2 06/42] input: qapi: define event types

2014-01-22 Thread Gerd Hoffmann
Define input event types, using qapi. So we get nicely autogenerated types for our input events. And when it comes to qmp support some day things will be alot easier. Types are modeled after the linux input layer. There are separate event types for each value. There is a sync to indicate the e

[Qemu-devel] [PATCH v2 02/42] sdl2: baum build fix

2014-01-22 Thread Gerd Hoffmann
--- backends/baum.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/baum.c b/backends/baum.c index 1132899..665107f 100644 --- a/backends/baum.c +++ b/backends/baum.c @@ -566,7 +566,7 @@ CharDriverState *chr_baum_init(void) BaumDriverState *baum; CharDriv

[Qemu-devel] [PATCH v2 08/42] input: qapi: add pause key

2014-01-22 Thread Gerd Hoffmann
It's missing. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index eace666..f7c2cc5 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3391,7 +3391,7 @@ # # Since: 1.3.0 # -# '

[Qemu-devel] [PATCH v2 07/42] input: qapi: add unmapped key

2014-01-22 Thread Gerd Hoffmann
Simplifies building something -> QkeyCode mapping tables. Uninitialized entries can easily identified then. Signed-off-by: Gerd Hoffmann --- qapi-schema.json | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 38ffc88..eace666 100644

[Qemu-devel] [PATCH v2 21/42] input: mouse: add qemu_input_is_absolute()

2014-01-22 Thread Gerd Hoffmann
Same as kbd_mouse_is_absolute(), but using new input core. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 1 + ui/input.c | 8 2 files changed, 9 insertions(+) diff --git a/include/ui/input.h b/include/ui/input.h index c6f50c2..28afc45 100644 --- a/include/ui/input.h +++

[Qemu-devel] [PATCH v2 04/42] console: export QemuConsole index, width, height

2014-01-22 Thread Gerd Hoffmann
Add functions to query QemuConsole properties. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 +++ ui/console.c | 24 2 files changed, 27 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 4156a87..8543d18 100644 --- a/inclu

[Qemu-devel] [PATCH v2 14/42] input: keyboard: switch sdl ui to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index 736bb95..c3b8036 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -32,6 +32,7 @@ #include "qemu-common.h" #include "ui/console.h" +#inclu

[Qemu-devel] [PATCH v2 09/42] input: add core bits of the new input layer

2014-01-22 Thread Gerd Hoffmann
Register and unregister handlers. Event dispatcher code. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 32 + ui/Makefile.objs | 2 +- ui/input.c | 83 ++ 3 files changed, 116 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 00/42] rework input handling, sdl2 support

2014-01-22 Thread Gerd Hoffmann
Hi, This patch series features a reworked input layer and sdl2 support. The input layer moves to a model modeled roughly after the linux event layer. It also uses qapi to create all the data types needed. First, because it is convinient to have all the support code generated, and also to make

[Qemu-devel] [PATCH v2 05/42] input: rename file to legacy

2014-01-22 Thread Gerd Hoffmann
Rename ui/input.c to ui/input-legacy.c. We are going to replace it step by step. Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 2 +- ui/{input.c => input-legacy.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename ui/{input.c => input-legacy.c} (100%) diff --git a/

[Qemu-devel] [PATCH v2 17/42] input: keyboard: switch spice ui to new core

2014-01-22 Thread Gerd Hoffmann
--- ui/spice-input.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index 3beb8de..c9df699 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -26,12 +26,15 @@ #include "qemu-common.h" #include "ui/qemu-spice.h"

Re: [Qemu-devel] [PATCH] tap-linux: Get features once and use it many times

2014-01-22 Thread Stefan Hajnoczi
On Sat, Jan 18, 2014 at 02:38:45PM +0900, Kusanagi Kouichi wrote: > Signed-off-by: Kusanagi Kouichi > --- > net/tap-linux.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) Thanks, applied to my net tree: https://github.com/stefanha/qemu/commits/net Stefan

Re: [Qemu-devel] [PATCH 04/13 v7] dump: add API to write vmcore

2014-01-22 Thread Laszlo Ersek
On 01/17/14 08:46, qiaonuohan wrote: > Function is used to write vmcore in flatten format. In flatten format, data is > written block by block, and in front of each block, a struct > MakedumpfileDataHeader is stored there to indicate the offset and size of the > data block. > > struct Makedumpfile

[Qemu-devel] [PATCH v2 10/42] input: keyboard: add helper functions to core

2014-01-22 Thread Gerd Hoffmann
A bunch of helper functions to manage keyboard events, to make life simpler for the ui code when submitting keyboard events. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 5 + ui/input.c | 35 +++ 2 files changed, 40 insertions(+) diff --git

[Qemu-devel] [PATCH v2 16/42] input: keyboard: switch vnc ui to new core

2014-01-22 Thread Gerd Hoffmann
--- ui/vnc.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..4658559 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -33,6 +33,7 @@ #include "qapi/qmp/types.h" #include "qmp-commands.h" #include "qemu/osdep.h" +#include "

[Qemu-devel] [PATCH v2 23/42] input: mouse: switch gtk ui to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 58 +++--- 1 file changed, 19 insertions(+), 39 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 993a9b5..64a0228 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -190,7 +190,7 @@ static void gd_update_curs

[Qemu-devel] [PATCH v2 12/42] input: keyboard: switch qmp_send_key() to new core.

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 80f4f5c..a4006cc 100644 --- a/ui/input-legacy.c +++ b/ui/input-legacy.c @@ -260,10 +260,8 @@ static void free_keycodes(voi

[Qemu-devel] [PATCH v2 35/42] input-legacy: remove kbd_mouse_event

2014-01-22 Thread Gerd Hoffmann
--- include/ui/console.h | 1 - ui/input-legacy.c| 49 - 2 files changed, 50 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 21b32e4..71a0da3 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -47,7 +47,

[Qemu-devel] [PATCH v2 31/42] input: trace events

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 8 ui/input.c | 48 2 files changed, 56 insertions(+) diff --git a/trace-events b/trace-events index 9f4456a..a81d71e 100644 --- a/trace-events +++ b/trace-events @@ -1019,6 +1019,14 @@ g

[Qemu-devel] [PATCH v2 32/42] input-legacy: remove kbd_put_keycode

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 23 --- 2 files changed, 24 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index a3062d0..c7f4e4f 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -46,7

[Qemu-devel] [PATCH v2 30/42] input: mouse: switch cocoa ui to new core [untested]

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 ++ ui/cocoa.m | 63 ++-- 2 files changed, 44 insertions(+), 21 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 8543d18..a3062d0 100644 --- a/include/u

[Qemu-devel] Intel AVX instructions

2014-01-22 Thread Xin Tong
Intel AVX instructions have been out for some time since sandy-bridge. Is there value to support it in QEMU. I am thinking abut a google summer of code this year to bring support for AVX/AVX2.0 to QEMU. Xin

[Qemu-devel] [PATCH v2 40/42] input: move qmp_query_mice to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 23 --- ui/input.c| 29 + 2 files changed, 29 insertions(+), 23 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 7f8e72b..7843482 100644 --- a/ui/input-legacy.c +++ b

[Qemu-devel] [PATCH v2 36/42] input: move mouse mode notifier to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 4 include/ui/input.h | 4 ui/input-legacy.c| 34 +- ui/input.c | 30 ++ 4 files changed, 35 insertions(+), 37 deletions(-) diff --git a/include/ui/cons

Re: [Qemu-devel] outlined TLB lookup on x86

2014-01-22 Thread Richard Henderson
On 01/22/2014 07:28 AM, Xin Tong wrote: > Can you tell me whether ARM is the only architecture that requires > special treatment for increasing tlb size beyond 256 entries so that i > can whip up a patch to the QEMU mainline. The major constraint for the non-arm ports is CPU_TLB_ENTRY_SIZE +

Re: [Qemu-devel] [PATCH uq/master] kvm: always update the MPX model specific register

2014-01-22 Thread Paolo Bonzini
Il 22/01/2014 16:29, Marcelo Tosatti ha scritto: > The original patch from Liu Jinsong restricted them to reset or full > state updates, but that's unnecessary (and wrong) since the BNDCFGS > MSR has no side effects. Why is it necessary to save/restore BNDCFGS MSR on states other than FULL and R

[Qemu-devel] [PATCH v2 34/42] input-legacy: remove kbd_mouse_is_absolute

2014-01-22 Thread Gerd Hoffmann
--- include/ui/console.h | 1 - ui/input-legacy.c| 11 +-- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 53e956d..21b32e4 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -50,7 +50,6 @@ void kbd_put_leds

[Qemu-devel] [PATCH v2 20/42] input: mouse: add graphic_rotate support

2014-01-22 Thread Gerd Hoffmann
Transform absolute mouse events according to graphic_rotate. Legacy input code does it for both absolute and relative events, but the logic is broken for relative coordinates, so this is most likely not used anyway. Signed-off-by: Gerd Hoffmann --- ui/input.c | 33 ++

[Qemu-devel] [PATCH v2 42/42] input: remove index_from_keycode (no users)

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 1 - ui/input-legacy.c| 14 -- 2 files changed, 15 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index 9a282cb..3bf69ee 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -329,7 +329,6 @

Re: [Qemu-devel] [PATCH v11 00/11] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-01-22 Thread Ian Main
On Wed, Jan 08, 2014 at 06:07:41PM +0800, Fam Zheng wrote: > This series adds for point-in-time snapshot NBD exporting based on > blockdev-backup (variant of drive-backup with existing device as target). > > We get a thin point-in-time snapshot by COW mechanism of drive-backup, and > export it thr

[Qemu-devel] [PATCH v2 38/42] sdl2: simplify keymap handling

2014-01-22 Thread Gerd Hoffmann
sdl2 gives us scancodes (i.e. identifies keys by location not by keysym mapped to it). We can map them directly to QKeyCodes, pass them on to the new input core and be done with it. No need to jump though any keymap hops. Zap the code. Also operate directly on SDL scancodes for any hotkeys. Sig

Re: [Qemu-devel] outlined TLB lookup on x86

2014-01-22 Thread Peter Maydell
On 22 January 2014 15:28, Xin Tong wrote: > On Wed, Nov 27, 2013 at 8:12 PM, Richard Henderson wrote: >> I'd be interested to experiment with different TLB sizes, to see what effect >> that has on performance. But I suspect that lack of TLB contexts mean that >> we >> wind up flushing the TLB m

[Qemu-devel] [PATCH v2 41/42] input: move do_mouse_set to new core

2014-01-22 Thread Gerd Hoffmann
This removes the last user of the lecagy input mouse handler list, so we can remove more legacy bits with this. Signed-off-by: Gerd Hoffmann --- ui/input-legacy.c | 43 --- ui/input.c| 21 + 2 files changed, 21 insertions(+), 43

[Qemu-devel] [PATCH v2 19/42] input: mouse: add helpers functions to core

2014-01-22 Thread Gerd Hoffmann
Likewise a bunch of helper functions to manage mouse button and movement events, again to make life easier for the ui code. Signed-off-by: Gerd Hoffmann --- include/ui/input.h | 14 +++ ui/input.c | 71 ++ 2 files changed, 85 in

[Qemu-devel] [PATCH v2 33/42] input-legacy: remove kbd_mouse_has_absolute

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 3 --- ui/input-legacy.c| 21 ++--- 2 files changed, 2 insertions(+), 22 deletions(-) diff --git a/include/ui/console.h b/include/ui/console.h index c7f4e4f..53e956d 100644 --- a/include/ui/console.h +++ b/include/ui/co

[Qemu-devel] [PATCH v2 24/42] input: mouse: switch sdl ui to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/sdl.c | 84 ++-- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/ui/sdl.c b/ui/sdl.c index c3b8036..c1a16be 100644 --- a/ui/sdl.c +++ b/ui/sdl.c @@ -353,7 +353,7 @@ static void sdl_hide

[Qemu-devel] [PATCH v2 39/42] sdl2: codestyle fixups

2014-01-22 Thread Gerd Hoffmann
--- ui/Makefile.objs | 2 +- ui/sdl2.c| 173 +-- 2 files changed, 104 insertions(+), 71 deletions(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index e6a5ec1..6f2294e 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -15,6

Re: [Qemu-devel] [v19 00/25] replace QEMUOptionParameter with QemuOpts

2014-01-22 Thread Stefan Hajnoczi
On Wed, Jan 22, 2014 at 03:35:15PM +0100, Kevin Wolf wrote: > Am 20.01.2014 um 15:19 hat Chunyan Liu geschrieben: > > This patch series is to replace QEMUOptionParameter with QemuOpts, so that > > only > > one Qemu Option structure is kept in QEMU code. > > > > This version is based on Dong Xu's

[Qemu-devel] [PATCH v2 27/42] input: mouse: switch spice ui to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/spice-input.c | 62 ++-- 1 file changed, 38 insertions(+), 24 deletions(-) diff --git a/ui/spice-input.c b/ui/spice-input.c index c9df699..6dab23b 100644 --- a/ui/spice-input.c +++ b/ui/spice-input.c @@ -98,4

[Qemu-devel] [PATCH v2 37/42] input: add input_mouse_mode tracepoint

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- trace-events | 1 + ui/input.c | 1 + 2 files changed, 2 insertions(+) diff --git a/trace-events b/trace-events index a81d71e..322ad11 100644 --- a/trace-events +++ b/trace-events @@ -1026,6 +1026,7 @@ input_event_btn(int conidx, const char *btn, bool down) "c

[Qemu-devel] [PATCH v2 11/42] input: keyboard: switch legacy handlers to new core

2014-01-22 Thread Gerd Hoffmann
legacy kbd event handlers are registered in the new core, so they receive events from the new input core code. keycode -> scancode translation needed here. legacy kbd_put_keycode() sends events to the new core. scancode -> keycode translation needed here. So with this patch the new input core is

[Qemu-devel] [PATCH v2 15/42] sdl2: switch keyboard handling to new core

2014-01-22 Thread Gerd Hoffmann
--- ui/sdl2.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index e7a30b3..ac3ac19 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -33,6 +33,7 @@ #include "qemu-common.h" #include "ui/console.h" +#include "ui/input.h" #include "s

[Qemu-devel] [PATCH v2 26/42] input: mouse: switch vnc ui to new core

2014-01-22 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/vnc.c | 46 ++ ui/vnc.h | 1 + 2 files changed, 23 insertions(+), 24 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 4658559..7dfc94a 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1484,7 +1484,7 @@ static void client

Re: [Qemu-devel] [PATCH 07/13 v7] dump: add members to DumpState and init some of them

2014-01-22 Thread Laszlo Ersek
comments below On 01/17/14 08:46, qiaonuohan wrote: > add some members to DumpState that will be used in writing vmcore in > kdump-compressed format. some of them, like page_size, will be initialized > in the patch. > > Signed-off-by: Qiao Nuohan > --- > dump.c| 30 +++

  1   2   >