Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-12-07 Thread Stefan Hajnoczi
On Fri, Dec 6, 2013 at 4:40 PM, Will Drewry wrote: > On Fri, Dec 6, 2013 at 3:13 AM, Stefan Hajnoczi wrote: >> On Thu, Dec 05, 2013 at 10:12:00AM -0600, Will Drewry wrote: >>> On Thu, Dec 5, 2013 at 7:15 AM, Stefan Hajnoczi wrote: >>> > On Wed, Dec 04, 2013 at 11:21:12AM -0200, Eduardo Otubo wro

[Qemu-devel] [PATCH] openrisc: Fix spelling in comment (transaltion -> translation)

2013-12-07 Thread Stefan Weil
I also removed two hyphens in the same comment. Signed-off-by: Stefan Weil --- target-openrisc/translate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c index 91c60eb..b381477 100644 --- a/target-openrisc/translat

[Qemu-devel] [PATCH] misc: Use macro ARRAY_SIZE were possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Signed-off-by: Stefan Weil --- hw/audio/intel-hda.c |4 ++-- net/net.c|2 +- qemu-char.c |3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 43

[Qemu-devel] [PATCH] ui/cocoa: Use macro ARRAY_SIZE were possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Signed-off-by: Stefan Weil --- Please note that I could not test this patch. Regards, Stefan ui/cocoa.m |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index be49179..2524f18 100644 --- a/ui

[Qemu-devel] [PATCH] exynos4210: Use macro ARRAY_SIZE were possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Signed-off-by: Stefan Weil --- hw/char/exynos4210_uart.c |6 ++ hw/misc/exynos4210_pmu.c |3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/char/exynos4210_uart.c b/hw/char/exynos4210_uart.c index eef23a0..19b

[Qemu-devel] [PATCH] target.mips: Use macro ARRAY_SIZE were possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Signed-off-by: Stefan Weil --- I'm not sure whether this patch qualifies as a trivial one. Stefan target-mips/dsp_helper.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/target-mips/dsp_

[Qemu-devel] [PATCH] linux-user: Use macro TARGET_NSIG_WORDS were possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Signed-off-by: Stefan Weil --- linux-user/signal.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 7751c47..8f692cd 100644 --- a/linux-user/signal.c +++ b/linux-user/

Re: [Qemu-devel] [PATCH] misc: Use macro ARRAY_SIZE were possible

2013-12-07 Thread Peter Maydell
On 7 December 2013 08:42, Stefan Weil wrote: > This improves readability and simplifies the code. Typo in subject: should be "where", not "were" (ditto in the other patches you've sent). thanks -- PMM

Re: [Qemu-devel] [PATCH] openrisc: Fix spelling in comment (transaltion -> translation)

2013-12-07 Thread Jia Liu
Hi Stefan, On Sat, Dec 7, 2013 at 4:24 PM, Stefan Weil wrote: > I also removed two hyphens in the same comment. > > Signed-off-by: Stefan Weil > --- > target-openrisc/translate.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-openrisc/translate.c b/target-ope

[Qemu-devel] [PATCH] osdep: Get environment pointer from global variable

2013-12-07 Thread Stefan Weil
Linux provides a global variable __environ, so it is not necessary to use envp from main and propagate it via qemu_init_auxval. Signed-off-by: Stefan Weil --- include/qemu/osdep.h | 12 linux-user/main.c|3 +-- util/getauxval.c |9 - vl.c |

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-07 Thread Don Slutz
On 12/05/13 10:18, Paolo Bonzini wrote: Il 04/12/2013 02:32, Don Slutz ha scritto: Any hints or pointers about the bug in RHEL5 binutils? I can try and make a patch to auto detect this. Actually it's RHEL5 GCC: $ cat f.c void * f(unsigned char *buf, int len) { return (void*)0L; } void

[Qemu-devel] [PATCH v2 0/5] Replace sizeof(array) / sizeof(*array)

2013-12-07 Thread Stefan Weil
These patches were previously sent as single patches instead of a patch series. They all replace sizeof(array) / sizeof(*array) by macros. v2: Fix typos in commit messages (thanks to Peter Maydell). [PATCH v2 1/5] misc: Use macro ARRAY_SIZE where possible [PATCH v2 2/5] ui/cocoa: Use macro ARRAY_

[Qemu-devel] [PATCH v2 1/5] misc: Use macro ARRAY_SIZE where possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Cc: Anthony Liguori Cc: Gerd Hoffmann Cc: Stefan Hajnoczi Signed-off-by: Stefan Weil --- hw/audio/intel-hda.c |4 ++-- net/net.c|2 +- qemu-char.c |3 +-- 3 files changed, 4 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v2 2/5] ui/cocoa: Use macro ARRAY_SIZE where possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Cc: Andreas Färber Cc: Anthony Liguori Signed-off-by: Stefan Weil --- ui/cocoa.m |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index be49179..2524f18 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.

[Qemu-devel] [PATCH v2 5/5] linux-user: Use macro TARGET_NSIG_WORDS where possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Cc: Riku Voipio Signed-off-by: Stefan Weil --- linux-user/signal.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 7751c47..8f692cd 100644 --- a/linux-user/signal.c

[Qemu-devel] [PATCH v2 4/5] target-mips: Use macro ARRAY_SIZE where possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Cc: Aurelien Jarno Signed-off-by: Stefan Weil --- target-mips/dsp_helper.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index b088a25.

[Qemu-devel] [PATCH v2 3/5] exynos4210: Use macro ARRAY_SIZE where possible

2013-12-07 Thread Stefan Weil
This improves readability and simplifies the code. Cc: Dmitry Solodkiy Cc: Evgeny Voevodin Cc: Igor Mitsyanko Cc: Maksim Kozlov Signed-off-by: Stefan Weil --- hw/char/exynos4210_uart.c |6 ++ hw/misc/exynos4210_pmu.c |3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH] qxl: Add missing trace.h (fix broken build)

2013-12-07 Thread Stefan Weil
Commit ac86048bcd41129b18702ba63395f222871804de removed trace.h from console.h and ignored the fact that qxl-render.c needs this file (it includes qxl.h which includes console.h which included trace.h). Signed-off-by: Stefan Weil --- Sorry for this regression. Obviously most builds don't set CON

[Qemu-devel] failed to add usb3.0 device

2013-12-07 Thread WANG Siyuan
Hi, I am failed to use host usb stick attached on usb 3.0 port. qemu version is 1.7.0. I attached usb2.0 disk and usb3.0 disk on usb3.0 port. Both are failed. I use this command to add xhci and host usb disk: -device nec-usb-xhci,id=xhci -device usb-host,bus=xhci.0,hostbus=3,hostaddr=18 Here is lo

[Qemu-devel] Fwd: failed to add usb3.0 device

2013-12-07 Thread WANG Siyuan
Hi, I am failed to use host usb stick attached on usb 3.0 port. qemu version is 1.7.0. I attached usb2.0 disk and usb3.0 disk on usb3.0 port. Both are failed. I use this command to add xhci and host usb disk: -device nec-usb-xhci,id=xhci -device usb-host,bus=xhci.0,hostbus=3,hostaddr=18 Here is lo

[Qemu-devel] [BUG] tci: Endless recursion in QEMU host while booting a Linux ISO image in the guest

2013-12-07 Thread Stefan Weil
Booting Tiny Core Linux with QEMU + TCI results in an endless recursion at the end of the guest's Linux boot process. The last kernel debug message (kernel started with debug) was "Write protecting the kernel read-only data: 980 k". The ISO image is available from http://tinycorelinux.net/5.x/x86/

[Qemu-devel] [PATCH] gtk: Support keyboard translation for hosts running Windows

2013-12-07 Thread Stefan Weil
GTK uses different hardware keycodes on Windows hosts, so some special handling is needed to get the QEMU keycode. Signed-off-by: Stefan Weil --- ui/gtk.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 6316f5b..a633d89 100644 -

Re: [Qemu-devel] [PATCH v2 0/5] Replace sizeof(array) / sizeof(*array)

2013-12-07 Thread Peter Maydell
On 7 December 2013 13:48, Stefan Weil wrote: > These patches were previously sent as single patches instead of > a patch series. They all replace sizeof(array) / sizeof(*array) > by macros. > > v2: Fix typos in commit messages (thanks to Peter Maydell). Whole series: Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH] tcg: Use bitmaps for free temporaries

2013-12-07 Thread Peter Maydell
On 19 September 2013 20:58, Richard Henderson wrote: > We previously allocated 32-bits per temp for the next_free_temp entry. > We now allocate 4 bits per temp across the 4 bitmaps. > > Using a linked list meant that if a translator is tweeked, resulting in > temps being freed in a different order

Re: [Qemu-devel] [PATCH] osdep: Get environment pointer from global variable

2013-12-07 Thread Peter Maydell
On 7 December 2013 13:14, Stefan Weil wrote: > Linux provides a global variable __environ, so it is not necessary to > use envp from main and propagate it via qemu_init_auxval. I don't think this will work, because __environ changes whenever the environment is modified (eg by setenv() calls). It'

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/arm/highbank: Simplify code (memory region in device state)

2013-12-07 Thread Michael Tokarev
06.12.2013 22:43, Stefan Weil wrote: > The memory region can be included by value instead of by reference in the > device state (like it is done in other SoCs). Applied to trivial-patches queue, with the suggested comment fix. Thanks! /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Add missing trace.h (fix broken build)

2013-12-07 Thread Michael Tokarev
07.12.2013 18:09, Stefan Weil wrote: > Commit ac86048bcd41129b18702ba63395f222871804de removed trace.h from > console.h and ignored the fact that qxl-render.c needs this file > (it includes qxl.h which includes console.h which included trace.h). > > Signed-off-by: Stefan Weil > --- > > Sorry for

[Qemu-devel] [PULL urgent] Trivial patches for 2013-12-07

2013-12-07 Thread Michael Tokarev
We have a regression introduced by one of previous trivial patches, here's a (one-line) fix for it. Please consider applying/pulling at earliest opportunity, since it fixes a build problem when CONFIG_QXL is enabled. Thanks, /mjt The following changes since commit d2aa90cda81ae3f860dd047ce5e37e

[Qemu-devel] [PULL] qxl: Add missing trace.h (fix broken build)

2013-12-07 Thread Michael Tokarev
From: Stefan Weil Commit ac86048bcd41129b18702ba63395f222871804de removed trace.h from console.h and ignored the fact that qxl-render.c needs this file (it includes qxl.h which includes console.h which included trace.h). Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/display

Re: [Qemu-devel] [Qemu-trivial] [PATCH] openrisc: Fix spelling in comment (transaltion -> translation)

2013-12-07 Thread Michael Tokarev
07.12.2013 12:24, Stefan Weil wrote: > I also removed two hyphens in the same comment. Thanks, applied. /mjt

Re: [Qemu-devel] [PATCH] x86: only allow real mode to access 32bit without LMA

2013-12-07 Thread Michael Tokarev
06.12.2013 16:52, Alexander Graf wrote: > When we're running in non-64bit mode with qemu-system-x86_64 we can > still end up with virtual addresses that are above the 32bit boundary > if a segment offset is set up. > > GNU Hurd does exactly that. It sets the segment offset to 0x8000 and > puts

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 0/5] Replace sizeof(array) / sizeof(*array)

2013-12-07 Thread Michael Tokarev
07.12.2013 17:48, Stefan Weil wrote: > These patches were previously sent as single patches instead of > a patch series. They all replace sizeof(array) / sizeof(*array) > by macros. > > v2: Fix typos in commit messages (thanks to Peter Maydell). Applied to trivial-patches queue. > [PATCH v2 1/5]

Re: [Qemu-devel] [PATCH] target-arm: Use new qemu_ld/st opcodes

2013-12-07 Thread Peter Maydell
On 7 December 2013 00:34, Richard Henderson wrote: > Retain the existing gen_aa32_* inlines, to aid compilation for A64. > -#define DO_GEN_LD(OP)\ > -static inline void gen_aa32_##OP(TCGv_i32 val, TCGv_i32 addr, int index) \ > +#define DO_GEN_L

Re: [Qemu-devel] [RFC 1/2] ARM: cpu: add "hivecs" property (high vectors on reset)

2013-12-07 Thread Antony Pavlov
On Sat, 7 Dec 2013 11:00:05 +1000 Peter Crosthwaite wrote: > On Sat, Dec 7, 2013 at 10:55 AM, Antony Pavlov > wrote: > > Signed-off-by: Antony Pavlov > > --- > > target-arm/cpu-qom.h | 1 + > > target-arm/cpu.c | 13 + > > 2 files changed, 14 insertions(+) > > > > diff --git

Re: [Qemu-devel] [RFC 2/2] ARM: arm_cpu_reset: make possible to use high vectors for reset_exc

2013-12-07 Thread Antony Pavlov
On Sat, 7 Dec 2013 11:08:40 +1000 Peter Crosthwaite wrote: > On Sat, Dec 7, 2013 at 10:55 AM, Antony Pavlov > wrote: > > Signed-off-by: Antony Pavlov > > --- > > target-arm/cpu.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/target-arm/cpu.c b/target-arm/cpu.c > > index f

Re: [Qemu-devel] [RFC 2/2] ARM: arm_cpu_reset: make possible to use high vectors for reset_exc

2013-12-07 Thread Peter Maydell
On 7 December 2013 20:49, Antony Pavlov wrote: > On Sat, 7 Dec 2013 11:08:40 +1000 > Peter Crosthwaite wrote: > >> On Sat, Dec 7, 2013 at 10:55 AM, Antony Pavlov >> wrote: >> > Signed-off-by: Antony Pavlov >> > --- >> > target-arm/cpu.c | 4 >> > 1 file changed, 4 insertions(+) >> > >> >

Re: [Qemu-devel] [RFC 1/2] ARM: cpu: add "hivecs" property (high vectors on reset)

2013-12-07 Thread Peter Crosthwaite
On Sun, Dec 8, 2013 at 6:44 AM, Antony Pavlov wrote: > On Sat, 7 Dec 2013 11:00:05 +1000 > Peter Crosthwaite wrote: > >> On Sat, Dec 7, 2013 at 10:55 AM, Antony Pavlov >> wrote: >> > Signed-off-by: Antony Pavlov >> > --- >> > target-arm/cpu-qom.h | 1 + >> > target-arm/cpu.c | 13 +++