Re: [Qemu-devel] [RFC PATCH 03/15] input: define event types using qapi

2013-12-03 Thread Gerd Hoffmann
On Mo, 2013-12-02 at 12:12 -0700, Eric Blake wrote: > On 11/28/2013 07:29 AM, Gerd Hoffmann wrote: > > Define input event types, using qapi. So we get nicely autogenerated > > types for our input events. And when it comes to qmp support some day > > things will be alot easier. > > > > Types are

Re: [Qemu-devel] [PATCHv2 00/14] Spice block device, ready-to-go patches

2013-12-03 Thread Gerd Hoffmann
Hi, > Thanks, applied Patches 1 and 14 to my block tree: > https://github.com/stefanha/qemu/commits/block > > Leaving the rest to Gerd and Paolo. Added 2-13 to the spice patch queue. cheers, Gerd

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
On 2013年12月03日 14:05, Wenchao Xia wrote: > >Why forbid mode = writeback? > These test cases used to run with only possibly "writethrough", or "none". And they don't work with writeback, at least in my case. So I didn't add other modes here. Fam

[Qemu-devel] [PATCH v5 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-12-03 Thread Fam Zheng
This series adds cache mode option in the iotests framework. Test cases are updated to make use of cache mode and mask supported modes. v5: Fix help test for "-c mode". (Wenchao) v4: Address Stefan's comments: Add _default_cache_mode. Split last two cases in 048 to 074. Use long optio

[Qemu-devel] [PATCH v5 1/6] qemu-iotests: Add "-c " option

2013-12-03 Thread Fam Zheng
The option sets cache mode used in the tests. "-nocache" is changed to an alias to "-c none", and internally passes "-t none" to qemu-io. Python scripts will make use of option this in the next commit. Signed-off-by: Fam Zheng --- tests/qemu-iotests/check | 2 +- tests/qemu-iotests/common | 2

[Qemu-devel] [PATCH v5 4/6] qemu-iotests: Change default cache mode to "writeback"

2013-12-03 Thread Fam Zheng
So that the tests can run faster. Signed-off-by: Fam Zheng --- tests/qemu-iotests/common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index 4743c9e..b2a0944 100644 --- a/tests/qemu-iotests/common +++ b/tests/qemu-iotest

[Qemu-devel] [PATCH v5 2/6] qemu-iotests: Honour cache mode in iotests.py

2013-12-03 Thread Fam Zheng
This will allow overriding cache mode from the "-c mode" option. Signed-off-by: Fam Zheng --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index fb10ff4..c84a1a5 100644 --- a/test

[Qemu-devel] [PATCH v5 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
This replaces _unsupported_qemu_io_options and check for support of current cache mode, and allow to provide a default if user didn't specify. Signed-off-by: Fam Zheng --- tests/qemu-iotests/026 | 3 ++- tests/qemu-iotests/039 | 3 ++- tests/qemu-iotests/052 | 4 ++-- tests/

[Qemu-devel] [PATCH v5 6/6] qemu-iotests: Split qcow2 only cases in 048

2013-12-03 Thread Fam Zheng
Format "raw" doesn't always work on certain file systems (e.g. tmpfs). Use qcow2 to make the allocation status explicit and split into a new case. Signed-off-by: Fam Zheng --- tests/qemu-iotests/048 | 27 --- tests/qemu-iotests/048.out | 16 - tests/qemu-iotests/074 |

Re: [Qemu-devel] [PATCH] vmdk: Fix creating big description file

2013-12-03 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 10:29:14AM +0800, Fam Zheng wrote: > On 2013年12月02日 21:26, Stefan Hajnoczi wrote: > >On Mon, Dec 02, 2013 at 11:01:20AM +0800, Fam Zheng wrote: > >>The buffer for description file was 4096 which only covers a few > >>hundred of extents. This changes the buffer to dynamic all

[Qemu-devel] [PATCH v5 5/6] qemu-iotests: Clean up spaces in usage output

2013-12-03 Thread Fam Zheng
Whitespace changes to align columns. Signed-off-by: Fam Zheng --- tests/qemu-iotests/common | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index b2a0944..3e0ecfb 100644 --- a/tests/qemu-iotests/common +++ b

[Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support

2013-12-03 Thread Sergey Fedorov
This patch set implements a basic support of CPU core TrustZone feature. The following major functionalities are implemented: * CPU monitor mode * Separate code translation for each secure state * CPACR & NSACR co-processor access control * Separate TLB for each secure state * Co-processo

[Qemu-devel] [RFC PATCH 04/21] target-arm: preserve RAO/WI bits of ARMv7 SCTLR

2013-12-03 Thread Sergey Fedorov
From: Svetlana Fedoseeva Signed-off-by: Svetlana Fedoseeva Signed-off-by: Sergey Fedorov --- target-arm/helper.c |4 1 file changed, 4 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index 6642e53..d7922ad 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.

[Qemu-devel] [RFC PATCH 10/21] target-arm: add non-secure Translation Block flag

2013-12-03 Thread Sergey Fedorov
This patch is based on idea found in patch at git://github.com/jowinter/qemu-trustzone.git f3d955c6c0ed8c46bc0eb10b634201032a651dd2 by Johannes Winter . This flag prevents from executing TCG code generated for other CPU secure state. It also allows to generate different TCG code depending on CPU s

[Qemu-devel] [RFC PATCH 03/21] target-arm: adjust TTBCR for TrustZone feature

2013-12-03 Thread Sergey Fedorov
TTBCR has additional fields PD0 and PD1 when using Short-descriptor translation table format on a CPU with TrustZone feature support. Signed-off-by: Sergey Fedorov --- target-arm/helper.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/h

[Qemu-devel] [RFC PATCH 08/21] target-arm: adjust arm_current_pl() for TrustZone

2013-12-03 Thread Sergey Fedorov
Make arm_current_pl() to return PL3 in secure privileged mode. Signed-off-by: Sergey Fedorov --- target-arm/cpu.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index a00c86f..1b03450 100644 --- a/target-arm/cpu.h +++ b/target-arm

[Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-03 Thread Sergey Fedorov
From: Svetlana Fedoseeva Define CPU monitor mode. Adjust core registers banking. Adjust CPU VM state info. Provide CPU mode name for monitor mode. Signed-off-by: Svetlana Fedoseeva Signed-off-by: Sergey Fedorov --- target-arm/cpu.h |7 --- target-arm/helper.c|3 +++ targ

[Qemu-devel] [RFC PATCH 09/21] target-arm: adjust SCR CP15 register access rights

2013-12-03 Thread Sergey Fedorov
SCR register is accessible in PL3 (secure privileged) mode only. Fix SRC access rights since arm_current_pl() can return PL3 now. Signed-off-by: Sergey Fedorov --- target-arm/helper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c

[Qemu-devel] [RFC PATCH 17/21] target-arm: use c13_context field for CONTEXTIDR

2013-12-03 Thread Sergey Fedorov
Use c13_context field instead of c13_fcse for CONTEXTIDR register definition. Signed-off-by: Sergey Fedorov --- target-arm/helper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 9442e08..e1e9762 100644 --- a/target-arm/help

[Qemu-devel] [RFC PATCH 14/21] target-arm: split TLB for secure state

2013-12-03 Thread Sergey Fedorov
This patch is based on idea found in patch at git://github.com/jowinter/qemu-trustzone.git a9ad01767c4b25e14700b5682a412f4fd8146ee8 by Johannes Winter . Each secure state has its own MMU state. So provide a separate TLB for each secure state to avoid flushing the whole TLB on each secure state cha

[Qemu-devel] [RFC PATCH 11/21] target-arm: implement CPACR register logic

2013-12-03 Thread Sergey Fedorov
CPACR register allows to control access rights to coprocessor 0-13 interfaces. Bits corresponding to unimplemented coprocessors should be RAZ/WI. QEMU implement only VFP coprocessor on ARMv6+ targets. So only cp10 & cp11 bits is writable. Signed-off-by: Sergey Fedorov --- target-arm/helper.c

[Qemu-devel] [RFC PATCH 12/21] target-arm: add NSACR support

2013-12-03 Thread Sergey Fedorov
NSACR allows to control non-secure access to coprocessor interfaces 0-13 and CPACR bits. Signed-off-by: Sergey Fedorov --- target-arm/cpu.h |1 + target-arm/helper.c| 21 + target-arm/translate.c |3 +++ 3 files changed, 25 insertions(+) diff --git a/targ

[Qemu-devel] [RFC PATCH 18/21] target-arm: switch banked CP registers

2013-12-03 Thread Sergey Fedorov
Banked coprocessor registers are switched on two cases: 1) Entering or leaving CPU monitor mode with SCR.NS bit set; 2) Setting SCR.NS bit not from CPU monitor mode Coprocessor register banking is done similar to CPU core register banking. Some of SCTRL bits are common for secure and non-secure st

[Qemu-devel] [RFC PATCH 15/21] target-arm: add banked coprocessor register type

2013-12-03 Thread Sergey Fedorov
Banked CP registers are defined with BANKED_CP_REG macro which defines an active register state field followed by an adjacent banked register state array field. An active CP register state is accessed as usual through an active state field. Banked CP register state is save in banked register state

[Qemu-devel] [RFC PATCH 06/21] target-arm: add arm_is_secure() helper

2013-12-03 Thread Sergey Fedorov
arm_is_secure() helper allows to determine CPU security state. Signed-off-by: Sergey Fedorov --- target-arm/cpu.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 94d8bd1..a00c86f 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@

[Qemu-devel] [RFC PATCH 13/21] target-arm: add SDER definition

2013-12-03 Thread Sergey Fedorov
Signed-off-by: Sergey Fedorov --- target-arm/cpu.h|1 + target-arm/helper.c |3 +++ 2 files changed, 4 insertions(+) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 5aeb630..ffc1b21 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -150,6 +150,7 @@ typedef struct CPUARM

[Qemu-devel] [RFC PATCH 02/21] target-arm: move SCR & VBAR into TrustZone register list

2013-12-03 Thread Sergey Fedorov
Define a new ARM CP register info list for TrustZone Security Extension feature. Register that list only for ARM cores with TrustZone support. SCR and VBAR are security extension registers. So move them into TrustZone feature register list. Signed-off-by: Sergey Fedorov --- target-arm/helper.c |

[Qemu-devel] [RFC PATCH 21/21] target-arm: implement IRQ/FIQ routing to Monitor mode

2013-12-03 Thread Sergey Fedorov
SCR.{IRQ/FIQ} bits allows to route IRQ/FIQ exceptions to monitor CPU mode. When taking IRQ exception to monitor mode FIQ exception is additionally masked. Signed-off-by: Sergey Fedorov --- target-arm/helper.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/target-arm/helper.c b/tar

[Qemu-devel] [RFC PATCH 07/21] target-arm: reject switching to monitor mode from non-secure state

2013-12-03 Thread Sergey Fedorov
Signed-off-by: Sergey Fedorov --- target-arm/helper.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index d4407cf..e406ec9 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2018,12 +2018,13 @@ static int bad_mode_s

[Qemu-devel] [RFC PATCH 19/21] target-arm: add MVBAR support

2013-12-03 Thread Sergey Fedorov
MVBAR register provides an exception vector base address for exceptions taking to CPU monitor mode. Signed-off-by: Sergey Fedorov --- target-arm/cpu.h|1 + target-arm/helper.c | 16 +++- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/target-arm/cpu.h b/targe

Re: [Qemu-devel] [RFC PATCH 11/15] input: mouse: add graphic_rotate support

2013-12-03 Thread Gerd Hoffmann
On Mo, 2013-12-02 at 14:00 -0500, John Baboval wrote: > I'm not sure this is correct. Generally when the display gets rotated, > the input device coordinates do not, and the in-guest code handles the math. This just mimics what kbd_mouse_event() does today. I guess there is a reason this code wa

[Qemu-devel] [RFC PATCH 20/21] target-arm: implement SMC instruction

2013-12-03 Thread Sergey Fedorov
SMC instruction is implemented similar to SVC instruction. When executing SMC instruction from monitor CPU mode SCR.NS bit is reset. Signed-off-by: Sergey Fedorov --- target-arm/cpu.h |1 + target-arm/helper.c| 11 +++ target-arm/translate.c | 37 +++

Re: [Qemu-devel] [PATCH v5 1/6] qemu-iotests: Add "-c " option

2013-12-03 Thread Wenchao Xia
Reviewed-by: Wenchao Xia

[Qemu-devel] [RFC PATCH 16/21] target-arm: convert appropriate coprocessor registers to banked type

2013-12-03 Thread Sergey Fedorov
Define appropriate coprocessor registers with banked type. The register state fields are defined with BANKED_CP_REG() macro. Banked coprocessor registers with a special behaviour is adjusted to correctly use its active or banked non-secure state. Signed-off-by: Sergey Fedorov --- target-arm/cpu

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Markus Armbruster
Alexey Kardashevskiy writes: > On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: >> Hi! >> >> btw there is a problem with this patch - it does not compile for >> "linux-user" as there is no current-machine global variable defined in vl.c >> which is not compiled for linux-user. >> >> How to s

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-03 Thread Markus Armbruster
Alexey Kardashevskiy writes: [...] >And I cannot find any machine > which would not define max_cpus, have I missed any? If a machine lacks an explicit initializer for max_cpus, it'll remain zero, which its users will interpret as 1.

[Qemu-devel] [RFC PATCH 01/21] target-arm: add TrustZone CPU feature

2013-12-03 Thread Sergey Fedorov
From: Svetlana Fedoseeva Define TrustZone CPU feature. Set that feature for relevant CPUs. Signed-off-by: Svetlana Fedoseeva Signed-off-by: Sergey Fedorov --- target-arm/cpu.c |4 target-arm/cpu.h |1 + 2 files changed, 5 insertions(+) diff --git a/target-arm/cpu.c b/target-arm/

Re: [Qemu-devel] [PATCH v2] vmdk: Fix creating big description file

2013-12-03 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 10:41:05AM +0800, Fam Zheng wrote: > The buffer for description file was 4096 which only covers a few > hundred of extents. This changes the buffer to dynamic allocated with > g_strdup_printf in order to support bigger cases. > > Signed-off-by: Fam Zheng > > --- > v2: Use

[Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/cubieboard.c | 33 + 2 files changed, 34 insertions(+), 1 deletions(-) create mode 100644 hw/arm/cubieboard.c diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs index b9e5983..8be8d8e 1006

[Qemu-devel] [PATCH 0/5] add allwinner A10 SoC support

2013-12-03 Thread liguang
add support for allwinner A10 SoC with a cortex-a8 processor. and will add more devices later. v2: split timer and interrupt controller emulation into their corresponding files. v3: 1. change loader_start address 2. add 64-bit counter 3. fixup fail to clear interrup status issue

[Qemu-devel] [PATCH 1/5] vmstate: add VMSTATE_PTIMER_ARRAY

2013-12-03 Thread liguang
Signed-off-by: liguang --- include/migration/vmstate.h |4 savevm.c| 31 +++ 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 9d09e60..977cf52 100644 --- a/inc

[Qemu-devel] [PATCH 2/5] hw/timer: add allwinner a10 timer

2013-12-03 Thread liguang
Signed-off-by: liguang --- default-configs/arm-softmmu.mak |2 + hw/timer/Makefile.objs |2 + hw/timer/allwinner-a10_pit.c | 253 ++ include/hw/timer/allwinner-a10_pit.h | 57 4 files changed, 314 insertions(+), 0 dele

[Qemu-devel] [PATCH 4/5] hw/arm: add allwinner a10 SoC support

2013-12-03 Thread liguang
Signed-off-by: liguang --- hw/arm/Makefile.objs |2 +- hw/arm/allwinner-a10.c | 39 +++ include/hw/arm/allwinner-a10.h | 27 +++ 3 files changed, 67 insertions(+), 1 deletions(-) create mode 100644 hw/arm/allwi

[Qemu-devel] [PATCH 3/5] hw/intc: add allwinner A10 interrupt controller

2013-12-03 Thread liguang
Signed-off-by: liguang --- hw/intc/Makefile.objs |1 + hw/intc/allwinner-a10_pic.c | 218 +++ include/hw/intc/allwinner-a10_pic.h | 40 +++ 3 files changed, 259 insertions(+), 0 deletions(-) create mode 100644 hw/intc/allwinner-a10

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Stefan Hajnoczi
On Tue, Dec 03, 2013 at 02:05:32PM +0800, Wenchao Xia wrote: > This patch override only when default is specified, I am +1 with it. > I think we had discuss before, just want a double check, stefan, do you > agree with this? Yes, I'm happy with this. I just want to avoid test cases with custom co

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Kevin Wolf
Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: > On 2013年12月03日 14:05, Wenchao Xia wrote: > > > > >Why forbid mode = writeback? > > > > These test cases used to run with only possibly "writethrough", or "none". > And they don't work with writeback, at least in my case. So I didn't add >

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Alexey Kardashevskiy
On 12/03/2013 08:11 PM, Markus Armbruster wrote: > Alexey Kardashevskiy writes: > >> On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: >>> Hi! >>> >>> btw there is a problem with this patch - it does not compile for >>> "linux-user" as there is no current-machine global variable defined in vl.c

Re: [Qemu-devel] [RFC PATCH v1 2/5] hw: Remove assert_no_error usages

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite writes: > Replace assert_no_error() usages with the error_abort system. > &error_abort is passed into API calls to signal to the Error sub-system > that any errors are fatal. Removes need for caller assertions. > > Signed-off-by: Peter Crosthwaite [...] > diff --git a/hw/core/q

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 25/11/2013 08:27, Alexey Kardashevskiy ha scritto: > QEMU supports firmware names for all devices in the QEMU tree but > sometime the exact format differs from what sPAPR platform uses. > > This introduces a callback to let a machine fix device tree path names. > > Signed-off-by: Alexey Kardas

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite writes: > This is a boiler-plate _nofail variant of qemu_opts_create. Remove and > use error_abort in call sites. > > A null argument needs to be added for the id field in affected callsites > due to inconsistency between the normal and no_fail variants. Two arguments, actually

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite writes: > Following our discussion RE self asserting API calls, here is a spin of > my proposal. This series obsoletes the need for _nofail variants for > Error ** accepting APIs. Is also greately reduces the verbosity of calls > sites that are currently asserting against errors

[Qemu-devel] [Bug 1256826] Re: INT instruction bug in WindowsXP

2013-12-03 Thread Jackend
** Description changed: This bug is in -no-kvm mode. In windowsXP at IDT entry 2&8 is Task gate when application use INT 2 or INT 8 it will cause blue screen in XP. - I found it should cause #GP not generate hw interrupt. + I found it should cause #GP but not generate hw interrupt.

Re: [Qemu-devel] [PATCH v4 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-12-03 Thread Kevin Wolf
Am 26.11.2013 um 02:43 hat Fam Zheng geschrieben: > This series adds cache mode option in the iotests framework. Test cases are > updated to make use of cache mode and mask supported modes. > > v4: Address Stefan's comments: > Add _default_cache_mode. > Split last two cases in 048 to 074.

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 10:32, Alexey Kardashevskiy ha scritto: >> > Absolutely not. It's merely not portable to machines with object file >> > formats and linkers stuck in the 80s. However, we routinely twist >> > ourselves into knots for portability (observation, not endorsement), and >> > at least one p

Re: [Qemu-devel] [RFC PATCH v1 2/5] hw: Remove assert_no_error usages

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:35 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> Replace assert_no_error() usages with the error_abort system. >> &error_abort is passed into API calls to signal to the Error sub-system >> that any errors are fatal. Removes need for caller assertions. >> >

Re: [Qemu-devel] [PATCH] arm: Raspberry Pi support

2013-12-03 Thread Jan Petrouš
Sorry guys for html, I didn't know that my company's mail has such default formatting :( I was on bussiness trip for few days so replaying only now. And as Greg said, it looks like we have another progress on raspi machine so I will check that and return back soon, hopefully ;) /Jan

[Qemu-devel] [BUG] ahci -device ide-hd|ide-cd select a bus already in use

2013-12-03 Thread Fabio Fantoni
I started to test/implement q35 cipset on xen hvm domUs. I found that ide disks and cdrom don't works with q35 using old qemu parameters without -device, this is not a blocking problem. I tried with new qemu parameters and ahci and the disk works. When I tried to add more that one ahci disk/cdro

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> This is a boiler-plate _nofail variant of qemu_opts_create. Remove and >> use error_abort in call sites. >> >> A null argument needs to be added for the id field in affected callsites >> due to inconsistency

Re: [Qemu-devel] [PATCH v4 3/6] qemu-iotests: Add _default_cache_mode and _supported_cache_modes

2013-12-03 Thread Fam Zheng
On 2013年12月03日 17:28, Kevin Wolf wrote: > Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: >> On 2013年12月03日 14:05, Wenchao Xia wrote: >> >>> >>> Why forbid mode = writeback? >>> >> >> These test cases used to run with only possibly "writethrough", or "none". >> And they don't work with writeb

Re: [Qemu-devel] [BUG] ahci -device ide-hd|ide-cd select a bus already in use

2013-12-03 Thread Markus Armbruster
Fabio Fantoni writes: > I started to test/implement q35 cipset on xen hvm domUs. > I found that ide disks and cdrom don't works with q35 using old qemu > parameters without -device, this is not a blocking problem. > I tried with new qemu parameters and ahci and the disk works. > When I tried to a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-03 Thread Igor Mammedov
On Mon, 02 Dec 2013 23:09:55 +0100 Andreas Färber wrote: > Am 02.12.2013 18:06, schrieb Michael Tokarev: > > 25.11.2013 07:39, Alexey Kardashevskiy wrote: > >> Since modern POWER7/POWER8 chips can have more that 256 CPU threads > >> (>2000 actually), remove this check from smp_parse. > >> > >> Th

Re: [Qemu-devel] [RFC PATCH v1 4/5] qemu-option: Remove qemu_opts_create_nofail

2013-12-03 Thread Markus Armbruster
Peter Crosthwaite writes: > On Tue, Dec 3, 2013 at 7:42 PM, Markus Armbruster wrote: >> Peter Crosthwaite writes: [...] >>> @@ -3376,8 +3377,9 @@ int main(int argc, char **argv, char **envp) >>> } >>> >>> qemu_opt_set_bool(fsdev, "readonly", >>> -

Re: [Qemu-devel] [BUG] ahci -device ide-hd|ide-cd select a bus already in use

2013-12-03 Thread Fabio Fantoni
Il 03/12/2013 11:32, Markus Armbruster ha scritto: Fabio Fantoni writes: I started to test/implement q35 cipset on xen hvm domUs. I found that ide disks and cdrom don't works with q35 using old qemu parameters without -device, this is not a blocking problem. I tried with new qemu parameters an

Re: [Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert

2013-12-03 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 12:27:10PM +0800, Wenchao Xia wrote: > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx > index da1d965..9a8153b 100644 > --- a/qemu-img-cmds.hx > +++ b/qemu-img-cmds.hx > @@ -34,7 +34,7 @@ STEXI > ETEXI > > DEF("convert", img_convert, > -"convert [-c] [-p] [-q] [-n]

Re: [Qemu-devel] [PATCH v4] cpu: add suboptions support

2013-12-03 Thread Igor Mammedov
On Tue, 3 Dec 2013 14:42:48 +1100 Alexey Kardashevskiy wrote: > This adds suboptions support for -cpu. This keeps @cpu_model in order not > to break the existing architectures/machines. > > Cc: Andreas Färber > Signed-off-by: Alexey Kardashevskiy > --- > Changes: > v4: > * moved QemuOpts logi

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Lei Li
On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: This patch adds send_pipefd() to pass the pipe file descriptor to destination process. Signed-off-by: Lei Li --- migration-local.c | 46 ++

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Daniel P. Berrange
On Tue, Dec 03, 2013 at 07:19:40PM +0800, Lei Li wrote: > On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: > >On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: > >>This patch adds send_pipefd() to pass the pipe file descriptor > >>to destination process. > >> > >>Signed-off-by: Lei Li > >>-

Re: [Qemu-devel] [PATCH 2/5] hw/timer: add allwinner a10 timer

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: > Signed-off-by: liguang > --- > default-configs/arm-softmmu.mak |2 + > hw/timer/Makefile.objs |2 + > hw/timer/allwinner-a10_pit.c | 253 > ++ Mix of _ and - in filename is ugly.

Re: [Qemu-devel] [PATCH 4/5] hw/arm: add allwinner a10 SoC support

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: > Signed-off-by: liguang > --- > hw/arm/Makefile.objs |2 +- > hw/arm/allwinner-a10.c | 39 +++ > include/hw/arm/allwinner-a10.h | 27 +++ > 3 files changed, 67 in

Re: [Qemu-devel] [PATCH 4/5] hw/arm: add allwinner a10 SoC support

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: > Signed-off-by: liguang > --- > hw/arm/Makefile.objs |2 +- > hw/arm/allwinner-a10.c | 39 +++ > include/hw/arm/allwinner-a10.h | 27 +++ > 3 files changed, 67 in

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Igor Mammedov
On Tue, 03 Dec 2013 10:44:57 +0100 Markus Armbruster wrote: > Peter Crosthwaite writes: > > > Following our discussion RE self asserting API calls, here is a spin of > > my proposal. This series obsoletes the need for _nofail variants for > > Error ** accepting APIs. Is also greately reduces th

Re: [Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 12:19, Lei Li ha scritto: > On 12/02/2013 05:33 PM, Daniel P. Berrange wrote: >> On Mon, Dec 02, 2013 at 05:19:06PM +0800, Lei Li wrote: >>> This patch adds send_pipefd() to pass the pipe file descriptor >>> to destination process. >>> >>> Signed-off-by: Lei Li >>> --- >>> migratio

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Paolo Bonzini
Il 03/12/2013 10:44, Markus Armbruster ha scritto: > > There are some _nofail functions left, but none of them can use > error_abort. > > If anything assigns to error_abort, we're probably screwed. No bright > idea how to prevent that at compile-time. Isn't it always used by address? Paolo

Re: [Qemu-devel] [PATCH 0/17 v5] Localhost migration with side channel for ram

2013-12-03 Thread Paolo Bonzini
Il 02/12/2013 10:19, Lei Li ha scritto: > This patch series tries to introduce a mechanism using side > channel pipe for RAM via SCM_RIGHTS with unix domain socket > protocol migration. > > This side channel is used for the page flipping by vmsplice, > which is the internal mechanism for localhost

Re: [Qemu-devel] [PATCH 5/5] hw/arm: add cubieboard support

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 7:11 PM, liguang wrote: > Signed-off-by: liguang > --- > hw/arm/Makefile.objs |2 +- > hw/arm/cubieboard.c | 33 + > 2 files changed, 34 insertions(+), 1 deletions(-) > create mode 100644 hw/arm/cubieboard.c > > diff --git a/hw/arm/M

[Qemu-devel] [PATCH] vl: add missing transition debug->finish_migrate

2013-12-03 Thread Paolo Bonzini
This fixes an abort if you invoke the "migrate" command while the guest is being debugged. Cc: qemu-sta...@nongnu.org Cc: lcapitul...@redhat.com Signed-off-by: Paolo Bonzini --- vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/vl.c b/vl.c index 8d5d874..31e3411 100644 --- a/vl.c +++ b/vl

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 9:57 PM, Paolo Bonzini wrote: > Il 03/12/2013 10:44, Markus Armbruster ha scritto: >> >> There are some _nofail functions left, but none of them can use >> error_abort. >> >> If anything assigns to error_abort, we're probably screwed. No bright >> idea how to prevent that a

Re: [Qemu-devel] [RFC PATCH 03/21] target-arm: adjust TTBCR for TrustZone feature

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: > TTBCR has additional fields PD0 and PD1 when using Short-descriptor > translation table format on a CPU with TrustZone feature support. > > Signed-off-by: Sergey Fedorov > --- > target-arm/helper.c |4 +++- > 1 file changed, 3 insertion

Re: [Qemu-devel] [RFC PATCH 04/21] target-arm: preserve RAO/WI bits of ARMv7 SCTLR

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: > From: Svetlana Fedoseeva > > Signed-off-by: Svetlana Fedoseeva > Signed-off-by: Sergey Fedorov > --- > target-arm/helper.c |4 > 1 file changed, 4 insertions(+) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 6

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: > From: Svetlana Fedoseeva > > Define CPU monitor mode. Adjust core registers banking. Adjust CPU VM > state info. Provide CPU mode name for monitor mode. > > Signed-off-by: Svetlana Fedoseeva > Signed-off-by: Sergey Fedorov > --- > target-

Re: [Qemu-devel] [RFC PATCH 08/21] target-arm: adjust arm_current_pl() for TrustZone

2013-12-03 Thread Peter Crosthwaite
On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: > Make arm_current_pl() to return PL3 in secure privileged mode. > > Signed-off-by: Sergey Fedorov > --- > target-arm/cpu.h |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.h

Re: [Qemu-devel] [RFC PATCH 05/21] target-arm: add CPU Monitor mode

2013-12-03 Thread Peter Maydell
On 3 December 2013 12:20, Peter Crosthwaite wrote: > On Tue, Dec 3, 2013 at 6:48 PM, Sergey Fedorov wrote: >> From: Svetlana Fedoseeva >> >> Define CPU monitor mode. Adjust core registers banking. Adjust CPU VM >> state info. Provide CPU mode name for monitor mode. >> >> Signed-off-by: Svetlana

[Qemu-devel] [PULL 01/01] seccomp: add kill() to the syscall whitelist

2013-12-03 Thread Eduardo Otubo
From: Paul Moore The kill() syscall is triggered with the following command: # qemu -sandbox on -monitor stdio \ -device intel-hda -device hda-duplex -vnc :0 The resulting syslog/audit message: # ausearch -m SECCOMP time->Wed Nov 20 09:52:08 2013 type=SECCOMP msg=audit(138491

[Qemu-devel] [PULL 00/01] seccomp: add missing system call to whitelist

2013-12-03 Thread Eduardo Otubo
Anthony, The following changes since commit 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e: Open 2.0 development tree (2013-11-27 14:02:45 -0800) are available in the git repository at: git://github.com/otubo/qemu.git seccomp Paul Moore (1): seccomp: add kill() to the syscall whitelist qe

Re: [Qemu-devel] [RFC PATCH v1 0/5] Add error_abort and associated cleanups

2013-12-03 Thread Eric Blake
On 12/03/2013 02:44 AM, Markus Armbruster wrote: > Peter Crosthwaite writes: > >> Following our discussion RE self asserting API calls, here is a spin of >> my proposal. This series obsoletes the need for _nofail variants for >> Error ** accepting APIs. Is also greately reduces the verbosity of c

Re: [Qemu-devel] [PATCH arm-devs v3 1/9] qom/object: Make uintXX added properties writable

2013-12-03 Thread Andreas Färber
Am 03.12.2013 07:59, schrieb Peter Crosthwaite: > Currently the uintXX property adders make a read only property. This > is not useful for devices that want to create board (or container) > configurable dynamic device properties. Fix by trivially adding property > setters to object_property_add_uin

Re: [Qemu-devel] [Bug 1257099] [NEW] QEMU fails to build on CentOS 5.10 with relocation R_X86_64_PC32 error

2013-12-03 Thread Stefano Stabellini
CC'ing Paolo and xen-devel. The original thread is here: http://marc.info/?l=xen-devel&m=135718999710640 On Mon, 2 Dec 2013, Don Slutz wrote: > Public bug reported: > > lt LINK libcacard.la > /usr/bin/ld: libcacard/.libs/vcard.o: relocation R_X86_64_PC32 against > `vcard_buffer_response_delet

[Qemu-devel] [RFC V3 0/7] Giving names to BlockDriverState graph nodes

2013-12-03 Thread Benoît Canet
This partial series start to add some node-name manipulation from QMP. In particular it allow to take snapshots of quorum files. I post it in a partial state to spread the reviewing load. Best regards Benoît Benoît Canet (7): block: Add bs->node_name to hold the name of a bs node of the bs

[Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option.

2013-12-03 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 42 +- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index 4f6b36a..3a0cb30 100644 --- a/block.c +++ b/block.c @@ -873,6 +873,7 @@ int bdrv_file_open(BlockDriverState **pbs, const

Re: [Qemu-devel] [PATCH arm-devs v3 1/9] qom/object: Make uintXX added properties writable

2013-12-03 Thread Andreas Färber
Am 03.12.2013 07:59, schrieb Peter Crosthwaite: > Currently the uintXX property adders make a read only property. This > is not useful for devices that want to create board (or container) > configurable dynamic device properties. Fix by trivially adding property > setters to object_property_add_uin

[Qemu-devel] [RFC V3 6/7] block: Create authorizations mechanism for external snapshots.

2013-12-03 Thread Benoît Canet
--- block.c | 64 +-- block/blkverify.c | 2 +- include/block/block.h | 16 +--- include/block/block_int.h | 9 --- 4 files changed, 75 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index 8016f

[Qemu-devel] [RFC V3 5/7] qmp: Allow block_resize to manipulate bs graph nodes.

2013-12-03 Thread Benoît Canet
Signed-off-by: Benoit Canet --- blockdev.c | 13 + hmp.c| 2 +- qapi-schema.json | 10 -- qmp-commands.hx | 3 ++- 4 files changed, 20 insertions(+), 8 deletions(-) diff --git a/blockdev.c b/blockdev.c index aab370f..e314d62 100644 --- a/blockdev.c +++ b/

[Qemu-devel] [RFC V3 7/7] qmp: Allow to take external snapshots on bs graphs node.

2013-12-03 Thread Benoît Canet
Signed-off-by: Benoit Canet --- blockdev.c | 49 + hmp.c| 4 +++- qapi-schema.json | 13 ++--- qmp-commands.hx | 11 ++- 4 files changed, 64 insertions(+), 13 deletions(-) diff --git a/blockdev.c b/blockdev.c ind

[Qemu-devel] [RFC V3 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph.

2013-12-03 Thread Benoît Canet
Add the minimum of code to prepare the followings patches. Signed-off-by: Benoit Canet --- block.c | 72 ++- block/blkverify.c | 2 +- block/iscsi.c | 2 +- block/vmdk.c | 2 +- block/vvfat.c

[Qemu-devel] [RFC V3 4/7] qmp: Allow block_passwd to manipulate bs graph nodes.

2013-12-03 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block.c | 33 + blockdev.c| 13 + hmp.c | 2 +- include/block/block.h | 3 +++ qapi-schema.json | 9 +++-- qmp-commands.hx | 3 ++- 6 files changed, 55 insertio

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

2013-12-03 Thread Andreas Färber
Am 03.12.2013 00:03, schrieb Alexey Kardashevskiy: > On 12/03/2013 09:09 AM, Andreas Färber wrote: >> Am 02.12.2013 18:06, schrieb Michael Tokarev: >>> 25.11.2013 07:39, Alexey Kardashevskiy wrote: Since modern POWER7/POWER8 chips can have more that 256 CPU threads (>2000 actually), remov

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 04:52, schrieb Alexey Kardashevskiy: > On 11/26/2013 03:55 PM, Alexey Kardashevskiy wrote: >> Hi! >> >> btw there is a problem with this patch - it does not compile for >> "linux-user" as there is no current-machine global variable defined in vl.c >> which is not compiled for linux-us

[Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph.

2013-12-03 Thread Benoît Canet
--- blockdev.c | 8 qapi-schema.json | 32 2 files changed, 40 insertions(+) diff --git a/blockdev.c b/blockdev.c index a474bb5..824e718 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1940,6 +1940,14 @@ void qmp_drive_backup(const char *device, const

Re: [Qemu-devel] [PATCH 2/5] machine: introduce get_fw_dev_path() callback

2013-12-03 Thread Andreas Färber
Am 03.12.2013 10:37, schrieb Paolo Bonzini: > Il 25/11/2013 08:27, Alexey Kardashevskiy ha scritto: >> QEMU supports firmware names for all devices in the QEMU tree but >> sometime the exact format differs from what sPAPR platform uses. >> >> This introduces a callback to let a machine fix device t

Re: [Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-12-03 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 12:27:09PM +0800, Wenchao Xia wrote: > +nbd_snapshot_port=10850 > +nbd_snapshot_img="nbd:127.0.0.1:$nbd_snapshot_port" > + > +_export_nbd_snapshot() > +{ > +$QEMU_NBD -v -t -b 127.0.0.1 -p $nbd_snapshot_port "$TEST_IMG" -l $1 & Please use a UNIX domain socket so that mu

  1   2   3   4   >