Re: [Qemu-devel] [RFC qom-cpu v4 09/10] piix4: implement function cpu_status_write() for vcpu ejection

2013-11-22 Thread Vasilis Liaskovitis
Hi, On Wed, Oct 09, 2013 at 05:43:17PM +0800, Chen Fan wrote: > When OS eject a vcpu (like: echo 1 > /sys/bus/acpi/devices/LNXCPUXX/eject), > it will call acpi EJ0 method, the firmware will write the new cpumap, QEMU > will know which vcpu need to be ejected. I think that the _EJ0 callback (CPEJ

Re: [Qemu-devel] [PATCH 3/6] qemu-option: Add qemu_config_parse_qdict()

2013-11-22 Thread Fam Zheng
On 2013年11月22日 03:05, Max Reitz wrote: This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple

Re: [Qemu-devel] Is there any new progress or plans about "ram live snapshot feature"?

2013-11-22 Thread Pavel Hrdina
On 22.11.2013 02:43, Wenchao Xia wrote: 于 2013/11/21 19:02, Zhanghailiang 写道: Hi, Now qemu ram live snapshot feature has some problems, it is based on ‘ram live migration’. The time of snapshot depends on completion time of migration, which is not measurable. Also It may can’t achieve migrate

Re: [Qemu-devel] console muti-head some more design input

2013-11-22 Thread Gerd Hoffmann
Hi, > > With absolute pointer events the whole thing becomes a bit more tricky > > as we have to map input from multiple displays (QemuConsoles) to a > > single absolute pointing device (usb tablet). This is what Dave wants > > the screen layout for. I still think the input layer is the place

Re: [Qemu-devel] console muti-head some more design input

2013-11-22 Thread Gerd Hoffmann
Hi, > > While thinking about this: A completely different approach to tackle > > this would be to implement touchscreen emulation. So we don't have a > > single usb-tablet, but multiple (one per display) touch input devices. > > Then we can simply route absolute input events from this display

Re: [Qemu-devel] [PATCH] qdev-properties-system.c: Allow vlan or netdev for -device, not both

2013-11-22 Thread Stefan Hajnoczi
On Thu, Nov 07, 2013 at 09:13:09PM -0500, Vlad Yasevich wrote: > It is currently possible to specify things like: > -device e1000,netdev=foo,vlan=1 > With this usage, whichever argument was specified last (vlan or netdev) > overwrites what was previousely set and results in a non-working > co

Re: [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-11-22 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 03:16:23PM +0100, Kevin Wolf wrote: > Am 21.11.2013 um 13:43 hat Stefan Hajnoczi geschrieben: > > On Wed, Nov 20, 2013 at 03:44:11PM +0800, Fam Zheng wrote: > > > This series adds cache mode option in the iotests framework. Test cases > > > are > > > updated to make use of

Re: [Qemu-devel] os x boot broken by commit 11948748495841bd54721b250d68c7b3cb0475ef

2013-11-22 Thread Paolo Bonzini
Il 21/11/2013 23:02, Gabriel L. Somlo ha scritto: > On Thu, Nov 21, 2013 at 07:14:27PM +0100, Paolo Bonzini wrote: >> > Can you remind us about your DSDT modifications? It should be possible >> > to patch the HPET and applesmc bits appropriately from QEMU (or to move >> > them from the DSDT to an

Re: [Qemu-devel] [edk2] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Paolo Bonzini
Il 21/11/2013 23:21, Laszlo Ersek ha scritto: > Split the variable store off to a separate file when SPLIT_VARSTORE is > defined. > > Even in this case, the preexistent PCDs' values don't change. Qemu must > take care of contiguously mapping NVVARSTORE.fd + OVMF.fd so that when > concatenated they

[Qemu-devel] [PATCH for-1.7] spapr: tie spapr-nvram to -pflash

2013-11-22 Thread Paolo Bonzini
spapr-nvram's drive property is currently connected to a non-existent "-machine nvram=" option. Instead, tie it to -pflash like other non-volatile RAM devices. This provides the following possibilities for adding a backend for the sPAPR non-volatile RAM: * -pflash filename * -drive if=pflash,fi

Re: [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-11-22 Thread Kevin Wolf
Am 22.11.2013 um 09:57 hat Stefan Hajnoczi geschrieben: > On Thu, Nov 21, 2013 at 03:16:23PM +0100, Kevin Wolf wrote: > > Am 21.11.2013 um 13:43 hat Stefan Hajnoczi geschrieben: > > > On Wed, Nov 20, 2013 at 03:44:11PM +0800, Fam Zheng wrote: > > > > This series adds cache mode option in the iotest

Re: [Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

2013-11-22 Thread Jason Wang
On 11/22/2013 04:04 AM, Vlad Yasevich wrote: > e1000 provides a E1000_RAH_AV bit on every complete write > to the Receive Address Register. We can use this bit > 2 ways: > 1) To trigger HMP notifications. When the bit is set the > mac address is fully set and we can update the HMP. > > 2) W

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Paolo Bonzini
Il 21/11/2013 15:37, Peter Lieven ha scritto: > -max_cpus = qemu_opt_get_number(opts, "maxcpus", 0); > +if (cpus != sockets * cores * threads) { > +fprintf(stderr, "Illegal CPU layout: %d cpus with %d sockets," > +" %d cores per socket and %d

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Stefan Hajnoczi
On Wed, Oct 30, 2013 at 11:04:39AM +0100, Stefan Hajnoczi wrote: > On Wed, Oct 23, 2013 at 12:42:34PM -0200, Eduardo Otubo wrote: > > On 10/22/2013 11:00 AM, Anthony Liguori wrote: > > >On Tue, Oct 22, 2013 at 12:21 PM, Eduardo Otubo > > > wrote: > > >>Inverting the way sandbox handles arguments, m

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > On Thursday, November 21, 2013 04:14:11 PM Paolo Bonzini wrote: > > Il 30/10/2013 11:04, Stefan Hajnoczi ha scritto: > > > On Wed, Oct 23, 2013 at 12:42:34PM -0200, Eduardo Otubo wrote: > > >> On 10/22/2013 11:00 AM, Anthony Liguori wrot

Re: [Qemu-devel] [RFC] Architecture to connect a userspace ethernet switch to QEMU guests via Virtio

2013-11-22 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 12:01:20PM +0100, Antonios Motakis wrote: > On Tue, Nov 19, 2013 at 5:11 PM, Stefan Hajnoczi wrote: > > On Tue, Nov 19, 2013 at 11:17:40AM +0100, Antonios Motakis wrote: > >> There have been discussions before on these lists on the topic of > >> connecting a QEMU guest runn

Re: [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error)

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 07:56:12AM +0100, Stefan Weil wrote: > Am 21.11.2013 09:40, schrieb Stefan Hajnoczi: > > Excellent, thanks! The latest buildbot has compiled successfully: > > http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/784 > > > > It's now hitting a make check failur

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 09:44:29PM +0100, Erik Rull wrote: > Hu Tao wrote: > >On Thu, Nov 21, 2013 at 09:06:43AM +0100, Erik Rull wrote: > >>Hi all, > >> > >>when doing a git clone on the latest master, it fails compiling: > >> > >> CCx86_64-softmmu/memory_mapping.o > >> CCx86_64-softmm

Re: [Qemu-devel] [PATCH] net: Update netdev peer on link change

2013-11-22 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 09:05:51PM -0500, Vlad Yasevich wrote: > When a link change occurs on a backend (like tap), we currently do > not propage such change to the nic. As a result, when someone turns > off a link on a tap device, for instance, then a guest doesn't see > that change and continues

[Qemu-devel] [PULL for-1.7 0/1] net patches

2013-11-22 Thread Stefan Hajnoczi
Bug fix for netdev/vlan configuration. The following changes since commit 607bb022f2a44797cbf40e85e84da4134e2f0e01: Update version for 1.7.0-rc1 release (2013-11-21 08:11:47 -0800) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to

[Qemu-devel] [PULL 1/1] qdev-properties-system.c: Allow vlan or netdev for -device, not both

2013-11-22 Thread Stefan Hajnoczi
From: Vlad Yasevich It is currently possible to specify things like: -device e1000,netdev=foo,vlan=1 With this usage, whichever argument was specified last (vlan or netdev) overwrites what was previousely set and results in a non-working configuration. Even worse, when used with multique

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Peter Lieven
On 22.11.2013 11:16, Paolo Bonzini wrote: Il 21/11/2013 15:37, Peter Lieven ha scritto: -max_cpus = qemu_opt_get_number(opts, "maxcpus", 0); +if (cpus != sockets * cores * threads) { +fprintf(stderr, "Illegal CPU layout: %d cpus with %d sockets," +

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Erik Rull
> On November 22, 2013 at 11:56 AM Stefan Hajnoczi wrote: > > > On Thu, Nov 21, 2013 at 09:44:29PM +0100, Erik Rull wrote: > > Hu Tao wrote: > > >On Thu, Nov 21, 2013 at 09:06:43AM +0100, Erik Rull wrote: > > >>Hi all, > > >> > > >>when doing a git clone on the latest master, it fails compiling: >

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Paolo Bonzini
Il 22/11/2013 12:13, Peter Lieven ha scritto: >> I see where you come from, but I think the potential for this patch to >> break some working configuration (for some definition of working) is too >> high. Can you split out the fixes to the "fill in the blanks" logic? > > I can, but the number of

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-22 Thread Lei Li
On 11/21/2013 06:19 PM, Daniel P. Berrange wrote: On Thu, Nov 21, 2013 at 05:11:23PM +0800, Lei Li wrote: This patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel is used for the page flipping b

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-22 Thread Paolo Bonzini
Il 22/11/2013 12:29, Lei Li ha scritto: > During the page flipping migration, ram page of source guest would > be flipped to the destination, that's why the source guest can not > be resumed. AFAICT, the page flipping migration may fail at the > connection stage (including the exchange of pipe fd)

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-22 Thread Daniel P. Berrange
On Fri, Nov 22, 2013 at 07:29:05PM +0800, Lei Li wrote: > On 11/21/2013 06:19 PM, Daniel P. Berrange wrote: > >On Thu, Nov 21, 2013 at 05:11:23PM +0800, Lei Li wrote: > >In discussions about supporting this for libvirt, we were told that > >when this localhost migration fails, you cannot re-start t

Re: [Qemu-devel] [edk2] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Laszlo Ersek
On 11/22/13 10:27, Paolo Bonzini wrote: > Il 21/11/2013 23:21, Laszlo Ersek ha scritto: >> Split the variable store off to a separate file when SPLIT_VARSTORE is >> defined. >> >> Even in this case, the preexistent PCDs' values don't change. Qemu must >> take care of contiguously mapping NVVARSTORE

Re: [Qemu-devel] [edk2] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Paolo Bonzini
Il 22/11/2013 12:46, Laszlo Ersek ha scritto: >> Also, I see a command line compatibility problem, especially if one >> > wants OVMF.fd to become the default firmware. > I don't understand. If you use the un-split build, you use the original > command line (single -pflash or -drive if=pflash option

Re: [Qemu-devel] [edk2] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-22 Thread Laszlo Ersek
On 11/22/13 12:56, Paolo Bonzini wrote: > Il 22/11/2013 12:46, Laszlo Ersek ha scritto: >>> Also, I see a command line compatibility problem, especially if one wants OVMF.fd to become the default firmware. >> I don't understand. If you use the un-split build, you use the original >> command li

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-22 Thread Markus Armbruster
Laszlo Ersek writes: > This patch allows the user to usefully specify > > -drive file=img_1,if=pflash,format=raw,readonly \ > -drive file=img_2,if=pflash,format=raw > > on the command line. The flash images will be mapped under 4G in their > reverse unit order -- that is, with their base addr

[Qemu-devel] [PATCH V6 2/6] qemu-nbd: support internal snapshot export

2013-11-22 Thread Wenchao Xia
Now it is possible to directly export an internal snapshot, which can be used to probe the snapshot's contents without qemu-img convert. Signed-off-by: Wenchao Xia --- block/snapshot.c | 18 ++ include/block/snapshot.h |8 qemu-nbd.c | 46 ++

[Qemu-devel] [PATCH V6 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

2013-11-22 Thread Wenchao Xia
This case can't run when IMGPROTO=nbd, since it needs to create some internal snapshot which would fail for EOF write request, even when TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto to file. _require_command() is changed to tip what util is missing, instead of printing

[Qemu-devel] [PATCH V6 1/6] snapshot: distinguish id and name in load_tmp

2013-11-22 Thread Wenchao Xia
Since later this function will be used so improve it. The only caller of it now is qemu-img, and it is not impacted by introduce function bdrv_snapshot_load_tmp_by_id_or_name() that call bdrv_snapshot_load_tmp() twice to keep old search logic. bdrv_snapshot_load_tmp_by_id_or_name() return int to le

[Qemu-devel] [PATCH V6 0/6] export internal snapshot by qemu-nbd

2013-11-22 Thread Wenchao Xia
This series allow user to read internal snapshot's contents without qemu-img convert. V2: Address Stefan's comments: 02: add 'fall through' comments in the case statement. 03: add doc about the difference of internal snapshot and backing chain snapshot, which is used in previous '--snapshot'

[Qemu-devel] [PATCH V6 6/6] qemu-nbd: add doc for option -f

2013-11-22 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- qemu-nbd.c|1 + qemu-nbd.texi |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index fe6053c..136e8c9 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -79,6 +79,7 @@ static void usage(const char *name) #endif "\n

[Qemu-devel] [PATCH V6 5/6] qemu-iotests: add test for snapshot in qemu-img convert

2013-11-22 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- tests/qemu-iotests/058 | 19 ++- tests/qemu-iotests/058.out | 12 2 files changed, 30 insertions(+), 1 deletions(-) diff --git a/tests/qemu-iotests/058 b/tests/qemu-iotests/058 index 0b48386..19d8a8c 100755 --- a/tests/qemu-iote

[Qemu-devel] [PATCH V6 4/6] qemu-img: add -l for snapshot in convert

2013-11-22 Thread Wenchao Xia
Now qemu-img convert have similar options as qemu-nbd for internal snapshot. Signed-off-by: Wenchao Xia --- qemu-img-cmds.hx |2 +- qemu-img.c | 44 +++- qemu-img.texi| 12 3 files changed, 44 insertions(+), 14 deletions(-)

[Qemu-devel] [PATCH v3 00/19] block & scsi: write_zeroes support through the whole stack

2013-11-22 Thread Paolo Bonzini
This series fixes the implementation of WRITE SAME in the SCSI emulation layer. On top of this, it ensures that zero writes from the guest can be offloaded to the host device or filesystem if that's supported. This is a relatively important part of the thin provisioning feature, and builds on the

[Qemu-devel] [PATCH v3 01/19] block: generalize BlockLimits handling to cover bdrv_aio_discard too

2013-11-22 Thread Paolo Bonzini
bdrv_co_discard is only covering drivers which have a .bdrv_co_discard() implementation, but not those with .bdrv_aio_discard(). Not very nice, and easy to avoid. Suggested-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block.c | 80 +

[Qemu-devel] [PATCH v3 02/19] block: add flags to BlockRequest

2013-11-22 Thread Paolo Bonzini
This lets bdrv_co_do_rw receive flags, so that it can be used for zero writes. Signed-off-by: Paolo Bonzini --- block.c | 17 +++-- include/block/block.h | 1 + 2 files changed, 12 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index 1b3e8b2..0665f35 100

[Qemu-devel] [PATCH v3 04/19] block: add bdrv_aio_write_zeroes

2013-11-22 Thread Paolo Bonzini
This will be used by the SCSI layer. Signed-off-by: Paolo Bonzini --- block.c | 11 +++ include/block/block.h | 3 +++ trace-events | 1 + 3 files changed, 15 insertions(+) diff --git a/block.c b/block.c index cb07e57..f9674d9 100644 --- a/block.c +++ b/block.c

[Qemu-devel] [PATCH v3 09/19] block drivers: expose requirement for write same alignment from formats

2013-11-22 Thread Paolo Bonzini
This will let misaligned but large requests use zero clusters. This is important because the cluster size is not guest visible. Signed-off-by: Paolo Bonzini --- block/qcow2.c | 1 + block/qed.c | 1 + block/vmdk.c | 4 3 files changed, 6 insertions(+) diff --git a/block/qcow2.c b/block

[Qemu-devel] [PATCH v3 15/19] raw-posix: add support for write_zeroes on XFS and block devices

2013-11-22 Thread Paolo Bonzini
The code is similar to the implementation of discard and write_zeroes with UNMAP. However, failure must be propagated up to block.c. The stale page cache problem can be reproduced as follows: # modprobe scsi-debug lbpws=1 lbprz=1 # ./qemu-io /dev/sdXX qemu-io> write -P 0xcc 0 2M

[Qemu-devel] [PATCH v3 03/19] block: add flags argument to bdrv_co_write_zeroes tracepoint

2013-11-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c | 2 +- trace-events | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 0665f35..cb07e57 100644 --- a/block.c +++ b/block.c @@ -2887,7 +2887,7 @@ int coroutine_fn bdrv_co_write_zeroes(BlockDriverState *bs,

[Qemu-devel] [PATCH v3 05/19] block: handle ENOTSUP from discard in generic code

2013-11-22 Thread Paolo Bonzini
Similar to write_zeroes, let the generic code receive a ENOTSUP for discard operations. Since bdrv_discard has advisory semantics, we can just swallow the error. Signed-off-by: Paolo Bonzini --- block.c | 2 +- block/raw-posix.c | 12 ++-- 2 files changed, 7 insertions(+), 7

[Qemu-devel] [PATCH v3 07/19] vpc, vhdx: add get_info

2013-11-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/vhdx.c | 10 ++ block/vpc.c | 14 ++ 2 files changed, 24 insertions(+) diff --git a/block/vhdx.c b/block/vhdx.c index 7d1af96..ed6fa53 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1043,6 +1043,15 @@ static void vhdx_block_translate(

[Qemu-devel] [PATCH v3 18/19] scsi-disk: reject ANCHOR=1 for UNMAP and WRITE SAME commands

2013-11-22 Thread Paolo Bonzini
Since we report ANC_SUP==0 in VPD page B2h, we need to return an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME requests with ANCHOR==1. Inspired by a similar patch to the LIO in-kernel target. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 12 +++- 1 file chang

[Qemu-devel] [PATCH v3 11/19] block/iscsi: updated copyright

2013-11-22 Thread Paolo Bonzini
From: Peter Lieven added myself to reflect recent work on the iscsi block driver. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index b6b62aa..20f4f55 100644 --- a/block/iscsi.c +++

[Qemu-devel] [PATCH v3 12/19] block/iscsi: check WRITE SAME support differently depending on MAY_UNMAP

2013-11-22 Thread Paolo Bonzini
The current check is right for MAY_UNMAP=1. For MAY_UNMAP=0, just try and fall back to regular writes as soon as a WRITE SAME command fails. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/block/iscsi.c b/bl

[Qemu-devel] [PATCH v3 10/19] block/iscsi: remove .bdrv_has_zero_init

2013-11-22 Thread Paolo Bonzini
From: Peter Lieven since commit 3ac21627 the default value changed to 0. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index b7b5238..b6b62aa 100644 --- a/block/iscsi.c +++ b/b

[Qemu-devel] [PATCH v3 13/19] raw-posix: implement write_zeroes with MAY_UNMAP for files

2013-11-22 Thread Paolo Bonzini
Writing zeroes to a file can be done by punching a hole if MAY_UNMAP is set. Note that in this case ENOTSUP is not ignored, but makes the block layer fall back to the generic implementation. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 66

[Qemu-devel] [PATCH v3 14/19] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-22 Thread Paolo Bonzini
See the next commit for the description of the Linux kernel problem that is worked around in raw_open_common. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 37 + 1 file changed, 37 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH v3 19/19] scsi-disk: correctly implement WRITE SAME

2013-11-22 Thread Paolo Bonzini
Fetch the data to be written from the input buffer. If it is all zeroes, we can use the write_zeroes call (possibly with the new MAY_UNMAP flag). Otherwise, do as many write cycles as needed, writing 512k at a time. Strictly speaking, this is still incorrect because a zero cluster should only be

[Qemu-devel] [PATCH v3 06/19] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-22 Thread Paolo Bonzini
Right now, bdrv_co_do_write_zeroes will only try to align the beginning of the request. However, it is simpler for many formats to expect the block layer to separate both the head *and* the tail. This makes sure that the format's bdrv_co_write_zeroes function will be called with aligned sector_nu

[Qemu-devel] [PATCH v3 16/19] qemu-iotests: 033 is fast

2013-11-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/group | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group index b63b18c..303e0f3 100644 --- a/tests/qemu-iotests/group +++ b/tests/qemu-iotests/group @@ -39,7 +39,7 @@ 030 rw a

[Qemu-devel] [PATCH v3 17/19] scsi-disk: catch write protection errors in UNMAP

2013-11-22 Thread Paolo Bonzini
This is the same that is already done for WRITE SAME. Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-disk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 74e6a14..4138268 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -154

Re: [Qemu-devel] Buildbot failure: MinGW (was: qga/vss-win32/requester.h compile error)

2013-11-22 Thread Gerd Hoffmann
Hi, > > 'make check' for MinGW cross builds needs an installation of wine to run > > the resulting exe files. I don't think it is a good idea to run tests for cross builds by default. cheers, Gerd

[Qemu-devel] [PATCH v3 08/19] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-22 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 1 + block/vhdx.c | 3 +++ block/vpc.c | 1 + 5 files changed, 9 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 2fe37ed..1542750 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1892

Re: [Qemu-devel] [PATCH 00/21] RFCv2: add Spice block device

2013-11-22 Thread Marc-André Lureau
Hi there, Even though there is no rush to review this series, it would be nice to get the first ~10 patches. It would make the next rebase easier, and the review smaller. cheers On Mon, Nov 18, 2013 at 1:25 PM, Marc-André Lureau wrote: > Hi, > > The following patch series implement a Spice bloc

Re: [Qemu-devel] [PATCH 3/6] qemu-option: Add qemu_config_parse_qdict()

2013-11-22 Thread Max Reitz
On 22.11.2013 09:08, Fam Zheng wrote: On 2013年11月22日 03:05, Max Reitz wrote: This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 =

[Qemu-devel] [PATCH] vl.c: clean up missing parameters calculation in smp_parse

2013-11-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- vl.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/vl.c b/vl.c index 8d5d874..470a8d1 100644 --- a/vl.c +++ b/vl.c @@ -1385,35 +1385,33 @@ static QemuOptsList qemu_smp_opts = { static void smp_parse(QemuOpts *

Re: [Qemu-devel] [PATCH 21/27] pc: add memory hotplug 440fx machine

2013-11-22 Thread Gerd Hoffmann
On Do, 2013-11-21 at 03:38 +0100, Igor Mammedov wrote: > Add DimmBus for memory hotplug below 4Gb or above 4Gb depending > on initial memory size and hotplug memory size. > > * if ram_size is less than 32-bit PCI hole start, reserve > hotplug memory region as [ram_size,32bit-PCIhole-start) > i

Re: [Qemu-devel] [PATCH RFC 0/3] add direct support of event in qapi schema

2013-11-22 Thread Luiz Capitulino
On Fri, 22 Nov 2013 10:03:44 +0800 Wenchao Xia wrote: > 于 2013/11/13 9:44, Wenchao Xia 写道: > > This series add support for tag/keyword 'event' in qapi-schema. > > The implemention doesn't generate a struture and visit function > > in the background for every event, so it doesn't support nested >

[Qemu-devel] [RESENT PATCH for-1.7] curses: fixup SIGWINCH handler mess

2013-11-22 Thread Gerd Hoffmann
Don't run code in the signal handler, only set a flag. Use sigaction(2) to avoid non-portable signal(2) semantics. Make #ifdefs less messy. Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek --- ui/curses.c | 44 1 file changed, 28 insertions(+),

Re: [Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

2013-11-22 Thread Vlad Yasevich
On 11/22/2013 04:47 AM, Jason Wang wrote: > On 11/22/2013 04:04 AM, Vlad Yasevich wrote: >> e1000 provides a E1000_RAH_AV bit on every complete write >> to the Receive Address Register. We can use this bit >> 2 ways: >> 1) To trigger HMP notifications. When the bit is set the >> mac address

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Paul Moore
On Friday, November 22, 2013 11:34:41 AM Stefan Hajnoczi wrote: > IMO this seccomp approach is doomed since QEMU does not practice > privilege separation. QEMU is monolithic so it's really hard to create > a meaningful sets of system calls. I'm a big fan of decomposing QEMU, but based on previous

Re: [Qemu-devel] [PATCH] vl: verify if combination of cpus, sockets, cores and threads is sane

2013-11-22 Thread Andreas Färber
Am 22.11.2013 12:20, schrieb Paolo Bonzini: > Il 22/11/2013 12:13, Peter Lieven ha scritto: >>> I see where you come from, but I think the potential for this patch to >>> break some working configuration (for some definition of working) is too >>> high. Can you split out the fixes to the "fill in

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Paul Moore
On Friday, November 22, 2013 11:39:31 AM Stefan Hajnoczi wrote: > On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > > I'm always open to suggestions on how to improve the development/debugging > > process, so if you have any ideas please let me know. > > The failure mode is terrible:

[Qemu-devel] [RFC][PATCH] qemu-img: add support for skipping zeroes in input during convert

2013-11-22 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img.c | 52 ++-- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b6b5644..808f8f8 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1121,8 +1121,9 @@ out3: static int

[Qemu-devel] [RFC] hw/net: add DEC Tulip NIC emulation

2013-11-22 Thread Dmitry Smagin
From: Antony Pavlov This patch adds emulation of DEC/Intel Tulip 21143 with some external chips: * Intel LXT971A 10/100 Mbps PHY MII Tranceiver; * Microchip 93LC46B 1K Microwire Compatible Serial EEPROM. Restrictions and TODOs: - Tulip always work in promisc-mode with no packet filtering

[Qemu-devel] [RFC PATCH 4/8] exec: Make memory_region_section_get_iotlb use section AS

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- exec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 05df217..0162eb3 100644 --- a/exec.c +++ b/exec.c @@ -709,7 +709,7 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env,

[Qemu-devel] [RFC PATCH 2/8] exec: Make iotlb_to_region input an AS

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- cputlb.c|2 +- exec.c |4 ++-- include/exec/exec-all.h |2 +- include/exec/softmmu_template.h |5 +++-- 4 files changed, 7 insertions(+), 6 deletions(-) diff

[Qemu-devel] [RFC PATCH 0/8] Steps towards per CPU address-spaces

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Hi, I'm looking at modelling a system where multiple CPUs co-exist with different views of their attached buses/devs. With this RFC series I'm trying to take small steps towards having an address-space per CPU. This is still incomplete but I would like to get comments

[Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- cputlb.c|4 ++-- exec.c | 31 +++ include/exec/cpu-defs.h |3 +++ include/exec/exec-all.h |1 + include/exec/softmmu_template

[Qemu-devel] [RFC PATCH 3/8] exec: Always initialize MemorySection address spaces

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- exec.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/exec.c b/exec.c index 5e17110..05df217 100644 --- a/exec.c +++ b/exec.c @@ -806,6 +806,7 @@ static void register_subpage(AddressSpaceDispatch *d, MemoryRegionSection *

[Qemu-devel] [RFC PATCH 1/8] exec: Make tb_invalidate_phys_addr input an AS

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" No functional change. Signed-off-by: Edgar E. Iglesias --- exec.c|3 ++- include/exec/exec-all.h |2 +- target-xtensa/op_helper.c |3 ++- translate-all.c |4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [RFC PATCH 5/8] memory: Add MemoryListener to typedefs

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- include/qemu/typedefs.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index a4c1b84..425ca1a 100644 --- a/include/qemu/typedefs.h +++ b/include/qemu/typedefs.h @@ -24,6 +24,

[Qemu-devel] [RFC PATCH 8/8] exec: Make ldl_*_phys input an AddressSpace

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- cpu-exec.c|5 +- exec.c| 19 --- hw/dma/pl080.c|9 ++-- hw/dma/sun4m_iommu.c |3 +- hw/net/vmware_utils.h |2 +-

[Qemu-devel] [RFC PATCH 7/8] exec: On AS changes, only flush affected CPU TLBs

2013-11-22 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- exec.c |5 + 1 file changed, 5 insertions(+) diff --git a/exec.c b/exec.c index acbd2e6..f273a46 100644 --- a/exec.c +++ b/exec.c @@ -1715,6 +1715,11 @@ static void tcg_commit(MemoryListener *listener) reset the mod

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 09:44:42AM -0500, Paul Moore wrote: > On Friday, November 22, 2013 11:39:31 AM Stefan Hajnoczi wrote: > > On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > > > I'm always open to suggestions on how to improve the development/debugging > > > process, so if you hav

Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

2013-11-22 Thread Peter Maydell
On 22 November 2013 15:15, wrote: > @@ -176,6 +176,9 @@ typedef struct CPUWatchpoint { > sigjmp_buf jmp_env; \ > int exception_index;\ >

Re: [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 10:30:30AM +0100, Kevin Wolf wrote: > Am 22.11.2013 um 09:57 hat Stefan Hajnoczi geschrieben: > > On Thu, Nov 21, 2013 at 03:16:23PM +0100, Kevin Wolf wrote: > > > Am 21.11.2013 um 13:43 hat Stefan Hajnoczi geschrieben: > > > > On Wed, Nov 20, 2013 at 03:44:11PM +0800, Fam Z

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 12:16:37PM +0100, Erik Rull wrote: > > On November 22, 2013 at 11:56 AM Stefan Hajnoczi wrote: > > > > > > On Thu, Nov 21, 2013 at 09:44:29PM +0100, Erik Rull wrote: > > > Hu Tao wrote: > > > >On Thu, Nov 21, 2013 at 09:06:43AM +0100, Erik Rull wrote: > > > >>Hi all, > > >

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-22 Thread Paul Moore
On Friday, November 22, 2013 04:48:41 PM Stefan Hajnoczi wrote: > On Fri, Nov 22, 2013 at 09:44:42AM -0500, Paul Moore wrote: > > On Friday, November 22, 2013 11:39:31 AM Stefan Hajnoczi wrote: > > > On Thu, Nov 21, 2013 at 10:48:58AM -0500, Paul Moore wrote: > > > > I'm always open to suggestions

Re: [Qemu-devel] [RFC PATCH 6/8] cpu: Add per-cpu address space

2013-11-22 Thread Edgar E. Iglesias
Hi, no I actually had it in cpustate first but had to do env-get-cpu all over so i moved it to env. Iiuc env-get-cpu involves a dyn typecheck. I havent meassured the perf impact though. Sorry for phone email... Cheers --- Sent from my phone On Nov 22, 2013 4:51 PM, "Peter Maydell" wrote: > On

[Qemu-devel] [PATCH v2 0/7] blkdebug/blkverify: Allow command-line configuration

2013-11-22 Thread Max Reitz
Currently, the configuration of blkdebug and blkverify is done through the "filename" alone. There is now way of manually choosing blkdebug or blkverify as a driver and using a normal image filename. In the case of blkdebug, the filename starts with the protocol prefix, follows up with the name of

[Qemu-devel] [PATCH v2 2/7] blkdebug: Don't require sophisticated filename

2013-11-22 Thread Max Reitz
If the filename is not prefixed by "blkdebug:" in blkdebug_parse_filename(), the blkdebug driver was not selected through that protocol prefix, but by an explicit command line option (file.driver=blkdebug or something similar). Contrary to the current reaction, this is not a problem at all; we just

[Qemu-devel] [PATCH v2 1/7] blkdebug: Use errp for read_config()

2013-11-22 Thread Max Reitz
Use an Error variable in the read_config() function. Signed-off-by: Max Reitz --- block/blkdebug.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 16d2b91..9dfa712 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -

[Qemu-devel] [PATCH v2 3/7] qdict: Add qdict_array_split()

2013-11-22 Thread Max Reitz
This function splits a QDict consisting of entries prefixed by incrementally enumerated indices into a QList of QDicts. Signed-off-by: Max Reitz --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c | 36 2 files changed, 37 insertions(+) diff --git

[Qemu-devel] [PATCH v2 5/7] blkdebug: Always call read_config()

2013-11-22 Thread Max Reitz
Move the check whether there actually is a config file into the read_config() function. Signed-off-by: Max Reitz --- block/blkdebug.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index b50db9d..

[Qemu-devel] [PATCH v2 4/7] qemu-option: Add qemu_config_parse_qdict()

2013-11-22 Thread Max Reitz
This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple sections and also multiple sections of t

[Qemu-devel] [PATCH v2 6/7] blkdebug: Use command-line in read_config()

2013-11-22 Thread Max Reitz
Use qemu_config_parse_qdict() to parse the command-line options in addition to the config file. Signed-off-by: Max Reitz --- block/blkdebug.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 1db999b..58bf05a 100644 ---

[Qemu-devel] [PATCH v2 7/7] blkverify: Don't require protocol filename

2013-11-22 Thread Max Reitz
If the filename is not prefixed by "blkverify:" in blkverify_parse_filename(), the blkverify driver was not selected through that protocol prefix, but by an explicit command line option (like file.driver=blkverify). Contrary to the current reaction, this is not really a problem; the whole filename

Re: [Qemu-devel] [PATCH v4 2/7] block: Introduce op_blockers to BlockDriverState

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 01:24:49PM +0800, Fam Zheng wrote: > +bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType op, Error **errp) > +{ > +BdrvOpBlocker *blocker; > +assert(op >=0 && op < BLOCK_OP_TYPE_MAX); > +if (!QLIST_EMPTY(&bs->op_blockers[op])) { > +blocker = QLIST_

[Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread mrhines
From: "Michael R. Hines" As far as we can tell, all known bugs have been fixed: 1. Parallel RDMA migrations are working 2. IPv6 migration is working 3. Libvirt patches are ready 4. virt-test is working Objections? Reviewed-by: Eric Blake Signed-off-by: Michael R. Hines --- docs/rdma.txt

Re: [Qemu-devel] [PATCH v3 for-1.7 resend] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Daniel P. Berrange
On Sat, Nov 23, 2013 at 12:29:51AM +0800, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > As far as we can tell, all known bugs have been fixed: > 3. Libvirt patches are ready Please stop claiming this. A proof of concept was posted and got some review feedback. AFAIK, no follo

Re: [Qemu-devel] [PATCH v3 for-1.7] rdma: rename 'x-rdma' => 'rdma'

2013-11-22 Thread Paolo Bonzini
Il 16/11/2013 11:32, Daniel P. Berrange ha scritto: > There's also an SELinux question to deal with there. If multiple QEMUs > need concurrent access we can't do a selective grant of the device just > when migration is running - we would have to give all QEMU's access > all the time. This would be

Re: [Qemu-devel] [PATCH v4 0/7] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2013-11-22 Thread Stefan Hajnoczi
On Fri, Nov 22, 2013 at 01:24:47PM +0800, Fam Zheng wrote: > This series adds for point-in-time snapshot NBD exporting based on > blockdev-backup (variant of drive-backup with existing device as target). > > We get a thin point-in-time snapshot by COW mechanism of drive-backup, and > export it thr

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-22 Thread Paolo Bonzini
Il 22/11/2013 12:16, Erik Rull ha scritto: > It's getting more and more complex to build qemu, is there a reason why > everyone > needs to build the acpi stuff by himself? It is only attempted if iasl is installed but as you said below, your version is too old. Please run "make V=1" so that we c

  1   2   >