[Qemu-devel] GIT master fails compilation for ACPI

2013-11-21 Thread Erik Rull
Hi all, when doing a git clone on the latest master, it fails compiling:   CC    x86_64-softmmu/memory_mapping.o   CC    x86_64-softmmu/dump.o   CC    x86_64-softmmu/xen-stub.o   CC    x86_64-softmmu/hw/i386/multiboot.o   CC    x86_64-softmmu/hw/i386/smbios.o   CC    x86_64-softmmu/hw/i386/pc.o  

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Hu Tao
On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: > > it fixes IRQ storm since guest isn't able to lower SCI IRQ > > after it has been handled when it clears GPE event. > > > > Signed-off-by: Igor Mammedov > > The

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Li Guang
Hu Tao wrote: On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: it fixes IRQ storm since guest isn't able to lower SCI IRQ after it has been handled when it clears GPE event. Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 04:12:22PM +0800, Hu Tao wrote: > On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: > > > it fixes IRQ storm since guest isn't able to lower SCI IRQ > > > after it has been handled when it c

Re: [Qemu-devel] [PATCH v6 RESENT 0/2] sheepdog: add user-defined redundancy option

2013-11-21 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 01:22:53AM +0800, Liu Yuan wrote: > On Mon, Nov 18, 2013 at 01:58:50PM +0800, Liu Yuan wrote: > > On Thu, Nov 07, 2013 at 10:56:36PM +0800, Liu Yuan wrote: > > > v6: > > > - update comment typo > > > - remove is_number() > > > > Anyone pick this set up? > > Ping again. W

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: > Hu Tao wrote: > >On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: > >>On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: > >>>it fixes IRQ storm since guest isn't able to lower SCI IRQ > >>>after it has been

Re: [Qemu-devel] [PATCH v6 RESENT 0/2] sheepdog: add user-defined redundancy option

2013-11-21 Thread Stefan Hajnoczi
On Thu, Nov 07, 2013 at 10:56:36PM +0800, Liu Yuan wrote: > v6: > - update comment typo > - remove is_number() > > v5: > - use pstrcpy instead of strncpy > - fix a segfalt for 'null' string option string > > v4: > - fix do_sd_create that forgot to pass nr_copies > - fix parse_redundancy dea

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Hu Tao
On Thu, Nov 21, 2013 at 10:26:36AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 21, 2013 at 04:12:22PM +0800, Hu Tao wrote: > > On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: > > > On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: > > > > it fixes IRQ storm since

Re: [Qemu-devel] pcm.c:7843:(snd_pcm_recover) underrun occurred

2013-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 09:39:26PM +0100, Francesco Turco wrote: > I'm not sure if asking in qemu-devel is the right thing to do, as > I'm not a QEMU developer, but stefanha in the #qemu IRC channel told > me to do so. :-) > > I'm running QEMU 1.6.1 on a 64-bit Gentoo Linux system. The guest > ope

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Li Guang
Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: Hu Tao wrote: On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov wrote: it fixes IRQ storm since guest isn't

Re: [Qemu-devel] [Bug 1253465] [NEW] qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3

2013-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 11:00:14PM -, adrelanos wrote: > qemu-img convert in.vmdk -O RAW out.img > > Fails with: > qemu-img: 'image' uses a vmdk feature which is not supported by this qemu > version: VMDK version 3 > > qemu-img version 1.6.1 This is a known issue. VMware has not released

Re: [Qemu-devel] [PATCH v6 RESENT 0/2] sheepdog: add user-defined redundancy option

2013-11-21 Thread Liu Yuan
On Thu, Nov 21, 2013 at 09:23:59AM +0100, Stefan Hajnoczi wrote: > On Thu, Nov 21, 2013 at 01:22:53AM +0800, Liu Yuan wrote: > > On Mon, Nov 18, 2013 at 01:58:50PM +0800, Liu Yuan wrote: > > > On Thu, Nov 07, 2013 at 10:56:36PM +0800, Liu Yuan wrote: > > > > v6: > > > > - update comment typo > > >

Re: [Qemu-devel] GIT master fails compilation for ACPI

2013-11-21 Thread Hu Tao
On Thu, Nov 21, 2013 at 09:06:43AM +0100, Erik Rull wrote: > Hi all, > > when doing a git clone on the latest master, it fails compiling: > >   CC    x86_64-softmmu/memory_mapping.o >   CC    x86_64-softmmu/dump.o >   CC    x86_64-softmmu/xen-stub.o >   CC    x86_64-softmmu/hw/i386/multiboot.o >

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 05:40:15PM +, Tomoki Sekiyama wrote: > On 11/20/13 4:16 , "Stefan Hajnoczi" wrote: > >Sorry, I forgot to CC qemu-devel on this: > > > >On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi > >wrote: > >> Hi, > >> The mingw32 build is failing as follows: > >> > >> In file i

[Qemu-devel] [PATCH 1.7 2/2] rng-egd: offset the point when repeatedly read from the buffer

2013-11-21 Thread Amos Kong
The buffer content might be read out more than once, currently we just repeatedly read the first data block, buffer offset is missing. Cc: qemu-sta...@nongnu.org Signed-off-by: Amos Kong --- backends/rng-egd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backends/rng-eg

Re: [Qemu-devel] [PATCH 0/17 v2] Localhost migration with side channel for ram

2013-11-21 Thread Lei Li
On 10/25/2013 08:24 PM, Lei Li wrote: On 10/25/2013 03:30 PM, Paolo Bonzini wrote: Il 25/10/2013 06:58, Lei Li ha scritto: Right now just has inaccurate numbers without the new vmsplice, which based on the result from info migrate, as the guest ram size increases, although the 'total time' is

[Qemu-devel] [PATCHv2 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT

2013-11-21 Thread Peter Lieven
this allows for setting VNC_DIRTY_PIXELS_PER_BIT to different values than 16 if desired. Signed-off-by: Peter Lieven --- ui/vnc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 67b1f75..0c93058 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2695,7 +269

[Qemu-devel] [PATCHv2 0/6] ui/vnc: update optimizations

2013-11-21 Thread Peter Lieven
this series includes several optimizations for the ui/vnc guest to server and server to client update cycles. comments/reviews appreciated. v1->v2: - new patches 2,4,5 - patch3: added performance test [Anthony] - patch3: further optimized the vnc_update_client by searching for the

[Qemu-devel] [PATCHv2 6/6] ui/vnc: disable adaptive update calculations if not needed

2013-11-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- ui/vnc.c |9 + 1 file changed, 9 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 5134456..46a9428 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3169,7 +3169,9 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) a

[Qemu-devel] [PATCHv2 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro

2013-11-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- ui/vnc.c | 55 ++- ui/vnc.h |6 +- 2 files changed, 39 insertions(+), 22 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 5601cc3..67b1f75 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -442,17 +442,19 @@ s

[Qemu-devel] [PATCHv2 3/6] ui/vnc: optimize dirty bitmap tracking

2013-11-21 Thread Peter Lieven
vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty. vnc_refresh_server_surface does almost the same. this patch optimizes both by utilizing the heavily optimized function find_next_bit to find the offset of the next

[Qemu-devel] [PATCHv2 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height()

2013-11-21 Thread Peter Lieven
The following artifical test (just the bitmap operation part) running vnc_update_client 65536 times on a 2560x2048 surface illustrates the performance difference: All bits clean - vnc_update_client_new: 0.07 secs vnc_update_client_new2: 0.07 secs vnc_update_client

[Qemu-devel] [PATCHv2 5/6] ui/vnc: optimize setting in vnc_dpy_update()

2013-11-21 Thread Peter Lieven
Signed-off-by: Peter Lieven --- ui/vnc.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 3bbf2af..5134456 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -430,7 +430,6 @@ static int vnc_refresh_server_surface(VncDisplay *vd); static void vnc_dpy_updat

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-21 Thread Stefan Hajnoczi
On Thu, Nov 21, 2013 at 11:33:56AM +0800, Chunyan Liu wrote: > 2013/11/20 Stefan Hajnoczi > > > On Wed, Nov 20, 2013 at 04:50:29PM +0800, Chunyan Liu wrote: > > > block/cow.c | 22 ++ > > > block/qcow.c | 22 ++ > > > block/q

[Qemu-devel] [PATCH 1.7 0/2] fix rng-egd backend

2013-11-21 Thread Amos Kong
The first is a trivial cleanup, the second patch fixes a memcpy bug in reading data from chardev to request data buffer. Amos Kong (2): rng-egd: remove redundant free rng-egd: offset the point when repeatedly read from the buffer backends/rng-egd.c | 5 +++-- 1 file changed, 3 insertions(+),

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 05:05:46PM +0100, Andreas Färber wrote: > Am 20.11.2013 16:16, schrieb Stefan Hajnoczi: > > On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote: > >> On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote: > >>> Hi Gerd, > >>> make check is failing on kraxel_rhel6

Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

2013-11-21 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 06:49:40AM +1000, Richard Henderson wrote: > hw/i386/acpi-build.c:294:5: error: implicit declaration of function > ‘g_string_vprintf’ [-Werror=implicit-function-declaration] > g_string_vprintf(s, format, args); > > Introduced in 2.14. > > > hw/i386/acpi-build.c:427:5

[Qemu-devel] [PATCH 02/17] migration: add migrate_unix_page_flipping()

2013-11-21 Thread Lei Li
Add migrate_unix_page_flipping() to check if MIGRATION_CAPABILITY_UNIX_PAGE_FLIPPING is enabled. Reviewed-by: Paolo Bonzini Signed-off-by: Lei Li --- include/migration/migration.h |3 +++ migration.c |9 + 2 files changed, 12 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 08/17] add unix_msgfd_lookup() to callback get_buffer

2013-11-21 Thread Lei Li
The control message for exchange of pipe file descriptor should be received by recvmsg, and it might be eaten to stream file by qemu_recv() when receiving by two callbacks. So this patch adds unix_msgfd_lookup() to callback get_buffer as the only one receiver, where the pipe file descriptor would b

[Qemu-devel] [PATCH 01/17] QAPI: introduce migration capability unix_page_flipping

2013-11-21 Thread Lei Li
Introduce unix_page_flipping to MigrationCapability for localhost migration. Signed-off-by: Paolo Bonzini Signed-off-by: Lei Li --- qapi-schema.json | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 83fa485..b290a0f 10064

[Qemu-devel] [PATCH 05/17] migration-local: introduce qemu_fopen_socket_local()

2013-11-21 Thread Lei Li
Add qemu_fopen_socket_local() to open QEMUFileLocal introduced earlier. It will create a pipe in write mode if unix_page_flipping is enabled, adjust qemu_local_close() to close pipe as well. Signed-off-by: Lei Li --- include/migration/qemu-file.h |2 + migration-local.c | 46 ++

[Qemu-devel] [PATCH 03/17] qmp-command.hx: add missing docs for migration capabilites

2013-11-21 Thread Lei Li
Signed-off-by: Paolo Bonzini Signed-off-by: Lei Li --- qmp-commands.hx |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index fba15cd..dcec433 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -2898,6 +2898,10 @@ migrate-set-ca

[Qemu-devel] [PATCH 07/17] migration-local: override before_ram_iterate to send pipefd

2013-11-21 Thread Lei Li
Override before_ram_iterate to send pipefd. It will qemu_fflush the stream QEMUFile and send it in RAM_CONTROL_SETUP stage. Signed-off-by: Lei Li --- migration-local.c | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/migration-local.c b/migration-

[Qemu-devel] [PATCH 06/17] migration-local: add send_pipefd()

2013-11-21 Thread Lei Li
This patch adds send_pipefd() to pass the pipe file descriptor to destination process. Signed-off-by: Lei Li --- migration-local.c | 53 + 1 files changed, 53 insertions(+), 0 deletions(-) diff --git a/migration-local.c b/migration-local.c i

[Qemu-devel] [PATCH 13/17] migration-unix: replace qemu_fopen_socket with qemu_fopen_socket_local

2013-11-21 Thread Lei Li
Relace qemu_fopen_socket with qemu_fopen_socket_local in Unix protocol migration. Signed-off-by: Lei Li --- migration-unix.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/migration-unix.c b/migration-unix.c index 651fc5b..9beeafe 100644 --- a/migratio

[Qemu-devel] [PATCH 11/17] savevm: adjust ram_control_save_page for page flipping

2013-11-21 Thread Lei Li
As callback save_page will always be opened by qemu_fopen_socket_local(), and without unix_page_flipping it will return RAM_SAVE_CONTROL_NOT_SUPP, it leads to a wrong qemu_file_set_error() based on the current logic. So this patch adds RAM_SAVE_CONTROL_NOT_SUPP to the check. Reviewed-by: Paolo Bon

[Qemu-devel] [PATCH 15/17] migration-unix: page flipping support on unix outgoing

2013-11-21 Thread Lei Li
Add page flipping support on unix outgoing part by stopping VM with the new RunState RUN_STATE_MEMORY_STALE before invoking migration if unix_page_flipping enabled. Signed-off-by: Lei Li --- migration-unix.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/migr

[Qemu-devel] [PATCH 16/17] migration: adjust migration_thread() process for page flipping

2013-11-21 Thread Lei Li
Signed-off-by: Lei Li --- migration.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/migration.c b/migration.c index 4ac466b..0f98ac1 100644 --- a/migration.c +++ b/migration.c @@ -579,10 +579,11 @@ static void *migration_thread(void *opaque) pendin

[Qemu-devel] [PATCH 09/17] save_page: replace block_offset with a MemoryRegion

2013-11-21 Thread Lei Li
This patch exports MemoryRegion to save_page hook, replacing argument ram_addr_t block_offset with a MemoryRegion suggested by Paolo Bonzini. Signed-off-by: Lei Li --- arch_init.c |4 ++-- include/migration/migration.h |2 +- include/migration/qemu-file.h |8 ---

Re: [Qemu-devel] [PATCH v5 2/2] spapr: limit numa memory regions by ram size

2013-11-21 Thread Thomas Huth
On Mon, 18 Nov 2013 15:19:32 +1100 Alexey Kardashevskiy wrote: > From: Paul Mackerras > > This makes sure that all NUMA memory blocks beside within RAM or s/beside/reside/ ? > have zero length. > > Signed-off-by: Alexey Kardashevskiy > --- > > This is a bugfix for: > -m 500 > -smp 8,socket

[Qemu-devel] [Bug 1179357] Re: Assigned ID could not be used for net-client name

2013-11-21 Thread Amos Kong
** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1179357 Title: Assigned ID could not be used for net-client name Status in QEMU: Fix Re

[Qemu-devel] [PATCH 17/17] hmp: better format for info migrate_capabilities

2013-11-21 Thread Lei Li
As there might be more capabilities introduced, better to display it in lines. Reviewed-by: Paolo Bonzini Signed-off-by: Lei Li --- hmp.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hmp.c b/hmp.c index 32ee285..dcfa2f9 100644 --- a/hmp.c +++ b/hmp.c @@ -226,13 +

Re: [Qemu-devel] [Bug 1253465] [NEW] qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3

2013-11-21 Thread Fam Zheng
On 2013年11月21日 16:37, Stefan Hajnoczi wrote: On Wed, Nov 20, 2013 at 11:00:14PM -, adrelanos wrote: qemu-img convert in.vmdk -O RAW out.img Fails with: qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3 qemu-img version 1.6.1 This is a kno

Re: [Qemu-devel] [PATCH 23/27] pc: ACPI BIOS: implement memory hotplug interface

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:44AM +0100, Igor Mammedov wrote: > - provides static SSDT object for memory hotplug > - SSDT template for memory devices and runtime generator > of them in SSDT table. > > Signed-off-by: Vasilis Liaskovitis > Signed-off-by: Igor Mammedov > --- > mst/pci tree speci

[Qemu-devel] [PATCH 04/17] migration-local: add QEMUFileLocal with socket based QEMUFile

2013-11-21 Thread Lei Li
This patch adds QEMUFileLocal with copy of socket based QEMUFile, will be used as the basis code for Unix socket protocol migration and page flipping migration. Signed-off-by: Lei Li --- Makefile.target |1 + migration-local.c | 121 + 2

[Qemu-devel] [PATCH 1.7 1/2] rng-egd: remove redundant free

2013-11-21 Thread Amos Kong
We didn't set default chr_name, the free is redundant. Signed-off-by: Amos Kong --- backends/rng-egd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 9e5a536..6f56f9e 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -167,7 +167,6 @@ st

[Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-21 Thread Lei Li
This patch series tries to introduce a mechanism using side channel pipe for RAM via SCM_RIGHTS with unix domain socket protocol migration. This side channel is used for the page flipping by vmsplice, which is the internal mechanism for localhost migration that we are trying to add to QEMU. The ba

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:38:34AM +0100, Igor Mammedov wrote: > - implements QEMU hardware part of memory hotplug protocol > described at "docs/specs/acpi_mem_hotplug.txt" > - handles only memory add notification event for now > > Signed-off-by: Igor Mammedov > --- > docs/specs/acpi_mem_hotpl

[Qemu-devel] [PATCH 14/17] add new RanState RAN_STATE_MEMORY_STALE

2013-11-21 Thread Lei Li
Introduce new RanState RAN_STATE_MEMORY_STALE and add it to runstate_needs_reset(). Signed-off-by: Lei Li --- qapi-schema.json |7 +-- vl.c | 12 +++- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index b290a0f..

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 04:32:27PM +0800, Li Guang wrote: > Michael S. Tsirkin wrote: > >On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: > >>Hu Tao wrote: > >>>On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 21, 2013 at 03:38:37AM +0100, Igor Mammedov

[Qemu-devel] [PATCH 10/17] migration-local: override save_page for page transmit

2013-11-21 Thread Lei Li
This patch implements save_page callback for the outside of page flipping. It will write the address of the page on the Unix socket and flip the page data on pipe by vmsplice(). Every page address would have a header flag RAM_SAVE_FLAG_HOOK, which will trigger the load hook to receive it in incomin

[Qemu-devel] [PATCH 12/17] migration-local: override hook_ram_load

2013-11-21 Thread Lei Li
Override hook_ram_load to receive the pipe file descriptor passed by source process and page address which will be extracted to vmsplice the page data from pipe. Signed-off-by: Lei Li --- migration-local.c | 55 + 1 files changed, 55 insertio

Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

2013-11-21 Thread Peter Maydell
On 21 November 2013 09:15, Michael S. Tsirkin wrote: > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 486e705..97e0fba 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -287,14 +287,17 @@ static inline void build_append_array(GArray *array, > GArray *val) > >

Re: [Qemu-devel] [PATCH 04/27] vl: convert -m to qemu_opts_parse()

2013-11-21 Thread Markus Armbruster
Igor Mammedov writes: > Along with conversion extend -m option to support following parameters: Please split this into two patches: first conversion to QemuOpts, then extension. > "mem" - startup memory amount > "slots" - total number of hotplug memory slots > "maxmem" - maximum possible

Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor

2013-11-21 Thread Markus Armbruster
Igor Mammedov writes: > Signed-off-by: Igor Mammedov > --- > qapi/string-input-visitor.c | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c > index 8f1bc41..a152f5d 100644 > --- a/qapi/string-

Re: [Qemu-devel] [PATCH 0/17 v3] Localhost migration with side channel for ram

2013-11-21 Thread Daniel P. Berrange
On Thu, Nov 21, 2013 at 05:11:23PM +0800, Lei Li wrote: > This patch series tries to introduce a mechanism using side > channel pipe for RAM via SCM_RIGHTS with unix domain socket > protocol migration. > > This side channel is used for the page flipping by vmsplice, > which is the internal mechani

Re: [Qemu-devel] [PATCH 0/9] usb: redirection streams support + small fixes

2013-11-21 Thread Gerd Hoffmann
On Di, 2013-11-19 at 14:36 +0100, Hans de Goede wrote: > Hi Gerd, > > Here are my outstanding qemu usb patches. Most of them have been send > before and are just rebases. As before these depend on kernel / libusb > streams support, which will hopefully go upstream for 3.14 . Dropped usb-host patc

[Qemu-devel] [PATCH resend] virtio-rng: add check of period

2013-11-21 Thread Amos Kong
If period is assigned to 0, limit timer will expire immediately. It causes a qemu warning: "main-loop: WARNING: I/O thread spun for 1000 iterations" This limit is meaningless. This patch forbids to assign 0 to period. Reviewed-by: Amit Shah Signed-off-by: Amos Kong --- hw/virtio/virtio-rng.c

Re: [Qemu-devel] [RFC] Architecture to connect a userspace ethernet switch to QEMU guests via Virtio

2013-11-21 Thread Antonios Motakis
On Tue, Nov 19, 2013 at 5:11 PM, Stefan Hajnoczi wrote: > On Tue, Nov 19, 2013 at 11:17:40AM +0100, Antonios Motakis wrote: >> There have been discussions before on these lists on the topic of >> connecting a QEMU guest running a virtio_net driver, with an external >> userspace ethernet switch (Sn

[Qemu-devel] Is there any new progress or plans about "ram live snapshot feature"?

2013-11-21 Thread Zhanghailiang
Hi, Now qemu ram live snapshot feature has some problems, it is based on 'ram live migration'. The time of snapshot depends on completion time of migration, which is not measurable. Also It may can't achieve migrate in some situation. I have seen discussion about that in your previous emails, and

[Qemu-devel] [PATCH 2/2] qtest: unlink UNIX domain sockets after connecting

2013-11-21 Thread Stefan Hajnoczi
UNIX domain sockets are leaked when tests call abort(3) (indirectly via glib assert functions). Unlink the files immediately after the connection has been established to avoid leaks. Signed-off-by: Stefan Hajnoczi --- tests/libqtest.c | 23 --- 1 file changed, 12 insertions(

[Qemu-devel] [PATCH 0/2] qtest: don't leak pid files and UNIX domain sockets

2013-11-21 Thread Stefan Hajnoczi
GLib uses abort(3) to exit failed test cases. As a result, the pid file and UNIX domain sockets for a running test are leaked upon failure. Since abort(3) does not call atexit(3) handler functions, we could set up a SIGABRT handler that performs cleanup. But there are other conditions where proc

[Qemu-devel] [PATCH 1/2] qtest: unlink QEMU pid file after startup

2013-11-21 Thread Stefan Hajnoczi
After starting the QEMU process and initializing the QMP connection, we can read the pid file and unlink it. Just stash away the pid instead of the pid filename. This way we can avoid pid file leaks since running tests may abort(3) without cleanup. Signed-off-by: Stefan Hajnoczi --- tests/libq

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-21 Thread Gerd Hoffmann
On Do, 2013-11-21 at 13:12 +1000, Dave Airlie wrote: > On Wed, Nov 20, 2013 at 10:02 PM, Gerd Hoffmann wrote: > > On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> This is a virtio-vga device built on top of the virtio-gpu device. > > > > Ah, I see what you use

Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 10:09:58AM +, Peter Maydell wrote: > On 21 November 2013 09:15, Michael S. Tsirkin wrote: > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index 486e705..97e0fba 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -287,14 +287,17

Re: [Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-21 Thread Peter Lieven
On 19.11.2013 18:07, Paolo Bonzini wrote: Right now, bdrv_co_do_write_zeroes will only try to align the beginning of the request. However, it is simpler for many formats to expect the block layer to separate both the head *and* the tail. This makes sure that the format's bdrv_co_write_zeroes fu

Re: [Qemu-devel] [PATCH v2 08/20] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-21 Thread Peter Lieven
On 19.11.2013 18:07, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 3 +++ block/vhdx.c | 3 +++ block/vpc.c | 2 ++ 5 files changed, 12 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c index 2fe37ed..92ed895 1

Re: [Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 12:30, Peter Lieven ha scritto: >> +if (num <= max_write_zeroes) { > This frees the bounce buffer ever and ever. num can never be greater than > max_write_zeroes. So you need a num < max_write_zeroes here. Thanks, well spotted. Paolo

Re: [Qemu-devel] [PATCH v2 08/20] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 12:33, Peter Lieven ha scritto: > On 19.11.2013 18:07, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> block/qcow2.c | 2 ++ >> block/qed.c | 2 ++ >> block/vdi.c | 3 +++ >> block/vhdx.c | 3 +++ >> block/vpc.c | 2 ++ >> 5 files changed, 12 insertions(+

Re: [Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1

2013-11-21 Thread Peter Lieven
On 19.11.2013 18:07, Paolo Bonzini wrote: The latest revision of SCSI SBC clarifies the semantics of LBPRZ in a way that lets the iscsi driver remove the distinction between bdrv_unallocated_blocks_are_zero and bdrv_can_write_zeroes_with_unmap. See Table 8: "[If] the LBA became mapped as th

Re: [Qemu-devel] [PATCH v2 08/20] block drivers: add discard/write_zeroes properties to bdrv_get_info implementation

2013-11-21 Thread Peter Lieven
On 21.11.2013 12:39, Paolo Bonzini wrote: Il 21/11/2013 12:33, Peter Lieven ha scritto: On 19.11.2013 18:07, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- block/qcow2.c | 2 ++ block/qed.c | 2 ++ block/vdi.c | 3 +++ block/vhdx.c | 3 +++ block/vpc.c | 2 ++ 5 file

Re: [Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 12:43, Peter Lieven ha scritto: >> >> @@ -1579,7 +1582,7 @@ static int iscsi_get_info(BlockDriverState >> *bs, BlockDriverInfo *bdi) >> { >> IscsiLun *iscsilun = bs->opaque; >> bdi->unallocated_blocks_are_zero = !!iscsilun->lbprz; >> -bdi->can_write_zeroes_with_unm

Re: [Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1

2013-11-21 Thread Peter Lieven
On 21.11.2013 12:49, Paolo Bonzini wrote: Il 21/11/2013 12:43, Peter Lieven ha scritto: @@ -1579,7 +1582,7 @@ static int iscsi_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) { IscsiLun *iscsilun = bs->opaque; bdi->unallocated_blocks_are_zero = !!iscsilun->lbprz; -bd

[Qemu-devel] [PATCH for-1.7] s390x: fix flat rom load on 32 bit systems

2013-11-21 Thread Michael S. Tsirkin
pc-bios/s390-zipl.rom is a flat image so it's expected that loading it as elf will fail. It should fall back on loading a flat file, but doesn't on 32 bit systems, instead it fails printing: qemu: hardware error: could not load bootloader 's390-zipl.rom' The result is boot failure. The reason

Re: [Qemu-devel] [PATCH v2 13/20] block/iscsi: use UNMAP to write zeroes if LBPRZ=1

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 12:54, Peter Lieven ha scritto: > What is the actual reason to add this tweak? The reason is that there are targets that implement UNMAP but not WRITE SAME. But I see what you mean---such a target could validly ignore the unaligned edges of the request. I guess it could be made to

[Qemu-devel] [PATCH for-1.7 1/2] acpi-build: fix build on glib < 2.22

2013-11-21 Thread Michael S. Tsirkin
g_string_vprintf was only introduced in 2.24 so switch to vsnprintf instead. A bit uglier but name size is fixed at 4 bytes here so it's easy. Reported-by: Richard Henderson Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletion

[Qemu-devel] [PATCH for-1.7 2/2] acpi-build: fix build on glib < 2.14

2013-11-21 Thread Michael S. Tsirkin
g_array_get_element_size was only added in glib 2.14. Fortunately we don't use it for any arrays where element size is > 1, so just add an assert. Reported-by: Richard Henderson Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 5 - hw/i386/bios-linker-loader.c | 8 --

Re: [Qemu-devel] [PATCH for-1.7] s390x: fix flat rom load on 32 bit systems

2013-11-21 Thread Alexander Graf
On 21.11.2013, at 13:08, Michael S. Tsirkin wrote: > pc-bios/s390-zipl.rom is a flat image so it's expected that > loading it as elf will fail. > It should fall back on loading a flat file, but doesn't > on 32 bit systems, instead it fails printing: >qemu: hardware error: could not load boot

[Qemu-devel] [PATCH 2/3] usb-host-libusb: Add alloc / free streams ops

2013-11-21 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 50 ++ 1 file changed, 50 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 0dd60b2..894875b 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1280,6

Re: [Qemu-devel] [PATCH 1.7 0/2] fix rng-egd backend

2013-11-21 Thread Paolo Bonzini
Il 21/11/2013 09:42, Amos Kong ha scritto: > The first is a trivial cleanup, the second patch fixes a memcpy > bug in reading data from chardev to request data buffer. > > Amos Kong (2): > rng-egd: remove redundant free > rng-egd: offset the point when repeatedly read from the buffer > > bac

[Qemu-devel] [ANNOUNCE] QEMU 1.7.0-rc1 is now available

2013-11-21 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.7 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.7.0-rc1.tar.bz2 You can help improv

Re: [Qemu-devel] [PATCH 16/27] acpi: ich9: allow guest to clear SCI rised by GPE

2013-11-21 Thread Igor Mammedov
On Thu, 21 Nov 2013 16:32:27 +0800 Li Guang wrote: > Michael S. Tsirkin wrote: > > On Thu, Nov 21, 2013 at 04:18:45PM +0800, Li Guang wrote: > > > >> Hu Tao wrote: > >> > >>> On Thu, Nov 21, 2013 at 09:14:18AM +0200, Michael S. Tsirkin wrote: > >>> > On Thu, Nov 21, 2013 at

Re: [Qemu-devel] [PATCH v2 for-1.7] s390x: fix flat file load on 32 bit systems

2013-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2013 14:52:02 +0200 "Michael S. Tsirkin" wrote: > pc-bios/s390-zipl.rom is a flat image so it's expected that > loading it as elf will fail. > It should fall back on loading a flat file, but doesn't > on 32 bit systems, instead it fails printing: > qemu: hardware error: could n

[Qemu-devel] [RFC PATCH 2/2] rtl8139: update HMP only when the address is fully written

2013-11-21 Thread Vlad Yasevich
rtl8139 hardware requires 9346 config register to be set into write mode before mac address can be changed even though it is not documented. Every driver inspected so far appears to do this along with comments that this is an undocumented requirement. We can use this to help us identify when the

[Qemu-devel] [PATCH for-1.7 5/5] acpi unit-test: compare DSDT and SSDT tables against expected values

2013-11-21 Thread Marcel Apfelbaum
This test will run only if iasl is installed on the host machine. The test plan: 1. Dumps the ACPI tables as AML on the disk. 2. Runs iasl to disassembly the tables into ASL files. 3. Compares them with expected offline ASL files. The test runs for both default machine and q35. In case the test

Re: [Qemu-devel] [PATCH 13/27] acpi: memory hotplug ACPI hardware implementation

2013-11-21 Thread Michael S. Tsirkin
On Thu, Nov 21, 2013 at 03:21:37PM +0100, Igor Mammedov wrote: > On Thu, 21 Nov 2013 11:42:02 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Nov 21, 2013 at 03:38:34AM +0100, Igor Mammedov wrote: > > > - implements QEMU hardware part of memory hotplug protocol > > > described at "docs/specs/

[Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-21 Thread Laszlo Ersek
This patch allows the user to usefully specify -drive file=img_1,if=pflash,format=raw,readonly \ -drive file=img_2,if=pflash,format=raw on the command line. The flash images will be mapped under 4G in their reverse unit order -- that is, with their base addresses progressing downwards, in inc

[Qemu-devel] [edk2 PATCH] OvmfPkg: split the variable store to a separate file

2013-11-21 Thread Laszlo Ersek
Split the variable store off to a separate file when SPLIT_VARSTORE is defined. Even in this case, the preexistent PCDs' values don't change. Qemu must take care of contiguously mapping NVVARSTORE.fd + OVMF.fd so that when concatenated they end exactly at 4GB. Contributed-under: TianoCore Contrib

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-21 Thread Eric Blake
On 11/21/2013 03:21 PM, Laszlo Ersek wrote: > This patch allows the user to usefully specify > > -drive file=img_1,if=pflash,format=raw,readonly \ > -drive file=img_2,if=pflash,format=raw > > on the command line. The flash images will be mapped under 4G in their > reverse unit order -- that i

Re: [Qemu-devel] [qemu PATCH] hw/i386/pc_sysfw: support more than one flash drive

2013-11-21 Thread Laszlo Ersek
On 11/21/13 23:26, Eric Blake wrote: > On 11/21/2013 03:21 PM, Laszlo Ersek wrote: >> This patch allows the user to usefully specify >> >> -drive file=img_1,if=pflash,format=raw,readonly \ >> -drive file=img_2,if=pflash,format=raw >> >> on the command line. The flash images will be mapped under

Re: [Qemu-devel] [RFC PATCH 1/2] e1000: Use Address_Available bit as HW latch

2013-11-21 Thread Eric Blake
On 11/21/2013 01:04 PM, Vlad Yasevich wrote: > e1000 provides a E1000_RAH_AV bit on every complete write > to the Receive Address Register. We can use this bit > 2 ways: > 1) To trigger HMP notifications. When the bit is set the > mac address is fully set and we can update the HMP. > > 2)

Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests

2013-11-21 Thread Erik Rull
Marcel Apfelbaum wrote: Added 2 tests: 1. Basic check of FACS table (missed on prev submission) 2. Compare DSDT and SSDT tables against expected values Test 2: - runs only if iasl is installed on the host machine. - the test plan: 1. Dumps the ACPI tables as AML on the disk. 2. R

[Qemu-devel] [PULL for-1.7 4/5] acpi-build: fix build on glib < 2.14

2013-11-21 Thread Michael S. Tsirkin
g_array_get_element_size was only added in glib 2.14, there's no way to find element size in with an older glib. Fortunately we only use a single table (linker) where element size > 1. Switch element size to 1 everywhere, then we can just look at len field to get table size in bytes. Add an asser

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-11-21 Thread Paul Moore
On Thursday, November 21, 2013 04:14:11 PM Paolo Bonzini wrote: > Il 30/10/2013 11:04, Stefan Hajnoczi ha scritto: > > On Wed, Oct 23, 2013 at 12:42:34PM -0200, Eduardo Otubo wrote: > >> On 10/22/2013 11:00 AM, Anthony Liguori wrote: > >>> On Tue, Oct 22, 2013 at 12:21 PM, Eduardo Otubo > >>> > >>

Re: [Qemu-devel] [PATCH v3 0/6] Add cache mode option to qemu-iotests, and change default mode to "writeback"

2013-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 03:44:11PM +0800, Fam Zheng wrote: > This series adds cache mode option in the iotests framework. Test cases are > updated to make use of cache mode and mask supported modes. > > v3: Change _unsupported_qemu_io_options to _supported_cache_modes. > Change default mode to

[Qemu-devel] [PULL 07/11] rng-egd: remove redundant free

2013-11-21 Thread Paolo Bonzini
From: Amos Kong We didn't set default chr_name, the free is redundant. Signed-off-by: Amos Kong Signed-off-by: Paolo Bonzini --- backends/rng-egd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 9e5a536..6f56f9e 100644 --- a/backends/rng-egd.c

[Qemu-devel] [PATCH 3/6] qemu-option: Add qemu_config_parse_qdict()

2013-11-21 Thread Max Reitz
This function basically parses command-line options given as a QDict replacing a config file. For instance, the QDict {"section.opt1": 42, "section.opt2": 23} corresponds to the config file: [section] opt1 = 42 opt2 = 23 It is possible to specify multiple sections and also multiple sections of t

Re: [Qemu-devel] [RFC PATCH 2/2] rtl8139: update HMP only when the address is fully written

2013-11-21 Thread Eric Blake
On 11/21/2013 01:04 PM, Vlad Yasevich wrote: > rtl8139 hardware requires 9346 config register to be set into > write mode before mac address can be changed even though it is > not documented. Every driver inspected so far appears to do > this along with comments that this is an undocumented requir

Re: [Qemu-devel] [PATCH for-1.7 0/5] acpi unit-test: added tests

2013-11-21 Thread Erik Rull
Marcel Apfelbaum wrote: On Thu, 2013-11-21 at 22:20 +0100, Erik Rull wrote: Marcel Apfelbaum wrote: Added 2 tests: 1. Basic check of FACS table (missed on prev submission) 2. Compare DSDT and SSDT tables against expected values Test 2: - runs only if iasl is installed on the host mach

[Qemu-devel] [PATCH 1/3] usb-host-libusb: Fill in endpoint max_streams when available

2013-11-21 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/host-libusb.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index fd320cd..0dd60b2 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -720,6 +720,9 @@ static void usb_host_ep_updat

  1   2   3   >