[Qemu-devel] [PATCH v2 1/7] split definitions for exec.c and translate-all.c radix trees

2013-11-13 Thread Michael S. Tsirkin
From: Paolo Bonzini The exec.c and translate-all.c radix trees are quite different, and the exec.c one in particular is not limited to the CPU---it can be used also by devices that do DMA, and in that case the address space is not limited to TARGET_PHYS_ADDR_SPACE_BITS bits. We want to make exec

Re: [Qemu-devel] [PATCH for-1.7] acpi unit-test: ensure both 1.6 machine and default machine received the same acpi tables

2013-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2013 at 06:11:25PM +0200, Marcel Apfelbaum wrote: > Machines before 1.6 used ACPI supplied by SeaBios, > for 1.7+ machines the tables are build by qemu. > This patch checks that both machines have the same ACPI tables. > > Also checks the signature of FACS table. > > Signed-off-by

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: > On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: > >On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: > >>What about this approach? This only updates the monitory when all the > >>bits have been written to. > >> > >>-vl

[Qemu-devel] [PATCH v2 3/7] exec: extend skip field to 6 bit, page entry to 32 bit

2013-11-13 Thread Michael S. Tsirkin
Extend skip to 6 bit. As page entry doesn't fit in 16 bit any longer anyway, extend it to 32 bit. This doubles node map memory requirements, but follow-up patches will save this memory. Signed-off-by: Michael S. Tsirkin --- exec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-13 Thread Vlad Yasevich
On 11/13/2013 03:00 PM, Michael S. Tsirkin wrote: On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all t

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Eric Blake
On 11/13/2013 07:19 AM, Kevin Wolf wrote: >> # >> -# @dirty: #optional dirty bitmap information (only present if the dirty >> -# bitmap is enabled) >> +# @dirty-bitmaps: #optional dirty bitmaps information (only present if the >> +# driver has one or more dirty bitmaps) >>

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

2013-11-13 Thread Marcelo Tosatti
On Wed, Nov 13, 2013 at 05:58:32PM -0200, Marcelo Tosatti wrote: > On Wed, Nov 13, 2013 at 06:13:15PM +0100, Paolo Bonzini wrote: > > > assert(piecetwosize <= holesize); > > > > > > piecetwosize = MIN(above_4g_mem_size, piecetwosize); > > > if ((above_4g_mem_siz

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Eric Blake
On 11/13/2013 03:29 AM, Fam Zheng wrote: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. > > Signed-off-by: Fam Zheng > --- > block.c | 20 > block/qapi.c | 5 +

Re: [Qemu-devel] [PATCH 12/14] VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-11-13 Thread Tom Musta
On 11/7/2013 6:13 PM, Richard Henderson wrote: > On 11/08/2013 09:30 AM, Richard Henderson wrote: >> On 11/08/2013 09:28 AM, Richard Henderson wrote: >>> On 11/07/2013 06:31 AM, Tom Musta wrote: } \ +

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-13 Thread Corey Minyard
On 11/13/2013 02:55 AM, Gerd Hoffmann wrote: > Hi, > >> Allow a socket that connects to reconnect on a periodic basis if it >> fails to connect at startup or if the connection drops while in use. >> +chr->backend = i; >> +chr->recon_time = qemu_opt_get_number(opts, "reconnect", 0); >> +

Re: [Qemu-devel] [PATCH 11/16] ipmi: Add tests

2013-11-13 Thread Corey Minyard
On 11/13/2013 08:12 AM, Bret Ketchum wrote: > Having trouble with this patch (after the prior patches were > successfully applied): I was a couple of days behind and some other changes that came in conflicted with this. -corey > > git status > # On branch master > # Changes not staged for c

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

2013-11-13 Thread Corey Minyard
On 11/13/2013 08:37 AM, Bret Ketchum wrote: > > Don't know if it matters much but this patch cannot be applied > without the prototype definition in 16/16. Thanks, I'll fix this. -corey > > > On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard > wrote: > > There was

Re: [Qemu-devel] [PATCH 1.7] mips jazz: do not raise data bus exception when accessing invalid addresses

2013-11-13 Thread Hervé Poussineau
Ping for 1.7 Paolo Bonzini a écrit : Il 04/11/2013 23:26, Hervé Poussineau ha scritto: MIPS Jazz chipset doesn't seem to raise data bus exceptions on invalid accesses. However, there is no easy way to prevent them. Creating a big memory region for the whole address space doesn't prevent memory

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2013 at 03:26:36PM -0500, Vlad Yasevich wrote: > On 11/13/2013 03:00 PM, Michael S. Tsirkin wrote: > >On Wed, Nov 13, 2013 at 11:21:18AM -0500, Vlad Yasevich wrote: > >>On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: > >>>On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wro

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

2013-11-13 Thread Paolo Bonzini
> > > +if (guest_info->gb_align && above_4g_mem_size > holesize) { > > > +/* Round the allocation up to 2 MB to use more hugepages. > > To align to 2MB boundary, the number of hugepages is the same. Right. > > > + * Remove the slack from the [yyy] piece so that pieceonesize >

[Qemu-devel] [Bug 1246990] Re: [qemu-x86-64-linux-user 1.6.1] qemu: uncaught target signal 11 (Segmentation fault) - core dumped

2013-11-13 Thread Serge Hallyn
** Changed in: qemu (Ubuntu) Importance: Undecided => Low ** Changed in: qemu (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1246990 Title: [qemu-x86-64-

Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-13 Thread Peter Maydell
On 13 November 2013 07:25, Paolo Bonzini wrote: > Il 13/11/2013 03:27, Richard Henderson ha scritto: >> I think it's also worthwhile to implement the kvm api in kvm-stub.c, >> unnecessary or not. If you really want compile-time feedback on those that >> ought to have been removed by optimization,

[Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-13 Thread Peter Maydell
Fix build failures with clang when KVM is not enabled by providing a stub version of kvm_arch_get_supported_cpuid(). We retain the compile time check that this function isn't called when CONFIG_KVM is not set by guarding the stub with ifndef __OPTIMIZE__ (we assume that an optimizing build will do

Re: [Qemu-devel] [PATCH 12/14] VSX Stage 4: Add Scalar SP Fused Multiply-Adds

2013-11-13 Thread Richard Henderson
On 11/14/2013 06:49 AM, Tom Musta wrote: > I have reviewed the code and the spec and I cannot see a flaw. The sequence > is > effectively this: > > - float64_muladd - performs proper FMA for 64 bit numbers) > - float64_to_float32 - converts to single precision, including proper > rounding

Re: [Qemu-devel] [PATCH for-1.7] vfio-pci: Fix multifunction=on

2013-11-13 Thread Bandan Das
Alex Williamson writes: > When an assigned device is initialized it copies the device config > space into the emulated config space. Unfortunately multifunction is > setup prior to the device initfn and gets clobbered. We need to > restore it just like pci-assign does. > > Signed-off-by: Alex W

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

2013-11-13 Thread Fam Zheng
On 2013年11月13日 23:23, Jeff Cody wrote: On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: If target block driver forces compression, qemu-img convert needs to write by cluster size as well as "-c" option. Particularly, this applies for converting to VMDK streamOptimized format. Signed-

Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result

2013-11-13 Thread Fam Zheng
On 2013年11月13日 23:34, Jeff Cody wrote: On Wed, Nov 13, 2013 at 08:53:14AM +0800, Fam Zheng wrote: bdrv_get_info could fail. Add check before using the returned value. Signed-off-by: Fam Zheng --- block/mirror.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/mi

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Wenchao Xia
--- a/qapi-schema.json +++ b/qapi-schema.json @@ -948,8 +948,8 @@ # @tray_open: #optional True if the device has a tray and it is open # (only present if removable is true) # -# @dirty: #optional dirty bitmap information (only present if the dirty -# bitmap is enabled)

Re: [Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Fam Zheng
On 2013年11月13日 20:43, Kevin Wolf wrote: From: Fam Zheng This patch moves ret assignment after reporting original error. We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" mismatch offset. This fixes two bug

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

2013-11-13 Thread Jeff Cody
On Thu, Nov 14, 2013 at 09:18:35AM +0800, Fam Zheng wrote: > On 2013年11月13日 23:23, Jeff Cody wrote: > >On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: > >>If target block driver forces compression, qemu-img convert needs to > >>write by cluster size as well as "-c" option. > >> > >>Parti

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035

2013-11-13 Thread Fam Zheng
On 2013年11月13日 22:02, Kevin Wolf wrote: Am 13.11.2013 um 13:40 hat Fam Zheng geschrieben: This change is manually copy&pasted into thunderbird. It has a super long line to kill `git send-email`, and is wrapped by email composer. So you need to pull to merge it. 'git send-email --no-validate' w

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

2013-11-13 Thread Fam Zheng
On 2013年11月14日 09:34, Jeff Cody wrote: On Thu, Nov 14, 2013 at 09:18:35AM +0800, Fam Zheng wrote: On 2013年11月13日 23:23, Jeff Cody wrote: On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: If target block driver forces compression, qemu-img convert needs to write by cluster size as well

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Eric Blake
On 11/13/2013 06:31 PM, Wenchao Xia wrote: > >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -948,8 +948,8 @@ >> # @tray_open: #optional True if the device has a tray and it is open >> # (only present if removable is true) >> # >> -# @dirty: #optional dirty bitmap infor

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Wenchao Xia
于 2013/11/13 22:40, Fam Zheng 写道: On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. Signed-off-by: Fam Zhe

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
On 2013年11月14日 10:13, Wenchao Xia wrote: 于 2013/11/13 22:40, Fam Zheng 写道: On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop

[Qemu-devel] [PATCH] qemu-iotests: Add "-c " to check

2013-11-13 Thread Fam Zheng
The default cache mode for drive options is changed to writethrough, and overridable with "./check -c ". Signed-off-by: Fam Zheng --- tests/qemu-iotests/common | 13 - tests/qemu-iotests/iotests.py | 3 ++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tests/qe

[Qemu-devel] [PATCH] qapi: Add (Since 1.8) to BlockInfo.dirty-bitmaps

2013-11-13 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 931d710..3f2b5ef 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -949,7 +949,7 @@ # (only present if removable is true)

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
On 2013年11月14日 09:31, Wenchao Xia wrote: --- a/qapi-schema.json +++ b/qapi-schema.json @@ -948,8 +948,8 @@ # @tray_open: #optional True if the device has a tray and it is open # (only present if removable is true) # -# @dirty: #optional dirty bitmap information (only present i

Re: [Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-11-13 Thread Wenchao Xia
ping?

Re: [Qemu-devel] [PATCH V5 0/5] export internal snapshot by qemu-nbd

2013-11-13 Thread Wenchao Xia
Hello, any more comments?

Re: [Qemu-devel] [PATCH V2 0/8] qapi script: support enum as discriminator and better enum name

2013-11-13 Thread Wenchao Xia
Just found timestamp of this series seems older than v1, so ping to correct it.

Re: [Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-13 Thread Wenchao Xia
于 2013/11/14 3:37, Max Reitz 写道: > If a block device is unbacked, a streaming blockjob should immediately > finish instead of beginning to try to stream, then noticing the backing > file does not contain even the first sector (since it does not exist) > and then finishing normally. > > Signed-off-

Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c " to check

2013-11-13 Thread Wenchao Xia
Tried on RH6.4 x86_64 on upstream, the value can be passed to the final vm boot command. Tested-by: Wenchao Xia

[Qemu-devel] -vga std vs. -device VGA

2013-11-13 Thread Alexey Kardashevskiy
Hi everyone. Here is a problem with the SPAPR machine and a libvirt's habit to use "-nodefaults". When we run QEMU with "-vga std", a VGA device is created from the machine_init callback and if VGA is added, then we automatically add a PCI USB OHCI adapter with a keyboard and everybody (SLOF, yab

Re: [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property

2013-11-13 Thread Alexey Kardashevskiy
On 11/12/2013 12:31 AM, Andreas Färber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: >> This patch is to demonstrate a static property handling in PowerPC. >> Running QEMU with -cpu host,-vsx disables VSX bit in >> PowerPCCPU::env::flags. >> >> Signed-off-by: Alexey Kardashevskiy >>

Re: [Qemu-devel] [PATCH v2 for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()

2013-11-13 Thread Stefan Weil
Am 14.11.2013 00:09, schrieb Peter Maydell: > Fix build failures with clang when KVM is not enabled by > providing a stub version of kvm_arch_get_supported_cpuid(). > We retain the compile time check that this function isn't > called when CONFIG_KVM is not set by guarding the stub with > ifndef __O

Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

2013-11-13 Thread Alexey Kardashevskiy
On 11/13/2013 11:04 PM, Paolo Bonzini wrote: > Il 13/11/2013 03:40, Alexey Kardashevskiy ha scritto: >> I looked further and did not find any use of ffs/clz so I wonder what did >> you mean about bitops.h and what did I miss? I am confused. > > It's host-utils.h actually. The reason for the wrapp

Re: [Qemu-devel] -vga std vs. -device VGA

2013-11-13 Thread Benjamin Herrenschmidt
On Thu, 2013-11-14 at 16:01 +1100, Alexey Kardashevskiy wrote: > So the question is - is there any proper (i. e. qemu-upstreamable) way to > detect a VGA device presence and create additional devices (OHCI, keyboard, > mouse) as "-vga" does it now? The machine reset callback is too late for that. >

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-13 Thread Michael S. Tsirkin
On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: > Postpone the addition of the ACPI and SMBIOS tables until after > device initialization. This allows devices to add entries to these > tables. > > Signed-off-by: Corey Minyard Why delay adding FW_CFG_ACPI_TABLES? These are normall

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-13 Thread Michael S. Tsirkin
On Tue, Nov 12, 2013 at 11:08:07AM -0600, Corey Minyard wrote: > On 11/12/2013 10:43 AM, Eric Blake wrote: > > On 11/12/2013 09:33 AM, Corey Minyard wrote: > >> Allow a socket that connects to reconnect on a periodic basis if it > >> fails to connect at startup or if the connection drops while in u

Re: [Qemu-devel] [PATCH 2/2] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-11-13 Thread Michael S. Tsirkin
On Wed, Nov 13, 2013 at 01:04:10PM +0100, Igor Mammedov wrote: > On Wed, 13 Nov 2013 00:10:39 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Nov 12, 2013 at 07:26:02PM +0100, Paolo Bonzini wrote: > > > Il 12/11/2013 14:58, Igor Mammedov ha scritto: > > > > 'etc/reserved-memory-end' will allow

Re: [Qemu-devel] [PATCH 16/16] ipmi: Add SMBIOS table entry

2013-11-13 Thread Michael S. Tsirkin
BTW you included this: Cc: qemu-devel@nongnu.org, Andreas Färber , Bret Ketchum , Corey Minyard the last address: cminy...@mvista.com is bouncing. -- MST

<    1   2