Re: [Qemu-devel] Adding some code to the QEMU used inside Android Emulator

2013-11-13 Thread Max Filippov
On Wed, Nov 13, 2013 at 11:26 AM, Fardin wrote: > Hi everyone, > > My question might look very stupid but the answer would really help me. > > I am working on Android emulator which is using QEMU. I need to print out > the value of env->cp15.c13_fcse everytime the void tlb_flush(CPUState *env, > i

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block tree repo URLs

2013-11-13 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 05:10:23PM +0100, Kevin Wolf wrote: > Am 06.11.2013 um 16:06 hat Stefan Hajnoczi geschrieben: > > Signed-off-by: Stefan Hajnoczi > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 77edacf..6c63548 1

Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus

2013-11-13 Thread Chen Fan
On Tue, 2013-11-12 at 17:41 +0100, Andreas Färber wrote: > Am 12.11.2013 04:02, schrieb Chen Fan: > > On Tue, 2013-11-12 at 09:54 +0800, 赵小强 wrote: > >> He asked me to drop the parent_realize. so in v2, I just replace the > >> 'init' with 'realize'. > >> > > Hmm,I'm confused, Go through the entire

Re: [Qemu-devel] [PATCH] qemu-img: Fix content mismatch offset of image compare

2013-11-13 Thread Miroslav Rezanina
- Original Message - > From: "Fam Zheng" > To: qemu-devel@nongnu.org > Cc: stefa...@redhat.com, kw...@redhat.com, "Miroslav Rezanina" > > Sent: Wednesday, November 13, 2013 5:04:18 AM > Subject: [PATCH] qemu-img: Fix content mismatch offset of image compare > > We were lucky to pass qem

Re: [Qemu-devel] [PATCH 02/16] qemu-char: Allow a chardev to reconnect if disconnected

2013-11-13 Thread Gerd Hoffmann
Hi, > Allow a socket that connects to reconnect on a periodic basis if it > fails to connect at startup or if the connection drops while in use. > +chr->backend = i; > +chr->recon_time = qemu_opt_get_number(opts, "reconnect", 0); > +if (chr->recon_time) { > +if (strcmp(qemu_

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-13 Thread Paolo Bonzini
Il 12/11/2013 10:58, Igor Mammedov ha scritto: > extending QemuOpts to parsing ±opts format, seems like good workaround > above problem. But I was under impression that general movement was to convert > custom formats to canonical format "prop=value". I think the general movement is to convert thi

[Qemu-devel] [PATCH v2] curses: fixup SIGWINCH handler mess

2013-11-13 Thread Gerd Hoffmann
Don't run code in the signal handler, only set a flag. Use sigaction(2) to avoid non-portable signal(2) semantics. Make #ifdefs less messy. Signed-off-by: Gerd Hoffmann --- ui/curses.c | 44 1 file changed, 28 insertions(+), 16 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH] qemu-img: re-assign ret after reporting original error

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 06:24 hat Amos Kong geschrieben: > Currently the output error is always: > strerror(-4) -> Unknown error -4 > > This patch moves ret assignment after reporting original error. > > Signed-off-by: Amos Kong Fam and Amos, can you consolidate the fixes in one patch, and update th

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-13 Thread Paolo Bonzini
Il 12/11/2013 13:45, Andreas Färber ha scritto: >> > Heh. I do not understand movements in the qemu project most of the time >> > :) I thought I could have added "compat" to PowerPC CPU as others did >> > but I was so wrong :) > Hey, I instructed you how to do exactly that, with a const char * > ar

[Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

2013-11-13 Thread Stefan Hajnoczi
There are a number of contributors who maintain block drivers (image formats and protocols). They should be listed in the MAINTAINERS file so that get_maintainer.pl lists them. Note that commits are still merged through Kevin or Stefan's block tree but the block driver sub-maintainers are usually

Re: [Qemu-devel] [PATCH 06/11] scsi-disk: correctly implement WRITE SAME

2013-11-13 Thread Paolo Bonzini
Il 13/11/2013 07:18, Peter Lieven ha scritto: >> > The WRITE SAME command is implemented incorrectly. WRITE SAME with the >> > UNMAP bit set should _not_ unmap the sectors unless the written data >> > matches the payload of the WRITE SAME command; currently, QEMU is not >> > looking at the payload

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-13 Thread Paolo Bonzini
Il 13/11/2013 07:29, Peter Lieven ha scritto: > Wouldn't it be good to add bdi->can_write_zeroes_with_unmap here as well? We do: > +bdi->unallocated_blocks_are_zero = s->discard_zeroes; > +bdi->can_write_zeroes_with_unmap = s->discard_zeroes; > This would automatically avoid full allocat

[Qemu-devel] [PATCH RFC 3/3] tests: add test cases for qapi event support

2013-11-13 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- tests/Makefile | 14 ++- tests/qapi-schema/qapi-schema-test.json | 12 ++ tests/qapi-schema/qapi-schema-test.out | 10 +- tests/test-qmp-event.c | 250 +++ 4 files changed, 281 insertions(

[Qemu-devel] [PATCH RFC 1/3] os-posix: include sys/time.h

2013-11-13 Thread Wenchao Xia
Since gettimeofday() is used in this header file as a macro define, include the function's define header file, to avoid compile warning when other file include os-posix.h. Signed-off-by: Wenchao Xia --- include/sysemu/os-posix.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff -

[Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

2013-11-13 Thread Wenchao Xia
Nested structure is not supported now, so following define is not valid: { 'event': 'EVENT_C', 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' } Signed-off-by: Wenchao Xia --- Makefile |9 +- Makefile.objs |2 +- qapi/Makefile.objs|1 + scripts/qa

[Qemu-devel] [PATCH 2/2] try

2013-11-13 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- Makefile|9 +- Makefile.objs |2 +- include/qapi/qmp-event.h| 29 +++ qapi/Makefile.objs |1 + qapi/qmp-event.c| 45 scripts/q

[Qemu-devel] [PATCH RFC 0/3] add direct support of event in qapi schema

2013-11-13 Thread Wenchao Xia
This series add support for tag/keyword 'event' in qapi-schema. The implemention doesn't generate a struture and visit function in the background for every event, so it doesn't support nested structure in the define to avoid trouble. It is on top of series: http://lists.nongnu.org/archive/html/qem

Re: [Qemu-devel] [PATCH 2/2] try

2013-11-13 Thread Wenchao Xia
Sorry I sent this draft patch by mistake, please ignore this one and have a look at the rest 3 patches.

Re: [Qemu-devel] [Bug 1250360] [NEW] qcow2 image logical corruption after host crash

2013-11-13 Thread Stefan Hajnoczi
On Tue, Nov 12, 2013 at 09:17:34AM -, Blue wrote: Please post the qemu command-line (ps aux | grep qemu) for the affected VM. What kind of workload is accessing the disk? Guest OS and version? Please also confirm that nothing else is accessing the image file while the VM is running. It is

[Qemu-devel] [PATCH v3 0/2] block: per caller dirty bitmap

2013-11-13 Thread Fam Zheng
This adds multiple dirty bitmaps support into BlockDriverState and updates QAPI to include it with query-block. v3: Add patch 2 to drop old "*dirty" field in BlockInfo and add "*dirty_bitmaps". Fam Zheng (2): block: per caller dirty bitmap qapi: Change BlockDirtyInfo to list block-migratio

[Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. Signed-off-by: Fam Zheng --- block.c | 20 block/qapi.c | 5 + include/block/block.h | 1 + qapi-schema.json

[Qemu-devel] [PATCH v3 1/2] block: per caller dirty bitmap

2013-11-13 Thread Fam Zheng
Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the lifecycle is managed with these new functions: bdrv_create_dirty_bitmap bdrv_

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-13 Thread Igor Mammedov
On Wed, 13 Nov 2013 13:07:26 +1100 Alexey Kardashevskiy wrote: > On 11/13/2013 12:11 AM, Igor Mammedov wrote: > > On Tue, 12 Nov 2013 23:39:27 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 12.11.2013 20:58, Igor Mammedov wrote: > >>> On Tue, 12 Nov 2013 10:49:58 +1100 > >>> Alexey Kardashev

[Qemu-devel] [Bug 1250360] Re: qcow2 image logical corruption after host crash

2013-11-13 Thread Blue
Indeed, it's the same issue, i opened the report @ centos, redhat and here. Thank you Kevin for posting the link before I got to do it :) Can we link the reports like we can in rhel-centos bugzilla ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

[Qemu-devel] [PATCH] qemu-iotests: Test qcow2 count_contiguous_clusters()

2013-11-13 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- This test case catches the qcow2 corruption bug that Peter sent a patch for yesterday. tests/qemu-iotests/073 | 166 + tests/qemu-iotests/073.out | 118 tests/qemu-iotests/group |

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW

2013-11-13 Thread Michael Tokarev
10.11.2013 21:49, Stefan Weil wrote: > While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny > (gcc-mingw32 4.4.2-3) shows these errors: I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny is an "old-old-stable" Debian release - it was before squeeze which is now oldstab

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] trace: Remove trace.h from console.h (less dependencies)

2013-11-13 Thread Michael Tokarev
10.11.2013 17:20, Stefan Weil wrote: > This reduces the dependencies on trace.h. > Only two source files which need console.h also need trace.h. Thanks, applied both patches to the trivial patches queue, after actually verifying that the result is sane ;) /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] console: Remove unused debug code

2013-11-13 Thread Michael Tokarev
10.11.2013 18:58, Stefan Weil пишет: > The local function console_print_text_attributes is no longer used since > commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f. Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] gtk: Replace conditional debug messages by trace methods

2013-11-13 Thread Michael Tokarev
10.11.2013 19:24, Stefan Weil wrote: [] Thanks, applied to the trivial-patches queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qga: Fix shutdown command of guest agent to work with SysV

2013-11-13 Thread Michael Tokarev
06.11.2013 05:54, whitearchey wrote: > For now guest agent uses following command to shutdown system: > shutdown -P +0 "blabla" > but this syntax works only with shutdown command from systemd or upstart, > because SysV shutdown requires -h switch. > > Following patch changes the command so it work

Re: [Qemu-devel] [PATCH 2/2] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS

2013-11-13 Thread Igor Mammedov
On Wed, 13 Nov 2013 00:10:39 +0200 "Michael S. Tsirkin" wrote: > On Tue, Nov 12, 2013 at 07:26:02PM +0100, Paolo Bonzini wrote: > > Il 12/11/2013 14:58, Igor Mammedov ha scritto: > > > 'etc/reserved-memory-end' will allow QEMU to tell BIOS where PCI > > > BARs mapping could safely start in high m

Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

2013-11-13 Thread Paolo Bonzini
Il 13/11/2013 03:40, Alexey Kardashevskiy ha scritto: > I looked further and did not find any use of ffs/clz so I wonder what did > you mean about bitops.h and what did I miss? I am confused. It's host-utils.h actually. The reason for the wrappers is twofold: (1) provide 32/64-bit functions inst

Re: [Qemu-devel] xsave instruction not passed through correctly on AMD hardware

2013-11-13 Thread Owen Tuz
Great, thanks for the clarification. Testing with kvm-next shows that this is still true in the latest build. Best regards, Owen On Mon, Nov 11, 2013 at 4:56 PM, Paolo Bonzini wrote: > Il 11/11/2013 16:43, Owen Tuz ha scritto: > > Thanks, Paolo. We will test and let you know. > > I'm not fami

[Qemu-devel] [PATCH v2] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Fam Zheng
This patch moves ret assignment after reporting original error. We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" mismatch offset. This fixes two bugs. In the first if branch, setting ret to 1 before using it

[Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add

2013-11-13 Thread Fam Zheng
This will allow running iotests on tmpfs, which is much faster, so we can run more tests. Signed-off-by: Fam Zheng --- tests/qemu-iotests/iotests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index fb10ff4..c2

[Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035

2013-11-13 Thread Fam Zheng
This change is manually copy&pasted into thunderbird. It has a super long line to kill `git send-email`, and is wrapped by email composer. So you need to pull to merge it. It is available as following branch, with one single commit: https://github.com/famz/qemu.git 035-filter-qemu-io

[Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Kevin Wolf
From: Fam Zheng This patch moves ret assignment after reporting original error. We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" mismatch offset. This fixes two bugs. In the first if branch, setting ret to

Re: [Qemu-devel] [PATCH v3 1/2] COW: Speed up writes

2013-11-13 Thread Kevin Wolf
Am 06.11.2013 um 16:59 hat Charlie Shepherd geschrieben: > Process a whole sector's worth of COW bits by reading a sector, setting the > bits after skipping > any already set bits, then writing it out again. Make sure we only flush once > before writing > metadata, and only if we need to write me

[Qemu-devel] [PULL 04/16] qemu-char: add missing characters used in keymaps

2013-11-13 Thread Michael Tokarev
From: Jan Krupa This patch adds all missing characters used in regional keymap files which already exist in QEMU. I checked for the missing characters by going through all of the keymaps and matching that with records in vnc_keysym.h. If the key wasn't found I looked it up in libxkbcommon library

[Qemu-devel] [PULL 10/16] qga: Fix compilation for old versions of MinGW

2013-11-13 Thread Michael Tokarev
From: Stefan Weil While MinGW-w64 can compile the qga code, MinGW from Debian lenny (gcc-mingw32 4.4.2-3) shows these errors: In file included from qga/vss-win32.c:17: qga/vss-win32/requester.h:31: error: expected »=«, »,«, »;«, »asm« or »__attribute__« before »requester_init« qga/vss-win32/req

[Qemu-devel] [PULL 02/16] qemu-char: add Czech keymap file

2013-11-13 Thread Michael Tokarev
From: Jan Krupa This patch adds Czech keyboard layout to available keymap files and Makefile. Signed-off-by: Jan Krupa Signed-off-by: Michael Tokarev --- Makefile |2 +- pc-bios/keymaps/cz | 94 2 files changed, 95 insertion

[Qemu-devel] [PULL 01/16] qemu-char: add Czech characters to VNC keysyms

2013-11-13 Thread Michael Tokarev
From: Jan Krupa This patch adds missing Czech characters to the VNC keysym table. Signed-off-by: Jan Krupa Signed-off-by: Michael Tokarev --- ui/vnc_keysym.h |8 1 file changed, 8 insertions(+) diff --git a/ui/vnc_keysym.h b/ui/vnc_keysym.h index 6250bec..72c01d1 100644 --- a/ui

[Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

2013-11-13 Thread Michael Tokarev
Here's a next trivial-patches pull request, for patches collected in almost 3 weeks. There's nothing extra-ordinary here, except of one thing: this is keyboard maps handling series by Jan Krupa. While I don't expect any breakage in this area, but the series introduces a new keymap (cz), fixes oth

[Qemu-devel] [PULL 03/16] qemu-char: add support for U-prefixed symbols

2013-11-13 Thread Michael Tokarev
From: Jan Krupa This patch adds support for Unicode symbols in keymap files. This feature was already used in some keyboard layouts in QEMU generated from XKB (e.g. Arabic) but it wasn't implemented in QEMU source code. There is no need for check of validity of the hex string after U character b

[Qemu-devel] [PULL 15/16] gtk: Replace conditional debug messages by trace methods

2013-11-13 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- trace-events |5 + ui/gtk.c | 19 +-- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/trace-events b/trace-events index d196234..bc6788f 100644 --- a/trace-events +++

[Qemu-devel] [PULL 07/16] qapi: Fix comment for create-type to match code.

2013-11-13 Thread Michael Tokarev
From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Eric Blake Signed-off-by: Michael Tokarev --- qapi-schema.json |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 81a375b..76c98a7 100644 --- a/qapi-schema.json +++ b/qapi-schem

[Qemu-devel] [PULL 13/16] trace: Remove trace.h from hw/usb/hcd-ehci.h (less dependencies)

2013-11-13 Thread Michael Tokarev
From: Stefan Weil This reduces the dependencies on trace.h. Only one source file which needs hcd-ehci.h also needs trace.h. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/usb/hcd-ehci.c |1 + hw/usb/hcd-ehci.h |1 - 2 files changed, 1 insertion(+), 1 deletion(-) dif

[Qemu-devel] [PULL 11/16] console: Remove unused debug code

2013-11-13 Thread Michael Tokarev
From: Stefan Weil The local function console_print_text_attributes is no longer used since commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f. Signed-off-by: Stefan Weil Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- ui/console.c | 33 - 1 file c

[Qemu-devel] [PULL 09/16] .travis.yml: basic compile and check recipes

2013-11-13 Thread Michael Tokarev
From: Alex Bennée This adds a build matrix definition for travis-ci.org continuous integration service. It is usable on any public repository hosted on GitHub. Once you have created an account signed into Travis you can enable it on selected projects via travis-ci.org/profile. Alternatively you c

[Qemu-devel] [PULL 06/16] vl: fix build when configured with no graphic support

2013-11-13 Thread Michael Tokarev
From: Antony Pavlov The following error occurs when building with no graphic output support: vl.c: In function ‘main’: vl.c:2829:19: error: variable ‘ds’ set but not used [-Werror=unused-but-set-variable] DisplayState *ds; ^ cc1: all warnings being treated as e

[Qemu-devel] [PULL 05/16] usb: drop unused USBNetState.inpkt field

2013-11-13 Thread Michael Tokarev
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Benoit Canet Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- hw/usb/dev-network.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 660d774..4c532b7 100644 --

[Qemu-devel] [PULL 12/16] trace: Remove trace.h from console.h (less dependencies)

2013-11-13 Thread Michael Tokarev
From: Stefan Weil This reduces the dependencies on trace.h. Only two source files which need console.h also need trace.h. Signed-off-by: Stefan Weil Signed-off-by: Michael Tokarev --- hw/display/vmware_vga.c |1 + include/ui/console.h|1 - ui/console.c|1 + 3 files

[Qemu-devel] [PULL 14/16] console: Replace conditional debug messages by trace methods

2013-11-13 Thread Michael Tokarev
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Gerd Hoffmann Signed-off-by: Michael Tokarev --- trace-events |2 ++ ui/console.c | 11 +++ 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/trace-events b/trace-events index 8695e9e..d196234 100644 --- a/tr

[Qemu-devel] [PULL 16/16] qga: Fix shutdown command of guest agent to work with SysV

2013-11-13 Thread Michael Tokarev
From: whitearchey For now guest agent uses following command to shutdown system: shutdown -P +0 "blabla" but this syntax works only with shutdown command from systemd or upstart, because SysV shutdown requires -h switch. Following patch changes the command so it works with systemd, upstart and S

[Qemu-devel] [PULL 08/16] pci-assign: Fix error_report of pci-stub message

2013-11-13 Thread Michael Tokarev
From: Cole Robinson Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_printf to preserve the intended formatting. Since this code path is always preceded by an error_report call, we don't lose

Re: [Qemu-devel] [RFC v2] target-arm: provide skeleton for a64 insn decoding

2013-11-13 Thread Laurent Desnogues
On Tue, Nov 12, 2013 at 2:29 PM, Claudio Fontana wrote: > provide a skeleton for a64 instruction decoding in translate-a64.c, > by dividing instructions into the classes defined by the > ARM Architecture Reference Manual(DDI0487A_a) C3 > > Signed-off-by: Claudio Fontana > Signed-off-by: Alex Benn

Re: [Qemu-devel] [PATCH] qemu-iotests: Use cache=writeback in drive_add

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 13:27 hat Fam Zheng geschrieben: > This will allow running iotests on tmpfs, which is much faster, so we > can run more tests. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/iotests.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

2013-11-13 Thread Igor Mammedov
On Tue, 12 Nov 2013 19:16:37 -0200 Marcelo Tosatti wrote: > > v2: condition enablement of new mapping to new machine types (Paolo) > v3: fix changelog > v4: rebase > v5: ensure alignment of piecetwo on 2MB GPA (Igor) > do not register zero-sized piece-one(Igor) > v6: fix memory leak

Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out qemu-io prompt in 035

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 13:40 hat Fam Zheng geschrieben: > This change is manually copy&pasted into thunderbird. It has a super > long line to kill `git send-email`, and is wrapped by email > composer. So you need to pull to merge it. 'git send-email --no-validate' worked the last time I has something li

Re: [Qemu-devel] [PATCH v2] curses: fixup SIGWINCH handler mess

2013-11-13 Thread Laszlo Ersek
On 11/13/13 10:23, Gerd Hoffmann wrote: > Don't run code in the signal handler, only set a flag. > Use sigaction(2) to avoid non-portable signal(2) semantics. > Make #ifdefs less messy. > > Signed-off-by: Gerd Hoffmann > --- > ui/curses.c | 44 > 1 fi

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-13 Thread Peter Lieven
Am 13.11.2013 um 10:44 schrieb Paolo Bonzini : > Il 13/11/2013 07:29, Peter Lieven ha scritto: >> Wouldn't it be good to add bdi->can_write_zeroes_with_unmap here as well? > > We do: > >> +bdi->unallocated_blocks_are_zero = s->discard_zeroes; >> +bdi->can_write_zeroes_with_unmap = s->di

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. > > Signed-off-by: Fam Zheng > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..931d710 10

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-13 Thread Bret Ketchum
Had trouble with this one: git apply --verbos --check ../ipmi-patches/290708.mbox Checking patch hw/i386/pc.c... Hunk #1 succeeded at 622 (offset 15 lines). error: while searching for: fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)apic_id_limit); fw_cfg_add_i32(fw_cfg, FW_CFG_ID,

Re: [Qemu-devel] [PATCH v3 1/2] block: per caller dirty bitmap

2013-11-13 Thread Fam Zheng
On Wed, Nov 13, 2013 at 6:29 PM, Fam Zheng wrote: > Previously a BlockDriverState has only one dirty bitmap, so only one > caller (e.g. a block job) can keep track of writing. This changes the > dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the > lifecycle is managed with t

Re: [Qemu-devel] [PATCH 00/14] VSX Stage 4

2013-11-13 Thread Tom Musta
On 11/7/2013 6:23 PM, Richard Henderson wrote: > Modulo my comments wrt the actual computation of fma, the patches all look > fine. > > But I'd like to also mention a pre-existing flaw/niggle in the ppc port. > > The conversions to/from in-register representation for the single-precision > value

Re: [Qemu-devel] [PATCH v3 1/2] block: per caller dirty bitmap

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 15:33 hat Fam Zheng geschrieben: > On Wed, Nov 13, 2013 at 6:29 PM, Fam Zheng wrote: > > Previously a BlockDriverState has only one dirty bitmap, so only one > > caller (e.g. a block job) can keep track of writing. This changes the > > dirty bitmap to a list and creates a BdrvDirt

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

2013-11-13 Thread Bret Ketchum
Don't know if it matters much but this patch cannot be applied without the prototype definition in 16/16. On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard wrote: > There was no way to directly add a table entry to the SMBIOS table, > even though the BIOS supports this. So add a function to

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-13 Thread Paolo Bonzini
Il 13/11/2013 15:14, Peter Lieven ha scritto: >>> >> does BLKDISCARDZEROES ioctl guarantee that a device is >>> >> zero initialized or does it just guarantee that a discard may not >>> >> fail and that it reads as zeroes afterwards? >> > >> > Only the latter. ".bdrv_has_zero_init" is only present

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: > Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: >> We have multiple dirty bitmaps in BDS now, switch QAPI to allow query >> it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. >> >> Signed-off-by: Fam Zheng > >> diff --git a/qap

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Paolo Bonzini
Il 13/11/2013 15:19, Kevin Wolf ha scritto: > I believe this is of limited use; if you ever have more than one dirty > bitmap, we're lacking information to associate it with the job it > belongs to. One option would be to extend BlockDirtyInfo to indicate > this, but another might be to actually ex

Re: [Qemu-devel] [PATCH v3] qemu-img: Fix overwriting 'ret' before using

2013-11-13 Thread Eric Blake
On 11/13/2013 05:43 AM, Kevin Wolf wrote: > From: Fam Zheng > > This patch moves ret assignment after reporting original error. > > We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when > I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong" > mismatch offset. This

Re: [Qemu-devel] [PATCH 09/11] raw-posix: implement write_zeroes with MAY_UNMAP for block devices

2013-11-13 Thread Peter Lieven
> Am 13.11.2013 um 15:39 schrieb Paolo Bonzini : > > Il 13/11/2013 15:14, Peter Lieven ha scritto: >> does BLKDISCARDZEROES ioctl guarantee that a device is >> zero initialized or does it just guarantee that a discard may not >> fail and that it reads as zeroes afterwards?

Re: [Qemu-devel] [PATCH 1/5] qemu-img: Convert by cluster size if target is compressed

2013-11-13 Thread Jeff Cody
On Wed, Nov 13, 2013 at 08:53:10AM +0800, Fam Zheng wrote: > If target block driver forces compression, qemu-img convert needs to > write by cluster size as well as "-c" option. > > Particularly, this applies for converting to VMDK streamOptimized > format. > > Signed-off-by: Fam Zheng > --- >

[Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory

2013-11-13 Thread Paul Durrant
The intention of the Xen PV device is that it is used as a parent device for PV drivers in Xen HVM guests and the set of PV drivers that bind to the device is determined by its device ID (and possibly vendor ID and revision). As such, the device should not have a default device ID, it should always

Re: [Qemu-devel] [PATCH 5/5] mirror: Check for bdrv_get_info result

2013-11-13 Thread Jeff Cody
On Wed, Nov 13, 2013 at 08:53:14AM +0800, Fam Zheng wrote: > bdrv_get_info could fail. Add check before using the returned value. > > Signed-off-by: Fam Zheng > --- > block/mirror.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/mirror.c b/block/mirror.c > in

Re: [Qemu-devel] [PATCH 12/16] ipmi: Add documentation

2013-11-13 Thread Bret Ketchum
The actual default I/O address for KCS is 0xca2. On Tue, Nov 12, 2013 at 10:33 AM, Corey Minyard wrote: > Add some basic documentation for the IPMI device. > > Signed-off-by: Corey Minyard > --- > qemu-options.hx | 35 +++ > 1 file changed, 35 insertions(+

[Qemu-devel] [PATCH for-1.7] acpi unit-test: ensure both 1.6 machine and default machine received the same acpi tables

2013-11-13 Thread Marcel Apfelbaum
Machines before 1.6 used ACPI supplied by SeaBios, for 1.7+ machines the tables are build by qemu. This patch checks that both machines have the same ACPI tables. Also checks the signature of FACS table. Signed-off-by: Marcel Apfelbaum --- Note that for the moment we check only that the machines

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

2013-11-13 Thread Jeff Cody
On Wed, Nov 13, 2013 at 10:33:10AM +0100, Stefan Hajnoczi wrote: > There are a number of contributors who maintain block drivers (image > formats and protocols). They should be listed in the MAINTAINERS file > so that get_maintainer.pl lists them. > > Note that commits are still merged through Ke

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-13 Thread Vlad Yasevich
On 11/10/2013 07:11 AM, Michael S. Tsirkin wrote: On Fri, Nov 08, 2013 at 02:42:27PM -0500, Vlad Yasevich wrote: What about this approach? This only updates the monitory when all the bits have been written to. -vlad Thanks! Some comments below. -- >8 -- Subject: [PATCH] e1000/rtl8139: upd

Re: [Qemu-devel] [PATCH 15/16] smbios: Add a function to directly add an entry

2013-11-13 Thread Andreas Färber
Am 13.11.2013 15:37, schrieb Bret Ketchum: > > Don't know if it matters much but this patch cannot be applied > without the prototype definition in 16/16. It does matter for bisecting, thanks for pointing it out! Cheers, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, G

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: add block driver sub-maintainers

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 17:17 hat Jeff Cody geschrieben: > On Wed, Nov 13, 2013 at 10:33:10AM +0100, Stefan Hajnoczi wrote: > > There are a number of contributors who maintain block drivers (image > > formats and protocols). They should be listed in the MAINTAINERS file > > so that get_maintainer.pl list

[Qemu-devel] [Bug 1250360] Re: qcow2 image logical corruption after host crash

2013-11-13 Thread Kevin Wolf
See also https://bugzilla.redhat.com/show_bug.cgi?id=1029344 for some more information ** Bug watch added: Red Hat Bugzilla #1029344 https://bugzilla.redhat.com/show_bug.cgi?id=1029344 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEM

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

2013-11-13 Thread Paolo Bonzini
> assert(piecetwosize <= holesize); > > piecetwosize = MIN(above_4g_mem_size, piecetwosize); > if ((above_4g_mem_size - piecetwosize) > 0) { > memory_region_init_alias(ram_above_4g, NULL, "ram-above-4g", >

Re: [Qemu-devel] [PATCH 0/8 v4] s390-qemu: cpu hotplug

2013-11-13 Thread Jason J. Herne
On 10/31/2013 01:21 PM, Jason J. Herne wrote: Pinging this for review. -- -- Jason J. Herne (jjhe...@linux.vnet.ibm.com)

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qga: Fix compilation for old versions of MinGW

2013-11-13 Thread Stefan Weil
Am 13.11.2013 12:53, schrieb Michael Tokarev: > 10.11.2013 21:49, Stefan Weil wrote: >> While MinGW-w64 can compile the qga code, MinGW from Ubuntu lenny >> (gcc-mingw32 4.4.2-3) shows these errors: > I guess you mean Debian lenny, not Ubuntu lenny here ;) And lenny > is an "old-old-stable" Debian

Re: [Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

2013-11-13 Thread Stefan Weil
Am 13.11.2013 14:01, schrieb Michael Tokarev: > Here's a next trivial-patches pull request, for patches collected > in almost 3 weeks. > > There's nothing extra-ordinary here, except of one thing: this is > keyboard maps handling series by Jan Krupa. While I don't expect > any breakage in this are

Re: [Qemu-devel] [PATCH] xen-pvdevice: make device-id property compulsory

2013-11-13 Thread Stefano Stabellini
On Wed, 13 Nov 2013, Paul Durrant wrote: > The intention of the Xen PV device is that it is used as a parent > device for PV drivers in Xen HVM guests and the set of PV drivers that > bind to the device is determined by its device ID (and possibly > vendor ID and revision). As such, the device shou

Re: [Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

2013-11-13 Thread Michael Tokarev
13.11.2013 22:05, Stefan Weil wrote: [] > The two trace.h related patches moved include statements from .h files > to .c files. > I compiled the resulting code on 64 bit Linux, also with cross > compilation for > MinGW, so win* won't be a problem. > > Nevertheless there remains a risk because my b

Re: [Qemu-devel] [PATCH 05/11] scsi-disk: reject ANCHOR=1 for UNMAP and WRITE SAME commands

2013-11-13 Thread Eric Blake
On 11/12/2013 08:49 AM, Paolo Bonzini wrote: > Since we report ANC_SUP==0 in VPD page B2h, we need to return > an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME > requests with ANCHOR==1. > > Inspired by a similar patch to the LIO in-kernel target. > > Signed-off-by: Paolo Bonzin

Re: [Qemu-devel] i386: pc: align gpa<->hpa on 1GB boundary (v6)

2013-11-13 Thread Michael S. Tsirkin
On Tue, Nov 12, 2013 at 07:16:37PM -0200, Marcelo Tosatti wrote: > > v2: condition enablement of new mapping to new machine types (Paolo) > v3: fix changelog > v4: rebase > v5: ensure alignment of piecetwo on 2MB GPA (Igor) > do not register zero-sized piece-one(Igor) > v6: fix memory leak

Re: [Qemu-devel] [PULL 00/16] [for-1.7] Trivial patches for 2013-11-13

2013-11-13 Thread Stefan Weil
Am 13.11.2013 19:24, schrieb Michael Tokarev: > 13.11.2013 22:05, Stefan Weil wrote: [] >> The two trace.h related patches moved include statements from .h >> files to .c files. I compiled the resulting code on 64 bit Linux, >> also with cross compilation for MinGW, so win* won't be a problem. >> N

[Qemu-devel] [PATCH v2 2/7] exec: replace leaf with skip

2013-11-13 Thread Michael S. Tsirkin
In preparation for dynamic radix tree depth support, rename is_leaf field to skip, telling us how many bits to skip to next level. Set to 0 for leaf. Signed-off-by: Michael S. Tsirkin --- exec.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c

[Qemu-devel] [PATCH v2 4/7] exec: pass hw address to phys_page_find

2013-11-13 Thread Michael S. Tsirkin
callers always shift by target page bits so let's just do this internally. Signed-off-by: Michael S. Tsirkin --- exec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index ec46aea..edb577f 100644 --- a/exec.c +++ b/exec.c @@ -216,10 +216,11 @@ static

[Qemu-devel] [PATCH v2 7/7] exec: reduce L2_PAGE_SIZE

2013-11-13 Thread Michael S. Tsirkin
With the single exception of ppc with 16M pages, we get the same number of levels with L2_PAGE_SIZE = 10 as with L2_PAGE_SIZE = 9. by doing this we reduce memory footprint of a single level in the node memory map by 2x without runtime overhead. Signed-off-by: Michael S. Tsirkin --- exec.c | 2 +

[Qemu-devel] [PATCH v2 0/7] making address spaces 64 bit wide

2013-11-13 Thread Michael S. Tsirkin
At the moment, exec ignores high bits in each address, for efficiency. This is incorrect: devices can do full 64 bit DMA, it's only the CPU that is limited by target address space. Resolving such addresses can actually corrupt the pagetables, so using full 64 bit addresses is called for. However,

[Qemu-devel] [PATCH] pc: add 1.8 machine type

2013-11-13 Thread Michael S. Tsirkin
I already have several patches that affect compatibility between 1.8 and 1.7 queued, so we need pc compat structures in place. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 27 +++ hw/i386/pc_q35.c | 24 ++-- 2 files changed, 45 insertions

[Qemu-devel] [PATCH v2 6/7] exec: make address spaces 64-bit wide

2013-11-13 Thread Michael S. Tsirkin
From: Paolo Bonzini As an alternative to commit 818f86b (exec: limit system memory size, 2013-11-04) let's just make all address spaces 64-bit wide. This eliminates problems with phys_page_find ignoring bits above TARGET_PHYS_ADDR_SPACE_BITS and address_space_translate_internal consequently messi

Re: [Qemu-devel] [PATCH for-1.7] acpi unit-test: add signatures and checksum verification

2013-11-13 Thread Michael S. Tsirkin
On Tue, Nov 12, 2013 at 06:32:24PM +0200, Marcel Apfelbaum wrote: > Loaded all ACPI tables from guest, making > a good environment for further unit tests. > > Checked that ACPI tables are corrected pointed > within the ACPI tree using their signatures. > Verified checksum for all the tables. > >

[Qemu-devel] [PATCH v2 5/7] exec: memory radix tree page level compression

2013-11-13 Thread Michael S. Tsirkin
At the moment, memory radix tree is already variable width, but it can only skip the low bits of address. This is efficient if we have huge memory regions but inefficient if we are only using a tiny portion of the address space. After we have built up the map, detect configurations where a single

[Qemu-devel] [PATCH] block/stream: Don't stream unbacked devices

2013-11-13 Thread Max Reitz
If a block device is unbacked, a streaming blockjob should immediately finish instead of beginning to try to stream, then noticing the backing file does not contain even the first sector (since it does not exist) and then finishing normally. Signed-off-by: Max Reitz --- block/stream.c | 5 +

  1   2   >