[Qemu-devel] [PATCH V6 5/6] blkdebug: add debug events for snapshot

2013-11-11 Thread Wenchao Xia
Some code in qcow2-snapshot.c directly accesses bs->file, so in those places errors can't be injected by other events. Since the code in qcow2-snapshot.c is similar to the other qcow2 internal code (in regards to e.g. the L1 table), add some debug events. Signed-off-by: Wenchao Xia Reviewed-by: M

[Qemu-devel] [PATCH V6 4/6] qcow2: cancel the modification on fail in qcow2_snapshot_create()

2013-11-11 Thread Wenchao Xia
Signed-off-by: Wenchao Xia Reviewed-by: Max Reitz --- block/qcow2-snapshot.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 70e329e..685ef8b 100644 --- a/block/qcow2-snapshot.c +++ b/block/qc

[Qemu-devel] [PATCH V6 0/6] qcow2: rollback the modification on fail in snapshot creation

2013-11-11 Thread Wenchao Xia
V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn->l1size correctly in qcow2_free_cluster(). 4-7: add test case to verify the error paths. Other: 1: new patch fix a existing bug,

[Qemu-devel] [PATCH v2 0/3] Device tree cleanups

2013-11-11 Thread peter . crosthwaite
From: Peter Crosthwaite Fix the name stem of the devicetree API (P1 - s/qemu_devtree/qemu_fdt) and cleanup error report (P3). Trivial patch P2 fixing an arugment name along the way. Tested using: 1: Alex's e500 test vector. 2: Xilinx Zynq (tests arm/boot.c). I have testing using Zynq with Mem

[Qemu-devel] [PATCH v2 1/3] device_tree: s/qemu_devtree/qemu_fdt globally

2013-11-11 Thread peter . crosthwaite
From: Peter Crosthwaite The qemu_devtree API is a wrapper around the fdt_ set of APIs. Rename accordingly. Signed-off-by: Peter Crosthwaite --- device_tree.c| 62 ++--- hw/arm/boot.c| 24 ++--- hw/arm/vexpress.c| 18 ++-- hw/microblaze/bo

[Qemu-devel] [PATCH v2 2/3] device_tree: qemu_fdt_setprop: Rename val_array arg

2013-11-11 Thread peter . crosthwaite
From: Peter Crosthwaite Looking at the implementation, this doesn't really have a lot to do with arrays. Its just a pointer to a buffer and is passed through to the wrapped fn (qemu_fdt_setprop) unchanged. So rename to make it consistent with libfdt, which in the wrapped function just calls it "v

[Qemu-devel] [PATCH v2 3/3] device_tree: qemu_fdt_setprop: Fixup error reporting

2013-11-11 Thread peter . crosthwaite
From: Peter Crosthwaite There are a mix of usages of the qemu_fdt_* API calls, some which wish to assert and abort QEMU on failure and some of which wish to do their own error handling. The latter in more correct, but the former is in the majority and more pragmatic. However the asserting clients

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-11-11 Thread Gerd Hoffmann
On Fr, 2013-11-08 at 17:51 +0100, Jan Kiszka wrote: > On 2013-11-08 16:39, Gerd Hoffmann wrote: > > Hi, > > > >> OK, then here is the first issue I ran into while trying libusbx (git > >> head, i.e. 1.0.17+: The new stack causes significant latency issues that > >> makes it almost unusable for p

Re: [Qemu-devel] Buildbot failures (MinGW)

2013-11-11 Thread Gerd Hoffmann
On So, 2013-11-10 at 19:25 +0100, Stefan Weil wrote: > Hello Gerd, > > could you please install bison and flex on the buildbot machine for > default_mingw? Done. cheers, Gerd

Re: [Qemu-devel] [RFC PATCH] i386: Add _PXM method to ACPI CPU objects

2013-11-11 Thread Igor Mammedov
On Sun, 10 Nov 2013 12:36:29 +0200 "Michael S. Tsirkin" wrote: > On Fri, Nov 08, 2013 at 06:33:12PM +0100, Igor Mammedov wrote: > > On Fri, 8 Nov 2013 12:22:12 +0200 > > Vasilis Liaskovitis wrote: > > > > > Hi, > > > > > > On Thu, Nov 07, 2013 at 03:03:42PM +0200, Michael S. Tsirkin wrote: > >

Re: [Qemu-devel] Buildbot failures (XEN)

2013-11-11 Thread Stefan Hajnoczi
On Sun, Nov 10, 2013 at 05:07:03PM +0100, Stefan Weil wrote: > could you please have a look at these buildbots (maybe others, too): > > xen_i386_debian_6_0 > xen_x86_64_debian_6_0 > > Both fail during the configuration: > > ERROR: unknown option --disable-debug-info fetching branch xen-next fro

Re: [Qemu-devel] [PATCH] ui/sdl2 : initial port to SDL 2.0

2013-11-11 Thread Dave Airlie
On Mon, Nov 11, 2013 at 2:02 PM, Anthony Liguori wrote: > On Sun, Nov 10, 2013 at 3:15 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. >> >> The biggest changes were in the input handling, where SDL2 has done a major

Re: [Qemu-devel] [PATCH] console: Remove unused debug code

2013-11-11 Thread Gerd Hoffmann
On So, 2013-11-10 at 15:58 +0100, Stefan Weil wrote: > The local function console_print_text_attributes is no longer used > since > commit 7d6ba01c3741bc32ae252bf64a5fd3f930c2df4f. Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH] console: Replace conditional debug messages by trace methods

2013-11-11 Thread Gerd Hoffmann
On So, 2013-11-10 at 16:04 +0100, Stefan Weil wrote: > +console_putchar_csi(int esc_param0, int esc_param1, int ch, int > nb_esc_params) "escape sequence CSI%d;%d%c, %d parameters" > +console_putchar_unhandled(int ch) "unhandled escape character '%c'" Reviewed-by: Gerd Hoffmann cheers, Gerd

Re: [Qemu-devel] [PATCH v2] e1000: initial link negotiation on mac osx

2013-11-11 Thread Stefan Hajnoczi
On Fri, Nov 08, 2013 at 10:52:09AM -0500, Gabriel L. Somlo wrote: > On Fri, Nov 08, 2013 at 02:39:25PM +0100, Stefan Hajnoczi wrote: > > On Fri, Nov 08, 2013 at 12:12:52AM +0100, Alexander Graf wrote: > >> We can easily modify SeaBIOS to just loop through all PCI devices, > >> look for an e1000 and

Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed

2013-11-11 Thread Stefan Hajnoczi
On Fri, Nov 08, 2013 at 11:26:49AM +0800, Fam Zheng wrote: > If backing file doesn't exist, the error message is confusing and > misleading: > > $ qemu /tmp/a.qcow2 > qemu: could not open disk image /tmp/a.qcow2: Could not open file: No > such file or directory > > But... > > $ l

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Matthias Brugger
2013/11/5 Stefan Hajnoczi : > On Mon, Nov 04, 2013 at 11:28:41AM +0100, Matthias Brugger wrote: >> v2: >> - fix issues found by checkpatch.pl >> - change the descritpion of patch 3 >> >> This patch series makes the thread pool implementation modular. >> This allows each drive to use a special imp

Re: [Qemu-devel] [PATCH 2/2] exec: make address spaces 64-bit wide

2013-11-11 Thread Paolo Bonzini
Il 10/11/2013 11:31, Michael S. Tsirkin ha scritto: > > Reported-by: Luiz Capitulino > > Signed-off-by: Paolo Bonzini > > So this causes a 12% performance regression on some TCG > tests, I think we should look into a smarter > datastructure to solve the issues. It causes a 12% performance regre

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 04, 2013 at 11:55:47AM +0100, Paolo Bonzini wrote: > Il 04/11/2013 11:47, Fam Zheng ha scritto: > >>> > >>> -void bdrv_set_dirty_tracking(BlockDriverState *bs, int granularity); > >>> -int bdrv_get_dirty(BlockDriverState *bs, int64_t sector); > >>> +typedef struct BdrvDirtyBitmap BdrvDi

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 04, 2013 at 05:30:10PM +0800, Fam Zheng wrote: > @@ -2785,9 +2792,7 @@ static int coroutine_fn > bdrv_co_do_writev(BlockDriverState *bs, > ret = bdrv_co_flush(bs); > } > > -if (bs->dirty_bitmap) { > bdrv_set_dirty(bs, sector_num, nb_sectors); > -} Forg

Re: [Qemu-devel] [PATCH v2] block: per caller dirty bitmap

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 04, 2013 at 05:30:10PM +0800, Fam Zheng wrote: > Previously a BlockDriverState has only one dirty bitmap, so only one > caller (e.g. a block job) can keep track of writing. This changes the > dirty bitmap to a list and creates a BdrvDirtyBitmap for each caller, the > lifecycle is manage

Re: [Qemu-devel] [PATCH] ui/sdl2 : initial port to SDL 2.0

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 10:10, Dave Airlie ha scritto: >> > It's very hard to review ATM due to the split. > No I talked to enough people at kvmforum and everyone said I should > split this into a separate file, please don't make me undo that now, I > originally did it with ifdefs and just spent a few days r

Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

2013-11-11 Thread Andreas Färber
Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > This adds a macro to calculate the highest bit set. Isn't that already available as ffs / clz GCC builtin with wrapper in qemu/bitops.h? What's the difference to your macro? CC'ing Paolo. Andreas > If used on constant > values, no code will be

Re: [Qemu-devel] [PATCH v3 5/6] bitops: add BITNR macro

2013-11-11 Thread Alexey Kardashevskiy
On 11/11/2013 10:57 PM, Andreas Färber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: >> This adds a macro to calculate the highest bit set. > > Isn't that already available as ffs / clz GCC builtin with wrapper in > qemu/bitops.h? What's the difference to your macro? CC'ing Paolo. >

Re: [Qemu-devel] [PATCH v2 1/3] Make thread pool implementation modular

2013-11-11 Thread Kevin Wolf
Am 04.11.2013 um 11:28 hat Matthias Brugger geschrieben: > This patch introduces function pointers for the thread pool, so that > it's implementation can be set at run-time. > > Signed-off-by: Matthias Brugger Like Stefan said, this can really only be given a meaningful review in context with an

Re: [Qemu-devel] [PATCH v2 3/3] Add workerthreads configuration option

2013-11-11 Thread Kevin Wolf
Am 04.11.2013 um 11:28 hat Matthias Brugger geschrieben: > This patch allows to choose at the command line level which thread pool > implementation will be used by every block device. > > Signed-off-by: Matthias Brugger This would require a change to blockdev-add in qapi-schema.json in order to

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-11 Thread Andreas Färber
Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > This converts +foo/-foo to "foo=on"/"foo=off" respectively when > QEMU parser is used for the command line options. > > "-cpu" parsers in x86 and other architectures should be unaffected > by this change. > > Signed-off-by: Alexey Kardashevskiy

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 11:00:45AM +0100, Matthias Brugger wrote: > 2013/11/5 Stefan Hajnoczi : > > I'd also like to see the thread pool implementation you wish to add > > before we add a layer of indirection which has no users yet. > > Fair enough, I will evaluate if it will make more sense to im

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-11 Thread Jan Kiszka
On 2013-11-11 13:41, Andreas Färber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: >> This converts +foo/-foo to "foo=on"/"foo=off" respectively when >> QEMU parser is used for the command line options. >> >> "-cpu" parsers in x86 and other architectures should be unaffected >> by this

Re: [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard

2013-11-11 Thread Kevin Wolf
Am 24.10.2013 um 12:06 hat Peter Lieven geschrieben: > Reviewed-by: Eric Blake > Signed-off-by: Peter Lieven > --- > block.c | 37 - > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/block.c b/block.c > index 0c0b0ac..b28dd42 100644 > --- a

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-11 Thread Andreas Färber
Am 11.11.2013 13:52, schrieb Jan Kiszka: > On 2013-11-11 13:41, Andreas Färber wrote: >> Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: >>> This converts +foo/-foo to "foo=on"/"foo=off" respectively when >>> QEMU parser is used for the command line options. >>> >>> "-cpu" parsers in x86 and oth

Re: [Qemu-devel] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property

2013-11-11 Thread Andreas Färber
Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > This patch is to demonstrate a static property handling in PowerPC. > Running QEMU with -cpu host,-vsx disables VSX bit in > PowerPCCPU::env::flags. > > Signed-off-by: Alexey Kardashevskiy > --- > target-ppc/translate_init.c | 7 +++ > 1 f

[Qemu-devel] [PATCH] block: Fail if requested driver is not available

2013-11-11 Thread Kevin Wolf
If an explicit driver option is present, but doesn't specify a valid driver, then bdrv_open() should fail instead of probing the format. Signed-off-by: Kevin Wolf --- block.c| 5 + tests/qemu-iotests/051 | 7 +++ tests/qemu-iotests/051.out | 9 + 3 files c

Re: [Qemu-devel] [PATCH] ui/sdl2 : initial port to SDL 2.0

2013-11-11 Thread Anthony Liguori
On Nov 11, 2013 1:10 AM, "Dave Airlie" wrote: > > On Mon, Nov 11, 2013 at 2:02 PM, Anthony Liguori wrote: > > On Sun, Nov 10, 2013 at 3:15 PM, Dave Airlie wrote: > >> From: Dave Airlie > >> > >> I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. > >> > >> The biggest

Re: [Qemu-devel] [PATCH] block: Fail if requested driver is not available

2013-11-11 Thread Jeff Cody
On Mon, Nov 11, 2013 at 02:54:59PM +0100, Kevin Wolf wrote: > If an explicit driver option is present, but doesn't specify a valid > driver, then bdrv_open() should fail instead of probing the format. > > Signed-off-by: Kevin Wolf > --- > block.c| 5 + > tests/qemu-iotest

Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments

2013-11-11 Thread Igor Mammedov
On Mon, 11 Nov 2013 13:41:05 +0100 Andreas Färber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: > > This converts +foo/-foo to "foo=on"/"foo=off" respectively when > > QEMU parser is used for the command line options. > > > > "-cpu" parsers in x86 and other architectures should be

[Qemu-devel] xsave instruction not passed through correctly on AMD hardware

2013-11-11 Thread Owen Tuz
Hi all, We've been seeing a problem lately running FreeBSD 9.1 and 9.2 (latest stable) which causes the guest to crash during boot when QEMU is run on an AMD processor with the 'xsave' flag set. To reproduce this behaviour: - Boot a FreeBSD 9.1 or 9.2 guest or even installation CD on an AMD proc

Re: [Qemu-devel] [PATCH for-1.7 v2] block: Print its file name if backing file opening failed

2013-11-11 Thread Kevin Wolf
Am 08.11.2013 um 04:26 hat Fam Zheng geschrieben: > If backing file doesn't exist, the error message is confusing and > misleading: > > $ qemu /tmp/a.qcow2 > qemu: could not open disk image /tmp/a.qcow2: Could not open file: No > such file or directory > > But... > > $ ls /tmp/a.

Re: [Qemu-devel] [PATCH v2] flatload: fix non-GOT relocations

2013-11-11 Thread Corey Boyle
Ping http://patchwork.ozlabs.org/patch/280764/ On Sat, Oct 5, 2013 at 7:46 AM, Corey J. Boyle wrote: > From: "Corey J. Boyle" > > Use target address rather than host address when performing > non-GOT relocations > > Signed-off-by: Corey J. Boyle > --- > linux-user/flatload.c |2 +- > 1

Re: [Qemu-devel] Questions about Spice pv domUs

2013-11-11 Thread Stefano Stabellini
On Thu, 7 Nov 2013, Fabio Fantoni wrote: > > The xenfb code is here: > > > > hw/display/xenfb.c > > > > It is registered here: > > > > hw/i386/xen_machine_pv.c:xen_init_pv > > Thanks, then I must search on qemu code what xenstore parameters enable xenfb > and after search on xen, right? Yes, o

[Qemu-devel] [RFC] target-arm: provide skeleton for a64 insn decoding

2013-11-11 Thread Claudio Fontana
provide a skeleton for a64 instruction decoding in translate-a64.c, by dividing instructions into the classes defined by the ARM Architecture Reference Manual(DDI0487A_a) C3 Signed-off-by: Claudio Fontana --- The following patch has been started during Linaro Connect by me and Alex Bennee. The go

Re: [Qemu-devel] xsave instruction not passed through correctly on AMD hardware

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 15:30, Owen Tuz ha scritto: > Hi all, > > We've been seeing a problem lately running FreeBSD 9.1 and 9.2 (latest > stable) which causes the guest to crash during boot when QEMU is run on > an AMD processor with the 'xsave' flag set. > > To reproduce this behaviour: > > - Boot a Fr

Re: [Qemu-devel] xsave instruction not passed through correctly on AMD hardware

2013-11-11 Thread Owen Tuz
Thanks, Paolo. We will test and let you know. I'm not familiar with LWP (some reading to do there) - are there any plans to support this in future, or is this just something that we're not interested in emulating? Best regards, Owen On Mon, Nov 11, 2013 at 3:25 PM, Paolo Bonzini wrote: > Il 1

[Qemu-devel] [Bug 1243287] Re: [KVM/QEMU][ARM][SAUCY] fails to boot cloud-image due to host kvm fail

2013-11-11 Thread Peter Maydell
dmidecode itself should probably be checking at runtime what cpu architecture it is running on so it can refuse to read /dev/mem on systems which it doesn't know it understands. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

[Qemu-devel] [PULL 1/6] Fix pc migration from qemu <= 1.5

2013-11-11 Thread Michael S. Tsirkin
From: Cole Robinson The following commit introduced a migration incompatibility: commit 568f0690fd9aa4d39d84b04c1a5dbb53a915c3fe Author: David Gibson Date: Thu Jun 6 18:48:49 2013 +1000 pci: Replace pci_find_domain() with more general pci_root_bus_path() The issue is that i440fx savevm

[Qemu-devel] [PULL 5/6] Revert "hw/pci: partially handle pci master abort"

2013-11-11 Thread Michael S. Tsirkin
From: Marcel Apfelbaum This reverts commit a53ae8e934cd54686875b5bcfc2f434244ee55d6. The patch being reverted introduced a low-priority memory region covering all 64 bit pci address space. This exposed the following bugs elsewhere in the code: 1. Some memory regions have INT64_MAX size, where

[Qemu-devel] [PULL 0/6] pci, pc, virtio bug fixes for 1.7

2013-11-11 Thread Michael S. Tsirkin
The following changes since commit c2d30667760e3d7b81290d801e567d4f758825ca: rtc: remove dead SQW IRQ code (2013-11-05 20:04:03 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to ef9e455d645bed6d2

[Qemu-devel] [PULL 6/6] Revert "exec: limit system memory size"

2013-11-11 Thread Michael S. Tsirkin
This reverts commit 818f86b88394b7b2b59d313e51043fe15a8004db. This was a work-around for bugs elsewhere in the system, exposed by commit a53ae8e934cd54686875b5bcfc2f434244ee55d6: "hw/pci: partially handle pci master abort" since that's reverted now, the work-around is not required for 1.7 anym

Re: [Qemu-devel] [PATCH v3 0/2] block/drive-mirror: Check for NULL backing_hd

2013-11-11 Thread Kevin Wolf
Am 06.11.2013 um 19:50 hat Max Reitz geschrieben: > It should be possible to execute the QMP "drive-mirror" command in > "none" sync mode and "absolute-paths" mode even for block devices > lacking a backing file. > > "absolute-paths" does in fact not require a backing file to be present, > as can

[Qemu-devel] [PULL 3/6] acpi-build: disable with -no-acpi

2013-11-11 Thread Michael S. Tsirkin
QEMU will currently crash if started with -no-acpi flag since acpi build code probes the PM device which isn't present in this configuration. To fix, don't expose ACPI tables to guest when acpi has been disabled from command line. Fixes LP# 1248854 https://bugs.launchpad.net/qemu/+bug/1248854 Re

Re: [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode

2013-11-11 Thread Kevin Wolf
Am 07.11.2013 um 19:47 hat Max Reitz geschrieben: > If the NewImageMode is "absolute-paths" but no backing file is available > (e.g., when mirroring a device with an unbacked image), the target image > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly

[Qemu-devel] [PULL 2/6] virtio-net: only delete bh that existed

2013-11-11 Thread Michael S. Tsirkin
From: Jason Wang We delete without check whether it existed during exit. This will lead NULL pointer deference since it was created conditionally depends on guest driver status and features. So add a check of existence before trying to delete it. Cc: qemu-sta...@nongnu.org Signed-off-by: Jason W

[Qemu-devel] [PULL 4/6] loader: drop return value for rom_add_blob_fixed

2013-11-11 Thread Michael S. Tsirkin
rom_add_blob never fails, and neither does rom_add_blob_fixed, so there's no need to return value from it. In fact, rom_add_blob_fixed was erroneously returning -1 unconditionally which made the only system that checked the return value -M bamboo fail to start. Drop the return value and drop chec

Re: [Qemu-devel] [PATCH] MAINTAINERS: add block tree repo URLs

2013-11-11 Thread Kevin Wolf
Am 06.11.2013 um 16:06 hat Stefan Hajnoczi geschrieben: > Signed-off-by: Stefan Hajnoczi > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 77edacf..6c63548 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -639,6 +639,8 @@ S: Suppo

[Qemu-devel] [PATCH RFC 4/5] exec: extend skip field to 3 bits

2013-11-11 Thread Michael S. Tsirkin
13 bits left for pointer, which seems enough. Signed-off-by: Michael S. Tsirkin --- exec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 7e512db..39f76ee 100644 --- a/exec.c +++ b/exec.c @@ -84,9 +84,9 @@ typedef struct PhysPageEntry PhysPageEntr

[Qemu-devel] [PATCH RFC 2/5] exec: make address spaces 64-bit wide

2013-11-11 Thread Michael S. Tsirkin
From: Paolo Bonzini As an alternative to commit 818f86b (exec: limit system memory size, 2013-11-04) let's just make all address spaces 64-bit wide. This eliminates problems with phys_page_find ignoring bits above TARGET_PHYS_ADDR_SPACE_BITS and address_space_translate_internal consequently messi

[Qemu-devel] [PATCH RFC 3/5] exec: relace leaf with skip

2013-11-11 Thread Michael S. Tsirkin
In preparation for dynamic page support, rename is_leaf field to skip, telling us how many bits to skip to next level. Set to 0 for leaf. Signed-off-by: Michael S. Tsirkin --- exec.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index d5ce3

[Qemu-devel] [PATCH RFC 1/5] split definitions for exec.c and translate-all.c radix trees

2013-11-11 Thread Michael S. Tsirkin
From: Paolo Bonzini The exec.c and translate-all.c radix trees are quite different, and the exec.c one in particular is not limited to the CPU---it can be used also by devices that do DMA, and in that case the address space is not limited to TARGET_PHYS_ADDR_SPACE_BITS bits. We want to make exec

[Qemu-devel] [PATCH RFC 5/5] exec: memory radix tree page level compression

2013-11-11 Thread Michael S. Tsirkin
At the moment, memory radix tree is already variable width, but it can only skip the low bits of address. This is efficient if we have huge memory regions but inefficient if we are only using a tiny portion of the address space. After we have built up the map, it's a simple matter to detect confi

Re: [Qemu-devel] [PATCH v3 0/2] COW: Speed up writes

2013-11-11 Thread Kevin Wolf
Am 06.11.2013 um 16:59 hat Charlie Shepherd geschrieben: > v3: > - Refix cow_update_bitmap and squash patches 1 & 3 together to ensuring > that we only flush if > necessary, patch 1 on its own would change this causing a regression. > v2: > - Fix bit position calculations in cow_update_bit

Re: [Qemu-devel] [PATCH 0/2] exec: alternative fix for master abort woes

2013-11-11 Thread Michael S. Tsirkin
On Thu, Nov 07, 2013 at 06:29:40PM +0100, Paolo Bonzini wrote: > Il 07/11/2013 17:47, Michael S. Tsirkin ha scritto: > > That's on kvm with 52 bit address. > > But where I would be concerned is systems with e.g. 36 bit address > > space where we are doubling the cost of the lookup. > > E.g. try i38

[Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Eric Blake
Quick - identify the bug in this code (from ui/curses.c): static void curses_winch_handler(int signum) { struct winsize { unsigned short ws_row; unsigned short ws_col; unsigned short ws_xpixel; /* unused */ unsigned short ws_ypixel; /* unused */ } ws;

Re: [Qemu-devel] [PATCH RFC 0/5] making address spaces 64 bit wide

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 17:40, Michael S. Tsirkin ha scritto: > At the moment, exec ignores high bits in each address, > for efficiency. > This is incorrect: devices can do full 64 bit DMA, it's > only the CPU that is limited by target address space. > Using full 64 bit addresses was clocked at 12% performan

[Qemu-devel] [PATCH v2 02/19] bsd-user: add HOST_ABI_DIR for the various *BSD dependent code.

2013-11-11 Thread Stacey Son
This change adds HOST_ABI_DIR (similar to TARGET_ABI_DIR) so the various BSD OS dependent code can be seperated into its own directories rather than using #ifdef's. Signed-off-by: Stacey Son --- Makefile.target |3 ++- configure | 11 +++ 2 files changed, 13 insertions(+), 1

Re: [Qemu-devel] xsave instruction not passed through correctly on AMD hardware

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 16:43, Owen Tuz ha scritto: > Thanks, Paolo. We will test and let you know. > I'm not familiar with LWP (some reading to do there) - are there any > plans to support this in future, or is this just something that we're > not interested in emulating? Given Linux does not support LWP,

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Anthony Liguori
On Mon, Nov 11, 2013 at 8:50 AM, Eric Blake wrote: > Quick - identify the bug in this code (from ui/curses.c): > > static void curses_winch_handler(int signum) > { > struct winsize { > unsigned short ws_row; > unsigned short ws_col; > unsigned short ws_xpixel; /* unus

[Qemu-devel] [PATCH v2 10/19] bsd-user: add support for file system related system calls

2013-11-11 Thread Stacey Son
This change adds support or stubs for file system (except stat) related system calls including read(2), pread(2), readv(2), write(2), pwrite(2), writev(2), pwritev(2), open(2), openat(2), close(2), closefrom(2), revoke(2), access(2), eaccess(2), faccessat(2), chdir(2), fchdir(2), rename(2), rename

[Qemu-devel] [PATCH v2 00/19] bsd-user: Add system call and mips/arm support.

2013-11-11 Thread Stacey Son
[v2] - Rebases to 1.7.0-rc0. (Requires, however, Andreas Tobler's patch to build: see http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg0.html) - Fixes deadlock in the _umtx_op() system call handler. - Fixes race condition in mmap() system call handler. - Makes qemu-mips (o32) usa

[Qemu-devel] [PATCH v2 11/19] bsd-user: add support for stat, directory, and file control related system calls

2013-11-11 Thread Stacey Son
This change adds support or stubs for stat, directory, and file control related system calls including stat(2), lstat(2), fstat(2), fstatat(2), nstat(), nfstat(), nlstat(), getfh(2), lgetfh(2), fhopen(2), fhstat(2), fhstatfs(2), statfs(2), fstatfs(2), getfsstat(2), getdents(2), getdirentries(2), a

[Qemu-devel] [PATCH v2 01/19] bsd-user: refresh freebsd system call numbers

2013-11-11 Thread Stacey Son
Update FreeBSD system call numbers in freebsd/syscall_nr.h. Reviewed-by: Ed Maste Signed-off-by: Stacey Son --- bsd-user/freebsd/syscall_nr.h | 813 ++--- 1 files changed, 445 insertions(+), 368 deletions(-) diff --git a/bsd-user/freebsd/syscall_nr.h b/bsd-

[Qemu-devel] [PATCH v2 13/19] bsd-user: add support for socket related system calls

2013-11-11 Thread Stacey Son
This change adds support or stubs for socket related system calls including accept(2), bind(2), connect(2), getpeername(2), getsockname(2), getsockopt(2), setsockopt(2), listen(2), recvfrom(2), recvmsg(2), sendmsg(2), sendto(2), socket(2), socketpair(2), shutdown(2), setfib(2), sctp_peeloff(2), sct

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 17:56, Anthony Liguori ha scritto: > On Mon, Nov 11, 2013 at 8:50 AM, Eric Blake wrote: >> Quick - identify the bug in this code (from ui/curses.c): >> >> static void curses_winch_handler(int signum) >> { >> struct winsize { >> unsigned short ws_row; >> unsigned s

[Qemu-devel] [PATCH v2 03/19] bsd-user: move OS/arch dependent code for strace into separate directories

2013-11-11 Thread Stacey Son
This change moves host OS and arch dependent code for the sysarch system call related to the -strace functionality into the appropriate HOST_ABI_DIR and TARGET_ABI_DIR directories. Signed-off-by: Stacey Son --- bsd-user/arm/syscall.h | 36 +++ bsd-user/arm/target_arch_sysar

[Qemu-devel] [PATCH v2 16/19] bsd-user: add support for extended attribute and ACL related syscalls

2013-11-11 Thread Stacey Son
This change add support for extended attribute and Access Control List (ACL) related system calls including extattrctl(), extattr_set_file(2), extattr_delete_file(2), extattr_set_fd(2), extattr_get_fd(2), extattr_delete_fd(2), extattr_get_link(2), extattr_set_link(2), extattr_delete_link(2), extatt

[Qemu-devel] [PATCH v2 05/19] bsd-user: move target arch and host OS dependent code out of syscall.c

2013-11-11 Thread Stacey Son
This change moves the system call handler for sysctl(2) and sysarch(2) from syscall.c to the OS and arch dependent directories. This eliminates many of the #ifdef's in syscall.c. These system call handlers are now located in the host os and target arch directories. Signed-off-by: Stacey Son ---

[Qemu-devel] [PATCH v2 19/19] bsd-user: fix linking conflicts with FreeBSD libcrypto

2013-11-11 Thread Stacey Son
FreeBSD has it's own AES_set_decrypt_key, etc. in libcrypto. This change fixes these conflicts and allows statically linking BSD user mode qemu. Signed-off-by: Stacey Son --- include/qemu/aes.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/include/qemu/aes.h b

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 11/11/2013 18:08, Eric Blake ha scritto: >>> That said, aren't all signals in QEMU (except SIG_IPI) caught >>> with signalfd and the handlers run synchronously in the >>> iothread? > signalfd is currently a Linux-only concept - what happens on BSD?

[Qemu-devel] [PATCH v2 12/19] bsd-user: add support for memory management related system calls

2013-11-11 Thread Stacey Son
This change adds support or stubs for memory management related system calls including mmap(2), munmap(2), mprotect(2), msync(2), mlock(2), munlock(2), mlockall(2), munlockall(2), madvise(2), minherit(2), mincore(2), shm_open(2), shm_unlink(2), shmget(2), shmctl(2), shmat(2), shmdt(2), vadvise(), s

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Eric Blake
On 11/11/2013 09:56 AM, Anthony Liguori wrote: >> Here's a hint: ioctl() can clobber errno. But if a signal handler is >> called in the middle of other code that is using errno, then the handler >> MUST restore the value of errno before returning, if it is to guarantee >> that the interrupted con

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Peter Maydell
On 11 November 2013 17:05, Paolo Bonzini wrote: > That said, aren't all signals in QEMU (except SIG_IPI) caught with > signalfd and the handlers run synchronously in the iothread? Eric specifically points out one which is not. (I'm pretty sure that 'reinstall signal handler at end of signal handl

[Qemu-devel] DMA Engine Support

2013-11-11 Thread Forrest Franks
I am working with two DMA engines at the moment. I want to be able to provide guest access to a Crystal Beach DMA engine and a PLX 87xx DMA engine. Are there any current efforts to provide support for these DMA engines? What I have looked at so far indicates that they will need to have a QEMU

[Qemu-devel] [PATCH v2 18/19] bsd-user: add arm, mips and mips64 options to configure target-list

2013-11-11 Thread Stacey Son
This change adds arm-bsd-user, mips-bsd-user, mips64-bsd-user, mips64el-bsd-user, and mipsel-bsd-user as --target-list options to configure. Signed-off-by: Stacey Son --- default-configs/arm-bsd-user.mak |3 +++ default-configs/mips-bsd-user.mak |1 + default-configs/mips64-bsd-

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Peter Maydell
On 11 November 2013 16:56, Anthony Liguori wrote: > On Mon, Nov 11, 2013 at 8:50 AM, Eric Blake wrote: >> Here's a hint: ioctl() can clobber errno. But if a signal handler is >> called in the middle of other code that is using errno, then the handler >> MUST restore the value of errno before ret

Re: [Qemu-devel] [PATCH 0/2] exec: alternative fix for master abort woes

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 17:43, Michael S. Tsirkin ha scritto: > On Thu, Nov 07, 2013 at 06:29:40PM +0100, Paolo Bonzini wrote: >> Il 07/11/2013 17:47, Michael S. Tsirkin ha scritto: >>> That's on kvm with 52 bit address. >>> But where I would be concerned is systems with e.g. 36 bit address >>> space where w

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Eric Blake
On 11/11/2013 10:13 AM, Peter Maydell wrote: > On 11 November 2013 17:05, Paolo Bonzini wrote: >> That said, aren't all signals in QEMU (except SIG_IPI) caught with >> signalfd and the handlers run synchronously in the iothread? > > Eric specifically points out one which is not. > (I'm pretty sur

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 18:13, Peter Maydell ha scritto: >> > That said, aren't all signals in QEMU (except SIG_IPI) caught with >> > signalfd and the handlers run synchronously in the iothread? > Eric specifically points out one which is not. > (I'm pretty sure that 'reinstall signal handler at > end of sig

[Qemu-devel] [PATCH RFC 0/5] making address spaces 64 bit wide

2013-11-11 Thread Michael S. Tsirkin
At the moment, exec ignores high bits in each address, for efficiency. This is incorrect: devices can do full 64 bit DMA, it's only the CPU that is limited by target address space. Using full 64 bit addresses was clocked at 12% performance hit on a microbenchmark. To solve, teach pagetables to skip

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Eric Blake
On 11/11/2013 10:05 AM, Paolo Bonzini wrote: > > That said, aren't all signals in QEMU (except SIG_IPI) caught with > signalfd and the handlers run synchronously in the iothread? signalfd is currently a Linux-only concept - what happens on BSD? -- Eric Blake eblake redhat com+1-919-301-3

Re: [Qemu-devel] [PATCH RFC 5/5] exec: memory radix tree page level compression

2013-11-11 Thread Eric Blake
On 11/11/2013 09:41 AM, Michael S. Tsirkin wrote: > At the moment, memory radix tree is already variable width, but it can > only skip the low bits of address. > > This is efficient if we have huge memory regions but inefficient if we > are only using a tiny portion of the address space. > > Afte

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Alex Bligh
On 11 Nov 2013, at 12:43, Stefan Hajnoczi wrote: > Why is it necessary to push this task down into the host? I don't > understand the advantage of this approach except that maybe it works > around certain misconfigurations, I/O scheduler quirks, or plain old > bugs - all of which should be inves

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 18:59, Alex Bligh ha scritto: > > Why is it necessary to push this task down into the host? I don't > > understand the advantage of this approach except that maybe it works > > around certain misconfigurations, I/O scheduler quirks, or plain old > > bugs - all of which should be inve

Re: [Qemu-devel] audit needed for signal handlers

2013-11-11 Thread Max Filippov
On Mon, Nov 11, 2013 at 8:50 PM, Eric Blake wrote: > Quick - identify the bug in this code (from ui/curses.c): > > static void curses_winch_handler(int signum) > { > struct winsize { > unsigned short ws_row; > unsigned short ws_col; > unsigned short ws_xpixel; /* unus

[Qemu-devel] [PATCH] A hexdump function that also displays UTF-8 strings contained in the dumped buffer.

2013-11-11 Thread Mike Day
This function is used by a forthcomingQemu monitor command that dumps contents of OpenFirmware Device Trees. It dumps contents of a buffer as hex in the same format as the existing function but also also appends any UTF-8 strings in human-readable format. Like the existing hexdump function, this f

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Alex Bligh
On 11 Nov 2013, at 18:01, Paolo Bonzini wrote: > Il 11/11/2013 18:59, Alex Bligh ha scritto: >>> Why is it necessary to push this task down into the host? I don't >>> understand the advantage of this approach except that maybe it works >>> around certain misconfigurations, I/O scheduler quirks,

Re: [Qemu-devel] [PATCH v2 0/3] Make thread pool implementation modular

2013-11-11 Thread Paolo Bonzini
Il 11/11/2013 19:32, Alex Bligh ha scritto: > > On 11 Nov 2013, at 18:01, Paolo Bonzini wrote: > >> Il 11/11/2013 18:59, Alex Bligh ha scritto: Why is it necessary to push this task down into the host? I don't understand the advantage of this approach except that maybe it works ar

Re: [Qemu-devel] [RFC] target-arm: provide skeleton for a64 insn decoding

2013-11-11 Thread Richard Henderson
On 11/12/2013 01:13 AM, Claudio Fontana wrote: > +/* C3.2 Branches, exception generating and system instructions */ > +static void disas_b_exc_sys(DisasContext *s, uint32_t insn) > +{ > +switch (extract32(insn, 25, 7)) { > +case 0x0a: case 0x4a: /* Unconditional branch (immediate) */ > +

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-11-11 Thread Hans de Goede
Hi, On 11/11/2013 09:47 AM, Gerd Hoffmann wrote: On Fr, 2013-11-08 at 17:51 +0100, Jan Kiszka wrote: On 2013-11-08 16:39, Gerd Hoffmann wrote: Hi, OK, then here is the first issue I ran into while trying libusbx (git head, i.e. 1.0.17+: The new stack causes significant latency issues that

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-11 Thread Laszlo Ersek
On 11/11/13 04:28, Phi Debian wrote: > CU82$ /usr/bin/readelf -a vmcore > Program Headers: > Type Offset VirtAddrPhysAddr FileSizMemSiz Flg Align > NOTE 0x74 0x 0x 0x000a0 0x000a0 0 > LOAD 0x000114 0x6000 0x6000 0x4000 0x40

Re: [Qemu-devel] dump-guest-memory enhancement.

2013-11-11 Thread Phi Debian
Hi Laszlo, On Mon, Nov 11, 2013 at 8:38 PM, Laszlo Ersek wrote: > > But first, I think you meant TARGET_PAGE_SIZE, not TARGET_PAGE_BITS, for > the p_align field. > > So, the specs say for p_align: > >> As ``Program Loading'' describes in this chapter of the processor >> supplement, loadable pro

Re: [Qemu-devel] [PATCH] A hexdump function that also displays UTF-8 strings contained in the dumped buffer.

2013-11-11 Thread Anthony Liguori
On Mon, Nov 11, 2013 at 10:29 AM, Mike Day wrote: > This function is used by a forthcomingQemu monitor command that dumps > contents of OpenFirmware Device Trees. It dumps contents of a buffer > as hex in the same format as the existing function but also also > appends any UTF-8 strings in human-r

  1   2   >