This patch mirrors a patch to the Linux uas kernel driver which I've just
submitted. It looks like the qemu uas struct definitions were taken from
the Linux kernel driver, and have inherited the same mistake.
Besides fixing the response iu struct, the patch also drops the add_info
parameter from t
On Wed, Oct 30, 2013 at 04:44:18PM +0100, Andreas Färber wrote:
> Am 30.10.2013 14:54, schrieb Stefan Hajnoczi:
> > v3:
> > * I lost track of this patch, now I'm pushing it again
>
> Part of this series is in a pending qom-next pull of mine (on a
> different base), which Anthony didn't merge due
On Wed, Oct 30, 2013 at 09:22:38PM +0100, Markus Armbruster wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Oct 30, 2013 at 04:18:37PM +0100, Markus Armbruster wrote:
> >> "Michael S. Tsirkin" writes:
> >>
> >> > On Wed, Oct 30, 2013 at 12:29:16PM -0200, Eduardo Habkost wrote:
> >> >> On We
On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote:
> CC to Amos.
>
> On 30/10/13 16:19, whitearchey wrote:
> >
> >In QEMU 1.6 parameters of 'drive' option were removed:
> >
> >QemuOptsList qemu_drive_opts = {
> >.name = "drive",
> >.head = QTAILQ_HEAD_INITIALIZER(qemu_drive_opts.h
On Thu, Oct 31, 2013 at 06:51:50AM +0100, Markus Armbruster wrote:
> Michael Tsirkin doesn't trust us to keep values of QEMUMachine member
> product stable in the future. Use copies instead, and in a way that
> makes it obvious that they're guest ABI.
>
> Note that we can be trusted to keep value
On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote:
> From: Markus Armbruster
>
> A PIIX3/PIIX4 southbridge has multiple functions. We model each
> function as a separate qdev. Two of them need some special wiring set
> up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01
Marcel Apfelbaum writes:
> On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote:
>> From: Markus Armbruster
>>
>> A PIIX3/PIIX4 southbridge has multiple functions. We model each
>> function as a separate qdev. Two of them need some special wiring set
>> up in pc_init1() or mips_malta_in
On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote:
> On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote:
> > This simply imports kvm-unittest git into qemu source tree.
> >
> > We can next work on making make check run it
> > automatically.
> >
> > Squashed 'kvm-unittes
This is not really a patch to accept or review, this is a conversation
starter.
Cc: Badari Pulavarty
Cc: Paul Mackerras
Cc: David Gibson
Cc: Benjamin Herrenschmidt
Cc: Andreas Färber
Signed-off-by: Alexey Kardashevskiy
---
Normall CPUState::cpu_index is used to pick the right CPU for vari
Il 31/10/2013 04:32, Giridhar Maruthy ha scritto:
> On 30 October 2013 22:12, Paolo Bonzini wrote:
>> Il 30/10/2013 15:40, Giridhar Maruthy ha scritto:
>>> Hi All,
>>>
>>> I tried to measure the network performance of guest (mach-virt) with
>>> virtio-net on an ARM host platform (Samsung exynos).
CC Kevin, Paolo
On Thu, Oct 31, 2013 at 04:35:43PM +0800, Amos Kong wrote:
> On Thu, Oct 31, 2013 at 04:07:15PM +0800, Osier Yang wrote:
> > CC to Amos.
> >
> > On 30/10/13 16:19, whitearchey wrote:
> > >
> > >In QEMU 1.6 parameters of 'drive' option were removed:
> > >
> > >QemuOptsList qemu_dri
On Thu, Oct 31, 2013 at 12:32:12PM +0100, Paolo Bonzini wrote:
> Il 28/10/2013 20:01, Michael S. Tsirkin ha scritto:
> > From: Alexander Graf
> >
> > When AHCI executes an asynchronous IDE command, it checked DRDY without
> > checking either DRQ or BSY. This sometimes caused interrupt to be sent
Il 28/10/2013 20:01, Michael S. Tsirkin ha scritto:
> From: Alexander Graf
>
> When AHCI executes an asynchronous IDE command, it checked DRDY without
> checking either DRQ or BSY. This sometimes caused interrupt to be sent
> before command is actually completed.
>
> This resulted in a race con
Hi Sebastian,
On Wed, Oct 30, 2013 at 5:22 AM, Sebastian Macke wrote:
> On 29/10/2013 2:15 PM, Max Filippov wrote:
>>
>> On Tue, Oct 29, 2013 at 11:04 PM, Sebastian Macke
>> wrote:
>>>
>>> Hi,
>>>
>>> This is the second part of the patches to make the openrisc target faster
>>> and more reliable
On Wed, Oct 30, 2013 at 05:09:26PM +0100, Paolo Bonzini wrote:
> Il 30/10/2013 16:07, Stefan Hajnoczi ha scritto:
> > I came across this little tests/Makefile annoyance:
> > If you modify QEMU code and then run "make check" it will not rebuild QEMU.
> >
> > This can be confusing during development
On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote:
> From: Markus Armbruster
>
> Such devices have always been unavailable and omitted from the list of
> available devices shown by device_add help. Until commit 18b6dad
> silently broke the former, setting up nasty traps for unwary users
On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote:
> From: Markus Armbruster
>
> Drop it when there's no obvious reason why device_add could not work.
> Else keep and document why.
>
> * isa-fdc: drop
>
> * i8042: drop, even though its I/O base is hardcoded (because you
> could conce
Il 31/10/2013 10:28, Alexey Kardashevskiy ha scritto:
> This is not really a patch to accept or review, this is a conversation
> starter.
>
> Cc: Badari Pulavarty
> Cc: Paul Mackerras
> Cc: David Gibson
> Cc: Benjamin Herrenschmidt
> Cc: Andreas Färber
> Signed-off-by: Alexey Kardashevskiy
On Wed, Oct 30, 2013 at 10:44:37AM -0400, Jeff Cody wrote:
> This patch series contains the initial VHDX log parsing, replay,
> write support, and image creation.
>
> === v8 changes ===
> https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v7-upstream
>
> Rebased to latest qemu/master
>
>
On Thu, 2013-10-31 at 11:29 +0100, Markus Armbruster wrote:
> Marcel Apfelbaum writes:
>
> > On Wed, 2013-10-30 at 17:28 +0100, arm...@redhat.com wrote:
> >> From: Markus Armbruster
> >>
> >> A PIIX3/PIIX4 southbridge has multiple functions. We model each
> >> function as a separate qdev. Two
On Wed, Oct 30, 2013 at 10:44:53AM -0400, Jeff Cody wrote:
> +if (image_size > VHDX_MAX_IMAGE_SIZE) {
> +error_setg_errno(errp, EINVAL, "Image size too large; max of
> 64TB\n");
Error messages should not include '\n'.
Perhaps this can be fixed when merging the patch.
On Fri, Oct 25, 2013 at 07:07:23PM +0100, Peter Maydell wrote:
> The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
>
> Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18
> 10:03:24 -0700)
>
> are available in the git repository at:
>
>
> g
On Thu, Oct 31, 2013 at 8:48 AM, Gleb Natapov wrote:
> On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote:
>> On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote:
>> > This simply imports kvm-unittest git into qemu source tree.
>> >
>> > We can next work on making make che
Hi,
Am 31.10.2013 15:02, schrieb Edgar E. Iglesias:
> On Fri, Oct 25, 2013 at 07:07:23PM +0100, Peter Maydell wrote:
>> The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
>>
>> Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18
>> 10:03:24 -0700
On Thu, Oct 31, 2013 at 3:18 PM, Andreas Färber wrote:
> Hi,
>
> Am 31.10.2013 15:02, schrieb Edgar E. Iglesias:
>> On Fri, Oct 25, 2013 at 07:07:23PM +0100, Peter Maydell wrote:
>>> The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
>>>
>>> Merge remote-tracking branch
On Thu, Oct 31, 2013 at 03:17:57PM +0100, Anthony Liguori wrote:
> On Thu, Oct 31, 2013 at 8:48 AM, Gleb Natapov wrote:
> > On Wed, Oct 30, 2013 at 04:06:19PM -0700, Andrew Jones wrote:
> >> On Wed, Oct 16, 2013 at 10:03:37PM +0300, Michael S. Tsirkin wrote:
> >> > This simply imports kvm-unittest
On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
> Hi All,
>
> I know it's been a long time since this thread. But qemu 1.7 is
> releasing, do you have any consensus on this?
>
> Thanks.
I think the biggest issue is the new PANICKED state.
Guests already have simple ways to halt the CPU,
On 31 October 2013 14:18, Andreas Färber wrote:
> Peter, since I had picked up the first two patches into my still pending
> qom-next pull, as per the QEMU Summit discussion those patches should've
> gotten an Acked-by.
Hmm? I don't recall this part of the discussion. If you want the
patches to h
On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>> Hi All,
>>
>> I know it's been a long time since this thread. But qemu 1.7 is
>> releasing, do you have any consensus on this?
>>
>> Thanks.
>
>
> I think the biggest issue is the new PA
On Thu, Oct 31, 2013 at 3:32 PM, Eric Blake wrote:
> On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
>> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>>> Hi All,
>>>
>>> I know it's been a long time since this thread. But qemu 1.7 is
>>> releasing, do you have any consensus on this?
>>
Am 31.10.2013 15:31, schrieb Peter Maydell:
> On 31 October 2013 14:18, Andreas Färber wrote:
>> Peter, since I had picked up the first two patches into my still pending
>> qom-next pull, as per the QEMU Summit discussion those patches should've
>> gotten an Acked-by.
>
> Hmm? I don't recall this
Hello Anthony,
This is my updated QOM devices patch queue. Please pull or provide more details
of what is not working in your build environment.
v2 is rebased, dropping two ARM patches, and the observed SD segfault had been
fixed in 794cbc26eb94ce13c75d105eea9ff0afff56e2c2.
Patches are not manual
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Il 31/10/2013 15:32, Eric Blake ha scritto:
> On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
>> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>>> Hi All,
>>>
>>> I know it's been a long time since this thread. But qemu 1.7 is
>>> releasin
On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber wrote:
> Am 31.10.2013 15:31, schrieb Peter Maydell:
>> On 31 October 2013 14:18, Andreas Färber wrote:
>>> Peter, since I had picked up the first two patches into my still pending
>>> qom-next pull, as per the QEMU Summit discussion those patches s
On Thu, Oct 31, 2013 at 08:32:43AM -0600, Eric Blake wrote:
> On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> > On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
> >> Hi All,
> >>
> >> I know it's been a long time since this thread. But qemu 1.7 is
> >> releasing, do you have any consensu
Am 31.10.2013 15:39, schrieb Anthony Liguori:
> On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber wrote:
>> Am 31.10.2013 15:31, schrieb Peter Maydell:
>>> On 31 October 2013 14:18, Andreas Färber wrote:
Peter, since I had picked up the first two patches into my still pending
qom-next pul
On 10/31/2013 08:47 AM, Michael S. Tsirkin wrote:
>>> if (event & PVPANIC_PANICKED) {
>>> panicked_mon_event("pause");
>>> -vm_stop(RUN_STATE_GUEST_PANICKED);
>>
>> Don't you still need to halt the guest on a panic event, for management
>> to have a chance to choose what to d
On Thu, Oct 31, 2013 at 03:39:17PM +0100, Paolo Bonzini wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Il 31/10/2013 15:32, Eric Blake ha scritto:
> > On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> >> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
> >>> Hi All,
> >>>
>
On Thu, Oct 31, 2013 at 3:45 PM, Andreas Färber wrote:
> Am 31.10.2013 15:39, schrieb Anthony Liguori:
>> On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber wrote:
>>> Am 31.10.2013 15:31, schrieb Peter Maydell:
On 31 October 2013 14:18, Andreas Färber wrote:
> Peter, since I had picked up
Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
>> > Yes, it does.
> What does it break exactly?
The point of a panicked event is to examine the guest at a particular
moment in time (e.g. host-initiated crash dump). If you let the guest
run, it may reboot and prevent you from getting a meanin
On Thu, Oct 31, 2013 at 3:45 PM, Andreas Färber wrote:
> Am 31.10.2013 15:39, schrieb Anthony Liguori:
>> On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber wrote:
>>> Am 31.10.2013 15:31, schrieb Peter Maydell:
On 31 October 2013 14:18, Andreas Färber wrote:
> Peter, since I had picked up
On Wed, Oct 30, 2013 at 6:31 PM, jacek burghardt wrote:
> I got this error
> hw/net/e1000.c: In function 'set_phy_ctrl':
> hw/net/e1000.c:209:10: warning: implicit declaration of function 'set_ics'
> [-Wimplicit-function-declaration]
That's because set_ics needs to be declared before being used in
On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
> >> > Yes, it does.
> > What does it break exactly?
>
> The point of a panicked event is to examine the guest at a particular
> moment in time (e.g. host-initiated crash dump). If
On Thu, Oct 31, 2013 at 08:49:08AM -0600, Eric Blake wrote:
> On 10/31/2013 08:47 AM, Michael S. Tsirkin wrote:
>
> >>> if (event & PVPANIC_PANICKED) {
> >>> panicked_mon_event("pause");
> >>> -vm_stop(RUN_STATE_GUEST_PANICKED);
> >>
> >> Don't you still need to halt the gues
On 31 October 2013 14:36, Andreas Färber wrote:
> Am 31.10.2013 15:31, schrieb Peter Maydell:
>> On 31 October 2013 14:18, Andreas Färber wrote:
>>> Peter, since I had picked up the first two patches into my still pending
>>> qom-next pull, as per the QEMU Summit discussion those patches should'v
Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
> On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
>> Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
> Yes, it does.
>>> What does it break exactly?
>>
>> The point of a panicked event is to examine the guest at a particular
On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 15:52, Michael S. Tsirkin ha scritto:
> > Yes, it does.
> >>> What does it break exactly?
>
From: Peter Lieven
currently it is not possible to distinguish by exitcode if there
has been an error or if bdrv_check is not supported by the image
format. Change the exitcode from 1 to 63 for the latter case.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
The following changes since commit fc8ead74674b7129e8f31c2595c76658e5622197:
Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-10-18
10:03:24 -0700)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-anthony
for you to fetch changes up to f
From: Max Reitz
Since df2a6f29a5, bdrv_co_do_writev increases the total_sectors value of
a growable block devices on writes after the current end. This leads to
the virtual disk apparently growing in qcow2_save_vmstate, which in turn
affects the disk size captured by the internal snapshot taken d
From: Eric Blake
The QMP wire format uses "", not '', around strings.
* docs/qapi-code-gen.txt: Fix typo.
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
---
docs/qapi-code-gen.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code
From: Peter Lieven
this adds a check that a dynamic VHD file has not been
accidently truncated (e.g. during transfer or upload).
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/vpc.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block/vpc.
From: Max Reitz
Saving the VM state is done using bdrv_pwrite. This function may perform
a read-modify-write, which in this case results in data being read from
beyond the end of the virtual disk. Since we are actually trying to
access an area which is not a part of the virtual disk, zero_beyond_
From: Max Reitz
Opening the qcow2 image with BDRV_O_NO_FLUSH prevents any flushes during
the image creation. This means that the image has not yet been flushed
to disk when qemu-img create exits. This flush is delayed until the next
operation on the image involving opening it without BDRV_O_NO_FL
From: MORITA Kazutaka
The current resend_aio_req() doesn't work when the request is against
vdi objects. This fixes the problem.
Signed-off-by: MORITA Kazutaka
Tested-by: Liu Yuan
Reviewed-by: Liu Yuan
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 21 -
1 file change
From: MORITA Kazutaka
This introduces a failed request queue and links all the inflight
requests to the list after network error happens. After QEMU
reconnects to the sheepdog server successfully, the sheepdog block
driver will retry all the requests in the failed queue.
Signed-off-by: MORITA K
From: MORITA Kazutaka
If qemu_co_recv/send doesn't return the specified length, it means
that an error happened.
Signed-off-by: MORITA Kazutaka
Tested-by: Liu Yuan
Reviewed-by: Liu Yuan
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 16
1 file changed, 8 insertions(+), 8
This fixes a regression introduced by commit e3127ae0c, which kept the
allocation size of the bounce buffer limited to one page in order to
avoid unbounded allocations (as explained in the commit message of
6d16c2f88), but broke the reporting of the shortened bounce buffer to
the caller. The caller
This adds a test case for Multiboot memory map in the tests/multiboot
directory, where future i386 test kernels can be dropped. Because this
requires an x86 build host and an installed 32 bit libgcc, the test is
not part of a regular 'make check'.
The reference output for the test is verified agai
From: MORITA Kazutaka
These functions no longer return errors. We can make them void
functions and simplify the codes.
Signed-off-by: MORITA Kazutaka
Tested-by: Liu Yuan
Reviewed-by: Liu Yuan
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 66 +++---
From: Fam Zheng
Implement .bdrv_get_specific_info to return the extent information.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 68 +-
qapi-schema.json | 24 +++-
tests/qemu-iotests/059
From: Thibaut LAURENT
Since commit 0ebd24e0a203cf2852c310b59fbe050190dc6c8c,
bdrv_open_common will throw an error when trying to open a file
read-only with the BDRV_O_COPY_ON_READ flag set.
Although BDRV_O_RDWR is unset for the backing files,
BDRV_O_COPY_ON_READ is still passed on if copy-on-read
From: Max Reitz
bdrv_open_backing_file() tries to copy the backing file name using
pstrcpy directly after calling bdrv_open() to open the backing file
without checking whether that was actually successful. If it was not,
ps->backing_hd->file will probably be NULL and qemu will crash.
Fix this by
The block layer generally keeps the size of an image cached in
bs->total_sectors so that it doesn't have to perform expensive
operations to get the size whenever it needs it.
This doesn't work however when using a backend that can change its size
without qemu being aware of it, i.e. passthrough of
From: Liu Yuan
'copies' is actually uint8_t since day one, but request headers and some helper
functions parameterize it as uint32_t for unknown reasons and effectively
reserve 24 bytes for possible future use. This patch explicitly set the correct
for copies and reserve the left bytes.
This is
There are still problems with the qemu-iotests, if the pathname of the working
directory contains spaces. This series fixes most of them. To verify,
./check -qcow2 was run from a pathname with spaces (e.g., renamed ~/qemu-kvm
to "~/qemu-kvm test/").
The following tests still fail due to pathnam
There were still instances of $TEST_IMG not being properly quoted.
This was in the usage of a string built up for a 'for' loop; modify
the loop so we can quote $TEST_IMG properly.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/019 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
dif
_make_test_img() currently works with spaced pathnames only when not
specifying a backing file. This fixes it so that the backing file
argument is properly quoted.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.rc | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
dif
Commit 684b254 forgot to update it.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/051.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index 2839e32..15deef6 100644
--- a/tests/qemu-iotests/051.out
+++ b/tests/qemu
From: Liu Yuan
Currently copy_policy isn't used. Recent sheepdog supports erasure coding, which
make use of copy_policy internally, but require client explicitly passing
copy_policy from base inode to newly creately inode for snapshot related
operations.
If connected sheep daemon doesn't utilize
$TEST_IMG.base is used unquoted. Add quotes so that pathnames with
spaces are supported.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/017 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/017 b/tests/qemu-iotests/017
index 45f2c0b..aba3faf 100755
--- a/tes
Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/039 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039
index f85b4ce..8bade92 100755
--- a/tests/qemu-iotests/0
From: Fam Zheng
There's a same common function in iotests.py
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/040 | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index aad535a..a2e18c5
There were still a couple of instances of unquoted usage of
$TEST_IMG and $TEST_IMG.orig. Quoted these so they will not fail
on pathnames with spaces in them.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/051 | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/qe
From: Max Reitz
Add a test case for trying to open an image file where it is impossible
to open its backing file (in this case, because it was deleted). When
doing this, qemu (or qemu-io in this case) should not crash but rather
print an appropriate error message.
Signed-off-by: Max Reitz
Revie
When creating images with backing files in the test, the backing
file argument was not quoted properly. This caused the test to fail
when run from a pathname with a space. Pass the backing argument in
with the -b option to _make_test_img, so it can be properly quoted.
Signed-off-by: Jeff Cody
-
From: MORITA Kazutaka
This prepares for using resend_aioreq() after reconnecting to the
sheepdog server.
Signed-off-by: MORITA Kazutaka
Tested-by: Liu Yuan
Reviewed-by: Liu Yuan
Signed-off-by: Kevin Wolf
---
block/sheepdog.c | 33 +++--
1 file changed, 19 inserti
From: Fam Zheng
Case 030 occasionally fails because of block job compltes too fast to be
captured by script, and 'unexpected qmp event' of job completion causes
the test failure.
Simply fill in some data to the test image to make this false alarm less
likely to happen.
(For other benefits to pr
From: Fam Zheng
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
qapi-schema.json | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 60f3fd1..add97e2 100644
--- a/qapi-schema.json
+++ b/qapi-schema.jso
On Thu, Oct 31, 2013 at 04:56:07PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 16:45, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 04:26:13PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 16:09, Michael S. Tsirkin ha scritto:
> >>> On Thu, Oct 31, 2013 at 03:56:42PM +0100, Paolo Bonz
On 10/30/2013 08:06 PM, Fam Zheng wrote:
> Implement .bdrv_get_specific_info to return the extent information.
>
> Signed-off-by: Fam Zheng
>
> ---
> v5: Changed 3 lines:
> - Save cid in vmdk_open. (Kevin)
> - Report parent_cid in vmdk_get_specific_info.
> - Rename create_type to cre
On 10/31/2013 09:48 AM, Kevin Wolf wrote:
> From: Fam Zheng
>
> Implement .bdrv_get_specific_info to return the extent information.
>
> Signed-off-by: Fam Zheng
> Signed-off-by: Kevin Wolf
> ---
> +++ b/qapi-schema.json
> @@ -225,6 +225,27 @@
>} }
>
> ##
> +# @ImageInfoSpecificVmdk:
>
Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
>> PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
>> reverted if the panicked state is removed from runstate_needs_reset.
>
> Okay so let's drop the code duplication and explicitly make
> them the same?
>
> Signed-off-by: Mic
Am 31.10.2013 um 17:13 hat Eric Blake geschrieben:
> On 10/31/2013 09:48 AM, Kevin Wolf wrote:
> > From: Fam Zheng
> >
> > Implement .bdrv_get_specific_info to return the extent information.
> >
> > Signed-off-by: Fam Zheng
> > Signed-off-by: Kevin Wolf
> > ---
>
> > +++ b/qapi-schema.json
>
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> _make_test_img() currently works with spaced pathnames only when not
> specifying a backing file. This fixes it so that the backing file
> argument is properly quoted.
>
> Signed-off-by: Jeff Cody
> ---
> tests/qemu-iotests/common.rc | 13 +++--
On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> >> PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
> >> reverted if the panicked state is removed from runstate_needs_reset.
> >
> > Okay so let's drop the code
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> The usage of $TEST_IMG was not properly quoted everywhere in
> common.pattern.
>
> Signed-off-by: Jeff Cody
> ---
> tests/qemu-iotests/common.pattern | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake
--
Eri
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> $TEST_IMG.base is used unquoted. Add quotes so that pathnames with
> spaces are supported.
>
> Signed-off-by: Jeff Cody
> ---
> tests/qemu-iotests/017 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake eb
On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> >> PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
> >> reverted if the panicked state is removed from runstate_needs_reset.
> >
> > Okay so let's drop the code
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> Test 039 had $TEST_IMG with duplicate double quotes - remove duplicate.
>
> Signed-off-by: Jeff Cody
> ---
> tests/qemu-iotests/039 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com
From: MORITA Kazutaka
This helper function behaves similarly to co_sleep_ns(), but the
sleeping coroutine will be resumed when using qemu_aio_wait().
Signed-off-by: MORITA Kazutaka
Tested-by: Liu Yuan
Reviewed-by: Liu Yuan
Signed-off-by: Kevin Wolf
---
include/block/coroutine.h | 9 +++
On 10/31/2013 09:57 AM, Jeff Cody wrote:
> When creating images with backing files in the test, the backing
> file argument was not quoted properly. This caused the test to fail
> when run from a pathname with a space. Pass the backing argument in
> with the -b option to _make_test_img, so it can
From: MORITA Kazutaka
After reconnection happens, all the inflight requests are moved to the
failed request list. As a result, sd_co_rw_vector() can send another
create request before resend_aioreq() resends a create request from
the failed list.
This patch adds a helper function check_simultan
Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto:
> On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
>> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
PANICKED->DEBUG was added by commit bc7d0e667. That commit can be
reverted if the panicked state is removed from run
The usage of $TEST_IMG was not properly quoted everywhere in
common.pattern.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.pattern | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tests/qemu-iotests/common.pattern
b/tests/qemu-iotests/common.pattern
inde
On Thu, Oct 31, 2013 at 05:38:40PM +0100, Paolo Bonzini wrote:
> Il 31/10/2013 17:26, Michael S. Tsirkin ha scritto:
> > On Thu, Oct 31, 2013 at 05:17:24PM +0100, Paolo Bonzini wrote:
> >> Il 31/10/2013 17:14, Michael S. Tsirkin ha scritto:
> PANICKED->DEBUG was added by commit bc7d0e667. Tha
From: Alexander Graf
When AHCI executes an asynchronous IDE command, it checked DRDY without
checking either DRQ or BSY. This sometimes caused interrupt to be sent
before command is actually completed.
This resulted in a race condition: if guest then managed to access the
device before command
Il 31/10/2013 17:48, Michael S. Tsirkin ha scritto:
> But code duplication is bad.
So should we make a table of IO_ERROR-like states to avoid code
duplication? You have to draw a line somewhere...
> I think IO error for example
> is broken in that you can't pause but can run then pause.
> Seems
Am 31.10.2013 16:04, schrieb Anthony Liguori:
> On Thu, Oct 31, 2013 at 3:45 PM, Andreas Färber wrote:
>> Am 31.10.2013 15:39, schrieb Anthony Liguori:
>>> On Thu, Oct 31, 2013 at 3:36 PM, Andreas Färber wrote:
Am 31.10.2013 15:31, schrieb Peter Maydell:
> On 31 October 2013 14:18, Andre
From: Max Reitz
Add a test for saving a VM state from a qcow2 image and loading it back
(with having restarted qemu in between); this should work without any
problems.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/068 | 65 ++
1 - 100 of 172 matches
Mail list logo
