[Qemu-devel] [PATCH 1/2] net/e1000: update network information when macaddr is changed in guest

2013-10-17 Thread Amos Kong
If we change macaddr in guest by 'ifconfig eth0 hw ether 12:12:12:34:35:36', the mac register of e1000 is already updated, but we don't update network information in qemu. Therefor, the information in monitor is wrong. This patch updates nic info when the second part of macaddr is written. Signed

[Qemu-devel] [PATCH 0/2] fix updating of nic info

2013-10-17 Thread Amos Kong
I tried to change macaddr in guest, addr in guest is updated, and guest network is fine. But the nic information in monitor isn't update. This problem both exists in e1000 and rtl8139. 1) change macaddr in guest by ifconfig guest)# ifconfig eth0 hw ether 12:12:12:34:35:36 guest)# ifconfig et

[Qemu-devel] [PATCH 2/2] net/rtl8139: update network information when macaddr is changed in guest

2013-10-17 Thread Amos Kong
rtl8139 has same problem as e1000, nic info isn't updated when macaddr is changed in guest. This patch updates the nic info when the last bit of macaddr is written. Signed-off-by: Amos Kong --- hw/net/rtl8139.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net/rtl8

Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info

2013-10-17 Thread Stefan Hajnoczi
On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > I tried to change macaddr in guest, addr in guest is updated, and guest > network is fine. But the nic information in monitor isn't update. This > problem both exists in e1000 and rtl8139. > > 1) change macaddr in guest by ifconfig >

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread Kevin Wolf
Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben: > Change to v1: > remove '[not inserted]' line instead of adding '\n' Please put such notes for reviewers below the --- line, so that git am automatically removes them and they don't end up in the git commit message. > Output of 'info block'

Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > > I tried to change macaddr in guest, addr in guest is updated, and guest > > network is fine. But the nic information in monitor isn't update. This > > problem both exist

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread Stefan Hajnoczi
On Wed, Oct 16, 2013 at 11:16:01PM -0400, Mike Qiu wrote: > Change to v1: > remove '[not inserted]' line instead of adding '\n' > > Output of 'info block' > > scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) > [not inserted] > scsi0-cd2: [not inserted] > Removable device: not locked, tray cl

Re: [Qemu-devel] [PATCH] sd: Avoid access to NULL BlockDriverState

2013-10-17 Thread Stefan Hajnoczi
On Wed, Oct 16, 2013 at 03:24:01PM +0200, Andreas Färber wrote: > Commit 4f8a066b5fc254eeaabbbde56ba4f5b29cc68fdf (blockdev: Remove IF_* > check for read-only blockdev_init) added a usage of bdrv_is_read_only() > to sd_init(), which is called for versatilepb, versatileab and > xilinx-zynq-a9 machin

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-17 Thread Gerd Hoffmann
Hi, > By far the best way to test this is to boot some guest, > download tables, then run iasl -d on them. Fully agree. /me did the same when testing with coreboot. Boot linux, with old seabios, with new seabios, with (patched) coreboot, then diffed the iasl decompiled tables. cheers, Gerd

Re: [Qemu-devel] [PATCH v8 0/3] block: Add support for Secure Shell (ssh) block device.

2013-10-17 Thread Richard W.M. Jones
On Tue, Apr 09, 2013 at 10:56:30AM +0100, Richard W.M. Jones wrote: > Changes since v7: > > - fsync (ie. bdrv_co_flush_to_disk) is now supported, *if* you have > the following patches to libssh2 and OpenSSH: > > https://bugzilla.mindrot.org/show_bug.cgi?id=1798 > (OpenSSH: accepted, but not upstr

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 11:12:31AM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 09:27:51AM +0300, Gleb Natapov wrote: > > On Wed, Oct 16, 2013 at 10:46:53PM +0300, Michael S. Tsirkin wrote: > > > Old GCC didn't let you reference variable by > > > number if it is listed with a specific

Re: [Qemu-devel] [PATCH v2] blockdev: fix cdrom read_only flag

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 05:45:50PM +0800, Fam Zheng wrote: > Since 0ebd24e0, cdrom doesn't have read-only on by default, which will > error out when using an read only image. Fix it by setting the default > value when parsing opts. > > Reported-by: Edivaldo de Araujo Pereira > Signed-off-by: Fam

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 11:20:27AM +0300, Gleb Natapov wrote: > On Thu, Oct 17, 2013 at 11:12:31AM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 17, 2013 at 09:27:51AM +0300, Gleb Natapov wrote: > > > On Wed, Oct 16, 2013 at 10:46:53PM +0300, Michael S. Tsirkin wrote: > > > > Old GCC didn't let

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 09:27:51AM +0300, Gleb Natapov wrote: > On Wed, Oct 16, 2013 at 10:46:53PM +0300, Michael S. Tsirkin wrote: > > Old GCC didn't let you reference variable by > > number if it is listed with a specific register > > constraint, on the assumption you can just > > use the registe

Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info

2013-10-17 Thread Amos Kong
On Thu, Oct 17, 2013 at 11:15:21AM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > > > I tried to change macaddr in guest, addr in guest is updated, and guest > > > network is fine.

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 11:27:37AM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 11:20:27AM +0300, Gleb Natapov wrote: > > On Thu, Oct 17, 2013 at 11:12:31AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 17, 2013 at 09:27:51AM +0300, Gleb Natapov wrote: > > > > On Wed, Oct 16, 201

[Qemu-devel] [PATCH] net: update nic info during device reset

2013-10-17 Thread Amos Kong
macaddr is reset during device reset, but nic info isn't updated, this problem exists in e1000 & rtl8139 Signed-off-by: Amos Kong --- hw/net/e1000.c | 1 + hw/net/rtl8139.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 7769be0..70a59fd 100644 --- a

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread mike
On 10/17/2013 04:11 PM, Kevin Wolf wrote: Am 17.10.2013 um 05:16 hat Mike Qiu geschrieben: Change to v1: remove '[not inserted]' line instead of adding '\n' Please put such notes for reviewers below the --- line, so that git am automatically removes them and they don't end up in the git

Re: [Qemu-devel] [PATCH v2] hmp: solve '\n' in monitor_printf()

2013-10-17 Thread mike
On 10/17/2013 04:14 PM, Stefan Hajnoczi wrote: On Wed, Oct 16, 2013 at 11:16:01PM -0400, Mike Qiu wrote: Change to v1: remove '[not inserted]' line instead of adding '\n' Output of 'info block' scsi0-hd0: /images/f18-ppc64.qcow2 (qcow2) [not inserted] scsi0-cd2: [not inserted] R

Re: [Qemu-devel] qemu-system-or32 is not working on OS X, ask for help.

2013-10-17 Thread Peter Maydell
On 17 October 2013 04:17, Jia Liu wrote: > On Fri, Oct 11, 2013 at 10:41 AM, Jia Liu wrote: >> I'm not sure about why qemu-system-or32 is not working on OS X, is it >> a AREG0 problem? May you please give me some suggestion, I want to >> test it on OS X, not Ubuntu any longer. The things that me

Re: [Qemu-devel] [RFC PATCH v3 4/5] Update documentation for LTTng ust tracing

2013-10-17 Thread Alex Bennée
mohamad.ge...@polymtl.ca writes: > On 13-10-16 08:05 AM, Alex Bennée wrote: Running this gives me: UST events: - None Before or after running qemu. What is the mechanism lttng expects to find out all these events? >>> Either the user

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 11:34:41AM +0300, Gleb Natapov wrote: > On Thu, Oct 17, 2013 at 11:27:37AM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 17, 2013 at 11:20:27AM +0300, Gleb Natapov wrote: > > > On Thu, Oct 17, 2013 at 11:12:31AM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Oct 17, 201

Re: [Qemu-devel] [PATCH] Fix VNC SASL authentication when using a QXL device

2013-10-17 Thread Gerd Hoffmann
On Mi, 2013-10-16 at 17:52 +0200, Christophe Fergeau wrote: > ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init() > are both calling sasl_server_init(). If spice_server_set_sasl_appname() > hasn't been called, spice-server will call it with "spice" as an appname, > causing cy

Re: [Qemu-devel] [PATCH 0/2] fix updating of nic info

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 04:31:22PM +0800, Amos Kong wrote: > On Thu, Oct 17, 2013 at 11:15:21AM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > > > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > > > > I tried to change macaddr in

Re: [Qemu-devel] [PATCH] net: update nic info during device reset

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 04:38:34PM +0800, Amos Kong wrote: > macaddr is reset during device reset, but nic info > isn't updated, this problem exists in e1000 & rtl8139 > > Signed-off-by: Amos Kong Acked-by: Michael S. Tsirkin > --- > hw/net/e1000.c | 1 + > hw/net/rtl8139.c | 1 + > 2 files

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 12:28:58PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 11:34:41AM +0300, Gleb Natapov wrote: > > On Thu, Oct 17, 2013 at 11:27:37AM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 17, 2013 at 11:20:27AM +0300, Gleb Natapov wrote: > > > > On Thu, Oct 17, 201

Re: [Qemu-devel] [Qemu-ppc] [PATCH V2] Fix float64_to_uint64

2013-10-17 Thread Alexander Graf
On 16.10.2013, at 23:10, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. >

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 12:33:39PM +0300, Gleb Natapov wrote: > > > It just papers over the problem. Compiler should either complain that it > > > does not know what %w0 or complain that variable length does not match > > > assembly > > > > Of course it can't. Compiler does not parse assembly at a

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 12:44:46PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 17, 2013 at 12:33:39PM +0300, Gleb Natapov wrote: > > > > It just papers over the problem. Compiler should either complain that it > > > > does not know what %w0 or complain that variable length does not match > > > >

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-17 Thread Markus Armbruster
Andreas Färber writes: > Am 16.10.2013 12:00, schrieb Markus Armbruster: >> Anthony Liguori writes: >> >>> On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf wrote: Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben: > Am 15.10.2013 15:21, schrieb Markus Armbruster: >> Andreas, >>

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-17 Thread Markus Armbruster
Anthony Liguori writes: > On Wed, Oct 16, 2013 at 3:00 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf wrote: Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben: > Am 15.10.2013 15:21, schrieb Markus Armbruster: > > And

Re: [Qemu-devel] [PATCH v1 4/4] target-arm: Add CP15 VBAR support

2013-10-17 Thread Peter Maydell
On 10 July 2013 05:23, wrote: > From: Nathan Rossi > > Added Vector Base Address remapping on ARM v7. Apologies for this dropping off my radar for so long. I've had a bit of a think and I think that you're right that we can put in this register as part of our "random things we provide even thou

[Qemu-devel] [PATCH 4/4] spice: fix multihead support

2013-10-17 Thread Gerd Hoffmann
This patch fixes spice display initialization to handle multihead properly. spice-core now keeps track of which QemuConsole has a spice display channel attached to it and which has not. It also manages display channel ids. spice-display looks at all QemuConsoles and will pick up any graphic cons

[Qemu-devel] [PULL 0/4] spice patch queue

2013-10-17 Thread Gerd Hoffmann
Hi, Here comes the spice patch queue with a small collection of fixes. cheers, Gerd The following changes since commit 1680d485777ecf436d724631ea8722cc0c66990e: Merge remote-tracking branch 'rth/tcg-ldst-6' into staging (2013-10-14 09:59:59 -0700) are available in the git repository at:

[Qemu-devel] [PATCH 2/4] Fix VNC SASL authentication when using a QXL device

2013-10-17 Thread Gerd Hoffmann
From: Christophe Fergeau ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init() are both calling sasl_server_init(). If spice_server_set_sasl_appname() hasn't been called, spice-server will call it with "spice" as an appname, causing cyrus-sasl to try to use a /etc/sasl2/spice

[Qemu-devel] [PATCH 1/4] spice: replace use of deprecated API

2013-10-17 Thread Gerd Hoffmann
From: Marc-André Lureau hose API are deprecated since 0.11, and qemu depends on 0.12 already. Signed-off-by: Gerd Hoffmann --- hw/display/qxl.c | 16 ui/spice-core.c| 15 +++ ui/spice-display.c | 10 +- 3 files changed, 20 insertions(+), 21 deletions(

[Qemu-devel] [PATCH 3/4] spice-display: add display channel id to the debug messages.

2013-10-17 Thread Gerd Hoffmann
And s/__FUNCTION__/__func__/ while being at it. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 0297373..c15c555 100644 --- a/ui/spice-display.c +++

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Paolo Bonzini
Il 16/10/2013 21:46, Michael S. Tsirkin ha scritto: > Old GCC didn't let you reference variable by > number if it is listed with a specific register > constraint, on the assumption you can just > use the register name explicitly. Tell us the truth, you made this up. :) Who doesn't do that for inv

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 08:27, Gleb Natapov ha scritto: > On Wed, Oct 16, 2013 at 10:46:53PM +0300, Michael S. Tsirkin wrote: >> Old GCC didn't let you reference variable by >> number if it is listed with a specific register >> constraint, on the assumption you can just >> use the register name explicitly. >

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Gleb Natapov
On Thu, Oct 17, 2013 at 12:55:16PM +0200, Paolo Bonzini wrote: > Il 17/10/2013 08:27, Gleb Natapov ha scritto: > > On Wed, Oct 16, 2013 at 10:46:53PM +0300, Michael S. Tsirkin wrote: > >> Old GCC didn't let you reference variable by > >> number if it is listed with a specific register > >> constrai

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 12:58, Gleb Natapov ha scritto: >>> > > @@ -143,14 +143,14 @@ static inline int rtc_in(u8 reg) >>> > > { >>> > > u8 x = reg; >>> > > asm volatile("outb %b1, $0x70; inb $0x71, %b0" >>> > > -: "+a"(x) : "0"(x)); >>> > > +: "=a"(x) : "0"(x)); >>

[Qemu-devel] [PATCH 0/2] vga: add secondary stdvga variant

2013-10-17 Thread Gerd Hoffmann
Hi, This little series adds a legacy-free variant of the qemu standard vga, which can easily be used as secondary vga. No BIOS, thus no vesa support, thus you need guest drivers. If you wanna play with this walk over here: http://www.kraxel.org/cgit/linux/log/?h=qemu-drm The bochs drm drive

[Qemu-devel] [PATCH 2/2] vga: add secondary stdvga variant

2013-10-17 Thread Gerd Hoffmann
Add a standard vga variant which doesn't occupy any legacy ressources and thus can easily be used as secondary (or legacy-free) graphics adapter. Programming must be done using the MMIO bar. Signed-off-by: Gerd Hoffmann --- docs/specs/standard-vga.txt | 13 +++--- hw/display/vga-pci.c

[Qemu-devel] [PATCH 1/2] vga: allow non-global vmstate

2013-10-17 Thread Gerd Hoffmann
Need a way to opt-out from vga.vram being global vmstate, for secondary vga cards. Add a bool parameter to vga_common_init to support this. Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vga-isa-mm.c | 2 +- hw/display/vga-isa.c

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 07:34, Michael S. Tsirkin ha scritto: > > So we could have a qtest for sanity checking ACPI tables. At least > > fw_cfg is one of the few components that has qtest infrastructure... I > > don't think we need to do more than that though. The set of sanity > > checks can start with a

[Qemu-devel] [PULL 0/1] e820: pass high memory too.

2013-10-17 Thread Gerd Hoffmann
Hi, See patch description for all the details. Patch has been out for review for a while without objections. please pull, Gerd The following changes since commit 1680d485777ecf436d724631ea8722cc0c66990e: Merge remote-tracking branch 'rth/tcg-ldst-6' into staging (2013-10-14 09:59:59 -07

[Qemu-devel] [PATCH 1/1] e820: pass high memory too.

2013-10-17 Thread Gerd Hoffmann
We have a fw_cfg entry to pass e820 entries from qemu to the firmware. Today it's used to pass reservations only. This patch makes qemu pass entries for RAM too. This allows to pass RAM sizes larger than 1TB to the firmware and it will also allow to pass non-contignous memory ramges should we dec

[Qemu-devel] [PATCH] add firmware to machine options

2013-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- vl.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c index 7e1f408..ef450ee 100644 --- a/vl.c +++ b/vl.c @@ -428,6 +428,10 @@ static QemuOptsList qemu_machine_opts = { .name = "usb", .type = QEMU_OPT_

Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 05:16, Liu Ping Fan ha scritto: > + bool hpet_irqs) > { > int i; > DriveInfo *fd[MAX_FD]; > @@ -1249,10 +1250,19 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq > *gsi, > /* In order to set property, here not using sysbus_try_create

Re: [Qemu-devel] [PATCH v7 4/4] PC: differentiate hpet's interrupt capability on piix and q35

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 05:16, Liu Ping Fan ha scritto: > + bool hpet_irqs) > { > int i; > DriveInfo *fd[MAX_FD]; > @@ -1249,10 +1250,19 @@ void pc_basic_device_init(ISABus *isa_bus, qemu_irq > *gsi, > /* In order to set property, here not using sysbus_try_create

[Qemu-devel] Qemu VGA Driver With XP Guest

2013-10-17 Thread Bohai (ricky)
Hi All, When I user '-vga std' to run winxp Guest. The driver in the guest seems not normal . The vendor, display memory size can't be read by the operation system. In the hardware device management, the vga device's status is not normal. Is this a problem of qemu's std vga device implement? Or

Re: [Qemu-devel] [PATCH v3 1/4] Curling: add doc

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 03:26:20PM +0800, Jules Wang wrote: > +Usage > += > +The steps of curling are the same as the steps of live migration except the > +following: > +1. Start ft in the qemu monitor of sender vm by following cmdline: > + > migrate_set_speed > + > migrate -f tcp:: > +2.

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 12:53:30PM +0200, Paolo Bonzini wrote: > Il 16/10/2013 21:46, Michael S. Tsirkin ha scritto: > > Old GCC didn't let you reference variable by > > number if it is listed with a specific register > > constraint, on the assumption you can just > > use the register name explicit

Re: [Qemu-devel] [PATCH] kvm-unittest: fix build with gcc 4.3.X and older

2013-10-17 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 01:02:17PM +0200, Paolo Bonzini wrote: > Il 17/10/2013 12:58, Gleb Natapov ha scritto: > >>> > > @@ -143,14 +143,14 @@ static inline int rtc_in(u8 reg) > >>> > > { > >>> > > u8 x = reg; > >>> > > asm volatile("outb %b1, $0x70; inb $0x71, %b0" > >>> > > -

Re: [Qemu-devel] [PATCH v2 1/6] osdep: Create qemu_getauxval and qemu_init_auxval

2013-10-17 Thread Peter Maydell
On 10 September 2013 23:07, Richard Henderson wrote: > Abstract away dependence on a system implementation of getauxval. > > Signed-off-by: Richard Henderson There are unfortunately some trivial conflicts now so this series needs a respin :-( > --- > include/qemu/osdep.h | 20 > l

Re: [Qemu-devel] [PATCH v3 0/4] Curling: KVM Fault Tolerance

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 03:26:19PM +0800, Jules Wang wrote: > v2 -> v3: > * add documentation of new option in qapi-schema. > > * long option name: ft -> fault-tolerant > > v1 -> v2: > * cmdline: migrate curling:tcp:: >-> migrate -f tcp:: > > * sender: use QEMU_VM_FILE_MAGIC_FT as the

Re: [Qemu-devel] [PATCH v2 2/6] tcg-ppc64: Use qemu_getauxval

2013-10-17 Thread Peter Maydell
On 10 September 2013 23:07, Richard Henderson wrote: > Allow host detection on linux systems without glibc 2.16 or later. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH v2 3/6] tcg-arm: Use qemu_getauxval

2013-10-17 Thread Peter Maydell
On 10 September 2013 23:07, Richard Henderson wrote: > Allow host detection on linux systems without glibc 2.16 or later. > > Signed-off-by: Richard Henderson > --- > include/elf.h| 22 ++ > tcg/arm/tcg-target.c | 15 ++- > 2 files changed, 28 insertions(+

[Qemu-devel] [PATCH] Fix another corner-case of using VNC+SASL+SPICE

2013-10-17 Thread Christophe Fergeau
Similarly to the previous commit fixing VNC+SASL+QXL, when starting QEMU with SPICE but no SASL, and also VNC with SASL, then spice_server_init() will get called without a previous call to spice_server_set_sasl_appname(), which will cause cyrus-sasl to try to use /etc/sasl2/spice.conf (spice-server

Re: [Qemu-devel] [PATCH v2 5/6] util: Provide fallback hwcap and platform for powerpc

2013-10-17 Thread Peter Maydell
On 10 September 2013 23:07, Richard Henderson wrote: > Allow host "detection" on non-linux hosts. > > Signed-off-by: Richard Henderson > --- > util/getauxval.c | 56 > ++-- > 1 file changed, 54 insertions(+), 2 deletions(-) > > diff --git a/ut

Re: [Qemu-devel] [PATCH v2 6/6] util: Use qemu_getauxval in linux qemu_cache_utils_init

2013-10-17 Thread Peter Maydell
On 10 September 2013 23:07, Richard Henderson wrote: > With this we no longer pass down envp, and thus all systems can have > the same void prototype. So also eliminate a useless thunk. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 00/60] AArch64 TCG emulation support

2013-10-17 Thread Alexander Graf
On 16.10.2013, at 21:54, Edgar E. Iglesias wrote: > On Fri, Sep 27, 2013 at 02:47:54AM +0200, Alexander Graf wrote: >> Howdy, >> >> This is the first batch of patches to implement AArch64 instruction >> emulation in QEMU. It implements enough to execute simple AArch64 >> programs in linux-user

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 09:33:06PM +0800, mike wrote: > On 10/15/2013 08:36 PM, Eric Blake wrote: > >On 10/14/2013 11:07 PM, Stefan Weil wrote: > >>Is it reasonable to get a random mac address in your guest? I don't > >>think so. It would no longer be possible to connect to a guest using > >>ssh, r

Re: [Qemu-devel] [PATCH 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM

2013-10-17 Thread Mark Cave-Ayland
On 15/10/13 22:46, Peter Maydell wrote: On 15 October 2013 21:19, Mark Cave-Ayland wrote: +/* FCode ROM */ +memory_region_init_ram(&s->rom, NULL, "cg3.prom", FCODE_MAX_ROM_SIZE); +vmstate_register_ram_global(&s->rom); +memory_region_set_readonly(&s->rom, true); +sysbus_ini

Re: [Qemu-devel] [PATCH v3 0/2] target-ppc: Tidy sPAPR device tree CPU nodes

2013-10-17 Thread Alexander Graf
On 15.10.2013, at 18:33, Andreas Färber wrote: > Hello Alexey and Alex, > > This series cleans up the fdt CPU nodes for -M pseries as attempted by Prerna. > > v3 uses DeviceClass::fw_name for name storage exclusively, with > "PowerPC,UNKNOWN" > as fallback. Thanks, applied all to ppc-next.

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Alexey Kardashevskiy
On 10/16/2013 06:59 PM, Alexey Kardashevskiy wrote: > On 10/16/2013 05:36 PM, Paolo Bonzini wrote: >> Il 16/10/2013 07:04, Alexey Kardashevskiy ha scritto: >>> Hi! >>> >>> Normally on sPAPR platform the IBMVSCSI host bus adapter is used which is >>> SCSI. So when we want some image to appear as a D

Re: [Qemu-devel] [PATCH] qemu-iotests: fix 030 for faster machines

2013-10-17 Thread Stefan Hajnoczi
On Tue, Oct 15, 2013 at 10:41:51AM +0800, Fam Zheng wrote: > If the block job completes too fast, the test can fail. Change the > numbers so the qmp events are more stably captured by the script. > > A sleep is removed for the same reason. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests

Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete

2013-10-17 Thread Stefan Hajnoczi
On Wed, Oct 16, 2013 at 08:56:49PM +0200, Max Reitz wrote: > On 2013-10-15 04:23, Fam Zheng wrote: > The reason I object it here is that error_propagate *currently* is a > no-op. But this may change in the future: I have already sent an RFC > which extends error_propagate so it can generate an erro

Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete

2013-10-17 Thread Stefan Hajnoczi
On Wed, Oct 16, 2013 at 08:56:49PM +0200, Max Reitz wrote: > However, this is not the reason I'd object a patch doing > something different (here: dropping the unused backing_filename > code) BTW I agree with this. This should be a separate patch. Stefan

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 14:38, Alexey Kardashevskiy ha scritto: > qdev_get_fw_dev_path: > /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,2 suffix=(null) > /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,1 suffix=(null) You need to implement qdev_fw_get_path to change spapr-vio-bridge -> vdevice spapr-vscs

Re: [Qemu-devel] [PATCH] block/raw-win32: Always use -errno in hdev_open

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:30:16PM +0200, Max Reitz wrote: > On one occasion, hdev_open() returned -1 in case of an unknown error > instead of a proper -errno value. Adjust this to match the behavior of > raw_open() (in raw-win32), which is to return -EINVAL in this case. > Also, change the call to

Re: [Qemu-devel] [PATCH 1/1] e820: pass high memory too.

2013-10-17 Thread Andrea Arcangeli
Hi, On Thu, Oct 17, 2013 at 01:09:38PM +0200, Gerd Hoffmann wrote: > We have a fw_cfg entry to pass e820 entries from qemu to the firmware. > Today it's used to pass reservations only. This patch makes qemu pass > entries for RAM too. > > This allows to pass RAM sizes larger than 1TB to the firm

Re: [Qemu-devel] [PATCH v2] mirror: drop local_err in mirror_complete

2013-10-17 Thread Kevin Wolf
Am 17.10.2013 um 14:49 hat Stefan Hajnoczi geschrieben: > On Wed, Oct 16, 2013 at 08:56:49PM +0200, Max Reitz wrote: > > On 2013-10-15 04:23, Fam Zheng wrote: > > The reason I object it here is that error_propagate *currently* is a > > no-op. But this may change in the future: I have already sent a

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Alexander Graf
On 17.10.2013, at 14:54, Paolo Bonzini wrote: > Il 17/10/2013 14:38, Alexey Kardashevskiy ha scritto: >> qdev_get_fw_dev_path: >> /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,2 suffix=(null) >> /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,1 suffix=(null) > > You need to implement qdev_fw_ge

Re: [Qemu-devel] [PATCH v3 2/2] vmdk: Implment bdrv_get_specific_info

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 08:08:35PM +0800, Fam Zheng wrote: > @@ -814,6 +821,7 @@ static int vmdk_open_desc_file(BlockDriverState *bs, int > flags, > ret = -ENOTSUP; > goto exit; > } > +s->create_type = g_strdup(ct); Where is this freed if opening the file fails?

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Alexey Kardashevskiy
On 10/17/2013 11:54 PM, Paolo Bonzini wrote: > Il 17/10/2013 14:38, Alexey Kardashevskiy ha scritto: >> qdev_get_fw_dev_path: >> /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,2 suffix=(null) >> /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,1 suffix=(null) > > You need to implement qdev_fw_get_pa

Re: [Qemu-devel] [PATCH v2 5/6] util: Provide fallback hwcap and platform for powerpc

2013-10-17 Thread Richard Henderson
On 10/17/2013 05:03 AM, Peter Maydell wrote: > On 10 September 2013 23:07, Richard Henderson wrote: >> Allow host "detection" on non-linux hosts. >> >> Signed-off-by: Richard Henderson >> --- >> util/getauxval.c | 56 >> ++-- >> 1 file changed

Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock

2013-10-17 Thread Luiz Capitulino
On Wed, 16 Oct 2013 19:17:08 +0200 Paolo Bonzini wrote: > This lock does not protect anything that the BQL does not already > protect. Furthermore, with -nodefaults and no monitor, the mutex > is not initialized but monitor_protocol_event_queue is called > anyway, which causes a crash under ming

Re: [Qemu-devel] [PATCH] vmdk: Only read cid from image file when opening

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 03:55:39PM +0800, Fam Zheng wrote: > @@ -378,6 +359,22 @@ static int vmdk_parent_open(BlockDriverState *bs) > } > > pstrcpy(bs->backing_file, end_name - p_name + 1, p_name); > + > +ret = bdrv_open_backing_file(bs, NULL, errp); This breaks 'backin

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Alexey Kardashevskiy
On 10/18/2013 12:02 AM, Alexander Graf wrote: > > On 17.10.2013, at 14:54, Paolo Bonzini wrote: > >> Il 17/10/2013 14:38, Alexey Kardashevskiy ha scritto: >>> qdev_get_fw_dev_path: >>> /spapr-vio-bridge/spapr-vscsi/channel@0/disk@3,2 suffix=(null) >>> /spapr-vio-bridge/spapr-vscsi/channel@0/disk

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 15:09, Alexey Kardashevskiy ha scritto: >> In general, try to make QEMU produce SLOF APIs by modifying the devices >> that instantiate the buses. > > "channel@0" -> ""? This is a generic scsi bus, cannot change this. > "disk@3,2" -> "disk@8302"? This is a generic scsi-cd,

Re: [Qemu-devel] virtio-blk-pci: how to tell if it is CD or HDD?

2013-10-17 Thread Paolo Bonzini
Il 17/10/2013 15:36, Alexey Kardashevskiy ha scritto: >> > But please make sure to not block the path for non-SLOF machines. -M mac99 >> > should still be able to get different path names for PCI devices for >> > example. > Ok. Then question for you. I need to change root PHB name from > spapr-pc

[Qemu-devel] [PATCH 04/10] apic: Document why cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster Signed-off-by: Markus Armbruster --- hw/intc/apic_common.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index ea420c7..aaef054 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -38

[Qemu-devel] [PATCH 00/10] Clean up and fix no_user

2013-10-17 Thread armbru
From: Markus Armbruster In an ideal world, machines can be built by wiring devices together with configuration, not code. Unfortunately, that's not the world we live in right now. We still have quite a few devices that need to be wired up by code. If you try to device_add such a device, it'll

[Qemu-devel] [PATCH 08/10] vt82c686: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster A VT82C686B southbridge has multiple functions. We model each function as a separate qdev. One of them need some special wiring set up in mips_fulong2e_init() to work: the ISA bridge at 05.0. The IDE controller at 05.1 (via-ide) has always had cannot_instantiate_with_de

[Qemu-devel] [PATCH 02/10] sysbus: Set cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster device_add plugs devices into suitable bus. For "real" buses, that actually connects the device. For sysbus, the connections need to be made separately, and device_add can't do that. The device would be left unconncected, and could not possibly work. Many, but not all

[Qemu-devel] [PATCH 09/10] isa: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster Drop it when there's no obvious reason why device_add could not work. Else keep and document why. * isa-fdc, port92, i8042, m48t59_isa, mc146818rtc, isa-pit, kvm-pit: drop (from the last two by dropping it from their abstract base pit-common) * pcspk: keep because of

[Qemu-devel] [PATCH 01/10] qdev: Replace no_user by cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster In an ideal world, machines can be built by wiring devices together with configuration, not code. Unfortunately, that's not the world we live in right now. We still have quite a few devices that need to be wired up by code. If you try to device_add such a device, it'll

[Qemu-devel] [PATCH 10/10] qdev: Do not let the user try to device_add when it cannot work

2013-10-17 Thread armbru
From: Markus Armbruster Such devices have always been unavailable and omitted from the list of available devices shown by device_add help. Until commit 18b6dad silently broke the former, setting up nasty traps for unwary users, like this one: $ qemu-system-x86_64 -nodefaults -monitor stdio

[Qemu-devel] [PATCH 03/10] cpu: Document why cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster Signed-off-by: Markus Armbruster --- qom/cpu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index 09c15e6..6e0d54e 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -254,7 +254,11 @@ static void cpu_class_init(ObjectClass *klass

[Qemu-devel] [PATCH 06/10] ich9: Document why cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster An ICH9 southbridge contains several PCI devices, some of them with multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up in pc_q35_init() to work: the LPC controller at 00:1f.0, and the SMBus controller at 00:1f.3. S

[Qemu-devel] [PATCH 07/10] piix3 piix4: Clean up use of cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster A PIIX3/PIIX4 southbridge has multiple functions. We model each function as a separate qdev. Two of them need some special wiring set up in pc_init1() or mips_malta_init() to work: the ISA bridge at 01.0, and the SMBus controller at 01.3. The IDE controller at 01.1 (pii

[Qemu-devel] [PATCH 05/10] pci-host: Consistently set cannot_instantiate_with_device_add_yet

2013-10-17 Thread armbru
From: Markus Armbruster Many PCI host bridges consist of a sysbus device and a PCI device. You need both for the thing to work. Arguably, these bridges should be modelled as a single, composite devices instead of pairs of seemingly independent devices you can only use together, but we're not the

Re: [Qemu-devel] [PATCH v7 16/19] block: vhdx - add .bdrv_create() support

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 02:17:36PM -0400, Jeff Cody wrote: > +if (image_size > VHDX_MAX_IMAGE_SIZE) { > +fprintf(stderr, "Image size too large; max of 64TB\n"); Please use error_setg_errno(errp, EINVAL, "Image size too large; max of 64TB") instead of fprintf(). There are other instan

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform

2013-10-17 Thread Peter Maydell
On 15 October 2013 16:14, Tom Sutcliffe wrote: > > On 15 Oct 2013, at 16:00, Peter Maydell wrote: > >> On 15 October 2013 15:58, Tom Sutcliffe wrote: >>> Thumbs up from me testing on Arndale. My only issue is that virt and >>> vexpress-a15 add virtio-mmio devices in the opposite order to each o

Re: [Qemu-devel] [PATCH 1/1] e820: pass high memory too.

2013-10-17 Thread Gerd Hoffmann
On Do, 2013-10-17 at 15:00 +0200, Andrea Arcangeli wrote: > Hi, > > On Thu, Oct 17, 2013 at 01:09:38PM +0200, Gerd Hoffmann wrote: > > We have a fw_cfg entry to pass e820 entries from qemu to the firmware. > > Today it's used to pass reservations only. This patch makes qemu pass > > entries for R

[Qemu-devel] Watching Resource consumption of guest from Qemu ?

2013-10-17 Thread Sunil Agham
Hello List, I am a graduate student trying to learn about virtualization. I wanted to understand if there is any way to tell about resource consumption of guest through Qemu ? e.g. if guest starts doing something cpu intensive, would qemu be aware of that ? or is there a way to detect that from qe

Re: [Qemu-devel] PPC: Timer issues with git master

2013-10-17 Thread Mark Cave-Ayland
On 11/10/13 09:44, Paolo Bonzini wrote: I've just upgraded my git repository from around the 1.6 release timeframe to git master and I'm seeing some strange timing issues running through my OpenBIOS test suite which weren't there before my git update. The two most noticeable changes are in Free

[Qemu-devel] [PATCH uq/master] KVM: x86: fix typo in KVM_GET_XCRS

2013-10-17 Thread Paolo Bonzini
Only the first item of the array was ever looked at. No practical effect, but still worth fixing. Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 749aa09..27071e3 100644 --- a/

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform

2013-10-17 Thread Tom Sutcliffe
On 17 Oct 2013, at 15:30, Peter Maydell wrote: > On 15 October 2013 16:14, Tom Sutcliffe wrote: >> >> On 15 Oct 2013, at 16:00, Peter Maydell wrote: >> >>> On 15 October 2013 15:58, Tom Sutcliffe wrote: Thumbs up from me testing on Arndale. My only issue is that virt and vexpress

  1   2   >