Re: [Qemu-devel] KVM call for agenda for 2013-10-01

On 30/09/2013 10:53, Orit Wasserman wrote: On 09/24/2013 05:09 PM, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Agenda so far: - Talk about qemu reverse executin

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

Il 30/09/2013 11:06, Stefan Hajnoczi ha scritto: > I'd like to fix the win32 coroutine backend. > > In your email you said it can be reproduced under wine on Linux. I > wasn't able to reproduce it with this command-line: > > $ wine qemu-system-x86_64.exe -m 1024 -vnc :1 -L ../pc-bios -hda ../t

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

On Tue, Oct 01, 2013 at 07:51:24AM +0200, Stefan Weil wrote: > $ wine i386-softmmu/qemu-system-i386 -L pc-bios -cdrom /var/tmp/mini.iso > -sdl # or -vnc :1 > > => Assertion in qemu-coroutine-lock.c:99. Could you please provide the backtrace for this? I am curious which of the uses of qemu_co_que

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

Stefan Weil writes: > Am 30.09.2013 11:59, schrieb Markus Armbruster: >> Stefan Weil writes: >>> Am 29.09.2013 22:13, schrieb Michael Tokarev: 29.09.2013 19:41, Stefan Weil wrote: > The QEMU buildbot default_i386_debian_6_0 shows this warning: > >CCmigration.o > migr

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

On 23.09.2013 12:33, Sebastian Ottlik wrote: On 18.09.2013 18:58, Stefan Weil wrote: Am 16.09.2013 17:10, schrieb Sebastian Ottlik: On 16.09.2013 16:55, Paolo Bonzini wrote: Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: - Added the silent flag to socket_set_fast_reuse controlling error re

Re: [Qemu-devel] [PATCH v5 5/6] qemu-iotests: Discard specific info in _img_info

On 2013-09-30 19:14, Eric Blake wrote: On 09/23/2013 06:09 AM, Max Reitz wrote: In _img_info, filter out additional information specific to the image format provided by qemu-img info, since tests designed for multiple image formats would produce different outputs for every image format else. s/

Re: [Qemu-devel] [PATCH] qcow2: Switch L1 table in a single sequence

Am 30.09.2013 um 17:57 hat Max Reitz geschrieben: > Switching the L1 table in memory should be an atomic operation, as far > as possible. Calling qcow2_free_clusters on the old L1 table on disk is > not a good idea when the old L1 table is no longer valid and the address > to the new one hasn't yet

Re: [Qemu-devel] [PATCH qom-next for-next 0/5] QOM PCMCIA, MicroDrive and IDE cleanups

Has this one fallen through the cracks? Andreas Färber writes: > Hello, > > Based on an initial draft from Othmar Pasteka, this series QOM'ifies > MicroDrive. > As a prerequisite, PCMCIA must be QOM'ified as pointed out by Peter. We can > then > finally drop ide_init2_with_non_qdev_drives(), a

Re: [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info

On 2013-09-30 19:19, Eric Blake wrote: On 09/23/2013 06:09 AM, Max Reitz wrote: Add a test for the additional information now provided by qemu-img info when used on qcow2 images. Signed-off-by: Max Reitz --- tests/qemu-iotests/065 | 72 ++ tes

[Qemu-devel] [PATCH] turn firmware image filename into a machine option

Signed-off-by: Gerd Hoffmann --- hw/alpha/dp264.c| 2 +- hw/arm/highbank.c | 8 hw/i386/pc.c| 6 -- hw/i386/pc_piix.c | 3 ++- hw/i386/pc_q35.c| 3 ++- hw/i386/pc_sysfw.c | 8 +--- hw/lm32/milkymist.c | 8 hw/mips/m

Re: [Qemu-devel] [RFC PATCH 0/3] Fix UST backend for LTTng 2.x

mohamad.ge...@gmail.com writes: > These patches fix the UST backend which got broken by LTTng 2.x. > > An interesting new feature in LTTng 2.x is that tracepoints now need to belong > to a provider. A provider is a way to group tracepoints in a logical way, for > instance tracepoints that belong

Re: [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest

On Sun, 29 Sep 2013 13:58:21 +0300 "Michael S. Tsirkin" wrote: WS2008R2x64 BSODs with ACPI error on boot when 64bit PCI hole is present, but it boots fine with upstream QEMU [stock or acpi BIOS] QEMU cli: qemu-system-x86_64 -enable-kvm -monitor stdio -m 4096 test.qcow2 -device ivshmem,size=4G

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On 1 October 2013 18:39, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/alpha/dp264.c| 2 +- > hw/arm/highbank.c | 8 > hw/i386/pc.c| 6 -- > hw/i386/pc_piix.c | 3 ++- > hw/i386/pc_q35.c| 3 ++- > hw/i386/pc_sysfw.c

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On Di, 2013-10-01 at 19:55 +0900, Peter Maydell wrote: > On 1 October 2013 18:39, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > hw/alpha/dp264.c| 2 +- > > hw/arm/highbank.c | 8 > > hw/i386/pc.c| 6 -- > > hw/i386/pc_piix.c |

[Qemu-devel] [PATCH] hw/9pfs: Fix errno value for xattr functions

From: "Daniel P. Berrange" If there is no operation driver for the xattr type the functions return '-1' and set errno to '-EOPNOTSUPP'. When the calling code sets 'ret = -errno' this turns into a large positive number. In Linux 3.11, the kernel has switched to using 9p version 9p2000.L, instead

Re: [Qemu-devel] [PATCH v6 08/20] block: vhdx - log parsing, replay, and flush support

On Wed, Sep 25, 2013 at 05:02:53PM -0400, Jeff Cody wrote: > +static int vhdx_log_read_desc(BlockDriverState *bs, BDRVVHDXState *s, > + VHDXLogEntries *log, VHDXLogDescEntries > **buffer) > +{ > +int ret = 0; > +uint32_t desc_sectors; > +uint32_t sectors_re

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On 1 October 2013 20:22, Gerd Hoffmann wrote: > On Di, 2013-10-01 at 19:55 +0900, Peter Maydell wrote: >> No documentation or definition of what the semantics of >> specifying a "firmware image" filename are? > > "-machine firmware=$file" has the same effect as "-bios $file", which is > simliar to

Re: [Qemu-devel] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

Il 29/09/2013 17:41, Stefan Weil ha scritto: > The QEMU buildbot default_i386_debian_6_0 shows this warning: > > CCmigration.o > migration.c: In function 'qmp_query_migrate_capabilities': > migration.c:149: warning: > 'caps' may be used uninitialized in this function > > While changing thi

Re: [Qemu-devel] [PATCH v6 09/20] block: vhdx - add region overlap detection for image files

On Wed, Sep 25, 2013 at 05:02:54PM -0400, Jeff Cody wrote: > +/* Check for region overlaps inside the VHDX image */ > +static int vhdx_region_check(BDRVVHDXState *s, uint64_t start, uint64_t > length) > +{ > +int ret = 0; > +uint64_t end; > +VHDXRegionEntry *r; > + > +end = start +

[Qemu-devel] [PATCH] vl: Clean up unnecessary boot_order complications

From: Markus Armbruster Messed up in commit 8281abd. Signed-off-by: Markus Armbruster --- vl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 983cdc6..7e1f408 100644 --- a/vl.c +++ b/vl.c @@ -2825,7 +2825,7 @@ int main(int argc, char **argv, char **

Re: [Qemu-devel] [PATCH qom-next for-next 0/5] QOM PCMCIA, MicroDrive and IDE cleanups

Am 01.10.2013 11:15, schrieb Markus Armbruster: > Has this one fallen through the cracks? Nobody, including yourself, has felt responsable for reviewing this, and I wanted to get some form of test coverage in place before sending any pull, which I have just applied yesterday. :-) It has been rebas

Re: [Qemu-devel] [PATCH qom-next for-next 0/5] QOM PCMCIA, MicroDrive and IDE cleanups

Andreas Färber writes: > Am 01.10.2013 11:15, schrieb Markus Armbruster: >> Has this one fallen through the cracks? > > Nobody, including yourself, has felt responsable for reviewing this, and QOMification isn't exactly my home turf... > I wanted to get some form of test coverage in place befor

Re: [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest

On Tue, Oct 01, 2013 at 12:03:57PM +0200, Igor Mammedov wrote: > On Sun, 29 Sep 2013 13:58:21 +0300 > "Michael S. Tsirkin" wrote: > > WS2008R2x64 BSODs with ACPI error on boot when 64bit PCI hole is present, > but it boots fine with upstream QEMU [stock or acpi BIOS] > > QEMU cli: > > qemu-syst

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

Hi, > -bios we're stuck with because it's a legacy > option, What is legacy about it? Well, the x86-centric name of course. Thats why the machine option is named 'firmware' instead. It also doesn't use QemuOpts, which is fixed by this patch. Anything else? > >> Why is this a machine option

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

Hi, Am 01.10.2013 14:16, schrieb Gerd Hoffmann: >> -bios we're stuck with because it's a legacy >> option, > > What is legacy about it? > > Well, the x86-centric name of course. Thats why the machine option is > named 'firmware' instead. > > It also doesn't use QemuOpts, which is fixed by this

[Qemu-devel] [PATCH v6 0/6] Provide additional info through qemu-img info

qemu-img info provides only pretty general information about an image. For any image format, there might be specific options which cannot be represented in a universal way; for instance, qcow2 provides the compatibility and lazy_refcount options whose values are certainly interesting but currently

[Qemu-devel] [PATCH v6 4/6] qcow2: Add support for ImageInfoSpecific

Add a new ImageInfoSpecificQCow2 type as a subtype of ImageInfoSpecific. This contains the compatibility level as a string and an optional lazy_refcounts boolean (optional means mandatory for compat >= 1.1 and not available for compat == 0.10). Also, add qcow2_get_specific_info, which returns this

[Qemu-devel] [PATCH v6 5/6] qemu-iotests: Discard specific info in _img_info

In _img_info, filter out additional information specific to the image format provided by qemu-img info, since tests designed for multiple image formats would produce different outputs for every image format otherwise. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 20 +++

[Qemu-devel] [PATCH v6 1/6] qapi: Add ImageInfoSpecific type

Add a new type ImageInfoSpecific as a union for image format specific information in ImageInfo. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- qapi-schema.json | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index

[Qemu-devel] [PATCH v6 2/6] block: Add bdrv_get_specific_info

Add a function for retrieving an ImageInfoSpecific object from a block driver. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block.c | 9 + block/qapi.c | 3 +++ include/block/block.h | 1 + include/block/block_int.h | 1 + 4 files changed, 14 i

[Qemu-devel] [PATCH v6 3/6] block/qapi: Human-readable ImageInfoSpecific dump

Add a function for generically dumping the ImageInfoSpecific information in a human-readable format to block/qapi.c. Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to allow qemu-img info resp. qemu-io -c info to print that format specific information. Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v6 6/6] qemu-iotests: Additional info from qemu-img info

Add a test for the additional information now provided by qemu-img info when used on qcow2 images. This test only covers the human-readable output, not the JSON dump. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/065 | 72 +++

Re: [Qemu-devel] [PATCH v6 00/26] qemu: generate acpi tables for the guest

On Tue, Oct 01, 2013 at 12:03:57PM +0200, Igor Mammedov wrote: > On Sun, 29 Sep 2013 13:58:21 +0300 > "Michael S. Tsirkin" wrote: > > WS2008R2x64 BSODs with ACPI error on boot when 64bit PCI hole is present, > but it boots fine with upstream QEMU [stock or acpi BIOS] > > QEMU cli: > > qemu-syst

Re: [Qemu-devel] [PATCH v6 5/6] qemu-iotests: Discard specific info in _img_info

On 2013-10-01 14:32, Max Reitz wrote: In _img_info, filter out additional information specific to the image format provided by qemu-img info, since tests designed for multiple image formats would produce different outputs for every image format otherwise. Signed-off-by: Max Reitz Ah, I just not

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On 1 October 2013 21:16, Gerd Hoffmann wrote: > Hi, > >> -bios we're stuck with because it's a legacy >> option, > > What is legacy about it? The fact that we've had it since forever, it was introduced for a specific x86 use case and has since accreted behaviour rather than being designed. >>

Re: [Qemu-devel] [PATCH v6 0/6] Provide additional info through qemu-img info

On 10/01/2013 06:31 AM, Max Reitz wrote: > qemu-img info provides only pretty general information about an image. > For any image format, there might be specific options which cannot be > represented in a universal way; for instance, qcow2 provides the > compatibility and lazy_refcount options whos

Re: [Qemu-devel] [PATCH v6 10/20] block: vhdx - add log write support

On Wed, Sep 25, 2013 at 05:02:55PM -0400, Jeff Cody wrote: > +static int vhdx_log_write(BlockDriverState *bs, BDRVVHDXState *s, > + void *data, uint32_t length, uint64_t offset) > +{ > +int ret = 0; > +void *buffer = NULL; > +void *merged_sector = NULL; > +v

[Qemu-devel] [PATCH v2 04/17] blockdev: 'blockdev-add' QMP command

For examples see the changes to qmp-commands.hx. Signed-off-by: Kevin Wolf --- blockdev.c | 57 ++ qapi-schema.json | 236 +++ qmp-commands.hx | 59 ++ 3 files changed, 352 insertions(+) diff --git a/blockdev.c

[Qemu-devel] [PATCH v2 01/17] qapi-types/visit.py: Pass whole expr dict for structs

Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- scripts/qapi-types.py | 11 --- scripts/qapi-visit.py | 8 ++-- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 5222463..566fe5e 100644 --- a/scripts/qapi-types.

[Qemu-devel] [PATCH v2 06/17] blockdev: Pass QDict to blockdev_init()

Working on a QDict instead of a QemuOpts that accepts anything is more in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has anyway, so this saves additional conversions. And last, but not least, it allows later patches to easily extract legacy options into a separate, typed Qemu

[Qemu-devel] [PATCH v2 02/17] qapi-types/visit.py: Inheritance for structs

This introduces a new 'base' key for struct definitions that refers to another struct type. On the JSON level, the fields of the base type are included directly into the same namespace as the fields of the defined type, like with unions. On the C level, a pointer to a struct of the base type is inc

[Qemu-devel] [PATCH v2 11/17] blockdev: Move bus/unit/index processing to drive_init

This requires moving the automatic ID generation at the same time, so let's do that as well. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- blockdev.c | 157 - 1 file changed, 73 insertions(+), 84 deletions(-) diff --git a/block

[Qemu-devel] [PATCH v2 05/17] blockdev: Separate ID generation from DriveInfo creation

blockdev-add shouldn't automatically generate IDs, but will keep most of the DriveInfo creation code. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Wenchao Xia Reviewed-by: Eric Blake --- blockdev.c| 32 +--- include/qemu/option.h | 1 +

[Qemu-devel] [PATCH v2 00/17] blockdev-add QMP command

This series adds a blockdev-add QMP command and a row of cleanup patches to separate legacy -drive/drive_add behaviour from blockdev_init() to the wrapper function drive_init(). v2: - Removed I/O throttling and copy-on-read options from the schema: Both are candidates for becoming block filters

[Qemu-devel] [PATCH v2 03/17] blockdev: Introduce DriveInfo.enable_auto_del

BlockDriverStates shouldn't be affected by an unplugged guest device, except if created with the legacy -drive command line option or the drive_add HMP command. Make the automatic deletion as well as cancelling of jobs conditional on an enable_auto_del boolean that is only set in drive_init(). Si

[Qemu-devel] [PATCH v2 12/17] blockdev: Move virtio-blk device creation to drive_init

Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- blockdev.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/blockdev.c b/blockdev.c index 4a0ee17..8b1a0c1 100644 --- a/blockdev.c +++ b/blockdev.c @@ -318,7 +318,6 @@

[Qemu-devel] [PATCH v2 17/17] blockdev: blockdev_init() error conversion

This gives us meaningful error messages for the blockdev-add QMP command. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- blockdev.c | 59 +-- 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/blockdev.c b/blockdev.c ind

[Qemu-devel] [PATCH v2 08/17] blockdev: Move parsing of 'if' option to drive_init

It's always IF_NONE for blockdev-add. Signed-off-by: Kevin Wolf --- blockdev.c | 40 ++-- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/blockdev.c b/blockdev.c index d364dca..ce1208f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -309,14 +309,13

[Qemu-devel] [PATCH v2 13/17] blockdev: Remove IF_* check for read-only blockdev_init

IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which the check would have errored out check in their init function that they don't get a read-only BlockDriverState. This catches even cases where IF_NO

[Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init

This moves all of the geometry options (cyls/heads/secs/trans) to drive_init so that they can only be accessed using legacy functions, but never with anything blockdev-add related. Signed-off-by: Kevin Wolf --- blockdev.c | 136 +++-- 1 fil

[Qemu-devel] [PATCH v2 14/17] qemu-iotests: Check autodel behaviour for device_del

Block devices creates with -drive and drive_add should automatically disappear if the guest device is unplugged. blockdev-add ones shouldn't. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- tests/qemu-iotests/064 | 133 +++ tests/qemu-iotests/0

[Qemu-devel] [PATCH v2 07/17] blockdev: Move parsing of 'media' option to drive_init

This moves as much as possible of the processing of the 'media' option to drive_init so that it can only be accessed using legacy functions, but never with anything blockdev-add related. Signed-off-by: Kevin Wolf Reviewed-by: Benoit Canet --- blockdev.c | 73

Re: [Qemu-devel] [PATCH v6 08/20] block: vhdx - log parsing, replay, and flush support

On Tue, Oct 01, 2013 at 01:31:36PM +0200, Stefan Hajnoczi wrote: > On Wed, Sep 25, 2013 at 05:02:53PM -0400, Jeff Cody wrote: > > +static int vhdx_log_read_desc(BlockDriverState *bs, BDRVVHDXState *s, > > + VHDXLogEntries *log, VHDXLogDescEntries > > **buffer) > > +{ >

[Qemu-devel] [PATCH v2 15/17] blockdev: Remove 'media' parameter from blockdev_init()

The remaining users shouldn't be there with blockdev-add and are easy to move to drive_init(). Bonus bug fix: As a side effect, CD-ROM drives can now use block drivers on the read-only whitelist without explicitly specifying read-only=on, even if a format is explicitly specified. Signed-off-by: K

[Qemu-devel] [PATCH v2 16/17] blockdev: Don't disable COR automatically with blockdev-add

If a read-only device is configured with copy-on-read=on, the old code only prints a warning and automatically disables copy on read. Make it a real error for blockdev-add. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz --- block.c| 9 +++-- blockdev.c | 31 ++

Re: [Qemu-devel] [PATCH v6 11/20] block: vhdx write support

On Wed, Sep 25, 2013 at 05:02:56PM -0400, Jeff Cody wrote: > @@ -1070,7 +1070,43 @@ exit: > return ret; > } > > +/* > + * Allocate a new payload block at the end of the file. > + * > + * Allocation will happen at 1MB alignment inside the file > + * > + * Returns the file offset start of the

Re: [Qemu-devel] [PATCH v6 10/20] block: vhdx - add log write support

On Wed, Sep 25, 2013 at 05:02:55PM -0400, Jeff Cody wrote: > +/* Perform a log write, and then immediately flush the entire log */ > +int vhdx_log_write_and_flush(BlockDriverState *bs, BDRVVHDXState *s, > + void *data, uint32_t length, uint64_t offset) > +{ > +int re

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

> > --- a/hw/arm/highbank.c > > +++ b/hw/arm/highbank.c > > @@ -250,15 +250,15 @@ static void calxeda_init(QEMUMachineInitArgs *args, > > enum cxmachines machine) > > sysram = g_new(MemoryRegion, 1); > > memory_region_init_ram(sysram, NULL, "highbank.sysram", 0x8000); > > memory_

[Qemu-devel] [PATCH v2 10/17] blockdev: Move parsing of 'boot' option to drive_init

It's already ignored and only prints a deprecation message. No use in making it available in new interfaces. Signed-off-by: Kevin Wolf --- blockdev.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/blockdev.c b/blockdev.c index 033202d..1888941 100644

Re: [Qemu-devel] [PATCH v6 13/20] block: vhdx - move more endian translations to vhdx-endian.c

On Wed, Sep 25, 2013 at 05:02:58PM -0400, Jeff Cody wrote: > In preperation for vhdx_create(), move more endian translation s/preperation/preparation/

Re: [Qemu-devel] [PATCH v6 00/20] VHDX log replay and write support, .bdrv_create()

On Wed, Sep 25, 2013 at 05:02:45PM -0400, Jeff Cody wrote: > > This patch series contains the initial VHDX log parsing, replay, > write support, and image creation. > > === v6 changes === > https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v6-upstream > > Rebased to latest qemu/master: >

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On Di, 2013-10-01 at 14:20 +0200, Andreas Färber wrote: > Hi, > > Am 01.10.2013 14:16, schrieb Gerd Hoffmann: > >> -bios we're stuck with because it's a legacy > >> option, > > > > What is legacy about it? > > > > Well, the x86-centric name of course. Thats why the machine option is > > named '

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

Am 01.10.2013 15:41, schrieb Gerd Hoffmann: > On Di, 2013-10-01 at 14:20 +0200, Andreas Färber wrote: >> Hi, >> >> Am 01.10.2013 14:16, schrieb Gerd Hoffmann: -bios we're stuck with because it's a legacy option, >>> >>> What is legacy about it? >>> >>> Well, the x86-centric name of course

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

On Mon, 30 Sep 2013 19:09:38 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 30, 2013 at 05:55:50PM +0200, Andreas Färber wrote: > > Am 30.09.2013 17:50, schrieb Michael S. Tsirkin: > > > On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote: > > >> On 30 September 2013 23:40, Michael S.

Re: [Qemu-devel] [PATCH v6 09/20] block: vhdx - add region overlap detection for image files

On Tue, Oct 01, 2013 at 01:42:18PM +0200, Stefan Hajnoczi wrote: > On Wed, Sep 25, 2013 at 05:02:54PM -0400, Jeff Cody wrote: > > +/* Check for region overlaps inside the VHDX image */ > > +static int vhdx_region_check(BDRVVHDXState *s, uint64_t start, uint64_t > > length) > > +{ > > +int ret

Re: [Qemu-devel] [PATCH v6 10/20] block: vhdx - add log write support

On Tue, Oct 01, 2013 at 03:04:15PM +0200, Stefan Hajnoczi wrote: > On Wed, Sep 25, 2013 at 05:02:55PM -0400, Jeff Cody wrote: > > +static int vhdx_log_write(BlockDriverState *bs, BDRVVHDXState *s, > > + void *data, uint32_t length, uint64_t offset) > > +{ > > +int ret =

Re: [Qemu-devel] [PATCH v6 11/20] block: vhdx write support

On Tue, Oct 01, 2013 at 03:29:17PM +0200, Stefan Hajnoczi wrote: > On Wed, Sep 25, 2013 at 05:02:56PM -0400, Jeff Cody wrote: > > @@ -1070,7 +1070,43 @@ exit: > > return ret; > > } > > > > +/* > > + * Allocate a new payload block at the end of the file. > > + * > > + * Allocation will happe

Re: [Qemu-devel] [PATCH v2 04/17] blockdev: 'blockdev-add' QMP command

Le Tuesday 01 Oct 2013 à 15:20:06 (+0200), Kevin Wolf a écrit : > For examples see the changes to qmp-commands.hx. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 57 ++ > qapi-schema.json | 236 > +++ > qmp-commands.hx

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

On Tue, Oct 01, 2013 at 03:46:15PM +0200, Igor Mammedov wrote: > On Mon, 30 Sep 2013 19:09:38 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Sep 30, 2013 at 05:55:50PM +0200, Andreas Färber wrote: > > > Am 30.09.2013 17:50, schrieb Michael S. Tsirkin: > > > > On Tue, Oct 01, 2013 at 12:10:52AM

Re: [Qemu-devel] [PATCH v6 00/20] VHDX log replay and write support, .bdrv_create()

On Tue, Oct 01, 2013 at 03:41:04PM +0200, Stefan Hajnoczi wrote: > On Wed, Sep 25, 2013 at 05:02:45PM -0400, Jeff Cody wrote: > > > > This patch series contains the initial VHDX log parsing, replay, > > write support, and image creation. > > > > === v6 changes === > > https://github.com/codyprime

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

On 10/01/2013 03:08 AM, Peter Maydell wrote: > On 1 October 2013 00:57, Fabien Chouteau wrote: > >> +#define MD_I64 0 >> +#define MD_I32 1 > >> -#define MD_TLONG 0 >> -#define MD_I32 1 > >> -{ "eax", offsetof(CPUX86State, regs[0]) }, >> -{ "ecx", offsetof(CPUX86State, regs[1]) }, > >

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On 10/01/2013 11:46 PM, Andreas Färber wrote: > Am 01.10.2013 15:41, schrieb Gerd Hoffmann: >> On Di, 2013-10-01 at 14:20 +0200, Andreas Färber wrote: >>> Hi, >>> >>> Am 01.10.2013 14:16, schrieb Gerd Hoffmann: > -bios we're stuck with because it's a legacy > option, What is legac

[Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

Forgot to add: Reproduced the above behavior in both 1.5.1 and 1.6.0. Adding -no-hpet to commandline removed both problems (full disclosure: this fix wasn't tested in 1.5.1 but I have no reason to believe behavior would be different.) -- You received this bug notification because you are a member

[Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

Apparently this bug's still alive and kicking. There's an obvious clock skew problem on Windows 7; in the Date & Time dialog, the clock jumps through seconds visibly too fast. I also found a case where HPET bugs are causing a real problem: Terraria (dedicated server) seems to be relying on (somet

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

On 10/01/2013 04:00 AM, Richard Henderson wrote: > On 09/30/2013 08:57 AM, Fabien Chouteau wrote: >> +extern const MonitorDef arch_monitor_defs[]; > > This is supplied by target-foo/monitor.c, right? > Why in the world is it declared in generic code? > Yes, why? > Especially if it's only ever acc

Re: [Qemu-devel] [PATCH V3 1/7] snapshot: distinguish id and name in load_tmp

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Since later this function will be used so improve it. The only caller of it > now is qemu-img, and it is not impacted by introduce function > bdrv_snapshot_load_tmp_by_id_or_name() that call bdrv_snapshot_load_tmp() > twice to keep old search logic. bdrv

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

Hi, > SLOF is what is loaded from the very beginning, it configures PCI, cooks > the device tree and boots the guest system (directly or via yaboot/grub, > from disk, network or ram). Normal firmware, as usual. It knows all the > details about the machine so the guest system (linux) does not nee

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On 10/01/2013 04:40 PM, Gerd Hoffmann wrote: Hi, SLOF is what is loaded from the very beginning, it configures PCI, cooks the device tree and boots the guest system (directly or via yaboot/grub, from disk, network or ram). Normal firmware, as usual. It knows all the details about the machine

Re: [Qemu-devel] [PATCH V3 2/7] qemu-nbd: support internal snapshot export

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Now it is possible to directly export an internal snapshot, which > can be used to probe the snapshot's contents without qemu-img > convert. > > Signed-off-by: Wenchao Xia > --- > block/snapshot.c | 18 ++ > include/block/sna

Re: [Qemu-devel] [PATCH V3 3/7] qemu-nbd: add doc for internal snapshot export

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > qemu-nbd.c| 11 ++- > qemu-nbd.texi | 11 ++- > 2 files changed, 20 insertions(+), 2 deletions(-) This should be squashed into 2/7. When adding new options, the documentation should be added

Re: [Qemu-devel] [PATCH V3 4/7] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > +_export_nbd_snapshot() > +{ > +eval "$QEMU_NBD -v -t -b 127.0.0.1 -p $nbd_snapshot_port $TEST_IMG -l $1 > &" Uggh. Why do you need an eval here? Especially given that there was recently a patch to properly qu

Re: [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in convert

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Now qemu-img convert have similar options as qemu-nbd for internal > snapshot. > > Signed-off-by: Wenchao Xia > --- > qemu-img.c | 30 +- > 1 files changed, 21 insertions(+), 9 deletions(-) > > diff --git a/qemu-img.c b/

[Qemu-devel] KVM call for agenda for 2013-10-15

Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Call details: 10:00 AM to 11:00 AM EDT Every two weeks If you need phone number details, contact me privately.

Re: [Qemu-devel] [PATCH V3 6/7] qemu-img: add doc for param -L in convert

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Also renamed snapshot_name to snapshot_id_or_name to tip better. s/to tip better/as a better hint of what it does/ > > Signed-off-by: Wenchao Xia > --- > qemu-img-cmds.hx |2 +- > qemu-img.c |2 ++ > qemu-img.texi|7 +-- >

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

On 1 October 2013 23:23, Fabien Chouteau wrote: > On 10/01/2013 03:08 AM, Peter Maydell wrote: >> I like this generally, but this detail is wrong. These changes >> mean that these registers (and many others) are now described >> as being int64_t wide rather than target_long wide, so you'll >> find

Re: [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for snapshot in qemu-img convert

On 09/25/2013 06:16 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > @@ -53,6 +55,7 @@ _cleanup() > kill $NBD_SNAPSHOT_PID > fi > _cleanup_test_img > +rm -f $converted_image Indentation is off. -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

Il 01/10/2013 15:00, Peter Maydell ha scritto: > > Some don't. They just memcpy the firmware into guest ram instead. > > ...is that a good thing? What does the real hardware do? Should we > be doing that instead? Isn't this awkward on reset? They probably have a ROM (which should be the real "-m

Re: [Qemu-devel] [PATCH v2 08/17] blockdev: Move parsing of 'if' option to drive_init

Le Tuesday 01 Oct 2013 à 15:20:10 (+0200), Kevin Wolf a écrit : > It's always IF_NONE for blockdev-add. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 40 ++-- > 1 file changed, 22 insertions(+), 18 deletions(-) > > diff --git a/blockdev.c b/blockdev.c >

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On Di, 2013-10-01 at 22:00 +0900, Peter Maydell wrote: > On 1 October 2013 21:16, Gerd Hoffmann wrote: > > Hi, > > > >> -bios we're stuck with because it's a legacy > >> option, > > > > What is legacy about it? > > The fact that we've had it since forever, it was introduced for > a specific x86

[Qemu-devel] KVM call minutes for 2013-10-01

2013-10-01 -- - acpi generation patches - ok to merge? - Talk about qemu reverse executing (1st description was done this week) How to handle IO when we want to do reverse execution. How this relate to Kemari needs? And to icount changes? a- Save state every second. When something

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

On 10/01/2013 07:28 AM, Fabien Chouteau wrote: > On 10/01/2013 04:00 AM, Richard Henderson wrote: >> On 09/30/2013 08:57 AM, Fabien Chouteau wrote: >>> +extern const MonitorDef arch_monitor_defs[]; >> >> This is supplied by target-foo/monitor.c, right? >> Why in the world is it declared in generic

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

On 2 October 2013 00:05, Gerd Hoffmann wrote: > I just need some way to have different default firmware images for > different pc machine type versions. Requests to considering other > firmware loading needs (such as the two images needed for sPAPR) when > doing this is reasonable. Blaming me fo

Re: [Qemu-devel] KVM call minutes for 2013-10-01

On 1 October 2013 23:54, Juan Quintela wrote: > - Multicore on Multicore: > TCG has no locking, no people really working there (Alex Graf?) Apart from the TCG locking issues (which are conceptually tractable if anybody cares to try to fix them), the real complication of multicore-on-multicore

Re: [Qemu-devel] [PATCH v2 02/17] qapi-types/visit.py: Inheritance for structs

On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This introduces a new 'base' key for struct definitions that refers to > another struct type. On the JSON level, the fields of the base type are > included directly into the same namespace as the fields of the defined > type, like with unions. On the C le

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

On 2 October 2013 00:13, Richard Henderson wrote: > On 10/01/2013 07:28 AM, Fabien Chouteau wrote: >> On 10/01/2013 04:00 AM, Richard Henderson wrote: >>> On 09/30/2013 08:57 AM, Fabien Chouteau wrote: +extern const MonitorDef arch_monitor_defs[]; >>> >>> This is supplied by target-foo/monito

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

Il 01/10/2013 17:12, Peter Maydell ha scritto: >> > I just need some way to have different default firmware images for >> > different pc machine type versions. Requests to considering other >> > firmware loading needs (such as the two images needed for sPAPR) when >> > doing this is reasonable. B

Re: [Qemu-devel] [PATCH 2/2] machine type dependant bios

On Tue, Oct 1, 2013 at 1:27 AM, Paolo Bonzini wrote: > Il 01/10/2013 00:57, Anthony Liguori ha scritto: > > On Mon, Sep 30, 2013 at 5:43 PM, Paolo Bonzini > > wrote: > > > > Il 01/10/2013 00:08, Anthony Liguori ha scritto: > > > Wouldn't this be logical as a m

Re: [Qemu-devel] [PATCH V3] block: Add BlockDriver.bdrv_check_ext_snapshot.

Le Monday 30 Sep 2013 à 13:36:55 (+0200), Benoît Canet a écrit : > This field is used by blkverify to disable external snapshots creation. > I will also be used by block filters like quorum to disable external snapshots > creation. > > Signed-off-by: Benoit Canet > --- > block.c

Re: [Qemu-devel] [PATCH v2 00/17] blockdev-add QMP command

On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This series adds a blockdev-add QMP command and a row of cleanup patches to > separate legacy -drive/drive_add behaviour from blockdev_init() to the wrapper > function drive_init(). > > v2: > > - Removed I/O throttling and copy-on-read options from the

Re: [Qemu-devel] [PATCH v2 04/17] blockdev: 'blockdev-add' QMP command

On 10/01/2013 07:20 AM, Kevin Wolf wrote: > For examples see the changes to qmp-commands.hx. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 57 ++ > qapi-schema.json | 236 > +++ > qmp-commands.hx | 59 ++ >

  1   2   3   >