Re: [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block

2013-09-23 Thread Wenchao Xia
于 2013/9/16 22:27, Wenchao Xia 写道: 于 2013/9/16 18:02, Paolo Bonzini 写道: Il 16/09/2013 06:59, Wenchao Xia ha scritto: 于 2013/9/12 17:31, Paolo Bonzini 写道: Il 12/09/2013 11:15, Wenchao Xia ha scritto: This series will remove the usage of symbols of mon-protocol-event in qemu-img, qemu-nbd and q

Re: [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block

2013-09-23 Thread Paolo Bonzini
Il 23/09/2013 21:06, Wenchao Xia ha scritto: >> > > Hi Paolo, > This series tries to find a mechanism, which can avoid link with unused > symbols. Assume QObject was replaced with other design, such as QAPI, it > will still call monitor funcions to emit the event, so it will still > require > re

Re: [Qemu-devel] [PATCH 13/17] blockdev: Remove IF_* check for read-only blockdev_init

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which the check would have errored out check in their init function that they don't get a read-only BlockDriverS

Re: [Qemu-devel] [PATCH 13/17] blockdev: Remove IF_* check for read-only blockdev_init

2013-09-23 Thread Kevin Wolf
Am 23.09.2013 um 10:00 hat Max Reitz geschrieben: > On 2013-09-20 13:54, Kevin Wolf wrote: > >IF_NONE allows read-only, which makes forbidding it in this place > >for other types pretty much pointless. > > > >Instead, make sure that all devices for which the check would have > >errored out check in

Re: [Qemu-devel] [PATCH 05/17] blockdev: Separate ID generation from DriveInfo creation

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: blockdev-add shouldn't automatically generate IDs, but will keep most of the DriveInfo creation code. Signed-off-by: Kevin Wolf --- blockdev.c| 32 +--- include/qemu/option.h | 1 + util/qemu-option.c| 6 ++

Re: [Qemu-devel] [PATCH 11/17] blockdev: Move bus/unit/index processing to drive_init

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: This requires moving the automatic ID generation at the same time, so let's do that as well. Signed-off-by: Kevin Wolf --- blockdev.c | 157 - 1 file changed, 73 insertions(+), 84 deletions(-)

Re: [Qemu-devel] [PATCH 12/17] blockdev: Move virtio-blk device creation to drive_init

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- blockdev.c | 54 +++--- 1 file changed, 27 insertions(+), 27 deletions(-) Aside from return NULL instead of goto fail: Reviewed-by: Max Reitz

Re: [Qemu-devel] [PATCH 14/17] qemu-iotests: Check autodel behaviour for device_del

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: Block devices creates with -drive and drive_add should automatically disappear if the guest device is unplugged. blockdev-add ones shouldn't. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/064 | 133 +++ t

Re: [Qemu-devel] [PATCH 15/17] blockdev: Remove 'media' parameter from blockdev_init()

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: The remaining users shouldn't be there with blockdev-add and are easy to move to drive_init(). Bonus bug fix: As a side effect, CD-ROM drives can now use block drivers on the read-only whitelist without explicitly specifying read-only=on, even if a format i

Re: [Qemu-devel] [PATCH 17/17] blockdev: blockdev_init() error conversion

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: This gives us meaningful error messages for the blockdev-add QMP command. Signed-off-by: Kevin Wolf --- blockdev.c | 59 +-- 1 file changed, 33 insertions(+), 26 deletions(-) Reviewed-by: Max Rei

Re: [Qemu-devel] [PATCH 16/17] blockdev: Don't disable COR automatically with blockdev-add

2013-09-23 Thread Max Reitz
On 2013-09-20 13:54, Kevin Wolf wrote: If a read-only device is configured with copy-on-read=on, the old code only prints a warning and automatically disables copy on read. Make it a real error for blockdev-add. Signed-off-by: Kevin Wolf --- block.c| 9 +++-- blockdev.c | 31 +++

Re: [Qemu-devel] [PATCH 0/2] block: fix backing file overriding

2013-09-23 Thread Kevin Wolf
Am 22.09.2013 um 14:05 hat Fam Zheng geschrieben: > The backing.file.filename option is not working as expected: if there's also a > backing file name from the format driver, adding this option fails bdrv_open; > if there's no backing file name info in the image, "info block" doesn't show > the ove

[Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-23 Thread Fam Zheng
We use the extent size as cluster size for flat extents (where no L1/L2 table is allocated so it's safe) reuse sector calculating code with sparse extents. Don't pass in the cluster size for adding flat extent, just set it to sectors later, then the cluster size checking will not fail. The cluste

Re: [Qemu-devel] [PATCH] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-23 Thread Kevin Wolf
Am 20.09.2013 um 22:24 hat Benoît Canet geschrieben: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. > > The first driver of this type will be the quorum driver. > > Signed-off-by: Benoit Canet > --- > block.c

Re: [Qemu-devel] [PATCH v4 19/23] piix: APIs for pc guest info

2013-09-23 Thread Igor Mammedov
On Sun, 22 Sep 2013 16:37:59 +0300 "Michael S. Tsirkin" wrote: > This adds APIs that will be used to fill in guest acpi tables. > Some required information is still lacking in QOM, so we > fall back on lookups by type and returning explicit types. > > Signed-off-by: Michael S. Tsirkin > --- >

Re: [Qemu-devel] [PATCH] linux-user: Emulate SOCK_CLOEXEC/NONBLOCK if unavailable

2013-09-23 Thread Riku Voipio
Hi, On Mon, Sep 16, 2013 at 03:08:06PM +0200, edgar.igles...@gmail.com wrote: > From: "Edgar E. Iglesias" > > If the host lacks support for SOCK_CLOEXEC or SOCK_NONBLOCK, > try to emulate them with fcntl() FD_CLOEXEC and O_NONBLOCK. Last time emulating CLOEXEC with fcntl was discussed, the idea

Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-23 Thread Fam Zheng
On Mon, 09/23 17:18, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe) reuse sector calculating code with > sparse extents. > > Don't pass in the cluster size for adding flat extent, just set it to > sectors later, then th

[Qemu-devel] [PATCH 2/7] roms: enable parallel builds for 'make lgplvgabios'

2013-09-23 Thread Gerd Hoffmann
Recurse into vgabios once, adjust dependencies, call make using $(MAKE) $(MAKEFLAGS) so jobserver mode works. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index b646060..6d4330f 100644 --

[Qemu-devel] [PATCH 6/7] roms: add rules to build slof

2013-09-23 Thread Gerd Hoffmann
Add some logic to detect cross compilers. Add support for "make slof", which should JustWork[tm] if you are on a ppx64 machine or have a ppc64 cross compiler installed somewhere in your path. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 22 ++ 1 file changed, 22 insertio

[Qemu-devel] [PATCH 1/7] roms: add 'make clean'

2013-09-23 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- roms/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 7a228ae..b646060 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -75,3 +75,10 @@ efi-rom-%: ipxe/src/config/local/general.h ipxe/src/config/local/%: c

[Qemu-devel] [PATCH 3/7] roms: build lgplvgabios isavga variant

2013-09-23 Thread Gerd Hoffmann
Add logic to also build+install the isavga vgabios variant. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index 6d4330f..11d7837 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -1,6 +1,6 @@

[Qemu-devel] [PATCH 0/7] roms: build improvements

2013-09-23 Thread Gerd Hoffmann
Hi, Here comes a patch series with a bunch of improvements for rom builds. It enables parallel builds for some of the roms, and it starts adding support for cross builds. cheers, Gerd Gerd Hoffmann (7): roms: add 'make clean' roms: enable parallel builds for 'make lgplvgabios' roms: bu

[Qemu-devel] [PATCH 7/7] roms: enable ipxe cross builds

2013-09-23 Thread Gerd Hoffmann
--- roms/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roms/Makefile b/roms/Makefile index 5fcc77d..1966f04 100644 --- a/roms/Makefile +++ b/roms/Makefile @@ -31,6 +31,7 @@ find-cross-gcc = $(firstword $(wildcard $(patsubst %ld,%gcc,$(call find-cross-ld find-cross-prefix = $(su

[Qemu-devel] [PATCH 4/7] roms: parallel ipxe builds

2013-09-23 Thread Gerd Hoffmann
Enable parallel ipxe builds. Reduce the recursive make calls. Call recursive make properly using $(MAKE) $(MAKEFLAGS). Signed-off-by: Gerd Hoffmann --- roms/Makefile | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/roms/Makefile b/roms/Makefile index 11d7

[Qemu-devel] [PATCH 5/7] roms: rewrite scripts/refresh-pxe-roms.sh

2013-09-23 Thread Gerd Hoffmann
Just use the Makefile in roms/ Signed-off-by: Gerd Hoffmann --- scripts/refresh-pxe-roms.sh | 80 - 1 file changed, 6 insertions(+), 74 deletions(-) diff --git a/scripts/refresh-pxe-roms.sh b/scripts/refresh-pxe-roms.sh index 14d5860..90fc0b3 100755 -

Re: [Qemu-devel] [PATCH v4 19/23] piix: APIs for pc guest info

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 11:27:09AM +0200, Igor Mammedov wrote: > On Sun, 22 Sep 2013 16:37:59 +0300 > "Michael S. Tsirkin" wrote: > > > This adds APIs that will be used to fill in guest acpi tables. > > Some required information is still lacking in QOM, so we > > fall back on lookups by type and

Re: [Qemu-devel] [PATCH V2 2/4] qemu-nbd: support internal snapshot export

2013-09-23 Thread Paolo Bonzini
Il 22/09/2013 11:39, Wenchao Xia ha scritto: > Now it is possible to directly export an internal snapshot, which > can be used to probe the snapshot's contents without qemu-img > convert. > > Signed-off-by: Wenchao Xia > --- > qemu-nbd.c | 54 +++

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-23 Thread Sebastian Ottlik
On 18.09.2013 18:58, Stefan Weil wrote: Am 16.09.2013 17:10, schrieb Sebastian Ottlik: On 16.09.2013 16:55, Paolo Bonzini wrote: Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: - Added the silent flag to socket_set_fast_reuse controlling error reporting One location where SO_REUSEADDR wa

Re: [Qemu-devel] [PATCH 0/4] qom: add helpers for integer properties

2013-09-23 Thread Paolo Bonzini
Il 22/09/2013 09:16, Michael S. Tsirkin ha scritto: > Add helper functions for adding read-only properties, that work in the > case where the value is in memory. > > Michael S. Tsirkin (4): > qemu: add Error to typedefs > qom: pull in qemu/typedefs > qom: cleanup struct Error references >

[Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Marcel Apfelbaum
This patch is implemented on top of series: [PATCH v5 0/3] pci: implement upstream master abort protocol Added "master abort io" background region for PCIBus. Added "master abort mem" region to catch transactions initiated by pci devices targeted to unassigned addresses. Enabled "master abort" r

Re: [Qemu-devel] [PATCH v4 19/23] piix: APIs for pc guest info

2013-09-23 Thread Igor Mammedov
On Mon, 23 Sep 2013 13:10:49 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 23, 2013 at 11:27:09AM +0200, Igor Mammedov wrote: > > On Sun, 22 Sep 2013 16:37:59 +0300 > > "Michael S. Tsirkin" wrote: > > > > > This adds APIs that will be used to fill in guest acpi tables. > > > Some required inf

Re: [Qemu-devel] [PATCH 1/2] ich9: update sci on gpe write

2013-09-23 Thread Hu Tao
On Thu, Sep 12, 2013 at 05:22:14PM +0200, Igor Mammedov wrote: > On Wed, 21 Aug 2013 17:04:27 +0800 > Hu Tao wrote: > > > OSPM may disable the sci by clearing GPEx_BLK EN bit, in the case > > we have to set sci level to 0 or guest will receive sci interrupts > > endlessly. > > Could you make a m

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 02:01:17PM +0300, Marcel Apfelbaum wrote: > This patch is implemented on top of series: > [PATCH v5 0/3] pci: implement upstream master abort protocol > > Added "master abort io" background region for PCIBus. > > Added "master abort mem" region to catch transactions initia

Re: [Qemu-devel] [PATCH v4 19/23] piix: APIs for pc guest info

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 01:14:11PM +0200, Igor Mammedov wrote: > On Mon, 23 Sep 2013 13:10:49 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Sep 23, 2013 at 11:27:09AM +0200, Igor Mammedov wrote: > > > On Sun, 22 Sep 2013 16:37:59 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > This ad

Re: [Qemu-devel] [PATCH] linux-user: Emulate SOCK_CLOEXEC/NONBLOCK if unavailable

2013-09-23 Thread Edgar E. Iglesias
On Mon, Sep 23, 2013 at 12:37:10PM +0300, Riku Voipio wrote: > Hi, Hi Riku, > > On Mon, Sep 16, 2013 at 03:08:06PM +0200, edgar.igles...@gmail.com wrote: > > From: "Edgar E. Iglesias" > > > > If the host lacks support for SOCK_CLOEXEC or SOCK_NONBLOCK, > > try to emulate them with fcntl() FD_C

[Qemu-devel] [PATCH V2] introduce .bdrv_needs_filename

2013-09-23 Thread Benoît Canet
since v1: simplify assertion [Kevin] add .bdrv_needs_filename only to driver to having .bdrv_parse_filename nor .bdrv_open [Kevin] Tested that raw, qed and ssh protocols works fine. Benoît Canet (1): block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

[Qemu-devel] [PATCH V2] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-23 Thread Benoît Canet
Some drivers will have driver specifics options but no filename. This new bool allow the block layer to treat them correctly. The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and not having .bdrv_open. The first exception to this rule will be the quorum driver. Signed-o

Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-23 Thread Riku Voipio
On Thu, Sep 19, 2013 at 07:31:51PM +0200, Stefan Weil wrote: > Ping? Are there any more opinions how qemu-sparc64 should be fixed? > Should we choose Peter's approach (which is good, but with a > higher risk than my patch)? I've included it now in my qeu, since it fixes qemu-sparc64 in my smoketes

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-09-23 Thread Peter Maydell
On 23 September 2013 11:14, Christoffer Dall wrote: > On Sat, Sep 21, 2013 at 06:38:19PM +0900, Peter Maydell wrote: > (2) How does the arm_gic_kvm.c code detect the underlying host CPU that > the kernel read the register from when it returned the value of the > register to do the prope

Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-23 Thread Peter Maydell
On 23 September 2013 20:57, Riku Voipio wrote: > On Thu, Sep 19, 2013 at 07:31:51PM +0200, Stefan Weil wrote: >> Ping? Are there any more opinions how qemu-sparc64 should be fixed? >> Should we choose Peter's approach (which is good, but with a >> higher risk than my patch)? > > I've included it n

[Qemu-devel] [PATCH v5 2/6] block: Add bdrv_get_specific_info

2013-09-23 Thread Max Reitz
Add a function for retrieving an ImageInfoSpecific object from a block driver. Signed-off-by: Max Reitz --- block.c | 9 + block/qapi.c | 3 +++ include/block/block.h | 1 + include/block/block_int.h | 1 + 4 files changed, 14 insertions(+) diff --git

[Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info

2013-09-23 Thread Max Reitz
Add a test for the additional information now provided by qemu-img info when used on qcow2 images. Signed-off-by: Max Reitz --- tests/qemu-iotests/065 | 72 ++ tests/qemu-iotests/065.out | 22 ++ tests/qemu-iotests/group | 1 + 3 fil

[Qemu-devel] [PATCH v5 0/6] Provide additional info through qemu-img info

2013-09-23 Thread Max Reitz
qemu-img info provides only pretty general information about an image. For any image format, there might be specific options which cannot be represented in a universal way; for instance, qcow2 provides the compatibility and lazy_refcount options whose values are certainly interesting but currently

[Qemu-devel] [PATCH v5 4/6] qcow2: Add support for ImageInfoSpecific

2013-09-23 Thread Max Reitz
Add a new ImageInfoSpecificQCow2 type as a subtype of ImageInfoSpecific. This contains the compatibility level as a string and an optional lazy_refcounts boolean (optional means mandatory for compat >= 1.1 and not available for compat == 0.10). Also, add qcow2_get_specific_info, which returns this

[Qemu-devel] [PATCH v5 3/6] block/qapi: Human-readable ImageInfoSpecific dump

2013-09-23 Thread Max Reitz
Add a function for generically dumping the ImageInfoSpecific information in a human-readable format to block/qapi.c. Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to allow qemu-img info resp. qemu-io -c info to print that format specific information. Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH] hmp: block-stream: fix typo

2013-09-23 Thread Stefan Hajnoczi
On Fri, Sep 20, 2013 at 08:07:43AM -0500, Anthony Liguori wrote: > Found this by enabling C++ errors. The bool and enum arguments > are mistakenly flipped. > > Signed-off-by: Anthony Liguori > --- > hmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hmp.c b/hmp.c >

[Qemu-devel] [PATCH v5 1/6] qapi: Add ImageInfoSpecific type

2013-09-23 Thread Max Reitz
Add a new type ImageInfoSpecific as a union for image format specific information in ImageInfo. Signed-off-by: Max Reitz --- qapi-schema.json | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index 145eca8..cbad705 100644 -

Re: [Qemu-devel] [PATCH v2] block: Fix compiler warning (-Werror=uninitialized)

2013-09-23 Thread Stefan Hajnoczi
On Sun, Sep 22, 2013 at 08:19:10AM +0200, Stefan Weil wrote: > The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3: > > block/stream.c:141:22: error: > ‘copy’ may be used uninitialized in this function [-Werror=uninitialized] > > This is not a real bug - a better compiler would not co

[Qemu-devel] [PATCH v5 5/6] qemu-iotests: Discard specific info in _img_info

2013-09-23 Thread Max Reitz
In _img_info, filter out additional information specific to the image format provided by qemu-img info, since tests designed for multiple image formats would produce different outputs for every image format else. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.rc | 19 ++-

[Qemu-devel] [PATCH v2] linux-user: Handle SOCK_CLOEXEC/NONBLOCK if unavailable on host

2013-09-23 Thread edgar . iglesias
From: "Edgar E. Iglesias" If the host lacks SOCK_CLOEXEC, bail out with -EINVAL. If the host lacks SOCK_ONONBLOCK, try to emulate it with fcntl() and O_NONBLOCK. Signed-off-by: Edgar E. Iglesias --- v2: Dont emulate SOCK_CLOEXEC (Riku) linux-user/syscall.c | 40 +

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-23 Thread Luiz Capitulino
On Sun, 22 Sep 2013 14:50:54 +0800 Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients

Re: [Qemu-devel] [PATCH v4 12/23] acpi: add rules to compile ASL source

2013-09-23 Thread Paolo Bonzini
Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > Detect presence of IASL compiler and use it > to process ASL source. If not there, use pre-compiled > files in-tree. Add script to update the in-tree files. > > Note: distros are known to silently update iasl > so detect correct iasl flags for

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Marcel Apfelbaum
On Mon, 2013-09-23 at 14:27 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 02:01:17PM +0300, Marcel Apfelbaum wrote: > > This patch is implemented on top of series: > > [PATCH v5 0/3] pci: implement upstream master abort protocol > > > > Added "master abort io" background region for PC

Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage

2013-09-23 Thread Stefan Hajnoczi
On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote: > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043 > index 478773d..ae7cf27 100755 > --- a/tests/qemu-iotests/043 > +++ b/tests/qemu-iotests/043 > @@ -31,7 +31,7 @@ status=1# failure is the default! > _cleanup() > { >

Re: [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader

2013-09-23 Thread Paolo Bonzini
Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > This adds a dynamic bios linker/loader. > This will be used by acpi table generation > code to: > - load each table in the appropriate memory segment > - link tables to each other > - fix up checksums after said linking > > Signed-o

Re: [Qemu-devel] [PATCH] virtio-net: broken RX filtering logic fixed

2013-09-23 Thread Stefan Hajnoczi
On Sun, Sep 22, 2013 at 06:09:13PM +0300, Dmitry Fleytman wrote: > From: Dmitry Fleytman > > Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command > multicast list overwrites unicast list in mac_table. > This leads to broken logic for both unicast and multicast RX filtering. > > Signed-off-by

Re: [Qemu-devel] [PATCH 02/12] trace+libvirt: start trace processing thread in final child process

2013-09-23 Thread Stefan Hajnoczi
On Fri, Sep 06, 2013 at 04:06:08PM +0200, Michael Mueller wrote: > On Wed, 17 Jul 2013 10:08:15 +0800 > Stefan Hajnoczi wrote: > > > On Tue, Jul 16, 2013 at 02:17:28PM +0200, Michael Mueller wrote: > > > On Tue, 16 Jul 2013 11:05:11 +0800 > > > Stefan Hajnoczi wrote: > > > > > > > On Mon, Jul 1

Re: [Qemu-devel] I/O performance degradation with Virtio-Blk-Data-Plane

2013-09-23 Thread Stefan Hajnoczi
On Thu, Sep 05, 2013 at 10:18:28AM +0900, Jonghwan Choi wrote: Thanks for posting these details. Have you tried running x-data-plane=off with vcpu = 8 and how does the performance compare to x-data-plane=off with vcpu = 1? > > 1. The fio results so it's clear which cases performed worse and by h

Re: [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator name

2013-09-23 Thread Stefan Hajnoczi
On Thu, Sep 12, 2013 at 10:51:48AM +0200, Paolo Bonzini wrote: > Il 12/09/2013 10:38, Stefan Hajnoczi ha scritto: > > On Tue, Sep 10, 2013 at 06:40:04PM +0200, Paolo Bonzini wrote: > >> The UUID is unique even across multiple hosts, thus it is > >> better than a VM name even if it is less user-frie

Re: [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 02:48:57PM +0200, Paolo Bonzini wrote: > Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > > This adds a dynamic bios linker/loader. > > This will be used by acpi table generation > > code to: > > - load each table in the appropriate memory segment > > - link tab

[Qemu-devel] [PATCH v3 14/18] milkymist: Suppress -kernel/-bios/-drive error for qtest

2013-09-23 Thread Andreas Färber
Acked-by: Michael Walle Signed-off-by: Andreas Färber --- hw/lm32/milkymist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index f1744ec..15053c4 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -21,6 +21,7 @@ #incl

[Qemu-devel] [PATCH v3 00/18] qtest: Test all targets

2013-09-23 Thread Andreas Färber
Hello, As discussed on the KVM Call, this series extends test coverage to all 16 targets. For now it tests that QOM type changes do not lead to QOM cast assertions. v3 macro'fies and cleans up ppcemb machine test setup. There was a discussion of dropping usage of qtest_enabled() in favor of neve

[Qemu-devel] [PATCH v3 16/18] shix: Don't require firmware presence for qtest

2013-09-23 Thread Andreas Färber
Adopt error_report() while at it. Reviewed-by: Stefan Hajnoczi Reviewed-by: Aurelien Jarno Signed-off-by: Andreas Färber --- hw/block/tc58128.c | 10 ++ hw/sh4/shix.c | 9 + 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/block/tc58128.c b/hw/block/tc58

[Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/boot.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 1e313af..0c3dc5f 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -15,6 +15,7 @@ #include "hw/loader.h" #include "elf.h" #include "sysemu/device_tree.h"

[Qemu-devel] [PATCH v3 07/18] palm: Don't enforce loading ROM or kernel for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/palm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/palm.c b/hw/arm/palm.c index 3e39044..ff6bfab 100644 --- a/hw/arm/palm.c +++ b/hw/arm/palm.c @@ -19,6 +19,7 @@ #include "hw/hw.h" #include "audio/audio.h" #include "syse

[Qemu-devel] [PATCH v3 10/18] armv7m: Don't enforce use of kernel for qtest

2013-09-23 Thread Andreas Färber
Adopt error_report(). Signed-off-by: Andreas Färber --- hw/arm/armv7m.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c index 89a9015..397e8df 100644 --- a/hw/arm/armv7m.c +++ b/hw/arm/armv7m.c @@ -11,6 +11,8 @@ #

[Qemu-devel] [PATCH v3 03/18] puv3: Turn puv3_load_kernel() into a no-op for qtest without -kernel

2013-09-23 Thread Andreas Färber
Replacing the assert() with more user-friendly error handling is left for a follow-up. Signed-off-by: Andreas Färber --- hw/unicore32/puv3.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/unicore32/puv3.c b/hw/unicore32/puv3.c index a900061..e05cbc1 100644 --- a/hw/unicore32/puv3.c +

[Qemu-devel] [PATCH v3 04/18] mainstone: Don't enforce use of -pflash for qtest

2013-09-23 Thread Andreas Färber
Simply skip flash setup for now. Also drop useless debug output. Signed-off-by: Andreas Färber --- hw/arm/mainstone.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c index b244f7e..9402c84 100644 --- a/hw/arm/mainstone.c +++ b/hw/a

[Qemu-devel] [PATCH v3 09/18] exynos4_boards: Silence lack of -smp 2 warning for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/exynos4_boards.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/arm/exynos4_boards.c b/hw/arm/exynos4_boards.c index 2929f9f..26cedec 100644 --- a/hw/arm/exynos4_boards.c +++ b/hw/arm/exynos4_boards.c @@ -22,6 +22,7 @@ */ #in

[Qemu-devel] [PATCH v3 11/18] axis_dev88: Don't enforce use of kernel for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cris/axis_dev88.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index 03058d3..5524088 100644 --- a/hw/cris/axis_dev88.c +++ b/hw/cris/axis_dev88.c @@ -32,6 +32,7 @@ #include "boot.

Re: [Qemu-devel] [PATCH v4 12/23] acpi: add rules to compile ASL source

2013-09-23 Thread Laszlo Ersek
On 09/23/13 15:39, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 02:36:41PM +0200, Paolo Bonzini wrote: >> Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: >>> Detect presence of IASL compiler and use it >>> to process ASL source. If not there, use pre-compiled >>> files in-tree. Add scrip

[Qemu-devel] [PATCH v3 18/18] qtest: Prepare QOM machine tests

2013-09-23 Thread Andreas Färber
Instantiate all [*] machines per target, so that they get a bit of test coverage at all. This has proven helpful during QOM refactorings. [*] ppcemb target contains some non-working non-embedded machines, and ppc405 CPUs are not available there either. i386 and x86_64 do not cover pc*-x.y or xenfv

[Qemu-devel] [PATCH v3 12/18] mcf5208: Don't enforce use of kernel for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/m68k/mcf5208.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c index fb96fe8..6e30c0b 100644 --- a/hw/m68k/mcf5208.c +++ b/hw/m68k/mcf5208.c @@ -10,6 +10,7 @@ #include "qemu/timer.h" #include "hw/ptimer.h" #incl

[Qemu-devel] [PATCH v3 01/18] mips_mipssim: Silence BIOS loading warning for qtest

2013-09-23 Thread Andreas Färber
Reviewed-by: Aurelien Jarno Signed-off-by: Andreas Färber --- hw/mips/mips_mipssim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/mips/mips_mipssim.c b/hw/mips/mips_mipssim.c index 242bab9..239aa6a 100644 --- a/hw/mips/mips_mipssim.c +++ b/hw/mips/mips_mipssim.c @@ -

[Qemu-devel] [PATCH v3 13/18] an5206: Don't enforce use of kernel for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/m68k/an5206.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c index a8eee44..24f2068 100644 --- a/hw/m68k/an5206.c +++ b/hw/m68k/an5206.c @@ -12,6 +12,7 @@ #include "hw/loader.h" #include "elf.h" #include "exec/ad

Re: [Qemu-devel] ChrEMU - Virtualization in the Browser

2013-09-23 Thread Stefan Hajnoczi
On Tue, Sep 10, 2013 at 08:08:22PM -0400, Joey Carlini wrote: > I managed to get QEMU running on a Crouton install, virtual box not being > possible with the Chrome OS kermel with the KVM mods required, and even a > couple distros running. Since I enjoy pain and/or haven't done enough cool > things

Re: [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader

2013-09-23 Thread Paolo Bonzini
Il 23/09/2013 15:36, Michael S. Tsirkin ha scritto: > On Mon, Sep 23, 2013 at 02:48:57PM +0200, Paolo Bonzini wrote: >> Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: >>> This adds a dynamic bios linker/loader. >>> This will be used by acpi table generation >>> code to: >>> - load each tab

Re: [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 03:39:10PM +0200, Paolo Bonzini wrote: > Il 23/09/2013 15:36, Michael S. Tsirkin ha scritto: > > On Mon, Sep 23, 2013 at 02:48:57PM +0200, Paolo Bonzini wrote: > >> Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > >>> This adds a dynamic bios linker/loader. > >>> This w

Re: [Qemu-devel] [PATCH v4 12/23] acpi: add rules to compile ASL source

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 02:36:41PM +0200, Paolo Bonzini wrote: > Il 22/09/2013 15:37, Michael S. Tsirkin ha scritto: > > Detect presence of IASL compiler and use it > > to process ASL source. If not there, use pre-compiled > > files in-tree. Add script to update the in-tree files. > > > > Note: di

Re: [Qemu-devel] [PATCH v4 15/23] i386: add bios linker/loader

2013-09-23 Thread Paolo Bonzini
Il 23/09/2013 15:47, Michael S. Tsirkin ha scritto: > > It doesn't, the names were already prefixed with alloc_/pointer_/cksum_. > > All it does is change underscores to periods. > > You are right, that's cleaner. I'll do this. > I don't want to sprinkle QEMU_PACKED around though, > it's just the

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-23 Thread Eric Blake
On 09/22/2013 12:50 AM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle t

[Qemu-devel] [PATCH 02/10] target-s390: Implement STFLE

2013-09-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/helper.h | 1 + target-s390x/insn-data.def | 2 ++ target-s390x/misc_helper.c | 13 + target-s390x/translate.c | 8 4 files changed, 24 insertions(+) diff --git a/target-s390x/helper.h b/target-s390x/helper.h index

[Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-09-23 Thread Richard Henderson
Rather than simply hard-coding them in STFL instruction. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 3 +++ target-s390x/cpu.h | 1 + target-s390x/translate.c | 10 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/target-s390x/cpu.c b/target-s

[Qemu-devel] [PATCH 0/9] target-s390 tcg improvements

2013-09-23 Thread Richard Henderson
With this patch set we can boot the fedora 19 kernel, and make it all the way to /bin/init. At which point the process either hangs or crashes; in either case the kernel winds up with no runnable processes and spends its time in the idle loop. The choice of z9-109 for the facilities is because th

[Qemu-devel] [PATCH 06/10] target-s390: Implement EPSW

2013-09-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 2 ++ target-s390x/translate.c | 18 ++ 2 files changed, 20 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index c528eb4..48850ff 100644 --- a/target-s390x/insn-data.def +++ b

[Qemu-devel] [PATCH 10/10] target-s390: Implement ECAG

2013-09-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 2 ++ target-s390x/translate.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index a405f64..d3bc5b1 100644 --- a/target-s390x/insn-data.def +++ b/target-s390x/

[Qemu-devel] [PATCH 03/10] target-s390: Add facilities bits and sets

2013-09-23 Thread Richard Henderson
Name the facilities bits, collect the set of bits for tcg and the various real processor revisions. Update the set of facilities reported for TCG. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 75 +++- target-s390x/cpu.h | 59 +

[Qemu-devel] [PATCH 09/10] target-s390: Implement LURA, LURAG, STURG

2013-09-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/helper.h | 3 +++ target-s390x/insn-data.def | 4 target-s390x/mem_helper.c | 16 target-s390x/translate.c | 26 ++ 4 files changed, 49 insertions(+) diff --git a/target-s390x/helper.h b/tar

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 03:37:43PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-09-23 at 14:27 +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2013 at 02:01:17PM +0300, Marcel Apfelbaum wrote: > > > This patch is implemented on top of series: > > > [PATCH v5 0/3] pci: implement upstream maste

[Qemu-devel] [PATCH v3 05/18] gumstix: Don't enforce use of -pflash for qtest

2013-09-23 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/arm/gumstix.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c index e97fbbd..aeea172 100644 --- a/hw/arm/gumstix.c +++ b/hw/arm/gumstix.c @@ -42,6 +42,7 @@ #include "hw/boards.h" #include "s

[Qemu-devel] [PATCH 08/10] target-s390: Fix STURA

2013-09-23 Thread Richard Henderson
We were storing 16 bits instead of 32. Signed-off-by: Richard Henderson --- target-s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 1422ae9..408836c 100644 --- a/target-s390x/mem_helper.c +++ b/targ

[Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP

2013-09-23 Thread Richard Henderson
The implementation had been incomplete, as we did not store the machine type. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 2 ++ target-s390x/cpu.h | 14 +- target-s390x/translate.c | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/tar

[Qemu-devel] [PATCH] tracing: start trace processing thread in final child process

2013-09-23 Thread Christian Borntraeger
From: Michael Mueller When running with trace backend e.g. "simple" the writer thread needs to be implemented in the same process context as the trace points that will be processed. Under libvirtd control, qemu gets first started in daemonized mode to privide its capabilities. Creating the writer

[Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache

2013-09-23 Thread Max Reitz
Test 052 uses qemu-io -s which will result in bdrv_open trying to create a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs do not work well together, disable this test for -nocache. Signed-off-by: Max Reitz --- tests/qemu-iotests/052 | 1 + 1 file changed, 1 insertion(+) diff

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Michael S. Tsirkin
On Mon, Sep 23, 2013 at 05:43:38PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-09-23 at 16:45 +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 23, 2013 at 03:37:43PM +0300, Marcel Apfelbaum wrote: > > > On Mon, 2013-09-23 at 14:27 +0300, Michael S. Tsirkin wrote: > > > > On Mon, Sep 23, 2013 at 0

Re: [Qemu-devel] [PATCH v4 06/12] xics: convert init() to realize()

2013-09-23 Thread Andreas Färber
Am 30.08.2013 07:28, schrieb Alexey Kardashevskiy: > This fixes XICS according new QOM rules. > > This converts ICS's init() callbacks to realize(). > > This converts legacy qdev_init_nofail() to property_set(realized). > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Than

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-23 Thread Marcel Apfelbaum
On Mon, 2013-09-23 at 16:45 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 23, 2013 at 03:37:43PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-09-23 at 14:27 +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 23, 2013 at 02:01:17PM +0300, Marcel Apfelbaum wrote: > > > > This patch is implemented

Re: [Qemu-devel] [PATCH v4 07/12] xics: add missing const specifiers to TypeInfo

2013-09-23 Thread Andreas Färber
Am 30.08.2013 07:28, schrieb Alexey Kardashevskiy: > This adds missing const specifiers to ICS and ICP TypeInfo's. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Fe

[Qemu-devel] [PATCH 05/10] target-s390: Implement SAM31 and SAM64

2013-09-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 8 target-s390x/translate.c | 29 + 2 files changed, 33 insertions(+), 4 deletions(-) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 4b462d4..c528eb4 100644 --- a

[Qemu-devel] [PATCH v3 15/18] shix: Drop debug output

2013-09-23 Thread Andreas Färber
Reviewed-by: Aurelien Jarno Signed-off-by: Andreas Färber --- hw/sh4/shix.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/hw/sh4/shix.c b/hw/sh4/shix.c index 1ff37f5..f008b98 100644 --- a/hw/sh4/shix.c +++ b/hw/sh4/shix.c @@ -50,7 +50,6 @@ static void shix_init(QEMUMachineInitArgs *a

  1   2   >