Add helper functions for adding read-only properties, that work in the
case where the value is in memory.
Michael S. Tsirkin (4):
qemu: add Error to typedefs
qom: pull in qemu/typedefs
qom: cleanup struct Error references
qom: add pointer to int property helpers
include/qemu/typedefs.h |
As usual so we can use typedefs without header dependencies.
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index 1a7b71a..5b3b743 100644
--- a/include/qom/object.h
+++ b/include/qom/objec
This is so qom headers can use it without pulling in
extra headers.
Signed-off-by: Michael S. Tsirkin
---
include/qemu/typedefs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index c5c6e36..bb5acf9 100644
--- a/include/qemu/typedefs.h
+++
Make it easy to add read-only helpers for simple
integer properties in memory.
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 21
qom/object.c | 56
2 files changed, 77 insertions(+)
diff --git a/inc
now that a typedef for struct Error is available,
use it in qom/object.h to match coding style rules.
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 51 +--
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/include/qom/o
On Wed, Sep 18, 2013 at 9:54 PM, Stefan Hajnoczi wrote:
> On Tue, Aug 27, 2013 at 11:20:59AM +0800, Liu Ping Fan wrote:
>> Saw the Alex's patches has been merged, rebase mine onto his.
>>
>> v3:
>> 1. rename seqlock_read_check as seqlock_read_retry
>> 2. Document timerlist were protected by BQ
on 22/09/2013 09:31 Gleb Natapov said the following:
> Which kernel version is this? What BSD version?
$ uname -a
Linux kvm 3.8.0-27-generic #40-Ubuntu SMP Tue Jul 9 00:17:05 UTC 2013 x86_64
x86_64 x86_64 GNU/Linux
FreeBSD is 9.x.
--
Andriy Gapon
Il 21/09/2013 21:17, Michael S. Tsirkin ha scritto:
> On Fri, Sep 20, 2013 at 04:57:49PM +0200, Paolo Bonzini wrote:
>> This series fixes hot-unplug of virtio devices, which can crash due to
>> dangling pointer accesses.
>
> Could you please describe the sequence of steps that makes
> qemu crash?
v4:
fix commit log for "protect timers_state's clock with seqlock" (Thanks for
Alex)
v3:
1. rename seqlock_read_check as seqlock_read_retry
2. Document timerlist were protected by BQL, and discard private lock around
"qemu_event_wait(tl->ev)".
v2:
1. fix comment in commit and code
2.
This lets the read-side access run outside the BQL.
Signed-off-by: Paolo Bonzini
---
include/qemu/seqlock.h | 72 ++
1 file changed, 72 insertions(+)
create mode 100644 include/qemu/seqlock.h
diff --git a/include/qemu/seqlock.h b/include/qemu/seq
QEMU_CLOCK_VIRTUAL may be read outside BQL. This will make its
foundation, i.e. timers_state exposed to race condition.
Using private lock to protect it.
After this patch, reading QEMU_CLOCK_VIRTUAL is thread safe
unless use_icount is true, in which case the existing callers
still rely on the BQL
This lets the read-side access run outside the BQL.
Signed-off-by: Paolo Bonzini
---
include/qemu/seqlock.h | 72 ++
1 file changed, 72 insertions(+)
create mode 100644 include/qemu/seqlock.h
diff --git a/include/qemu/seqlock.h b/include/qemu/seq
After disabling the QemuClock, we should make sure that no QemuTimers
are still in flight. To implement that with light overhead, we resort
to QemuEvent. The caller of disabling will wait on QemuEvent of each
timerlist.
Note, qemu_clock_enable(foo,false) can _not_ be called from timer's cb.
And th
This emulates Win32 manual-reset events using futexes or conditional
variables. Typical ways to use them are with multi-producer,
single-consumer data structures, to test for a complex condition whose
elements come from different threads:
for (;;) {
qemu_event_reset(ev);
... t
On Sun, Sep 22, 2013 at 11:05:37AM +0300, Andriy Gapon wrote:
> on 22/09/2013 09:31 Gleb Natapov said the following:
> > Which kernel version is this? What BSD version?
>
> $ uname -a
> Linux kvm 3.8.0-27-generic #40-Ubuntu SMP Tue Jul 9 00:17:05 UTC 2013 x86_64
> x86_64 x86_64 GNU/Linux
>
That's
This is a quick way to update helper program when qemu main code
is changed or built, instead of adding new Makefile under test/qemu-iotest.
Signed-off-by: Wenchao Xia
---
tests/Makefile |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/tests/Makefile b/tests/Makefi
Wenchao Xia (2):
tests: build the helper program in main build process
build: add command check-clean
Makefile |1 -
tests/Makefile | 16 ++--
2 files changed, 14 insertions(+), 3 deletions(-)
This command will package the clean operations in tests. Now root Makefile
simply calls the command and do not care the details of it any more. Original
the built binaries for test will not be removed, now they will be deleted
in clean operation.
Signed-off-by: Wenchao Xia
---
Makefile |
Hi, all
Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC
address will broadcast via qemu_announce_self in destination,
so, long time network disconnection probably happen.
I want to do below works to resolve this problem,
1. change NICConf's MAC as soon as emulated N
On Sun, Sep 22, 2013 at 08:35:29AM +, Zhanghaoyu (A) wrote:
> Hi, all
>
> Do live migration if emulated NIC's MAC has been changed, RARP with wrong MAC
> address will broadcast via qemu_announce_self in destination,
> so, long time network disconnection probably happen.
Good catch.
> I want
This series allow user to read internal snapshot's contents without qemu-img
convert.
V2:
Address Stefan's comments:
02: add 'fall through' comments in the case statement.
03: add doc about the difference of internal snapshot and backing chain
snapshot, which is used in previous '--snapshot'
Signed-off-by: Wenchao Xia
---
tests/qemu-iotests/058 | 87
tests/qemu-iotests/058.out | 26 +
tests/qemu-iotests/group |1 +
3 files changed, 114 insertions(+), 0 deletions(-)
create mode 100755 tests/qemu-iotests/058
creat
Since later this function will be used so improve it. The only caller of it
now is qemu-img, and it is not impacted by call the function twice to keep
old search logic.
Signed-off-by: Wenchao Xia
---
block/qcow2-snapshot.c| 16 ++--
block/qcow2.h |5 -
block
Signed-off-by: Wenchao Xia
---
qemu-nbd.c|8 +++-
qemu-nbd.texi |8 +++-
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index e450d04..8cb4bf1 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -80,7 +80,13 @@ static void usage(const char *nam
Now it is possible to directly export an internal snapshot, which
can be used to probe the snapshot's contents without qemu-img
convert.
Signed-off-by: Wenchao Xia
---
qemu-nbd.c | 54 +-
1 files changed, 53 insertions(+), 1 deletions(-)
dif
on 22/09/2013 11:17 Gleb Natapov said the following:
> On Sun, Sep 22, 2013 at 11:05:37AM +0300, Andriy Gapon wrote:
>> on 22/09/2013 09:31 Gleb Natapov said the following:
>>> Which kernel version is this? What BSD version?
>>
>> $ uname -a
>> Linux kvm 3.8.0-27-generic #40-Ubuntu SMP Tue Jul 9 00
On Thu, Jul 25, 2013 at 08:06:27PM -0400, Kevin O'Connor wrote:
> On Thu, Jul 25, 2013 at 03:55:56PM +0300, Michael S. Tsirkin wrote:
> > On Mon, Jul 15, 2013 at 11:01:02AM +0300, Michael S. Tsirkin wrote:
> > > On Sun, Jul 14, 2013 at 02:24:52PM -0400, Kevin O'Connor wrote:
> > > > I'd prefer to s
On Sun, Sep 22, 2013 at 01:49:58PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jul 25, 2013 at 08:06:27PM -0400, Kevin O'Connor wrote:
> > On Thu, Jul 25, 2013 at 03:55:56PM +0300, Michael S. Tsirkin wrote:
> > > On Mon, Jul 15, 2013 at 11:01:02AM +0300, Michael S. Tsirkin wrote:
> > > > On Sun, Jul
This is useful when pci assignment happens on sPAPR.
Signed-off-by: Liu Ping Fan
---
This patch will apply on patches which enable xics in kernel.
---
hw/intc/xics.c| 5 +
hw/ppc/spapr_pci.c| 14 ++
include/hw/ppc/xics.h | 1 +
3 files changed, 20 insertions(+)
dif
Providing backing.file.filename doesn't override backing file as expected:
$ x86_64-softmmu/qemu-system-x86_64 -drive \
file=/tmp/child.qcow2,backing.file.filename=/tmp/fake.qcow2
qemu-system-x86_64: -drive \
file=/tmp/child.qcow2,backing.file.filename=/tmp/fake.qcow2: cou
Test that backing.file.filename option can be parsed and override the
backing file from image (backing file reflected with "info block").
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/051 | 17 -
tests/qemu-iotests/051.out | 11 +++
2 files changed, 27 insertions(+)
The backing.file.filename option is not working as expected: if there's also a
backing file name from the format driver, adding this option fails bdrv_open;
if there's no backing file name info in the image, "info block" doesn't show
the overrided file name.
A test case is updated to catch these i
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/.gitignore b/tests/qemu-iotests/.gitignore
index 62b4002..0541f80 100644
--- a/tests/qemu-iotests/.gitignore
+++ b/tests/qemu-iotests/.gitignore
@@ -2,6 +2,7 @@ check.
Signed-off-by: Michael S. Tsirkin
---
include/hw/nvram/fw_cfg.h | 4
hw/nvram/fw_cfg.c | 33 -
2 files changed, 32 insertions(+), 5 deletions(-)
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
index f60dd67..2ab0fc2 100644
--- a/in
This code can also be found here:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi
While this patch still uses info not available in QOM, I think it's reasonable
to merge it and then refactor as QOM properties cover more ground.
In particular, merging this patchset blocks other projects so
This is so qom headers can use it without pulling in
extra headers.
Signed-off-by: Michael S. Tsirkin
---
include/qemu/typedefs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index a4c1b84..46c3599 100644
--- a/include/qemu/typedefs.h
+++
Detect presence of IASL compiler and use it
to process ASL source. If not there, use pre-compiled
files in-tree. Add script to update the in-tree files.
Note: distros are known to silently update iasl
so detect correct iasl flags for the installed version on each run as
opposed to at configure tim
Support ROM blobs not mapped into guest memory:
same as ROM files really but use caller's buffer.
Support incoking callback on access and
return memory pointer making it easier
for caller to update memory if necessary.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Laszlo Ersek
---
hw/lm32/lm3
Callers pass in the address so it's helpful for
them to be able to decode it.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 21 +
hw/pci/pcie_host.c | 21 -
2 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/inclu
This adds a dynamic bios linker/loader.
This will be used by acpi table generation
code to:
- load each table in the appropriate memory segment
- link tables to each other
- fix up checksums after said linking
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/bios-linker-loader.h
Add API to find HPET using QOM.
Signed-off-by: Michael S. Tsirkin
---
include/hw/timer/hpet.h | 2 ++
hw/timer/hpet.c | 5 +
2 files changed, 7 insertions(+)
diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h
index 757f79f..ab44bd3 100644
--- a/include/hw/timer/hpet.h
++
Useful to make it accessible through QOM.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 2 ++
hw/pci-host/q35.c | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index da0f275..33d75bd 10064
Make it possible to test unmapped status through QMP.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 3 +++
hw/pci/pcie_host.c | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index 1228e36
Don't abort if machine done callbacks add ROMs.
Signed-off-by: Michael S. Tsirkin
---
include/hw/loader.h | 1 +
hw/core/loader.c| 6 +-
vl.c| 3 +++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/hw/loader.h b/include/hw/loader.h
index e0c576b..58e
Address is already exposed, expose size for symmetry.
Signed-off-by: Michael S. Tsirkin
---
include/hw/pci/pcie_host.h | 1 +
hw/pci-host/q35.c | 14 ++
2 files changed, 15 insertions(+)
diff --git a/include/hw/pci/pcie_host.h b/include/hw/pci/pcie_host.h
index 33d75bd..ac
This defines a structure that will be used to fill in acpi tables
where relevant properties are not yet available using QOM.
Signed-off-by: Michael S. Tsirkin
Reviewed-by: Laszlo Ersek
---
include/hw/i386/pc.h | 10 ++
hw/i386/pc.c | 35 +++
2 fil
Add API to find pvpanic device and get its io port.
Will be used to fill in guest info structure.
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 1 +
hw/misc/pvpanic.c| 13 -
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/incl
Avoid a bit of code duplication, make
max file path constant reusable.
Suggested-by: Laszlo Ersek
Signed-off-by: Michael S. Tsirkin
---
include/hw/nvram/fw_cfg.h | 4 +++-
hw/core/loader.c | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/hw/nvram/fw_cfg.h
Signed-off-by: Michael S. Tsirkin
---
include/hw/i386/pc.h | 10 ++
hw/acpi/piix4.c | 6 +++---
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 7a343f8..f966cef 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/
On Sun, Sep 22, 2013 at 02:18:45PM +0300, Michael S. Tsirkin wrote:
> On Sun, Sep 22, 2013 at 01:49:58PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jul 25, 2013 at 08:06:27PM -0400, Kevin O'Connor wrote:
> > > On Thu, Jul 25, 2013 at 03:55:56PM +0300, Michael S. Tsirkin wrote:
> > > > On Mon, Jul
This adds APIs that will be used to fill in guest acpi tables.
Some required information is still lacking in QOM, so we
fall back on lookups by type and returning explicit types.
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/piix4.h | 8
include/hw/i386/pc.h| 1 +
hw/acpi/
This adds APIs that will be used to fill in
acpi tables, implemented using QOM,
to various ich9 components.
Some information is still missing in QOM,
so we fall back on lookups by type instead.
Signed-off-by: Michael S. Tsirkin
---
include/hw/acpi/ich9.h| 2 ++
include/hw/i386/ich9.h|
now that a typedef for struct Error is available,
use it in qom/object.h to match coding style rules.
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 51 +--
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/include/qom/o
As usual so we can use typedefs without header dependencies.
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/qom/object.h b/include/qom/object.h
index 1a7b71a..5b3b743 100644
--- a/include/qom/object.h
+++ b/include/qom/objec
Make it easy to add read-only helpers for simple
integer properties in memory.
Signed-off-by: Michael S. Tsirkin
---
include/qom/object.h | 21
qom/object.c | 56
2 files changed, 77 insertions(+)
diff --git a/inc
From: Dmitry Fleytman
Upon processing of VIRTIO_NET_CTRL_MAC_TABLE_SET command
multicast list overwrites unicast list in mac_table.
This leads to broken logic for both unicast and multicast RX filtering.
Signed-off-by: Dmitry Fleytman
---
hw/net/virtio-net.c | 3 ++-
1 file changed, 2 insertio
Hi all I am using the following code to read registers, i can read the value
of EIP, but when i dump the value pointed by EIP, all are zero, byte code
should not be zero, so i think my code is wrong. Please point me out thanks?
static void gkd_read_registers(CPUState *cpu, char *buffer) {
On Sun, Sep 22, 2013 at 05:00:58PM +0200, Sander Eikelenboom wrote:
>
> >> I'm trying to get secondary vga-passthrough on a HVM guest to work with a
> >> AMD HD6570 and the native kernel radeon driver and kernel modesetting.
> >> So the guest still gets the emulated stdvga or cirrus device(used i
On Fri, Sep 20, 2013 at 1:24 AM, Richard Henderson wrote:
> This is an attempt to improve performance of target-sparc
> by exposing the windowed registers as TCG globals, and all
> the optimization that we can do there.
>
> This is done via allowing tcg_global_mem_new to be used
> with any base po
Il 22/09/2013 15:38, Michael S. Tsirkin ha scritto:
> Add API to find HPET using QOM.
>
> Signed-off-by: Michael S. Tsirkin
> ---
> include/hw/timer/hpet.h | 2 ++
> hw/timer/hpet.c | 5 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/include/hw/timer/hpet.h b/include/hw/timer
On Sun, Sep 22, 2013 at 09:22:09PM +0200, Paolo Bonzini wrote:
> Il 22/09/2013 15:38, Michael S. Tsirkin ha scritto:
> > Add API to find HPET using QOM.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > include/hw/timer/hpet.h | 2 ++
> > hw/timer/hpet.c | 5 +
> > 2 files change
Am 22.09.2013 um 13:47 schrieb Liu Ping Fan :
> This is useful when pci assignment happens on sPAPR.
This patch doesn't sound useful on its own to me, thus probably belongs in a
greater patch set.
And without even a clear commit message that explains why exactly this is going
to be "useful" e
22.09.2013 12:30, Wenchao Xia пишет:
This is a quick way to update helper program when qemu main code
is changed or built, instead of adding new Makefile under test/qemu-iotest.
Why?
[]
+# Build the help program automatically
+
+all: $(QEMU_IOTESTS_HELPERS-y)
This appears to be somewhat aw
Reviewed-by: Wenchao Xia
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/.gitignore b/tests/qemu-iotests/.gitignore
index 62b4002..0541f80 100644
--- a/tests/qemu-iotests/.gitignore
+++ b/tests/qemu-iotests/.git
On 09/23/2013 04:36 AM, Michael Tokarev wrote:
22.09.2013 12:30, Wenchao Xia пишет:
This is a quick way to update helper program when qemu main code
is changed or built, instead of adding new Makefile under
test/qemu-iotest.
Why?
[]
I think it is a bit overkill to have a new Makefile for
On Mon, Sep 23, 2013 at 4:02 AM, Alexander Graf wrote:
>
> Am 22.09.2013 um 13:47 schrieb Liu Ping Fan :
>
>> This is useful when pci assignment happens on sPAPR.
>
> This patch doesn't sound useful on its own to me, thus probably belongs in a
> greater patch set.
>
Yes, I think, it will be appli
On 09/22/2013 09:47 PM, Liu Ping Fan wrote:
> This is useful when pci assignment happens on sPAPR.
I have almost the same patch in my queue already, it will enable irqfd for
both INTX and MSI, I am just waiting till in-kernel XICS patchset gets in
upstream and then I'll post it.
> Signed-off-by
On 09/16/2013 02:10 PM, Alexey Kardashevskiy wrote:
> On 09/10/2013 02:26 PM, Alexey Kardashevskiy wrote:
>> On 09/04/2013 12:56 PM, Alexey Kardashevskiy wrote:
>>> On 08/30/2013 03:28 PM, Alexey Kardashevskiy wrote:
Yet another try with XICS and XICS-KVM.
v3->v4:
Addressed mult
On Sat, Sep 21, 2013 at 06:38:19PM +0900, Peter Maydell wrote:
> On 21 September 2013 06:46, Christoffer Dall
> wrote:
> > On Sat, Sep 21, 2013 at 06:22:23AM +0900, Peter Maydell wrote:
> >> *) for getting TCG<->KVM and KVM-with-non-host-CPU cases
> >> right we need to do translation anyway, or a
On Mon, Sep 23, 2013 at 9:59 AM, Alexey Kardashevskiy wrote:
> On 09/22/2013 09:47 PM, Liu Ping Fan wrote:
>> This is useful when pci assignment happens on sPAPR.
>
>
> I have almost the same patch in my queue already, it will enable irqfd for
> both INTX and MSI, I am just waiting till in-kernel
On 2013-09-22 10:11, Liu Ping Fan wrote:
> This lets the read-side access run outside the BQL.
In fact, not only BQL. Didn't the original commit provide a changlog
about the content of this patch? Otherwise, briefly describe use cases
and maybe the typical invocation pattern.
>
> Signed-off-by:
On 2013-09-22 10:11, Liu Ping Fan wrote:
> QEMU_CLOCK_VIRTUAL may be read outside BQL. This will make its
> foundation, i.e. timers_state exposed to race condition.
> Using private lock to protect it.
>
> After this patch, reading QEMU_CLOCK_VIRTUAL is thread safe
> unless use_icount is true, in w
On 2013-09-22 10:11, Liu Ping Fan wrote:
> This emulates Win32 manual-reset events using futexes or conditional
> variables. Typical ways to use them are with multi-producer,
> single-consumer data structures, to test for a complex condition whose
> elements come from different threads:
>
> f
On 2013-09-22 10:11, Liu Ping Fan wrote:
> After disabling the QemuClock, we should make sure that no QemuTimers
> are still in flight. To implement that with light overhead, we resort
> to QemuEvent. The caller of disabling will wait on QemuEvent of each
> timerlist.
>
> Note, qemu_clock_enable(f
74 matches
Mail list logo
