Re: [Qemu-devel] [PATCH v4 3/3] hw/pci: handle downstream pci master abort

2013-09-16 Thread Peter Maydell
On 16 September 2013 07:14, Michael S. Tsirkin wrote: > On Sun, Sep 15, 2013 at 10:41:26PM +0100, Peter Maydell wrote: >> On 15 September 2013 22:07, Michael S. Tsirkin wrote: >> > On Sun, Sep 15, 2013 at 09:40:37PM +0100, Peter Maydell wrote: >> >> "native" means "if the device's MMIO callback d

Re: [Qemu-devel] [RFC qom-cpu v3 00/10] i386: add cpu hot remove support

2013-09-16 Thread Andreas Färber
Hi, Am 16.09.2013 04:40, schrieb Chen Fan: > Via implementing ACPI standard methods _EJ0 in bios, after Guest OS hot remove > one vCPU, it is able to send a signal to QEMU, then QEMU could notify > the assigned vCPU of exiting. meanwhile, and intruduce the QOM command > 'cpu-del' to remove > vCPU

[Qemu-devel] [PATCH] tests/.gitignore: ignore test-throttle

2013-09-16 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index d11cc22..ae5280e 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -5,6 +5,7 @@ check-qjson check-qlist check-qstring test-aio +test-throttle test-

Re: [Qemu-devel] [PATCH] tests/.gitignore: ignore test-throttle

2013-09-16 Thread Benoît Canet
Le Monday 16 Sep 2013 à 15:20:40 (+0800), Fam Zheng a écrit : > Signed-off-by: Fam Zheng > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/.gitignore b/tests/.gitignore > index d11cc22..ae5280e 100644 > --- a/tests/.gitignore > +++ b/tests/.gitignore > @@ -5

Re: [Qemu-devel] Block Filters

2013-09-16 Thread Fam Zheng
On Sun, 09/15 20:10, Benoît Canet wrote: > Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : > > Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: > > > On Fri, 09/06 10:45, Kevin Wolf wrote: > > > > Am 06.09.2013 um 09:56 hat Fam Zheng geschrieben: > > > > > Since BlockDriver.bdrv_sna

Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op

2013-09-16 Thread Claudio Fontana
Hello Richard, On 14.09.2013 23:54, Richard Henderson wrote: > This reduces the code size of the function significantly. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 95 > +--- > 1 file changed, 50 insertions(+), 45 deletio

Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle mov/movi in tcg_out_op

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 20 +++- > 1 file changed, 7 insertions(+), 13 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > index 983a74a..8f19b50 100644 > -

Re: [Qemu-devel] [PATCH v4 06/33] tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insn

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > And since we're no longer talking about opcodes, merge the 0x1ac02000 > data2 primary opcode with the shift subcode to create the full insn. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 49 > -

Re: [Qemu-devel] [PATCH v4 07/33] tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > It was unused. Let's not overcomplicate things before we need them. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c

Re: [Qemu-devel] [RFC qom-cpu v3 00/10] i386: add cpu hot remove support

2013-09-16 Thread chenfan
On Mon, 2013-09-16 at 09:13 +0200, Andreas Färber wrote: > Hi, > > Am 16.09.2013 04:40, schrieb Chen Fan: > > Via implementing ACPI standard methods _EJ0 in bios, after Guest OS hot > > remove > > one vCPU, it is able to send a signal to QEMU, then QEMU could notify > > the assigned vCPU of exiti

[Qemu-devel] [PATCH v5 0/3] pci: partially implement master abort protocol

2013-09-16 Thread Marcel Apfelbaum
PCI spec requires that a transaction that has not been claimed by any PCI bus devices will be terminated by the initiator with "master abort". For read transactions -1() is returned and writes are silently dropped. Implementation: - Allowed the MemoryRegion priority to be negative so a s

[Qemu-devel] [PATCH v5 1/3] memory: Change MemoryRegion priorities from unsigned to signed

2013-09-16 Thread Marcel Apfelbaum
When memory regions overlap, priority can be used to specify which of them takes priority. By making the priority values signed rather than unsigned, we make it more convenient to implement a situation where one "background" region should appear only where no other region exists: rather than having

[Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort

2013-09-16 Thread Marcel Apfelbaum
A MemoryRegion with negative priority was created and it spans over all the pci address space. It "intercepts" the accesses to unassigned pci address space and will follow the pci spec: 1. returns -1 on read 2. does nothing on write Note: setting the RECEIVED MASTER ABORT bit in the STATUS regis

[Qemu-devel] [PATCH v5 2/3] docs/memory: Explictly state that MemoryRegion priority is signed

2013-09-16 Thread Marcel Apfelbaum
When memory regions overlap, priority can be used to specify which of them takes priority. By making the priority values signed rather than unsigned, we make it more convenient to implement a situation where one "background" region should appear only where no other region exists: rather than having

[Qemu-devel] [PATCH v4 4/5] slirp: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- slirp/misc.c |3 +-- slirp/socket.c |

[Qemu-devel] [PATCH v4 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. An exception to this rule are multicast sockets where it is sensible to have multiple

[Qemu-devel] [PATCH v4 0/5] Do not set SO_REUSEADDR on Windows

2013-09-16 Thread Sebastian Ottlik
This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with calls to the new function socket_set_fast_reuse. On Windows systems the default behaviour is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR can still be set but results in undesired behaviour in mo

[Qemu-devel] [PATCH v4 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- gdbstub.c |6 ++ 1 file changed, 2 inser

[Qemu-devel] [PATCH v4 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
If a socket is closed it remains in TIME_WAIT state for some time. On operating systems using BSD sockets the endpoint of the socket may not be reused while in this state unless SO_REUSEADDR was set on the socket. On windows on the other hand the default behaviour is to allow reuse (i.e. identical

[Qemu-devel] [PATCH v4 5/5] util: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- util/qemu-sockets.c |6 +++--- 1 file change

Re: [Qemu-devel] [PATCH v4 08/33] tcg-aarch64: Introduce tcg_fmt_Rdnm and tcg_fmt_Rdnm_lsl

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > Now that we've converted opcode fields to pre-shifted insns, we > can merge the implementation of arithmetic and shift insns. > > Simplify the left/right shift parameter to just the left shift > needed by tcg_out_tlb_read. > > Signed-off-by: Richard

Re: [Qemu-devel] [PATCH v4 09/33] tcg-aarch64: Introduce tcg_fmt_Rdn_aimm

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > This merges the implementation of tcg_out_addi and tcg_out_subi. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 79 > +++- > 1 file changed, 31 insertions(+), 48 deletions(-) >

Re: [Qemu-devel] [PATCH v4 10/33] tcg-aarch64: Implement mov with tcg_fmt_* functions

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > Avoid the magic numbers in the current implementation. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) > > diff --git a/tcg/aarch64/tcg-target

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 02:50:24PM +0800, Fam Zheng wrote: > Added three types of modules: > > typedef enum { > MODULE_LOAD_BLOCK = 0, > MODULE_LOAD_UI, > MODULE_LOAD_NET, > MODULE_LOAD_MAX, > } module_load_type; > > and their loading function: > > voi

Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort

2013-09-16 Thread Michael S. Tsirkin
On Mon, Sep 16, 2013 at 11:21:16AM +0300, Marcel Apfelbaum wrote: > A MemoryRegion with negative priority was created and > it spans over all the pci address space. > It "intercepts" the accesses to unassigned pci > address space and will follow the pci spec: > 1. returns -1 on read > 2. does not

Re: [Qemu-devel] [PATCH v4 11/33] tcg-aarch64: Handle constant operands to add, sub, and compare

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 103 > --- > 1 file changed, 80 insertions(+), 23 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c > i

Re: [Qemu-devel] [PATCH v4 33/33] tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > Removed from other targets in 56bbc2f967ce185fa1c5c39e1aeb5b68b26242e9. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-

Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort

2013-09-16 Thread Marcel Apfelbaum
On Mon, 2013-09-16 at 12:04 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 16, 2013 at 11:21:16AM +0300, Marcel Apfelbaum wrote: > > A MemoryRegion with negative priority was created and > > it spans over all the pci address space. > > It "intercepts" the accesses to unassigned pci > > address spac

Re: [Qemu-devel] [PATCH v4 22/33] tcg-aarch64: Use MOVN in tcg_out_movi

2013-09-16 Thread Claudio Fontana
On 14.09.2013 23:54, Richard Henderson wrote: > When profitable, initialize the register with MOVN instead of MOVZ, > before setting the remaining lanes with MOVK. > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c | 88 > +--- > 1

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Fam Zheng
On Mon, 09/16 09:59, Daniel P. Berrange wrote: > On Mon, Sep 16, 2013 at 02:50:24PM +0800, Fam Zheng wrote: > > Added three types of modules: > > > > typedef enum { > > MODULE_LOAD_BLOCK = 0, > > MODULE_LOAD_UI, > > MODULE_LOAD_NET, > > MODULE_LOAD_MAX, > >

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: >> The init function of dynamic module is no longer with >> __attribute__((constructor)) as static linked version, and need to be >> explicitly called once loaded. The function name is mangled with per >> configure fingerprint as: >> >> init_

Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort

2013-09-16 Thread Michael S. Tsirkin
On Mon, Sep 16, 2013 at 12:11:32PM +0300, Marcel Apfelbaum wrote: > On Mon, 2013-09-16 at 12:04 +0300, Michael S. Tsirkin wrote: > > On Mon, Sep 16, 2013 at 11:21:16AM +0300, Marcel Apfelbaum wrote: > > > A MemoryRegion with negative priority was created and > > > it spans over all the pci address

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Fam Zheng
On Mon, 09/16 11:44, Paolo Bonzini wrote: > Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: > >> The init function of dynamic module is no longer with > >> __attribute__((constructor)) as static linked version, and need to be > >> explicitly called once loaded. The function name is mangled with

Re: [Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-16 Thread Marcel Apfelbaum
On Thu, 2013-09-12 at 13:04 +0200, Markus Armbruster wrote: > Marcel Apfelbaum writes: > > > On Thu, 2013-09-12 at 11:43 +0200, Markus Armbruster wrote: > >> Paolo Bonzini writes: > >> > >> > Il 11/09/2013 20:26, Marcel Apfelbaum ha scritto: > >> >> Qemu is expected to quit if the same boot ind

Re: [Qemu-devel] [RFC PATCH 0/8] Remove stub mon-protocol-event for block

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 06:59, Wenchao Xia ha scritto: > 于 2013/9/12 17:31, Paolo Bonzini 写道: >> Il 12/09/2013 11:15, Wenchao Xia ha scritto: >>> This series will remove the usage of symbols of mon-protocol-event in >>> qemu-img, qemu-nbd and qemu-io, in short remove the connetion for block >>> layer. >>> >>

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 11:51, Fam Zheng ha scritto: > On Mon, 09/16 11:44, Paolo Bonzini wrote: >> Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: The init function of dynamic module is no longer with __attribute__((constructor)) as static linked version, and need to be explicitly called

Re: [Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 11:54, Marcel Apfelbaum ha scritto: > On Thu, 2013-09-12 at 13:04 +0200, Markus Armbruster wrote: >> Marcel Apfelbaum writes: >> >>> On Thu, 2013-09-12 at 11:43 +0200, Markus Armbruster wrote: Paolo Bonzini writes: > Il 11/09/2013 20:26, Marcel Apfelbaum ha scritto: >>

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 12:09:47PM +0200, Paolo Bonzini wrote: > Il 16/09/2013 11:51, Fam Zheng ha scritto: > > On Mon, 09/16 11:44, Paolo Bonzini wrote: > >> Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: > The init function of dynamic module is no longer with > __attribute__((const

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 12:14, Daniel P. Berrange ha scritto: > On Mon, Sep 16, 2013 at 12:09:47PM +0200, Paolo Bonzini wrote: >> Il 16/09/2013 11:51, Fam Zheng ha scritto: >>> On Mon, 09/16 11:44, Paolo Bonzini wrote: Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: >> The init function of dynam

Re: [Qemu-devel] [PATCH v5 3/3] hw/pci: partially handle pci master abort

2013-09-16 Thread Marcel Apfelbaum
On Mon, 2013-09-16 at 12:51 +0300, Michael S. Tsirkin wrote: > On Mon, Sep 16, 2013 at 12:11:32PM +0300, Marcel Apfelbaum wrote: > > On Mon, 2013-09-16 at 12:04 +0300, Michael S. Tsirkin wrote: > > > On Mon, Sep 16, 2013 at 11:21:16AM +0300, Marcel Apfelbaum wrote: > > > > A MemoryRegion with negat

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 12:18:54PM +0200, Paolo Bonzini wrote: > Il 16/09/2013 12:14, Daniel P. Berrange ha scritto: > > On Mon, Sep 16, 2013 at 12:09:47PM +0200, Paolo Bonzini wrote: > >> Il 16/09/2013 11:51, Fam Zheng ha scritto: > >>> On Mon, 09/16 11:44, Paolo Bonzini wrote: > Il 16/09/201

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Alex Bligh
On 16 Sep 2013, at 10:51, Fam Zheng wrote: > On Mon, 09/16 11:44, Paolo Bonzini wrote: >> Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: The init function of dynamic module is no longer with __attribute__((constructor)) as static linked version, and need to be explicitly calle

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 12:21, Daniel P. Berrange ha scritto: > On Mon, Sep 16, 2013 at 12:18:54PM +0200, Paolo Bonzini wrote: >> Il 16/09/2013 12:14, Daniel P. Berrange ha scritto: >>> On Mon, Sep 16, 2013 at 12:09:47PM +0200, Paolo Bonzini wrote: Il 16/09/2013 11:51, Fam Zheng ha scritto: > On Mon

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 12:24, Alex Bligh ha scritto: > At risk of heresy, can I suggest a rather simpler scheme that requires > a total of zero infrastructure changes? > > Here's a patch against qemu 1.0 (sorry) Ubuntu dist (sorry) that > uses weak binding to load and compile against any version of > librb

Re: [Qemu-devel] Block Filters

2013-09-16 Thread Benoît Canet
Le Monday 16 Sep 2013 à 15:41:45 (+0800), Fam Zheng a écrit : > On Sun, 09/15 20:10, Benoît Canet wrote: > > Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : > > > Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: > > > > On Fri, 09/06 10:45, Kevin Wolf wrote: > > > > > Am 06.09.2013

Re: [Qemu-devel] [PATCH v2 0/5] lsi: small cleanup and add 53C810 variant

2013-09-16 Thread Paolo Bonzini
Il 14/09/2013 17:51, Hervé Poussineau ha scritto: > Hi, > > This small patchset fixes a few issues I encountered while trying to > add support for the IBM RS/6000 40p. > > Patches 1 to 4 are small cleanups. > Patch 5 may be more controversial, as it adds support for an older > (albeit compatible)

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-16 Thread Michael Mueller
On Fri, 13 Sep 2013 11:01:57 -0400 "Jason J. Herne" wrote: > On 09/05/2013 10:06 AM, Andreas Färber wrote: > > Am 05.09.2013 15:10, schrieb Alexander Graf: > >> On 05.09.2013, at 15:05, Andreas Färber wrote: > >>> Am 05.09.2013 14:54, schrieb Alexander Graf: > Very simple and clean patch set

Re: [Qemu-devel] [RFC 4/4] disas: implement host disassembly output for aarch64

2013-09-16 Thread Claudio Fontana
Hallo Andreas, On 16.09.2013 08:53, Andreas Färber wrote: > Am 11.09.2013 15:08, schrieb Claudio Fontana: >> use C++ libvixl to implement output, for now only enabled for the host output >> disasm, since we don't have the aarch64 target yet. >> >> Signed-off-by: Claudio Fontana >> --- >> configu

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Fam Zheng
On Mon, 09/16 11:24, Alex Bligh wrote: > > On 16 Sep 2013, at 10:51, Fam Zheng wrote: > > > On Mon, 09/16 11:44, Paolo Bonzini wrote: > >> Il 16/09/2013 10:59, Daniel P. Berrange ha scritto: > The init function of dynamic module is no longer with > __attribute__((constructor)) as static

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Gerd Hoffmann
Hi, > With this patch, a module will not be able to use the module_init macro > twice. I am not sure this is an acceptable limitation, especially if we > do not have a dependency system within modules and/or load them with > G_MODULE_LOCAL/RTLD_LOCAL. Exactly. To modularize spice we need eith

Re: [Qemu-devel] Block Filters

2013-09-16 Thread Benoît Canet
Le Monday 16 Sep 2013 à 15:41:45 (+0800), Fam Zheng a écrit : > On Sun, 09/15 20:10, Benoît Canet wrote: > > Le Friday 06 Sep 2013 à 11:55:38 (+0200), Kevin Wolf a écrit : > > > Am 06.09.2013 um 11:18 hat Fam Zheng geschrieben: > > > > On Fri, 09/06 10:45, Kevin Wolf wrote: > > > > > Am 06.09.2013

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 12:57, Gerd Hoffmann ha scritto: > Hi, > >> With this patch, a module will not be able to use the module_init macro >> twice. I am not sure this is an acceptable limitation, especially if we >> do not have a dependency system within modules and/or load them with >> G_MODULE_LOCAL/

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Alex Bligh
On 16 Sep 2013, at 11:38, Paolo Bonzini wrote: > No, librbd does need to be there for the other symbols that are not weak > (e.g. rbd_aio_read). This approach cannot be "taken to the limit", i.e. > removing the librbd dependency altogether. For example: > > xx.c: > int f(void) > { > retu

Re: [Qemu-devel] [PATCH 08/12] qemu-img: conditionally zero out target on convert

2013-09-16 Thread Paolo Bonzini
Il 13/09/2013 21:48, Peter Lieven ha scritto: > Am 13.09.2013 20:25, schrieb Eric Blake: >> On 09/13/2013 04:36 AM, Paolo Bonzini wrote: >>> Il 13/09/2013 12:25, Peter Lieven ha scritto: if the target has_zero_init = 0, but supports efficiently writing zeroes by unmapping we call bdrv_zer

Re: [Qemu-devel] [PATCH] qdev-monitor: Avoid exiting when hot-plugging two devices with the same bootindex value

2013-09-16 Thread Gleb Natapov
On Mon, Sep 16, 2013 at 12:54:39PM +0300, Marcel Apfelbaum wrote: > On Thu, 2013-09-12 at 13:04 +0200, Markus Armbruster wrote: > > Marcel Apfelbaum writes: > > > > > On Thu, 2013-09-12 at 11:43 +0200, Markus Armbruster wrote: > > >> Paolo Bonzini writes: > > >> > > >> > Il 11/09/2013 20:26, Ma

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 12:00:47PM +0100, Alex Bligh wrote: > > However, even if you don't use weak symbols, we could simply dlopen() > a fixed list of modules known at compile time from a single directory > (because we also know at compile which executable needs what, e.g. > that qemu-img doesn't

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 02:50:24PM +0800, Fam Zheng wrote: > Added three types of modules: > > typedef enum { > MODULE_LOAD_BLOCK = 0, > MODULE_LOAD_UI, > MODULE_LOAD_NET, > MODULE_LOAD_MAX, > } module_load_type; > > and their loading function: > > voi

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 13:00, Alex Bligh ha scritto: > > On 16 Sep 2013, at 11:38, Paolo Bonzini wrote: > >> No, librbd does need to be there for the other symbols that are not weak >> (e.g. rbd_aio_read). This approach cannot be "taken to the limit", i.e. >> removing the librbd dependency altogether. F

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Alex Bligh
On 16 Sep 2013, at 12:04, Daniel P. Berrange wrote: > On Mon, Sep 16, 2013 at 12:00:47PM +0100, Alex Bligh wrote: >> >> However, even if you don't use weak symbols, we could simply dlopen() >> a fixed list of modules known at compile time from a single directory >> (because we also know at compi

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Fam Zheng
On Mon, 09/16 12:30, Paolo Bonzini wrote: > Il 16/09/2013 12:21, Daniel P. Berrange ha scritto: > > On Mon, Sep 16, 2013 at 12:18:54PM +0200, Paolo Bonzini wrote: > >> Il 16/09/2013 12:14, Daniel P. Berrange ha scritto: > >>> On Mon, Sep 16, 2013 at 12:09:47PM +0200, Paolo Bonzini wrote: > Il

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Alex Bligh
On 16 Sep 2013, at 12:08, Paolo Bonzini wrote: > But the reason to do modularization is not to "cope with different > versions of libraries". In fact that's a problem that Fam's patches do > not solve at all. The reason to do modularization is to make libraries > optional, i.e. let them be comp

Re: [Qemu-devel] [PATCH 05/12] block: add logical block provisioning information to BlockDriverInfo

2013-09-16 Thread Peter Lieven
On 13.09.2013 13:45, Paolo Bonzini wrote: Il 13/09/2013 12:44, Peter Lieven ha scritto: On 13.09.2013 12:34, Paolo Bonzini wrote: Il 13/09/2013 12:25, Peter Lieven ha scritto: +/* maximum number of sectors that can be discarded at once */ +int max_discard; +/* maximum number of sec

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 13:29, Fam Zheng ha scritto: > An idea for single .so file: > - before loads a .so, an empty initializer list is created. > - module_init adds a __attribute__((constructor)) function, which appends > its real initializer to the initializer list. So this function is >

Re: [Qemu-devel] [PATCH 05/12] block: add logical block provisioning information to BlockDriverInfo

2013-09-16 Thread Paolo Bonzini
Il 16/09/2013 13:30, Peter Lieven ha scritto: > On 13.09.2013 13:45, Paolo Bonzini wrote: >> Il 13/09/2013 12:44, Peter Lieven ha scritto: >>> On 13.09.2013 12:34, Paolo Bonzini wrote: Il 13/09/2013 12:25, Peter Lieven ha scritto: > +/* maximum number of sectors that can be discarded a

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Fam Zheng
On Mon, 09/16 13:33, Paolo Bonzini wrote: > Il 16/09/2013 13:29, Fam Zheng ha scritto: > > An idea for single .so file: > > - before loads a .so, an empty initializer list is created. > > - module_init adds a __attribute__((constructor)) function, which > > appends > > its real initi

[Qemu-devel] cpufreq and QEMU guests

2013-09-16 Thread Benoît Canet
Hello, I know a cloud provider worried about the fact that the /proc/cpuinfo of his guests give a bogus frequency to his customer. QEMU and the guests kernel currently have no way to reflect the host frequency changes to the guests. The customer compute intensive application then read this info

Re: [Qemu-devel] Q35 FreeBSD install status

2013-09-16 Thread Bret Ketchum
As a workaround until I can uncover the qemu/FreeBSD AHCI/SATA issue, I simply create a legacy IDE to hang the CD and HD from: -device piix4-ide \ -drive if=none,file=/home/ehv/images/FreeBSD-9.1-RELEASE-amd64-dvd1.iso,id=drive-ide0-0-0 \ -device ide-cd,bus=ide.0,drive=drive-i

Re: [Qemu-devel] [PATCH] qom: helper macro for adding read-only properties

2013-09-16 Thread Michael S. Tsirkin
On Mon, Sep 16, 2013 at 08:32:13AM +0200, Andreas Färber wrote: > Am 15.09.2013 19:23, schrieb Michael S. Tsirkin: > > Add a helper macro for adding read-only properties, that works in the > > common case where the value is a constant. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > I'

Re: [Qemu-devel] Q35 FreeBSD install status

2013-09-16 Thread Michael S. Tsirkin
On Mon, Sep 16, 2013 at 12:28:41PM +, Bret Ketchum wrote: > > As a workaround until I can uncover the qemu/FreeBSD AHCI/SATA issue, I > simply create a legacy IDE to hang the CD and HD from: > > -device piix4-ide \ > -drive > if=none,file=/home/ehv/images/FreeBSD-9.1-RELEASE-am

Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading

2013-09-16 Thread Gerd Hoffmann
On Mo, 2013-09-16 at 12:05 +0100, Daniel P. Berrange wrote: > On Mon, Sep 16, 2013 at 02:50:24PM +0800, Fam Zheng wrote: > > Added three types of modules: > > > > typedef enum { > > MODULE_LOAD_BLOCK = 0, > > MODULE_LOAD_UI, > > MODULE_LOAD_NET, > > MODULE_LOAD_

[Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-09-16 Thread alex . bennee
From: Alex Bennée Commit 9b8c69243 broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see integrator_led_set in the kernel code). Relying on a varying implementation detail is incorrect

[Qemu-devel] [PATCH v2 0/0] integrator: fix Linux boot failure by emulating dbg

2013-09-16 Thread alex . bennee
Hi, I've applied the review comments from Peter. Alex.

Re: [Qemu-devel] Q35 FreeBSD install status

2013-09-16 Thread Gerd Hoffmann
On Mo, 2013-09-16 at 12:28 +, Bret Ketchum wrote: > As a workaround until I can uncover the qemu/FreeBSD AHCI/SATA issue, I > simply create a legacy IDE to hang the CD and HD from: > > -device piix4-ide \ No need for that one. > -drive > if=none,file=/home/ehv/images/FreeBSD-9

[Qemu-devel] [PATCH RESEND] ivshmem: allow the sharing of hugepages

2013-09-16 Thread Damien Millescamps
This patch permits to share memory areas that do not specifically belong to /dev/shm. In such case, the file must be already present when launching qemu. A use case for this patch is sharing huge pages available through a hugetlbfs mountpoint. Signed-off-by: Damien Millescamps --- docs/specs/iv

Re: [Qemu-devel] Q35 FreeBSD install status

2013-09-16 Thread Bret Ketchum
Tried that - looks like FreeBSD expects to use MSI for AHCI devices which does not appear to be supported in q35. -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Monday, September 16, 2013 7:55 AM To: Bret Ketchum Cc: Qemu-devel@nongnu.org; m...@redhat.com Su

Re: [Qemu-devel] Q35 FreeBSD install status

2013-09-16 Thread Bret Ketchum
Syslog suggests the interface is brought down then up but no interrupt at the irq assigned. Need to enable more debug and make sure the interrupt is wired properly. -Original Message- From: Michael S. Tsirkin [mailto:m...@redhat.com] Sent: Monday, September 16, 2013 7:36 AM To: Bre

Re: [Qemu-devel] Q35 FreeBSD install status

2013-09-16 Thread Bret Ketchum
Qemu says the IRQ is 11: Bus 0, device 3, function 0: Ethernet controller: PCI device 8086:100e IRQ 11. BAR0: 32 bit memory at 0xfebc [0xfebd]. BAR1: I/O at 0xc040 [0xc07f]. BAR6: 32 bit memory at 0x [0x0003fffe]. id "" Free

Re: [Qemu-devel] [PATCH RESEND] ivshmem: allow the sharing of hugepages

2013-09-16 Thread Daniel P. Berrange
On Mon, Sep 16, 2013 at 02:56:15PM +0200, Damien Millescamps wrote: > This patch permits to share memory areas that do not specifically belong to > /dev/shm. In such case, the file must be already present when launching qemu. > > A use case for this patch is sharing huge pages available through a

[Qemu-devel] [PATCH] linux-user: Emulate SOCK_CLOEXEC/NONBLOCK if unavailable

2013-09-16 Thread edgar . iglesias
From: "Edgar E. Iglesias" If the host lacks support for SOCK_CLOEXEC or SOCK_NONBLOCK, try to emulate them with fcntl() FD_CLOEXEC and O_NONBLOCK. Signed-off-by: Edgar E. Iglesias --- linux-user/syscall.c | 48 +--- 1 file changed, 45 insertions(+)

[Qemu-devel] [PATCH v3] ivshmem: allow the sharing of hugepages

2013-09-16 Thread Damien Millescamps
This patch permits to share memory areas that do not specifically belong to /dev/shm. In such case, the file must be already present when launching qemu. A new parameter 'file' has been added to specify the file to use. A use case for this patch is sharing huge pages available through a hugetlbfs

Re: [Qemu-devel] [PATCH RESEND] ivshmem: allow the sharing of hugepages

2013-09-16 Thread Damien Millescamps
On 09/16/2013 03:07 PM, Daniel P. Berrange wrote: > IME this kind of auto-magical fallback behaviour is a bad idea. If we > want to support non-SHM files for the ivshmem device, then it should > be done with an explicit command line property. eg where we currently > have a 'size' and 'shm' property

Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-09-16 Thread Christian Borntraeger
On 05/09/13 13:25, Alexander Graf wrote: > > On 01.08.2013, at 16:12, Jason J. Herne wrote: > >> From: "Jason J. Herne" >> >> Define new SCLP codes to improve code readability. >> >> Signed-off-by: Jason J. Herne >> --- >> hw/s390x/sclp.c |2 +- >> include/hw/s390x/sclp.h |8

Re: [Qemu-devel] [PATCH v4 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Eric Blake
On 09/16/2013 02:25 AM, Sebastian Ottlik wrote: > SO_REUSEADDR should be avoided on Windows but is desired on other operating > systems. So instead of setting it we call socket_set_fast_reuse that will > result > in the appropriate behaviour on all operating systems. > > Signed-off-by: Sebastian

Re: [Qemu-devel] [PATCH v4 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Eric Blake
On 09/16/2013 02:25 AM, Sebastian Ottlik wrote: > SO_REUSEADDR should be avoided on Windows but is desired on other operating > systems. So instead of setting it we call socket_set_fast_reuse that will > result > in the appropriate behaviour on all operating systems. > > An exception to this rule

Re: [Qemu-devel] [PATCH v4 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
On 16.09.2013 16:03, Eric Blake wrote: On 09/16/2013 02:25 AM, Sebastian Ottlik wrote: SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating system

Re: [Qemu-devel] [PATCH v2 1/4] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-09-16 Thread Alexey Kardashevskiy
On 09/10/2013 02:15 PM, Alexey Kardashevskiy wrote: > On 08/16/2013 08:35 AM, Andreas Färber wrote: >> Set the expected values for POWER7, POWER7+, POWER8 and POWER5+. >> Note that POWER5+ and POWER7+ are intentionally lacking the '+', so the >> lack of a POWER7P family constitutes no problem. >> >

[Qemu-devel] [PATCH v5 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. An exception to this rule are multicast sockets where it is sensible to have multiple

[Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-09-16 Thread Sebastian Ottlik
This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with calls to the new function socket_set_fast_reuse. On Windows systems the default behaviour is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR can still be set but results in undesired behaviour in mo

[Qemu-devel] [PATCH v5 5/5] util: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- util/qemu-sockets.c |6 +++--- 1 file change

[Qemu-devel] [PATCH v5 4/5] slirp: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- slirp/misc.c |3 +-- slirp/socket.c |

[Qemu-devel] [PATCH v5 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik --- gdbstub.c |6 ++ 1 file changed, 2 inser

[Qemu-devel] [PATCH v5 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR

2013-09-16 Thread Sebastian Ottlik
If a socket is closed it remains in TIME_WAIT state for some time. On operating systems using BSD sockets the endpoint of the socket may not be reused while in this state unless SO_REUSEADDR was set on the socket. On windows on the other hand the default behaviour is to allow reuse (i.e. identical

Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-09-16 Thread Jason J. Herne
On 09/16/2013 09:53 AM, Christian Borntraeger wrote: On 05/09/13 13:25, Alexander Graf wrote: On 01.08.2013, at 16:12, Jason J. Herne wrote: From: "Jason J. Herne" Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne --- hw/s390x/sclp.c |2 +- includ

Re: [Qemu-devel] [Bug 1224444] [NEW] virtio-serial loses writes when used over virtio-mmio

2013-09-16 Thread Laszlo Ersek (Red Hat)
On 09/12/13 14:04, Richard Jones wrote: > + -chardev socket,path=/home/rjones/d/libguestfs/tmp/libguestfsLa9dE2/guestfsd.sock,id=channel0 \ Is this a socket that libguestfs pre-creates on the host-side? > the socket is never added to any poll/ppoll syscall, so it's no > wonder that qemu neve

Re: [Qemu-devel] cpufreq and QEMU guests

2013-09-16 Thread Alexander Graf
Am 16.09.2013 um 07:15 schrieb Benoît Canet : > > Hello, > > I know a cloud provider worried about the fact that the /proc/cpuinfo of his > guests give a bogus frequency to his customer. > > QEMU and the guests kernel currently have no way to reflect the host frequency > changes to the guests

Re: [Qemu-devel] cpufreq and QEMU guests

2013-09-16 Thread Benoît Canet
Le Monday 16 Sep 2013 à 09:39:10 (-0500), Alexander Graf a écrit : > > > Am 16.09.2013 um 07:15 schrieb Benoît Canet : > > > > > Hello, > > > > I know a cloud provider worried about the fact that the /proc/cpuinfo of his > > guests give a bogus frequency to his customer. > > > > QEMU and the

[Qemu-devel] [PATCH] xhci: Fix number of streams allocated when using streams

2013-09-16 Thread Hans de Goede
According to the xhci spec the total number of streams is 2 ^ (MaxPStreams + 1), and this is also how the Linux xhci driver uses this field. Signed-off-by: Hans de Goede --- hw/usb/hcd-xhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.

Re: [Qemu-devel] [PATCH v4 06/33] tcg-aarch64: Merge enum aarch64_srr_opc with AArch64Insn

2013-09-16 Thread Richard Henderson
On 09/16/2013 12:56 AM, Claudio Fontana wrote: >> > case INDEX_op_shl_i64: >> > case INDEX_op_shl_i32: >> > -if (c2) {/* LSL / UBFM Wd, Wn, (32 - m) */ >> > +if (c2) { >> > tcg_out_shl(s, ext, a0, a1, a2); >> > -} else {/* LSL / LSL

Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-09-16 Thread Jason J. Herne
On 09/16/2013 10:43 AM, Alexander Graf wrote: Am 16.09.2013 um 09:29 schrieb "Jason J. Herne" : On 09/16/2013 09:53 AM, Christian Borntraeger wrote: On 05/09/13 13:25, Alexander Graf wrote: On 01.08.2013, at 16:12, Jason J. Herne wrote: From: "Jason J. Herne" Define new SCLP codes to i

[Qemu-devel] [Question] memory: AddressSpace backed by single IO MemoryRegion

2013-09-16 Thread Marcel Apfelbaum
Hi all, I have an AddressSpace backed by a single MemoryRegion which is initiated using memory_region_init_io (has ops). Once I enable it, I get an assertion: exec.c:806: register_subpage: Assertion `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed. Here is the pseudo-cod

  1   2   >