Re: [Qemu-devel] [PATCH]virtio: virtqueue_get_avail_bytes: fix desc_pa when loop over the indirect descriptor table

2013-08-25 Thread Michael S. Tsirkin
On Thu, Aug 22, 2013 at 02:47:16PM +0800, yinyin wrote: > virtqueue_get_avail_bytes: when found a indirect desc, we need loop over it. >/* loop over the indirect descriptor table */ >indirect = 1; >max = vring_desc_len(desc_pa, i) / sizeof(VRingDesc); >

Re: [Qemu-devel] [PATCH v3] usb/dev-hid: Modified usb-tablet category from Misc to Input

2013-08-25 Thread Michael S. Tsirkin
On Thu, Aug 22, 2013 at 04:44:11PM +0300, Marcel Apfelbaum wrote: > usb-tablet device was wrongly assigned to Misc category > > Reported-by: Markus Armbruster > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Andreas Färber Reviewed-by: Michael S. Tsirkin > --- > Changes from v2: > - Correct

[Qemu-devel] [Bug 1209180] Re: hw/usb/core.c:415: usb_handle_packet: Assertion `p->ep->type != 3 || (dev->flags & (1 << USB_DEV_FLAG_IS_HOST))' failed

2013-08-25 Thread Lekensteyn
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1209180 Title: hw/usb/core.c:415: usb_handle_packet: Assertion `p->ep->type != 3 ||

[Qemu-devel] [PATCH v3] target-i386: Fix segment cache dump

2013-08-25 Thread Tobias Markus
When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default operation size bit (D/B bit) is not set for Long Mode Data Segments since there are only Data Segments in Long Mode and no explicit 16/32/64-bit Descriptors. This patch fixes this by checking the Long Mode Active bit of the hidd

Re: [Qemu-devel] [PATCH v4] usb/dev-hid: Modified usb-tablet category from Misc to Input

2013-08-25 Thread Michael S. Tsirkin
On Thu, Aug 22, 2013 at 08:11:36PM +0300, Marcel Apfelbaum wrote: > usb-tablet device was wrongly assigned to Misc category > > Reported-by: Markus Armbruster > Cc: qemu-sta...@nongnu.org > Signed-off-by: Marcel Apfelbaum > Reviewed-by: Andreas Färber Reviewed-by: Michael S. Tsirkin > --- >

Re: [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-25 Thread Michael S. Tsirkin
On Thu, Aug 22, 2013 at 11:50:43AM -0500, Anthony Liguori wrote: > Laszlo Ersek writes: > > > On 08/21/13 19:06, Paolo Bonzini wrote: > >> Il 21/08/2013 19:07, Michael S. Tsirkin ha scritto: > > > >>> NACK > >> > >> You know that a single developer's NACK counts nothing (it can be you, > >> it c

Re: [Qemu-devel] [PATCH 3/3] pvpanic: rename to isa-pvpanic

2013-08-25 Thread Michael S. Tsirkin
On Thu, Aug 22, 2013 at 02:41:51PM +0200, Paolo Bonzini wrote: > Il 22/08/2013 14:43, Laszlo Ersek ha scritto: > > On 08/21/13 19:06, Paolo Bonzini wrote: > >> Il 21/08/2013 19:07, Michael S. Tsirkin ha scritto: > > > >>> NACK > >> > >> You know that a single developer's NACK counts nothing (it ca

Re: [Qemu-devel] [PATCH v4 0/6] Clean up bogus default boot order

2013-08-25 Thread Michael S. Tsirkin
On Fri, Aug 23, 2013 at 02:31:49PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Fri, Aug 16, 2013 at 01:13:44PM +0200, arm...@redhat.com wrote: > >> From: Markus Armbruster > >> > >> The first five patches are admittedly related to the stated purpose of > >> this seri

Re: [Qemu-devel] [PATCH v3 6/6] hw: Clean up bogus default boot order

2013-08-25 Thread Michael S. Tsirkin
On Thu, Aug 22, 2013 at 01:24:50PM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Aug 22, 2013 at 10:39:34AM +0200, Markus Armbruster wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Wed, Aug 21, 2013 at 06:01:45PM +0200, Markus Armbruster wrote: > >> >> "Mi

Re: [Qemu-devel] [RFC PATCH] Introduce RCU-enabled DQs (v2)

2013-08-25 Thread Mike Day
Paolo Bonzini writes: > Just a couple of questions, one of them on the new macro... > >> +/* prior to publication of the elm->prev->next value, some list >> + * readers may still see the removed element when following >> + * the antecedent's next pointer. >> + */ >> + >> +#define QLIST_REMOVE_R

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-25 Thread Gleb Natapov
On Thu, Aug 08, 2013 at 05:55:09PM +0200, Andreas Färber wrote: > Hi Peter, > > Am 08.08.2013 14:51, schrieb Peter Maydell: > > [I missed this KVM call but the stuff about -cpu host ties into > > an issue we've been grappling with for ARM KVM, so it seems > > a reasonable jumping-off-point.] > >

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-25 Thread Gleb Natapov
On Fri, Aug 09, 2013 at 02:53:30PM -0300, Eduardo Habkost wrote: > On Thu, Aug 08, 2013 at 12:29:07PM -0700, Christoffer Dall wrote: > > On Thu, Aug 08, 2013 at 08:05:11PM +0100, Peter Maydell wrote: > > > On 8 August 2013 19:39, Christoffer Dall > > > wrote: > > > > FWIW, from the kernel point o

Re: [Qemu-devel] -cpu host (was Re: KVM call minutes for 2013-08-06)

2013-08-25 Thread Gleb Natapov
On Thu, Aug 08, 2013 at 07:20:41PM +0100, Peter Maydell wrote: > >> For ARM you can't get at feature info of the host from userspace > >> (unless you want to get into parsing /proc/cpuinfo), so my current > >> idea is to have KVM_ARM_VCPU_INIT support a target-cpu-type > >> which means "whatever ho

Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-25 Thread Gleb Natapov
On Wed, Aug 14, 2013 at 09:28:10PM +0200, Alexander Graf wrote: > > On 14.08.2013, at 20:28, Christoffer Dall wrote: > > > On Wed, Aug 14, 2013 at 08:21:54PM +0200, Alexander Graf wrote: > >> > >> On 14.08.2013, at 20:18, Christoffer Dall wrote: > >> > >>> On Wed, Aug 14, 2013 at 07:44:25PM +02

[Qemu-devel] [PATCH 5/9] bswap.h: Remove be32_to_cpupu()

2013-08-25 Thread Peter Maydell
Replace the legacy be32_to_cpupu() with ldl_be_p(). Signed-off-by: Peter Maydell --- hw/net/e1000.c |2 +- include/qemu/bswap.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index fdb1f89..f770f08 100644 --- a/hw/net/e1000.c

[Qemu-devel] [PATCH 1/9] bswap.h: Remove cpu_to_le16wu()

2013-08-25 Thread Peter Maydell
Replace the legacy cpu_to_le16wu() with stw_le_p(). Signed-off-by: Peter Maydell --- hw/acpi/core.c |4 ++-- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index b07feda..

[Qemu-devel] [PATCH 9/9] bswap.h: Remove cpu_to_32wu()

2013-08-25 Thread Peter Maydell
Replace the legacy cpu_to_32wu() with stl_p(). Signed-off-by: Peter Maydell --- hw/display/vga_template.h | 14 -- include/qemu/bswap.h |7 --- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/hw/display/vga_template.h b/hw/display/vga_template.h index f

[Qemu-devel] [PATCH 7/9] bswap.h: Remove cpu_to_be32wu()

2013-08-25 Thread Peter Maydell
Replace the legacy cpu_to_be32wu() with stl_be_p(). Signed-off-by: Peter Maydell --- hw/block/cdrom.c |6 +++--- hw/net/e1000.c |3 +-- hw/pci/pcie_aer.c|4 ++-- include/qemu/bswap.h |5 - 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/block/

[Qemu-devel] [PATCH 8/9] bswap.h: Remove cpu_to_be64wu()

2013-08-25 Thread Peter Maydell
Replace the legacy cpu_to_be64wu() with stq_be_p(). Signed-off-by: Peter Maydell --- block/qcow2-cluster.c |2 +- include/qemu/bswap.h |5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index cca76d4..363a725 100644 ---

[Qemu-devel] [PATCH 2/9] bswap.h: Remove cpu_to_le32wu()

2013-08-25 Thread Peter Maydell
Replace the legacy cpu_to_le32wu() with stl_le_p(). Signed-off-by: Peter Maydell --- hw/net/ne2000.c |2 +- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index 31afd28..

[Qemu-devel] [PATCH 3/9] bswap.h: Remove le16_to_cpupu()

2013-08-25 Thread Peter Maydell
Replace the legacy le16_to_cpupu() with lduw_le_p(). Signed-off-by: Peter Maydell --- hw/acpi/core.c |3 +-- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index e84a577..

[Qemu-devel] [PATCH 4/9] bswap.h: Remove le32_to_cpupu()

2013-08-25 Thread Peter Maydell
Replace the legacy le32_to_cpupu() with ldl_le_p(). Signed-off-by: Peter Maydell --- hw/net/ne2000.c |2 +- include/hw/pci/pci.h |2 +- include/qemu/bswap.h |5 - 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c index e7865e9..

[Qemu-devel] [PATCH 6/9] bswap.h: Remove cpu_to_be16wu()

2013-08-25 Thread Peter Maydell
Replace the legacy cpu_to_be16wu() with stw_be_p(). Signed-off-by: Peter Maydell --- hw/block/cdrom.c |4 ++-- hw/ide/atapi.c | 16 hw/net/e1000.c | 19 --- include/qemu/bswap.h |5 - 4 files changed, 18 insertions(+), 26 deletions

Re: [Qemu-devel] [RFC 0/2] target-arm: Provide '-cpu host' when running KVM

2013-08-25 Thread Peter Maydell
On 25 August 2013 15:42, Gleb Natapov wrote: > Are ARM cpu features not enumerable and the only way to know what is > supported by a core is by its id? I do see feature registers in the > spec, so why wouldn't we want to be able to disable/enable features > individually? It's complicated. There a

[Qemu-devel] [PATCH 0/9] Remove legacy unaligned bswap functions

2013-08-25 Thread Peter Maydell
The bswap.h header includes a set of "legacy unaligned functions" that (since commit c732a52d3 at the beginning of this year) are just wrappers for underlying {ld,st} functions. The legacy functions aren't used in many places, so just replace all their uses with uses of the new-style {ld,st} functi

Re: [Qemu-devel] [PATCH 2/5] hw: arm_gic: Introduce GIC_SET_PRIORITY macro

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 21:10, Christoffer Dall wrote: > To make the code slightly cleaner to look at and make the save/restore > code easier to understand, introduce this macro to set the priority of > interrupts. > > Signed-off-by: Christoffer Dall > --- > hw/intc/arm_gic.c |6 +- > hw/

Re: [Qemu-devel] [PATCH 5/5] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 21:10, Christoffer Dall wrote: > Save and restore the ARM KVM VGIC state from the kernel. We rely on > QEMU to marshal the GICState data structure and therefore simply > synchronize the kernel state with the QEMU emulated state in both > directions. > > We take some care on th

Re: [Qemu-devel] [PATCH 0/5] Support arm-gic-kvm save/restore

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 21:10, Christoffer Dall wrote: > Implement support to save/restore the ARM KVM VGIC state from the > kernel. The basic appraoch is to transfer state from the in-kernel VGIC > to the emulated arm-gic state representation and let the standard QEMU > vmstate save/restore handle sa

[Qemu-devel] [PATCH V20 1/8] docs: document for add-cow file format

2013-08-25 Thread Dong Xu Wang
Document for add-cow format, the usage and spec of add-cow are introduced. v19->v20: 1) fix AddCowMeta's logic while add-cow is being written. v18-v19: 1) backing_fmt and image_fmt NUL-terminated. 2) other fix. V17->V18: 1) remove version field. 2) header size is maximum value and cluster size v

[Qemu-devel] [PATCH V20 3/8] qed_read_string to bdrv_read_string

2013-08-25 Thread Dong Xu Wang
Make qed_read_string function to a common interface, so move it to block.c. Signed-off-by: Dong Xu Wang --- block.c | 27 +++ block/qed.c | 34 -- include/block/block.h | 2 ++ 3 files changed, 33 insertions(+), 30

[Qemu-devel] [PATCH V20 0/7] add-cow file format

2013-08-25 Thread Dong Xu Wang
It will introduce a new file format: add-cow. The add-cow file format makes it possible to perform copy-on-write on top of a raw disk image. When we know that no backing file clusters remain visible (e.g. we have streamed the entire image and copied all data from the backing file), then it is pos

[Qemu-devel] [PATCH V20 8/8] qemu-iotests: add add-cow iotests support

2013-08-25 Thread Dong Xu Wang
This patch will use qemu-iotests to test add-cow file format. v17-v18: 1) add 037 and 038 tests. Signed-off-by: Dong Xu Wang --- tests/qemu-iotests/017 | 2 +- tests/qemu-iotests/020 | 2 +- tests/qemu-iotests/037 | 2 +- tests/qemu-iotests/038 | 2 +- tests/qemu-iot

[Qemu-devel] [PATCH V20 2/8] make path_has_protocol non static

2013-08-25 Thread Dong Xu Wang
We will use path_has_protocol outside block.c, so just make it public. Reviewed-by: Michael Roth Signed-off-by: Dong Xu Wang --- block.c | 2 +- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index fcc8870..b2711e9 1006

[Qemu-devel] [PATCH V20 4/8] rename qcow2_cache functions to block_cache

2013-08-25 Thread Dong Xu Wang
This patch only rename qcow2_cache* functions to block_cache*, did not touch other code. Signed-off-by: Dong Xu Wang --- block/qcow2-cache.c| 70 +- block/qcow2-cluster.c | 48 +- block/qcow2-refcount.c | 42 +++

Re: [Qemu-devel] [PATCH] hw: fix to display correct memory size

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 15:57, Yongbok Kim wrote: > A parenthesis placed inappropriately caused displaying > wrong memory size bigger than 4GB. > > Signed-off-by: Yongbok Kim Acked-by: Alexander Graf I think this should easily go in through the qemu-trivial queue. Alex > --- > hw/mips/mips_malt

[Qemu-devel] [PATCH V20 7/8] add-cow file format core code

2013-08-25 Thread Dong Xu Wang
add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. v18->v19: 1) add aio parallel write support. 2) fix flush method. v17-v18: 1) use error_report, not fprintf. 2) remove version field from header. 3) header_size is MAX(cluster_size, 4096). 4) i

[Qemu-devel] [PATCH V20 5/8] move qcow2-cache.c to block-cache.c

2013-08-25 Thread Dong Xu Wang
Will use block cache as common interface, so move qcow2-cache.c to block-cache.c, Signed-off-by: Dong Xu Wang --- block/Makefile.objs | 3 +- block/block-cache.c | 323 block/qcow2-cache.c | 323 --

[Qemu-devel] [PATCH V20 6/8] Make block-cache.c be common interface

2013-08-25 Thread Dong Xu Wang
To use block-cache.c be common cache interface, we need to add some parameter to identify cache's type. Define a struct named BlockTableType, pass BlockTableType and table size parameters to block cache initialization function. v17-v18: 1) move struct to source file. 2) cluster_size->table_size.

Re: [Qemu-devel] [PATCH] hw: fix to display correct memory size

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 17:20, Andreas Färber wrote: > Am 23.08.2013 16:57, schrieb Yongbok Kim: >> A parenthesis placed inappropriately caused displaying >> wrong memory size bigger than 4GB. >> >> Signed-off-by: Yongbok Kim >> --- >> hw/mips/mips_malta.c |2 +- >> hw/mips/mips_r4k.c|2 +

Re: [Qemu-devel] [PATCH] spapr-vscsi: Report error on unsupported MAD requests

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 10:23, Alexey Kardashevskiy wrote: > The existing driver just dropped unsupported requests. This adds error > responses to those unhandled requests. > > Signed-off-by: Alexey Kardashevskiy > --- > hw/scsi/spapr_vscsi.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 del

Re: [Qemu-devel] [RFC] TCG unit testing

2013-08-25 Thread Richard Henderson
On 08/23/2013 01:42 PM, Stefan Weil wrote: > Am 23.08.2013 21:47, schrieb Richard Henderson: >> I've been thinking for a while about how to reliably test TCG backends, and >> maybe how to do regression testing on them. Having to begin the test from a >> guest binary, especially considering the vas

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 10:22, Alexey Kardashevskiy wrote: > From: Nikunj A Dadhania > > This implements capabilities exchange between host and client. > As at the moment no capability is supported, put zero flags everywhere > and return. > > Signed-off-by: Nikunj A Dadhania > Signed-off-by: Alexey

Re: [Qemu-devel] [RFC] TCG unit testing

2013-08-25 Thread Peter Maydell
On 23 August 2013 22:18, Richard Henderson wrote: > E.g. tci never defines TCG_TARGET_CALL_ALIGN_ARGS. Thus if one uses tci on an > ARM host, a helper like > > DEF_HELPER_FLAGS_2(store_fpcr, TCG_CALL_NO_RWG, void, env, i64) > > will have its arguments loaded into TCI's R0, R1, R2, and thence into

Re: [Qemu-devel] [PATCH for-1.6? v2 21/21] qtest: Prepare QOM machine tests

2013-08-25 Thread Alexander Graf
On 05.08.2013, at 14:27, Andreas Färber wrote: > Instantiate all [*] machines per target, so that they get a bit of test > coverage at all. This has proven helpful during QOM refactorings. > > [*] ppcemb target contains some non-working non-embedded machines, and > ppc405 CPUs are not available

Re: [Qemu-devel] [PATCH for-1.6? v2 21/21] qtest: Prepare QOM machine tests

2013-08-25 Thread Peter Maydell
On 5 August 2013 14:27, Andreas Färber wrote: > +static const char *arm_machines[] = { > +"integratorcp", > +"versatilepb", > +"versatileab", > +"lm3s811evb", > +"lm3s6965evb", > +"collie", [etc] I'd rather have these tests than not have them, but can't we autodetect the

Re: [Qemu-devel] [PATCH for-1.6? v2 21/21] qtest: Prepare QOM machine tests

2013-08-25 Thread Andreas Färber
Am 25.08.2013 19:22, schrieb Alexander Graf: > > On 05.08.2013, at 14:27, Andreas Färber wrote: > >> Instantiate all [*] machines per target, so that they get a bit of test >> coverage at all. This has proven helpful during QOM refactorings. >> >> [*] ppcemb target contains some non-working non-e

Re: [Qemu-devel] [PATCH for-1.6? v2 21/21] qtest: Prepare QOM machine tests

2013-08-25 Thread Andreas Färber
Am 25.08.2013 19:33, schrieb Peter Maydell: > On 5 August 2013 14:27, Andreas Färber wrote: >> +static const char *arm_machines[] = { >> +"integratorcp", >> +"versatilepb", >> +"versatileab", >> +"lm3s811evb", >> +"lm3s6965evb", >> +"collie", > > [etc] > > I'd rather have

Re: [Qemu-devel] [PATCH] spapr-pci: rework MSI/MSIX

2013-08-25 Thread Alexander Graf
On 12.07.2013, at 08:38, Alexey Kardashevskiy wrote: > On the sPAPR platform a guest allocates MSI/MSIX vectors via RTAS > hypercalls which return global IRQ numbers to a guest so it only > operates with those and never touches MSIMessage. > > Therefore MSIMessage handling is completely hidden i

Re: [Qemu-devel] [PATCH -V3 4/4] target-ppc: Use #define for max slb entries

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Instead of opencoding 64 use MAX_SLB_ENTRIES. We don't update the kernel > header here. Ah, here you're fixing up the hardcoded 64 :). Could you please check whether ARRAY_SIZE() works in all these as well? If not

Re: [Qemu-devel] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > With kvm enabled, we store the hash page table information in the hypervisor. > Use ioctl to read the htab contents. Without this we get the below error when > trying to read the guest address > > (gdb) x/10 do_for

Re: [Qemu-devel] [PATCH -V3 3/4] target-ppc: Check for error on address translation in memsave command

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > When we translate the virtual address to physical check for error. > > Signed-off-by: Aneesh Kumar K.V I think this change is sane, but I'd really prefer to see an ack from (or get this applied by) Luiz. Alex

Re: [Qemu-devel] [PATCH -V3 1/4] target-ppc: Update slb array with correct index values.

2013-08-25 Thread Alexander Graf
On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Without this, a value of rb=0 and rs=0 results in replacing the 0th > index. This can be observed when using gdb remote debugging support. > > (gdb) x/10i do_fork > 0xc0085330 :Cannot access memory

Re: [Qemu-devel] [RFC] TCG unit testing

2013-08-25 Thread Stefan Weil
Am 23.08.2013 23:18, schrieb Richard Henderson: > > I don't see how TCI really comes into this except as Yet Another Backend to be > tested. Indeed, such unit testing could show that TCI is in fact broken wrt > helpers, depending on the host abi. TCI is special because it is the only TCG backend

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-25 Thread Benjamin Herrenschmidt
On Sun, 2013-08-25 at 17:41 +0100, Alexander Graf wrote: > > While I don't think any harm could happen from it, this could lead to > a potential timing attack where we read and write from different > locations in memory if the guest swizzles the request while we're > processing it. > > It's certa

Re: [Qemu-devel] [RFC PATCH] Introduce RCU-enabled DQs (v2)

2013-08-25 Thread Mathieu Desnoyers
Hi Mike, * Mike Day (ncm...@ncultra.org) wrote: > Add RCU-enabled variants on the existing bsd DQ facility. Each Q > operation has the same interface as the existing (non-RCU) > version. Also, each operation is implemented as macro for now. > > Using the RCU-enabled DQ, existing DQ users will be

Re: [Qemu-devel] [Qemu-ppc] [PATCH -V3 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-08-25 Thread Benjamin Herrenschmidt
On Sun, 2013-08-25 at 19:32 +0100, Alexander Graf wrote: > > + * At this point we are only interested in reading only bolted > entries > > + */ > > +ghf.flags = KVM_GET_HTAB_BOLTED_ONLY; > > +ghf.start_index = index; > > +htab_fd = kvm_vm_ioctl(kvm_state, KVM_PPC_GET_HTAB_FD, &g

Re: [Qemu-devel] [PATCH] spapr-vscsi: Adding VSCSI capabilities

2013-08-25 Thread Benjamin Herrenschmidt
On Sun, 2013-08-25 at 17:41 +0100, Alexander Graf wrote: > > +vcap = &req->iu.mad.capabilities; > > +rc = spapr_vio_dma_read(&s->vdev, be64_to_cpu(vcap->buffer), > > +&cap, > be16_to_cpu(vcap->common.length)); > > While I don't think any harm could happen from i

Re: [Qemu-devel] [PATCH -V3 3/4] target-ppc: Check for error on address translation in memsave command

2013-08-25 Thread Andreas Färber
Am 25.08.2013 20:32, schrieb Alexander Graf: > > On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" >> >> When we translate the virtual address to physical check for error. >> >> Signed-off-by: Aneesh Kumar K.V > > I think this change is sane, but I'd really prefer

Re: [Qemu-devel] [PATCH -V3 4/4] target-ppc: Use #define for max slb entries

2013-08-25 Thread Andreas Färber
Am 25.08.2013 20:33, schrieb Alexander Graf: > > On 23.08.2013, at 06:20, Aneesh Kumar K.V wrote: > >> From: "Aneesh Kumar K.V" >> >> Instead of opencoding 64 use MAX_SLB_ENTRIES. We don't update the kernel >> header here. > > Ah, here you're fixing up the hardcoded 64 :). Could you please chec

[Qemu-devel] [PATCH 16/47] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_lx60 conditionally

2013-08-25 Thread Ákos Kovács
Add the new CONFIG_* values to default-config/xtensa*-softmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/xtensa-softmmu.mak |3 +++ default-configs/xtensaeb-softmmu.mak |3 +++ hw/xtensa/Makefile.objs |4 ++-- 3 files changed, 8 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 01/47] rules.mak: New logical functions

2013-08-25 Thread Ákos Kovács
lnot, land, lor, lif, eq, ne, isempty, notempty functions added Example usage: obj-$(call lor,$(CONFIG_LINUX),$(CONFIG_BSD)) += feature.o Signed-off-by: Ákos Kovács --- rules.mak | 16 1 file changed, 16 insertions(+) diff --git a/rules.mak b/rules.mak index 4499745..7e8e

[Qemu-devel] [RFC PATCH 00/47] Describing patchset

2013-08-25 Thread Ákos Kovács
This is a request-for-comments patchset on the kconfig integration. The patchset contains a 'scripts/kconfig' git submodule (PATCH 5, kconfig-frontends v3.10) with the necessary modifications in the Makefile.objs (PATCHES 6-16). It also contains the Kconfig files themselves (PATCHES 17-45) for

[Qemu-devel] [PATCH 02/47] Makefile.target: CONFIG_NO_* variables removed

2013-08-25 Thread Ákos Kovács
CONFIG_NO_* variables replaced with the lnot logical function Signed-off-by: Ákos Kovács --- Makefile.target |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Makefile.target b/Makefile.target index 9a49852..bbc668b 100644 --- a/Makefile.target +++ b/Makefile.target

[Qemu-devel] [PATCH 04/47] scripts/kconfig: kconfig-frontends submodule added

2013-08-25 Thread Ákos Kovács
Add the kconfig-frontends to scripts/, picking version 3.10. Signed-off-by: Ákos Kovács --- .gitmodules |3 +++ scripts/kconfig |1 + 2 files changed, 4 insertions(+) create mode 16 scripts/kconfig diff --git a/.gitmodules b/.gitmodules index d7e3f3c..754fc03 100644 --- a/.gitm

[Qemu-devel] [PATCH 20/47] hw/block/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/block/Kconfig | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 hw/block/Kconfig diff --git a/hw/block/Kconfig b/hw/block/Kconfig new file mode 100644 index 000..400cab3 --- /dev/null +++ b/hw/block/Kconfig @@ -0

[Qemu-devel] [PATCH 19/47] hw/audio/Kconfig: Add audio Kconfig

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/audio/Kconfig | 41 + 1 file changed, 41 insertions(+) create mode 100644 hw/audio/Kconfig diff --git a/hw/audio/Kconfig b/hw/audio/Kconfig new file mode 100644 index 000..bb6c31d --- /dev/null +++ b/hw/audio/Kconfi

[Qemu-devel] [PATCH 03/47] default-configs/: CONFIG_GDBSTUB_XML removed

2013-08-25 Thread Ákos Kovács
Makefile.target: Build gdbstub-xml.o only when TARGET_XML_FILES is not empty. Signed-off-by: Ákos Kovács --- Makefile.target |2 +- default-configs/arm-linux-user.mak|2 -- default-configs/arm-softmmu.mak |1 - default-configs/armeb-linux-u

[Qemu-devel] [PATCH 23/47] hw/cpu/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/cpu/Kconfig | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 hw/cpu/Kconfig diff --git a/hw/cpu/Kconfig b/hw/cpu/Kconfig new file mode 100644 index 000..d90cbe5 --- /dev/null +++ b/hw/cpu/Kconfig @@ -0,0 +1,11 @@ +config ARM11MPCORE +

[Qemu-devel] [PATCH 27/47] hw/i2c/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/i2c/Kconfig | 10 ++ 1 file changed, 10 insertions(+) create mode 100644 hw/i2c/Kconfig diff --git a/hw/i2c/Kconfig b/hw/i2c/Kconfig new file mode 100644 index 000..eaf17cc --- /dev/null +++ b/hw/i2c/Kconfig @@ -0,0 +1,10 @@ +config VERSATILE_I2C

[Qemu-devel] [PATCH 06/47] hw/alpha/Makefile.objs: Build objects depending on CLIPPER

2013-08-25 Thread Ákos Kovács
Set CONFIG_CLIPPER as default for default-configs/alpha-softmmu.mak Signed-off-by: Ákos Kovács --- default-configs/alpha-softmmu.mak |2 ++ hw/alpha/Makefile.objs|2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/default-configs/alpha-softmmu.mak b/default-

[Qemu-devel] [PATCH 29/47] hw/input/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/input/Kconfig | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 hw/input/Kconfig diff --git a/hw/input/Kconfig b/hw/input/Kconfig new file mode 100644 index 000..9114433 --- /dev/null +++ b/hw/input/Kconfig @@ -0,0 +1,23 @@

[Qemu-devel] [PATCH 10/47] hw/microblaze/Makefile.objs: Create configs for petalogix boards

2013-08-25 Thread Ákos Kovács
CONFIG_PETALOGIX_* configs added to default-configs/microblaze-softmmu.mak and default-configs/microblazeel-softmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/microblaze-softmmu.mak |3 +++ default-configs/microblazeel-softmmu.mak |3 +++ hw/microblaze/Makefile.objs

[Qemu-devel] [PATCH 35/47] hw/pci/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/pci/Kconfig |8 1 file changed, 8 insertions(+) create mode 100644 hw/pci/Kconfig diff --git a/hw/pci/Kconfig b/hw/pci/Kconfig new file mode 100644 index 000..31a755d --- /dev/null +++ b/hw/pci/Kconfig @@ -0,0 +1,8 @@ +config PCI +bool + +m

[Qemu-devel] [PATCH 33/47] hw/net/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/net/Kconfig | 74 1 file changed, 74 insertions(+) create mode 100644 hw/net/Kconfig diff --git a/hw/net/Kconfig b/hw/net/Kconfig new file mode 100644 index 000..19ca549 --- /dev/null +++ b/hw/net/K

[Qemu-devel] [PATCH 11/47] hw/mips/Makefile.objs: Create CONFIG_* for mips boards

2013-08-25 Thread Ákos Kovács
Add the new configs to default-configs/mips*-sofmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/mips-softmmu.mak |6 ++ default-configs/mips64-softmmu.mak |6 ++ default-configs/mips64el-softmmu.mak |6 ++ default-configs/mipsel-softmmu.mak |6 ++

[Qemu-devel] [PATCH 12/47] hw/ppc/Makefile.objs: Build all boards conditinally

2013-08-25 Thread Ákos Kovács
CONFIG_PPC405, CONFIG_PPC440, CONFIG_PPC4XX, CONFIG_PREP, CONFIG_MAC_OLDWORLD, CONFIG_MAC_NEWWORLD, CONFIG_VIRTEX configuration options created for default-configs/ppc*-softmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/ppc-softmmu.mak|8 default-configs/ppc64-softmmu.m

[Qemu-devel] [PATCH 14/47] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created

2013-08-25 Thread Ákos Kovács
CONFIG_LEON3 added to default-configs/sparc-softmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/sparc-softmmu.mak |2 ++ hw/sparc/Makefile.objs|3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/default-configs/sparc-softmmu.mak b/default-configs/sp

[Qemu-devel] [PATCH 36/47] hw/pci-bridge/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/pci-bridge/Kconfig |3 +++ 1 file changed, 3 insertions(+) create mode 100644 hw/pci-bridge/Kconfig diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig new file mode 100644 index 000..1d23483 --- /dev/null +++ b/hw/pci-bridge/Kconfig @@ -0,0 +1,3

[Qemu-devel] [PATCH 13/47] hw/sh4/Makefile.objs: Build sh4 boards conditionally

2013-08-25 Thread Ákos Kovács
New CONFIG_* varibales created for r2d and shix boards and added to the default-configs/sh4*-softmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/sh4-softmmu.mak |3 +++ default-configs/sh4eb-softmmu.mak |3 +++ hw/sh4/Makefile.objs |4 ++-- 3 files changed, 8 i

[Qemu-devel] [PATCH 42/47] hw/tpm/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/tpm/Kconfig |6 ++ 1 file changed, 6 insertions(+) create mode 100644 hw/tpm/Kconfig diff --git a/hw/tpm/Kconfig b/hw/tpm/Kconfig new file mode 100644 index 000..8c9fb24 --- /dev/null +++ b/hw/tpm/Kconfig @@ -0,0 +1,6 @@ +config TPM_TIS +bool +

[Qemu-devel] [PATCH 17/47] hw/9pfs/Kconfig: Add 9pfs Kconfig

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/9pfs/Kconfig |2 ++ 1 file changed, 2 insertions(+) create mode 100644 hw/9pfs/Kconfig diff --git a/hw/9pfs/Kconfig b/hw/9pfs/Kconfig new file mode 100644 index 000..f16ffed --- /dev/null +++ b/hw/9pfs/Kconfig @@ -0,0 +1,2 @@ +config OPEN_BY_HANDLE +

[Qemu-devel] [PATCH 15/47] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/lm32/Makefile.objs |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/lm32/Makefile.objs b/hw/lm32/Makefile.objs index ea6418a..c394186 100644 --- a/hw/lm32/Makefile.objs +++ b/hw/lm32/Makefile.objs @@ -1,3 +1,3 @@ # LM32 boards -obj-y

[Qemu-devel] [PATCH 45/47] hw/Kconfig: Add the main Kconfig for hw/

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/Kconfig | 27 +++ 1 file changed, 27 insertions(+) create mode 100644 hw/Kconfig diff --git a/hw/Kconfig b/hw/Kconfig new file mode 100644 index 000..23e062b --- /dev/null +++ b/hw/Kconfig @@ -0,0 +1,27 @@ +source "hw/9pfs/Kconfig"

[Qemu-devel] [PATCH 21/47] hw/char/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/char/Kconfig | 24 1 file changed, 24 insertions(+) create mode 100644 hw/char/Kconfig diff --git a/hw/char/Kconfig b/hw/char/Kconfig new file mode 100644 index 000..7ad0bd3 --- /dev/null +++ b/hw/char/Kconfig @@ -0,0 +1,24 @@ +co

[Qemu-devel] [PATCH 18/47] hw/arm/Kconfig: Add ARM Kconfig

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/arm/Kconfig | 235 1 file changed, 235 insertions(+) create mode 100644 hw/arm/Kconfig diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig new file mode 100644 index 000..c72b949 --- /dev/null +++ b/hw/arm/

[Qemu-devel] [PATCH 22/47] hw/core/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/core/Kconfig | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 hw/core/Kconfig diff --git a/hw/core/Kconfig b/hw/core/Kconfig new file mode 100644 index 000..8c275f7 --- /dev/null +++ b/hw/core/Kconfig @@ -0,0 +1,11 @@ +config EMPTY_SL

[Qemu-devel] [PATCH 25/47] hw/dma/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/dma/Kconfig | 25 + 1 file changed, 25 insertions(+) create mode 100644 hw/dma/Kconfig diff --git a/hw/dma/Kconfig b/hw/dma/Kconfig new file mode 100644 index 000..1ef6b47 --- /dev/null +++ b/hw/dma/Kconfig @@ -0,0 +1,25 @@ +config

[Qemu-devel] [PATCH 24/47] hw/display/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/display/Kconfig | 84 1 file changed, 84 insertions(+) create mode 100644 hw/display/Kconfig diff --git a/hw/display/Kconfig b/hw/display/Kconfig new file mode 100644 index 000..1f6f386 --- /dev/null ++

[Qemu-devel] [PATCH 26/47] hw/gpio/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/gpio/Kconfig |5 + 1 file changed, 5 insertions(+) create mode 100644 hw/gpio/Kconfig diff --git a/hw/gpio/Kconfig b/hw/gpio/Kconfig new file mode 100644 index 000..820c76f --- /dev/null +++ b/hw/gpio/Kconfig @@ -0,0 +1,5 @@ +config MAX7310 +boo

[Qemu-devel] [PATCH 28/47] hw/ide/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/ide/Kconfig | 49 + 1 file changed, 49 insertions(+) create mode 100644 hw/ide/Kconfig diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig new file mode 100644 index 000..c73af88 --- /dev/null +++ b/hw/ide/Kconfig

[Qemu-devel] [PATCH 09/47] hw/m68k/Makefile.objs: Conditionally build boards

2013-08-25 Thread Ákos Kovács
CONFIG_AN5206, CONFIG_DUMMY_M68K, CONFIG_MCF5206, CONFIG_MCF5208 make variables created for m68k boards, and added to default-configs/m86k-softmmu.mak. Signed-off-by: Ákos Kovács --- default-configs/m68k-softmmu.mak |3 +++ hw/m68k/Makefile.objs|7 --- 2 files changed, 7

[Qemu-devel] [PATCH 30/47] hw/intc/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/intc/Kconfig | 28 1 file changed, 28 insertions(+) create mode 100644 hw/intc/Kconfig diff --git a/hw/intc/Kconfig b/hw/intc/Kconfig new file mode 100644 index 000..c4dec79 --- /dev/null +++ b/hw/intc/Kconfig @@ -0,0 +1,28 @@

[Qemu-devel] [PATCH 31/47] hw/isa/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/isa/Kconfig | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 hw/isa/Kconfig diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig new file mode 100644 index 000..8b6baaf --- /dev/null +++ b/hw/isa/Kconfig @@ -0,0

[Qemu-devel] [PATCH 37/47] hw/pci-host/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/pci-host/Kconfig | 36 1 file changed, 36 insertions(+) create mode 100644 hw/pci-host/Kconfig diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig new file mode 100644 index 000..12014f5 --- /dev/null +++ b/hw/pci-h

[Qemu-devel] [PATCH 32/47] hw/misc/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/misc/Kconfig | 67 +++ 1 file changed, 67 insertions(+) create mode 100644 hw/misc/Kconfig diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig new file mode 100644 index 000..5a6477f --- /dev/null +++ b/hw/mi

[Qemu-devel] [PATCH 34/47] hw/nvram/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/nvram/Kconfig |5 + 1 file changed, 5 insertions(+) create mode 100644 hw/nvram/Kconfig diff --git a/hw/nvram/Kconfig b/hw/nvram/Kconfig new file mode 100644 index 000..1235c6e --- /dev/null +++ b/hw/nvram/Kconfig @@ -0,0 +1,5 @@ +config DS1225Y +

[Qemu-devel] [PATCH 38/47] hw/scsi/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/scsi/Kconfig | 21 + 1 file changed, 21 insertions(+) create mode 100644 hw/scsi/Kconfig diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig new file mode 100644 index 000..5e493a6 --- /dev/null +++ b/hw/scsi/Kconfig @@ -0,0 +1,21 @@ +menu

[Qemu-devel] [PATCH 41/47] hw/timer/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/timer/Kconfig | 80 ++ 1 file changed, 80 insertions(+) create mode 100644 hw/timer/Kconfig diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig new file mode 100644 index 000..5d55137 --- /dev/null +++ b/hw

[Qemu-devel] [PATCH 39/47] hw/sd/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/sd/Kconfig | 23 +++ 1 file changed, 23 insertions(+) create mode 100644 hw/sd/Kconfig diff --git a/hw/sd/Kconfig b/hw/sd/Kconfig new file mode 100644 index 000..eaef4f7 --- /dev/null +++ b/hw/sd/Kconfig @@ -0,0 +1,23 @@ +config SD +

[Qemu-devel] [PATCH 40/47] hw/ssi/Kconfig: Add Kconfig file

2013-08-25 Thread Ákos Kovács
Signed-off-by: Ákos Kovács --- hw/ssi/Kconfig | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 hw/ssi/Kconfig diff --git a/hw/ssi/Kconfig b/hw/ssi/Kconfig new file mode 100644 index 000..4f89fd2 --- /dev/null +++ b/hw/ssi/Kconfig @@ -0,0 +1,14 @@ +config SSI +b

  1   2   >